Re: [PATCH V2] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-03 Thread Guennadi Liakhovetski
--- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-06-03 Thread Guennadi Liakhovetski
hsync_act_low; + u8 vsync_act_low; + u8 pclk_act_falling; + u8 isi_full_mode; + u32 data_width_flags; + /* Using for ISI_CFG1 */ + u32 frate; +}; + +#endif /* __ATMEL_ISI_H__ */ -- 1.6.3.3 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http

Re: [PATCH] drivers/media: fix uninitialized variable

2011-06-03 Thread Guennadi Liakhovetski
in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH] media: soc_camera_video_start - type should be const

2011-06-06 Thread Guennadi Liakhovetski
; if (!icd-dev.parent) -- 1.7.0.4 Thanks for the patchm unfortunately, you're not the first: http://www.mail-archive.com/linux-media@vger.kernel.org/msg32245.html and not even the second;) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open

[PATCH/RFC] V4L: add media bus configuration subdev operations

2011-06-06 Thread Guennadi Liakhovetski
, in such cases subdevice drivers return bitmasks with all respective bits set. When a set-configuration operation is called, it has to specify a non-ambiguous configuration. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- This change

Re: [PATCH/RFC] V4L: add media bus configuration subdev operations

2011-06-06 Thread Guennadi Liakhovetski
...@mm-sol.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- This change would allow a re-use of soc-camera and standard subdev drivers. It is a modified and extended version of http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/29408 therefore

Re: [PATCH/RFC 1/4] V4L: add three new ioctl()s for multi-size videobuffer management

2011-06-06 Thread Guennadi Liakhovetski
On Wed, 18 May 2011, Sakari Ailus wrote: Hi Guennadi and Laurent, Guennadi Liakhovetski wrote: On Wed, 18 May 2011, Laurent Pinchart wrote: On Tuesday 17 May 2011 07:52:28 Sakari Ailus wrote: Guennadi Liakhovetski wrote: [snip] What about making it possible to pass an array

Re: [PATCH/RFC] V4L: add media bus configuration subdev operations

2011-06-06 Thread Guennadi Liakhovetski
Hi Sergio On Mon, 6 Jun 2011, Aguirre, Sergio wrote: Hi Guennadi, Thanks for the patch. On Mon, Jun 6, 2011 at 7:31 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Add media bus configuration types and two subdev operations to get supported mediabus configurations and to set

[PATCH] V4L: mx3_camera: remove redundant calculations

2011-06-06 Thread Guennadi Liakhovetski
soc_camera core now performs the standard .bytesperline and .sizeimage calculations internally, no need to duplicate in drivers. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/mx3_camera.c | 12 1 files changed, 0 insertions(+), 12 deletions

[PATCH] V4L: pxa_camera: remove redundant calculations

2011-06-06 Thread Guennadi Liakhovetski
soc_camera core now performs the standard .bytesperline and .sizeimage calculations internally, no need to duplicate in drivers. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/pxa_camera.c | 24 +--- 1 files changed, 13 insertions(+), 11

[PATCH] V4L: mx2_camera: .try_fmt shouldn't fail

2011-06-06 Thread Guennadi Liakhovetski
If the user is requesting too large a frame, instead of failing select an acceptable geometry, preserving the requested aspect ratio. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Attention: completely untested! Please, give it a spin on an i.MX25, specifically, please, try

[PATCH] V4L: sh_mobile_ceu_camera: remove redundant calculations

2011-06-06 Thread Guennadi Liakhovetski
soc_camera core now performs the standard .bytesperline and .sizeimage calculations internally, no need to duplicate in drivers. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/sh_mobile_ceu_camera.c |5 - 1 files changed, 0 insertions(+), 5 deletions

[PATCH] V4L: tw9910: remove bogus ENUMINPUT implementation

2011-06-06 Thread Guennadi Liakhovetski
tw9910 is a TV decoder, it doesn't have a tuner. Besides, the .enum_input soc-camera operation is optional and normally not needed. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/tw9910.c | 11 --- 1 files changed, 0 insertions(+), 11 deletions

[PATCH] V4L: soc-camera: MIPI flags are not sensor flags

2011-06-06 Thread Guennadi Liakhovetski
SOCAM_MIPI_[1234]LANE flags are not board-specific sensor flags, they are bus configuration flags. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- include/media/soc_camera.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/media

[PATCH 2/2] V4L: mt9m111: switch to v4l2-subdev .s_power() method

2011-06-06 Thread Guennadi Liakhovetski
Eliminate soc-camera specific .suspend() and .restore() methods in favour of the standard v4l2-subdev .s_power() method Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Please, test both these mt9m111 patches. drivers/media/video/mt9m111.c | 51

[PATCH] V4L: soc-camera: remove now unused soc-camera .enum_input() operation

2011-06-06 Thread Guennadi Liakhovetski
Also this functionality should be implemented, if needed, using the v4l2-subdev API. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/soc_camera.c | 13 - include/media/soc_camera.h |1 - 2 files changed, 4 insertions(+), 10 deletions

Re: [PATCH] V4L: tw9910: remove bogus ENUMINPUT implementation

2011-06-06 Thread Guennadi Liakhovetski
and test. Thanks Guennadi On Mon, 6 Jun 2011, Guennadi Liakhovetski wrote: tw9910 is a TV decoder, it doesn't have a tuner. Besides, the .enum_input soc-camera operation is optional and normally not needed. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media

Re: [PATCH] V4L: pxa_camera: remove redundant calculations

2011-06-06 Thread Guennadi Liakhovetski
On Mon, 6 Jun 2011, Robert Jarzmik wrote: On 06/06/2011 07:02 PM, Guennadi Liakhovetski wrote: soc_camera core now performs the standard .bytesperline and .sizeimage calculations internally, no need to duplicate in drivers. Haven't I noticed that this patch is twofold : - the calculation

Re: [PATCH/RFC] V4L: add media bus configuration subdev operations

2011-06-06 Thread Guennadi Liakhovetski
On Mon, 6 Jun 2011, Sylwester Nawrocki wrote: Hi Guennadi, On 06/06/2011 02:31 PM, Guennadi Liakhovetski wrote: Add media bus configuration types and two subdev operations to get supported mediabus configurations and to set a specific configuration. Subdevs can support several

Re: [PATCH] V4L: tw9910: remove bogus ENUMINPUT implementation

2011-06-07 Thread Guennadi Liakhovetski
player, and it works well. But I just played video. Is this test OK for you ? Yes, very good, thanks very much! Can I add your Tested-by to the patch? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from

Re: [PATCH] V4L: soc-camera: MIPI flags are not sensor flags

2011-06-07 Thread Guennadi Liakhovetski
regards Kassey Application Processor Systems Engineering, Marvell Technology Group Ltd. Shanghai, China. On Tue, Jun 7, 2011 at 1:17 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: SOCAM_MIPI_[1234]LANE flags are not board-specific sensor flags, they are bus configuration flags

Re: [PATCH 1/7] marvell-cam: Move cafe-ccic into its own directory

2011-06-07 Thread Guennadi Liakhovetski
/video/marvell-ccic/cafe_ccic.c delete mode 100644 drivers/media/video/ov7670.h create mode 100644 include/media/ov7670.h --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-07 Thread Guennadi Liakhovetski
Armada 610 application + processors (and likely beyond). This is the controller found + in OLPC XO 1.75 systems. + Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line

Re: [RFC] Refactor the cafe_ccic driver and add Armada 610 support

2011-06-07 Thread Guennadi Liakhovetski
-- Best regards Kassey Application Processor Systems Engineering, Marvell Technology Group Ltd. Shanghai, China. --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH V2] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-07 Thread Guennadi Liakhovetski
On Tue, 7 Jun 2011, Kassey Lee wrote: Guennadi thanks for your comments very much! I will update the V3 patch later. On Fri, Jun 3, 2011 at 6:22 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Ok, this will be converted to use a common cafe code, but I'll comment

[PATCH 0/3 v2] V4L: pxa-camera: minor updates

2011-06-07 Thread Guennadi Liakhovetski
go to Robert for spotting that:) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH 1/3 v2] V4L: pxa_camera: remove redundant calculations

2011-06-07 Thread Guennadi Liakhovetski
soc_camera core now performs the standard .bytesperline and .sizeimage calculations internally, no need to duplicate in drivers. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/pxa_camera.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff

[PATCH 2/3 v2] V4L: pxa-camera: try to force progressive video format

2011-06-07 Thread Guennadi Liakhovetski
The pxa-camera driver only supports progressive video so far. Passing down to the client the same format, as what the user has requested can result in interlaced video, even if the client supports both. This patch avoids such cases. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

[PATCH 3/3 v2] V4L: pxa-camera: switch to using subdev .s_power() core operation

2011-06-07 Thread Guennadi Liakhovetski
soc-camera specific .suspend() and .resume() methods are deprecated and should be replaced by the subdev standard .s_power() operation. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/pxa_camera.c | 16 1 files changed, 12 insertions(+), 4

Re: [PATCH 1/2] V4L: mt9m111: propagate higher level abstraction down in functions

2011-06-07 Thread Guennadi Liakhovetski
On Mon, 6 Jun 2011, Robert Jarzmik wrote: On 06/06/2011 07:20 PM, Guennadi Liakhovetski wrote: It is more convenient to propagate the higher level abstraction - the struct mt9m111 object into functions and then retrieve a pointer to the i2c client, if needed, than to do the reverse

[PATCH v2] V4L: mt9m111: propagate higher level abstraction down in functions

2011-06-07 Thread Guennadi Liakhovetski
It is more convenient to propagate the higher level abstraction - the struct mt9m111 object into functions and then retrieve a pointer to the i2c client, if needed, than to do the reverse. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: also convert mt9m111_setfmt_

[PATCH v2] V4L: soc-camera: remove several now unused soc-camera client operations

2011-06-07 Thread Guennadi Liakhovetski
, and the only host driver, using them has been pxa-camera. Now that both those drivers have been converted to the standard subdev .s_power() operation, .suspend() and .resume() can be removed. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: also remove .suspend() and .resume

Re: [PATCH/RFC 1/4] V4L: add three new ioctl()s for multi-size videobuffer management

2011-06-07 Thread Guennadi Liakhovetski
On Mon, 6 Jun 2011, Sakari Ailus wrote: Hi Guennadi, On Mon, Jun 06, 2011 at 03:10:54PM +0200, Guennadi Liakhovetski wrote: On Wed, 18 May 2011, Sakari Ailus wrote: Hi Guennadi and Laurent, Guennadi Liakhovetski wrote: On Wed, 18 May 2011, Laurent Pinchart wrote

Re: [PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-07 Thread Guennadi Liakhovetski
On Tue, 7 Jun 2011, Jonathan Corbet wrote: On Tue, 7 Jun 2011 09:44:45 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: +obj-$(CONFIG_VIDEO_MMP_CAMERA) += marvell-ccic/ Wouldn't it be better to have only one symbol, selecting the marvell-ccic directory

Re: [PATCH] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-08 Thread Guennadi Liakhovetski
Jon's CCIC code stabilises a bit and you rebase your driver on top of it? Of course, you can also work together with Jon on the drivers to get them faster in shape and in a way, suitable fou you both. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http

Re: [PATCH v4] [media] at91: add Atmel Image Sensor Interface (ISI) support

2011-06-08 Thread Guennadi Liakhovetski
; +}; + +#endif /* __ATMEL_ISI_H__ */ -- 1.6.3.3 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [beagleboard] Re: [PATCH v7 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-08 Thread Guennadi Liakhovetski
: Failed to power on device: -5 [ 159.898956] isp_register_subdev_group: Unable to register subdev mt9p031 Have you (or anyone else) seen that issue ? I build in both statically to avoid that problem. I used modules and it worked for me. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D

Re: [PATCH] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-09 Thread Guennadi Liakhovetski
On Thu, 9 Jun 2011, Kassey Lee wrote: Guennadi, Jon: thanks! we hope to work out a common ccic core, and then re base the code. ok, so, we agree, that I don't review your last version, ok? Thanks Guennadi : On Wed, Jun 8, 2011 at 7:30 PM, Guennadi Liakhovetski g.liakhovet

Re: [PATCH 3.0] soc_camera: OMAP1: stop falling back to dma-sg on single -ENOMEM

2011-06-09 Thread Guennadi Liakhovetski
. - */ - if (!sg_mode q-int_ops-mmap_mapper != omap1_cam_mmap_mapper) { - pcdev-mmap_mapper = q-int_ops-mmap_mapper; - q-int_ops-mmap_mapper = omap1_cam_mmap_mapper; - } } static int omap1_cam_reqbufs(struct soc_camera_device *icd, --- Guennadi

Re: soc_camera_set_fmt in soc_camera_open

2011-06-10 Thread Guennadi Liakhovetski
Group Ltd. Shanghai, China. --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH] media: DVB_NET must depend on DVB_CORE

2011-06-10 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index dc61895..c2ee0aa 100644 --- a/drivers/media/Kconfig +++ b/drivers/media/Kconfig

Re: soc_camera_set_fmt in soc_camera_open

2011-06-13 Thread Guennadi Liakhovetski
On Mon, 13 Jun 2011, Kassey Lee wrote: On Fri, Jun 10, 2011 at 5:16 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 10 Jun 2011, Kassey Lee wrote: hi, Guennadi: in drivers/media/video/soc_camera.c static int soc_camera_open(struct file *file

Re: [PATCH 1/2] V4L: mt9m111: propagate higher level abstraction down in functions

2011-06-13 Thread Guennadi Liakhovetski
On Mon, 13 Jun 2011, Robert Jarzmik wrote: On 06/07/2011 12:02 PM, Guennadi Liakhovetski wrote: A general question to you: from your comments I haven't understood: have you also tested the patches or only reviewed them? I had reviewed them so far. Now, please have my : Acked

[PATCH v2] V4L: add media bus configuration subdev operations

2011-06-22 Thread Guennadi Liakhovetski
, in such cases subdevice drivers return bitmasks with all respective bits set. When a set-configuration operation is called, it has to specify a non-ambiguous configuration. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: 1. Removed

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-22 Thread Guennadi Liakhovetski
Hi Hans Thanks for the review, agree to all, except one: On Wed, 22 Jun 2011, Hans Verkuil wrote: On Wednesday, June 22, 2011 23:26:29 Guennadi Liakhovetski wrote: [snip] +static inline unsigned long v4l2_mbus_config_compatible(struct v4l2_mbus_config *cfg

[PULL] a 3.0 fix

2011-06-23 Thread Guennadi Liakhovetski
://linuxtv.org/gliakhovetski/v4l-dvb.git 3.0-rc4-fixes Andre Bartke (1): V4L: mx1-camera: fix uninitialized variable drivers/media/video/mx1_camera.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software

[PATCH v3] V4L: add media bus configuration subdev operations

2011-06-23 Thread Guennadi Liakhovetski
, in such cases subdevice drivers return bitmasks with all respective bits set. When a set-configuration operation is called, it has to specify a non-ambiguous configuration. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v3: addressed

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-23 Thread Guennadi Liakhovetski
Hi Sakari On Fri, 24 Jun 2011, Sakari Ailus wrote: Hi Guennadi, Thanks for the patch. I have a few comments below. On Wed, Jun 22, 2011 at 11:26:29PM +0200, Guennadi Liakhovetski wrote: Add media bus configuration types and two subdev operations to get supported mediabus

Re: [PATCH 1/6 v3] [media] ov9740: Cleanup hex casing inconsistencies

2011-06-24 Thread Guennadi Liakhovetski
= ov9740_set_register, #endif - }; static struct v4l2_subdev_video_ops ov9740_video_ops = { -- 1.7.5.4 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-27 Thread Guennadi Liakhovetski
Hi Sakari On Mon, 27 Jun 2011, Sakari Ailus wrote: On Fri, Jun 24, 2011 at 12:35:03AM +0200, Guennadi Liakhovetski wrote: Hi Sakari Hi Guennadi, On Fri, 24 Jun 2011, Sakari Ailus wrote: Hi Guennadi, Thanks for the patch. I have a few comments below. On Wed, Jun 22

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-27 Thread Guennadi Liakhovetski
On Mon, 27 Jun 2011, Sakari Ailus wrote: Hi Guennadi, On Mon, Jun 27, 2011 at 10:54:11AM +0200, Guennadi Liakhovetski wrote: Hi Sakari On Mon, 27 Jun 2011, Sakari Ailus wrote: On Fri, Jun 24, 2011 at 12:35:03AM +0200, Guennadi Liakhovetski wrote: Hi Sakari Hi Guennadi

[PATCH/RFC v2] V4L: add two new ioctl()s for multi-size videobuffer management

2011-06-27 Thread Guennadi Liakhovetski
A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF and defines respective data structures. Signed-off-by: Guennadi Liakhovetski

Re: [PATCH v3] V4L: add media bus configuration subdev operations

2011-06-28 Thread Guennadi Liakhovetski
On Fri, 24 Jun 2011, Hans Verkuil wrote: On Thursday, June 23, 2011 23:53:11 Guennadi Liakhovetski wrote: Add media bus configuration types and two subdev operations to get supported mediabus configurations and to set a specific configuration. Subdevs can support several configurations

Re: [PATCH] Fix suspend/resume of pxa_camera driver

2011-06-28 Thread Guennadi Liakhovetski
argumentation: On Thu, 31 Jul 2008, Guennadi Liakhovetski wrote: On Wed, 30 Jul 2008, Robert Jarzmik wrote: Guennadi Liakhovetski g.liakhovet...@gmx.de writes: For the camera part, by now, I'm using standard suspend/resume functions of the platform driver (mt9m111.c). It does work

Re: [PATCH/RFC v2] V4L: add two new ioctl()s for multi-size videobuffer management

2011-06-29 Thread Guennadi Liakhovetski
Hi Sakari On Mon, 27 Jun 2011, Sakari Ailus wrote: Hi, Guennadi! Many thanks for the patch! On Mon, Jun 27, 2011 at 05:17:03PM +0200, Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation

[PULL] first soc-camera pull for 3.1

2011-06-29 Thread Guennadi Liakhovetski
hardcoded resolution regs V4L: ov9740: Reorder video and core ops V4L: ov9740: Add suspend/resume Guennadi Liakhovetski (11): V4L: mx3_camera: remove redundant calculations V4L: pxa_camera: remove redundant calculations V4L: pxa-camera: try to force progressive video

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-29 Thread Guennadi Liakhovetski
On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: [snip] If the structures are expected to be generic I somehow feel that a field of flags isn't the best way to describe the configuration of CSI-2 or other busses. Why not to just use a structure with bus type and an union for bus

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-06-29 Thread Guennadi Liakhovetski
On Wed, 29 Jun 2011, Sakari Ailus wrote: Guennadi Liakhovetski wrote: On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: [snip] If the structures are expected to be generic I somehow feel that a field of flags isn't the best way to describe the configuration of CSI-2 or other

Re: [PATCH v2] V4L: add media bus configuration subdev operations

2011-07-01 Thread Guennadi Liakhovetski
On Thu, 30 Jun 2011, Sakari Ailus wrote: On Wed, Jun 29, 2011 at 09:28:06PM +0200, Guennadi Liakhovetski wrote: On Wed, 29 Jun 2011, Sakari Ailus wrote: Guennadi Liakhovetski wrote: On Mon, 27 Jun 2011, Guennadi Liakhovetski wrote: [snip] If the structures

[PATCH v5] V4L: add media bus configuration subdev operations

2011-07-01 Thread Guennadi Liakhovetski
, in such cases subdevice drivers return bitmasks with all respective bits set. When a set-configuration operation is called, it has to specify a non-ambiguous configuration. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Ok, no more RFC

Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-07-04 Thread Guennadi Liakhovetski
@@ +/* + * Driver for OV5642 CMOS Image Sensor from Omnivision + * + * Copyright (C) 2011, Bastian Hecht hec...@gmail.com + * + * Based on Sony IMX074 Camera Driver + * Copyright (C) 2010, Guennadi Liakhovetski g.liakhovet...@gmx.de + * + * Based on Omnivision OV7670 Camera Driver

[PATCH] V4L: sh_mobile_ceu_camera: fix Oops when USERPTR mapping fails

2011-07-04 Thread Guennadi Liakhovetski
If vb2_dma_contig_get_userptr() fails on a videobuffer, driver's .buf_init() method will not be called and the list will not be initialised. Trying to remove an uninitialised element from a list leads to a NULL-dereference. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers

Re: [PATCH] media: initial driver for ov5642 CMOS sensor

2011-07-06 Thread Guennadi Liakhovetski
in its present, is a reason enough to not merge it. Thanks Guennadi Thank you Angela On Mon, Jul 4, 2011 at 3:35 AM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Angela On Sun, 3 Jul 2011, angela wan wrote: Hi, Bastian,    Could the setting in ov5642.c like

Re: [PATCH] [media] videobuf2-dma-contig: return NULL if alloc fails

2011-07-12 Thread Guennadi Liakhovetski
,                        size);                kfree(buf); -               return ERR_PTR(-ENOMEM); +               return NULL;        }        buf-conf = conf; -- 1.7.0.4 How do you think about this fix? Thanks! Jun --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer

Re: Migrate from soc_camera to v4l2

2011-07-13 Thread Guennadi Liakhovetski
have to hack the driver yourself for your local uses by removing all soc-camera specific code and replacing it with your own glue, something along these lines: http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/11486/focus=11691 Thanks Guennadi --- Guennadi Liakhovetski, Ph.D

Re: [RFC] Binning on sensors

2011-07-14 Thread Guennadi Liakhovetski
. Cheers, -- Sakari Ailus sakari.ai...@iki.fi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- Guennadi Liakhovetski, Ph.D. Freelance

Re: [RFC] Binning on sensors

2011-07-14 Thread Guennadi Liakhovetski
On Fri, 15 Jul 2011, Sakari Ailus wrote: Hi Guennadi, Thanks for the comments. On Thu, Jul 14, 2011 at 07:56:10PM +0200, Guennadi Liakhovetski wrote: On Thu, 14 Jul 2011, Sakari Ailus wrote: Hi all, I was thinking about the sensor binning controls. What wrong with just

Re: [RFC] Binning on sensors

2011-07-14 Thread Guennadi Liakhovetski
On Fri, 15 Jul 2011, Sakari Ailus wrote: On Fri, Jul 15, 2011 at 12:02:06AM +0200, Guennadi Liakhovetski wrote: On Fri, 15 Jul 2011, Sakari Ailus wrote: Hi Guennadi, Thanks for the comments. On Thu, Jul 14, 2011 at 07:56:10PM +0200, Guennadi Liakhovetski wrote: On Thu

Re: Migrate from soc_camera to v4l2

2011-07-15 Thread Guennadi Liakhovetski
Hello Teresa On Fri, 15 Jul 2011, Teresa Gamez wrote: Hello Guennadi, Am Mittwoch, den 13.07.2011, 09:14 +0200 schrieb Guennadi Liakhovetski: On Wed, 13 Jul 2011, LBM wrote: my dear Guennadi I'm wrong about that v4l2-int-device,maybe it just V4L2. Now i have

[RFC] soc-camera: remove device and bus abstractions

2011-07-15 Thread Guennadi Liakhovetski
, this is just to let everyone know about my plans, don't know whether I manage it for 3.1, or will have to postpone to 3.2. In any case if anyone has any principle objections against this plan, please shout now! Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer

Re: [PATCH] v4l: mt9v032: Fix Bayer pattern

2011-07-15 Thread Guennadi Liakhovetski
= clamp(ALIGN(crop-rect.width, 2), -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- Guennadi Liakhovetski, Ph.D

[PATCH 1/6] V4L: pxa-camera: switch to using standard PM hooks

2011-07-15 Thread Guennadi Liakhovetski
The pxa-camera driver doesn't need soc-camera specific PM callbacks, switch it to using the standard PM hooks instead. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Tested-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/media/video/pxa_camera.c | 20 1

[PATCH 0/6] soc-camera: moving closer to v4l2 interoperability

2011-07-15 Thread Guennadi Liakhovetski
Before sending a pull-request, a short preview into the forthcoming soc-camera patches. We are becoming thinner, more v4l2-compatible. Paul, unfortunately, two patches touch arch/sh and / or arch/arm/mach-shmobile, can I, please, have your acks for them? Thanks Guennadi --- Guennadi

[PATCH 2/6] V4L: soc-camera: remove now unused soc-camera specific PM hooks

2011-07-15 Thread Guennadi Liakhovetski
soc-camera host drivers shall be implementing their PM, using standard kernel methods, soc-camera specific hooks can die. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/soc_camera.c | 26 -- include/media/soc_camera.h |2

[PATCH 3/6] V4L: soc-camera: group struct field initialisations together

2011-07-15 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/soc_camera.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/soc_camera.c b/drivers/media/video/soc_camera.c index 5084e72..96bed29 100644 --- a/drivers/media/video

[PATCH 5/6] V4L: soc-camera: un-export the soc-camera bus

2011-07-15 Thread Guennadi Liakhovetski
The soc-camera bus is now completely local again. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/soc_camera.c |3 +-- include/media/soc_camera.h |8 +++- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/media/video

Re: [PATCH] v4l: mt9v032: Fix Bayer pattern

2011-07-16 Thread Guennadi Liakhovetski
On Sat, 16 Jul 2011, Laurent Pinchart wrote: Hi Guennadi, On Saturday 16 July 2011 01:11:28 Guennadi Liakhovetski wrote: On Fri, 15 Jul 2011, Laurent Pinchart wrote: Compute crop rectangle boundaries to ensure a GRBG Bayer pattern. Signed-off-by: Laurent Pinchart laurent.pinch

Re: [PATCH 1/5] mt9m111: set inital return values to zero

2011-07-17 Thread Guennadi Liakhovetski
this patch. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 3/5] mt9m111: move lastpage to struct mt9m111 for multi instances

2011-07-17 Thread Guennadi Liakhovetski
Pinchart --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/5] mt9m111: fix missing return value check mt9m111_reg_clear

2011-07-17 Thread Guennadi Liakhovetski
mt9m111_reg_write(client, reg, ret ~data); + if (ret = 0) + ret = mt9m111_reg_write(client, reg, ret ~data); + return ret; } static int mt9m111_set_context(struct i2c_client *client, -- 1.7.5.4 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http

Re: [PATCH 5/5] mt9m111: make use of testpattern

2011-07-17 Thread Guennadi Liakhovetski
= mt9m111_reg_set(client, + MT9M111_TEST_PATTERN_GEN, pattern); + if (!ret) ret = reg_mask(OUTPUT_FORMAT_CTRL2_A, data_outfmt2, mask_outfmt2); -- 1.7.5.4 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer

[PULL] V4L, soc-camera: second pull for 3.1

2011-07-17 Thread Guennadi Liakhovetski
): V4L: initial driver for ov5642 CMOS sensor Guennadi Liakhovetski (8): V4L: pxa-camera: switch to using standard PM hooks V4L: soc-camera: remove now unused soc-camera specific PM hooks V4L: soc-camera: group struct field initialisations together V4L: add media bus

Re: [PATCH v4 4/5] mt9m111: rewrite set_pixfmt

2011-07-17 Thread Guennadi Liakhovetski
) { -- 1.7.5.4 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] v4l: mt9v032: Fix Bayer pattern

2011-07-17 Thread Guennadi Liakhovetski
On Mon, 18 Jul 2011, Laurent Pinchart wrote: On Monday 18 July 2011 00:14:21 Guennadi Liakhovetski wrote: On Sun, 17 Jul 2011, Laurent Pinchart wrote: Hi Guennadi, On Saturday 16 July 2011 23:40:23 Guennadi Liakhovetski wrote: On Sat, 16 Jul 2011, Laurent Pinchart wrote

Re: [PATCH v2] mt9m111: move lastpage to struct mt9m111 for multi instances

2011-07-19 Thread Guennadi Liakhovetski
-iface); + mt9m111-lastpage = -1; + mt9m111-autoexposure = 1; mt9m111-autowhitebalance = 1; -- 1.7.5.4 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe

[PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-20 Thread Guennadi Liakhovetski
A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF and defines respective data structures. Signed-off-by: Guennadi Liakhovetski

[PULL v2] V4L, soc-camera: second pull for 3.1

2011-07-21 Thread Guennadi Liakhovetski
/gliakhovetski/v4l-dvb.git for-3.1 Bastian Hecht (1): V4L: initial driver for ov5642 CMOS sensor Guennadi Liakhovetski (8): V4L: pxa-camera: switch to using standard PM hooks V4L: soc-camera: remove now unused soc-camera specific PM hooks V4L: soc-camera: group struct field

Re: Parallel CMOS Image Sensor with UART Control Interface

2011-07-27 Thread Guennadi Liakhovetski
/majordomo-info.html --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-28 Thread Guennadi Liakhovetski
or nonstd to store the FOURCC (with a slight preference for grayscale), and with either a vmode flag or using the most significant byte of the grayscale/nonstd field to detect FOURCC mode. I believe FB_CAP_FOURCC (or something similar) is needed. Thanks Guennadi --- Guennadi Liakhovetski

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-28 Thread Guennadi Liakhovetski
or after earlier CREATE_BUFS adds more buffers REQBUFS(count=0) frees all buffers REQBUFS(count 0) frees all buffers and allocates new ones Yes, I'll extend the documentation with this. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-28 Thread Guennadi Liakhovetski
Hi Sylwester On Wed, 27 Jul 2011, Sylwester Nawrocki wrote: Hi Gueannadi, On 07/20/2011 10:43 AM, Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

2011-07-28 Thread Guennadi Liakhovetski
On Thu, 28 Jul 2011, Hans Verkuil wrote: On Thursday, July 28, 2011 06:11:38 Pawel Osciak wrote: Hi Guennadi, On Wed, Jul 20, 2011 at 01:43, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2

[PATCH 04/59] V4L: sh_mobile_ceu_camera: remove duplicated code

2011-07-29 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/sh_mobile_ceu_camera.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c index a322f83..aa187a4

[PATCH 01/59] V4L: sh_mobile_ceu_camera: output image sizes must be a multiple of 4

2011-07-29 Thread Guennadi Liakhovetski
CEU can only produce images with 4 pixel aligned width and height. Enforce this alignment, adjust comments and simplify some calculations. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/sh_mobile_ceu_camera.c | 49 +-- 1 files changed

[PATCH 02/59] V4L: sh_mobile_ceu_camera: don't try to improve client scaling, if perfect

2011-07-29 Thread Guennadi Liakhovetski
If the client has managed to configure the precise output format, we don't have to try to further improve it. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/sh_mobile_ceu_camera.c | 21 - 1 files changed, 16 insertions(+), 5 deletions

[PATCH 40/59] V4L: mt9m001: remove superfluous soc-camera client operations

2011-07-29 Thread Guennadi Liakhovetski
Now that all soc-camera hosts have been ported to use V4L2 subdevice mediabus-config operations and soc-camera client bus-parameter operations have been made optional, they can be removed. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/mt9m001.c | 41

[PATCH 42/59] V4L: imx074: remove superfluous soc-camera client operations

2011-07-29 Thread Guennadi Liakhovetski
Now that all soc-camera hosts have been ported to use V4L2 subdevice mediabus-config operations and soc-camera client bus-parameter operations have been made optional, they can be removed. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/imx074.c | 24

[PATCH 37/59] V4L: pxa_camera: convert to the new mbus-config subdev operations

2011-07-29 Thread Guennadi Liakhovetski
Switch from soc-camera specific .{query,set}_bus_param() to V4L2 subdevice .[gs]_mbus_config() operations. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/pxa_camera.c | 140 ++ 1 files changed, 80 insertions(+), 60

[PATCH 35/59] V4L: mt9m001, mt9v022: add a clarifying comment

2011-07-29 Thread Guennadi Liakhovetski
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/mt9m001.c |6 ++ drivers/media/video/mt9v022.c |6 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mt9m001.c b/drivers/media/video/mt9m001.c index 7618b3c

[PATCH 41/59] V4L: mt9m111: remove superfluous soc-camera client operations

2011-07-29 Thread Guennadi Liakhovetski
Now that all soc-camera hosts have been ported to use V4L2 subdevice mediabus-config operations and soc-camera client bus-parameter operations have been made optional, they can be removed. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/mt9m111.c | 17

<    2   3   4   5   6   7   8   9   10   11   >