Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

cameras are all MJPEG-A, as the libv4l decoder uses tinyjpeg library to handle both JPEG and MJPEG. Maybe Hans de Goede knows more about that, and may have actually tested it with different camera models. I've tested the JPG path in libv4l with quite a lot of cameras and sofar it has worked

Re: [PATCH v2] libv4l: Add support for BAYER10P format conversion

Ribalda Delgado Patch looks good to me now: Acked-by: Hans de Goede Regards, Hans --- lib/libv4lconvert/bayer.c | 21 lib/libv4lconvert/libv4lconvert-priv.h | 4 +++ lib/libv4lconvert/libv4lconvert.c | 35 ++ 3 files changed, 60

Re: [PATCH] libv4l: Add support for BAYER10P format conversion

Hi, On 21-09-18 09:40, Ricardo Ribalda Delgado wrote: Hi Hans On Fri, Sep 21, 2018 at 9:38 AM Hans de Goede wrote: Hi, On 20-09-18 22:04, Ricardo Ribalda Delgado wrote: Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P

Re: [PATCH] libv4l: Add support for BAYER10P format conversion

Hi, On 20-09-18 22:04, Ricardo Ribalda Delgado wrote: Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo

Re: Devices with a front and back webcam represented as a single UVC device

Hi, On 18-07-18 13:53, Carlos Garnacho wrote: Hey, On Wed, Jul 11, 2018 at 9:51 PM, Hans de Goede wrote: Hi, On 11-07-18 20:26, Carlos Garnacho wrote: Hi!, On Wed, Jul 11, 2018 at 7:41 PM, Hans de Goede wrote: Hi, On 11-07-18 18:07, Carlos Garnacho wrote: Hi!, On Wed, Jul 11

Re: Devices with a front and back webcam represented as a single UVC device

Hi, On 11-07-18 20:26, Carlos Garnacho wrote: Hi!, On Wed, Jul 11, 2018 at 7:41 PM, Hans de Goede wrote: Hi, On 11-07-18 18:07, Carlos Garnacho wrote: Hi!, On Wed, Jul 11, 2018 at 2:41 PM, Hans de Goede wrote: HI, On 11-07-18 14:08, Laurent Pinchart wrote: Hi Carlos

Re: Devices with a front and back webcam represented as a single UVC device

Hi, On 11-07-18 18:07, Carlos Garnacho wrote: Hi!, On Wed, Jul 11, 2018 at 2:41 PM, Hans de Goede wrote: HI, On 11-07-18 14:08, Laurent Pinchart wrote: Hi Carlos, On Wednesday, 11 July 2018 14:36:48 EEST Carlos Garnacho wrote: On Wed, Jul 11, 2018 at 1:00 PM, Laurent Pinchart wrote

Re: Devices with a front and back webcam represented as a single UVC device

HI, On 11-07-18 14:08, Laurent Pinchart wrote: Hi Carlos, On Wednesday, 11 July 2018 14:36:48 EEST Carlos Garnacho wrote: On Wed, Jul 11, 2018 at 1:00 PM, Laurent Pinchart wrote: On Wednesday, 11 July 2018 11:37:14 EEST Hans de Goede wrote: Hi Laurent, At Guadec Carlos (in the Cc) told me

Devices with a front and back webcam represented as a single UVC device

Hi Laurent, At Guadec Carlos (in the Cc) told me that on his Acer 2-in-1 only the frontcam is working and it seems both are represented by a single UVC USB device. I've told him to check for some v4l control to flip between front and back. Carlos, as I mentioned you can try gtk-v4l ("sudo dnf

Re: [PATCH] [media] gspca: Stop using GFP_DMA for buffers for USB bulk transfers

Hi, On 05/13/2018 07:54 PM, Adam Baker wrote: On 05/05/18 09:22, Hans de Goede wrote: The recent "x86 ZONE_DMA love" discussion at LSF/MM pointed out that some gspca sub-drivvers are using GFP_DMA to allocate buffers which are used for USB bulk transfers, there is absolute

Re: [PATCH 1/4] gspca: convert to vb2

Hi, On 05/13/2018 11:32 AM, Hans Verkuil wrote: On 05/12/2018 08:00 PM, Hans de Goede wrote: Hi Hans, Overall looks good, 1 comment inline. - if (ret == 0 && gspca_dev->sd_desc->dq_callback) { - mutex_lock(_dev->usb_lock); - gspca

Re: [PATCH 1/4] gspca: convert to vb2

ORY_USERPTR) { - if (copy_to_user((__u8 __user *) frame->v4l2_buf.m.userptr, -frame->data, - frame->v4l2_buf.bytesused)) { - gspca_err(gspca_dev, "dqbuf cp to user failed\n"); -

Re: media: uvcvideo: Support realtek's UVC 1.5 device

r full UVC 1.5 compatibility. However, at least the UVC 1.5 Realtek RTS5847/RTS5852 cameras have been reported to work well. Signed-off-by: ming_qian <ming_q...@realsil.com.cn> Tested-by: Kai-Heng Feng <kai.heng.f...@canonical.com> Looks good to me: Reviewed-by: Hans de Goede &l

[PATCH] [media] gspca: Stop using GFP_DMA for buffers for USB bulk transfers

The recent "x86 ZONE_DMA love" discussion at LSF/MM pointed out that some gspca sub-drivvers are using GFP_DMA to allocate buffers which are used for USB bulk transfers, there is absolutely no need for this, drop it. Cc: "Luis R. Rodriguez" <mcg...@kernel.org> Signed-of

Wrong use of GFP_DMA32 in drivers/media/platform/vivid/vivid-osd.c

Hi Hans, et. al., While debugging another GFP_DMA32 problem I did a quick grep for GFP_DMA32 on the kernel, this result stood out: drivers/media/platform/vivid/vivid-osd.c 373:dev->video_vbase = kzalloc(dev->video_buffer_size, GFP_KERNEL | GFP_DMA32); Because it is making the same mistake

[PATCH] libv4lconvert: We support more then 32 bit src fmts now, so use 64 bit bitmasks

. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1508706 Signed-off-by: Hans de Goede <hdego...@redhat.com> --- lib/libv4lconvert/libv4lconvert-priv.h | 2 ++ lib/libv4lconvert/libv4lconvert.c | 9 - 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/libv4lc

[PATCH] stagin: atomisp: Fix oops by unbalanced clk enable/disable call

/0x280 [ 19.811828] driver_probe_device+0x2ff/0x450 Fixes: "staging: atomisp: use clock framework for camera clocks" Signed-off-by: Hans de Goede <hdego...@redhat.com> --- .../media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 7 +++ 1 file changed, 7 insertion

Re: Firmware for staging atomisp driver

Hi, On 05/28/2017 02:30 PM, Hans de Goede wrote: Hi All, I've been trying to get the atomisp driver from staging to work on a couple of devices I have. I started with an Asus T100TA after fixing 2 oopses in the sensor driver there I found out that the BIOS does not allow to put the ISP in PCI

[PATCH] staging: atomisp: Fix endless recursion in hmm_init

for tracking if hmm_init has been called. Not pretty, but it gets the job done, eventually we should be able to remove the hmm_init call from hmm_alloc. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 6 +- 1 file changed, 5 inse

Re: [PATCH v5 2/7] staging: atomisp: Do not call dev_warn with a NULL device

Hi, On 28-05-17 19:08, Alan Cox wrote: On Sun, 28 May 2017 14:30:35 +0200 Hans de Goede <hdego...@redhat.com> wrote: Do not call dev_warn with a NULL device, this silence the following 2 warnings: [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO [ 14.392257]

[PATCH 7/7] staging: atomisp: Make ov2680 driver less chatty

There is no reason for all this printk spamming and certainly not at an error log level. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/staging/media/atomisp/i2c/ov2680.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomi

[PATCH 6/7] staging: atomisp: Ignore errors from second gpio in ov2680 driver

the probing of the driver to file. This commit ignore the return value of the gpio1_ctrl call, fixing this. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/staging/media/atomisp/i2c/ov2680.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/s

[PATCH 1/7] staging: atomisp: Fix calling efivar_entry_get() with unaligned arguments

in the efivar_entry struct we kzalloc as arguments to efivar_entry_get(), which is how all the other callers of efivar_entry_get() do this. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- .../atomisp/platform/intel-mid/atomisp_gmin_platform.c | 17 + 1 file changed, 9 insertions

[PATCH 2/7] staging: atomisp: Do not call dev_warn with a NULL device

, but as comments in the source indicate, the check for these 2 special gmin variables with a NULL device is a workaround for 2 specific evaluation boards, so completely silencing the missing warning for these actually is a good thing. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- .../staging

[PATCH 3/7] staging: atomisp: Set step to 0 for mt9m114 menu control

menu controls are not allowed to have a step size, set step to 0 to fix an oops from the WARN_ON in v4l2_ctrl_new_custom() triggering because of this. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/staging/media/atomisp/i2c/mt9m114.c | 2 +- 1 file changed, 1 insertion

[PATCH 5/7] staging: atomisp: Add OVTI2680 ACPI id to ov2680 driver

Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/staging/media/atomisp/i2c/ov2680.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/ov2680.c b/drivers/staging/media/atomisp/i2c/ov2680.c index 566091035c64..449aa2aa276f 100644 --- a/d

[PATCH 4/7] staging: atomisp: Add INT0310 ACPI id to gc0310 driver

Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/staging/media/atomisp/i2c/gc0310.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/gc0310.c b/drivers/staging/media/atomisp/i2c/gc0310.c index 1ec616a15086..350fd7fd5b86 100644 --- a/d

Firmware for staging atomisp driver

Hi All, I've been trying to get the atomisp driver from staging to work on a couple of devices I have. I started with an Asus T100TA after fixing 2 oopses in the sensor driver there I found out that the BIOS does not allow to put the ISP in PCI mode and that there is no code to drive it in ACPI

[PATCH] staging: atomisp: Fix -Werror=int-in-bool-context compile errors

e cannot do as the error suggests since b is evaluated multiple times. This commit fixes these compile errors. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c | 1 - .../pci/atomisp2/css2400/hive_isp_css_include/

Re: [PATCH] MAINTAINERS: change maintainer for gscpa/pwc/radio-shark

Hi, On 04-07-16 15:20, Hans Verkuil wrote: Hans de Goede has no more time to work on those, so I'll take over. For gspca/pwc I'll do 'Odd Fixes', for radio-shark I'll be a full maintainer. Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Thanks! Acked-by: Hans de Goede

Re: Stepping down as gspca and pwc maintainer

Hi, On 04-07-16 09:36, Hans Verkuil wrote: Hi Hans, On 07/03/2016 11:31 PM, Hans de Goede wrote: Hi All, Admittedly I've not been all that active as gspca and pwc maintainer lately, but officially I'm still the maintainer for both. Between my $dayjob, other foss projects and last

Stepping down as gspca and pwc maintainer

Hi All, Admittedly I've not been all that active as gspca and pwc maintainer lately, but officially I'm still the maintainer for both. Between my $dayjob, other foss projects and last but not least spending time with my wife and children I'm way too busy lately. So I'm hereby officially

Re: [3/7,media] gspca: avoid unused variable warnings

Hi Arnd, On 26-01-16 15:09, Arnd Bergmann wrote: When CONFIG_INPUT is disabled, multiple gspca backend drivers print compile-time warnings about unused variables: media/usb/gspca/cpia1.c: In function 'sd_stopN': media/usb/gspca/cpia1.c:1627:13: error: unused variable 'sd'

Re: ov519.c - allow setting i2c_detect_tries

Hi, On 16-07-15 00:51, valdis.kletni...@vt.edu wrote: I encountered a user who was having troubles getting a PlayStation EyeToy (USB ID 054c:0155) working as a webcam. They reported that repeated attempts would often make it work. Looking at the code, there was support for repeated attempts at

Re: USB xHCI regression after upgrading from kernel 3.19.0-51 to 4.2.0-34.

Hi, It is probably best to resend this mail to linux-usb since this is more of a usb problem then a v4l2 problem, and all the usb experts are subscribed to that list. Regards, Hans On 07-04-16 17:36, Matthew Giassa wrote: Good day, I maintain an SDK for USB2.0

Re: [PATCH 6/7] [media] gspca: fix a v4l2-compliance failure during VIDIOC_REQBUFS

Hi, On 14-03-16 16:02, Antonio Ospite wrote: On Thu, 10 Mar 2016 15:54:37 +0100 Hans de Goede <hdego...@redhat.com> wrote: Hi, On 09-03-16 17:03, Antonio Ospite wrote: When calling VIDIOC_REQBUFS v4l2-compliance fails with this message: fail: v4l2-test-buffers.cpp(476): q.reqbuf

Re: [v4l-utils PATCHv2] libv4lconvert: Add support for V4L2_PIX_FMT_{NV16,NV61}

e case? needs_conversion is set on formats which apps are unlikely to support natively, so yes it is correct to set it. Patch looks good to me: Acked-by: Hans de Goede <hdego...@redhat.com> Hans Verkuil, if you're happy with this version feel free to push it. Regards, Hans Changes since v

Re: [PATCH 7/7] [media] gspca: fix a v4l2-compliance failure during read()

Hi, On 09-03-16 17:03, Antonio Ospite wrote: v4l2-compliance fails with this message: fail: v4l2-test-buffers.cpp(512): Expected EBUSY, got 22 test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL Looking at the v4l2-compliance code reveals that this failure is about the read() callback. In

Re: [PATCH 6/7] [media] gspca: fix a v4l2-compliance failure during VIDIOC_REQBUFS

Hi, On 09-03-16 17:03, Antonio Ospite wrote: When calling VIDIOC_REQBUFS v4l2-compliance fails with this message: fail: v4l2-test-buffers.cpp(476): q.reqbufs(node, 1) test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL By looking at the v4l2-compliance code the failure happens when trying to

Re: [PATCH 0/2] [media] gspca_kinect: enable both video and depth streams

Hi Ulrik, On 06-03-16 14:50, Ulrik de Muelenaere wrote: Hello, The Kinect produces both a video and depth stream, but the current implementation of the gspca_kinect subdriver requires a depth_mode parameter at probe time to select one of the streams which will be exposed as a v4l device.

Re: [PATCH 0/1] v4lconvert: Add "PEGATRON CORPORATION" to asus_board_vendor

Hans de Goede redhat.com> writes: > > Hi Gregor, > > Here is a patch to add "PEGATRON CORPORATION" to asus_board_vendor, > to fix an upside down bug reported to Fedora: > > https://bugzilla.redhat.com/show_bug.cgi?id=1311545 > > I'm not 100% sure thi

Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly

media] rc: add sunxi-ir driver") Signed-off-by: Chen-Yu Tsai <w...@csie.org> Good catch: Acked-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- drivers/media/rc/sunxi-cir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/rc/sunxi-cir.c b/driver

Re: sn9c20x: incorrect support for 0c45:6270 MT9V011/MT9V111 ?

Hi TJ, On 12/18/2015 12:48 PM, TJ wrote: I've been trying to get the 0c45:6270 Vehoh VMS-001 'Discovery' Microscope to work correctly and discovered what seem to be differences in the bridge_init and other control commands. The most obvious difference currently is the LEDs do not turn on,

Re: [PATCH] m5602: correctly check failed thread creation

Hi, On 19-10-15 17:24, Insu Yun wrote: Since thread creation can be failed, check return value of kthread_create and handle an error. Signed-off-by: Insu Yun --- drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

Re: [PATCH] gspca: correctly checked failed allocation

Hi, On 19-10-15 18:43, Insu Yun wrote: create_singlethread_workqueue can be failed in memory pressue. So, check return value and return -ENOMEM Signed-off-by: Insu Yun --- drivers/media/usb/gspca/sq905.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] [media] gspca: ov534/topro: prevent a division by 0

to reset the camera to. Signed-off-by: Antonio Ospite <a...@ao2.it> Cc: sta...@vger.kernel.org Good catch: Reviewed-by: Hans de Goede <hdego...@redhat.com> Mauro can you pick this one up directly, and include it in your next pull-req for 4.3 please ? Regards, Hans --- Hi, I think

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

Hi, On 08-09-15 16:36, Alan Stern wrote: On Tue, 8 Sep 2015, Hans de Goede wrote: Hi, On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

Hi, On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion and schedule work to process the list. Moreover, save timestamp and sof number in the urb

[PULL fixes for 4.3]: gspca minor fixes

Hi Mauro, Here are 2 minor fixes for gspca for 4.3. The following changes since commit 77a3c6fd90c94f635edb00d4a65f485687538791: [media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar buffers (2015-06-22 09:52:58 -0300) are available in the git repository at:

Re: [PATCH] [media] gscpa_m5602: use msecs_to_jiffies for conversions

Hi, On 07-06-15 16:34, Nicholas Mc Guire wrote: API compliance scanning with coccinelle flagged: ./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25: WARNING: timeout (100) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent

Re: [patch] [media] gspca: sn9c2028: remove an unneeded condition

Hi, On 04-06-15 10:52, Dan Carpenter wrote: We already know status is negative because of the earlier check so there is no need to check again. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Makes sense: Acked-by: Hans de Goede hdego...@redhat.com Mauro, can you pick this one up

[PULL patches for 4.2]: New camera support for gspca sn9c2028 driver (v2)

Hi Mauro, Here is a new pull-req for the new camera support for the gspca sn9c2028 driver, now with my S-o-b added and the copyright change dropped. The following changes since commit 2a80f296422a01178d0a993479369e94f5830127: [media] dvb-core: fix 32-bit overflow during bandwidth

Re: [PATCH v2 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

Hi, On 20-05-15 14:12, Mauro Carvalho Chehab wrote: Em Fri, 24 Apr 2015 10:04:03 +0300 Vasily Khoruzhick anars...@gmail.com escreveu: This cam seems to return different values on long commands, so make status check in sn9c2028_long_command() more tolerant. Anyway, read value isn't used

[PULL patches for 4.2]: New camera support for gspca sn9c2028 driver

Hi Mauro, Please pull from my tree for new camera support for the gspca sn9c2028 driver. The following changes since commit 0fae1997f09796aca8ada5edc028aef587f6716c: [media] dib0700: avoid the risk of forgetting to add the adapter's size (2015-05-14 19:31:34 -0300) are available in the git

Re: [PATCH v2 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

Hi Vasily On 15-05-15 17:55, Vasily Khoruzhick wrote: Ping? Sorry for being a bit slow on this one, v2 looks good. I'll queue it up for merging into 4.2 as soon as I find some time to work on this, Regards, Hans On Fri, Apr 24, 2015 at 10:04 AM, Vasily Khoruzhick anars...@gmail.com

Re: [PATCHv3 0/4] add devm_of_phy_get_by_index and update platform drivers

(+), 98 deletions(-) Patch set looks good to me: Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

Hi Vasily, Thanks for the patches. On 19-04-15 20:52, Vasily Khoruzhick wrote: Signed-off-by: Vasily Khoruzhick anars...@gmail.com --- drivers/media/usb/gspca/sn9c2028.c | 120 - 1 file changed, 119 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] gspca: sn9c2028: Add gain and autogain controls Genius Videocam Live v2

Hi, On 19-04-15 20:52, Vasily Khoruzhick wrote: Autogain algorithm is very simple, if average luminance is low - increase gain, if it's high - decrease gain. Gain granularity is low enough for this algo to stabilize quickly. Signed-off-by: Vasily Khoruzhick anars...@gmail.com ---

Re: [PATCH] libv4lconvert: Fix support for Y16 pixel format

Hi, On 26-03-15 17:17, Ricardo Ribalda Delgado wrote: Y16 is a little-endian format. The original implementation assumed that it was big-endian. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Thanks merged upstream, both into master and stable-1.6 branches. Regards, Hans

Re: [PATCH] add Android makefile for libv4l2 and libv4lconvert

Hi, On 27-03-15 09:29, Benjamin Gaignard wrote: Hello, On behalf of Paramanand, I would have to have your opinion on this patch. The goal is to enable more v4l2 lib features on Android to be able to do video decoding using v4l2 devices. This looks fine to me, you say that I would have to

[PULL fixes for 4.0]: gspca build fixes

Hi Mauro, Here is a small build-fix for gspca for 4.0. The following changes since commit a3dfc6d925ca1bbd1a228253acb93f08657bad25: [media] dvb-usb: create one media_dev per adapter (2015-02-26 09:52:26 -0300) are available in the git repository at: git://linuxtv.org/hgoede/gspca.git

Re: divide error: 0000 in the gspca_topro

for this looks good to me and is: Acked-by: Hans de Goede hdego...@redhat.com Mauro, thanks for picking this one up. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] [media] gspca/touptek: Fix a few CodingStyle issues

Hi, On 01/29/2015 09:25 PM, Mauro Carvalho Chehab wrote: Checkpatch complained about a few issues, like FSF address. Also, multi-line comments are not following the Kernel CodingStyle. While not too late, let's fix those issues. Cc: John McMaster johndmcmas...@gmail.com Cc: Hans de Goede

Re: [PULL patches for 3.20]: New gspca touptek driver, gspca fixes and sunxi-cir driver improvments

Hi, On 01/29/2015 09:36 PM, Mauro Carvalho Chehab wrote: Em Thu, 15 Jan 2015 11:52:14 +0100 Hans de Goede hdego...@redhat.com escreveu: Hi Mauro, Note this pull-req superseeds my previous pull-req for 3.20 . Hmm... I ended by applying the previous pull request. I was unable to see

Re: [PATCH] media: gspca_vc032x - wrong bytesperline

Hi, On 26-01-15 11:38, Luca Bonissi wrote: Hi! I found a problem on vc032x gspca usb webcam subdriver: bytesperline property is wrong for YUYV and YVYU formats. With recent v4l-utils library (=0.9.1), that uses bytesperline for pixel format conversion, the result is a wrong jerky image.

[PULL patches for 3.20]: New gspca touptek driver, gspca fixes and sunxi-cir driver improvments

(2015-01-28 09:06:50 +0100) Antonio Ospite (1): gspca_stv06xx: enable button found on some Quickcam Express variant Hans Verkuil (1): pwc: fix WARN_ON Hans de Goede (3): rc: sunxi-cir: Add support for an optional

Re: [linux-sunxi] [PATCH v2 04/13] rc: sunxi-cir: Add support for an optional reset controller

Hi, On 19-01-15 15:10, Chen-Yu Tsai wrote: Hi, On Sat, Dec 20, 2014 at 6:20 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 19-12-14 19:17, Maxime Ripard wrote: Hi, On Thu, Dec 18, 2014 at 09:50:26AM +0100, Hans de Goede wrote: Hi, On 18-12-14 03:48, Chen-Yu Tsai wrote: Hi

Re: [3/5, media] pwc-if: fix build warning when !CONFIG_USB_PWC_INPUT_EVDEV

Hi, On 02-10-14 01:10, Luis Henriques wrote: Label err_video_unreg in function usb_pwc_probe() is only used when CONFIG_USB_PWC_INPUT_EVDEV is defined. drivers/media/usb/pwc/pwc-if.c:1104:1: warning: label 'err_video_unreg' defined but not used [-Wunused-label] Signed-off-by: Luis Henriques

Re: [PATCH 1/1] gspca: Add high-speed modes for PS3 Eye camera

Hi, On 04-01-15 16:29, Antonio Ospite wrote: On Mon, 29 Dec 2014 11:00:03 -0400 Joe Howse josephho...@nummist.com wrote: Add support in the PS3 Eye driver for QVGA capture at higher frame rates: 187, 150, and 137 FPS. This functionality is valuable because the PS3 Eye is popular for computer

Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant

Hi, On 06-01-15 21:59, Antonio Ospite wrote: On Tue, 28 Oct 2014 15:39:41 +0100 Antonio Ospite a...@ao2.it wrote: On Mon, 14 Jul 2014 12:27:57 +0200 Hans de Goede hdego...@redhat.com wrote: Hi, On 07/11/2014 02:56 PM, Antonio Ospite wrote: Signed-off-by: Antonio Ospite a...@ao2

[PULL patches for 3.20]: New gspca touptek driver, gspca fixes and sunxi-cir driver improvments

11:46:17 +0100) Antonio Ospite (1): gspca_stv06xx: enable button found on some Quickcam Express variant Hans Verkuil (1): pwc: fix WARN_ON Hans de Goede (3): rc: sunxi-cir: Add support for an optional reset

Re: [patch] [media] gspca: underflow in vidioc_s_parm()

Hi, On 07-01-15 12:04, Dan Carpenter wrote: n is a user controlled integer. The code here doesn't handle the case where n is negative and this causes a static checker warning. drivers/media/usb/gspca/gspca.c:1571 vidioc_s_parm() warn: no lower bound on 'n' Signed-off-by: Dan

Re: [PATCH v2 12/13] ARM: dts: sun6i: Add sun6i-a31s.dtsi

Hi, On 05-01-15 10:08, Maxime Ripard wrote: Hi, On Mon, Dec 22, 2014 at 02:46:12PM +0100, Hans de Goede wrote: On 21-12-14 23:39, Maxime Ripard wrote: On Sat, Dec 20, 2014 at 11:24:55AM +0100, Hans de Goede wrote: snip Given your previous changes, you should also update the enable-method

[PULL patches for 3.20]: New gspca touptek driver and sunxi-cir driver improvments

) Hans de Goede (2): rc: sunxi-cir: Add support for an optional reset controller rc: sunxi-cir: Add support for the larger fifo found on sun5i and sun6i John McMaster (1): gspca_touptek: Add support for ToupTek UCMOS series USB cameras .../devicetree

Re: [PATCH] [media] gspca_touptek: Add support for ToupTek UCMOS series USB cameras

Hi John, On 01-12-14 03:27, John McMaster wrote: Adds support for AmScope MU800 / ToupTek UCMOS08000KPB USB microscope camera. Signed-off-by: John McMaster johndmcmas...@gmail.com Thanks, I've added this driver to my gspca tree, and asked Mauro to queue it up for 3.20. Regards, Hans ---

Re: [PATCH v2 12/13] ARM: dts: sun6i: Add sun6i-a31s.dtsi

Hi, On 21-12-14 23:39, Maxime Ripard wrote: On Sat, Dec 20, 2014 at 11:24:55AM +0100, Hans de Goede wrote: Hi, On 19-12-14 19:34, Maxime Ripard wrote: On Wed, Dec 17, 2014 at 06:18:23PM +0100, Hans de Goede wrote: Add a dtsi file for A31s based boards. Since the A31s is the same die

Re: [linux-sunxi] [PATCH v2 04/13] rc: sunxi-cir: Add support for an optional reset controller

Hi, On 19-12-14 19:17, Maxime Ripard wrote: Hi, On Thu, Dec 18, 2014 at 09:50:26AM +0100, Hans de Goede wrote: Hi, On 18-12-14 03:48, Chen-Yu Tsai wrote: Hi, On Thu, Dec 18, 2014 at 1:18 AM, Hans de Goede hdego...@redhat.com wrote: On sun6i the cir block is attached to the reset

Re: [PATCH v2 12/13] ARM: dts: sun6i: Add sun6i-a31s.dtsi

Hi, On 19-12-14 19:34, Maxime Ripard wrote: On Wed, Dec 17, 2014 at 06:18:23PM +0100, Hans de Goede wrote: Add a dtsi file for A31s based boards. Since the A31s is the same die as the A31 in a different package, this dtsi simply includes sun6i-a31.dtsi and then overrides the pinctrl

Re: [PATCH v2 06/13] clk: sunxi: Make the mod0 clk driver also a platform driver

Hi, On 19-12-14 19:24, Maxime Ripard wrote: Hi, On Wed, Dec 17, 2014 at 06:18:17PM +0100, Hans de Goede wrote: With the prcm in sun6i (and some later SoCs) some mod0 clocks are instantiated through the mfd framework, and as such do not work with of_clk_declare, since they do not have

Re: [linux-sunxi] [PATCH v2 04/13] rc: sunxi-cir: Add support for an optional reset controller

Hi, On 18-12-14 03:48, Chen-Yu Tsai wrote: Hi, On Thu, Dec 18, 2014 at 1:18 AM, Hans de Goede hdego...@redhat.com wrote: On sun6i the cir block is attached to the reset controller, add support for de-asserting the reset if a reset controller is specified in dt. Signed-off-by: Hans de Goede

Re: [PATCH v2 07/13] mfd: sun6i-prcm: Add support for the ir-clk

Hi, On 18-12-14 09:41, Lee Jones wrote: On Wed, 17 Dec 2014, Hans de Goede wrote: Add support for the ir-clk which is part of the sun6i SoC prcm module. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/mfd/sun6i-prcm.c | 14 ++ 1 file changed, 14 insertions

[PATCH v2 01/13] pinctrl: sun6i: Add some missing functions

While working on pinctrl for the A31s, I noticed that function 4 of PA15 - PA18 was missing, add these. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Drop the changes to the muxing of i2c3 this was based on A31s Datasheet v1.40.pdf, but all other A31 related info puts them

[PATCH v2 00/13] sun6i: Add A31s and ir support

Hi All, Here is v2 of my patch series to add sun6i A31s and ir support. Changes in v2: -pinctrl: sun6i: Add some missing functions, fix i2c3 muxing: -Drop the changes to the muxing of i2c3 this was based on A31s Datasheet v1.40.pdf, but all other A31 related info puts them

[PATCH v2 03/13] ARM: sunxi: Add allwinner,sun6i-a31s to mach-sunxi

So far the A31s is 100% compatible with the A31, still lets do the same as what we've done for the A13 / A10s and give it its own compatible string, in case we need to differentiate later. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/arm/sunxi/README | 1 - arch/arm/mach

[PATCH v2 06/13] clk: sunxi: Make the mod0 clk driver also a platform driver

in the of_clk_declare mod0 clk setup method, and also register mod0-clk support as a platform driver to work properly with mfd instantiated mod0 clocks. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/clk/sunxi/clk-mod0.c | 41 - 1 file changed, 36 insertions(+), 5

[PATCH v2 10/13] ARM: dts: sun6i: Add pinmux settings for the ir pins

Add pinmux settings for the ir receive pin of the A31. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 85c6365..9e9504c

[PATCH v2 08/13] ARM: dts: sun6i: Add ir_clk node

Add an ir_clk sub-node to the prcm node. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Use allwinner,sun4i-a10-mod0-clk as compatible, rather then a prcm specific compatible --- arch/arm/boot/dts/sun6i-a31.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2 13/13] ARM: dts: sun6i: Add dts file for CSQ CS908 board

The CSQ CS908 is an A31s based top-set box, with 1G RAM, 8G NAND, rtl8188etv usb wifi, 2 USB A receptacles (1 connected through the OTG controller), ethernet, 3.5 mm jack with a/v out and hdmi out. Note it has no sdcard slot and therefore can only be fel booted. Signed-off-by: Hans de Goede

[PATCH v2 12/13] ARM: dts: sun6i: Add sun6i-a31s.dtsi

Add a dtsi file for A31s based boards. Since the A31s is the same die as the A31 in a different package, this dtsi simply includes sun6i-a31.dtsi and then overrides the pinctrl compatible to reflect the different package, everything else is identical. Signed-off-by: Hans de Goede hdego

[PATCH v2 11/13] ARM: dts: sun6i: Enable ir receiver on the Mele M9

The Mele M9 has an ir receiver, enable it. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31-m9.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31-m9.dts b/arch/arm/boot/dts/sun6i-a31-m9.dts index 3ab544f..fccf709 100644

[PATCH v2 05/13] rc: sunxi-cir: Add support for the larger fifo found on sun5i and sun6i

-by: Hans de Goede hdego...@redhat.com Acked-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Maxime Ripard maxime.rip...@free-electrons.com --- .../devicetree/bindings/media/sunxi-ir.txt | 2 +- drivers/media/rc/sunxi-cir.c| 21 - 2

[PATCH v2 09/13] ARM: dts: sun6i: Add ir node

Add a node for the ir receiver found on the A31. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun6i-a31.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi index 1c1d255..85c6365 100644

[PATCH v2 07/13] mfd: sun6i-prcm: Add support for the ir-clk

Add support for the ir-clk which is part of the sun6i SoC prcm module. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/mfd/sun6i-prcm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/mfd/sun6i-prcm.c b/drivers/mfd/sun6i-prcm.c index 2f2e9f0..1911731

[PATCH v2 02/13] pinctrl: sun6i: Add A31s pinctrl support

-a31-r.c, as the prcm pins are identical between the A31 and the A31s. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Sync i2c3 muxing with v2 of pinctrl: sun6i: Add some missing functions -Add myself to the copyright header --- .../bindings/pinctrl/allwinner,sunxi-pinctrl.txt

[PATCH v2 04/13] rc: sunxi-cir: Add support for an optional reset controller

On sun6i the cir block is attached to the reset controller, add support for de-asserting the reset if a reset controller is specified in dt. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Maxime Ripard maxime.rip...@free

Re: LibV4L2 and CREATE_BUFS issues

Hi, On 14-12-14 15:24, Nicolas Dufresne wrote: Le 2014-12-14 04:49, Hans de Goede a écrit : Ah yes I see, so I assume that if libv4l where to return a failure for CREATE_BUFS when conversion is used, that gstreamer will then fallback to a regular REQUEST_BUFS call ? Then that indeed seems

Re: LibV4L2 and CREATE_BUFS issues

Hi, On 13-12-14 17:15, Nicolas Dufresne wrote: Le 2014-12-13 05:41, Hans de Goede a écrit : I think making CREATE_BUFS fail when doing conversion is probably best, note that gstreamer should be able to tell which formats will lead to doing conversion, and that it can try to avoid those

Re: LibV4L2 and CREATE_BUFS issues

Hi, On 10-12-14 17:27, Nicolas Dufresne wrote: Hi, we recently fixed our CREATE_BUFS support in GStreamer master. It works nicely with UVC drivers. The problem is that libv4l2 isn't aware of it, and endup taking terribly decision the least quickly lead to crash. I'm not sure what that right

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

Hi, On 07-12-14 19:08, Maxime Ripard wrote: On Wed, Dec 03, 2014 at 10:49:20AM +0100, Hans de Goede wrote: snip So it should not have a simple-bus compatible either, and as such we cannot simply change the mod0 driver from of_clk_define to a platform driver because then we need

Re: [PATCH 3/9] clk: sunxi: Add prcm mod0 clock driver

Hi, On 12/02/2014 04:45 PM, Maxime Ripard wrote: Ok, so thinking more about this, I'm still convinced that the MFD framework is only getting in the way here. You still haven't said of what exactly it's getting in the way of. Of using of_clk_define to bind to the mod0 clk in the prcm,

  1   2   3   4   5   6   7   8   9   10   >