Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-28 Thread Hans de Goede
Hi, First of all many thanks for working on this! Note I've also taken a quick look at the original patch with the actual implementation and that looks good. I'm replying here because in my mind the API is the most interesting thing to discuss. Comments inline. On 07/26/2012 06:21 PM, Konke Rad

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-28 Thread Hans de Goede
Hi, Overall this looks good, but some of the code, for example the set/get freq and get/set tuner stuff seems to be a 1 on 1 copy of code from v4l2-ctrl, please factor this out into a common file which can be shared between both utilities (I think Hans V's recent work on splitting v4l2-ctl into m

Re: linux-next: Tree for July 31 (media/radio-tea5777)

2012-08-01 Thread Hans de Goede
Thanks for fixing this for me! Acked-by: Hans de Goede On 07/31/2012 09:56 PM, Mauro Carvalho Chehab wrote: Em 31-07-2012 14:22, Randy Dunlap escreveu: drivers/built-in.o: In function `radio_tea5777_set_freq': radio-tea5777.c:(.text+0x4d8704): undefined reference to `__udivdi3'

Add v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Hi Hans et all, As discussed at the kernel summit. Note I have only compile tested this as I've no control event capable hardware with me (until I'm done with adding support for ctrl events to the UVC driver). Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-medi

[PATCH 1/3] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-10-24 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a/drivers/media/video/v4l2-event.c +++ b/drivers

[PATCH 3/3] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39 --- drivers/media

[PATCH 2/3] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede --- drivers/media/video/ivtv/ivtv-ioctl.c

Various ctrl and event frame work patches

2011-10-27 Thread Hans de Goede
Hi All, This patch set obsoletes my previous "add v4l2_subscribed_event_ops" set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux

[PATCH 1/6] v4l2-ctrl: Send change events to all fh for auto cluster slave controls

2011-10-27 Thread Hans de Goede
Otherwise the fh changing the master control won't get the inactive state change event for the slave controls. Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-ctrls.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-ctrls.c b/dr

[PATCH 2/6] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-10-27 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a/drivers/media/video/v4l2-event.c +++ b/drivers

[PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-10-27 Thread Hans de Goede
unsubscription. Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 9f56f18..01cbb7f 100644 --- a/drivers/media/video/v4l2

[PATCH 4/6] v4l2-event: Don't set sev->fh to NULL on unsubcribe

2011-10-27 Thread Hans de Goede
his series, since this op needs a way to get to its own data structures, and typically this will be done by using container_of on an embedded v4l2_fh struct. Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/driv

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-27 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede --- drivers/media/video/ivtv/ivtv-ioctl.c

[PATCH 6/6] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-27 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39 --- drivers/media

uvcvideo: Add support for control events

2011-10-27 Thread Hans de Goede
Hi All, This patch set adds support for control events to the uvcvideo driver. Note this patch set depends on the "Various ctrl and event frame work patches" set which I just send out. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a messag

[PATCH 1/2] uvcvideo: Refactor uvc_ctrl_get and query

2011-10-27 Thread Hans de Goede
This is a preparation patch for adding ctrl event support. Signed-off-by: Hans de Goede --- drivers/media/video/uvc/uvc_ctrl.c | 62 +--- 1 files changed, 43 insertions(+), 19 deletions(-) diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video

[PATCH 2/2] uvcvideo: Add support for control events

2011-10-27 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/media/video/uvc/uvc_ctrl.c | 104 drivers/media/video/uvc/uvc_v4l2.c | 51 - drivers/media/video/uvc/uvcvideo.h |9 +++ 3 files changed, 161 insertions(+), 3 deletions(-) diff --git a/drivers

Re: [PATCH 4/6] v4l2-event: Don't set sev->fh to NULL on unsubcribe

2011-10-28 Thread Hans de Goede
Hi, Thanks for the reviews! On 10/27/2011 02:20 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except for the

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-28 Thread Hans de Goede
Hi, On 10/27/2011 02:30 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:02 Hans de Goede wrote: Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe

[GIT PATCHES FOR 3.2] pwc driver ctrl events + fixes + pac207 exposure fix

2011-10-31 Thread Hans de Goede
git repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.2 Hans de Goede (7): pwc: Add support for control events pwc: properly mark device_hint as unused in all probe error paths pwc: Make auto white balance speed and delay available as v4l2 controls pwc

Re: [PATCH] Increase max exposure value to 255 from 26.

2011-10-31 Thread Hans de Goede
Hi, Thanks for the patch, I've taken a look at this, and the way the pac207's exposure control works is it sets the fps according to the formula of: 90 / exposure reg value. So the old max setting gave you a max exposure time of 90 / 26 = 3.46 fps or 288.9 milliseconds. 3.46 fps already is quite

Various ctrl and event frame work patches (version 2)

2011-10-31 Thread Hans de Goede
Hi All, This patch set obsoletes my previous "add v4l2_subscribed_event_ops" set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Changes since version 1: -Added a documentation update (update v4l2-framework.txt) t

[PATCH 1/6] v4l2-ctrl: Send change events to all fh for auto cluster slave controls

2011-10-31 Thread Hans de Goede
Otherwise the fh changing the master control won't get the inactive state change event for the slave controls. Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-ctrls.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-ctrls.c b/dr

[PATCH 2/6] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-10-31 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a/drivers/media/video/v4l2-event.c +++ b/drivers

[PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-10-31 Thread Hans de Goede
unsubscription. Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 9f56f18..01cbb7f 100644 --- a/drivers/media/video/v4l2

[PATCH 4/6] v4l2-event: Don't set sev->fh to NULL on unsubcribe

2011-10-31 Thread Hans de Goede
his series, since this op needs a way to get to its own data structures, and typically this will be done by using container_of on an embedded v4l2_fh struct. Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/driv

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-31 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede --- Documentation/video4linux/v4l2

[PATCH 6/6] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-31 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39 --- drivers/media

Re: Various ctrl and event frame work patches (version 2)

2011-11-01 Thread Hans de Goede
Hi, On 10/31/2011 05:17 PM, Hans Verkuil wrote: Hi Hans! On Monday, October 31, 2011 16:16:43 Hans de Goede wrote: Hi All, This patch set obsoletes my previous "add v4l2_subscribed_event_ops" set, while working on adding support for ctrl-events to the uvc driver I found a few b

Re: [PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-11-01 Thread Hans de Goede
Hi, hverkuil wrote: > > This patch fixes these dangling pointers in the available queue by removing > > all matching pending events on unsubscription. > > The idea is fine, but the implementation is inefficient. > > Instead of the list_for_each_entry_safe you can just do: > >for (i = 0; i <

Re: [PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-11-02 Thread Hans de Goede
Hi, hverkuil wrote: On Thursday, October 27, 2011 13:18:01 Hans de Goede wrote: >> 1: There is no reason for this after v4l2_event_unsubscribe releases the >> spinlock nothing is holding a reference to the sev anymore except for the >> local reference in the v4l2_event_un

Re: [PATCH 4/6] v4l2-event: Don't set sev->fh to NULL on unsubscribe

2011-11-02 Thread Hans de Goede
Hi, hverkuil wrote: >On Thursday, October 27, 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except for the local reference in the v4l2_event_unsubscribe function.

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-11-02 Thread Hans de Goede
Hi, hverkuil wrote: > > + if (sev->ops && sev->ops->add) { > > + int ret = sev->ops->add(sev); > > + if (ret) { > > + sev->ops = NULL; > > + v4l2_event_unsubscribe(fh, sub); > > + return ret; > > +

Various ctrl and event frame work patches (version 3)

2011-11-02 Thread Hans de Goede
Hi All, This patch set obsoletes my previous "add v4l2_subscribed_event_ops" set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Changes since version 1: 4/5 v4l2-event: Add v4l2_subscrib

[PATCH 1/5] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-11-02 Thread Hans de Goede
Signed-off-by: Hans de Goede Acked-by: Laurent Pinchart Acked-by: Hans Verkuil --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a

[PATCH 2/5] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-11-02 Thread Hans de Goede
unsubscription. Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-event.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 9f56f18..4d01f17 100644 --- a/drivers/media/video/v4l2-event.c

[PATCH 3/5] v4l2-event: Don't set sev->fh to NULL on unsubscribe

2011-11-02 Thread Hans de Goede
emoves sev->node from the ev_subs list 13) v4l2_ctrls del_event releases the ctrl lock 14) v4l2_event_unsubscribe frees the sev, to which no references are being held anymore Signed-off-by: Hans de Goede --- drivers/media/video/v4l2-ctrls.c |4 ++-- drivers/media/video/v4l2-event.c |

[PATCH 5/5] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-11-02 Thread Hans de Goede
Signed-off-by: Hans de Goede Acked-by: Hans Verkuil --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39

[PATCH 4/5] v4l2-event: Add v4l2_subscribed_event_ops

2011-11-02 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede --- Documentation/video4linux/v4l2

Re: Various ctrl and event frame work patches (version 3)

2011-11-02 Thread Hans de Goede
Hi Hans V., Thanks for the review and the acks. So do you want to get these patches in through my tree, or through yours? I believe we should get patches 1-3 into 3.2, 4 & 5 could also go to 3.2, or we can delay them to 3.3 . Regards, Hansg -- To unsubscribe from this list: send the line "unsu

[GIT FIXES FOR 3.2] Fixes for event framework

2011-11-02 Thread Hans de Goede
://linuxtv.org/hgoede/gspca.git eventfixes Hans de Goede (3): v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL v4l2-event: Remove pending events from fh event queue when unsubscribing v4l2-event: Don't set sev->fh to NULL on unsubscribe drivers/media/video/v4l2-ctrls.

[GIT FIXES FOR 3.2 ] Fixes for event framework

2011-11-07 Thread Hans de Goede
://linuxtv.org/hgoede/gspca.git eventfixes Hans de Goede (3): v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL v4l2-event: Remove pending events from fh event queue when unsubscribing v4l2-event: Don't set sev->fh to NULL on unsubscribe drivers/media/video/v4l2-ctrls.

Re: [PATCH] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

2011-11-19 Thread Hans de Goede
Hi, On 11/19/2011 07:50 PM, Ezequiel wrote: Pushed video_device initialization into a separate function. Replaced static allocation of struct video_device by video_device_alloc/video_device_release usage. NACK! I see a video_device_release call here, but not a video_device_alloc, also you're m

Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

2011-11-20 Thread Hans de Goede
Hi, On 11/19/2011 10:46 PM, Ezequiel wrote: Pushed video_device initialization into a separate function. Replace static allocation of struct video_device by video_device_alloc/video_device_release usage. NACK again! There is no reason to do this, it just makes the code more complicated withou

[PATCH] [REGRESSION] bt8xx: Fix too large height in cropcap

2013-03-25 Thread Hans de Goede
and using it for the PAL entry. This is a regression introduced in 3.8 and this fix should be backported to kernels back to 3.8.x. Signed-off-by: Hans de Goede Cc: sta...@vger.kernel.org --- drivers/media/pci/bt8xx/bttv-driver.c | 20 +++- 1 file changed, 15 insertions(+), 5 dele

Re: [PATCH] [media] gspca: remove obsolete Kconfig macros

2013-03-29 Thread Hans de Goede
Mauro, Can you pick this one up? I don't have anything pending for gspca, and to create a tree + pullreq for just a trivial patch is not really efficient. Alternatively I can put it on my TODO for when there is more gspca work, esp. since there is not really a need to hurry with merging this. R

Re: [PATCH] xawtv: release buffer if it can't be displayed

2013-03-31 Thread Hans de Goede
Hi, On 03/30/2013 10:47 AM, Hans Verkuil wrote: This patch for xawtv3 releases the buffer if it can't be displayed because the resolution of the current format is larger than the size of the window. This will happen if the hardware cannot scale down to the initially quite small xawtv window. Fo

[PATCH 1/2] libng: Add a get_min_size function to the plugins

2013-03-31 Thread Hans de Goede
Signed-off-by: Hans de Goede --- libng/grab-ng.h| 1 + libng/plugins/drv0-bsd.c | 8 +++ libng/plugins/drv0-v4l2.tmpl.c | 49 ++ 3 files changed, 58 insertions(+) diff --git a/libng/grab-ng.h b/libng/grab-ng.h index 2c73b79

[PATCH 2/2] xawtv: Limit minimum window size to minimum capture resolution

2013-03-31 Thread Hans de Goede
Signed-off-by: Hans de Goede --- x11/xawtv.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/x11/xawtv.c b/x11/xawtv.c index bade35a..9c578da 100644 --- a/x11/xawtv.c +++ b/x11/xawtv.c @@ -1636,7 +1636,7 @@ create_launchwin(void) int main(int argc, char *argv

Re: [PATCH] xawtv: release buffer if it can't be displayed

2013-04-01 Thread Hans de Goede
Hi, On 04/01/2013 12:19 PM, Hans Verkuil wrote: Hi Hans, On Sun March 31 2013 14:48:01 Hans de Goede wrote: Hi, On 03/30/2013 10:47 AM, Hans Verkuil wrote: This patch for xawtv3 releases the buffer if it can't be displayed because the resolution of the current format is larger than the

Re: [PATCH] [media] gspca_touptek: Add support for ToupTek UCMOS series USB cameras

2013-04-01 Thread Hans de Goede
Hi John, Thanks for the new driver! Unfortunately the driver is still using gspca's own/deprecated control mechanism rather then the new v4l2-control framework which all drivers now a days use. And we've just finished converting all the gspca sub-drivers to using this new control framework, and

Re: [PATCH] xawtv: release buffer if it can't be displayed

2013-04-02 Thread Hans de Goede
Hi, On 04/01/2013 04:39 PM, Hans Verkuil wrote: On Mon April 1 2013 16:23:51 Hans de Goede wrote: Hi, On 04/01/2013 12:19 PM, Hans Verkuil wrote: Hi Hans, On Sun March 31 2013 14:48:01 Hans de Goede wrote: Hi, On 03/30/2013 10:47 AM, Hans Verkuil wrote: This patch for xawtv3 releases the

Announce: xawtv-3.103

2013-04-02 Thread Hans de Goede
Hi All, I'm happy to announce the latest xawtv release Changes: 3.103 = * Improve alsa stream handling * Add support for alsa audio loopback to the radio app * Add support for multiple-band (AM+FM) tuners to radio app * Tons of other bugfixes + improvements for the radio app * Fix xawtv win

Anyone working on supporting sdio cams under Linux

2013-04-17 Thread Hans de Goede
Hi, Yes I mean camaras which connect to the computer / tablet through an sdio connector, ie the hp one shown here: http://en.wikipedia.org/wiki/Secure_Digital#SDIO A college asked me if I wanted one for the webcam driver work I do, but since it does not have a usb plug I'm not interested. But i

linuxtv.org wiki: V4L2_Userspace_Library hopelessly out of date

2009-08-12 Thread Hans de Goede
Hi, Can someone please kill: http://linuxtv.org/wiki/index.php/V4L2_Userspace_Library It still talks about the old complex proxy device and daemon using plans for a V4L2_Userspace_Library, now that we have libv4l this is pretty much obsolete. Yes having a new wiki page for libv4l would be great

Re: Decoding pac207

2009-08-12 Thread Hans de Goede
Hi, On 08/08/2009 11:57 AM, Ronny Brendel wrote: Hello, I am currently fiddling some around with capturing pictures from a very cheap webcam. Unfortunately that webcam uses the rare codec pac207. Does a decoder (as source) or a description of the codec exist? Or can you please give a hint where

Re: gspca: Trust webcam WB 300P ID 093a:2608 doesn't work

2009-08-12 Thread Hans de Goede
Hi, You are trying to use the webcam on the same usb root controller as an usb-audio device and there is not enough bandwidth for both, try removing the usb audio device. Regards, Hans On 08/11/2009 07:04 PM, Claudio Chimera wrote: Hello, I'm trying to use the Trust webcam WB 300P (ID 093a:2

Re: libv4l: problem with 2x downscaling + Labtec Webcam 2200

2009-08-15 Thread Hans de Goede
On 08/15/2009 08:53 AM, Németh Márton wrote: Hello Hans, I am using your libv4l 0.6.0 [1] together with the driver gspca_pac7311 from Linux kernel 2.6.31-rc4 and with Labtec Webcam 2200 hardware [2]. I am using the svv.c [3] to display the webcam image. When I'm using the webcam in 640x480 the

Re: gspca: Trust webcam WB 300P ID 093a:2608 doesn't work

2009-08-20 Thread Hans de Goede
0] err -28 Then you most likely still have something using usb bandwidth maybe some integrated pheriphial ? What is the output of lsusb? Regards, Hans This web-cam is never worked using Linux, but it is reported full working. Thanks Claudio Il giorno mer, 12/08/2009 alle 16.53 +0200, Hans d

Re: Exposure set bug in stv06xx driver

2009-08-24 Thread Hans de Goede
Hi, On 08/23/2009 02:50 PM, James Blanford wrote: Well that was quick. These issues as well as the stream drops were remedied in 2.6.31-rc7, ?? I'm the author of the pb100 (046d:0840) support in the stv06xx driver, and AFAIK there have been no changes to it recently. except exposure and gai

RFC: video device (stream) sharing

2009-08-27 Thread Hans de Goede
Hi All, This has been discussed before and this is something Brandon and I would like to discuss further at plumbers, so here is a first braindump, note that this braindump is purely mine and not Brandon's in any way. The basic idea is to have some sort of userspace proxy process which allows sh

Re: [PATCH] libv4l: add NULL pointer check

2009-09-01 Thread Hans de Goede
Hi, On 08/30/2009 10:56 AM, Németh Márton wrote: From: Márton Németh Add NULL pointer check before the pointers are dereferenced. The patch was tested with v4l-test 0.19 [1] together with "Trust 610 LCD pow...@m Zoom" in webcam mode. http://linuxtv.org/hg/~hgoede/libv4l/rev/c51a90c0f62f Re

libv4l release: 0.6.1: the 2nd upside down release

2009-09-01 Thread Hans de Goede
Hi All, I'm very happy to announce the release of libv4l-0.6.1 The main changes this release is tons of new laptops in the list of laptops whose camera modules (mostly uvc) are known to be mounted upside down in the frame and it will automatically correct the image for this. libv4l-0.6.1 --

Pull Request: http://linuxtv.org/hg/~hgoede/gspca/

2009-09-01 Thread Hans de Goede
Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/gspca/ For: -Some small pac207 driver improvements -Many improvements to the mr97310a driver, including support for much more cameras -Addition of the V4L2_FMT_FLAG_EMULATED flag to videodev2.h, as discussed before. Regards, Hans -- T

Pull Request: http://linuxtv.org/hg/~hgoede/libv4l/

2009-09-01 Thread Hans de Goede
Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/libv4l/ To sync libv4l in your tree with the libv4l-0.6.1 release. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: libv4l2 and the Hauppauge HVR1600 (cx18 driver) not working well together

2009-09-02 Thread Hans de Goede
Hi, On 09/02/2009 06:32 PM, Simon Farnsworth wrote: Hello, I'm in the process of reworking Xine's input_v4l to use libv4l2, so that it gets the benefit of all the work done on modern cards and webcams, and I've hit a stumbling block. I have a Hauppauge HVR1600 for NTSC and ATSC support, and

Re: libv4l2 and the Hauppauge HVR1600 (cx18 driver) not working well together

2009-09-03 Thread Hans de Goede
Hi, On 09/03/2009 11:17 AM, Simon Farnsworth wrote: Hans de Goede wrote: Hi, On 09/02/2009 06:32 PM, Simon Farnsworth wrote: I have a Hauppauge HVR1600 for NTSC and ATSC support, and it appears to simply not work with libv4l2, due to lack of mmap support. My code works adequately (modulo a

Re: libv4l2 and the Hauppauge HVR1600 (cx18 driver) not working well together

2009-09-03 Thread Hans de Goede
Hi, On 09/03/2009 11:17 AM, Simon Farnsworth wrote: Hans de Goede wrote: Hi, On 09/02/2009 06:32 PM, Simon Farnsworth wrote: I have a Hauppauge HVR1600 for NTSC and ATSC support, and it appears to simply not work with libv4l2, due to lack of mmap support. My code works adequately (modulo a

Re: libv4l2 and the Hauppauge HVR1600 (cx18 driver) not working well together

2009-09-03 Thread Hans de Goede
On 09/03/2009 12:21 PM, Simon Farnsworth wrote: Hans de Goede wrote: Ok, That was even easier then I thought it would be. Attached is a patch (against libv4l-0.6.1), which implements 1) and 3) from above. I applied it to a clone of your HG repository, and had to make a minor change to get it

Re: libv4l2 and the Hauppauge HVR1600 (cx18 driver) not working well together

2009-09-03 Thread Hans de Goede
Hans Verkuil, I think we have found a bug in the read() implementation of the cx18 driver, see below. Hi all, On 09/03/2009 12:37 PM, Simon Farnsworth wrote: Simon Farnsworth wrote: Hans de Goede wrote: Ok, That was even easier then I thought it would be. Attached is a patch (against

Re: libv4l2 and the Hauppauge HVR1600 (cx18 driver) not working well together

2009-09-03 Thread Hans de Goede
Hi, I've commited the patch to enable using libv4l2 with devices which only support read() : http://linuxtv.org/hg/~hgoede/libv4l/rev/41abaf074b58 Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More

Re: libv4l2 and the Hauppauge HVR1600 (cx18 driver) not working well together

2009-09-03 Thread Hans de Goede
Hi, On 09/04/2009 05:14 AM, Andy Walls wrote: The V4L2 spec for the read() call seems unlcear to me: "Return Value On success, the number of bytes read is returned. It is not an error if this number is smaller than the number of bytes requested, or the amount of data required for one frame. Thi

Re: [PATCH] DVB/V4L: ov511 - export snapshot button through input layer

2009-09-06 Thread Hans de Goede
Hi, The ov511 driver is a v4l1 driver and is deprecated, all supported webcams are now supported by the gspca_ov519 driver. Can you please do a patch to the gspca_ov519 driver instead? Note that the gspca_sn9c20x driver already has support for input events, if possible please try to locate comm

Re: [Patch 2/2] stv06xx webcams with HDCS 1xxx sensors

2009-09-13 Thread Hans de Goede
Hi, On 09/10/2009 09:51 AM, Erik Andrén wrote: Looks good! Thanks, Acked-by: Erik Andrén Erik, Are you going to merge these 2 patches in your tree, and let them find their way into the master this way, or shall I merge them in my tree ? Regards, Hans -- To unsubscribe from this list:

Re: image quality of Labtec Webcam 2200

2009-09-13 Thread Hans de Goede
Hi, On 09/13/2009 09:20 AM, Jean-Francois Moine wrote: On Fri, 11 Sep 2009 09:09:20 +0200 Németh Márton wrote: You can find my results at http://v4l-test.sourceforge.net/results/test-20090911/index.html There are three types of problems: a) Sometimes the picture contains a 8x8 pixel error, li

Re: image quality of Labtec Webcam 2200

2009-09-13 Thread Hans de Goede
Hi, On 09/13/2009 05:59 PM, Thomas Kaiser wrote: I thought Hans will come in, in this discussion... Hey hey, its weekend, give me some time to respond already :) See my reply higher up in the thread. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media

Re: [RFC] Global video buffers pool

2009-09-17 Thread Hans de Goede
Hi, On 09/16/2009 05:46 PM, Laurent Pinchart wrote: Hi everybody, I didn't want to miss this year's pretty flourishing RFC season, so here's another one about a global video buffers pool. All comments are welcome, but please don't trash this proposal too fast. It's a first shot at real problem

Re: Programming sensor through firmware files bc of NDA

2009-10-04 Thread Hans de Goede
Hi, On 10/02/2009 03:55 PM, Aguirre Rodriguez, Sergio Alberto wrote: Hi all, I'm currently interested in knowing what is the stand on having a v4l2_subdev driver that uses some kind of binary for programming registers in a image sensor driver. NOTE: I must confess I currently don't know how to

Re: Tool to measure frame rate

2009-10-04 Thread Hans de Goede
Hi, On 10/04/2009 12:28 PM, Erik Andrén wrote: Hi list, Could someone recommend a program that measures the frame rate of a video capturing device (webcam)? I usually use camorama for this, note camorama is buggy, you will want to apply the patches from: http://cvs.fedoraproject.org/viewvc/d

Re: Race in gspca main or missing lock in stv06xx subdriver?

2009-10-04 Thread Hans de Goede
Hi all, Sorry for jumping into this discussion a bit late, I was swamped with other stuff and did not have time to look into this before. On 09/15/2009 12:41 PM, Jean-Francois Moine wrote: On Mon, 14 Sep 2009 11:17:57 -0400 James Blanford wrote: Howdy folks, I have my old quickcam express w

PATCH: gscpa stv06xx + ov518: dont discard every other frame

2009-10-04 Thread Hans de Goede
Hi, As noticed by James Blanford , we were discarding every other frame in stv06xx and the ov518 (part of ov519.c) drivers. When we call gspca_frame_add, it returns a pointer to the frame passed in, unless we call it with LAST_PACKET, when it will return a pointer to a new frame in which to stor

Re: [PATCH] pac_common: redesign function for finding Start Of Frame

2009-10-05 Thread Hans de Goede
Hi, Good one, Acked-by: Hans de Goede Jean-Francois, can you please add this patch to your tree? Thanks, Hans On 10/04/2009 10:55 PM, Németh Márton wrote: From: Márton Németh The original implementation of pac_find_sof() does not always find the Start Of Frame (SOF) marker. Replace it

PULL request: http://linuxtv.org/hg/~hgoede/gspca

2009-10-09 Thread Hans de Goede
Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/gspca For the following changes: -Improved detection of the sensor type for mr97310a cams -Gain, exposure and brightness controls for mr97310a VGA cams with sensor type 1 -Cleanups of the work queue functions for the jeilinj, sq905 and

libv4l release: 0.6.2: the 3th upside down release

2009-10-09 Thread Hans de Goede
Hi All, I'm very happy to announce the release of libv4l-0.6.2 The main changes this release is 17 new laptops in the list of laptops whose camera modules (mostly uvc) are known to be mounted upside down in the frame and it will automatically correct the image for this. (This upside down busine

Pull request: http://linuxtv.org/hg/~hgoede/gspca

2009-10-12 Thread Hans de Goede
Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/gspca Besides the changes from my previous pull request, my tree now also contains support for ovfx2 based cams Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord..

Re: Possible bug on libv4l read() emulation

2009-10-16 Thread Hans de Goede
Hi, On 10/16/2009 12:00 AM, Pablo Baena wrote: I have a program where I use libv4l's read() emulation for simplicity. But with most v4l2 webcams I've tried, I get kernel panics. I have pics of the message if anyone cares to see them, I don't want to flood the mailing list. Basically, the names

Pull request: http://linuxtv.org/hg/~hgoede/gspca

2009-10-19 Thread Hans de Goede
Hi Mauro, I saw you've pulled in my tree, I assume this is for Linus for 2.6.32, I hope this pull request is also still in time for 2.6.32 (it adds support to an existing driver for a new bridge, no changes to the code for already supported bridges, so in essence it is a new driver). Please pull

PULL request: http://linuxtv.org/hg/~hgoede/gspca

2009-10-24 Thread Hans de Goede
Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/gspca For a new gspca subdriver adding support fopr stv0680 based webcams (replacing the old v4l1 stv0680 driver). If possible I would like to see this make 2.6.32 . Thanks & Regards, Hans -- To unsubscribe from this list: send the line

libv4l release: 0.6.3: time to retire some v4l1 drivers

2009-10-25 Thread Hans de Goede
Hi All, I'm very happy to announce the release of libv4l-0.6.3 The main change this release is support for decompression of w9968cf JPEG and stv0680 raw bayer formats, together with the new gspca support for these bridges, this will allow us to retire the w9968cf and stv680 v4l1 drivers. This r

Re: [Linux-uvc-devel] again "Logitech QuickCam Pro for Notebooks 046d:0991"

2009-10-26 Thread Hans de Goede
Hi, On 10/26/2009 12:52 PM, Alexey Fisher wrote: Am Sonntag, den 25.10.2009, 14:21 +0100 schrieb Hans de Goede: Hi, On 10/25/2009 02:02 PM, Alexey Fisher wrote: Am Sonntag, den 25.10.2009, 13:17 +0100 schrieb Hans de Goede: Hi, On 10/22/2009 09:40 AM, Alexey Fisher wrote: Hi Laurent

Pull request: http://linuxtv.org/hg/~hgoede/gspca

2009-10-29 Thread Hans de Goede
Hi Mauro, Can you please pull from: http://linuxtv.org/hg/~hgoede/gspca For 2 more small mr97310a fixes (1 bugfix, 1 new usb id) Thanks & Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [Linux-uvc-devel] again "Logitech QuickCam Pro for Notebooks 046d:0991"

2009-10-29 Thread Hans de Goede
10:58:24 Alexey Fisher wrote: Am Mittwoch, den 28.10.2009, 00:27 +0100 schrieb Laurent Pinchart: On Monday 26 October 2009 15:06:41 Hans de Goede wrote: On 10/26/2009 12:52 PM, Alexey Fisher wrote: Am Sonntag, den 25.10.2009, 14:21 +0100 schrieb Hans de Goede: [snip] fwiw I'm a v4l k

Re: Problem compiling libv4l 0.6.3

2009-10-29 Thread Hans de Goede
Hi, On 10/28/2009 06:43 PM, Pierre wrote: # make make -C libv4lconvert V4L2_LIB_VERSION=0.6.3 all make[1]: Entering directory `/tmp/libv4l-0.6.3/libv4lconvert' gcc -Wp,-MMD,"libv4lconvert.d",-MQ,"libv4lconvert.o",-MP -c -I../include -I../../../include -fvisibility=hidden -fPIC -DLIBDIR=\"/usr/lo

Re: Problem compiling libv4l 0.6.3

2009-11-03 Thread Hans de Goede
Hi, On 11/02/2009 05:23 PM, Pierre wrote: Hans de Goede wrote: Hi, On 10/28/2009 06:43 PM, Pierre wrote: # make make -C libv4lconvert V4L2_LIB_VERSION=0.6.3 all make[1]: Entering directory `/tmp/libv4l-0.6.3/libv4lconvert' gcc -Wp,-MMD,"libv4lconvert.d",-MQ,"libv4l

Re: Another gpsca kernel BUG when disconnecting camera while streaming with mmap

2009-11-07 Thread Hans de Goede
Hi, On 11/04/2009 10:37 AM, Sean wrote: Hi, I am having a bug when removing my pac207 camera while capture-example is streaming with mmap. It doesn't always do it. This is a complete lock up - num lock key stops functioning. A related bug also happens sometimes when capture-example finishes, tha

Re: [PATCH 3/3] gspca pac7302/pac7311: separate the two subdrivers

2009-11-07 Thread Hans de Goede
Hi Németh, I'm getting similar reports for other (non pac73xx) model webcams with 2.6.32 on eeepc's and other computers using the uhci usb driver. Can you try installing an older kernel (so 2.6.30) and then building and installing the latest v4l-dvb tree (with your changes in) over that ? I thi

Re: pac7302: INFO: possible circular locking dependency detected

2009-11-08 Thread Hans de Goede
Hi, I've taken a long time to analyse the below lock dep report, and what can I say, it is nasty. This could happen (task could be a thread too): Task 1: Does a readdir on sysfs Task 1: Takes sysfs Mutex Task 2: Does an mmap on the video device Task 2: Takes mmap semphore Task 1: Is now stuck wa

Re: [PATCH] gspca pac7302: add edge detect control

2009-11-08 Thread Hans de Goede
Hi, On 11/07/2009 09:45 PM, Németh Márton wrote: From: Márton Németh Add edge detect control to pac7302 driver. When this control is turned on the camera image is switched to black and white and the edges are visualized. Bit 2 on page 0, register 0x55 controls this mode on Labtec Webcam 2200 (U

Re: [PATCH] gspca pac7302: add test pattern/overlay control

2009-11-08 Thread Hans de Goede
Hi, On 11/08/2009 12:05 AM, Németh Márton wrote: From: Márton Németh The Labtec Webcam 2200 (USB ID 093a:2626) device can produce some diagnostic patterns instead of the sensor image. An overlay test pattern also exsits which can be combined with the sensor image or with any test patterns. Add

Re: pac7302: INFO: possible circular locking dependency detected

2009-11-08 Thread Hans de Goede
Hi, On 11/08/2009 10:56 AM, Németh Márton wrote: Hi, Hans de Goede wrote: [snip] About the usb control msg errors, I don't think they are related to this issue at all, no real world app ever does a streamon and an mmap at the same time. As said if we could serialize mmap and ioctl

<    4   5   6   7   8   9   10   11   >