Hi Strakh:
Thanks for your patch.
But I prefer to remove the mutex_unlock() in the pd_vidioc_s_fmt(),
since the pd_vidioc_s_fmt() is also called in restore_v4l2_context().
would you please change the patch?
I will ack it.
Best Regards
Huang Shijie
2010/12/13 Alexander Strakh str...@ispras.ru
() fails and by explicitly
initializing 'i' to zero.
I also moved the variables 'mem' and 'urb' inside the for loop. This does
not actually make any difference, it just seemed more correct to me to let
variables exist only in the innermost scope they are used.
Acked-by: Huang Shijie shij
://www.telegent.com/press/2009Sept14_CSI.html
Huang Shijie (10):
add maitainers for tlg2300
add readme file for tlg2300
add Kconfig and Makefile for tlg2300
add header files for tlg2300
add the generic file
add video file for tlg2300
add vbi code for tlg2300
add audio support for tlg2300
From: root r...@localhost.localdomain
modify the two files for tlg2300.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/Kconfig |2 ++
drivers/media/video/Makefile |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/Kconfig b
add maitainers for the driver.
Signed-off-by: Huang Shijie shij...@gmail.com
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 60299a9..a8f02d6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5673,6 +5673,12 @@ F
add Kconfig and Makefile for tlg2300.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/Kconfig | 16
drivers/media/video/tlg2300/Makefile |9 +
2 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video
pd-common.h contains the common data structures, while
vendorcmds.h contains the vendor commands for firmware.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-common.h | 318 ++
drivers/media/video/tlg2300/vendorcmds.h | 243
pd-main.c contains the -probe(), it privides the generic
functions for analog TV,DVB-T and radio.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-main.c | 546 +
1 files changed, 546 insertions(+), 0 deletions(-)
create mode
pd-video.c and pd-bufqueue.c contain the code for V4L2 implementation.
The code support read,mmap and user pointer.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-bufqueue.c | 185
drivers/media/video/tlg2300/pd-video.c| 1636
This is the vbi module for tlg2300.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-vbi.c | 183 ++
1 files changed, 183 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd-vbi.c
diff --git a/drivers
The module uses ALSA for the audio, it will register
a new card for tlg2300.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-alsa.c | 379 +
1 files changed, 379 insertions(+), 0 deletions(-)
create mode 100644 drivers/media
This module contains the code for DVB-T.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-dvb.c | 649 ++
1 files changed, 649 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd-dvb.c
diff --git
adevice=hw=1,0:arate=48000 -rawaudio rate=48000:channels=2
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-radio.c | 383
1 files changed, 383 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/tlg2300/pd
+#ifdef CONFIG_PM
+/* Is the card working now ? */
+static inline int is_working(struct poseidon *pd)
+{
+ if (pd-state POSEIDON_STATE_IDLE_HIBERANTION)
+ return 0;
+ return pd-interface-pm_usage_cnt 0;
+}
+
+static int poseidon_suspend(struct usb_interface *intf,
thanks.
Acked-by: Huang Shijie shij...@gmail.com
On Thu, Jul 26, 2012 at 3:41 AM, Tim Gardner tim.gard...@canonical.com wrote:
Cc: Huang Shijie shij...@gmail.com
Cc: Kang Yong kangy...@telegent.com
Cc: Zhang Xiaobing xbzh...@telegent.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc
Carvalho Chehab mche...@infradead.org
Cc: Huang Shijie shij...@gmail.com
Cc: Kang Yong kangy...@telegent.com
Cc: Zhang Xiaobing xbzh...@telegent.com
Cc: linux-media@vger.kernel.org
Signed-off-by: Marcos Paulo de Souza marcos.souza@gmail.com
---
drivers/media/video/tlg2300/pd-video.c
is always false [-Wtype-limits]
Cc: Huang Shijie shij...@gmail.com
Cc: Kang Yong kangy...@telegent.com
Cc: Zhang Xiaobing xbzh...@telegent.com
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/usb/tlg2300/pd-video.c | 4 ++--
1 file changed, 2 insertions(+), 2
Em Wed, 09 Dec 2009 17:08:27 -0200
Mauro Carvalho Chehabmche...@redhat.com escreveu:
Huang Shijie wrote:
The TLG2300 is a chip of Telegent System.
It support analog tv,DVB-T and radio in a single chip.
The chip has been used in several dongles, such as aeromax DH-9000
pd-common.h contains the common data structures, while
vendorcmds.h contains the vendor commands for firmware.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-common.h | 280 ++
drivers/media/video/tlg2300/vendorcmds.h | 243
pd-main.c contains the -probe(), it privides the
generic functions for analog TV, DVB-T and radio.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-main.c | 566 +
1 files changed, 566 insertions(+), 0 deletions(-)
create mode
adevice=hw=1,0:arate=48000 -rawaudio
rate=48000:channels=2
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-radio.c | 351
1 files changed, 351 insertions(+), 0 deletions(-)
create mode 100644 drivers
The file contains the code for audio which uses the ALSA.
The audio will register a new card for tlg2300.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd-alsa.c | 332 +
1 files changed, 332 insertions(+), 0 deletions(-)
create
add Kconfig and Makefile for tlg2300 driver.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/Kconfig | 16
drivers/media/video/tlg2300/Makefile |9 +
2 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 drivers/media
This file contains the code for V4L2 implementation.
The VBI shares the same code with the video.
The code support read and mmap for IO, and you can
also choose the USB transfer mode : bulk or isochronous.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video
add the items for tlg2300 in the two files.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/Kconfig |2 ++
drivers/media/video/Makefile |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
I'm assuming that you're referring to the analog part, right?
right.
The country code only effects the Analog TV and radio, it has no
effect on DVB-T.
Instead of a country code, the driver should use the V4L2_STD_ macros to
If we are in the radio mode, I do not have any video
you mean that the frequency range can be used to set the pre-emphasis?
I am not sure about this.
ioctls. There's no standard way to control the preemphasis, but I recommend
adding a ctrl to select between 50us/75us and no preemphasis.
Best Regards
Huang Shijie
--
To unsubscribe from
,
Mauro
Best Regards
Huang Shijie
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
for an example on how to use it.
Ah, please submit those changes as another series of patches. This helps me
to not needing to review the entire changeset again.
Cheers,
Mauro
Best Regards
Huang Shijie
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
video :
use the V4L2_STD macros to select the proper audio setting.
radio :
add preemphasis ctr.
test it by the command:
v4l2-ctl -d /dev/radio0 --set-ctrl=pre_emphasis_settings=1
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media/video/tlg2300/pd
remove the the country code section.
Signed-off-by: Huang Shijie shij...@gmail.com
---
Documentation/video4linux/README.tlg2300 | 198 +
1 files changed, 7 insertions(+), 191 deletions(-)
diff --git a/Documentation/video4linux/README.tlg2300
b/Documentation
linux-next commit 2ff8223957d901999bf76aaf2c6183e33a6ad14e
exposes an infinite loop defect in scripts/get_maintainer.pl
Fix the incorrect format of the MAINTAINERS M: entries.
Signed-off-by: Joe Perchesj...@perches.com
thanks ,
acked by : Huang Shijie
---
diff --git a/MAINTAINERS b
thanks.
Acked-by: Huang Shijie shij...@gmail.com
linux-next commit 2ff8223957d901999bf76aaf2c6183e33a6ad14e
exposes an infinite loop defect in scripts/get_maintainer.pl
Fix the incorrect format of the MAINTAINERS M: entries.
Signed-off-by: Joe Perchesj...@perches.com
---
diff --git
From: Márton Némethnm...@freemail.hu
Make the local variables and functions static. Some of them are not exported by
their
symbol name but used trough other means. For example a pointer of the operation
structure is passed through a function call.
This will remove the following sparse
thanks.
Acked-by: Huang Shijie shij...@gmail.com
From: Márton Némethnm...@freemail.hu
Make the local variables and functions static. Some of them are not exported by
their
symbol name but used trough other means. For example a pointer of the operation
structure is passed through a function
The function poseidon_fe_release is redundent in fact, I will remove it
in future.
But now I still acked this patch. thanks a lot.
Acked-by: Huang Shijie shij...@gmail.com
From: Márton Némethnm...@freemail.hu
When power management is not configured (CONFIG_PM) then some code is no longer
The orgin parameters may cause a bug : The audio may lost in certain
situation (such as open the VLC at the first time).
The origin parameters set a small stop_threshold for snd_pcm_runtime{}.
So a xrun occurs in some situation.
Signed-off-by: Huang Shijie shij...@gmail.com
---
drivers/media
Hi Mauro:
Please ignore this patch.
This patch has side effect : the radio does not run well with this patch.
Best Regards
Huang Shijie.
The orgin parameters may cause a bug : The audio may lost in certain
situation (such as open the VLC at the first time).
The origin parameters set a small
). the
radio runs well.
Do you have any advice ? Do you think this is a problem?
thanks.
Best Regards
Huang Shijie.
The orgin parameters may cause a bug : The audio may lost in certain
situation (such as open the VLC at the first time).
The origin parameters set a small stop_threshold
might be used
for further work.
Could you tell me how did you test your patch set?
did you test the hibernate and suspend/resume?
Huang Shijie, are you still able to act as maintainer? If not, then I can
put my name in. The MAINTAINER status should probably move to 'Odd Fixes'
Yes, you can
On Fri, Feb 1, 2013 at 3:49 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Fri February 1 2013 03:22:22 Huang Shijie wrote:
Hi Hans:
On Thu, Jan 31, 2013 at 6:25 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi all,
Last year I worked on this driver to improve it and fix v4l2-compliance
*/
snprintf(pd-v4l2_dev.name, sizeof(pd-v4l2_dev.name), %s %s,
dev-driver-name, dev_name(dev));
I think this line could be removed in this patch too. The
v4l2_device_register() will assign the v4l2_dev-name if it's empty.
thanks
Huang Shijie
- ret
err;
}
- p-radio_data.fm_dev = fm_dev;
return 0;
}
thanks.
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
will test it in my office.
thanks
Huang Shijie
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/tlg2300/pd-radio.c | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/media/usb/tlg2300/pd-radio.c
b/drivers/media/usb/tlg2300/pd-radio.c
)
{
- destroy_video_device(p-radio_data.fm_dev);
return 0;
}
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, VFL_TYPE_RADIO, -1);
}
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
于 2013年01月31日 05:25, Hans Verkuil 写道:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/tlg2300/pd-radio.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/tlg2300/pd-radio.c
);
v4l2_ctrl_handler_free(p-radio_data.ctrl_handler);
return 0;
}
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
|= V4L2_CAP_VIDEO_CAPTURE;
+ cap-capabilities = cap-device_caps | V4L2_CAP_DEVICE_CAPS |
+ V4L2_CAP_RADIO | V4L2_CAP_VBI_CAPTURE | V4L2_CAP_VIDEO_CAPTURE;
return 0;
}
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media
);
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
if (ret != 0)
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
return 0;
}
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
with this video input,
* Poseidon only have one audio/video, set to 0
*/
- in-audioset= 0;
+ in-audioset= 1;
i think it should be 0. it's need to be test.
thanks
Huang Shijie
in-tuner = 0;
in-std = V4L2_STD_ALL;
in-status = 0
*/
.vidioc_g_tuner = vidioc_g_tuner,
.vidioc_s_tuner = vidioc_s_tuner,
+ .vidioc_g_std = vidioc_g_std,
.vidioc_s_std = vidioc_s_std,
.vidioc_g_frequency = vidioc_g_frequency,
.vidioc_s_frequency = vidioc_s_frequency,
Acked-by: Huang Shijie
--;
}
+ if (!pd-vbi_data.users !pd-video_data.users)
+ pd-state = ~POSEIDON_STATE_ANALOG;
videobuf_stop(front-q);
videobuf_mmap_free(front-q);
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-media
);
@@ -1416,7 +1398,6 @@ static int pd_video_release(struct file *file)
struct poseidon *pd = front-pd;
s32 cmd_status = 0;
- logs(front);
mutex_lock(pd-lock);
if (front-type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
Acked-by: Huang Shijie shij...@gmail.com
(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 975ba7c..00bb196 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6778,8 +6778,6 @@ F: drivers/clocksource
TLG2300 VIDEO4LINUX-2 DRIVER
M: Huang Shijie shij...@gmail.com
-M: Kang Yong kangy...@telegent.com
-M: Zhang Xiaobing xbzh
,
- .vidioc_g_input = vidioc_g_input,
- .vidioc_s_input = vidioc_s_input,
.vidioc_queryctrl = tlg_fm_vidioc_queryctrl,
.vidioc_querymenu = tlg_fm_vidioc_querymenu,
.vidioc_g_ctrl = tlg_fm_vidioc_g_ctrl,
I tested this patch. it seems ok.
thanks.
Acked-by: Huang Shijie
?? 2013??02??04?? 03:38, Hans Verkuil :
On Mon February 4 2013 05:36:56 Huang Shijie wrote:
?? 2013??01??31?? 05:25, Hans Verkuil :
From: Hans Verkuilhans.verk...@cisco.com
Signed-off-by: Hans Verkuilhans.verk...@cisco.com
---
drivers/media/usb/tlg2300/pd-radio.c |7 ++-
1
with this video input,
* Poseidon only have one audio/video, set to 0
*/
- in-audioset= 0;
+ in-audioset= 1;
in-tuner = 0;
in-std = V4L2_STD_ALL;
in-status = 0;
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe from this list
);
-MODULE_DESCRIPTION(For tlg2300-based USB device );
+MODULE_DESCRIPTION(For tlg2300-based USB device);
MODULE_LICENSE(GPL);
MODULE_VERSION(0.0.2);
MODULE_FIRMWARE(TLG2300_FIRMWARE);
--
1.7.10.4
sorry for the later reply. I was on vacation.
Acked-by: Huang Shijie shij...@gmail.com
--
To unsubscribe
---
MAINTAINERS |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5334229..9a83a1c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6794,9 +6794,8 @@ F:drivers/clocksource
TLG2300 VIDEO4LINUX-2 DRIVER
M: Huang Shijie shij
64 matches
Mail list logo
