[PATCH v6 01/10] leds: unify the location of led-trigger API

2015-04-28 Thread Jacek Anaszewski
inline to match the style of the surrounding code. Signed-off-by: Jacek Anaszewski Cc: Bryan Wu Cc: Richard Purdie Acked-by: Sakari Ailus --- drivers/leds/leds.h | 24 include/linux/leds.h | 25 + 2 files changed, 25 insertions(+), 24

[PATCH v6 00/10] LED / flash API integration

2015-04-28 Thread Jacek Anaszewski
ted entry in Kconfig Thanks, Jacek Anaszewski [1] http://www.spinics.net/lists/kernel/msg1944538.html Jacek Anaszewski (10): leds: unify the location of led-trigger API DT: Add documentation for the mfd Maxim max77693 leds: Add support for max77693 mfd flash cell DT: Add documentation for

[PATCH v6 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-28 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Lee Jones Cc: Chanwoo Choi Cc: Bryan Wu Cc: Richard Purdie Cc

[PATCH v6 04/10] DT: Add documentation for the Skyworks AAT1290

2015-04-28 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/leds/leds-aat1290

[PATCH v6 07/10] Documentation: leds: Add description of v4l2-flash sub-device

2015-04-28 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 47 +++ 1 file

[PATCH v6 03/10] leds: Add support for max77693 mfd flash cell

2015-04-28 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

[PATCH v6 06/10] media: Add registration helpers for V4L2 flash sub-devices

2015-04-28 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- drivers/media/v4l2-core/Kconfig| 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash-led-class.c |

[PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller

2015-04-28 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie

[PATCH v6 09/10] DT: aat1290: Document handling external strobe sources

2015-04-28 Thread Jacek Anaszewski
This patch adds documentation for a pinctrl-names property. The property, when present, is used for switching the source of the strobe signal for the device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus Cc: devicet

[PATCH v6 08/10] leds: max77693: add support for V4L2 Flash sub-device

2015-04-28 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH v6 10/10] leds: aat1290: add support for V4L2 Flash sub-device

2015-04-28 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

Re: [PATCH v6 10/10] leds: aat1290: add support for V4L2 Flash sub-device

2015-04-28 Thread Jacek Anaszewski
Hi Sakari, On 04/28/2015 04:02 PM, Sakari Ailus wrote: Hi Jacek, On Tue, Apr 28, 2015 at 09:18:50AM +0200, Jacek Anaszewski wrote: Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash

S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Jacek Anaszewski
ctrls [3] b08d8d26 [media] media/v4l2-ctrls: volatiles should not generate CH_VALUE -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Jacek Anaszewski
Hi Hans, On 04/29/2015 09:53 AM, Hans Verkuil wrote: Hi Jacek, On 04/29/15 09:33, Jacek Anaszewski wrote: Hi, After testing my v4l2-flash helpers patch [1] with the recent patches for v4l2-ctrl.c ([2] and [3]) s_ctrl op isn't called despite setting the value that should be aligned t

Re: S_CTRL must be called twice to set volatile controls

2015-04-29 Thread Jacek Anaszewski
Hi Sakari, On 04/29/2015 02:01 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Apr 29, 2015 at 10:58:20AM +0200, Jacek Anaszewski wrote: Hi Hans, On 04/29/2015 09:53 AM, Hans Verkuil wrote: Hi Jacek, On 04/29/15 09:33, Jacek Anaszewski wrote: Hi, After testing my v4l2-flash helpers patch [1

Re: [PATCH v5 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-29 Thread Jacek Anaszewski
On 04/29/2015 02:34 PM, Lee Jones wrote: LED Ack please Bryan. You've already applied v6 with Bryan's ack today :) This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: And

[PATCH v7] Documentation: leds: Add description of v4l2-flash sub-device

2015-04-30 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 47

[PATCH v7] leds: Add driver for AAT1290 flash LED controller

2015-04-30 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie --- Fixed

[PATCH v7] leds: Add support for max77693 mfd flash cell

2015-04-30 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

[PATCH v7] media: Add registration helpers for V4L2 flash sub-devices

2015-04-30 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- - moved enum ctrl_init_data_id definition from *.c to *.h file and switched to allocating the memory for ctrls property of struct v4l2_flash dynamically - set V4L2_CTRL_FLAG_EXECUTE_ON_

Re: [PATCH v1 09/11] DT: Add documentation for exynos4-is 'flashes' property

2015-04-30 Thread Jacek Anaszewski
Hi Sakari and Sylwester, On 04/03/2015 12:53 PM, Sylwester Nawrocki wrote: Hello, On 25/03/15 09:52, Jacek Anaszewski wrote: On 03/25/2015 02:06 AM, Sakari Ailus wrote: On Fri, Mar 20, 2015 at 04:03:29PM +0100, Jacek Anaszewski wrote: This patch adds a description of 'flashes' p

Re: [PATCH 4/5] leds: aat1290: Pass dev and dev->of_node to v4l2_flash_init()

2015-05-20 Thread Jacek Anaszewski
gt;dev, not dev, which is &pdev->dev, whereas led_cdev->dev is returned by device_create_with_groups (it takes dev as a parent) called from led_classdev_register. if (IS_ERR(led->v4l2_flash)) { ret = PTR_ERR(led->v4l2_flash); goto er

Re: [PATCH 4/5] leds: aat1290: Pass dev and dev->of_node to v4l2_flash_init()

2015-05-20 Thread Jacek Anaszewski
On 05/20/2015 11:47 AM, Jacek Anaszewski wrote: Hi Sakari, On 05/20/2015 01:04 AM, Sakari Ailus wrote: Signed-off-by: Sakari Ailus --- drivers/leds/leds-aat1290.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds

Re: [PATCH 4/5] leds: aat1290: Pass dev and dev->of_node to v4l2_flash_init()

2015-05-20 Thread Jacek Anaszewski
On 05/20/2015 02:27 PM, Sakari Ailus wrote: Hi Jacek, On Wed, May 20, 2015 at 12:37:03PM +0200, Jacek Anaszewski wrote: On 05/20/2015 11:47 AM, Jacek Anaszewski wrote: Hi Sakari, On 05/20/2015 01:04 AM, Sakari Ailus wrote: Signed-off-by: Sakari Ailus --- drivers/leds/leds-aat1290.c

[PATCH v8 0/8] LED / flash API integration

2015-05-20 Thread Jacek Anaszewski
in v4l2-flash helpers detected with yavta - cleaned up AAT1290 device tree documentation - added GPIOLIB dependecy to AAT1290 related entry in Kconfig Thanks, Jacek Anaszewski [1] http://www.spinics.net/lists/kernel/msg1944538.html [2] http://www.spinics.net/lists/linux-media/msg89839.html Jace

[PATCH v8 1/8] media: Add registration helpers for V4L2 flash sub-devices

2015-05-20 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- drivers/media/v4l2-core/Kconfig| 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash-led-class.c |

[PATCH v8 2/8] leds: max77693: add support for V4L2 Flash sub-device

2015-05-20 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH v8 4/8] leds: aat1290: add support for V4L2 Flash sub-device

2015-05-20 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH v8 3/8] DT: aat1290: Document handling external strobe sources

2015-05-20 Thread Jacek Anaszewski
This patch adds documentation for a pinctrl-names property. The property, when present, is used for switching the source of the strobe signal for the device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus Cc: devicet

[PATCH v8 5/8] exynos4-is: Add support for v4l2-flash subdevs

2015-05-20 Thread Jacek Anaszewski
This patch adds support for external v4l2-flash devices. The support includes parsing "samsung,flash-led" DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/m

[PATCH v8 6/8] DT: s5c73m3: Add documentation for samsung,flash-led property

2015-05-20 Thread Jacek Anaszewski
This patch adds a description of 'samsung,flash-led' property to the samsung-s5c73m3.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/media/samsung-s5c73m3.txt |5 + 1 file

[PATCH v8 7/8] DT: s5k6a3: Add documentation for samsung,flash-led property

2015-05-20 Thread Jacek Anaszewski
This patch adds a description of 'samsung,flash-led' property to the samsung-s5k6a3.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/media/samsung-s5k6a3.txt |4 1 file

[PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

2015-05-20 Thread Jacek Anaszewski
This patch adds examples for samsung,flash-led property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/media/samsung-fimc.txt |4 1 file changed, 4 insertions

Re: [PATCH 1/5] v4l: async: Add a pointer to of_node to struct v4l2_subdev, match it

2015-05-20 Thread Jacek Anaszewski
f_node. */ + struct device_node *of_node; /* Links this subdev to a global subdev_list or @notifier->done list. */ struct list_head async_list; /* Pointer to respective struct v4l2_async_subdev. */ I've tested it with V4L2_ASYNC_MATCH_OF matching type. For this you can a

Re: [PATCH 4/5] leds: aat1290: Pass dev and dev->of_node to v4l2_flash_init()

2015-05-21 Thread Jacek Anaszewski
Hi Sakari, On 05/20/2015 04:31 PM, Sakari Ailus wrote: Hi Jacek, On Wed, May 20, 2015 at 03:47:25PM +0200, Jacek Anaszewski wrote: ... --- a/drivers/leds/leds-aat1290.c +++ b/drivers/leds/leds-aat1290.c @@ -524,9 +524,8 @@ static int aat1290_led_probe(struct platform_device *pdev

Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

2015-05-21 Thread Jacek Anaszewski
Hi Sakari, On 05/21/2015 12:00 AM, Sakari Ailus wrote: Hi Jacek, On Wed, May 20, 2015 at 04:10:15PM +0200, Jacek Anaszewski wrote: This patch adds examples for samsung,flash-led property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki

Re: [PATCH v8 5/8] exynos4-is: Add support for v4l2-flash subdevs

2015-05-21 Thread Jacek Anaszewski
On 05/21/2015 09:46 AM, Sakari Ailus wrote: Hi Jacek, On Wed, May 20, 2015 at 04:10:12PM +0200, Jacek Anaszewski wrote: This patch adds support for external v4l2-flash devices. The support includes parsing "samsung,flash-led" DT property and asynchronous subdevice registration.

Re: [PATCH 4/5] leds: aat1290: Pass dev and dev->of_node to v4l2_flash_init()

2015-05-21 Thread Jacek Anaszewski
Hi Sakari On 05/21/2015 12:06 PM, Sakari Ailus wrote: [...] On Wed, May 20, 2015 at 03:47:25PM +0200, Jacek Anaszewski wrote: ... --- a/drivers/leds/leds-aat1290.c +++ b/drivers/leds/leds-aat1290.c @@ -524,9 +524,8 @@ static int aat1290_led_probe(struct platform_device *pdev) led_cdev

Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

2015-05-25 Thread Jacek Anaszewski
ate a null entry if needed. When it should be needed? Similarly we could create properties for other sub-devices of a camera module, like lenses, etc. -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a mes

[PATCH v9 8/8] exynos4-is: Add support for v4l2-flash subdevs

2015-05-25 Thread Jacek Anaszewski
This patch adds support for external v4l2-flash devices. The support includes parsing "camera-flashes" DT property and asynchronous sub-device registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-de

[PATCH v9 7/8] DT: Add documentation for exynos4-is 'flashes' property

2015-05-25 Thread Jacek Anaszewski
This patch adds a description of 'samsung,camera-flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- .../devicetree/bindings/media/samsung-fimc.txt | 10 ++ 1 file changed, 10 insertions(+) di

[PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-05-25 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- drivers/media/v4l2-core/Kconfig| 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash-led-class.c |

[PATCH v9 1/8] Documentation: leds: Add description of v4l2-flash sub-device

2015-05-25 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 50 +++ 1 file changed, 50

[PATCH v9 6/8] exynos4-is: Improve the mechanism of async subdevs verification

2015-05-25 Thread Jacek Anaszewski
categorizing async sub-devices by their type upon DT node parsing and recognizing the type easily when they're being bound. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-dev.c | 34 +++-- drivers/

[PATCH v9 3/8] leds: max77693: add support for V4L2 Flash sub-device

2015-05-25 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH v9 0/8] LED / flash API integration

2015-05-25 Thread Jacek Anaszewski
tected with yavta - cleaned up AAT1290 device tree documentation - added GPIOLIB dependecy to AAT1290 related entry in Kconfig Thanks, Jacek Anaszewski [1] http://www.spinics.net/lists/kernel/msg1944538.html [2] http://www.spinics.net/lists/linux-media/msg89839.html Jacek Anaszewski (8): Docume

[PATCH v9 4/8] DT: aat1290: Document handling external strobe sources

2015-05-25 Thread Jacek Anaszewski
This patch adds documentation for a pinctrl-names property. The property, when present, is used for switching the source of the strobe signal for the device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus Cc: devicet

[PATCH v9 5/8] leds: aat1290: add support for V4L2 Flash sub-device

2015-05-25 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

Re: [PATCH v8 8/8] DT: samsung-fimc: Add examples for samsung,flash-led property

2015-05-25 Thread Jacek Anaszewski
On 05/25/2015 04:28 PM, Sylwester Nawrocki wrote: On 25/05/15 14:50, Jacek Anaszewski wrote: On 23/05/15 14:03, Sakari Ailus wrote: On Thu, May 21, 2015 at 03:28:40PM +0200, Sylwester Nawrocki wrote: flash-leds = <&flash_xx &image_sensor_x>, <...>; One more matter to c

Re: [PATCH v9 8/8] exynos4-is: Add support for v4l2-flash subdevs

2015-05-26 Thread Jacek Anaszewski
Hi Sylwester, Thanks for the review. On 05/26/2015 11:04 AM, Sylwester Nawrocki wrote: On 25/05/15 17:14, Jacek Anaszewski wrote: This patch adds support for external v4l2-flash devices. The support includes parsing "camera-flashes" DT property "samsung,camera-flashes&qu

Re: [PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-02 Thread Jacek Anaszewski
Hi Sakari, On 06/01/2015 10:59 PM, Sakari Ailus wrote: Hi Jacek, On Mon, May 25, 2015 at 05:13:57PM +0200, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem

Re: [PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-03 Thread Jacek Anaszewski
Hi Sakari, On 06/02/2015 05:32 PM, Sakari Ailus wrote: Hi, Jacek! On Tue, Jun 02, 2015 at 11:13:54AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 06/01/2015 10:59 PM, Sakari Ailus wrote: Hi Jacek, On Mon, May 25, 2015 at 05:13:57PM +0200, Jacek Anaszewski wrote: This patch adds helper

Re: [PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-08 Thread Jacek Anaszewski
Hi Sakari, On 06/03/2015 10:59 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Jun 03, 2015 at 09:56:39AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 06/02/2015 05:32 PM, Sakari Ailus wrote: Hi, Jacek! On Tue, Jun 02, 2015 at 11:13:54AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 06/01/2015

Re: [PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-08 Thread Jacek Anaszewski
On 06/08/2015 09:37 AM, Sakari Ailus wrote: Hi Jacek, On Mon, Jun 08, 2015 at 09:21:10AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 06/03/2015 10:59 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Jun 03, 2015 at 09:56:39AM +0200, Jacek Anaszewski wrote: Hi Sakari, On 06/02/2015 05:32 PM

[PATCH v10 4/8] DT: aat1290: Document handling external strobe sources

2015-06-08 Thread Jacek Anaszewski
This patch adds documentation for a pinctrl-names property. The property, when present, is used for switching the source of the strobe signal for the device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus Cc: devicet

[PATCH v10 1/8] Documentation: leds: Add description of v4l2-flash sub-device

2015-06-08 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 51 +++ 1 file changed, 51

[PATCH v10 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-08 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- drivers/media/v4l2-core/Kconfig| 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash-led-class.c |

[PATCH v10 0/8] LED / flash API integration

2015-06-08 Thread Jacek Anaszewski
tion - added GPIOLIB dependecy to AAT1290 related entry in Kconfig Thanks, Jacek Anaszewski [1] http://www.spinics.net/lists/kernel/msg1944538.html [2] http://www.spinics.net/lists/linux-media/msg89839.html Jacek Anaszewski (8): Documentation: leds: Add description of v4l2-flash sub-device m

[PATCH v10 3/8] leds: max77693: add support for V4L2 Flash sub-device

2015-06-08 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH v10 7/8] DT: Add documentation for exynos4-is 'flashes' property

2015-06-08 Thread Jacek Anaszewski
This patch adds a description of 'samsung,camera-flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/media/samsung-fimc.txt | 10 ++ 1 fi

[PATCH v10 6/8] exynos4-is: Improve the mechanism of async subdevs verification

2015-06-08 Thread Jacek Anaszewski
categorizing async sub-devices by their type upon DT node parsing and recognizing the type easily when they're being bound. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-dev.c | 34 +++-- drivers/

[PATCH v10 5/8] leds: aat1290: add support for V4L2 Flash sub-device

2015-06-08 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH v10 8/8] exynos4-is: Add support for v4l2-flash subdevs

2015-06-08 Thread Jacek Anaszewski
This patch adds support for external v4l2-flash devices. The support includes parsing "camera-flashes" DT property and asynchronous sub-device registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-de

Re: [v4l-utils PATCH/RFC v5 00/14] Add a plugin for Exynos4 camera

2015-06-08 Thread Jacek Anaszewski
useful to have a working plugin as an example in v4l-utils. Regards, Hans On 02/26/2015 04:59 PM, Jacek Anaszewski wrote: This is a fifth version of the patch series adding a plugin for the Exynos4 camera. Temporarily the plugin doesn't link against libmediactl, but has its sour

Re: [v4l-utils PATCH/RFC v5 00/14] Add a plugin for Exynos4 camera

2015-06-08 Thread Jacek Anaszewski
On 06/08/2015 11:36 AM, Hans Verkuil wrote: On 06/08/2015 11:14 AM, Jacek Anaszewski wrote: Hi Hans, It got stuck on this version. I have some slight improvements locally but haven't sent them as there hasn't been any comment to this so far. AFAIR Sakari had some doubts about handlin

Re: [PATCH v9 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-18 Thread Jacek Anaszewski
Hi Alexey, On 06/18/2015 07:45 PM, Alexey Klimov wrote: Hi Jacek, On Mon, May 25, 2015 at 6:13 PM, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device

[PATCH v10.1] media: Add registration helpers for V4L2 flash sub-devices

2015-06-19 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- - fixed possible NULL fled_cdev pointer dereference in the v4l2_flash_init function drivers/media/v4l2-core/Kconfig| 11 + drivers/media/v4l2-core/Makefile |

[PATCH] leds: aat1290: Add 'static' modifier to init_mm_current_scale

2015-06-19 Thread Jacek Anaszewski
Fix sparse warning by adding static modifier to the function init_mm_current_scale. Signed-off-by: Jacek Anaszewski --- drivers/leds/leds-aat1290.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-aat1290.c b/drivers/leds/leds-aat1290.c index 8635404

[PATCH v10.1] leds: aat1290: add support for V4L2 Flash sub-device

2015-06-19 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- - fixed

[PATCH 00/16] Add support for Exynox4x12 to the s5p-jpeg driver

2013-11-19 Thread Jacek Anaszewski
The main aim of this series is to add support for Exynos4x12 SoC for the s5p-jpeg driver. Nonetheless, a room for couple of fixes and improvements has been found during development, which is reflected in the corresponding patches. Thanks, Jacek Anaszewski Jacek Anaszewski (16): s5p-jpeg

[PATCH 02/16] s5p-jpeg: Fix output YUV 4:2:0 fourcc for decoder

2013-11-19 Thread Jacek Anaszewski
Output samples during decoding phase for the YUV 4:2:0 format are arranged in the manner compatible with 2-planar NV12, not 3-planar YUV420 fourcc. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- 1 file changed, 1

[PATCH 01/16] s5p-jpeg: Reorder quantization tables

2013-11-19 Thread Jacek Anaszewski
modification allows also to get rid of reverse logic in the s_ctrl callback while assigning user space value to the ctx->compr_quality variable. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 116 +--

[PATCH 03/16] s5p-jpeg: Fix erroneous condition while validating bytesperline value

2013-11-19 Thread Jacek Anaszewski
d, by that value to get the number of bytes required to store single line of image samples. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p

[PATCH 13/16] s5p-jpeg: Allow for wider JPEG subsampling scope for Exynos4x12 encoder

2013-11-19 Thread Jacek Anaszewski
Exynos4x12 supports wider scope of subsampling modes than S5PC210. Adjust corresponding mask accordingly. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH 07/16] s5p-jpeg: Fix lack of spin_lock protection

2013-11-19 Thread Jacek Anaszewski
s5p_jpeg_device_run and s5p_jpeg_runtime_resume callbacks should have spin_lock protection as they alter device registers. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 11 ++- 1 file changed, 10 insertions(+), 1

[PATCH 06/16] s5p-jpeg: Fix clock resource management

2013-11-19 Thread Jacek Anaszewski
moves control of jpeg clock to runtime_pm callbacks. Signed-off-by: Marek Szyprowski Signed-off-by: Seung-Woo Kim Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 52 ++- 1 file changed, 36 insertions

[PATCH 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-11-19 Thread Jacek Anaszewski
setting an illegal subsampling mode for Exynos4x12 encoder. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p

[PATCH 09/16] s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c

2013-11-19 Thread Jacek Anaszewski
Move function definitions from jpeg-hw.h to jpeg-hw-s5p.c and put function declarations in the jpeg-hw-s5p.h. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c|2

[PATCH 11/16] s5p-jpeg: Retrieve "YCbCr subsampling" field from the jpeg header

2013-11-19 Thread Jacek Anaszewski
device as the decoding process will not succeed if the destination format is set to YUV with subsampling lower than the one of the source JPEG image. With this knowledge the driver can adjust the destination format appropriately. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --

[PATCH 10/16] s5p-jpeg: Add hardware API for the exynos4x12 JPEG codec.

2013-11-19 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 620 +++--- drivers/media/platform/s5p-jpeg/jpeg-core.h | 72 ++- drivers/media/platform/s5p

[PATCH 16/16] s5p-jpeg: Adjust g_volatile_ctrl callback to Exynos4x12 needs

2013-11-19 Thread Jacek Anaszewski
Whereas S5PC210 device produces decoded JPEG subsampling values that map on V4L2_JPEG_CHROMA_SUBSAMPLNG values, the Exynos4x12 device doesn't. This patch adds helper function decoded_subsampling_to_v4l2, which performs HW -> V4L2 translation. Signed-off-by: Jacek Anaszewski Signe

[PATCH 15/16] s5p-jpeg: Ensure setting correct value of the chroma subsampling control

2013-11-19 Thread Jacek Anaszewski
prevents setting invalid value of the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 08/16] s5p-jpeg: Synchronize cached controls with V4L2 core

2013-11-19 Thread Jacek Anaszewski
This patch adds proper initialization of the in-driver cached state of JPEG controls with V4L2 core. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/s5p

[PATCH 12/16] s5p-jpeg: Ensure correct capture format for Exynos4x12

2013-11-19 Thread Jacek Anaszewski
Adjust capture format to the Exynos4x12 device limitations, according to the subsampling value parsed from the source JPEG image header. If the capture format was set to YUV with subsampling lower than the one of the source JPEG image the decoding process would not succeed. Signed-off-by: Jacek

[PATCH 04/16] s5p-jpeg: Remove superfluous call to the jpeg_bound_align_image function

2013-11-19 Thread Jacek Anaszewski
Aligning capture queue image dimensions while enqueuing output queue doesn't make a sense as the S_FMT ioctl might have not been called for the capture queue until that moment, whereas it is required to know capture format as the type of alignment heavily depends on it. Signed-off-by:

[PATCH 05/16] s5p-jpeg: Rename functions specific to the S5PC210 SoC accordingly

2013-11-19 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 58 --- 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg

Re: [PATCH 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-11-20 Thread Jacek Anaszewski
On 11/19/2013 03:46 PM, Hans Verkuil wrote: On 11/19/2013 03:27 PM, Jacek Anaszewski wrote: When output queue fourcc is set to any flavour of YUV, the V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value as well as its in-driver cached counterpart have to be updated with the subsampling property of

[PATCH v2 00/16] Add support for Exynox4x12 to the s5p-jpeg driver

2013-11-25 Thread Jacek Anaszewski
s5p_jpeg_to_user_subsampling - added freeing ctrl_handler when v4l2_ctrl_handler_setup fails - calling s5p_jpeg_runtime_suspend and s5p_jpeg_runtime_resume only when pm_runtime_suspended returns false Thanks, Jacek Anaszewski Jacek Anaszewski (16): s5p-jpeg: Reorder quantization tables s5p-jpeg

[PATCH v2 03/16] s5p-jpeg: Fix erroneous condition while validating bytesperline value

2013-11-25 Thread Jacek Anaszewski
d, by that value to get the number of bytes required to store single line of image samples. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p

[PATCH v2 02/16] s5p-jpeg: Fix output YUV 4:2:0 fourcc for decoder

2013-11-25 Thread Jacek Anaszewski
Output samples during decoding phase for the YUV 4:2:0 format are arranged in the manner compatible with 2-planar NV12, not 3-planar YUV420 fourcc. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- 1 file changed, 1

[PATCH v2 04/16] s5p-jpeg: Remove superfluous call to the jpeg_bound_align_image function

2013-11-25 Thread Jacek Anaszewski
Aligning capture queue image dimensions while enqueuing output queue doesn't make a sense as the S_FMT ioctl might have not been called for the capture queue until that moment, whereas it is required to know capture format as the type of alignment heavily depends on it. Signed-off-by:

[PATCH v2 11/16] s5p-jpeg: Retrieve "YCbCr subsampling" field from the jpeg header

2013-11-25 Thread Jacek Anaszewski
device as the decoding process will not succeed if the destination format is set to YUV with subsampling lower than the one of the source JPEG image. With this knowledge the driver can adjust the destination format appropriately. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --

[PATCH v2 10/16] s5p-jpeg: Add hardware API for the exynos4x12 JPEG codec.

2013-11-25 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 620 +++--- drivers/media/platform/s5p-jpeg/jpeg-core.h | 72 ++- drivers/media/platform/s5p

[PATCH v2 01/16] s5p-jpeg: Reorder quantization tables

2013-11-25 Thread Jacek Anaszewski
modification allows also to get rid of reverse logic in the s_ctrl callback while assigning user space value to the ctx->compr_quality variable. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 116 +--

[PATCH v2 07/16] s5p-jpeg: Fix lack of spin_lock protection

2013-11-25 Thread Jacek Anaszewski
s5p_jpeg_device_run and s5p_jpeg_runtime_resume callbacks should have spin_lock protection as they alter device registers. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 11 ++- 1 file changed, 10 insertions(+), 1

[PATCH v2 12/16] s5p-jpeg: Ensure correct capture format for Exynos4x12

2013-11-25 Thread Jacek Anaszewski
Adjust capture format to the Exynos4x12 device limitations, according to the subsampling value parsed from the source JPEG image header. If the capture format was set to YUV with subsampling lower than the one of the source JPEG image the decoding process would not succeed. Signed-off-by: Jacek

[PATCH v2 09/16] s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c

2013-11-25 Thread Jacek Anaszewski
Move function definitions from jpeg-hw.h to jpeg-hw-s5p.c and put function declarations in the jpeg-hw-s5p.h. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/Makefile |2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c|2

[PATCH v2 13/16] s5p-jpeg: Allow for wider JPEG subsampling scope for Exynos4x12 encoder

2013-11-25 Thread Jacek Anaszewski
Exynos4x12 supports wider scope of subsampling modes than S5PC210. Adjust corresponding mask accordingly. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 05/16] s5p-jpeg: Rename functions specific to the S5PC210 SoC accordingly

2013-11-25 Thread Jacek Anaszewski
Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 58 --- 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg

[PATCH v2 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value

2013-11-25 Thread Jacek Anaszewski
setting an illegal subsampling mode for Exynos4x12 encoder. Signed-off-by: Jacek Anaszewski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-jpeg/jpeg-core.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform

<    1   2   3   4   5   6   7   8   >