Re: [PATCH/RFC v8 06/14] media: Add registration helpers for V4L2 flash sub-devices

2014-12-01 Thread Jacek Anaszewski
On 11/28/2014 10:17 AM, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled

[PATCH/RFC v9 18/19] leds: max77693: add support for V4L2 Flash sub-device

2014-12-03 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu

[PATCH/RFC v9 19/19] leds: aat1290: add support for V4L2 Flash sub-device

2014-12-03 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu

[PATCH/RFC v9 17/19] DT: Add documentation for exynos4-is 'flashes' property

2014-12-03 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m

[PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-03 Thread Jacek Anaszewski
Add label array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Added is also an array for caching pointers to the sub-nodes representing sub-leds. Signed-off-by: Jacek Anaszewski j.anaszew

[PATCH/RFC v9 11/19] v4l2-async: change custom.match callback argument type

2014-12-03 Thread Jacek Anaszewski
It is useful to have an access to the async sub-device being matched, not only to the related struct device. Change match callback argument from struct device to struct v4l2_subdev. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc

[PATCH/RFC v9 09/19] of: Add Skyworks Solutions, Inc. vendor prefix

2014-12-03 Thread Jacek Anaszewski
Use skyworks as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell

[PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-03 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lee Jones lee.jo

[PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-03 Thread Jacek Anaszewski
Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com Cc: Lee Jones lee.jo...@linaro.org

[PATCH/RFC v9 14/19] media: Add registration helpers for V4L2 flash sub-devices

2014-12-03 Thread Jacek Anaszewski
will be used. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media

[PATCH/RFC v9 15/19] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-03 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com Cc: Bryan Wu coolo

[PATCH/RFC v9 07/19] dt-binding: mfd: max77693: Add DT binding related macros

2014-12-03 Thread Jacek Anaszewski
Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lee Jones lee.jo...@linaro.org Cc: Chanwoo Choi cw00.c...@samsung.com --- include/dt-bindings/mfd/max77693.h | 38

[PATCH/RFC v9 16/19] exynos4-is: Add support for v4l2-flash subdevs

2014-12-03 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro

[PATCH/RFC v9 13/19] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2014-12-03 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai

[PATCH/RFC v9 10/19] DT: Add documentation for the Skyworks AAT1290

2014-12-03 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: Rob Herring robh

[PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-03 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v9 08/19] leds: Add driver for AAT1290 current regulator

2014-12-03 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo

[PATCH/RFC v9 12/19] v4l2-async: add V4L2_ASYNC_MATCH_CUSTOM_OF matching type

2014-12-03 Thread Jacek Anaszewski
V4L2_ASYNC_MATCH_CUSTOM_OF matching type to declare this type of matching. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Hans Verkuil

[PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-03 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net

[PATCH/RFC v9 00/19] LED / flash API integration

2014-12-03 Thread Jacek Anaszewski
facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski Jacek Anaszewski (19): leds: Add LED Flash class extension to the LED subsystem Documentation: leds: Add description of LED

[PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-03 Thread Jacek Anaszewski
. The design assumes that V4L2 sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com

Re: [PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/03/2014 05:50 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the update. A few comments below. On Wed, Dec 03, 2014 at 05:06:36PM +0100, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. This patch provides support

Re: [PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/03/2014 06:08 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:37PM +0100, Jacek Anaszewski wrote: The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek

Re: [PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/04/2014 10:39 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:40PM +0100, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/04/2014 11:07 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:41PM +0100, Jacek Anaszewski wrote: This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-08 Thread Jacek Anaszewski
Hi Pavel, On 12/04/2014 05:12 PM, Pavel Machek wrote: Hi! +- maxim,boost-mode : + In boost mode the device can produce up to 1.2A of total current + on both outputs. The maximum current on each output is reduced + to 625mA then. If there are two child led nodes defined then

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-08 Thread Jacek Anaszewski
than for the devices which don't clear faults on readout. In case of devices which use writing to clear error code - I'd do that after reading flash_fault attribute, in the same callback. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH/RFC v8 01/14] leds: Add LED Flash class extension to the LED subsystem

2014-12-08 Thread Jacek Anaszewski
On 12/05/2014 08:27 PM, Bryan Wu wrote: On Fri, Nov 28, 2014 at 1:17 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Some LED devices support two operation modes - torch and flash. This patch provides support for flash LED devices in the LED subsystem by introducing new sysfs attributes

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-09 Thread Jacek Anaszewski
Hi Pavel, On 12/08/2014 09:18 PM, Pavel Machek wrote: On Mon 2014-12-08 17:55:20, Jacek Anaszewski wrote: On 12/06/2014 01:43 PM, Pavel Machek wrote: The format of a sysfs attribute should be concise. The error codes are generic and map directly to the V4L2 Flash error codes. Actually

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add label array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Added is also an array for caching pointers

Re: [PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 09:52 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 11:04 AM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add label array for Device Tree strings with the name of a LED device and make flash_timeout a two element array

Re: [PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-09 Thread Jacek Anaszewski
Hi Sakari, On 12/09/2014 01:36 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Dec 04, 2014 at 10:29:10AM +0100, Jacek Anaszewski wrote: ... +static struct attribute *led_flash_strobe_attrs[] = { + dev_attr_flash_strobe.attr, + NULL, +}; + +static struct attribute

Re: [PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-09 Thread Jacek Anaszewski
'? Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 02:50 PM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 11:04 AM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add label array for Device

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-09 Thread Jacek Anaszewski
Hi Sakari, On 12/09/2014 03:09 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Dec 04, 2014 at 12:40:48PM +0100, Jacek Anaszewski wrote: + the flash/torch. +- maxim,trigger : Array of flags indicating which trigger can activate given led + in order: fled1, fled2

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-10 Thread Jacek Anaszewski
Hi Sakari, On 12/04/2014 12:40 PM, Jacek Anaszewski wrote: On 12/04/2014 11:07 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:41PM +0100, Jacek Anaszewski wrote: This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-10 Thread Jacek Anaszewski
On 12/09/2014 03:41 PM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 02:50 PM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 11:04 AM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 09:50 AM, Lee

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-10 Thread Jacek Anaszewski
for the property, I guess we need to avoid maxim,current-sources due to ambiguity of the word current. For me this sounds reasonable. Moreover we will avoid the need for address-cells and size-cells properties in the parent node. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-10 Thread Jacek Anaszewski
On 12/09/2014 04:50 PM, Pavel Machek wrote: On Tue 2014-12-09 09:54:06, Jacek Anaszewski wrote: Hi Pavel, On 12/08/2014 09:18 PM, Pavel Machek wrote: On Mon 2014-12-08 17:55:20, Jacek Anaszewski wrote: On 12/06/2014 01:43 PM, Pavel Machek wrote: The format of a sysfs attribute should

Re: [PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-11 Thread Jacek Anaszewski
Hi Sakari, On 12/09/2014 02:11 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Dec 04, 2014 at 12:06:59PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. You're welcome! :-) On 12/04/2014 10:39 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:40PM +0100, Jacek

Re: [PATCH/RFC v9 08/19] leds: Add driver for AAT1290 current regulator

2014-12-11 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/11/2014 03:16 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:43PM +0100, Jacek Anaszewski wrote: This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2014-12-17 Thread Jacek Anaszewski
*/ #define EXYNOS4_HUFF_COUNT_MASK 0x -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-02-05 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 02/05/2015 04:34 PM, Sakari Ailus wrote: Hi Jacek, A few comments below. On Fri, Jan 09, 2015 at 04:22:58PM +0100, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED

Re: [PATCH/RFC v10 05/19] mfd: max77693: Modify flash cell name identifiers

2015-01-20 Thread Jacek Anaszewski
On 01/20/2015 12:13 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. This is okay by me, but aren't these ABI yet? No, the led driver using it hasn't been merged yet

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Jacek Anaszewski
On 01/20/2015 12:17 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver. Off-by-one ay? Wasn't the original code

Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros

2015-01-20 Thread Jacek Anaszewski
On 01/20/2015 12:12 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lee Jones lee.jo...@linaro.org Cc: Chanwoo

Re: [PATCH/RFC v10 09/19] DT: Add documentation for the mfd Maxim max77693

2015-01-20 Thread Jacek Anaszewski
On 01/20/2015 12:21 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha

Re: [PATCH/RFC v10 07/19] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-01-20 Thread Jacek Anaszewski
On 01/20/2015 02:01 PM, Jacek Anaszewski wrote: On 01/20/2015 12:17 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Modify FLASH_EN_SHIFT and TORCH_EN_SHIFT macros to work properly when passed enum max77693_fled values (0 for FLED1 and 1 for FLED2) from leds-max77693 driver

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-20 Thread Jacek Anaszewski
On 01/16/2015 04:52 PM, Jacek Anaszewski wrote: On 01/16/2015 02:48 PM, Rob Herring wrote: On Fri, Jan 16, 2015 at 3:07 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 01/15/2015 03:24 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski j.anaszew...@samsung.com

Re: [PATCH/RFC v10 17/19] DT: Add documentation for exynos4-is 'flashes' property

2015-01-22 Thread Jacek Anaszewski
Hi, On 01/21/2015 05:32 PM, Sylwester Nawrocki wrote: Hi, On 09/01/15 16:23, Jacek Anaszewski wrote: This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-16 Thread Jacek Anaszewski
On 01/15/2015 03:24 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 01/12/2015 05:55 PM, Rob Herring wrote: Adding Mark B and Liam... On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 01/12/2015

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-16 Thread Jacek Anaszewski
On 01/16/2015 02:48 PM, Rob Herring wrote: On Fri, Jan 16, 2015 at 3:07 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 01/15/2015 03:24 PM, Rob Herring wrote: On Tue, Jan 13, 2015 at 2:42 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 01/12/2015 05:55 PM, Rob Herring wrote

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-21 Thread Jacek Anaszewski
On 01/20/2015 06:40 PM, Pavel Machek wrote: On Tue 2015-01-20 11:29:16, Rob Herring wrote: On Tue, Jan 20, 2015 at 10:09 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 01/16/2015 04:52 PM, Jacek Anaszewski wrote: On 01/16/2015 02:48 PM, Rob Herring wrote: [...] You may want

Re: [PATCH] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-02-17 Thread Jacek Anaszewski
someone. Cc Jacek. Actually this will be not an issue for v4l2-flash sub-device anymore. In the next version of the patch set the v4l2-flash sub-device will be synchronizing the flash device registers with the state of the controls on open. -- Best Regards, Jacek Anaszewski -- To unsubscribe from

Re: [PATCH] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-02-17 Thread Jacek Anaszewski
On 02/17/2015 03:35 PM, Sakari Ailus wrote: Jacek Anaszewski wrote: On 02/17/2015 03:06 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: Hi Hans, Sakari, On 02/17/2015 12:32 PM, Sakari Ailus wrote: Hi Hans, Hans Verkuil wrote: ... Unfortunately, it only works one time, because

Re: [PATCH] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-02-17 Thread Jacek Anaszewski
On 02/17/2015 03:06 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: Hi Hans, Sakari, On 02/17/2015 12:32 PM, Sakari Ailus wrote: Hi Hans, Hans Verkuil wrote: ... Unfortunately, it only works one time, because the next time the user writes a zero to the control cluster_changed

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-19 Thread Jacek Anaszewski
On 02/18/2015 11:47 PM, Pavel Machek wrote: On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote: Add a documentation of LED Flash class specific sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-19 Thread Jacek Anaszewski
On 02/19/2015 10:40 PM, Greg KH wrote: On Thu, Feb 19, 2015 at 11:02:04AM +0200, Sakari Ailus wrote: On Wed, Feb 18, 2015 at 11:47:47PM +0100, Pavel Machek wrote: On Wed 2015-02-18 17:20:22, Jacek Anaszewski wrote: Add a documentation of LED Flash class specific sysfs attributes. Signed-off

Re: 0.led_name 2.other.led.name in /sysfs Re: [PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-20 Thread Jacek Anaszewski
Hi Pavel, On 02/20/2015 09:16 AM, Pavel Machek wrote: Hi! +What: /sys/class/leds/led/available_sync_leds +Date: February 2015 +KernelVersion: 3.20 +Contact: Jacek Anaszewski j.anaszew...@samsung.com +Description: read/write + Space separated list

[PATCH/RFC v11 01/20] leds: flash: document sysfs interface

2015-02-18 Thread Jacek Anaszewski
Add a documentation of LED Flash class specific sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- Documentation/ABI/testing/sysfs-class-led-flash

[PATCH/RFC v11 00/20] LED / flash API integration

2015-02-18 Thread Jacek Anaszewski
external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https://lkml.org/lkml/2014/7/11/914 Jacek Anaszewski (20): leds: flash: document sysfs interface leds: flash: Improve sync strobe related sysfs attributes Documentation: leds

[PATCH/RFC v11 03/20] Documentation: leds: Add description of LED Flash class extension

2015-02-18 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net

[PATCH/RFC v11 08/20] mfd: max77693: Adjust FLASH_EN_SHIFT and TORCH_EN_SHIFT macros

2015-02-18 Thread Jacek Anaszewski
-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com Cc: Lee Jones lee.jo...@linaro.org --- include/linux/mfd/max77693-private.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux

[PATCH/RFC v11 05/20] mfd: max77693: Modify flash cell name identifiers

2015-02-18 Thread Jacek Anaszewski
Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- drivers/mfd/max77693.c |4 ++-- 1

[PATCH/RFC v11 02/20] leds: flash: Improve sync strobe related sysfs attributes

2015-02-18 Thread Jacek Anaszewski
Current format of synchronized strobe related attributes introduces problems when it comes to parsing. Avoding the usage of square brackets and colons makes the parsing more convenient. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc

[PATCH/RFC v11 04/20] dt-binding: leds: Add common LED DT bindings macros

2015-02-18 Thread Jacek Anaszewski
Add macros for defining boost mode and trigger type properties of flash LED devices. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- include/dt-bindings/leds

[PATCH/RFC v11 07/20] mfd: max77693: add TORCH_IOUT_MASK macro

2015-02-18 Thread Jacek Anaszewski
Add a macro for obtaining the mask of ITORCH register bit fields related either to FLED1 or FLED2 current output. The expected arguments are TORCH_IOUT1_SHIFT or TORCH_IOUT2_SHIFT. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc

[PATCH/RFC v11 06/20] mfd: max77693: Remove struct max77693_led_platform_data

2015-02-18 Thread Jacek Anaszewski
The flash part of the max77693 device will depend only on OF, and thus will not use board files. Since there are no other users of the struct max77693_led_platform_data its existence is unjustified. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p

[PATCH/RFC v11 09/20] leds: Add support for max77693 mfd flash cell

2015-02-18 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v11 11/20] leds: Add driver for AAT1290 current regulator

2015-02-18 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo

[PATCH/RFC v11 10/20] DT: Add documentation for the mfd Maxim max77693

2015-02-18 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lee Jones lee.jo

[PATCH/RFC v11 17/20] Documentation: leds: Add description of v4l2-flash sub-device

2015-02-18 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com Cc: Bryan Wu coolo

[PATCH/RFC v11 14/20] exynos4-is: Add support for v4l2-flash subdevs

2015-02-18 Thread Jacek Anaszewski
This patch adds support for external v4l2-flash devices. The support includes parsing flashes DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro

[PATCH/RFC v11 12/20] of: Add Skyworks Solutions, Inc. vendor prefix

2015-02-18 Thread Jacek Anaszewski
Use skyworks as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell

[PATCH/RFC v11 18/20] DT: Add documentation for exynos4-is 'flashes' property

2015-02-18 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m

[PATCH/RFC v11 16/20] media: Add registration helpers for V4L2 flash sub-devices

2015-02-18 Thread Jacek Anaszewski
will be used. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media

[PATCH/RFC v11 15/20] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2015-02-18 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sakari Ailus

[PATCH/RFC v11 13/20] DT: Add documentation for the Skyworks AAT1290

2015-02-18 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- .../devicetree

[PATCH/RFC v11 20/20] leds: aat1290: add support for V4L2 Flash sub-device

2015-02-18 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu

[PATCH/RFC v11 19/20] leds: max77693: add support for V4L2 Flash sub-device

2015-02-18 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu

Re: setting volatile v4l2-control

2015-01-27 Thread Jacek Anaszewski
On 01/27/2015 03:14 PM, Hans Verkuil wrote: On 01/27/15 14:32, Jacek Anaszewski wrote: While testing the LED / flash API integration patches I noticed that the v4l2-controls marked as volatile with V4L2_CTRL_FLAG_VOLATILE flag behave differently than I would expect. Let's consider following

setting volatile v4l2-control

2015-01-27 Thread Jacek Anaszewski
reason for not doing this? -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v10 02/19] Documentation: leds: Add description of LED Flash class extension

2015-01-12 Thread Jacek Anaszewski
Hi Pavel, Thanks for the review. On 01/09/2015 06:40 PM, Pavel Machek wrote: Hi! The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-12 Thread Jacek Anaszewski
Hi Pavel, Thanks for the review. On 01/09/2015 07:46 PM, Pavel Machek wrote: On Fri 2015-01-09 16:22:58, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two

Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property

2015-01-12 Thread Jacek Anaszewski
On 01/09/2015 07:33 PM, Rob Herring wrote: On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Add a property for defining the device outputs the LED represented by the DT child node is connected to. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked

Re: [PATCH/RFC v10 15/19] media: Add registration helpers for V4L2 flash sub-devices

2015-01-12 Thread Jacek Anaszewski
Hi Pavel, Thanks for the review. On 01/09/2015 09:54 PM, Pavel Machek wrote: On Fri 2015-01-09 16:23:05, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem

Re: [PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-12 Thread Jacek Anaszewski
- iout[1]; } Does it lack precision? Thanks, Pavel -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH/RFC v10 19/19] leds: aat1290: add support for V4L2 Flash sub-device

2015-01-09 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu

[PATCH/RFC v10 18/19] leds: max77693: add support for V4L2 Flash sub-device

2015-01-09 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu

[PATCH/RFC v10 16/19] Documentation: leds: Add description of v4l2-flash sub-device

2015-01-09 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com Cc: Bryan Wu coolo

[PATCH/RFC v10 12/19] DT: Add documentation for the Skyworks AAT1290

2015-01-09 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: Rob Herring robh

[PATCH/RFC v10 14/19] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2015-01-09 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai

[PATCH/RFC v10 15/19] media: Add registration helpers for V4L2 flash sub-devices

2015-01-09 Thread Jacek Anaszewski
will be used. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media

[PATCH/RFC v10 13/19] exynos4-is: Add support for v4l2-flash subdevs

2015-01-09 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro

[PATCH/RFC v10 17/19] DT: Add documentation for exynos4-is 'flashes' property

2015-01-09 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m

[PATCH/RFC v10 11/19] of: Add Skyworks Solutions, Inc. vendor prefix

2015-01-09 Thread Jacek Anaszewski
Use skyworks as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell

[PATCH/RFC v10 01/19] leds: Add LED Flash class extension to the LED subsystem

2015-01-09 Thread Jacek Anaszewski
-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p

[PATCH/RFC v10 00/19] LED / flash API integration

2015-01-09 Thread Jacek Anaszewski
: - removed flash manager framework - its implementation needs further thorough discussion. - removed external strobe facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https

[PATCH/RFC v10 08/19] leds: Add support for max77693 mfd flash cell

2015-01-09 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

<    1   2   3   4   5   6   7   8   >