[PATCH] media: i2c: ov772x: Force use of SCCB protocol

lied: soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 ov772x 0-0021: ov7725 Product ID 77:21 Manufacturer ID 7f:a2 Signed-off-by: Jacopo Mondi <jac...@jmondi.org> --- drivers/media/i2c/soc_camera/ov772x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/soc_ca

[PATCH v3] media: i2c: ov772x: Force use of SCCB protocol

25 Product ID 77:21 Manufacturer ID 7f:a2 Signed-off-by: Jacopo Mondi <jac...@jmondi.org> Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Acked-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com&

[PATCH v2] media: i2c: ov772x: Force use of SCCB protocol

l messages. Tested on SH4 Migo-R board, with OV772x now successfully probing soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 ov772x 0-0021: ov7725 Product ID 77:21 Manufacturer ID 7f:a2 Signed-off-by: Jacopo Mondi <jac...@jmondi.org> Suggested-by: Laurent Pinchar

[PATCH] v4l: sh_mobile_ceu: Return buffers on streamoff()

videobuf2 core reports an error when not all buffers have been returned to the framework: drivers/media/v4l2-core/videobuf2-core.c:1651 WARN_ON(atomic_read(>owned_by_drv_count)) Fix this returning all buffers currently in capture queue. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmon

Re: [PATCH v1 01/10] dt-bindings: media: Add Renesas CEU bindings

Hi Geert, On Wed, Nov 15, 2017 at 02:07:31PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > CC devicetree folks Yeah, sorry I forgot them. Sorry about this and thanks for adding the address back! > > On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi > <jacopo+rene...@jmond

Re: [PATCH 3/4] staging: improves comparisons readability in atomisp-ov5693

Hi Riccardo, thanks for the patch On Mon, Nov 27, 2017 at 10:44:12PM +0100, Riccardo Schirone wrote: > Fix "Comparisons should place the constant on the right side of the > test" issue. > > Signed-off-by: Riccardo Schirone > --- >

Re: [PATCH 1/4] staging: add missing blank line after declarations in atomisp-ov5693

Hi Riccardo, On Mon, Nov 27, 2017 at 10:44:10PM +0100, Riccardo Schirone wrote: > Signed-off-by: Riccardo Schirone No patch can be accepted without a commit message. I know subject is self-explanatory here, but please add some lines eg. reporting checkpatch warnings. Thanks

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Sakari! On Sat, Nov 25, 2017 at 05:56:14PM +0200, Sakari Ailus wrote: > On Fri, Nov 17, 2017 at 10:33:55AM +0100, jacopo mondi wrote: > > Hi Sakari! > > [snip] > > I would like to make sure we're all on the same page with this. My > > preference would be: > >

Re: [PATCH 0/4] fix some checkpatch style issues in atomisp driver

Hello Riccardo, On Wed, Nov 29, 2017 at 10:31:17AM +0100, Riccardo S. wrote: > Hi Jacopo, > > for some reason your comment about "[PATCH 3/4] staging: improves > comparisons readability in atomisp-ov5693" did not reach my inbox. > > Unfortunately I already sent PATCHv2 and it has been accepted. >

Re: [RFC] v4l: i2c: ov7670: Implement mbus configuration

Hi Sakari, thanks for the reply On Wed, Nov 29, 2017 at 01:06:49PM +0200, Sakari Ailus wrote: > On Wed, Nov 29, 2017 at 01:04:30PM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Mon, Nov 27, 2017 at 11:26:53AM +0100, Jacopo Mondi wrote: > > > ov7670 cu

[RFC] v4l: i2c: ov7670: Implement mbus configuration

ov7670 currently supports configuration of a few parameters only through platform data. Implement media bus configuration by parsing DT properties at probe() time and opportunely configure REG_COM10 during s_format(). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Hi linux

Re: [PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

Hi Sakari, On Fri, Dec 15, 2017 at 05:20:40PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Dec 13, 2017 at 07:26:19PM +0100, Jacopo Mondi wrote: > > Currently, subdevice notifiers are tested against all available > > subdevices as soon as they get registered. It

Re: [PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

Hi Sakari, On Fri, Dec 15, 2017 at 06:17:04PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Dec 13, 2017 at 07:26:20PM +0100, Jacopo Mondi wrote: > > The v4l2-async module operations are quite complex to follow, due to the > > asynchronous nature of subdevices and n

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Hans, thanks for review comments On Wed, Dec 13, 2017 at 01:03:03PM +0100, Hans Verkuil wrote: > On 15/11/17 11:55, Jacopo Mondi wrote: > > Add driver for Renesas Capture Engine Unit (CEU). > > + > > + /* Register the video device */ > > + strncpy(vdev

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Laurent, thanks for review comments... On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > [snip] > > + > > +/** > > + * ceu_buffer - Link vb2 buffer to the list of available buffers > > If you use kerneldoc comments please make

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Laurent, a few more details on subdevice management On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > [snip] > > > +static int ceu_sensor_bound(struct v4l2_async_notifier *notifier, > > + struct v4l2_subdev

Re: [PATCH/RFC v2 10/15] adv748x: csi2: add translation from pixelcode to CSI-2 datatype

Hi Kieran, On Thu, Dec 14, 2017 at 10:25:36PM +, Kieran Bingham wrote: > Hi Niklas, > > On 14/12/17 19:08, Niklas Söderlund wrote: > > This will be needed to fill out the frame descriptor information > > correctly. > > > > Signed-off-by: Niklas Söderlund

Re: [PATCH/RFC v2 07/15] rcar-csi2: use frame description information to configure CSI-2 bus

Hi Niklas, thanks for the patch! On Thu, Dec 14, 2017 at 08:08:27PM +0100, Niklas Söderlund wrote: > The driver now have access to frame descriptor information, use it. Only > enable the virtual channels which are described in the frame descriptor > and calculate the link based on all enabled

[PATCH 4/5] v4l2: async: Postpone subdev_notifier registration

cannot be upscaled as long as the subdevice the notifiers belongs to is not registered. Also, it is now safe to access a notifier 'struct device *' as we're now sure it is properly initialized when the notifier is actually registered. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- d

[PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

not that useful). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- For fwnodes backed by OF, I may have used the "%pOF" format modifier to get the full node name instead of parsing the fwnode graph by myself with "v4l2_async_fwnode_full_name()". Unfortunate

[PATCH 3/5] include: v4l2_async: Add 'owner' field to notifier

purposes. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/v4l2-core/v4l2-async.c | 2 ++ include/media/v4l2-async.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index a

[PATCH 2/5] device property: Add fwnode_get_name() operation

Add operation to retrieve the device name from a fwnode handle. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/acpi/property.c | 6 ++ drivers/base/property.c | 12 drivers/of/property.c| 6 ++ include/linux/fwnode.h | 2 ++ include

[PATCH 1/5] v4l: async: Use endpoint node, not device node, for fwnode match

From: Sakari Ailus V4L2 async framework can use both device's fwnode and endpoints's fwnode for matching the async sub-device with the sub-device. In order to proceed moving towards endpoint matching assign the endpoint to the async sub-device. As most async

[PATCH 0/5] Add debug output to v4l2-async

linux-media anyhow for feedbacks. Thanks j Jacopo Mondi (4): device property: Add fwnode_get_name() operation include: v4l2_async: Add 'owner' field to notifier v4l2: async: Postpone subdev_notifier registration v4l2: async: Add debug output to v4l2-async module Sakari Ailus (1

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

Hi Sakari, On Thu, Dec 14, 2017 at 12:53:42PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Thu, Dec 07, 2017 at 03:29:40PM +0100, jacopo mondi wrote: > > Hi Sakari! > > thanks for proposing this > > > > While we all agree that full endpoint matching is th

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

Hi Sakari! On Fri, Nov 17, 2017 at 02:36:51AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 03:25:11PM +0100, jacopo mondi wrote: > > Hi Sakari, > >thanks for review! > > You're welcome! > > > On Wed, Nov 15, 2017 at 02:45:51PM +0200,

Re: [PATCH v1 06/10] sh: sh7722: Rename CEU clock

Hi Geert, On Wed, Nov 15, 2017 at 02:13:43PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi > <jacopo+rene...@jmondi.org> wrote: > > Rename CEU clock to match the new platform driver name used in Migo-R. > > >

Re: [PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

Hi Sakari! On Fri, Nov 17, 2017 at 02:43:15AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Nov 15, 2017 at 11:56:01AM +0100, Jacopo Mondi wrote: > > [snip] > > +#include > > #include > > #include > > #include > > @@ -25,8 +26,8 @@ &g

Re: [PATCH] media: cx231xx: add support for TheImagingSource DFG/USB2pro

Hi Romain, On Fri, Nov 17, 2017 at 04:38:55PM +0100, Romain Reignier wrote: > Hello, > > This is my first patch to the kernel so please be indulgent if I have done > anything wrong and help me produce a better submission. With this formatting (email text + patch below) applying with 'git am'

[PATCH v1 07/10] v4l: i2c: Copy ov772x soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/ov772x.c | 1124 1 file changed

[PATCH v1 00/10] Renesas Capture Engine Unit (CEU) V4L2 driver

. Thanks j Jacopo Mondi (10): dt-bindings: media: Add Renesas CEU bindings include: media: Add Renesas CEU driver interface v4l: platform: Add Renesas CEU driver ARM: dts: r7s72100: Add Capture Engine Unit (CEU) arch: sh: migor: Use new renesas-ceu camera driver sh: sh7722: Rename CEU

[PATCH v1 06/10] sh: sh7722: Rename CEU clock

Rename CEU clock to match the new platform driver name used in Migo-R. There are no other sh7722 based devices Migo-R apart, so we can safely rename this. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/kernel/cpu/sh4a/clock-sh7722.c | 2 +- 1 file changed, 1 insertion

[PATCH v1 09/10] v4l: i2c: Copy tw9910 soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/i2c/tw9910.c | 999 + 1 file change

[PATCH v1 08/10] media: i2c: ov772x: Remove soc_camera dependencies

Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock directly - Register async subdevice - Add platform specific enable/disable functions - Adjust build system This commit does not remove the original soc_camera based driver. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v1 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r7s72100.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi

[PATCH v1 05/10] arch: sh: migor: Use new renesas-ceu camera driver

for CEU video buffers is now reserved with membocks APIs, and need to be declared as dma_coherent during machine initialization to remove that architecture specific part from CEU driver. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/boards/mach-migor/setup.c

[PATCH v1 02/10] include: media: Add Renesas CEU driver interface

Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- include/media/drv-intf/renesas-ceu.h | 23 +++ 1 file changed, 23 insertions(+)

[PATCH v1 10/10] media: i2c: tw9910: Remove soc_camera dependencies

Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock directly - Register async subdevice - Add platform specific enable/disable functions - Adjust build system This commit does not remove the original soc_camera based driver. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

. Tested with ov7725 camera sensor on SH4 platform Migo-R. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/Kconfig |9 + drivers/media/platform/Makefile |2 + drivers/media/platform/renesas-ceu.c | 1768 ++ 3

[PATCH v1 01/10] dt-bindings: media: Add Renesas CEU bindings

Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- .../devicetree/bindings/media/renesas,ceu.txt | 87 ++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bi

Re: [PATCH v1 03/10] v4l: platform: Add Renesas CEU driver

utines apart, there's not that much code shared between the two... > > The same goes for the two V4L2 SoC camera sensor / video decoder drivers at > the end of the set. > Also in this case I prefer not to remove existing code, as long as there are platforms using it.. > On Wed, Nov 15, 2017 at

[PATCH] v4l: rcar-csi2: Don't bail out from probe on no ep

When rcar-csi interface is not connected to any endpoint, it fails and bails out from probe before registering its own video subdevice. This prevents rcar-vin registered notifier from completing and no subdevice is ever registered, also for other properly connected csi interfaces. Fix this not

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

Hi Sakari! thanks for proposing this While we all agree that full endpoint matching is the right thing to do (see also Kieran's last reply to his "v4l2-async: Match parent devices" patch) I have some perplexity on this proposal, please see below On Mon, Dec 04, 2017 at 11:03:02PM +0200,

Re: [PATCH v5] v4l2-async: Match parent devices

evices which store their default parent device > node. > > Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> please append: Reported-by: Jacopo Mondi <jacopo.mondi+rene...@jmondi.

Re: [PATCH v4 12/14] media: ov772x: avoid accessing registers under power saving mode

Hi Akinobu, On Fri, May 04, 2018 at 11:50:39PM +0900, Akinobu Mita wrote: > 2018-05-04 6:03 GMT+09:00 jacopo mondi <jac...@jmondi.org>: > > Hi Akinobu, > > let me see if I got this right... > > > > On Mon, Apr 30, 2018 at 02:13:11AM +0900, Akinobu Mita wrote:

[PATCH] media: renesas-ceu: Set mbus_fmt on subdev operations

] ov7670_try_fmt_internal -- Try mbus_code 0x3001 [0.891584] ov7670_try_fmt_internal -- mbus_code defaulted to 0x2008 With this patch applied: [0.867015] ov7670_try_fmt_internal -- Looking for mbus_code 0x2008 [0.873205] ov7670_try_fmt_internal -- Try mbus_code 0x2008: match Signed-off-by: Jacopo

Re: [PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

Hi Sakari, thanks for the clarification, please ignore my comment then. Thanks j On Mon, May 14, 2018 at 12:49:19PM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, May 14, 2018 at 11:06:46AM +0200, jacopo mondi wrote: > > Hi Akinobu, > > > >a small nit b

Re: [PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

Hi Niklas, On Fri, May 11, 2018 at 01:01:24PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work! > > The comments here apply to both 2/5 and 3/5. > > On 2018-05-11 11:59:38 +0200, Jacopo Mondi wrote: > > Add support for digital input subdevices to Ge

Re: [PATCH v5 10/14] media: ov772x: reconstruct s_frame_interval()

under power > saving mode. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Mauro Carvalho Chehab

Re: [PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

ving mode. These callbacks for ov772x driver > cause updating H/W registers that will fail under power saving mode. > > This avoids it by not apply any changes to H/W if the device is not powered > up. Instead the changes will be restored right after power-up. > > Cc: Jacopo Mondi <jacopo+ren

Re: [PATCH v5 13/14] media: ov772x: make set_fmt() and s_frame_interval() return -EBUSY while streaming

requests are preferred to fail while > the video stream on the device is active. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai

Re: [PATCH v5 14/14] media: ov772x: create subdevice device node

Hi Akinobu, thanks for the patch. On Sun, May 06, 2018 at 11:19:29PM +0900, Akinobu Mita wrote: > Set the V4L2_SUBDEV_FL_HAS_DEVNODE flag for the subdevice so that the > subdevice device node is created. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pi

Re: [PATCH v5 08/14] media: ov772x: support device tree probing

probing. > > > > Note that the platform data probe can select auto or manual edge control > > mode, but the device tree probling can only select auto edge control mode > > for now. > > > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > > Cc: Laurent Pinchar

Re: [PATCH v15 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, thanks for the patch On Sun, May 13, 2018 at 09:19:17PM +0200, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are > connected between the video sources and the video

Re: [PATCH v15 1/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

ndpoint properties in the hardware module, and those should be described here. Eg. the clock lane shall be fixed in position 0 (that's more an HW design choice, I agree), and the number of supported data lanes is either 1, 2 or 4 and 3 is not supported. Apart from that, w

Re: [PATCH 2/2] media: i2c: mt9t112: Add device tree support

Hi Sakari, On Mon, May 07, 2018 at 12:32:19PM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Apr 25, 2018 at 01:00:14PM +0200, Jacopo Mondi wrote: [snip] > > static int mt9t112_probe(struct i2c_client *client, > > const struct i2c_device_id *did)

Re: [PATCH 2/2] media: i2c: mt9t112: Add device tree support

Hi Sakari, On Tue, May 15, 2018 at 12:50:04AM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, May 14, 2018 at 04:30:44PM +0200, jacopo mondi wrote: > > Hi Sakari, > > > > On Mon, May 07, 2018 at 12:32:19PM +0300, Sakari Ailus wrote: > > > Hi Jacopo, >

Re: [PATCH v16 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

axime.rip...@bootlin.com> I forgot to add it to v15, as my comments there pointed to non blocking issues. Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Thanks j > > --- > > * Changes since v15 > - Merge struct phtw_mbps and struct phypll_hsfreqrange into a

Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

Hi Laurent, just one minor comment below On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote: > Add a parameter (in the form of a structure to ease future API > extensions) to the VSP atomic flush handler to pass CRC source > configuration, and pass the CRC value to the completion

Re: [PATCH v2 3/8] v4l: vsp1: Reset the crop and compose rectangles in the set_fmt helper

; Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jacopo Mondi <jac...@jmondi.org> > --- > drivers/media/platform/vsp1/vsp1_entity.c | 16 + > drivers/media/platform/vsp1/vsp1_histo.c | 59 > +++ > 2 fil

Re: [PATCH v2 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

HI Laurent, On Mon, Apr 23, 2018 at 01:34:29AM +0300, Laurent Pinchart wrote: > The DISCOM is used to compute CRCs on display frames. Integrate it in > the display pipeline at the output of the blending unit to process > output frames. > > Computing CRCs on input frames is possible by positioning

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

Hi Laurent, very minor comments below On Mon, Apr 23, 2018 at 01:34:24AM +0300, Laurent Pinchart wrote: > The implementation of the set_fmt pad operation is identical in the > three modules. Move it to a generic helper function. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

DOCMPMR_SEL(9)); > + > + crop = vsp1_entity_get_pad_selection(entity, entity->config, > + UIF_PAD_SINK, V4L2_SEL_TGT_CROP); > + > + /* On M3-W the horizontal coordinates are twice the register value. */ > + if (uif->m3w_quirk

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, apart from a small comment, as my comments on v13 have been clarified Reviewed-by: Jacopo Mondi <jac...@jmondi.org> On Thu, Apr 26, 2018 at 10:21:21PM +0200, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-C

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Sat, Apr 28, 2018 at 03:31:14PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your feedback. > > On 2018-04-28 13:28:27 +0200, Jacopo Mondi wrote: > > Hi Niklas, > >apart from a small comment, as my comments on v13 have been > &

[PATCH 4/5] media: rcar-vin: Do not use crop if not configured

. Fix this by using the actual format width and height when no crop rectangle has been programmed. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 1/5] media: rcar-vin: Add support for R-Car R8A77995 SoC

Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers

[PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 166 +++- drivers/media/platform/rcar-vin/rcar-vin.h | 13 +++ 2 files changed, 153 insertions(+), 26 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-cor

[PATCH 5/5] media: rcar-vin: Use FTEV for digital input

uture. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index ea7a1

[PATCH 3/5] media: rcar-vin: [un]bind and link digital subdevice

Add support for binding and unbinding digital subdevices to rcar-vin. On 'complete' also create direct links between the VIN instance and the digital subdevice. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c

[PATCH 0/5] rcar-vin: Add support for digital input on Gen3

Thanks j Jacopo Mondi (5): media: rcar-vin: Add support for R-Car R8A77995 SoC media: rcar-vin: Add digital input subdevice parsing media: rcar-vin: [un]bind and link digital subdevice media: rcar-vin: Do not use crop if not configured media: rcar-vin: Use FTEV for digital input

Re: [PATCH 5/5] media: rcar-vin: Use FTEV for digital input

Hi Hans, On Fri, May 11, 2018 at 12:28:55PM +0200, Hans Verkuil wrote: > On 05/11/18 11:59, Jacopo Mondi wrote: > > Since commit (015060cb "media: rcar-vin: enable field toggle after a set > > number of lines for Gen3) the VIN generates an internal field signal > > t

Re: [PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

Hi Niklas, On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN > > driver and only

Re: [PATCH v2 1/4] media: rcar-vin: Parse digital input in mc-path

fine with > that too. I would go with a major s/digital/parallel/ after this has been merged, if that' fine with you. > > On 2018-05-16 14:16:53 +0200, Jacopo Mondi wrote: > > Add support for digital input subdevices to Gen-3 rcar-vin. > > The Gen-3, media-controller compl

Re: [PATCH 4/6] media: rcar-vin: Handle CLOCKENB pin polarity

Hi Niklas, On Thu, May 17, 2018 at 12:11:03AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > I'm happy that you dig into this as it clearly needs doing! > > On 2018-05-16 18:32:30 +0200, Jacopo Mondi wrote: > > Handle CLOCKENB pin polarity

Re: [PATCH 3/6] media: rcar-vin: Handle data-active property

Hi Niklas, On Wed, May 16, 2018 at 11:58:47PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:29 +0200, Jacopo Mondi wrote: > > The data-active property has to be specified when running with embedded > > synchronization.

Re: [PATCH 2/6] dt-bindings: media: rcar-vin: Document data-active

Hi Niklas, On Wed, May 16, 2018 at 11:55:38PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:28 +0200, Jacopo Mondi wrote: > > Document 'data-active' property in R-Car VIN device tree bindings. > > The property is optional

[PATCH v2 3/4] media: rcar-vin: Handle digital subdev in link_notify

Handle digital subdevices in link_notify callback. If the notified link involves a digital subdevice, do not change routing of the VIN-CSI-2 devices. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 30 +++--

[PATCH v2 1/4] media: rcar-vin: Parse digital input in mc-path

-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 99 +++-- drivers/media/platform/rcar-vin/rcar-vin.h | 15 + 2 files changed, 93 insertions(+), 21 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-cor

[PATCH v2 4/4] media: rcar-vin: Add support for R-Car R8A77995 SoC

Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rc

[PATCH v2 0/4] rcar-vin: Add support for digital input on Gen3

://jmondi.org/linux d3/renesas-drivers/test Thanks j Jacopo Mondi (4): media: rcar-vin: Parse digital input in mc-path media: rcar-vin: Handle mc in digital notifier ops media: rcar-vin: Handle digital subdev in link_notify media: rcar-vin: Add support for R-Car R8A77995 SoC drivers/media

[PATCH v2 2/4] media: rcar-vin: Handle mc in digital notifier ops

Handle media-controller in the digital notifier operations (bound, unbind and complete) registered for VIN instances handling a digital input subdevice. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 94 --

[PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

Describe the optional endpoint properties for endpoint nodes of port@0 and port@1 of the R-Car VIN driver device tree bindings documentation. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Documentation/devicetree/bindings/media/rcar_vin.txt | 13 - 1 file chang

[PATCH 0/6] media: rcar-vin: Brush endpoint properties

bindings, as they are not parsed by the VIN driver and only confuse users. Niklas, as you already know I don't have any Gen2 board. Could you give this a spin on Koelsch if you like the series? Thanks j Jacopo Mondi (6): dt-bindings: media: rcar-vin: Describe optional ep properties dt-bindings

[PATCH 6/6] ARM: dts: rcar-gen2: Add 'data-active' property

The 'data-active' property needs to be specified when using embedded synchronization. Add it to the Gen-2 boards using composite video input. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7790-lager.dts | 1 + arch/arm/boot/dts/r8a7791-koelsch.dts | 1 +

[PATCH 3/6] media: rcar-vin: Handle data-active property

not sense to zero the mbus configuration flags when running with implicit synch (V4L2_MBUS_BT656). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN driver and only confuse users. Remove them in all Gen2 SoC that used them. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7790-lager.dts | 3 --- arch/arm/boot/dts/r8a7791-koelsch.d

[PATCH 4/6] media: rcar-vin: Handle CLOCKENB pin polarity

Handle CLOCKENB pin polarity, or use HSYNC in its place if polarity is not specified. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar

[PATCH 2/6] dt-bindings: media: rcar-vin: Document data-active

Document 'data-active' property in R-Car VIN device tree bindings. The property is optional when running with explicit synchronization (eg. BT.601) but mandatory when embedded synchronization is in use (eg. BT.656) as specified by the hardware manual. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v2 1/4] dt-bindings: media: rcar-vin: Describe optional ep properties

Describe the optional properties for endpoint nodes of port@0 and port@1 of the R-Car VIN driver device tree bindings documentation. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- Documentation/devicet

[PATCH v2 2/4] dt-bindings: media: rcar-vin: Document data-active

Document 'data-active' property in R-Car VIN device tree bindings. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> v1 -> v2: - HSYNC is used in place of data enable signal only when running with explicit synchronizations. - The property is no more mandatory when running with

[PATCH v2 4/4] ARM: dts: rcar-gen2: Remove unused VIN properties

The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN driver and only confuse users. Remove them in all Gen2 SoC that use them. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7790-lager.dts | 3 --- arch/arm/boot/dts/r8a7791-koelsch.d

[PATCH v2 3/4] media: rcar-vin: Handle CLOCKENB pin polarity

and ignore flags when on CSI-2. Also change comments style to remove un-necessary camel case and add a full stop at the end of sentences. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 34 ++ 1 file chang

[PATCH v2 0/4] media: rcar-vin: Brush endpoint properties

/salvator-x-dts_csi2/d3-vin-driver-v3 Thanks j v1 -> v2: - Change data-active properties handling: the property is only considered when running with explicit synchronization signals. - Drop patch 3/6 and 6/6 from v1 as they're not needed anymore as data-active handling logic changed. Jacopo Mo

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hello Bingbu, thanks for the patch On Tue, May 22, 2018 at 12:33:01PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a V4L2 sub-device driver for the Sony IMX319 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for

Re: [PATCH v4 5/9] media: rcar-vin: Parse parallel input on Gen3

Hi Niklas, I might have another question before sending v5. On Fri, May 25, 2018 at 12:29:44AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > I really like what you did with this patch in v4. > > On 2018-05-25 00:02:15 +0200, Jacopo Mondi wr

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Tomasz, On Fri, May 25, 2018 at 04:31:07PM +0900, Tomasz Figa wrote: > On Fri, May 25, 2018 at 4:12 PM jacopo mondi <jac...@jmondi.org> wrote: > > > Hi Tomasz, > [snip] > > > the controls set before powering on will actually be programmed into the > > &

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Sakari, On Wed, May 23, 2018 at 10:38:33AM +0300, Sakari Ailus wrote: > Hi Jacopo and Bingbu, > > On Tue, May 22, 2018 at 10:08:48PM +0200, jacopo mondi wrote: > ... > > > +/* Get bayer order based on flip setting. */ > > > +static __u32 imx319_get_for

Re: [PATCH v3 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

Hi Niklas, On Thu, May 24, 2018 at 12:42:25AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2018-05-18 16:40:37 +0200, Jacopo Mondi wrote: > > As the term 'digital' is used all over the rcar-vin code in place of > > 'parallel',

[PATCH v4 3/9] media: rcar-vin: Create a group notifier

-compliant code path, each VIN may register its own notifier if any parallel subdevice is connected there. To avoid registering a notifier twice (once for parallel subdev and one for the CSI-2 subdevs) create a group notifier, shared by all the VIN instances. Signed-off-by: Jacopo Mondi <jacopo+r

  1   2   3   4   5   6   >