Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

2018-05-14 Thread James Hogan
gpr.c > > @@ -29,7 +29,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > #include > > #include > > #include Acked-by: James Hogan Cheers James signature.asc Description: PGP signature

Re: Build regressions/improvements in v4.5-rc7

2016-03-08 Thread James Hogan
Hi, On Mon, Mar 07, 2016 at 10:01:09AM +0100, Geert Uytterhoeven wrote: > On Mon, Mar 7, 2016 at 9:55 AM, Geert Uytterhoeven > wrote: > > JFYI, when comparing v4.5-rc7[1] to v4.5-rc6[3], the summaries are: > > - build errors: +8/-7 > + error: debugfs.c: undefined reference to `clk_round_rate

[PATCH 12/13] media: img-ir: Drop METAG dependency

2018-02-21 Thread James Hogan
Now that arch/metag/ has been removed, remove the METAG dependency from the IMG IR device driver. The hardware is also present on MIPS SoCs so the driver still has value. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: linux-me

[PATCH 00/13] Remove metag architecture

2018-02-21 Thread James Hogan
Carvalho Chehab Cc: Wolfram Sang Cc: linux-me...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux...@kvack.org Cc: linux-g...@vger.kernel.org Cc: linux-watch...@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-...@vger.kernel.org James Hogan (13): metag: Remove arch/metag/ doc

Re: [PATCH 00/13] Remove metag architecture

2018-02-22 Thread James Hogan
On Thu, Feb 22, 2018 at 10:26:54AM +0100, Peter Zijlstra wrote: > On Wed, Feb 21, 2018 at 11:38:12PM +0000, James Hogan wrote: > > So lets call it a day and drop the Meta architecture port from the > > kernel. RIP Meta. > > So long, and thanks for all the fish! > >

Re: [PATCH 00/13] Remove metag architecture

2018-02-23 Thread James Hogan
On Fri, Feb 23, 2018 at 11:26:58AM +0100, Arnd Bergmann wrote: > On Thu, Feb 22, 2018 at 12:38 AM, James Hogan wrote: > > So lets call it a day and drop the Meta architecture port from the > > kernel. RIP Meta. > > Since I brought up the architecture removal independently, I

[GIT PULL] Remove metag architecture

2018-02-27 Thread James Hogan
Hi Arnd, On Fri, Feb 23, 2018 at 01:26:09PM +0100, Arnd Bergmann wrote: > On Fri, Feb 23, 2018 at 12:02 PM, James Hogan wrote: > > I'm happy to put v2 in linux-next now (only patch 4 has changed, I just > > sent an updated version), and send you a pull request early next week

Re: [PATCH 04/12] media: img-ir-hw: fix one kernel-doc comment

2017-11-29 Thread James Hogan
c:351: warning: Excess function > parameter 'timings' description in 'img_ir_decoder_convert' > > Signed-off-by: Mauro Carvalho Chehab Very true. Acked-by: James Hogan Thanks James > --- > drivers/media/rc/img-ir/img-ir-hw.c | 2 +- > 1 file changed, 1 insertion

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-04-09 Thread James Hogan
Hi, On Thursday 25 March 2010 14:42:33 Mauro Carvalho Chehab wrote: > Comments? I haven't seen this mentioned yet, but are there any plans for a sysfs interface to set up waking from suspend/standby on a particular IR scancode (for hardware decoders that support masking of comparing of the IR d

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-04-09 Thread James Hogan
On Fri, Apr 09, 2010 at 06:50:26AM -0400, Andy Walls wrote: > If you're waiting for me to get that working, I'll advise you to plan on > getting off the couch and pushing the power switch for some time to > come. ;) :-) On Friday 09 April 2010 14:01:46 Mauro Carvalho Chehab wrote: > The additions

Re: [PATCH 1/6] Input: add support for large scancodes

2010-10-29 Thread James Hogan
> diff --git a/include/linux/input.h b/include/linux/input.h > index 7892651..0057698 100644 > --- a/include/linux/input.h > +++ b/include/linux/input.h > +/** > + * struct input_keymap_entry - used by EVIOCGKEYCODE/EVIOCSKEYCODE ioctls > + * @scancode: scancode represented in machine-endian form.

Re: [PATCH 1/6] Input: add support for large scancodes

2010-10-29 Thread James Hogan
On Friday 29 October 2010 22:36:06 James Hogan wrote: > I thought I better point out that this breaks make htmldocs (see below) > because of the '<' characters "in" a kernel doc'd struct. This is with > 12ba8d1e9262ce81a695795410bd9ee5c9407ba1 from Linus'

[PATCH] ir-nec-decoder: fix extended NEC scancodes

2010-11-26 Thread James Hogan
rojects.com/knowledge/ir/nec.htm Signed-off-by: James Hogan --- drivers/media/IR/ir-nec-decoder.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/IR/ir-nec-decoder.c b/drivers/media/IR/ir-nec-decoder.c index 70993f7..11d3e78 100644 --- a/drivers/media/IR

Re: [PATCH] ir-nec-decoder: fix extended NEC scancodes

2010-11-26 Thread James Hogan
s all a matter of convention, but I think they should at least be consistent, so I'll go by the NEC datasheet and submit a patch to winbond-cir instead. Cheers James > James Hogan wrote: > > >Could somebody check this as I'm unable to test it. > > > >I'

[PATCH] media: rc: only turn on LED if keypress generated

2014-01-16 Thread James Hogan
er_event() call inside the keycode check. Signed-off-by: James Hogan Cc: Sean Young Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- Was that the original intent? If not it could be tweaked to set dev->keypressed in either case instead, so that they LED trigger works for unma

[PATCH v2 03/15] media: rc: add raw decoder for Sharp protocol

2014-01-17 Thread James Hogan
echo message which is an inverted version of the main message except for the address bits. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - new patch (suggested by Mauro). --- drivers/media/rc/Kconfig| 9 ++ drivers/media/rc/Makefile

[PATCH v2 05/15] media: rc: change 32bit NEC scancode format

2014-01-17 Thread James Hogan
TiVo keymap is updated accordingly. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: Jarod Wilson Cc: linux-media@vger.kernel.org --- v2: - New patch. --- drivers/media/rc/ir-nec-decoder.c | 5 ++- drivers/media/rc/keymaps/rc-tivo.c | 86 +++--- 2 files

[PATCH v2 04/15] media: rc: add sysfs scancode filtering interface

2014-01-17 Thread James Hogan
filter to be applied at the right time. Drivers can convert the scancode filter into a raw IR data filter, which can be applied immediately or later (for wake up filters). Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Rob Landley Cc: linux

[PATCH v2 01/15] media: rc: document rc class sysfs API

2014-01-17 Thread James Hogan
Briefly document /sys/class/rc/ API for remote controller devices in Documentation/ABI/teting. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Rob Landley Cc: linux-...@vger.kernel.org --- v2: - New patch. --- Documentation/ABI/testing/sysfs-class-rc

[PATCH v2 11/15] media: rc: img-ir: add NEC decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the NEC and extended NEC infrared protocols. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update scancode and filter callbacks to handle 32-bit NEC as used by Apple and TiVo remotes (the new 32-bit NEC

[PATCH v2 12/15] media: rc: img-ir: add JVC decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the JVC infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove modularity

[PATCH v2 13/15] media: rc: img-ir: add Sony decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the Sony infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove

[PATCH v2 15/15] media: rc: img-ir: add Sanyo decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the Sanyo infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove

[PATCH v2 06/15] dt: binding: add binding for ImgTec IR block

2014-01-17 Thread James Hogan
Add device tree binding for ImgTec Consumer Infrared block, specifically major revision 1 of the hardware. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet

[PATCH v2 08/15] media: rc: img-ir: add raw driver

2014-01-17 Thread James Hogan
Add raw IR remote control input driver for the ImgTec Infrared decoder block's raw edge interrupts. Generic software protocol decoders are used to allow multiple protocols to be supported at a time, including those not supported by the hardware decoder. Signed-off-by: James Hogan Cc:

[PATCH v2 07/15] media: rc: img-ir: add base driver

2014-01-17 Thread James Hogan
Add base driver for the ImgTec Infrared decoder block. The driver is split into separate components for raw (software) decode and hardware decoder which are in following commits. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Grant Likely Cc: Rob

[PATCH v2 09/15] media: rc: img-ir: add hardware decoder driver

2014-01-17 Thread James Hogan
filter conversion function will be provided in separate files for each protocol which this part of the driver can use. The new generic scan code filter interface is made use of to reduce interrupts and control wake events. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media

[PATCH v2 14/15] media: rc: img-ir: add Sharp decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the Sharp infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove

[PATCH v2 02/15] media: rc: add Sharp infrared protocol

2014-01-17 Thread James Hogan
Add Sharp infrared protocol constants RC_TYPE_SHARP and RC_BIT_SHARP. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/rc-main.c | 1 + include/media/rc-map.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 10/15] media: rc: img-ir: add to build

2014-01-17 Thread James Hogan
Add ImgTec IR decoder driver to the build system. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/Kconfig | 2 ++ drivers/media/rc/Makefile| 1 + drivers/media/rc/img-ir/Kconfig | 26

[PATCH v2 00/15] media: rc: ImgTec IR decoder driver

2014-01-17 Thread James Hogan
Jarod Wilson Cc: linux-media@vger.kernel.org Cc: Grant Likely Cc: Rob Herring Cc: devicet...@vger.kernel.org Cc: Rob Landley Cc: linux-...@vger.kernel.org Cc: Tomasz Figa James Hogan (15): media: rc: document rc class sysfs API media: rc: add Sharp infrared protocol media: rc: add raw dec

Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes

2014-02-05 Thread James Hogan
Hi Antti, On 05/02/14 07:03, Antti Seppälä wrote: > To wake up with nuvoton-cir we need to program several raw ir > pulse/space lengths to the hardware and not a scancode. James's > approach doesn't support this. Do the raw pulse/space lengths your hardware requires correspond to a single IR pack

Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes

2014-02-05 Thread James Hogan
On 05/02/14 09:39, James Hogan wrote: > Hi Antti, > > On 05/02/14 07:03, Antti Seppälä wrote: >> To wake up with nuvoton-cir we need to program several raw ir >> pulse/space lengths to the hardware and not a scancode. James's >> approach doesn't support this

[PATCH] rc: ir-raw: Load ir-sharp-decoder module at init

2014-02-05 Thread James Hogan
Commit 1d184b0bc13d ([media] media: rc: add raw decoder for Sharp protocol) added a new raw IR decoder for the sharp protocol, but didn't add the code to load the module at init as is done for other raw decoders, so add that code now. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab --

Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes

2014-02-06 Thread James Hogan
On 05/02/14 21:21, Mauro Carvalho Chehab wrote: > Em Wed, 05 Feb 2014 20:16:04 +0200 > Antti Seppälä escreveu: > >> On 5 February 2014 11:42, James Hogan wrote: >>> On 05/02/14 09:39, James Hogan wrote: >>>> Hi Antti, >>>> >>>> O

Re: [PATCH v2 06/15] dt: binding: add binding for ImgTec IR block

2014-02-06 Thread James Hogan
Hi Rob, On 06/02/14 14:33, Rob Herring wrote: > On Fri, Jan 17, 2014 at 7:58 AM, James Hogan wrote: >> +Required properties: >> +- compatible: Should be "img,ir1" > > Kind of short for a name. I don't have anything much better, but how > about img

[RFC 1/4] rc: ir-raw: add scancode encoder callback

2014-02-06 Thread James Hogan
Add a callback to raw ir handlers for encoding and modulating a scancode to a set of raw events. This could be used for transmit, or for converting a wakeup scancode filter to a form that is more suitable for raw hardware wake up filters. Signed-off-by: James Hogan --- drivers/media/rc/ir-raw.c

[RFC 3/4] rc: ir-nec-decoder: add encode capability

2014-02-06 Thread James Hogan
Add the capability to encode NEC scancodes as raw events. The scancode_to_raw is pretty much taken from the img-ir NEC filter() callback, and modulation uses the pulse distance helper added in a previous commit. Signed-off-by: James Hogan --- drivers/media/rc/ir-nec-decoder.c | 91

[RFC 2/4] rc: ir-raw: add modulation helpers

2014-02-06 Thread James Hogan
Add IR encoding helpers, particularly for pulse-distance modulation as used by the NEC protocol. Signed-off-by: James Hogan --- drivers/media/rc/ir-raw.c | 33 +++ drivers/media/rc/rc-core-priv.h | 44 + 2 files changed

[RFC 0/4] rc: ir-raw: Add encode, implement NEC encode

2014-02-06 Thread James Hogan
apply similarly to any raw ir driver to try it out. James Hogan (4): rc: ir-raw: add scancode encoder callback rc: ir-raw: add modulation helpers rc: ir-nec-decoder: add encode capability DEBUG: rc: img-ir: raw: Add loopback on s_filter drivers/media/rc/img-ir/img-ir-raw.c | 30 dr

[RFC 4/4] DEBUG: rc: img-ir: raw: Add loopback on s_filter

2014-02-06 Thread James Hogan
Purely for the purposes of debugging the raw IR encode, add the s_filter callback to the img-ir-raw driver, which instead of setting the filter just feeds it back through the input device so that it can be verified. --- drivers/media/rc/img-ir/img-ir-raw.c | 30 ++ 1 fi

[PATCH v3 06/15] dt: binding: add binding for ImgTec IR block

2014-02-07 Thread James Hogan
Add device tree binding for ImgTec Consumer Infrared block, specifically major revision 1 of the hardware. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet

[PATCH v3 07/15] media: rc: img-ir: add base driver

2014-02-07 Thread James Hogan
Add base driver for the ImgTec Infrared decoder block. The driver is split into separate components for raw (software) decode and hardware decoder which are in following commits. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Grant Likely Cc: Rob

Re: [RFC 0/4] rc: ir-raw: Add encode, implement NEC encode

2014-02-10 Thread James Hogan
Hi Antti, On 08/02/14 11:30, Antti Seppälä wrote: >> The first patch adds an encode callback to the existing raw ir handler >> struct and a helper function to encode a scancode for a given protocol. >> > > The mechanism used here to encode works fine as long as there is only > one protocol select

Re: [RFC PATCH 1/3] rc-core: Add Manchester encoder (phase encoder) support to rc-core

2014-02-10 Thread James Hogan
Hi Antti, On 08/02/14 12:07, Antti Seppälä wrote: > Adding a simple Manchester encoder to rc-core. > Manchester coding is used by at least RC-5 protocol and its variants. > > Signed-off-by: Antti Seppälä > --- > drivers/media/rc/ir-raw.c | 44 > + >

Re: [RFC PATCH 2/3] ir-rc5-sz: Add ir encoding support

2014-02-10 Thread James Hogan
Hi Antti, On 08/02/14 12:07, Antti Seppälä wrote: > The encoding in rc5-sz first inserts a pulse and then simply utilizes the > generic Manchester encoder available in rc-core. > > Signed-off-by: Antti Seppälä > --- > drivers/media/rc/ir-rc5-sz-decoder.c | 35 +++

Re: [RFC PATCH 2/3] ir-rc5-sz: Add ir encoding support

2014-02-10 Thread James Hogan
Hi Antti, On Monday 10 February 2014 22:09:33 Antti Seppälä wrote: > >> +static int ir_rc5_sz_encode(u64 protocols, > >> + const struct rc_scancode_filter *scancode, > >> + struct ir_raw_event *events, unsigned int max) > >> +{ > >> + int ret; >

[PATCH] rc-main: store_filter: pass errors to userland

2014-02-10 Thread James Hogan
ionally on success of s_filter, but the write always reported success back to userland. Reported-by: Antti Seppälä Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/rc-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC PATCH 2/3] ir-rc5-sz: Add ir encoding support

2014-02-11 Thread James Hogan
On Tuesday 11 February 2014 20:14:19 Antti Seppälä wrote: > On 10 February 2014 22:50, James Hogan wrote: > >> > I suspect it needs some more space at the end too, to be sure that no > >> > more bits afterwards are accepted. > >> > >> I'm sorry

Re: [RFC PATCH 2/3] ir-rc5-sz: Add ir encoding support

2014-02-27 Thread James Hogan
On Sunday 16 February 2014 19:04:01 Antti Seppälä wrote: > On 12 February 2014 01:39, James Hogan wrote: > > On Tuesday 11 February 2014 20:14:19 Antti Seppälä wrote: > >> Are you working on the wakeup protocol selector sysfs interface? > > > > I gave it a try yeste

Re: [PATCH v3 06/15] dt: binding: add binding for ImgTec IR block

2014-02-27 Thread James Hogan
Hi Rob, Mark + DT maintainers, On Friday 07 February 2014 15:49:15 James Hogan wrote: > Add device tree binding for ImgTec Consumer Infrared block, specifically > major revision 1 of the hardware. > > Signed-off-by: James Hogan > Cc: Mauro Carvalho Chehab > Cc: linux-media@vg

Re: [PATCH v3 06/15] dt: binding: add binding for ImgTec IR block

2014-02-28 Thread James Hogan
On 28/02/14 01:28, Rob Herring wrote: > On Thu, Feb 27, 2014 at 4:52 PM, James Hogan wrote: >>> v3: >>> - Rename compatible string to "img,ir-rev1" (Rob Herring). >>> - Specify ordering of clocks explicitly (Rob Herring). >> >> I'd apprec

[PATCH 1/5] rc-main: add generic scancode filtering

2014-02-28 Thread James Hogan
filter out the corner cases. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: Antti Seppälä Cc: linux-media@vger.kernel.org --- drivers/media/rc/rc-main.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers

[PATCH 3/5] rc: add allowed/enabled wakeup protocol masks

2014-02-28 Thread James Hogan
first element (RC_FILTER_NORMAL), and add a couple more helper functions for drivers to use for setting the allowed and enabled wakeup protocols. We also rename allowed_protos to allowed_protocols while we're at it, which is more consistent with enabled_protocols. Signed-off-by: James Hoga

[PATCH 5/5] rc-main: automatically refresh filter on protocol change

2014-02-28 Thread James Hogan
callback to be omitted entirely if there is only a single available wakeup protocol at a time, since selecting no protocol will automatically clear the wakeup filter, disabling wakeup. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: Antti Seppälä Cc: linux-media@vger.kernel.org --- drivers

[PATCH 4/5] rc: add wakeup_protocols sysfs file

2014-02-28 Thread James Hogan
Add a wakeup_protocols sysfs file which controls the new rc_dev::enabled_protocols[RC_FILTER_WAKEUP], which is the mask of protocols that are used for the wakeup filter. A new RC driver callback change_wakeup_protocol() is called to change the wakeup protocol mask. Signed-off-by: James Hogan Cc

[PATCH 2/5] rc: abstract access to allowed/enabled protocols

2014-02-28 Thread James Hogan
The allowed and enabled protocol masks need to be expanded to be per filter type in order to support wakeup filter protocol selection. To ease that process abstract access to the rc_dev::allowed_protos and rc_dev::enabled_protocols members with inline functions. Signed-off-by: James Hogan Cc

[PATCH 0/5] rc: scancode filtering improvements

2014-02-28 Thread James Hogan
Cc: Mauro Carvalho Chehab Cc: "Bruno Prémont" Cc: Maxim Levitsky Cc: Sean Young Cc: "David Härdeman" Cc: Jiri Kosina Cc: "Antti Seppälä" James Hogan (5): rc-main: add generic scancode filtering rc: abstract access to allowed/enabled protocols rc: add al

[PATCH v4 00/10] media: rc: ImgTec IR decoder driver

2014-02-28 Thread James Hogan
ypo in logic 1 pulse width comment. - Set tolerance to 20%, which seemed to be needed for the cases I have. Cc: Mauro Carvalho Chehab Cc: Jarod Wilson Cc: linux-media@vger.kernel.org Cc: Grant Likely Cc: Rob Herring Cc: devicet...@vger.kernel.org Cc: Rob Landley Cc: linux-...@vger.kernel.org C

[PATCH v4 01/10] dt: binding: add binding for ImgTec IR block

2014-02-28 Thread James Hogan
Add device tree binding for ImgTec Consumer Infrared block, specifically major revision 1 of the hardware. Signed-off-by: James Hogan Acked-by: Rob Herring Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet

[PATCH v4 02/10] rc: img-ir: add base driver

2014-02-28 Thread James Hogan
Add base driver for the ImgTec Infrared decoder block. The driver is split into separate components for raw (software) decode and hardware decoder which are in following commits. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Grant Likely Cc: Rob

[PATCH v4 05/10] rc: img-ir: add to build

2014-02-28 Thread James Hogan
Add ImgTec IR decoder driver to the build system. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/Kconfig | 2 ++ drivers/media/rc/Makefile| 1 + drivers/media/rc/img-ir/Kconfig | 26

[PATCH v4 07/10] rc: img-ir: add JVC decoder module

2014-02-28 Thread James Hogan
Add an img-ir module for decoding the JVC infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove modularity

[PATCH v4 08/10] rc: img-ir: add Sony decoder module

2014-02-28 Thread James Hogan
Add an img-ir module for decoding the Sony infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove

[PATCH v4 09/10] rc: img-ir: add Sharp decoder module

2014-02-28 Thread James Hogan
Add an img-ir module for decoding the Sharp infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove

[PATCH v4 03/10] rc: img-ir: add raw driver

2014-02-28 Thread James Hogan
Add raw IR remote control input driver for the ImgTec Infrared decoder block's raw edge interrupts. Generic software protocol decoders are used to allow multiple protocols to be supported at a time, including those not supported by the hardware decoder. Signed-off-by: James Hogan Cc:

[PATCH v4 06/10] rc: img-ir: add NEC decoder module

2014-02-28 Thread James Hogan
Add an img-ir module for decoding the NEC and extended NEC infrared protocols. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update scancode and filter callbacks to handle 32-bit NEC as used by Apple and TiVo remotes (the new 32-bit NEC

[PATCH v4 10/10] rc: img-ir: add Sanyo decoder module

2014-02-28 Thread James Hogan
Add an img-ir module for decoding the Sanyo infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic struct rc_scancode_filter). - Remove

[PATCH v4 04/10] rc: img-ir: add hardware decoder driver

2014-02-28 Thread James Hogan
filter conversion function will be provided in separate files for each protocol which this part of the driver can use. The new generic scan code filter interface is made use of to reduce interrupts and control wake events. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media

[PATCH] rc-main: fix missing unlock if no devno left

2014-03-01 Thread James Hogan
device numbers left. The added code doesn't depend on the device lock, so move it before the lock is taken. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/rc-main.c | 16 1 file changed, 8 insertions(+), 8 dele

Re: [PATCH 0/5] rc: scancode filtering improvements

2014-03-05 Thread James Hogan
Hi Antti, On Wednesday 05 March 2014 20:12:15 Antti Seppälä wrote: > After reviewing the series and porting my nuvoton changes to it I > haven't noticed any errors worth mentioning. > In fact I think this series is very well written and should be merged. Thanks for reviewing! > James, I hope you

Re: [PATCH v4 10/10] rc: img-ir: add Sanyo decoder module

2014-03-12 Thread James Hogan
On 12/03/14 10:57, Mauro Carvalho Chehab wrote: > Hi James, > > Em Fri, 28 Feb 2014 23:29:00 +0000 > James Hogan escreveu: > >> Add an img-ir module for decoding the Sanyo infrared protocol. > > After applying this series, some new warnings are popping u

[PATCH 1/3] rc: img-ir: hw: Remove unnecessary semi-colon

2014-03-13 Thread James Hogan
Fix a coccicheck warning in img-ir driver: drivers/media/rc/img-ir/img-ir-hw.c:500:2-3: Unneeded semicolon Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab --- I don't object to this patch being squashed into the patch "rc: img-ir: add hardware decoder driver". --- drivers/

[PATCH 0/3] rc: img-ir: Fixes a few warnings

2014-03-13 Thread James Hogan
These patches fix a few warnings in the img-ir driver, one from coccinelle and two more from W=1 (thanks Mauro). James Hogan (3): rc: img-ir: hw: Remove unnecessary semi-colon rc: img-ir: hw: Fix min/max bits setup rc: img-ir: jvc: Remove unused no-leader timings drivers/media/rc/img-ir

[PATCH 3/3] rc: img-ir: jvc: Remove unused no-leader timings

2014-03-13 Thread James Hogan
ing: (near initialization for ‘img_ir_jvc.timings.s01’) [-Woverride-init] Reported-by: Mauro Carvalho Chehab Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab --- I don't object to this patch being squashed into the patch "rc: img-ir: add JVC decoder module". --- drivers/med

[PATCH 2/3] rc: img-ir: hw: Fix min/max bits setup

2014-03-13 Thread James Hogan
-variable] Reported-by: Mauro Carvalho Chehab Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab --- I don't object to this patch being squashed into the patch "rc: img-ir: add hardware decoder driver". --- drivers/media/rc/img-ir/img-ir-hw.c | 6 +++--- 1 file changed, 3 insertions(

Re: [PATCH v5 02/18] [media] img-ir: use new wakeup_protocols sysfs mechanism

2016-12-12 Thread James Hogan
Hi Sean (and Sifan), On Mon, Dec 12, 2016 at 09:13:43PM +, Sean Young wrote: > Rather than guessing what variant a scancode is from its length, > use the new wakeup_protocol. > > Signed-off-by: Sean Young > Cc: James Hogan > Cc: Sifan Naeem > --- > drivers/med

Re: [PATCH v5 02/18] [media] img-ir: use new wakeup_protocols sysfs mechanism

2016-12-13 Thread James Hogan
Hi Sean, On Tue, Dec 13, 2016 at 07:54:16AM +, Sean Young wrote: > So that leaves the question open of whether we want to guess the protocol > variant from the scancode for img-ir or if we can live with having to > select this using wakeup_protocols. Having to do this does solve the issue > of

Re: [PATCH] rc-core: add separate defines for protocol bitmaps and numbers

2012-12-17 Thread James Hogan
On 12 October 2012 00:11, David Härdeman wrote: > The RC_TYPE_* defines are currently used both where a single protocol is > expected and where a bitmap of protocols is expected. This patch tries > to separate the two in preparation for the following patches. > > The intended use is also clearer t

[PATCH] rc/ir-raw: use kfifo_rec_ptr_1 instead of kfifo

2012-02-15 Thread James Hogan
d the BUG_ON(retval != sizeof(ev)) gets hit too. According to samples/kfifo/record-example.c struct kfifo_rec_ptr_1 can handle records of a length between 0 and 255 bytes, so change struct ir_raw_event_ctrl to use that instead of struct kfifo. Signed-off-by: James Hogan --- drivers/media/rc/rc

[BUG] divide by zero in uvc_video_clock_update, v3.3-rc4

2012-02-19 Thread James Hogan
Hi, I just tried v3.3-rc4 on an Acer Aspire One Happy 2 netbook. I happened to open the settings dialog box of kopete, which shows a view of the webcam. The kernel switched to a text console with a register dump (see below), indicating a divide error in uvc_video_clock_update. The IP is on 7482,

[PATCH] media: ir-sony-decoder: 15bit function decode fix

2012-02-20 Thread James Hogan
7:1 (0b1110). The old mask had the effect of dropping the MSB of the function number from bit 6, and leaving the LSB of the device number in bit 7. Signed-off-by: James Hogan --- (note, i don't have a 15bit sony remote to test this with, but i'm pretty confident of it's corre

Re: [PATCH v2 1/1] rc: Add support for GPIO based IR Receiver driver.

2012-02-20 Thread James Hogan
On Mon, Feb 20, 2012 at 03:17:52PM +0530, Ravi Kumar V wrote: > Adds GPIO based IR Receiver driver. It decodes signals using decoders > available in rc framework. > > Signed-off-by: Ravi Kumar V > --- > drivers/media/rc/Kconfig|9 ++ > drivers/media/rc/Makefile |1 + > driv

[PATCH RESEND] rc/ir-raw: fix BUG_ON, using kfifo_rec_ptr_1 instead of kfifo

2012-02-22 Thread James Hogan
d the BUG_ON(retval != sizeof(ev)) gets hit too. According to samples/kfifo/record-example.c struct kfifo_rec_ptr_1 can handle records of a length between 0 and 255 bytes, so change struct ir_raw_event_ctrl to use that instead of struct kfifo. Signed-off-by: James Hogan --- drivers/media/rc/rc

[RESEND] [PATCH] media: ir-sony-decoder: 15bit function decode fix

2012-02-27 Thread James Hogan
7:1 (0b1110). The old mask had the effect of dropping the MSB of the function number from bit 6, and leaving the LSB of the device number in bit 7. Signed-off-by: James Hogan --- (note, i don't have a 15bit sony remote to test this with, but i'm pretty confident of it's corre

Re: [PATCH v3 1/1] rc: Add support for GPIO based IR Receiver driver.

2012-02-28 Thread James Hogan
On Tue, Feb 28, 2012 at 11:21:40AM +0530, Ravi Kumar V wrote: > Adds GPIO based IR Receiver driver. It decodes signals using decoders > available in rc framework. > > Signed-off-by: Ravi Kumar V Looks good to me (but I'm no expert). Cheers James > --- > drivers/media/rc/Kconfig|9

[RESEND 2] [PATCH] rc/ir-raw: fix BUG_ON, using kfifo_rec_ptr_1 instead of kfifo

2012-02-29 Thread James Hogan
d the BUG_ON(retval != sizeof(ev)) gets hit too. According to samples/kfifo/record-example.c struct kfifo_rec_ptr_1 can handle records of a length between 0 and 255 bytes, so change struct ir_raw_event_ctrl to use that instead of struct kfifo. Signed-off-by: James Hogan --- drivers/media/rc/rc

Re: [RESEND] [PATCH] media: ir-sony-decoder: 15bit function decode fix

2012-03-05 Thread James Hogan
Ping Another week's gone by with no response. It's a trivial patch, so can somebody please take a look at it? (or if I'm missing somebody relevant from CC, please add them) Thanks James On 27/02/12 11:53, James Hogan wrote: > The raw Sony IR decoder decodes 15bit messages sl

Re: [RESEND] [PATCH] media: ir-sony-decoder: 15bit function decode fix

2012-03-05 Thread James Hogan
On 5 March 2012 17:17, Mauro Carvalho Chehab wrote: > > Em 05-03-2012 11:32, Trilok Soni escreveu: > > Hi James, > > > > On 3/5/2012 5:27 PM, James Hogan wrote: > >> Ping > >> > >> Another week's gone by with no response. It's a trivial

[PATCH 10/11] media: rc: img-ir: add Sharp decoder module

2013-12-13 Thread James Hogan
Add an img-ir module for decoding the Sharp infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/Kconfig| 7 ++ drivers/media/rc/img-ir/Makefile | 1 + drivers/media/rc/img-ir/img-ir-sharp.c | 115

[PATCH 03/11] media: rc: img-ir: add raw driver

2013-12-13 Thread James Hogan
Add raw IR remote control input driver for the ImgTec Infrared decoder block raw edge interrupts. Generic software protocol decoders are used to allow multiple protocols to be supported at a time, including those not supported by the hardware decoder. Signed-off-by: James Hogan Cc: Mauro

[PATCH 06/11] media: rc: img-ir: add NEC decoder module

2013-12-13 Thread James Hogan
Add an img-ir module for decoding the NEC and extended NEC infrared protocols. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/Kconfig | 7 ++ drivers/media/rc/img-ir/Makefile | 1 + drivers/media/rc/img-ir/img-ir

[PATCH 02/11] media: rc: img-ir: add base driver

2013-12-13 Thread James Hogan
Add base driver for the ImgTec Infrared decoder block. The driver is split into separate components for raw (software) decode and hardware decoder which are in following commits. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Grant Likely Cc: Rob

[PATCH 11/11] media: rc: img-ir: add Sanyo decoder module

2013-12-13 Thread James Hogan
Add an img-ir module for decoding the Sanyo infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/Kconfig| 7 ++ drivers/media/rc/img-ir/Makefile | 1 + drivers/media/rc/img-ir/img-ir-sanyo.c | 139

[PATCH 08/11] media: rc: img-ir: add Sony decoder module

2013-12-13 Thread James Hogan
Add an img-ir module for decoding the Sony infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/Kconfig | 7 ++ drivers/media/rc/img-ir/Makefile | 1 + drivers/media/rc/img-ir/img-ir-sony.c | 163

[PATCH 00/11] media: rc: ImgTec IR decoder driver

2013-12-13 Thread James Hogan
...@vger.kernel.org James Hogan (11): dt: binding: add binding for ImgTec IR block media: rc: img-ir: add base driver media: rc: img-ir: add raw driver media: rc: img-ir: add hardware decoder driver media: rc: img-ir: add to build media: rc: img-ir: add NEC decoder module media: rc: img

[PATCH 01/11] dt: binding: add binding for ImgTec IR block

2013-12-13 Thread James Hogan
Add device tree binding for ImgTec Consumer Infrared block. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Stephen Warren Cc: Ian Campbell Cc: devicet...@vger.kernel.org Cc: Rob Landley Cc: linux

[PATCH 04/11] media: rc: img-ir: add hardware decoder driver

2013-12-13 Thread James Hogan
filter conversion function are provided as separate modules for each protocol which this part of the driver can use. The scan code filter value and mask (and the same again for wake from sleep) are specified via sysfs files in /sys/class/rc/rcX/. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab

[PATCH 05/11] media: rc: img-ir: add to build

2013-12-13 Thread James Hogan
Add ImgTec IR decoder driver to the build system. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/Kconfig | 2 ++ drivers/media/rc/Makefile| 1 + drivers/media/rc/img-ir/Kconfig | 26

[PATCH 07/11] media: rc: img-ir: add JVC decoder module

2013-12-13 Thread James Hogan
Add an img-ir module for decoding the JVC infrared protocol. Signed-off-by: James Hogan Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/Kconfig | 7 +++ drivers/media/rc/img-ir/Makefile | 1 + drivers/media/rc/img-ir/img-ir-jvc.c | 109

  1   2   >