Re: [PATCH] rc-core: add loopback driver

2010-12-01 Thread Jarod Wilson
#x27;m understanding this correctly... Very cool, and indeed, very useful. Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: rc: ir-lirc-codec: fix potential integer overflow

2010-12-01 Thread Jarod Wilson
up to sizeof(int)-1 bytes bigger than > expected, > so check value of (n % sizeof(int)) too. > > Signed-off-by: Vasiliy Kulikov > --- > Compile tested only. Looks sane. Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the lin

Re: [PATCH] media: rc: lirc_dev: check kobject_set_name() result

2010-12-01 Thread Jarod Wilson
On Nov 26, 2010, at 12:06 PM, Vasiliy Kulikov wrote: > kobject_set_name() may fail with -ENOMEM, check for it. > > Signed-off-by: Vasiliy Kulikov > --- > Compile tested only. Works for me. Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from

Re: [PATCH] keycodes for DSR-0112 remote bundled with Haupauge MiniStick

2010-12-01 Thread Jarod Wilson
just IR remote controls. > Add kycodes for DSR-0112 remote that comes together with > Haupauge MiniStick > http://lirc.sourceforge.net/remotes/hauppauge/DSR-0112.jpg > > Signed-off-by: Richard Zidlicky Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubsc

[PATCH] media: fix casting issues in timberdale logiwin

2010-11-23 Thread Jarod Wilson
I get warnings about casting to and from pointers and integers of different sizes w/current code, this silences them. Signed-off-by: Jarod Wilson --- drivers/media/video/timblogiw.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/timblogiw.c b

Re: [PATCH 09/10] mceusb: int to bool conversion

2010-11-22 Thread Jarod Wilson
bool tx_mask_inverted:1; >> + bool is_polaris:1; >> +bool no_tx:1; >> >> const char *rc_map; /* Allow specify a per-board map */ >> const char *name; /* per-board name */ This bit looked a bit odd to me though. Isn't the :1 redundant if we've switched to bools? -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drivers/media: nuvoton: fix chip id probe v2

2010-11-19 Thread Jarod Wilson
On Fri, Nov 19, 2010 at 09:42:40PM +0100, Nicolas Kaiser wrote: > Make sure we have a matching chip id high and one or the other > of the chip id low values. > Print the values if the probe fails. > > Signed-off-by: Nicolas Kaiser That works for me, thanks much. Acked-b

Re: [PATCH] drivers/media: nuvoton: fix chip id probe

2010-11-19 Thread Jarod Wilson
uot;%s: chip id mismatch: 0x%02x 0x%02x", I'd probably go with "unsupported chip, id: " instead, since it makes the message a bit clearer, but generally speaking, yeah, something along those lines should be fine. -- Jarod Wilson ja...@redhat.com -- To unsubscribe fr

Re: [RFC PATCH 0/2] Apple remote support

2010-11-18 Thread Jarod Wilson
On Thu, Nov 18, 2010 at 09:43:19PM +0100, David Härdeman wrote: > On Thu, Nov 18, 2010 at 11:33:04AM -0500, Jarod Wilson wrote: > >Mauro's suggestion, iirc, was that max scancode size should be a > >property of the keytable uploaded, and something set at load time (and >

Re: [RFC PATCH 0/2] Apple remote support

2010-11-18 Thread Jarod Wilson
f7a059957ac2da2b0c1aa Mauro's suggestion, iirc, was that max scancode size should be a property of the keytable uploaded, and something set at load time (and probably exposed as a sysfs node, similar to protocols). However, the one issue I see there is that if someone loads a 16-bit keytabl

[PATCH] rc: fix sysfs entry for mceusb and streamzap

2010-11-17 Thread Jarod Wilson
usb-Streamzap__Inc._Streamzap_Remote_Control-event-if00 -> ../event6 lrwxrwxrwx. 1 root root 9 Nov 17 17:05 usb-Topseed_Technology_Corp._eHome_Infrared_Transceiver_TS000BzY-event-if00 -> ../event5 Previously, nada. Tested-by: Jarod Wilson Signed-off-by: Jarod Wilson --- drivers/media/rc/mceusb.c

Re: [patch 3/3] [media] lirc_dev: fixes in lirc_dev_fop_read()

2010-11-17 Thread Jarod Wilson
Also I changed the debug output from "-EFAULT" to just "" because > it isn't -EFAULT necessarily. And since we go though that path if the > length is invalid now, there was another debug print that I removed. > > Signed-off-by: Dan Carpenter Looks good, thanks m

Re: [patch 2/3] [media] lirc_dev: add some __user annotations

2010-11-17 Thread Jarod Wilson
edia/IR/lirc_dev.c:156:27:expected int ( *read )( ... ) > drivers/media/IR/lirc_dev.c:156:27:got int ( extern [toplevel] * > )( ... ) > > Signed-off-by: Dan Carpenter Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line &q

Re: [patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll()

2010-11-17 Thread Jarod Wilson
On Wed, Nov 17, 2010 at 08:12:23AM +0300, Dan Carpenter wrote: > We shouldn't unlock here. I think this was a cut and paste error. Yeah, looks like it. Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-

[PATCH] streamzap: merge timeout space with trailing space

2010-11-17 Thread Jarod Wilson
ested with streamzap and windows mce remotes. Signed-off-by: Jarod Wilson --- drivers/media/rc/streamzap.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/rc/streamzap.c b/drivers/media/rc/streamzap.c index 7781910..19652d4 100644 --- a/drivers/

Re: [PATCH] drivers/media: nuvoton: always true expression

2010-11-16 Thread Jarod Wilson
wed that one up. You're correct, the intention was to make sure we have a matching chip id high and one or the other of the chip id low values. Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in t

Re: [RFC PATCH 0/2] Apple remote support

2010-11-14 Thread Jarod Wilson
On Fri, Nov 5, 2010 at 9:27 AM, David Härdeman wrote: > On Thu, 04 Nov 2010 15:43:33 -0400, Mauro Carvalho Chehab > wrote: >> Em 04-11-2010 15:38, David Härdeman escreveu: >>> On Thu, Nov 04, 2010 at 11:54:25AM -0400, Jarod Wilson wrote: >>>> Okay, so we seem t

Re: [PATCH 2/3] [media] saa7134: Remove legacy IR decoding logic inside the module

2010-11-14 Thread Jarod Wilson
ehab Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] [media] rc: Remove ir-common module

2010-11-14 Thread Jarod Wilson
t; Signed-off-by: Mauro Carvalho Chehab Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] [media] saa7134: use rc-core raw decoders for Encore FM 5.3

2010-11-14 Thread Jarod Wilson
On Nov 13, 2010, at 2:33 PM, Mauro Carvalho Chehab wrote: > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.ke

Re: HVR900H : IR Remote Control

2010-11-14 Thread Jarod Wilson
efan. I've checked the /drivers/media/IR/keymaps of the kernel > source directory, but nothing seems to fit my remote, which is a DSR-0012 : > http://lirc.sourceforge.net/remotes/hauppauge/DSR-0112.jpg. > > Were you talking about these rc_"map" modules? If so and i

[PATCH v2] mceusb: fix keybouce issue after parser simplification

2010-11-12 Thread Jarod Wilson
uppress it when using the standard long-range sensor. Signed-off-by: Jarod Wilson --- v2: fix flub w/duplicate case select values and really test the final product this time... drivers/media/rc/mceusb.c | 56 + 1 files changed, 46 insertions(+), 10

[PATCH] mceusb: fix keybouce issue after parser simplification

2010-11-12 Thread Jarod Wilson
uppress it when using the standard long-range sensor. Signed-off-by: Jarod Wilson --- drivers/media/rc/mceusb.c | 57 + 1 files changed, 47 insertions(+), 10 deletions(-) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index bb8999

[PATCH] IR: allow disabling NEC checksum check, enable apple remote

2010-11-12 Thread Jarod Wilson
luded. Existing NEC extended remotes should continue to fuction with their current 24-bit tables, but we *could* decide in the future to simplify things and just use the full 32 bits for all NEC extended (ish) remotes. Signed-off-by: Jarod Wilson --- drivers/media/rc/ir-nec-decoder.c |

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-11 Thread Jarod Wilson
xplained above. > >>I like the idea of having an inlined function (like >>usb_fill_control_urb), to be sure that all mandatory fields are >>initialized by the drivers. > > I like the idea of having a function, let's call it > rc_register_device(), which makes su

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-09 Thread Jarod Wilson
rnel.org/?p=linux/kernel/git/jarod/linux-2.6-ir.git;a=shortlog;h=refs/heads/staging -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3 v2] IR: add tv power scancode to rc6 mce keymap

2010-11-09 Thread Jarod Wilson
And clean up some stray spaces. Signed-off-by: Jarod Wilson --- drivers/media/IR/keymaps/rc-rc6-mce.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/media/IR/keymaps/rc-rc6-mce.c b/drivers/media/IR/keymaps/rc-rc6-mce.c index 1b7adab

[PATCH 2/3 v2] mceusb: buffer parsing fixups for 1st-gen device

2010-11-09 Thread Jarod Wilson
livered to us. Signed-off-by: Jarod Wilson --- drivers/media/IR/mceusb.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/mceusb.c b/drivers/media/IR/mceusb.c index 1811098..ed151c8 100644 --- a/drivers/media/IR/mceusb.c +++ b/drivers/media/IR/mceusb.c

[PATCH 1/3 v2] mceusb: fix up reporting of trailing space

2010-11-09 Thread Jarod Wilson
, the removal of some magic number usage and some printk spew fixups. Signed-off-by: Jarod Wilson --- drivers/media/IR/mceusb.c | 45 + 1 files changed, 13 insertions(+), 32 deletions(-) diff --git a/drivers/media/IR/mceusb.c b/drivers/media/IR/mceusb.c

[PATCH 0/3 v2] mceusb: buffer parsing and keymap cleanups

2010-11-09 Thread Jarod Wilson
machine. Jarod Wilson (3): mceusb: fix up reporting of trailing space mceusb: buffer parsing fixups for 1st-gen device IR: add tv power scancode to rc6 mce keymap -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the

[PATCH] nuvoton-cir: improve buffer parsing responsiveness

2010-11-09 Thread Jarod Wilson
ignal data' 0x80 packet. Signed-off-by: Jarod Wilson --- Note: this patch should really go into 2.6.37, imo, as non-mce remotes frequently don't behave without it. drivers/media/IR/nuvoton-cir.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/m

Re: [RFC PATCH 0/2] Apple remote support

2010-11-07 Thread Jarod Wilson
sg w/core ir debugging enabled. If we're not pairing, its masked out in the full 32-bit scancode sent along, but still available via dmesg. If we are pairing, the pair byte is included in the full 32-bit scancode sent along. -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] i2c: Mark i2c_adapter.id as deprecated

2010-11-07 Thread Jarod Wilson
On Nov 5, 2010, at 4:10 PM, Jean Delvare wrote: > It's about time to make it clear that i2c_adapter.id is deprecated. > Hopefully this will remind the last user to move over to a different > strategy. > > Signed-off-by: Jean Delvare > Cc: Hans Verkuil > Cc: Jarod

Re: [PATCH 1/3] i2c: Delete unused adapter IDs

2010-11-07 Thread Jarod Wilson
; Big thanks for Hans Verkuil for doing all the hard work :) > > Signed-off-by: Jean Delvare > Cc: Hans Verkuil > Cc: Jarod Wilson I think I2C_HW_B_HDPVR was only being used by a not-yet-merged-upstream patch to the hdpvr driver, which enabled the IR functionality on it. Its not merg

Re: [RFC PATCH 0/2] Apple remote support

2010-11-04 Thread Jarod Wilson
On Thu, Nov 4, 2010 at 8:16 AM, David Härdeman wrote: > On Tue, 2 Nov 2010 16:42:05 -0400, Jarod Wilson > wrote: >> On Mon, Nov 1, 2010 at 5:56 PM, David Härdeman > wrote: >>> On Sat, Oct 30, 2010 at 10:32:14PM -0400, Jarod Wilson wrote: >>>> On Sat, Oct

Re: [PATCH 2/3] mceusb: fix up reporting of trailing space

2010-11-03 Thread Jarod Wilson
On Wed, Nov 03, 2010 at 01:15:30PM +0100, David Härdeman wrote: > On Tue, 2 Nov 2010 17:12:14 -0400, Jarod Wilson wrote: > > On Fri, Oct 29, 2010 at 09:21:21PM +0200, David Härdeman wrote: > >> I think the driver could be further simplified by using > >> ir_raw_event

Re: [PATCH 2/3] mceusb: fix up reporting of trailing space

2010-11-02 Thread Jarod Wilson
On Fri, Oct 29, 2010 at 09:21:21PM +0200, David Härdeman wrote: > On Thu, Oct 28, 2010 at 11:08:10PM -0400, Jarod Wilson wrote: > > We were storing a bunch of spaces at the end of each signal, rather than > > a single long space. The in-kernel decoders were actually okay with >

Re: [RFC PATCH 0/2] Apple remote support

2010-11-02 Thread Jarod Wilson
On Mon, Nov 1, 2010 at 5:56 PM, David Härdeman wrote: > On Sat, Oct 30, 2010 at 10:32:14PM -0400, Jarod Wilson wrote: >> On Sat, Oct 30, 2010 at 7:36 PM, David Härdeman wrote: >> > In that case, one solution would be: >> > >> > * using the full 32 bit scanc

Re: [PATCH 0/6] rc-core: ir-core to rc-core conversion

2010-11-02 Thread Jarod Wilson
hese patches touch every single driver. Obviously I > haven't tested them all due to a lack of hardware (I have made sure that > all drivers compile without any warnings and I have tested the end result > on mceusb and winbond-cir hardware, Jarod Wilson has tested nuvoton-cir, > imon and

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

2010-11-02 Thread Jarod Wilson
On Tue, Nov 2, 2010 at 12:24 PM, Dmitry Torokhov wrote: > On Tue, Nov 02, 2010 at 12:04:56PM -0400, Jarod Wilson wrote: >> On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov >> wrote: >> > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: >> >>

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

2010-11-02 Thread Jarod Wilson
; > drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': > drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used > uninitialized in this function > > Reported-by: Stefan Richter > Signed-off-by: Dmitry Torokhov Acked-by: Jar

Re: [PATCH 7/7] rc-core: convert winbond-cir

2010-11-02 Thread Jarod Wilson
On Fri, Oct 29, 2010 at 3:08 PM, David Härdeman wrote: > Move winbond-cir from drivers/input/misc/ into drivers/media/IR/ > and convert it to use rc-core. > > Signed-off-by: David Härdeman Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this li

Re: [PATCH 6/7] ir-core: make struct rc_dev the primary interface

2010-11-02 Thread Jarod Wilson
evice_free() > rc_device_register() > rc_device_unregister() > > Signed-off-by: David Härdeman Acked-by: Jarod Wilson Tested-by: Jarod Wilson Tested mceusb, streamzap, imon and nuvonton-cir. -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 5/7] ir-core: merge and rename to rc-core

2010-11-02 Thread Jarod Wilson
rdeman Acked-by: Jarod Wilson This also gets a... Tested-by: Jarod Wilson ...as I've tested the merged core w/mceusb, streamzap, imon and nuvoton-cir. -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in t

Re: [PATCH 4/7] ir-core: more cleanups of ir-functions.c

2010-11-02 Thread Jarod Wilson
_LEGACY. > > Signed-off-by: David Härdeman Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/7] ir-core: remove remaining users of the ir-functions keyhandlers

2010-11-02 Thread Jarod Wilson
David Härdeman Acked-by: Jarod Wilson Also tested the imon bits, at least as part of the whole series. -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH 2/7] ir-core: convert drivers/media/video/cx88 to ir-core

2010-11-02 Thread Jarod Wilson
sponds to 32 samples). > > Thanks to Mariusz Bialonczyk for testing my patches > (about one a day for two weeks!) on actual hardware. > > Signed-off-by: David Härdeman Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "

Re: [RFC PATCH 0/2] Apple remote support

2010-10-30 Thread Jarod Wilson
On Sat, Oct 30, 2010 at 7:36 PM, David Härdeman wrote: > On Fri, Oct 29, 2010 at 04:09:37PM -0400, Jarod Wilson wrote: >> On Fri, Oct 29, 2010 at 09:59:18PM +0200, David Härdeman wrote: >> > On Fri, Oct 29, 2010 at 03:27:33PM -0400, Jarod Wilson wrote: >> > > On F

Re: [PATCH 0/7] rc-core: ir-core to rc-core conversion

2010-10-29 Thread Jarod Wilson
gt; all drivers compile without any warnings and I have tested the end result > on mceusb and winbond-cir hardware). You can definitely sign me up for imon, streamzap and nuvoton-cir testing, and for sanity's sake, I can also verify multiple generations of mceusb devices. I'll see wh

Re: [RFC PATCH 0/2] Apple remote support

2010-10-29 Thread Jarod Wilson
On Fri, Oct 29, 2010 at 09:59:18PM +0200, David Härdeman wrote: > On Fri, Oct 29, 2010 at 03:27:33PM -0400, Jarod Wilson wrote: > > On Fri, Oct 29, 2010 at 09:17:11PM +0200, David Härdeman wrote: > > > On Fri, Oct 29, 2010 at 11:11:41AM -0400, Jarod Wilson wrote: > > >

Re: [PATCH 2/3] mceusb: fix up reporting of trailing space

2010-10-29 Thread Jarod Wilson
On Fri, Oct 29, 2010 at 09:21:21PM +0200, David Härdeman wrote: > On Thu, Oct 28, 2010 at 11:08:10PM -0400, Jarod Wilson wrote: > > We were storing a bunch of spaces at the end of each signal, rather than > > a single long space. The in-kernel decoders were actually okay with >

Re: [RFC PATCH 0/2] Apple remote support

2010-10-29 Thread Jarod Wilson
On Fri, Oct 29, 2010 at 09:17:11PM +0200, David Härdeman wrote: > On Fri, Oct 29, 2010 at 11:11:41AM -0400, Jarod Wilson wrote: > > So the Apple remotes do something funky... One of the four bytes is a > > remote identifier byte, which is used for pairing the remote to a specific

Re: [RFC PATCH 0/2] Apple remote support

2010-10-29 Thread Jarod Wilson
On Fri, Oct 29, 2010 at 11:46:02AM -0200, Mauro Carvalho Chehab wrote: > Em 29-10-2010 01:15, Jarod Wilson escreveu: > > On Thu, Oct 28, 2010 at 11:11:31PM -0400, Jarod Wilson wrote: > >> I've got one of those tiny little 6-button Apple remotes here, now it can > >>

Re: [RFC PATCH 0/2] Apple remote support

2010-10-28 Thread Jarod Wilson
On Thu, Oct 28, 2010 at 11:11:31PM -0400, Jarod Wilson wrote: > I've got one of those tiny little 6-button Apple remotes here, now it can > be decoded in-kernel (tested w/an mceusb transceiver). Oh yeah, RFC, because I'm not sure if we should have a more generic "skip the ch

[RFC PATCH 2/2] IR: add Apple remote keymap

2010-10-28 Thread Jarod Wilson
Apple remote, but I don't have one of those. Signed-off-by: Jarod Wilson --- drivers/media/IR/keymaps/Makefile |1 + drivers/media/IR/keymaps/rc-nec-apple.c | 51 +++ include/media/rc-map.h |1 + 3 files changed, 53 insertions(

[RFC PATCH 1/2] ir-nec-decoder: decode Apple's NEC remote variant

2010-10-28 Thread Jarod Wilson
Apple's remotes use an NEC-like protocol, but without checksumming. See http://en.wikipedia.org/wiki/Apple_Remote for details. Since they always send a specific vendor code, check for that, and bypass the checksum check. Signed-off-by: Jarod Wilson --- drivers/media/IR/ir-nec-decoder.c |

[RFC PATCH 0/2] Apple remote support

2010-10-28 Thread Jarod Wilson
I've got one of those tiny little 6-button Apple remotes here, now it can be decoded in-kernel (tested w/an mceusb transceiver). Jarod Wilson (2): ir-nec-decoder: decode Apple's NEC remote variant IR: add Apple remote keymap drivers/media/IR/ir-nec-decoder.c

[PATCH 3/3] mceusb: buffer parsing fixups for 1st-gen device

2010-10-28 Thread Jarod Wilson
livered to us. Signed-off-by: Jarod Wilson --- drivers/media/IR/mceusb.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/mceusb.c b/drivers/media/IR/mceusb.c index a05dec7..09a62f1 100644 --- a/drivers/media/IR/mceusb.c +++ b/drivers/media/IR/mceusb.c

[PATCH 2/3] mceusb: fix up reporting of trailing space

2010-10-28 Thread Jarod Wilson
rintk macros and a magic number. Signed-off-by: Jarod Wilson --- drivers/media/IR/mceusb.c | 39 +++ 1 files changed, 23 insertions(+), 16 deletions(-) diff --git a/drivers/media/IR/mceusb.c b/drivers/media/IR/mceusb.c index e453c6b..a05dec7 100644 --- a/dr

[PATCH 1/3] mceusb: add support for Conexant Hybrid TV RDU253S

2010-10-28 Thread Jarod Wilson
Another multi-function Conexant device. Interface 0 is IR, though on this model, TX isn't wired up at all, so I've mixed in support for models without TX (and verified that lircd says TX isn't supported when trying to send w/this device). Signed-off-by: Jarod Wilson --- d

[PATCH 0/3] mceusb cleanups and new device support

2010-10-28 Thread Jarod Wilson
Another round of mceusb patches... Jarod Wilson (3): mceusb: add support for Conexant Hybrid TV RDU253S mceusb: fix up reporting of trailing space mceusb: buffer parsing fixups for 1st-gen device drivers/media/IR/mceusb.c | 82

[PATCH] new_build/v2.6.32: build lirc_dev, ir-lirc-codec, mceusb, imon

2010-10-27 Thread Jarod Wilson
With some minor kfifo-related changes, lirc_dev ir-lirc-codec can be built on a 2.6.32-based kernel (Red Hat Enterprise Linux 6). The mceusb and imon drivers build fine without any changes, modulo a warning about pr_fmt being redefined in the imon driver. Signed-off-by: Jarod Wilson

[PATCH 2/3] imon: remove redundant change_protocol call

2010-10-23 Thread Jarod Wilson
There was a redundant call to imon_ir_change_protocol -- its already getting called from ir_input_register. Also do some minor housekeeping with var names and formatting. Signed-off-by: Jarod Wilson --- drivers/media/IR/imon.c | 25 +++-- 1 files changed, 7 insertions

[PATCH 3/3] imon: fix nomouse modprobe option

2010-10-23 Thread Jarod Wilson
Pointed out by Bonne Eggleston on the lirc list. Signed-off-by: Jarod Wilson --- drivers/media/IR/imon.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c index b4d489d..f782a9d 100644 --- a/drivers/media/IR/imon.c

[PATCH 1/3] imon: fix my egregious brown paper bag w/rdev/idev split

2010-10-23 Thread Jarod Wilson
Somehow, I managed to screw things up when reworking the rdev/idev split patch from David, and started trying to get ir_input_dev from idev instead of rdev, thus resulting in button presses hanging the system. This fixes it. Signed-off-by: Jarod Wilson --- drivers/media/IR/imon.c | 19

[PATCH 0/3] imon IR driver fixups

2010-10-23 Thread Jarod Wilson
fixup. Jarod Wilson (3): imon: fix my egregious brown paper bag w/rdev/idev split imon: remove redundant change_protocol call imon: fix nomouse modprobe option drivers/media/IR/imon.c | 48 +- 1 files changed, 18 insertions(+

[GIT PULL REQUEST] more IR enhancements for 2.6.37-rc1

2010-10-22 Thread Jarod Wilson
/scm/linux/kernel/git/jarod/linux-2.6-lirc.git staging Jarod Wilson (13): lirc_dev: sanitize function and struct names a bit lirc_dev: fix pointer to owner lirc_dev: get irctl from irctls by inode again lirc_dev: more error-checking improvements lirc_dev: call cdev_

Re: [PATCH 0/3] mceusb: allow per-model data

2010-10-22 Thread Jarod Wilson
nal work on top of it in my tree, then have you pull from there... -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Support for Elgato Video Capture.

2010-10-22 Thread Jarod Wilson
e v4l/dvb > media_tree as requested. > > Signed-off-by: Adrian Taylor Looks good, thanks for the redo. Reviewed-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [PATCH 4/4] [media] mceusb: Fix parser for Polaris

2010-10-21 Thread Jarod Wilson
On Oct 21, 2010, at 4:38 PM, Mauro Carvalho Chehab wrote: > Em 21-10-2010 18:06, Jarod Wilson escreveu: >> On Oct 21, 2010, at 10:07 AM, Mauro Carvalho Chehab wrote: >> >>> Add a parser for polaris mce. On this device, sometimes, a control >>> data appears t

Re: [PATCH 4/4] [media] mceusb: Fix parser for Polaris

2010-10-21 Thread Jarod Wilson
*/ > + rawir.pulse = 0; > + rawir.duration = IR_MAX_DURATION; > + dev_dbg(ir->dev, "Storing %s with duration %d\n", > + rawir.pulse ? "pulse" : "space", > + r

Re: [PATCH 3/4] [media] mceusb: Improve parser to get codes sent together with IR RX data

2010-10-21 Thread Jarod Wilson
uf_in[i] == 0x80 || ir->buf_in[i] == 0x9f) > ir->rem = 0; > > - dev_dbg(ir->dev, "calling ir_raw_event_handle\n"); > - ir_raw_event_handle(ir->idev); > } > + dev_dbg(ir->dev, "calling ir_raw_event_handle\

Re: [PATCH 1/4] [media] cx231xx: Fix compilation breakage if DVB is not selected

2010-10-21 Thread Jarod Wilson
io.o] Erro 1 > make[3]: ** [drivers/media/video/cx231xx] Erro 2 > make[2]: ** [drivers/media/video] Erro 2 > make[1]: ** [drivers/media] Erro 2 > make: ** [drivers] Erro 2 > > Reported-by: Marcio Araujo Alves > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jarod Wilson --

Re: [PATCH 2/4] [media] ir-raw-event: Fix a stupid error at a printk

2010-10-21 Thread Jarod Wilson
mple: (%05dus %s)\n", >                TO_US(ev->duration), TO_STR(ev->pulse)); > >        if (kfifo_in(&ir->raw->kfifo, ev, sizeof(*ev)) != sizeof(*ev)) Acked-by: Jarod Wilson -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH RFC] ir-rc5-decoder: don't wait for the end space to produce a code

2010-10-21 Thread Jarod Wilson
and merge that part via my staging tree, if you don't mind. (I've got a dozen or so IR patches that have been queueing up, planning on another pull req relatively soon). -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH] Support for Elgato Video Capture

2010-10-20 Thread Jarod Wilson
ine EM2800_BOARD_VC211A 74 > #define EM2882_BOARD_DIKOM_DK300 75 > +#define EM2860_BOARD_ELGATO_VIDEO_CAPTURE 76 > > /* Limits minimum and default number of buffers */ > #define EM28XX_MIN_BUF 4 > -- > 1.7.0.4 -- Jarod Wilson ja...@wilsonet.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] dvb: remove obsolete lgdt3304 driver

2010-10-20 Thread Jarod Wilson
l, > > Please send me a patch removing the legacy driver. More complete support for the lgdt3304 atsc demodulator was added by way of the lgdt3305 driver. There's only one device supported in-tree that has an lgdt3304 (the kworld 340u/ub435-q em28xx stick), and its already using the l

Re: [PATCH 0/3] Remaining patches in my queue for IR

2010-10-20 Thread Jarod Wilson
awir struct its initializing was already kzalloc'd, so we're just needlessly re-zero'ing it out again. Its not bad for clarity's sake, but does add some unnecessary inefficiency. -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsu

Re: Old patches sent via the Mailing list

2010-10-19 Thread Jarod Wilson
ate. But I suspect that, for the list bellow, most of > them are stuff where the > driver maintainer just forgot at limbo. > > From the list of patches under review, we have: ... > == Waiting for Jarod Wilson review/ack == > > Jun,20 2010: drivers/media/IR/im

Re: [PATCH 2/3] cx231xx: Only register USB interface 1

2010-10-19 Thread Jarod Wilson
IR interface. > > Signed-off-by: Mauro Carvalho Chehab Looks good. Reviewed-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 3/3] cx231xx: Remove IR support from the driver

2010-10-19 Thread Jarod Wilson
On Mon, Oct 18, 2010 at 08:52:58PM -0200, Mauro Carvalho Chehab wrote: > Polaris design uses MCE support. Instead of reinventing the wheel, > just let mceusb handle the remote controller. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jarod Wilson -- Jarod Wilson ja...@redha

Re: [PATCH 1/3] mceusb: add support for cx231xx-based IR (e. g. Polaris)

2010-10-19 Thread Jarod Wilson
x231xx-cards. > > Signed-off-by: Mauro Carvalho Chehab Looks good to me. Reviewed-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: drivers/media/IR/imon.c: Use pr_err instead of err

2010-10-18 Thread Jarod Wilson
hes Since I haven't got around to actually looking into using dev_foo bits instead where appropriate, lets just go ahead with this patch and if/when I get around to it later, I can switch things to dev_foo where possible. Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To u

Re: [PATCH 3/5] IR: ene_ir: few bugfixes

2010-10-15 Thread Jarod Wilson
On Fri, Oct 15, 2010 at 10:24:55PM +0200, Maxim Levitsky wrote: > On Fri, 2010-10-15 at 16:02 -0400, Jarod Wilson wrote: > > On Fri, Oct 15, 2010 at 06:06:37PM +0200, Maxim Levitsky wrote: > > > This is a result of last round of debug with > > > Sami R . > >

Re: [PATCH 4/5] IR: ene_ir: add support for carrier reports

2010-10-15 Thread Jarod Wilson
arrier_detect_enabled) { > + ev.carrier_report = true; > + ev.carrier = carrier; > + ev.duty_cycle = duty_cycle; > + ir_raw_event_store(dev->idev, &ev); > + } > } > > /* this enables/disables the CIR RX engine */ Acked-by: Jarod

Re: [PATCH 3/5] IR: ene_ir: few bugfixes

2010-10-15 Thread Jarod Wilson
t; /* Enable carrier detection */ > + ene_write_reg(dev, ENE_CIRCAR_PULS, 0x63); Looks sane, though I'd prefer to see symbolic bit names or some such thing here instead of 0x63. Not something to hold up the patch though. Acked-by: Jarod Wilson -- Jarod Wilson

Re: [PATCH 1/5] IR: extend and sort the MCE keymap

2010-10-15 Thread Jarod Wilson
> > Thanks to: > Sami R > Alexander Skiba > Jordi Pelegrin > > For reports and testing. > > Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-media&quo

[PATCH] IR/nuvoton: address all checkpatch.pl issues

2010-10-15 Thread Jarod Wilson
On Fri, Oct 15, 2010 at 12:39:57AM -0300, Mauro Carvalho Chehab wrote: > Em 12-10-2010 10:50, Jarod Wilson escreveu: > > Jarod Wilson (8): > > IR: add driver for Nuvoton w836x7hg integrated CIR > > There's a number of checkpatch issues on this patch. Pleas

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-10-14 Thread Jarod Wilson
esult of discussion on this patch was that we're all pretty much fine with it going in, even the as-yet-unused duty_cycle bit, as there *are* drivers that can use it sooner than later. Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line

Re: [PATCH] V4L/DVB: ir: properly handle an error at input_register

2010-10-14 Thread Jarod Wilson
On Thu, Oct 14, 2010 at 05:54:38PM -0300, Mauro Carvalho Chehab wrote: > Be sure to rollback all init if input register fails. > > Cc: Maxim Levitsky > Cc: Jarod Wilson > Signed-off-by: Mauro Carvalho Chehab Good catch. /me kicks self for missing that one. Acked-by: Jarod Wils

Re: [2/8] IR: make sure we register the input device when it is safe to do so.

2010-10-14 Thread Jarod Wilson
ack in patchwork, so it may have been from an earlier/superseded version... Finally got my head wrapped around this one too, and I do see the problem, and this fix looks good to me. Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "u

Re: [1/8] IR: plug races in IR raw thread.

2010-10-14 Thread Jarod Wilson
ing logic all remains the same, with the addition of locking that should prevent the race (also heavily supported by your testing). Acked-by: Jarod Wilson -- Jarod Wilson ja...@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a messa

Re: [PATCH] V4L/DVB: ir: avoid race conditions at device disconnect - was: Fwd: Re: *buntu 10.10 rc

2010-10-14 Thread Jarod Wilson
ata: Thu, 14 Oct 2010 12:06:39 -0300 > De: Mauro Carvalho Chehab > Para: Jarod Wilson > CC: Greg Oliver , Douglas Pearless > , LIRC Users > > > Em 14-10-2010 11:47, Jarod Wilson escreveu: >> On Oct 13, 2010, at 11:57 PM, Greg Oliver wrote: >> ... >&g

Re: [GIT PULL REQUEST] IR patches for 2.6.37-rc1

2010-10-12 Thread Jarod Wilson
On Sat, Oct 09, 2010 at 02:23:15PM -0400, Jarod Wilson wrote: > On Fri, Oct 8, 2010 at 5:44 PM, Jarod Wilson wrote: > > Hey Mauro, > > > > I've queued up some lirc fixes and a couple of patches that add a new > > ir-core driver for the Nuvoton w836x7hg Super I/O

Re: [patch -next] V4L/DVB: IR/streamzap: fix usec to nsec conversion

2010-10-12 Thread Jarod Wilson
EAMZAP_TIMEOUT and STREAMZAP_RESOLUTION are 255 and 256 respectively > and are in terms of usecs. > > The original code had a deadline of 1.005 seconds and the new code has a > deadline of .065 seconds. > > Signed-off-by: Dan Carpenter Nice catch, fix looks good. Acked-by

Re: [GIT PULL REQUEST] IR patches for 2.6.37-rc1

2010-10-09 Thread Jarod Wilson
On Fri, Oct 8, 2010 at 5:44 PM, Jarod Wilson wrote: > Hey Mauro, > > I've queued up some lirc fixes and a couple of patches that add a new > ir-core driver for the Nuvoton w836x7hg Super I/O integrated CIR > functionality. All but the Kconfig re-sorting patch have been posted

Re: [PATCH 1/2] IR/lirc: further ioctl portability fixups

2010-10-09 Thread Jarod Wilson
On Oct 9, 2010, at 5:47 AM, Joris van Rantwijk wrote: > On Friday, October 08, 2010 23:12:35 Jarod Wilson wrote: >> I've dropped the .compat_ioctl addition from Joris' original patch, >> as I swear the non-compat definition should now work for both 32-bit >> and 6

[GIT PULL REQUEST] IR patches for 2.6.37-rc1

2010-10-08 Thread Jarod Wilson
ble in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jarod/linux-2.6-lirc.git staging Jarod Wilson (5): IR: add driver for Nuvoton w836x7hg integrated CIR nuvoton-cir: add proper rx fifo overrun handling IR/Kconfig: sort hardware entries alphabetically

[PATCH 2/2] staging/lirc: ioctl portability fixups

2010-10-08 Thread Jarod Wilson
Signed-off-by: Jarod Wilson --- drivers/staging/lirc/lirc_it87.c | 17 - drivers/staging/lirc/lirc_ite8709.c |6 +++--- drivers/staging/lirc/lirc_parallel.c | 32 drivers/staging/lirc/lirc_serial.c | 21

[PATCH 1/2] IR/lirc: further ioctl portability fixups

2010-10-08 Thread Jarod Wilson
lly, I think we still need/want a Signed-off-by: from Joris here. Joris? (And sorry for the lengthy delay in getting a reply to you). Signed-off-by: Jarod Wilson --- drivers/media/IR/ir-lirc-codec.c | 10 +- drivers/media/IR/lirc_dev.c | 14 +++--- include/media/lirc

<    1   2   3   4   5   6   7   8   >