Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread javier Martin
On 16 December 2011 09:34, Scott Jiang scott.jiang.li...@gmail.com wrote: 2011/12/16 Javier Martin javier.mar...@vista-silicon.com: Some v4l-subdevs such as tvp5150 have multiple inputs. This patch allows the user of a soc-camera device to select between them. Signed-off-by: Javier Martin

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread javier Martin
On 16 December 2011 09:47, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier On Fri, 16 Dec 2011, Javier Martin wrote: Some v4l-subdevs such as tvp5150 have multiple inputs. This patch allows the user of a soc-camera device to select between them. Sure, we can support

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread javier Martin
info structures). But AFAIK, soc-camera does not support passing such kind of information. Neither any of the host camera drivers currently available expect that kind of data. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-18 Thread javier Martin
). 2.- Board specific code must tell the subdevice which inputs are really connected and how through platform data. Is that OK? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread javier Martin
independent of the pad-level API. I agree, I cannot contribute to implement pad-level API stuff since I can't test it with tvp5150. Would you accept a patch implementing only S_INPUT? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander

Re: Trying to figure out reasons for lost pictures in UVC driver.

2011-12-19 Thread javier Martin
On 19 December 2011 01:19, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, On Thursday 15 December 2011 17:02:47 javier Martin wrote: Hi, we are testing a logitech Webcam M/N: V-U0012 in the UVC tree (commit ef7728797039bb6a20f22cc2d96ef72d9338cba0). It is configured

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread javier Martin
On 19 December 2011 11:58, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 19 Dec 2011, javier Martin wrote: On 19 December 2011 11:41, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 19 Dec 2011, Laurent Pinchart wrote: Hi Guennadi, On Monday 19 December 2011

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread javier Martin
enough. Javier, could you give it a try? All right, as soon as I have some time I'll go for that approach. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: [PATCH] media i.MX27 camera: add support for YUV420 format.

2011-12-22 Thread javier Martin
Hi, are there any comments on this? May I suppose you agree and it will be applied? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list

MEM2MEM devices: how to handle sequence number?

2011-12-22 Thread javier Martin
. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

[PATCH] media i.MX27 camera: Fix field_count handling.

2011-12-22 Thread Javier Martin
To properly detect frame loss the driver must keep track of a frame_count. Furthermore, field_count use was erroneous because in progressive format this must be incremented twice. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c |5

Re: [PATCH] media i.MX27 camera: Fix field_count handling.

2011-12-22 Thread javier Martin
Argh, sorry, there is a file here that souldn't be included. I'll resend it again. On 22 December 2011 16:05, Javier Martin javier.mar...@vista-silicon.com wrote: To properly detect frame loss the driver must keep track of a frame_count. Furthermore, field_count use was erroneous because

[PATCH v2] media i.MX27 camera: Fix field_count handling.

2011-12-22 Thread Javier Martin
To properly detect frame loss the driver must keep track of a frame_count. Furthermore, field_count use was erroneous because in progressive format this must be incremented twice. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c |5 - 1

Re: [PATCH v2] media i.MX27 camera: Fix field_count handling.

2011-12-22 Thread javier Martin
Hi Guennadi, thank you for your comments. On 23 December 2011 00:17, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 22 Dec 2011, Javier Martin wrote: To properly detect frame loss the driver must keep track of a frame_count. Furthermore, field_count use was erroneous because

Re: [PATCH v2] media i.MX27 camera: Fix field_count handling.

2011-12-23 Thread javier Martin
On 23 December 2011 10:07, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 23 Dec 2011, javier Martin wrote: Hi Guennadi, thank you for your comments. On 23 December 2011 00:17, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 22 Dec 2011, Javier Martin wrote

Re: [PULL] soc-camera for 3.3

2012-01-02 Thread javier Martin
Controller conversion, so, that will have to wait at least until 3.4. Interestingly, Javier Martin has fixed field_count handling in mx2_camera, but, apparently, it also has to be fixed in other soc-camera drivers. So, a patch for that might follow later in the 3.3 cycle. The following changes since

[PATCH] media i.MX27 camera: properly detect frame loss.

2012-01-02 Thread Javier Martin
As V4L2 specification states, frame_count must also regard lost frames so that the user can handle that case properly. This patch adds a mechanism to increment the frame counter even when a video buffer is not available and a discard buffer is used. Signed-off-by: Javier Martin javier.mar

Re: [PATCH v4 0/2] Add support form eMMa-PrP in i.MX2 chips as a mem2mem device.

2012-01-02 Thread javier Martin
Hi, do you have any more concerns or comments on this patch? I can't find it in media_tree. Has it been merged somewhere else? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista

Re: MEM2MEM devices: how to handle sequence number?

2012-01-02 Thread javier Martin
source. Is that OK? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH] media: vb2: vmalloc-based allocator user pointer handling

2012-01-02 Thread javier Martin
Hi, what is the status of this patch? Did you finally merge it in any tree? I am willing to extend it so that it can support pfn mappings as soon as it's ready. Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria

Re: [PATCH] media: tvp5150: Add mbus_fmt callbacks.

2012-01-02 Thread javier Martin
Hi Mauro, any more comments on this? Will you please merge the last version which includes the fixes you requested? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: MEM2MEM devices: how to handle sequence number?

2012-01-02 Thread javier Martin
. But this would break your rule that sequence number introduced at the output queue has to be ignored by the driver. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from

[PATCH 1/2] media: vb2: support userptr for PFN mappings.

2012-01-02 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/videobuf2-vmalloc.c | 66

[PATCH 2/2] uvcvideo: Allow userptr IO mode.

2012-01-02 Thread Javier Martin
Userptr can be very useful if a UVC camera is requested to use video buffers allocated by another processing device. So that buffers don't need to be copied. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/uvc/uvc_queue.c |2 +- 1 files changed, 1

Re: [PATCH v4 0/2] Add support form eMMa-PrP in i.MX2 chips as a mem2mem device.

2012-01-02 Thread javier Martin
On 2 January 2012 22:12, Sylwester Nawrocki snj...@gmail.com wrote: Hi Javier, On 01/02/2012 10:31 AM, javier Martin wrote: Hi, do you have any more concerns or comments on this patch? I can't find it in media_tree. Has it been merged somewhere else? If you think your driver is good enough

Re: [PATCH 1/2] media: vb2: support userptr for PFN mappings.

2012-01-02 Thread javier Martin
Hi Laurent, thank you for your review. On 2 January 2012 20:00, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, Thanks for the patch. On Monday 02 January 2012 15:12:22 Javier Martin wrote: Some video devices need to use contiguous memory which is not backed by pages

Re: [PATCH v4 0/2] Add support form eMMa-PrP in i.MX2 chips as a mem2mem device.

2012-01-03 Thread javier Martin
Added Mauro to CC. On 3 January 2012 08:43, javier Martin javier.mar...@vista-silicon.com wrote: On 2 January 2012 22:12, Sylwester Nawrocki snj...@gmail.com wrote: Hi Javier, On 01/02/2012 10:31 AM, javier Martin wrote: Hi, do you have any more concerns or comments on this patch? I can't

[PATCH 1/2 v2] media: vb2: support userptr for PFN mappings.

2012-01-03 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v1: - Use vb2_get_contig_userptr() which provides page locking and contiguous memory check. Signed-off-by: Javier

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-03 Thread javier Martin
+v3.1.6/drivers/media/video/soc_camera.c#L1006 How am I suppose to pass that information to the tvp5150 then? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

[PATCH 1/2 v3] media: vb2: support userptr for PFN mappings.

2012-01-04 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v2: - Do not grab mm-mmap_sem. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread javier Martin
Hi Guennadi. Thanks for your help. On 3 January 2012 16:05, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier On Tue, 3 Jan 2012, javier Martin wrote: Guennadi, probably you could answer me some question: as we agreed I'm trying to implement ENUM_INPUT support to soc-camera

[PATCH 1/2 v4] media: vb2: support userptr for PFN mappings.

2012-01-04 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v3: - Remove vma_res variable. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media

Question regarding soc-camera v4l subdev status.

2010-03-08 Thread javier Martin
camera drivers? Or, on the other hand, is the subdev support partially implemented right now? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from

[PULL] video_visstrim ov7670_for_v3.9.

2013-01-29 Thread Javier Martin
: ov7670: remove legacy ctrl callbacks. (2013-01-29 12:21:40 +0100) Javier Martin (9): media: ov7670: add support for ov7675. media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'. media: ov7670

mt9m111/mt9m131: kernel 3.8 issues.

2013-03-07 Thread javier Martin
= mt9m111_s_power(mt9m111-subdev, 1); if (ret 0) return ret; Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-07 Thread javier Martin
if the s_width value that your sensor mt9m001 returns is correct? Remember it should be in pixels, not in bytes. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from

Re: [PATCH] soc-camera: mt9m111: Fix auto-exposure control

2013-03-07 Thread javier Martin
. Tested-By: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: mt9m111/mt9m131: kernel 3.8 issues.

2013-03-07 Thread javier Martin
Hi Benoît, thank you for your answer. On 7 March 2013 13:13, Benoît Thébaudeau benoit.thebaud...@advansee.com wrote: Dear Javier Martin, On Thursday, March 7, 2013 10:43:42 AM, Javier Martin wrote: Hi, I am testing mt9m131 sensor (which is supported in mt9m111.c) in mainline kernel 3.8

Re: mt9m111/mt9m131: kernel 3.8 issues.

2013-03-08 Thread javier Martin
whether the grey layer effect still persists. I will try to contact Aptina's technical support but, according to my previous experience, there is no guarantee we get a clarifying answer. I'll keep you updated nevertheless. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345

omap3isp: iommu register problem.

2013-03-11 Thread javier Martin
omap_install_iommu_arch(omap2_iommu_ops); } module_init(omap2_iommu_init); Does anyone know what could be the reason? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from

Re: mt9m111/mt9m131: kernel 3.8 issues.

2013-03-11 Thread javier Martin
colour quality. If Aptina comes up with better settings or I find them I'll post a patch for you to test. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe

Re: omap3isp: iommu register problem.

2013-03-11 Thread javier Martin
. However, according to the previous thread, omap3isp register should return error but an oops should not be generated. So I think there is a bug here anyway. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60

Re: omap3isp: iommu register problem.

2013-03-11 Thread javier Martin
Hi Laurent, thank you for your answer. On 11 March 2013 16:01, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, On Monday 11 March 2013 13:18:12 javier Martin wrote: I've just found the following thread where te problem is explained: http://lists.infradead.org/pipermail

Re: omap3isp: iommu register problem.

2013-03-12 Thread javier Martin
this. Guennadi might be able to give you a bit more information about the current status. So what kind of changes are required to make this work? Are we talking about migrating each soc-camera sensor separately, soc-camera framework changes, both of them? -- Javier Martin Vista Silicon S.L

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread javier Martin
Hi Guernnadi, Christoph, On 12 March 2013 09:25, Christoph Fritz chf.fr...@googlemail.com wrote: On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: On Thu, 7 Mar 2013, javier Martin wrote: What mbus format are you using? Could you please check if the s_width value that your

Re: [PATCH v2] media: i.MX27 camera: fix picture source width

2013-03-12 Thread javier Martin
On 12 March 2013 10:39, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Tue, 12 Mar 2013, javier Martin wrote: Hi Guernnadi, Christoph, On 12 March 2013 09:25, Christoph Fritz chf.fr...@googlemail.com wrote: On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote: On Thu, 7

[RFC] mt9m131/mt9m111 manual exposure control.

2013-03-20 Thread javier Martin
, V4L2_CID_EXPOSURE, + 1, 0x, 1, 0x219); v4l2_ctrl_new_std(mt9m111-hdl, mt9m111_ctrl_ops, V4L2_CID_VFLIP, 0, 1, 1, 0); v4l2_ctrl_new_std(mt9m111-hdl, mt9m111_ctrl_ops, -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S

Re: [PATCH 05/10] coda: Remove unneeded struct vb2_queue clear on queue_init()

2012-08-24 Thread javier Martin
On 23 August 2012 15:08, Ezequiel Garcia elezegar...@gmail.com wrote: queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Javier Martin javier.mar...@vista

Re: [PATCH 07/10] mem2mem-emmaprp: Remove unneeded struct vb2_queue clear on queue_init()

2012-08-24 Thread javier Martin
On 23 August 2012 15:08, Ezequiel Garcia elezegar...@gmail.com wrote: queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Javier Martin javier.mar...@vista

Re: [PATCH 03/12] coda: fix IRAM/AXI handling for i.MX53

2012-08-27 Thread javier Martin
*/ #define CODA_CMD_ENC_HEADER_CODE 0x180 -- 1.7.10.4 Regards. [1] http://lxr.free-electrons.com/source/arch/arm/plat-mxc/iram_alloc.c#L58 -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60

Re: [PATCH 04/12] media: coda: allocate internal framebuffers separately from v4l2 buffers

2012-08-28 Thread javier Martin
; - + v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE); ctx-gopcounter--; -- 1.7.10.4 Otherwise looks good. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain

Re: [PATCH 04/12] media: coda: allocate internal framebuffers separately from v4l2 buffers

2012-08-28 Thread javier Martin
On 28 August 2012 09:50, javier Martin javier.mar...@vista-silicon.com wrote: Hi Phillip, I see you are trying a cleaner approach for reference and reconstructed frames. On 24 August 2012 18:17, Philipp Zabel p.za...@pengutronix.de wrote: Some codecs running on CODA need internal

Re: [PATCH 0/12] Initial i.MX5/CODA7 support for the CODA driver

2012-08-28 Thread javier Martin
++ drivers/media/video/coda.h | 21 +--- 6 files changed, 305 insertions(+), 103 deletions(-) -- Javier Martin Vista

Re: [PATCH 03/12] coda: fix IRAM/AXI handling for i.MX53

2012-08-28 Thread javier Martin
On 28 August 2012 10:24, Philipp Zabel p.za...@pengutronix.de wrote: Hi Javier, thank you for the comments, Am Montag, den 27.08.2012, 10:59 +0200 schrieb javier Martin: Hi Philipp, thank you for your patch. Please, find some comments below. On 24 August 2012 18:17, Philipp Zabel p.za

Re: [PATCH 04/12] media: coda: allocate internal framebuffers separately from v4l2 buffers

2012-08-28 Thread javier Martin
On 28 August 2012 10:40, Philipp Zabel p.za...@pengutronix.de wrote: Hi Javier, Am Dienstag, den 28.08.2012, 09:50 +0200 schrieb javier Martin: Hi Phillip, I see you are trying a cleaner approach for reference and reconstructed frames. -#define CODA_OUTPUT_BUFS 4 -#define

Re: [PATCH 0/12] Initial i.MX5/CODA7 support for the CODA driver

2012-08-28 Thread javier Martin
[i + 1]); fwrite(data, sizeof(data), 1, f); } fclose(f); } On 28 August 2012 12:17, Gaëtan Carlier gcem...@gmail.com wrote: Hi Javier, On 08/28/2012 10:10 AM, javier Martin wrote: Hi Philipp, in order to give you my ACK I need that patch 3 gets fixed and patches 3-10 are resent so

Re: [PATCH v3 03/16] media: coda: fix IRAM/AXI handling for i.MX53

2012-09-03 Thread javier Martin
+#define CODA7_CMD_SET_FRAME_AXI_OVL_ADDR 0x1a0 +#define CODA7_CMD_SET_FRAME_SOURCE_BUF_STRIDE 0x1a8 /* Encoder Header */ #define CODA_CMD_ENC_HEADER_CODE 0x180 -- 1.7.10.4 Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005

Re: [PATCH v3 04/16] media: coda: allocate internal framebuffers separately from v4l2 buffers

2012-09-03 Thread javier Martin
) - v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); - else - ctx-reference = tmp_buf; - + v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE); ctx-gopcounter--; -- 1.7.10.4 -- Javier Martin Vista

Re: [PATCH v3 07/16] media: coda: stop all queues in case of lockup

2012-09-03 Thread javier Martin
= devm_clk_get(pdev-dev, per); -- 1.7.10.4 -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH v3 07/16] media: coda: stop all queues in case of lockup

2012-09-03 Thread javier Martin
-dev, per); -- 1.7.10.4 -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [PATCH v3] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

2012-09-03 Thread javier Martin
Hi, Guennadi,did you pick this one? Regards. On 20 August 2012 11:49, Javier Martin javier.mar...@vista-silicon.com wrote: Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v2: - Add Signed-off-by line. --- drivers/media/video/mx2_camera.c |5 +++-- 1

Re: [PATCH v3] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

2012-09-05 Thread javier Martin
On 5 September 2012 10:29, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Wed, 5 Sep 2012, Guennadi Liakhovetski wrote: Hi Javier On Mon, 3 Sep 2012, javier Martin wrote: Hi, Guennadi,did you pick this one? Wanted to do so, but I've applied this your patch with only

Re: [PATCH v4 01/16] media: coda: firmware loading for 64-bit AXI bus width

2012-09-11 Thread javier Martin
); return; -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line

Re: [PATCH v4 02/16] media: coda: add i.MX53 / CODA7541 platform support

2012-09-11 Thread javier Martin
[] = { { .compatible = fsl,imx27-vpu, .data = coda_platform_ids[CODA_IMX27] }, + { .compatible = fsl,imx53-vpu, .data = coda_devdata[CODA_IMX53] }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, coda_dt_ids); -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier

Re: [PATCH v4 03/16] media: coda: fix IRAM/AXI handling for i.MX53

2012-09-11 Thread javier Martin
+#define CODA7_CMD_SET_FRAME_AXI_OVL_ADDR 0x1a0 +#define CODA7_CMD_SET_FRAME_SOURCE_BUF_STRIDE 0x1a8 /* Encoder Header */ #define CODA_CMD_ENC_HEADER_CODE 0x180 -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C

Re: [PATCH v4 04/16] media: coda: allocate internal framebuffers separately from v4l2 buffers

2012-09-11 Thread javier Martin
Reviewed-by: Javier Martin javier.mar...@vista-silicon.com Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe

Re: [PATCH v4 05/16] media: coda: ignore coda busy status in coda_job_ready

2012-09-11 Thread javier Martin
-v4l2_dev, -not ready: coda is still busy.\n); - return 0; - } - v4l2_dbg(1, coda_debug, ctx-dev-v4l2_dev, job ready\n); return 1; -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier

Re: [PATCH v4 06/16] media: coda: keep track of active instances

2012-09-11 Thread javier Martin
) } spin_lock_init(dev-irqlock); + INIT_LIST_HEAD(dev-instances); dev-plat_dev = pdev; dev-clk_per = devm_clk_get(pdev-dev, per); -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C

Re: [PATCH v4 07/16] media: coda: stop all queues in case of lockup

2012-09-11 Thread javier Martin
; dev-clk_per = devm_clk_get(pdev-dev, per); -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: [PATCH v4 08/16] media: coda: enable user pointer support

2012-09-11 Thread javier Martin
; dst_vq-buf_struct_size = sizeof(struct v4l2_m2m_buffer); dst_vq-ops = coda_qops; -- 1.7.10.4 Acked-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32

Re: [PATCH v4 09/16] media: coda: wait for picture run completion in start/stop_streaming

2012-09-11 Thread javier Martin
); INIT_LIST_HEAD(dev-instances); INIT_DELAYED_WORK(dev-timeout, coda_timeout); + init_completion(dev-done); + complete(dev-done); dev-plat_dev = pdev; dev-clk_per = devm_clk_get(pdev-dev, per); -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista

Re: [PATCH v4 10/16] media: coda: fix sizeimage setting in try_fmt

2012-09-11 Thread javier Martin
, Setting format for type %d, wxh: %dx%d, fmt: %d\n, -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista

Re: [PATCH v4 11/16] media: coda: add horizontal / vertical flipping support

2012-09-11 Thread javier Martin
#define CODA_CMD_ENC_PIC_BB_START 0x198 #define CODA_CMD_ENC_PIC_BB_SIZE 0x19c -- 1.7.10.4 Tested-by: Javier Martin javier.mar...@vista-silicon.com -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32

Re: [PATCH v4 12/16] media: coda: add byte size slice limit control

2012-09-11 Thread javier Martin
, V4L2_CID_MPEG_VIDEO_HEADER_MODE, V4L2_MPEG_VIDEO_HEADER_MODE_JOINED_WITH_1ST_FRAME, -- 1.7.10.4 Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: [PATCH v4 16/16] media: coda: support 1024 px height on CODA7, set max frame size to 1080p

2012-09-11 Thread javier Martin
-- 1.7.10.4 -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH v5 12/13] media: coda: add byte size slice limit control

2012-09-13 Thread javier Martin
Hi Philipp, it now works properly. On 12 September 2012 17:02, Philipp Zabel p.za...@pengutronix.de wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v4: - Fix menu_skip_mask for V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE v4l2_ctrl. Tested-by: Javier Martin javier.mar

Re: [PATCH v5 13/13] media: coda: set up buffers to be sized as negotiated with s_fmt

2012-09-13 Thread javier Martin
--- Acked-by: Javier Martin javier.mar...@vista-silicon.com drivers/media/platform/coda.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index 0235f4e..0e0b4fe 100644 --- a/drivers/media/platform

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread javier Martin
+--- drivers/media/platform/coda.h | 30 ++- 3 files changed, 337 insertions(+), 118 deletions(-) -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread javier Martin
://patchwork.kernel.org/patch/1367011/ https://patchwork.kernel.org/patch/1363331/ https://patchwork.kernel.org/patch/1352551/ Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe

Improving ov7670 sensor driver.

2012-09-13 Thread javier Martin
trivial. The reason of this e-mail is to discuss whether you find these solution suitable or not and, more important, whether you think the suggested changes could break existing drivers. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005

Re: Improving ov7670 sensor driver.

2012-09-13 Thread javier Martin
Hi Hans, thank you for your response. On 13 September 2012 12:07, Hans Verkuil hverk...@xs4all.nl wrote: On Thu 13 September 2012 11:48:17 javier Martin wrote: Hi, our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor attached to the CSI interface. Apparently, this sensor

Re: Improving ov7670 sensor driver.

2012-09-13 Thread javier Martin
On 13 September 2012 13:00, Hans Verkuil hverk...@xs4all.nl wrote: On Thu 13 September 2012 12:47:53 javier Martin wrote: Hi Hans, thank you for your response. On 13 September 2012 12:07, Hans Verkuil hverk...@xs4all.nl wrote: On Thu 13 September 2012 11:48:17 javier Martin wrote: Hi

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

2012-09-13 Thread javier Martin
Hi Philipp, On 13 September 2012 13:24, Philipp Zabel p.za...@pengutronix.de wrote: Am Donnerstag, den 13.09.2012, 09:51 +0200 schrieb javier Martin: If you want to speed up the process and you have you could send a pull request to Mauro. Should I include the four patches below in the pull

Re: Improving ov7670 sensor driver.

2012-09-14 Thread javier Martin
13-09-2012 06:48, javier Martin escreveu: Hi, our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor attached to the CSI interface. Apparently, this sensor is fully compatible with the old ov7670. For this reason, it seems rather sensible that they should share the same driver

Alignment problems: arm_memblock_steal() + dma_declare_coherent_memory()

2012-09-14 Thread javier Martin
requirements. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-17 Thread javier Martin
+0x94/0x16c) from [c03c42f4] (kernel_init+0xe0/0x1ac) [c03c42f4] (kernel_init+0xe0/0x1ac) from [c0014900] (kernel_thread_exit+0x0/0x8) Code: bad PC value ---[ end trace 7f259a1ce2e10b1a ]--- Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b -- Javier Martin Vista Silicon S.L

Re: [PATCH 26/34] media: mx2_camera: remove dead code in mx2_camera_add_device

2012-09-17 Thread javier Martin
Acked-by: Javier Martin javier.mar...@vista-silicon.com Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Thanks Guennadi --- drivers/media/video/mx2_camera.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-17 Thread javier Martin
, }, + .id_table = mx2_camera_devtype, .remove = __devexit_p(mx2_camera_remove), }; -- 1.7.9.5 I can't test this patch because it depends heavily on the previous one, which breaks the driver. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-18 Thread javier Martin
Hi Shawn, On 18 September 2012 09:43, Shawn Guo shawn@linaro.org wrote: On Mon, Sep 17, 2012 at 03:36:07PM +0200, javier Martin wrote: This patch breaks the driver: Javier, Can you please apply the following change to see if it fixes the problem? Shawn @@ -1783,6 +1783,8 @@ static

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-18 Thread javier Martin
On 17 September 2012 15:59, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 17 Sep 2012, javier Martin wrote: Hi Shawn, On 17 September 2012 11:21, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 17 Sep 2012, Shawn Guo wrote: It changes the driver to use

Re: [GIT PULL v2] Initial i.MX5/CODA7 support for the CODA driver

2012-09-20 Thread javier Martin
: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/53627 The pull request is a way to tell Mauro this is ready to be merged in his linux-media tree and making things easier for him. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los

Re: [GIT PULL v2] Initial i.MX5/CODA7 support for the CODA driver

2012-09-20 Thread javier Martin
On 20 September 2012 10:03, Richard Zhao richard.z...@freescale.com wrote: On Thu, Sep 20, 2012 at 09:10:46AM +0200, javier Martin wrote: Hi Richard, On 20 September 2012 05:32, Richard Zhao richard.z...@freescale.com wrote: why is it a request-pull? After 5 version of Philipp's patches we

[PATCH 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-09-26 Thread Javier Martin
The following series includes all the changes discussed in [1] that don't affect either bridge drivers that use ov7670 or soc-camera framework For this reason they are considered non controversial and sent separately. At least 1 more series will follow in order to implement all features described

[PATCH 1/5] media: ov7670: add support for ov7675.

2012-09-26 Thread Javier Martin
ov7675 and ov7670 share the same registers but there is no way to distinguish them at runtime. However, they require different tweaks to achieve the desired resolution. For this reason this patch adds a new ov7675 entry to the ov7670_id table. Signed-off-by: Javier Martin javier.mar...@vista

[PATCH 2/5] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'.

2012-09-26 Thread Javier Martin
'min_height' and 'min_width' are variables that allow to specify the minimum resolution that the sensor will achieve. This patch make v4l2 fmt callbacks consider this parameters in order to return valid data to user space. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers

[PATCH 4/5] media: ov7670: add possibility to bypass pll for ov7675.

2012-09-26 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/i2c/ov7670.c | 24 ++-- include/media/ov7670.h |1 + 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 175fbfc

[PATCH 3/5] media: ov7670: calculate framerate properly for ov7675.

2012-09-26 Thread Javier Martin
will be used for ov7675 only. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/i2c/ov7670.c | 122 ++-- 1 file changed, 105 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c

[PATCH 5/5] media: ov7670: Add possibility to disable pixclk during hblank.

2012-09-26 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/i2c/ov7670.c |8 include/media/ov7670.h |1 + 2 files changed, 9 insertions(+) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 54fb535..f7e4341 100644 --- a/drivers

Re: [PATCH 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-09-26 Thread javier Martin
On 26 September 2012 11:47, Javier Martin javier.mar...@vista-silicon.com wrote: The following series includes all the changes discussed in [1] that don't affect either bridge drivers that use ov7670 or soc-camera framework For this reason they are considered non controversial and sent

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-09-27 Thread javier Martin
Hi Jonathan, thank you for your time. On 26 September 2012 18:40, Jonathan Corbet cor...@lwn.net wrote: This is going to have to be quick, sorry... On Wed, 26 Sep 2012 11:47:53 +0200 Javier Martin javier.mar...@vista-silicon.com wrote: +static struct ov7670_win_size ov7670_win_sizes[2][4

<    1   2   3   4   5   >