Re: Microsoft VX-1000 Microphone Drivers Crash in x86_64
On Sat, 10 Jul 2010 22:30:58 -0400 Kyle Baker kyleaba...@gmail.com wrote: Is this change from 0x40 to 0x44 intended to fix the bad interface messages as well as the mic becoming disabled? Also, is a reboot after installing these drivers and changes required? I'm only curious because it takes so much longer to test changes. The change from 0x40 to 0x44 is applied to the GPIO register of the SN9C105 which is the bridge of the webcam. I was thinking that some values of this register could break the audio input. It does not seem so. The bad interface messages are printed when the audio interfaces are called by HAL for probe by the video driver. This is not an error. I will remove this message in the next version. Rebooting after installing a new version of a module is not needed. The module may be removed from memory by 'rmmod'. In your case, when updating sonixj, you just need to unplug the webcam, do rmmod gspca_sonixj and replug the webcam. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Microsoft VX-1000 Microphone Drivers Crash in x86_64
On Sun, 11 Jul 2010 17:18:53 -0400 Kyle Baker kyleaba...@gmail.com wrote: Is the previous maintainer, Michel Xhaard, still working on this driver at all? I wonder if he might be able to help identify the problem or narrow it down. Which function is called when I open Cheese or other video applications? Initializing the webcam appears to be correct, however, sd_start() or the one that starts the video capture appears to be toggling or changing some setting. If I knew of a way, I would insert more debug messages to help pinpoint the place where the microphone breaks along with some boolean to show that its working or not. Hi, Michel Xhaard gave me all the gspca stuff and stopped working on it two years ago. He did not even tell me which of his webcams were working with gspca v2... The video capture is started in sd_start(). Checking all sequences again, I found that the GPIO is also set near line 1752. May you comment it and test? msleep(100); // reg_w1(gspca_dev, 0x02, 0x62); break; Otherwise, here is a way to know the exact bad USB exchange. First, in sonixj.c, add a long delay in the register write functions just before the debug messages: - line 1350 msleep(1000); // add this PDEBUG(D_USBO, reg_w1 [%04x] = %02x, value, data); - line 1365 msleep(1000); // add this PDEBUG(D_USBO, reg_w [%04x] = %02x %02x .., value, buffer[0], buffer[1]); After installation, connect the webcam and set the gspca debug level to 0xcf: echo 0xcf /sys/module/gspca_main/parameters/debug Check if the webcam microphone is working, and look at the kernel messages by: tail -f /var/log/messages Then, start the video capture. You should see each USB exchange in the 'tail' window. When the audio stops, the bad exchange is the one just printed... If the audio stopped before any exchange, this could mean that something went wrong when setting the alternate setting or on URB creation. BTW, your webcam is connected to a USB 1.1 port with the driver ohci_hcd. Have you some USB 2.0 port that you could use? Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Microsoft VX-1000 Microphone Drivers Crash in x86_64
On Mon, 12 Jul 2010 05:28:15 -0400 Kyle Baker kyleaba...@gmail.com wrote: Here is the exchange from plugging in my webcam until I quit Cheese. The point that the mic quits is at [ 224.692515] sonixj-2.9.51: reg_w1 [0002] = 62 as far as I can tell. I hope this sheds some light on the issue. Repeating this several times appears to show the same values each time, so it may be a GPIO setting that is incorrect. I don't understand the driver code as intricately as you. Fine job! The register 02 is the GPIO register. It seems the audio does not work when the bit 0x04 is not set. I am working on the driver for the other webcams, but you may patch it yourself removing the register 02 settings at lines 1752, 2320 and 2321 of sonixj.c. Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Microsoft VX-1000 Microphone Drivers Crash in x86_64
On Mon, 12 Jul 2010 19:01:51 -0400 Kyle Baker kyleaba...@gmail.com wrote: These do fix the audio problem, but they may not be good for other Sensor OV7660 devices. I am not sure how to identify only my model here, but that may be ideal for a better patch. I wonder if this patch would also be needed for the VX-3000 model? Hi Kyle, Thanks for the patch, but it is more complex. In fact, only the bridge sn9c105 may do audio stream and the sensor ov7660 is used with other bridges (the VX3000 is the same as the VX1000 and contains the sn9c105 and the ov7660). In the new gspca test version (2.9.52), I modified the driver for it checks the audio device. If present, the bandwidth is reduced and for the sn9c105, the bit 0x04 of the GPIO register is always set (I hope that the audio connection is done in the same way by all manufacturer!). May you check it? Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.36] gspca for_2.6.36
The following changes since commit a41ae2431a3d1c751bda1ef0e9b44b27192e19de: V4L/DVB: gspca - sq930x: Add some comments for sensor mt9v111 (2010-07-10 14:14:45 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.36 Jean-François Moine (6): gspca - main: Fix a compilation warning. gspca - main: Remove useless audio ioctl's. gspca - main: Adjust and remove some debug messages. gspca - main: Handle the audio device. gspca - sonixj: Do the audio input work for webcams with a microphone. gspca - vc032x: Move the first VC0321 settings to sd_init(). drivers/media/video/gspca/gspca.c | 66 +++- drivers/media/video/gspca/gspca.h |3 +- drivers/media/video/gspca/sonixj.c | 37 ++- drivers/media/video/gspca/vc032x.c | 25 ++--- 4 files changed, 53 insertions(+), 78 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.36] gspca for_2.6.36
The following changes since commit 906903f4c56f8dd74584a44d93d96df25d228786: V4L/DVB: gspca - vc032x: Move the first VC0321 settings to sd_init() (2010-07-25 17:16:25 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.36 Jean-François Moine (14): gspca - sonixj / sq930x / t613: Remove unused variable in struct sd. gspca - main: Version change. gspca - sq930x: Bad init sequence for sensor mt9v111. gspca - sq930x: Change the gain value for Micron sensors. gspca - sq930x: Change the default values of gain and exposure. gspca - sq930x: Change image format to Bayer mode. gspca - sq930x: Change the horizontal blanking of sensor mt9v111. gspca - sq930x: Cleanup source, add comments.. gspca - vc032x: Add more controls for po. gspca - vc032x: Do sensor probe at resume time. gspca - zc3xx: Cleanup source. gspca - zc3xx: Check the USB exchanges. gspca - vc032x: Force main register write at probe time (po). gspca - main: Fix a crash in gspca_frame_add(). drivers/media/video/gspca/gspca.c | 21 +- drivers/media/video/gspca/sonixj.c | 10 +- drivers/media/video/gspca/sq930x.c | 347 +- drivers/media/video/gspca/t613.c |4 +- drivers/media/video/gspca/vc032x.c | 360 ++ drivers/media/video/gspca/zc3xx.c | 592 +++- 6 files changed, 711 insertions(+), 623 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gspca_zc3xx module
On Thu, 29 Jul 2010 12:21:21 + Hasan SAHIN hasan.sa...@gmx.com wrote: Hello Jean-Francois, I am using Gentoo linux stable x86 with kernel 2.6.34-r1. before the kernel update to 2.6.34-r1, I was using 2.6.32-r7 and there was no problem with webcam. The webcam was working as good with kernel 2.6.32-r7(old gentoo stable kernel) but right now it does not work with the kernel 2.6.34-r1 (new gentoo stable kernel) And also I have tried with ubuntu 10.04 (kernel 2.6.32-25) and working good. I could not understood what is the problem. (Problem is : there is no output, no stream) [snip] gspca: probing 0ac8:303b zc3xx: probe 2wr ov vga 0x zc3xx: probe 3wr vga 1 0xc001 zc3xx: probe sensor - 0013 zc3xx: Find Sensor MI0360SOC. Chip revision c001 [snip] Hello Hasan, In the kernel 2.6.34, the sensor mi0360soc sequences have been changed to make the webcams 0ac8:301b work, but these sequences are wrong for the webcams 0ac8:303b. An other user is testing the fix which is in my test tarball (see my home page below - current version 2.10.4). There is just one remaining problem: the image is mirrored, and I have not found yet how to set it normal... Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Not able to capture video frames
On Thu, 5 Aug 2010 11:34:28 +0530 Sudhindra Nayak sudhindra.na...@gmail.com wrote: As you requested, I'm including the lsusb output below: Hi Sudhindra, The USB information indicate that the webcam uses uses isochronous transfer. The driver ov534 you used as a base uses bulk transfer. So, you must either remove the 'cam-bulk..' in sd_conf() or change your base driver to ov519. In any case, don't forget to adjust the pkt_scan function... Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Not able to capture video frames
On Tue, 17 Aug 2010 17:50:58 +0530 Sudhindra Nayak sudhindra.na...@gmail.com wrote: As you suggested I removed the 'cam-bulk' part in the sd_config function. Also, can you please explain how you arrived at the sd_pkt_scan function? I'm not able to understand the bit manipulations that you have performed in the sd_pkt_scan function. Also, you did mention that the sd_pkt_scan function needs to be modified. Can you please elaborate on the changes that need to be done to the sd_pkt_scan function? As I'd mentioned earlier, I'm using the 'ov534.c' code with the ov538 bridge processor. Will there be any change in the sd_pkt_scan function with respect to ov538? [snip] functions and then enters the mainloop() function. In the mainloop() function, the select() function call times out after 2 seconds and I'm not able to capture any video frames. Any suggestions?? Hi Sudhindra, The ov534 sends images in UVC format, i.e. each packet contains a 12 bytes header and a part of the image. In the header, the 1st byte contains various indicators, of which the bit 1 (0x02) marks the end of the image. To code your sd_pkt_scan(), you have to search in the ms-windows traces how the images are fragmented, how you may find the start and end of image and whether some data have to be discarded in the packets. The last problem to solve is to find how are encoded the images. You may know it looking also in the ms-winsows traces or, when the driver will work, in the received images. If you want, I may send you a small program which displays raw images (done by 'svv -rg') forcing the encoding. Good luck! -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: HG has errors on kernel 2.6.32
On Thu, 26 Aug 2010 21:54:10 +0200 Jan Hoogenraad jan-conceptro...@hoogenraad.net wrote: and change static void jpeg_set_qual(u8 *jpeg_hdr, into static __attribute__ (( unused )) void jpeg_set_qual(u8 *jpeg_hdr, at line 152 of linux/drivers/media/video/gspca/jpeg.h Hi, This warning occured while compiling the gspca subdriver sq930x. It has been fixed (as a critical gspca crash) in the last gspca changes which are in git://linuxtv.org/media_tree.git, branch staging/v2.6.36. BTW, Mauro, is it possible to put them in the kernel 2.6.36? Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gspca_cpia1: Add lamp control for Intel Play QX3 microscope
On Thu, 02 Sep 2010 21:09:42 -0400 Andy Walls awa...@md.metrocast.net wrote: [snip] Add a v4l2 control to get the lamp control code working for the Intel Play QX3 microscope. My daughter in middle school thought it was cool, and is now examining the grossest specimens she can find. [snip] - u8 toplight;/* top light lit , R/W */ - u8 bottomlight; /* bottom light lit, R/W */ + u8 toplamp; /* top lamp lit , R/W */ + u8 bottomlamp; /* bottom lamp lit, R/W */ [snip] +#define V4L2_CID_LAMPS (V4L2_CID_PRIVATE_BASE+1) [snip] Hi Andy, First, I do not see why you changed the name 'light' to 'lamp' while 'light' is used in the other cpia driver (cpia2). Then, you used a private control ID, and linux-media people don't like that. As many gspca users are waiting for a light/LED/illuminator/lamp control, I tried to define a standard one in March 2009: http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/3095 A second, but more restrictive, attempt was done by Németh Márton in February 2010: http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/16705 The main objection to that proposals was that the sysfs LED interface should be used instead: http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/3114 A patch in this way was done by Németh Márton in February 2010: http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/16670 but it was rather complex, and there was no consensus http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/17111 So, I don't think that your patch could be accepted... Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.36] gspca for_2.6.36
The following changes since commit 67ac062a5138ed446a821051fddd798a01478f85: V4L/DVB: Fix regression for BeholdTV Columbus (2010-08-24 10:39:32 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.36 Jason Wang (1): gspca - main: Fix a crash of some webcams on ARM arch. drivers/media/video/gspca/gspca.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] LED control
Some media devices may have one or many lights (LEDs, illuminators,
lamps..). This patch makes them controlable by the applications.
Signed-off-by: Jean-Francois Moine moin...@free.fr
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
diff --git a/Documentation/DocBook/v4l/controls.xml b/Documentation/DocBook/v4l/controls.xml
index 8408caa..c9b8ca5 100644
--- a/Documentation/DocBook/v4l/controls.xml
+++ b/Documentation/DocBook/v4l/controls.xml
@@ -312,6 +312,13 @@ minimum value disables backlight compensation./entry
information and bits 24-31 must be zero./entry
/row
row
+ entryconstantV4L2_CID_LEDS/constant/entry
+ entryinteger/entry
+ entrySwitch on or off the LED(s) or illuminator(s) of the device.
+ The control type and values depend on the driver and may be either
+ a single boolean (0: off, 1:on) or the index in a menu type./entry
+ /row
+ row
entryconstantV4L2_CID_LASTP1/constant/entry
entry/entry
entryEnd of the predefined control IDs (currently
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 61490c6..3807492 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -1045,8 +1045,10 @@ enum v4l2_colorfx {
#define V4L2_CID_CHROMA_GAIN(V4L2_CID_BASE+36)
+#define V4L2_CID_LEDS(V4L2_CID_BASE+37)
+
/* last CID + 1 */
-#define V4L2_CID_LASTP1 (V4L2_CID_BASE+37)
+#define V4L2_CID_LASTP1 (V4L2_CID_BASE+38)
/* MPEG-class control IDs defined by V4L2 */
#define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)
Re: [PATCH] LED control
On Sun, 05 Sep 2010 09:56:54 +0200 Hans de Goede hdego...@redhat.com wrote: I think that using one control for both status leds (which is what we are usually talking about) and illuminator(s) is a bad idea. I'm fine with standardizing these, but can we please have 2 CID's one for status lights and one for the led. Esp, as I can easily see us supporting a microscope in the future where the microscope itself or other devices with the same bridge will have a status led, so then we will need 2 separate controls anyways. Hi Hans, I was not thinking about the status light (I do not see any other usage for it), but well about illuminators which I saw only in microscopes. So, which is the better name? V4L2_CID_LAMPS? V4L2_CID_ILLUMINATORS? Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [git:v4l-dvb/v2.6.37] V4L/DVB: gspca - main: Fix a crash of some webcams on ARM arch
On Mon, 06 Sep 2010 17:57:25 +0200 Mauro Carvalho Chehab mche...@redhat.com wrote: Subject: V4L/DVB: gspca - main: Fix a crash of some webcams on ARM arch Author: Jason Wang jason77.w...@gmail.com Date:Fri Sep 3 06:57:19 2010 -0300 Hi Mauro, You put this important fix in staging/2.6.37. Cannot it go to 2.6.36? Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Illuminators and status LED controls
Hi,
This new proposal cancels the previous 'LED control' patch.
Cheers.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
Some media devices (microscopes) may have one or many illuminators,
and most webcams have a status LED which is normally on when capture is active.
This patch makes them controlable by the applications.
Signed-off-by: Jean-Francois Moine moin...@free.fr
diff --git a/Documentation/DocBook/v4l/controls.xml b/Documentation/DocBook/v4l/controls.xml
index 8408caa..77f87ad 100644
--- a/Documentation/DocBook/v4l/controls.xml
+++ b/Documentation/DocBook/v4l/controls.xml
@@ -312,10 +312,27 @@ minimum value disables backlight compensation./entry
information and bits 24-31 must be zero./entry
/row
row
+ entryconstantV4L2_CID_ILLUMINATORS/constant/entry
+ entryinteger/entry
+ entrySwitch on or off the illuminator(s) of the device
+ (usually a microscope).
+ The control type and values depend on the driver and may be either
+ a single boolean (0: off, 1:on) or defined by a menu type./entry
+ /row
+ row id=v4l2_status_led
+ entryconstantV4L2_CID_STATUS_LED/constant/entry
+ entryinteger/entry
+ entrySet the status LED behaviour. Possible values for
+constantenum v4l2_status_led/constant are:
+constantV4L2_STATUS_LED_AUTO/constant (0),
+constantV4L2_STATUS_LED_ON/constant (1),
+constantV4L2_STATUS_LED_OFF/constant (2)./entry
+ /row
+ row
entryconstantV4L2_CID_LASTP1/constant/entry
entry/entry
entryEnd of the predefined control IDs (currently
-constantV4L2_CID_BG_COLOR/constant + 1)./entry
+constantV4L2_CID_STATUS_LED/constant + 1)./entry
/row
row
entryconstantV4L2_CID_PRIVATE_BASE/constant/entry
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 61490c6..75e8869 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -1045,8 +1045,16 @@ enum v4l2_colorfx {
#define V4L2_CID_CHROMA_GAIN(V4L2_CID_BASE+36)
+#define V4L2_CID_ILLUMINATORS (V4L2_CID_BASE+37)
+#define V4L2_CID_STATUS_LED (V4L2_CID_BASE+38)
+enum v4l2_status_led {
+ V4L2_STATUS_LED_AUTO = 0,
+ V4L2_STATUS_LED_ON = 1,
+ V4L2_STATUS_LED_OFF = 2,
+};
+
/* last CID + 1 */
-#define V4L2_CID_LASTP1 (V4L2_CID_BASE+37)
+#define V4L2_CID_LASTP1 (V4L2_CID_BASE+39)
/* MPEG-class control IDs defined by V4L2 */
#define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)
Re: [PATCH] Illuminators and status LED controls
On Tue, 7 Sep 2010 17:30:33 +0200
Hans Verkuil hverk...@xs4all.nl wrote:
enum v4l2_illuminator {
V4L2_ILLUMINATOR_OFF = 0,
V4L2_ILLUMINATOR_ON = 1,
};
#define V4L2_CID_ILLUMINATOR_0 (V4L2_CID_BASE+37)
#define V4L2_CID_ILLUMINATOR_1 (V4L2_CID_BASE+38)
enum v4l2_led {
V4L2_LED_AUTO = 0,
V4L2_LED_OFF = 1,
V4L2_LED_ON = 2,
};
#define V4L2_CID_LED_0 (V4L2_CID_BASE+39)
Simple and straightforward.
Hi,
Hans (de Goede), is this OK for you? I think that if we find more
illuminators or LEDs on some devices, we may add more V4L2_CID_xxx_n
controls.
Hans (Verkuil), may we have the same enum's for both light types?
Something like:
enum v4l2_light {
V4L2_LIGHT_OFF = 0,
V4L2_LIGHT_ON = 1,
V4L2_LIGHT_AUTO = 2,
V4L2_LIGHT_BLINK = 3,
};
Regards.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Illuminators and status LED controls
On Wed, 08 Sep 2010 20:58:18 +0200 Peter Korsgaard jac...@sunsite.dk wrote: Andy == Andy Walls awa...@md.metrocast.net writes: Andy Incandescent and Halogen lamps that effect an image coming Andy into a camera are *not* LEDs that blink or flash automatically Andy based on driver or system trigger events. They are components Andy of a video capture system with which a human attempts to Andy adjust the appearance of an image of a subject by changing the Andy subject's environment. These illuminators are not some Andy generically connected device, but controlled by GPIO's on the Andy camera's bridge or sensor chip itself. Such an illuminator Andy will essentially be used only in conjunction with the camera. Agreed. Andy Status LEDs integrated into webcam devices that are not Andy generically connected devices but controlled with GPIOs on the Andy camera's bridge or sensor chip will also essentially be used Andy only in conjunction with the camera. Or for any other usage the user envision - E.G. I could imagine using the status led of the webcam in my macbook for hard disk or wifi activity. I'm sure other people can come up with more creative use cases as well. Andy Turning these sorts camera specific illuminators and LEDs on Andy an off should be as simple to implement for an application Andy developer as it is to grasp the concept of turning a light Andy bulb on and off. The point is that the logic rarely needs to be in the v4l applications. The status LEDs should by default go on when the v4l device is active and go off again when not like it used to do. A v4l application developer would normally not want to worry about such things, and only care about the video data. But if a user wants something special / non-standard, then it's just a matter of changing LED trigger in /sys/class/leds/.. [snip] Again, for status LEDs I don't see any reason why a standard v4l tool would care. As I mentioned above, illuminators are a different story (comparable to a gain setting imho). [snip] Again, I see the sysfs LED interface for status LEDs as more of a user/administrator interface than a programming API. Hi, If I may resume this exchange: - the (microscope or device dependant) illuminators may be controlled by v4l2, - the status LED should be controlled by the LED interface. Does everybody agree? Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Illuminators control
Hi, This new proposal cancels the previous patch 'Illuminators and status LED controls'. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ illuminator.pat Description: Binary data
[PATCH] Illuminators control
Hi, This new proposal cancels the previous patch 'Illuminators control'. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ illuminator.pat Description: Binary data
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
The following changes since commit 991403c594f666a2ed46297c592c60c3b9f4e1e2: V4L/DVB: cx231xx: Avoid an OOPS when card is unknown (card=0) (2010-09-11 11:58:01 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Alexander Goncharov (1): gspca - sonixj: Add webcam 0c45:612b Andy Walls (3): gspca_cpia1: Add basic v4l2 illuminator controls for the Intel Play QX3 gspca_cpia1: Restore QX3 illuminators' state on resume gspca_cpia1: Disable illuminator controls if not an Intel Play QX3 Jean-François Moine (9): gspca - all modules: Remove useless module load/unload messages. gspca - all modules: Display error messages when gspca debug disabled. gspca - sn9c20x: Bad transfer size of Bayer images. gspca - sn9c20x: Fix the number of bytes per line. gspca - sn9c20x: Better image sizes. gspca - main: New video control mechanism. gspca - stk014: Use the new video control mechanism. gspca - sonixj: Webcam 0c45:6102 added. v4l2: Add illuminator controls. Documentation/DocBook/v4l/controls.xml |9 +- Documentation/video4linux/gspca.txt|2 + drivers/media/video/gspca/conex.c |8 +- drivers/media/video/gspca/cpia1.c | 127 +-- drivers/media/video/gspca/etoms.c |8 +- drivers/media/video/gspca/finepix.c| 15 +-- drivers/media/video/gspca/gl860/gl860.c|6 +- drivers/media/video/gspca/gspca.c | 118 +- drivers/media/video/gspca/gspca.h | 12 ++- drivers/media/video/gspca/jeilinj.c| 15 +-- drivers/media/video/gspca/konica.c | 19 +-- drivers/media/video/gspca/m5602/m5602_core.c |8 +- drivers/media/video/gspca/mars.c | 11 +- drivers/media/video/gspca/mr97310a.c | 29 +-- drivers/media/video/gspca/ov519.c | 51 +++ drivers/media/video/gspca/ov534.c | 19 +-- drivers/media/video/gspca/ov534_9.c| 19 +-- drivers/media/video/gspca/pac207.c | 16 +-- drivers/media/video/gspca/pac7302.c| 25 +-- drivers/media/video/gspca/pac7311.c| 25 +-- drivers/media/video/gspca/sn9c2028.c | 19 +-- drivers/media/video/gspca/sn9c20x.c| 49 +++--- drivers/media/video/gspca/sonixb.c |8 +- drivers/media/video/gspca/sonixj.c | 15 +- drivers/media/video/gspca/spca1528.c | 15 +-- drivers/media/video/gspca/spca500.c| 14 +- drivers/media/video/gspca/spca501.c| 10 +- drivers/media/video/gspca/spca505.c| 14 +-- drivers/media/video/gspca/spca508.c| 13 +- drivers/media/video/gspca/spca561.c| 10 +- drivers/media/video/gspca/sq905.c | 21 +-- drivers/media/video/gspca/sq905c.c | 15 +-- drivers/media/video/gspca/sq930x.c | 23 +-- drivers/media/video/gspca/stk014.c | 176 +-- drivers/media/video/gspca/stv0680.c| 13 +- drivers/media/video/gspca/stv06xx/stv06xx.c| 10 +- drivers/media/video/gspca/stv06xx/stv06xx_st6422.c |2 +- drivers/media/video/gspca/sunplus.c| 18 +-- drivers/media/video/gspca/t613.c | 10 +- drivers/media/video/gspca/tv8532.c |8 +- drivers/media/video/gspca/vc032x.c | 19 +-- drivers/media/video/gspca/w996Xcf.c|6 +- drivers/media/video/gspca/xirlink_cit.c| 17 +-- drivers/media/video/gspca/zc3xx.c | 17 +-- drivers/media/video/sn9c102/sn9c102_devtable.h |2 + drivers/media/video/v4l2-ctrls.c |4 + include/linux/videodev2.h |5 +- 47 files changed, 458 insertions(+), 617 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
Hi Mauro, This new patch request cancels the previous one. I removed two changes which were not mature. The following changes since commit 991403c594f666a2ed46297c592c60c3b9f4e1e2: V4L/DVB: cx231xx: Avoid an OOPS when card is unknown (card=0) (2010-09-11 11:58:01 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Alexander Goncharov (1): gspca - sonixj: Add webcam 0c45:612b Andy Walls (3): gspca_cpia1: Add basic v4l2 illuminator controls for the Intel Play QX3 gspca_cpia1: Restore QX3 illuminators' state on resume gspca_cpia1: Disable illuminator controls if not an Intel Play QX3 Jean-François Moine (7): gspca - all modules: Remove useless module load/unload messages. gspca - all modules: Display error messages when gspca debug disabled. gspca - sn9c20x: Bad transfer size of Bayer images. gspca - sn9c20x: Fix the number of bytes per line. gspca - sn9c20x: Better image sizes. gspca - sonixj: Webcam 0c45:6102 added. v4l2: Add illuminator controls. Documentation/DocBook/v4l/controls.xml |9 ++- Documentation/video4linux/gspca.txt|2 + drivers/media/video/gspca/conex.c |8 +- drivers/media/video/gspca/cpia1.c | 127 ++-- drivers/media/video/gspca/etoms.c |8 +- drivers/media/video/gspca/finepix.c| 15 +-- drivers/media/video/gspca/gl860/gl860.c|6 +- drivers/media/video/gspca/gspca.c | 23 ++-- drivers/media/video/gspca/jeilinj.c| 15 +-- drivers/media/video/gspca/konica.c | 19 +-- drivers/media/video/gspca/m5602/m5602_core.c |8 +- drivers/media/video/gspca/mars.c | 11 +-- drivers/media/video/gspca/mr97310a.c | 29 ++--- drivers/media/video/gspca/ov519.c | 51 - drivers/media/video/gspca/ov534.c | 19 +-- drivers/media/video/gspca/ov534_9.c| 19 +-- drivers/media/video/gspca/pac207.c | 16 +-- drivers/media/video/gspca/pac7302.c| 25 ++--- drivers/media/video/gspca/pac7311.c| 25 ++--- drivers/media/video/gspca/sn9c2028.c | 19 +-- drivers/media/video/gspca/sn9c20x.c| 49 - drivers/media/video/gspca/sonixb.c |8 +- drivers/media/video/gspca/sonixj.c | 15 +-- drivers/media/video/gspca/spca1528.c | 15 +-- drivers/media/video/gspca/spca500.c| 14 +-- drivers/media/video/gspca/spca501.c| 10 +-- drivers/media/video/gspca/spca505.c| 14 +-- drivers/media/video/gspca/spca508.c| 13 +-- drivers/media/video/gspca/spca561.c| 10 +-- drivers/media/video/gspca/sq905.c | 21 +-- drivers/media/video/gspca/sq905c.c | 15 +-- drivers/media/video/gspca/sq930x.c | 23 ++--- drivers/media/video/gspca/stk014.c | 20 +-- drivers/media/video/gspca/stv0680.c| 13 +-- drivers/media/video/gspca/stv06xx/stv06xx.c| 10 +-- drivers/media/video/gspca/stv06xx/stv06xx_st6422.c |2 +- drivers/media/video/gspca/sunplus.c| 18 +-- drivers/media/video/gspca/t613.c | 10 +-- drivers/media/video/gspca/tv8532.c |8 +- drivers/media/video/gspca/vc032x.c | 19 +-- drivers/media/video/gspca/w996Xcf.c|6 +- drivers/media/video/gspca/xirlink_cit.c| 17 +-- drivers/media/video/gspca/zc3xx.c | 17 +-- drivers/media/video/sn9c102/sn9c102_devtable.h |2 + drivers/media/video/v4l2-ctrls.c |4 + include/linux/videodev2.h |5 +- 46 files changed, 340 insertions(+), 472 deletions(-) Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
The following changes since commit dace3857de7a16b83ae7d4e13c94de8e4b267d2a: V4L/DVB: tvaudio: remove obsolete tda8425 initialization (2010-09-24 19:20:20 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Jean-François Moine (6): gspca - benq: Display error messages when gspca debug disabled. gspca - benq: Remove useless module load/unload messages. gspca - cpia1: Fix compilation warning when gspca debug disabled. gspca - many subdrivers: Handle INPUT as a module. gspca - spca505: Remove the eeprom write commands of NxUltra. gspca - sonixj: Propagate USB errors to higher level. drivers/media/video/gspca/benq.c| 20 ++ drivers/media/video/gspca/cpia1.c |2 + drivers/media/video/gspca/konica.c |8 ++- drivers/media/video/gspca/ov519.c |6 +- drivers/media/video/gspca/pac207.c |6 +- drivers/media/video/gspca/pac7302.c |6 +- drivers/media/video/gspca/pac7311.c |6 +- drivers/media/video/gspca/sn9c20x.c |6 +- drivers/media/video/gspca/sonixb.c |6 +- drivers/media/video/gspca/sonixj.c | 91 +-- drivers/media/video/gspca/spca505.c |4 - drivers/media/video/gspca/spca561.c |8 ++- drivers/media/video/gspca/stv06xx/stv06xx.c |6 +- drivers/media/video/gspca/zc3xx.c |6 +- 14 files changed, 119 insertions(+), 62 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
The following changes since commit 1a45fd8d5ec39af5c00bec6094a606ccfc7957d5: V4L/DVB: tda18271: Add some hint about what tda18217 reg ID returned (2010-09-30 22:47:20 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Jean-François Moine (5): gspca - many subdrivers: Handle the buttons when CONFIG_INPUT=m. gspca - mr97310a: Declare static the constant tables. gspca - sonixj: Add sensor mi0360b. gspca - sonixj: Bad detection of the end of image. gspca - sonixj: Have 0c45:6130 handled by sonixj instead of sn9c102. drivers/media/video/gspca/konica.c |6 +- drivers/media/video/gspca/mr97310a.c | 23 ++-- drivers/media/video/gspca/ov519.c |4 +- drivers/media/video/gspca/pac207.c |4 +- drivers/media/video/gspca/pac7302.c|4 +- drivers/media/video/gspca/pac7311.c|4 +- drivers/media/video/gspca/sn9c20x.c|6 +- drivers/media/video/gspca/sonixb.c |4 +- drivers/media/video/gspca/sonixj.c | 180 drivers/media/video/gspca/spca561.c|6 +- drivers/media/video/gspca/stv06xx/stv06xx.c|4 +- drivers/media/video/gspca/zc3xx.c |6 +- drivers/media/video/sn9c102/sn9c102_devtable.h |2 + 13 files changed, 187 insertions(+), 66 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
The following changes since commit c8dd732fd119ce6d562d5fa82a10bbe75a376575: V4L/DVB: gspca - sonixj: Have 0c45:6130 handled by sonixj instead of sn9c102 (2010-10-01 18:14:35 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Jean-François Moine (4): gspca - main: New video control mechanism. gspca - stk014: Use the new video control mechanism. gspca - ov519: Use the new video control mechanism. gspca - sonixj: Use the new video control mechanism. drivers/media/video/gspca/gspca.c | 131 ++-- drivers/media/video/gspca/gspca.h | 12 +- drivers/media/video/gspca/ov519.c | 316 +--- drivers/media/video/gspca/sonixj.c | 583 ++ drivers/media/video/gspca/stk014.c | 154 +++--- drivers/media/video/gspca/w996Xcf.c |2 +- 6 files changed, 395 insertions(+), 803 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gspca, audio and ov534: regression.
On Wed, 6 Oct 2010 12:33:21 +0200 Antonio Ospite osp...@studenti.unina.it wrote: with 2.6.36-rc6 I can't use the ov534 gspca subdriver (with PS3 eye) anymore, when I try to capture video in dmesg I get: gspca: no transfer endpoint found If I revert commit 35680ba I can make video capture work again but I still don't get the audio device in pulseaudio, it shows up in alsamixer but if I try to select it, on the console I get: cannot load mixer controls: Invalid argument I'll test with latest Jean-François tree, and if it still fails I'll try to find a solution, but I wanted to report it quickly first, I hope we fix this before 2.6.36. Hi Antonio, I think I see why the commit prevents the webcam to work: as it is done, the choice of the alternate setting does not work with bulk transfer. A simple fix could be to also check bulk transfer when skipping an alt setting in the function get_ep(). About audio stream, I do not see how it can have been broken. Might you send me the full USB information of your webcam? Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gspca, audio and ov534: regression.
On Wed, 6 Oct 2010 16:04:41 +0200
Antonio Ospite osp...@studenti.unina.it wrote:
Thanks, the following change fixes it, was this what you had in mind?
diff --git a/drivers/media/video/gspca/gspca.c
b/drivers/media/video/gspca/gspca.c index b984610..30e0b32 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -651,7 +651,7 @@ static struct usb_host_endpoint *get_ep(struct
gspca_dev *gspca_dev) : USB_ENDPOINT_XFER_ISOC;
i = gspca_dev-alt; /* previous alt
setting */ if (gspca_dev-cam.reverse_alts) {
- if (gspca_dev-audio)
+ if (gspca_dev-audio !gspca_dev-cam.bulk)
i++;
while (++i gspca_dev-nbalt) {
ep = alt_xfer(intf-altsetting[i], xfer);
@@ -659,7 +659,7 @@ static struct usb_host_endpoint *get_ep(struct
gspca_dev *gspca_dev) break;
}
} else {
- if (gspca_dev-audio)
+ if (gspca_dev-audio !gspca_dev-cam.bulk)
i--;
while (--i = 0) {
ep = alt_xfer(intf-altsetting[i], xfer);
Yes, but, after thought, as there is only one alternate setting, the
tests could be:
if (gspca_dev-audio i gspca_dev-nbalt - 1)
and
if (gspca_dev-audio i 0)
This should work also for isochronous transfers.
regards.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gspca, audio and ov534: regression.
On Wed, 6 Oct 2010 16:53:37 +0200 Antonio Ospite osp...@studenti.unina.it wrote: PS3 Eye audio is working with linux-2.6.33.7 it is broken in linux-2.6.35.7 already, I'll try to further narrow down the interval. Ah, alsamixer doesn't work even when the device is OK in pulseaudio... I was wrong, the audio part works even in 2.6.36-rc6 but _only_ when the webcam is plugged in from boot, could this have to do with the order gspca and snd-usb-audio are loaded? Hi Antonio, If you still have a kernel 2.6.33, may you try my test version (tarball in my web page)? As it contain only the gspca stuff, this may tell if the problem is in gspca or elsewhere in the kernel. Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gspca, audio and ov534: regression.
On Sun, 10 Oct 2010 12:02:50 +0200 Antonio Ospite osp...@studenti.unina.it wrote: JF this change as is does not work for me, if I change the second check to if (gspca_dev-audio i 1) it does, but I don't know if this breaks anything else. Hi Antonio, You are right, this is the way the test must be. I'll try to have this in the kernel 2.6.36. Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.36] gspca for_2.6.36
The following changes since commit d65728875a85ac7c8b7d6eb8d51425bacc188980: V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.36 Jean-François Moine (1): gspca - main: Fix a regression with the PS3 Eye webcam drivers/media/video/gspca/gspca.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
The following changes since commit e749edc7e6967f8f92d2c0251c8a3a96524ec327: V4L/DVB: IR: ene_ir: few bugfixes (2010-10-16 00:30:12 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Jean-François Moine (5): gspca - main: Fix a regression with the PS3 Eye webcam gspca - main: Have discontinuous sequence numbers when frames are lost gspca - mars: Use the new video control mechanism. gspca - mars: Propagate USB errors to higher level gspca - mars: Add illuminator controls drivers/media/video/gspca/gspca.c |7 +- drivers/media/video/gspca/mars.c | 316 +++-- 2 files changed, 166 insertions(+), 157 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Old patches sent via the Mailing list
On Sun, 17 Oct 2010 19:20:31 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: == Gspca patches - Waiting Jean-Francois Moine moin...@free.fr review == Jul, 8 2010: video:gspca.c Fix warning: case value '7' not in enumerated type 'enum http://patchwork.kernel.org/patch/110779 Jean-Francois Moine moin...@free.fr Hi Mauro, This patch is already applied. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] gspca_sonixj: handle return values from USB subsystem
On Sun, 17 Oct 2010 16:45:03 +0200 Németh Márton nm...@freemail.hu wrote: The usb_control_msg() may return error at any time so it is necessary to handle it. The error handling mechanism is taken from the pac7302. The resulting driver was tested with hama AC-150 webcam (USB ID 0c45:6142). Hi Németh, This mechanism has already been done by commit 60f44336 in media_tree.git branch staging/v2.6.37. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] gspca_sonixj: add hardware vertical flip support for hama AC-150
On Sun, 17 Oct 2010 13:08:01 +0200 Németh Márton nm...@freemail.hu wrote: The PO2030N sensor chip found in hama AC-150 webcam supports vertical flipping the image by hardware. Add support for this in the gspca_sonixj driver also. [snip] Hi Németh, The driver sonixj has changed in staging/2.6.37. I join a new version of your patches. May you check it? (when acked, I'll keep you as the author of the change) Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ patch.pat Description: Binary data
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
The following changes since commit 350df81ebaccc651fa4dfad27738db958e067ded: Revert changeset d455b639c1fb09f8ea888371fb6e04b490e115fb (2010-10-17 19:32:45 -0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Jean-François Moine (1): gspca: Fix coding style issues Németh Márton (2): gspca - sonixj: Remove magic numbers for delay gspca - sonixj: Add horizontal and vertical flip for po2030n drivers/media/video/gspca/benq.c |3 +- drivers/media/video/gspca/conex.c |6 +- drivers/media/video/gspca/etoms.c |4 +- drivers/media/video/gspca/gl860/gl860-mi2020.c |6 +- drivers/media/video/gspca/gspca.c |2 +- drivers/media/video/gspca/konica.c |4 +- drivers/media/video/gspca/m5602/m5602_mt9m111.c| 48 drivers/media/video/gspca/m5602/m5602_mt9m111.h| 14 +-- drivers/media/video/gspca/m5602/m5602_ov7660.c | 70 +- drivers/media/video/gspca/m5602/m5602_ov7660.h |9 +- drivers/media/video/gspca/m5602/m5602_ov9650.c | 102 drivers/media/video/gspca/m5602/m5602_ov9650.h | 12 +- drivers/media/video/gspca/m5602/m5602_po1030.c | 136 ++-- drivers/media/video/gspca/m5602/m5602_po1030.h | 13 +- drivers/media/video/gspca/m5602/m5602_s5k4aa.c | 28 ++-- drivers/media/video/gspca/m5602/m5602_s5k4aa.h | 14 +-- drivers/media/video/gspca/m5602/m5602_s5k83a.h | 12 +- drivers/media/video/gspca/ov519.c | 18 +-- drivers/media/video/gspca/pac207.c |2 +- drivers/media/video/gspca/pac7302.c|3 +- drivers/media/video/gspca/pac7311.c|3 +- drivers/media/video/gspca/sn9c20x.c| 13 ++- drivers/media/video/gspca/sonixb.c |9 +- drivers/media/video/gspca/sonixj.c | 111 +++- drivers/media/video/gspca/spca501.c|6 +- drivers/media/video/gspca/spca508.c|3 +- drivers/media/video/gspca/stv06xx/stv06xx.h|2 +- drivers/media/video/gspca/stv06xx/stv06xx_hdcs.c | 19 ++-- drivers/media/video/gspca/stv06xx/stv06xx_hdcs.h |2 +- drivers/media/video/gspca/stv06xx/stv06xx_vv6410.c |2 +- drivers/media/video/gspca/stv06xx/stv06xx_vv6410.h |4 +- drivers/media/video/gspca/sunplus.c|9 +- drivers/media/video/gspca/w996Xcf.c|2 +- drivers/media/video/gspca/zc3xx.c | 14 +-- 34 files changed, 359 insertions(+), 346 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.36] gspca for_2.6.36
Hi Mauro, I added two fixes of an other regression. They should go to 2.6.36. The following changes since commit d65728875a85ac7c8b7d6eb8d51425bacc188980: V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call (2010-09-30 07:35:12 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.36 Jean-François Moine (3): gspca - main: Fix a regression with the PS3 Eye webcam gspca - sonixj: Fix a regression of sensors hv7131r and mi0360 gspca - sonixj: Fix a regression with sensor hv7131r drivers/media/video/gspca/gspca.c |4 ++-- drivers/media/video/gspca/sonixj.c |6 ++ 2 files changed, 4 insertions(+), 6 deletions(-) Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.37] gspca for_2.6.37
The following changes since commit 18cb657ca1bafe635f368346a1676fb04c512edf: Merge branch 'stable/xen-pcifront-0.8.2' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen and branch 'for-linus' of git://xenbits.xen.org/people/sstabellini/linux-pvhvm (2010-10-28 17:11:17 -0700) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.37 Jean-François Moine (5): gspca - main: Version change gspca - main: Fix a small code error gspca - zc3xx: Bad clocksetting for mt9v111_3 with 640x480 resolution gspca - sonixj: Simplify and clarify the hv7131r probe function gspca: Convert some uppercase hexadecimal values to lowercase drivers/media/video/gspca/cpia1.c | 10 +- drivers/media/video/gspca/gspca.c |4 ++-- drivers/media/video/gspca/m5602/m5602_ov9650.c |2 +- drivers/media/video/gspca/pac207.c |4 ++-- drivers/media/video/gspca/sonixb.c |4 ++-- drivers/media/video/gspca/sonixj.c | 18 +- drivers/media/video/gspca/spca561.c|2 +- drivers/media/video/gspca/stv06xx/stv06xx.c|2 +- drivers/media/video/gspca/stv06xx/stv06xx_st6422.c |4 ++-- drivers/media/video/gspca/t613.c |2 +- drivers/media/video/gspca/tv8532.c |2 +- drivers/media/video/gspca/zc3xx.c |2 +- 12 files changed, 28 insertions(+), 28 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Webcam driver not working: drivers/media/video/gspca/ov519.c device 05a9:4519
On Sun, 31 Oct 2010 15:16:40 +0200 Anca Emanuel anca.eman...@gmail.com wrote: After this patch, [snip] I get: [ 182.680032] usb 8-1: new full speed USB device using uhci_hcd and address 3 [ 182.875331] gspca: probing 05a9:4519 [ 183.064309] ov519: I2C synced in 0 attempt(s) [ 183.064314] ov519: starting OV7xx0 configuration [ 183.076312] ov519: Sensor is an OV7660 [snip] But only a green screen in Cheese. Logs attached. Hi Emanuel, The sensor ov7660 has not the same registers as the ov7670, so, your webcam could not work. To make it work, I need a USB trace done with ms-windows. May you do it? In a first step, I need the webcam connection and no more than one second of streaming at the maximum resolution. Please, use a sniffer which creates text files like sniffbin. Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Webcam driver not working: drivers/media/video/gspca/ov519.c device 05a9:4519
On Mon, 1 Nov 2010 22:02:49 +0200 Anca Emanuel anca.eman...@gmail.com wrote: Saved in txt and csv formats. I did not know this sniffer. The trace is compact, but, alas, the 'Request' and 'Value' are lacking... Is it possible to see them? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Webcam driver not working: drivers/media/video/gspca/ov519.c device 05a9:4519
On Tue, 2 Nov 2010 00:23:23 +0200 Anca Emanuel anca.eman...@gmail.com wrote: This file is stream.ulz compressed http://rapidshare.com/files/428384860/stream.zip To see the data, you need: http://www.usblyzer.com/download.htm And a windows machine. Sorry for the trouble. I got the ms-windows program, and I can see the lacking information, but only on clicking on each exchange. It could take one month to move all information into a readable format! May you redo traces with one of the free SniffUSB's? You may find links in: https://groups.google.com/group/microdia/web/usb-sniffing-on-windows Thanks. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Webcam driver not working: drivers/media/video/gspca/ov519.c device 05a9:4519
On Tue, 2 Nov 2010 12:33:10 +0200 Anca Emanuel anca.eman...@gmail.com wrote: I am using http://www.pcausa.com/Utilities/UsbSnoop/SniffUSB-x86-2.0.0006.zip now. The data: http://rapidshare.com/files/428460107/log4.zip please let me know if this is what you ask for. Hi, Thanks, that's what I wanted. Looking at the trace, I saw that the capture stopped and restarted 3 or 4 times. May you tell me what occured? Anyway, I will try to code your sensor tomorrow. I'll e-mail you when done. Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.38] gspca for_2.6.38
The following changes since commit af9f14f7fc31f0d7b7cdf8f7f7f15a3c3794aea3: [media] IR: add tv power scancode to rc6 mce keymap (2010-11-10 00:58:49 -0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.38 Jean-François Moine (16): gspca - ov519: Handle the snapshot on capture stop when CONFIG_INPUT=m gspca - ov519: Don't do USB exchanges after disconnection gspca - ov519: Change types '__xx' to 'xx' gspca - ov519: Reduce the size of some variables gspca - ov519: Define the sensor types in an enum gspca - ov519: Cleanup source gspca - ov519: Set their numbers in the ov519 and ov7670 register names gspca - ov519: Define the disabled controls in a table gspca - ov519: Propagate errors to higher level gspca - ov519: Clearer debug and error messages gspca - ov519: Check the disabled controls at start time only gspca - ov519: Simplify the LED control functions gspca - ov519: Change the ov519 start and stop sequences gspca - ov519: Initialize the ov519 snapshot register gspca - ov519: Re-initialize the webcam at resume time gspca - ov519: New sensor ov7660 with bridge ov530 (ov519) Nicolas Kaiser (1): gspca - cpia1: Fix error check drivers/media/video/gspca/cpia1.c |2 +- drivers/media/video/gspca/ov519.c | 1671 +-- drivers/media/video/gspca/w996Xcf.c | 325 +++ 3 files changed, 1131 insertions(+), 867 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gspca_ov534: Changing framerates, different behaviour in 2.6.36
On Mon, 22 Nov 2010 13:11:11 +0100 Antonio Ospite osp...@studenti.unina.it wrote: since 2.6.36 + the regression fix in [1] (please apply it): 3a. dmesg shows the message: ov534: frame_rate: xx 3b. guvcviews gives some errors and the preview image halts: VIDIOC_QBUF - Unable to queue buffer: Invalid argument Could not grab image (select timeout): Resource temporarily unavailable Reverting f7059eaa285c0460569ffd26c43ae07e3f03cd6c brings the old behaviour back. So something there is not happy with changing frame rate on the fly. Jean-François, I'll try to take a deeper look this week, but please tell me if you have any guess about what can cause this issue. Hi Antonio, I implemented dynamic frame rate change in ov519 for the ov530-ov7670 webcam I have, and it works well. In the ms-win file ov534.inf (for webcam 05a9:0531), I found sequences to stop and restart streaming: HKR,%CamSet%, BlockStream, 1, e0,08,ff HKR,%CamSet%, StartStream, 1, e0,00,ff In the ov534 driver, these are: ov534_reg_write(gspca_dev, 0xe0, 0x08); ov534_reg_write(gspca_dev, 0xe0, 0x00); So, you may try to block streaming when changing the frame rate (some delay may also help..). Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Regression at gspca core affecting SXGA mode on sn9c201 driver
On Wed, 08 Dec 2010 14:06:06 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: Drivers should provide a wmaxpacketsize range which they need / can deal with for a given resolution. This way we can fix your does not need highest alt setting at lower resolutions scenario (which is a very valid one), while still allowing fallback to a lower alt setting if the driver can deal with lower settings too, be it by lowering framerate or by increasing compression (decreasing the image quality). It seems a good strategy. Hi, That seems fine also to me. Mauro, about your patch, there is no need to add the variable 'no_audio_hack': just resetting the flag 'audio' in the subdrivers should be enough. Also, as a quicker hack, the 'audio' flag could be set only when USB is 1.1. Could that fix the problems found with sn9c20x and stv06xx? Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] [media] gspca/sn9c20x: Test if sensor is really an ov9650
On Thu, 9 Dec 2010 18:42:34 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: Instead of just assuming a ov9650 sensor based on USB ID, double-check it, by reading the sensor ID. Hi Mauro, In the patch, you check that the sensor is an OmniVision one, but not the ov9650. So, if the test succeeds, it could also be any of ov9655, ov7660 or ov7670, which could be treated, but will not work, or some other OmniVision sensor. The sensor type is defined by the sensor registers 0x0a and 0x0b. But, if it is enough for you, it is OK for me. Acked-by: Jean-Francois Moine moin...@free.fr Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/6] [media] gspca/sn9c20x: Get rid of scale magic numbers
On Thu, 9 Dec 2010 18:42:35 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: Use macros for the supported scales, instead of using magic numbers from 0 to 3. Code become cleaner by using macros for it. Acked-by: Jean-Francois Moine moin...@free.fr -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] [media] gspca core: Fix regressions gspca breaking devices with audio
On Thu, 9 Dec 2010 18:42:36 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: Changeset 35680ba broke several devices: - Sony Playstation Eye (1415:2000); - Gigaware model 25-234 (0c45:628f); - Logitech Messenger Plus (046d:08f6). Probably more devices were broken by this change. What happens is that several devices don't need to save some bandwidth for audio. Also, as pointed by Hans de Goede hdego...@redhat.com, the logic that implements the bandwidth reservation for audio is broken, since it will reduce the alt number twice, on devices with audio. So, let's just revert the broken logic, and think on a better solution for usb 1.1 devices with audio that can't use the maximum packetsize. Acked-by: Jean-Francois Moine moin...@free.fr -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/6] [media] gspca/sn9c20x: Fix support for mt9m001 (mi1300) sensor
On Thu, 9 Dec 2010 18:42:37 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: Support for mt9m001 (mi1300) is broken: - Table is incomplete; - Only one resolution is currently supported by the driver; - Resolution is incomplete; - it complains about broken JPEG headers. Use the same init found on em28xx driver, and properly report the output format as 8-bits GRAY. Acked-by: Jean-Francois Moine moin...@free.fr -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/6] [media] gspca/sonixj: Fix support for sn9c105+0v7660
On Thu, 9 Dec 2010 18:42:38 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: This bug were very tricky to discover. Basically, replying the webcam initialization sequence, after the capture is running make it works. After several researches, I discovered that the sensor were in powerdown mode, when the init sequence was sent. As result, the sensor were never initialized. The right fix would be to map the cases where the powerdown logic is inverted, and add it at some per-device init table. While we don't have it at sonixj, just add a variable to the bridge_init (where the sensor is also initialized), properly handling the case where the logic is not inverted for this specific device. Hi Mauro, I looked again at the USB traces I have with this sensor, and a problem was raised every time I found a webcam with the opposite setting of the powerdown mode. The last webcams I fixed were the Microsoft's VX1000 and VX3000 were the power mode is inverted. Indeed, this change broke most of the other ov7660 based webcams. So, the correct patch is to define the power mode in the device table. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/6] gspca sonixj better handling of reg 01 and 17
Here is an other way to fix the inv powerdown bug. These patches are not tested yet. Jean-François Moine (6): gspca - sonixj: Move bridge init to sd start gspca - sonixj: Fix a bad probe exchange gspca - sonixj: Add a flag in the driver_info table gspca - sonixj: Set the flag for some devices gspca - sonixj: Add the bit definitions of the bridge reg 0x01 and 0x17 gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17 drivers/media/video/gspca/sonixj.c | 410 1 files changed, 182 insertions(+), 228 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/6] gspca - sonixj: Move bridge init to sd start
Signed-off-by: Jean-François Moine moin...@free.fr
diff --git a/drivers/media/video/gspca/sonixj.c
b/drivers/media/video/gspca/sonixj.c
index 2229847..4660cbe 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -1755,141 +1755,6 @@ static void po2030n_probe(struct gspca_dev *gspca_dev)
}
}
-static void bridge_init(struct gspca_dev *gspca_dev,
- const u8 *sn9c1xx)
-{
- struct sd *sd = (struct sd *) gspca_dev;
- u8 reg0102[2];
- const u8 *reg9a;
- static const u8 reg9a_def[] =
- {0x00, 0x40, 0x20, 0x00, 0x00, 0x00};
- static const u8 reg9a_spec[] =
- {0x00, 0x40, 0x38, 0x30, 0x00, 0x20};
- static const u8 regd4[] = {0x60, 0x00, 0x00};
-
- /* sensor clock already enabled in sd_init */
- /* reg_w1(gspca_dev, 0xf1, 0x00); */
- reg_w1(gspca_dev, 0x01, sn9c1xx[1]);
-
- /* configure gpio */
- reg0102[0] = sn9c1xx[1];
- reg0102[1] = sn9c1xx[2];
- if (gspca_dev-audio)
- reg0102[1] |= 0x04; /* keep the audio connection */
- reg_w(gspca_dev, 0x01, reg0102, 2);
- reg_w(gspca_dev, 0x08, sn9c1xx[8], 2);
- reg_w(gspca_dev, 0x17, sn9c1xx[0x17], 5);
- switch (sd-sensor) {
- case SENSOR_GC0307:
- case SENSOR_OV7660:
- case SENSOR_PO1030:
- case SENSOR_PO2030N:
- case SENSOR_SOI768:
- case SENSOR_SP80708:
- reg9a = reg9a_spec;
- break;
- default:
- reg9a = reg9a_def;
- break;
- }
- reg_w(gspca_dev, 0x9a, reg9a, 6);
-
- reg_w(gspca_dev, 0xd4, regd4, sizeof regd4);
-
- reg_w(gspca_dev, 0x03, sn9c1xx[3], 0x0f);
-
- switch (sd-sensor) {
- case SENSOR_ADCM1700:
- reg_w1(gspca_dev, 0x01, 0x43);
- reg_w1(gspca_dev, 0x17, 0x62);
- reg_w1(gspca_dev, 0x01, 0x42);
- reg_w1(gspca_dev, 0x01, 0x42);
- break;
- case SENSOR_GC0307:
- msleep(50);
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0x22);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- msleep(50);
- break;
- case SENSOR_MI0360B:
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0x60);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- break;
- case SENSOR_MT9V111:
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0x61);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- break;
- case SENSOR_OM6802:
- msleep(10);
- reg_w1(gspca_dev, 0x02, 0x73);
- reg_w1(gspca_dev, 0x17, 0x60);
- reg_w1(gspca_dev, 0x01, 0x22);
- msleep(100);
- reg_w1(gspca_dev, 0x01, 0x62);
- reg_w1(gspca_dev, 0x17, 0x64);
- reg_w1(gspca_dev, 0x17, 0x64);
- reg_w1(gspca_dev, 0x01, 0x42);
- msleep(10);
- reg_w1(gspca_dev, 0x01, 0x42);
- i2c_w8(gspca_dev, om6802_init0[0]);
- i2c_w8(gspca_dev, om6802_init0[1]);
- msleep(15);
- reg_w1(gspca_dev, 0x02, 0x71);
- msleep(150);
- break;
- case SENSOR_OV7630:
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0xe2);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- break;
- case SENSOR_OV7648:
- reg_w1(gspca_dev, 0x01, 0x63);
- reg_w1(gspca_dev, 0x17, 0x20);
- reg_w1(gspca_dev, 0x01, 0x62);
- reg_w1(gspca_dev, 0x01, 0x42);
- break;
- case SENSOR_PO1030:
- case SENSOR_SOI768:
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0x20);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- break;
- case SENSOR_PO2030N:
- case SENSOR_OV7660:
- reg_w1(gspca_dev, 0x01, 0x63);
- reg_w1(gspca_dev, 0x17, 0x20);
- reg_w1(gspca_dev, 0x01, 0x62);
- reg_w1(gspca_dev, 0x01, 0x42);
- break;
- case SENSOR_SP80708:
- reg_w1(gspca_dev, 0x01, 0x63);
- reg_w1(gspca_dev, 0x17, 0x20);
- reg_w1(gspca_dev, 0x01, 0x62);
- reg_w1(gspca_dev, 0x01, 0x42);
- msleep(100);
- reg_w1(gspca_dev, 0x02, 0x62);
- break;
- default:
-/* case SENSOR_HV7131R: */
-/* case SENSOR_MI0360: */
-/* case SENSOR_MO4000: */
-
PATCH 2/6] gspca - sonixj: Fix a bad probe exchange
Signed-off-by: Jean-François Moine moin...@free.fr
diff --git a/drivers/media/video/gspca/sonixj.c
b/drivers/media/video/gspca/sonixj.c
index 4660cbe..5978676 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -1794,7 +1794,7 @@ static int sd_init(struct gspca_dev *gspca_dev)
/* setup a selector by bridge */
reg_w1(gspca_dev, 0xf1, 0x01);
reg_r(gspca_dev, 0x00, 1);
- reg_w1(gspca_dev, 0xf1, gspca_dev-usb_buf[0]);
+ reg_w1(gspca_dev, 0xf1, 0x00);
reg_r(gspca_dev, 0x00, 1); /* get sonix chip id */
regF1 = gspca_dev-usb_buf[0];
if (gspca_dev-usb_err 0)
@@ -2289,10 +2289,10 @@ static int sd_start(struct gspca_dev *gspca_dev)
struct sd *sd = (struct sd *) gspca_dev;
int i;
u8 reg0102[2];
- const u8 *reg9a;
u8 reg1, reg17;
const u8 *sn9c1xx;
const u8 (*init)[8];
+ const u8 *reg9a;
int mode;
static const u8 reg9a_def[] =
{0x00, 0x40, 0x20, 0x00, 0x00, 0x00};
--
1.7.2.3
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/6] gspca - sonixj: Add a flag in the driver_info table
Signed-off-by: Jean-François Moine moin...@free.fr
diff --git a/drivers/media/video/gspca/sonixj.c
b/drivers/media/video/gspca/sonixj.c
index 5978676..bd5858e 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -64,6 +64,7 @@ struct sd {
u8 jpegqual;/* webcam quality */
u8 reg18;
+ u8 flags;
s8 ag_cnt;
#define AG_CNT_START 13
@@ -96,6 +97,9 @@ enum sensors {
SENSOR_SP80708,
};
+/* device flags */
+#define PDN_INV1 /* inverse pin S_PWR_DN / sn_xxx tables
*/
+
/* V4L2 controls supported by the driver */
static void setbrightness(struct gspca_dev *gspca_dev);
static void setcontrast(struct gspca_dev *gspca_dev);
@@ -1763,7 +1767,8 @@ static int sd_config(struct gspca_dev *gspca_dev,
struct cam *cam;
sd-bridge = id-driver_info 16;
- sd-sensor = id-driver_info;
+ sd-sensor = id-driver_info 8;
+ sd-flags = id-driver_info;
cam = gspca_dev-cam;
if (sd-sensor == SENSOR_ADCM1700) {
@@ -2947,7 +2952,11 @@ static const struct sd_desc sd_desc = {
/* -- module initialisation -- */
#define BS(bridge, sensor) \
.driver_info = (BRIDGE_ ## bridge 16) \
- | SENSOR_ ## sensor
+ | (SENSOR_ ## sensor 8)
+#define BSF(bridge, sensor, flags) \
+ .driver_info = (BRIDGE_ ## bridge 16) \
+ | (SENSOR_ ## sensor 8) \
+ | flags
static const __devinitdata struct usb_device_id device_table[] = {
#if !defined CONFIG_USB_SN9C102 !defined CONFIG_USB_SN9C102_MODULE
{USB_DEVICE(0x0458, 0x7025), BS(SN9C120, MI0360)},
--
1.7.2.3
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/6] gspca - sonixj: Set the flag for some devices
The flag PDN_INV indicates that the sensor pin S_PWR_DN has not the same
value as other webcams with the same sensor. For now, only two webcams
have been detected so: the Microsoft's VX1000 and VX3000.
Signed-off-by: Jean-François Moine moin...@free.fr
diff --git a/drivers/media/video/gspca/sonixj.c
b/drivers/media/video/gspca/sonixj.c
index bd5858e..9b7e28a 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -2962,8 +2962,8 @@ static const __devinitdata struct usb_device_id
device_table[] = {
{USB_DEVICE(0x0458, 0x7025), BS(SN9C120, MI0360)},
{USB_DEVICE(0x0458, 0x702e), BS(SN9C120, OV7660)},
#endif
- {USB_DEVICE(0x045e, 0x00f5), BS(SN9C105, OV7660)},
- {USB_DEVICE(0x045e, 0x00f7), BS(SN9C105, OV7660)},
+ {USB_DEVICE(0x045e, 0x00f5), BSF(SN9C105, OV7660, PDN_INV)},
+ {USB_DEVICE(0x045e, 0x00f7), BSF(SN9C105, OV7660, PDN_INV)},
{USB_DEVICE(0x0471, 0x0327), BS(SN9C105, MI0360)},
{USB_DEVICE(0x0471, 0x0328), BS(SN9C105, MI0360)},
{USB_DEVICE(0x0471, 0x0330), BS(SN9C105, MI0360)},
--
1.7.2.3
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 5/6] gspca - sonixj: Add the bit definitions of the bridge reg 0x01 and 0x17
Signed-off-by: Jean-François Moine moin...@free.fr
diff --git a/drivers/media/video/gspca/sonixj.c
b/drivers/media/video/gspca/sonixj.c
index 9b7e28a..4c10324 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -100,6 +100,19 @@ enum sensors {
/* device flags */
#define PDN_INV1 /* inverse pin S_PWR_DN / sn_xxx tables
*/
+/* sn9c1xx definitions */
+/* register 0x01 */
+#define S_PWR_DN 0x01/* sensor power down */
+#define S_PDN_INV 0x02/* inverse pin S_PWR_DN */
+#define V_TX_EN0x04/* video transfer enable */
+#define LED0x08/* output to pin LED */
+#define SCL_SEL_OD 0x20/* open-drain mode */
+#define SYS_SEL_48M0x40/* system clock 0: 24MHz, 1: 48MHz */
+/* register 0x17 */
+#define MCK_SIZE_MASK 0x1f/* sensor master clock */
+#define SEN_CLK_EN 0x20/* enable sensor clock */
+#define DEF_EN 0x80/* defect pixel by 0: soft, 1: hard */
+
/* V4L2 controls supported by the driver */
static void setbrightness(struct gspca_dev *gspca_dev);
static void setcontrast(struct gspca_dev *gspca_dev);
--
1.7.2.3
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17
The initial values of the registers 0x01 and 0x17 are taken from the
senso table at capture start and updated according to the flag PDN_INV.
Their values are updated at each step of the capture initialization and
memorized for reuse in capture stop.
This patch also fixed automatically some bad hardcoded values of these
registers.
Signed-off-by: Jean-François Moine moin...@free.fr
diff --git a/drivers/media/video/gspca/sonixj.c
b/drivers/media/video/gspca/sonixj.c
index 4c10324..880e931 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -63,6 +63,8 @@ struct sd {
#define QUALITY_DEF 80
u8 jpegqual;/* webcam quality */
+ u8 reg01;
+ u8 reg17;
u8 reg18;
u8 flags;
@@ -2306,8 +2308,8 @@ static int sd_start(struct gspca_dev *gspca_dev)
{
struct sd *sd = (struct sd *) gspca_dev;
int i;
+ u8 reg01, reg17;
u8 reg0102[2];
- u8 reg1, reg17;
const u8 *sn9c1xx;
const u8 (*init)[8];
const u8 *reg9a;
@@ -2341,10 +2343,13 @@ static int sd_start(struct gspca_dev *gspca_dev)
/* sensor clock already enabled in sd_init */
/* reg_w1(gspca_dev, 0xf1, 0x00); */
- reg_w1(gspca_dev, 0x01, sn9c1xx[1]);
+ reg01 = sn9c1xx[1];
+ if (sd-flags PDN_INV)
+ reg01 ^= S_PDN_INV; /* power down inverted */
+ reg_w1(gspca_dev, 0x01, reg01);
/* configure gpio */
- reg0102[0] = sn9c1xx[1];
+ reg0102[0] = reg01;
reg0102[1] = sn9c1xx[2];
if (gspca_dev-audio)
reg0102[1] |= 0x04; /* keep the audio connection */
@@ -2370,95 +2375,49 @@ static int sd_start(struct gspca_dev *gspca_dev)
reg_w(gspca_dev, 0x03, sn9c1xx[3], 0x0f);
+ reg17 = sn9c1xx[0x17];
switch (sd-sensor) {
- case SENSOR_ADCM1700:
- reg_w1(gspca_dev, 0x01, 0x43);
- reg_w1(gspca_dev, 0x17, 0x62);
- reg_w1(gspca_dev, 0x01, 0x42);
- reg_w1(gspca_dev, 0x01, 0x42);
- break;
case SENSOR_GC0307:
- msleep(50);
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0x22);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- msleep(50);
- break;
- case SENSOR_MI0360B:
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0x60);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- break;
- case SENSOR_MT9V111:
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0x61);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
+ msleep(50); /*fixme: is it useful? */
break;
case SENSOR_OM6802:
msleep(10);
reg_w1(gspca_dev, 0x02, 0x73);
- reg_w1(gspca_dev, 0x17, 0x60);
+ reg17 |= SEN_CLK_EN;
+ reg_w1(gspca_dev, 0x17, reg17);
reg_w1(gspca_dev, 0x01, 0x22);
msleep(100);
- reg_w1(gspca_dev, 0x01, 0x62);
- reg_w1(gspca_dev, 0x17, 0x64);
- reg_w1(gspca_dev, 0x17, 0x64);
- reg_w1(gspca_dev, 0x01, 0x42);
+ reg01 = SCL_SEL_OD | S_PDN_INV;
+ reg17 = MCK_SIZE_MASK;
+ reg17 |= 0x04; /* clock / 4 */
+ break;
+ }
+ reg01 |= SYS_SEL_48M;
+ reg_w1(gspca_dev, 0x01, reg01);
+ reg17 |= SEN_CLK_EN;
+ reg_w1(gspca_dev, 0x17, reg17);
+ reg01 = ~S_PWR_DN; /* sensor power on */
+ reg_w1(gspca_dev, 0x01, reg01);
+ reg01 = ~SYS_SEL_48M;
+ reg_w1(gspca_dev, 0x01, reg01);
+
+ switch (sd-sensor) {
+ case SENSOR_HV7131R:
+ hv7131r_probe(gspca_dev); /*fixme: is it useful? */
+ break;
+ case SENSOR_OM6802:
msleep(10);
- reg_w1(gspca_dev, 0x01, 0x42);
+ reg_w1(gspca_dev, 0x01, reg01);
i2c_w8(gspca_dev, om6802_init0[0]);
i2c_w8(gspca_dev, om6802_init0[1]);
msleep(15);
reg_w1(gspca_dev, 0x02, 0x71);
msleep(150);
break;
- case SENSOR_OV7630:
- reg_w1(gspca_dev, 0x01, 0x61);
- reg_w1(gspca_dev, 0x17, 0xe2);
- reg_w1(gspca_dev, 0x01, 0x60);
- reg_w1(gspca_dev, 0x01, 0x40);
- break;
- case SENSOR_OV7648:
- reg_w1(gspca_dev, 0x01, 0x63);
- reg_w1(gspca_dev, 0x17, 0x20);
- reg_w1(gspca_dev, 0x01, 0x62);
- reg_w1(gspca_dev, 0x01, 0x42);
- break;
- case SENSOR_PO1030:
- case
Re: [PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17
On Mon, 13 Dec 2010 11:27:24 -0200
Mauro Carvalho Chehab mche...@redhat.com wrote:
case SENSOR_OV7660:
init = ov7660_sensor_param1;
- if (sd-bridge == BRIDGE_SN9C120) {
- if (mode) { /* 320x240 - 160x120 */
- reg17 = 0xa2;
- reg1 = 0x44;/* 48 Mhz, video trf eneble */
- }
- } else {
- reg17 = 0x22;
- reg1 = 0x06;/* 24 Mhz, video trf eneble
-* inverse power down */
- }
I'm not sure about this... On my tests with the two devices I have
with ov7660 (sn9c105 and sn9c120), the original driver uses 48 MHz
for all resolutions.
Hi Mauro,
You are right, I will fix that in the next version.
Regards.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] [media] gspca core: Fix regressions gspca breaking devices with audio
On Tue, 14 Dec 2010 20:52:43 +0200 Anca Emanuel anca.eman...@gmail.com wrote: How can I disable the noise from camera ? There is no physical microphone in it. ( mute do not work ) [snip] [ 139.848996] usb 8-1: usb_probe_device [ 139.849003] usb 8-1: configuration #1 chosen from 1 choice [ 139.851825] usb 8-1: adding 8-1:1.0 (config #1, interface 0) [ 139.851932] usb 8-1: adding 8-1:1.1 (config #1, interface 1) [ 139.851992] usb 8-1: adding 8-1:1.2 (config #1, interface 2) [ 139.898020] gspca: v2.11.0 registered [ 139.904357] ov519 8-1:1.0: usb_probe_interface [ 139.904362] ov519 8-1:1.0: usb_probe_interface - got id This is an old version. May you get the last one from my web page? (actual 2.11.15) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] [media] gspca core: Fix regressions gspca breaking devices with audio
On Tue, 14 Dec 2010 22:05:37 +0200 Anca Emanuel anca.eman...@gmail.com wrote: The same biz ... Does this noise exist with all image resolutions? Also, does it change when changing the frame rate or the light frequency? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Quickcam express: Not able to capture video
On Wed, 22 Dec 2010 10:45:14 +0530 Sudhindra Nayak sudhindra.na...@gmail.com wrote: Hi all, I'm using a 'Logitech Quickcam Express' (046d:0840) camera to capture video. I'm using the STV06xx driver for this camera. I'm using a v4l2 example code as my application along with the above mentioned driver. [snip] When I run the application, the kernel crashes. I'm running the application on the AT91 linux4sam kernel running on an AT91SAM9G45-EKES board. I've included the error messages below: gspca: [a.out] open gspca: frame alloc frsz: 106560 gspca: reqbufs st:0 c:4 [snip] gspca: packet [0] o:0 l:847 STV06xx: Packet of length 0 arrived gspca: packet [1] o:1023 l:63 STV06xx: Packet of length 1023 arrived Unable to handle kernel NULL pointer dereference at virtual address 0040 pgd = c0004000 [0040] *pgd= Internal error: Oops: 17 [#1] Modules linked in: CPU: 0Not tainted (2.6.30 #17) PC is at stv06xx_pkt_scan+0x3c/0x1e0 LR is at stv06xx_pkt_scan+0x20/0x1e0 [snip] Any suggestions?? Hi, (do not use the mailing list at redhat.com. The new one is linux-media - see Cc:) Your kernel is rather old. If you cannot change to a newer one (at least 2.6.32 or, better, 2.6.34), may you get and try the last gspca test version from my web page (see below)? Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Adds the Lego Bionicle to existing sq905c
On Sat, 25 Dec 2010 10:36:20 +0100 Hans de Goede hdego...@redhat.com wrote: On 12/25/2010 10:20 AM, Mauro Carvalho Chehab wrote: Em 24-12-2010 17:55, Hans de Goede escreveu: Mauro, Will you pick up this patch directly or should I put it in my tree ? Either way works for me (but I prefer if one of the gspca maintainers/sub-mainainers pick). If you don't pick it, please reply with your ack. Given that nothing else is going into my tree at the moment I would prefer for you to pick it up directly, so: Acked-by: Hans de Goede hdego...@redhat.com Hi Mauro and Hans, As I have some changes to do in this driver, I may also apply Theodore's patch. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.38] gspca for_2.6.38
The following changes since commit 884d09f0d9f2eb6848c71fd024c250816f835572: [media] drivers:media:dvb: add USB PIDs for Elgato EyeTV Sat (2010-12-22 15:57:42 -0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.38 Jean-François Moine (7): gspca - sq930x: Don't register a webcam when there are USB errors gspca - sq930x: Some detected sensors are not handled yet gspca - sq930x: Fix a bad comment gspca - main: Check the isoc packet status before its length gspca: Use the global error status for get/set streamparm gspca - ov519: Bad detection of some ov7670 sensors gspca - ov534_9: Remove a useless instruction Theodore Kilgore (1): gspca - sq905c: Adds the Lego Bionicle Documentation/video4linux/gspca.txt |1 + drivers/media/video/gspca/gspca.c | 34 ++ drivers/media/video/gspca/gspca.h |2 +- drivers/media/video/gspca/ov519.c |4 ++-- drivers/media/video/gspca/ov534.c | 14 ++ drivers/media/video/gspca/ov534_9.c |1 - drivers/media/video/gspca/sq905c.c |1 + drivers/media/video/gspca/sq930x.c | 28 8 files changed, 45 insertions(+), 40 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Adds the Lego Bionicle to existing sq905c
On Sat, 25 Dec 2010 12:14:25 -0600 (CST) Theodore Kilgore kilg...@banach.math.auburn.edu wrote: As I have some changes to do in this driver, If you do not mind, tell me more about the some changes. More cameras? Or something else? Hi Theodore, Sorry, I made a mistake. I had changes for the sq930x instead... The best also for you and for everybody for 2011. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Image and webcam freeze on Ubuntu with Logitech QuickCam Communicate STX
On Thu, 18 Aug 2011 12:31:51 +0200 Damien Cassou damien.cas...@gmail.com wrote: my Logitech QuickCam Communicate STX works perfectly well for a few minutes when I use it. However, after that the image is frozen and I can't make it work again until I reboot the system (before rebooting, the webcam has a blue color indicating it is working even though I can't get anything displayed). What can I do? A way to avoid rebooting would be a very welcomed workaround. Details below: - because of this bug I compiled the driver manually to see if the bug was fixed. I compiled it from gspca-2.13.6.tar.gz - ubuntu 11.04, all updates installed - dmesg displays a lot of the following line: gspca: ISOC data error: [0] len=0, status=-18 - lsusb returns: Bus 003 Device 002: ID 046d:08ad Logitech, Inc. QuickCam Communicate STX Hi Damien, I need more information. May you send me the kernel messages starting from the webcam connection up to the first ISOC data errors? Please, use the gspca 2.13.6 and set the debug level to 0x0f: echo 0x0f /sys/module/gspca_main/parameters/debug (then, unplug / replug the webcam) Thanks. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/14] [media] gspca: Use current logging styles
On Sun, 21 Aug 2011 15:56:57 -0700 Joe Perches j...@perches.com wrote: Add pr_fmt. Convert usb style logging macros to pr_level. Remove now unused old usb style logging macros. Hi Joe, Sorry, but I do not see the advantages of your patch. For gspca, the source files are bigger, and the only visible change is the display of the real module name instead of the name defined by hand (this change may have been done just in gspca.h). Also, I think that defining 'pr_fmt' in each source file is not a good idea... -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/14] [media] gspca: Use current logging styles
On Mon, 22 Aug 2011 08:20:28 -0700 Joe Perches j...@perches.com wrote: The primary current advantage is style standardization both in code and dmesg output. Future changes to printk.h will reduce object sizes by centralizing the prefix to a singleton and emitting it only in pr_level. Hi Joe, OK, I did not see that you started such changes a long time ago! Thanks and good luck! Acked-by: Jean-Francois Moine moin...@free.fr -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 06/14] [media] cx18: Use current logging styles
On Sat, 27 Aug 2011 09:42:32 -0700 Joe Perches j...@perches.com wrote: Andy, I fully understand how this stuff works. You apparently don't (yet). Look at include/linux/printk.h #ifndef pr_fmt #define pr_fmt(fmt) fmt #endif A default empty define is used when one is not specified before printk.h is included. kernel.h includes printk.h Hi Joe, Yes, but, what if pr_fmt is redefined in some driver specific include by: #undef pr_fmt #define pr_fmt(fmt) KBUILD_MODNAME : fmt (in gspca.h for example) ? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [git:v4l-dvb/for_v3.2] [media] Fix wrong register mask in gspca/sonixj.c
On Mon, 29 Aug 2011 09:57:26 -0700 (PDT) Luiz Ramos lramos.p...@yahoo.com.br wrote: Mauro: To be fair, this patch itself isn't sufficient to solve the problem described in the text provided. One other patch is necessary to get this goal accomplished, named, one published in this same thread in 2011-07-18. This later fix is now embedded in a wider patch provided by Jean-François Moine in 2011-08-10. I'd suggest to change the text below, if possible, mentioning only something like fix wrong register masking. Hi Mauro, Sorry, I did not notice the automatic commit report. I submitted Luiz's patch and the darkness fix in 2 git patch requests on Wed, 10 Aug for 3.1 and on Fri, 12 Aug for 3.2: gspca - sonixj: Fix wrong register mask for sensor om6802 gspca - sonixj: Fix the darkness of sensor om6802 in 320x240 Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: spca1528 device (Device 015: ID 04fc:1528 Sunplus Technology)..libv4l2: error turning on stream: Timer expired issue
On Sun, 04 Sep 2011 15:39:30 -0400 Mauricio Henriquez buhochil...@gmail.com wrote: Recently I'm trying to make work a Sunplus crappy mini HD USB camera, lsusb list this info related to the device: Picture Transfer Protocol (PIMA 15470) Bus 001 Device 015: ID 04fc:1528 Sunplus Technology Co., Ltd idVendor 0x04fc Sunplus Technology Co., Ltd idProduct 0x1528 bcdDevice1.00 iManufacturer 1 Sunplus Co Ltd iProduct2 General Image Devic iSerial 0 ... Using the gspca-2.13.6 on my Fed12 (2.6.31.6-166.fc12.i686.PAE kernel), the device is listed as /dev/video1 and no error doing a dmesg...but trying to make it work, let say with xawtv, I get: [snip] Hi Mauricio, The problem seems tied to the alternate setting. It must be the #3 while the lastest versions of gspca compute a best one. May you apply the following patch to gspca-2.13.6? --8-- --- build/spca1528.c.orig 2011-09-05 08:41:54.0 +0200 +++ build/spca1528.c2011-09-05 08:53:51.0 +0200 @@ -307,8 +307,6 @@ sd-color = COLOR_DEF; sd-sharpness = SHARPNESS_DEF; - gspca_dev-nbalt = 4; /* use alternate setting 3 */ - return 0; } @@ -349,6 +347,9 @@ reg_r(gspca_dev, 0x25, 0x0004, 1); reg_wb(gspca_dev, 0x27, 0x, 0x, 0x06); reg_r(gspca_dev, 0x27, 0x, 1); + + gspca_dev-alt = 4; /* use alternate setting 3 */ + return gspca_dev-usb_err; } --8-- (Theodore, this webcam may work in mass storage mode with ID 04fc:0171. In webcam mode with ID 04fc:1528, it offers 3 interfaces: interface 0 contains only an interrupt endpoint, interface 1 is the webcam with only isochronous endpoints and interface 2 contains bulk in, bulk out and interrupt in endpoints - I don't know how to use the interfaces 0 and 2, but sure the interface 2 could be used to access the camera images) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: spca1528 device (Device 015: ID 04fc:1528 Sunplus Technology)..libv4l2: error turning on stream: Timer expired issue
On Mon, 05 Sep 2011 11:33:49 -0400 Mauricio Henriquez buhochil...@gmail.com wrote: Thanks Jean, yeap I apply the patch, but still the same kind of messages about timeout sing xawtv or svv: OK Mauricio. So, I need more information. May you set the gspca debug level to 0x0f echo 0x0f /sys/module/gspca_main/parameters/debug run 'svv' and send me the kernel messages starting from the last gspca open? Thanks. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] gspca/zc3xx: add usb_id for HP Premium Starter Cam
On Fri, 9 Sep 2011 11:33:15 +0200 Wolfram Sang w.s...@pengutronix.de wrote: On Sat, Jul 02, 2011 at 02:02:00PM +0200, Wolfram Sang wrote: Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Jean-Francois Moine moin...@free.fr --- Ping. I can't find it in the git-repos on linuxtv.org? Hi Wolfram, I asked to pull your patch in linux 3.1 on Sun, 3 Jul 2011: http://www.spinics.net/lists/linux-media/msg34914.html but, it seems that only the patches relative to ov519 and jeilinj have been applied (the patch for sn9c20x has been lost too). Hi Mauro, I removed Wolfram's and Franck's patches from my repository. Have you still these patches or must I resubmit them (and the 2 other pending request)? Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Question about USB interface index restriction in gspca
On Tue, 13 Sep 2011 21:14:28 +0200 Frank Schäfer fschaefer@googlemail.com wrote: I have a question about the following code in gspca.c: in function gspca_dev_probe(...): ... /* the USB video interface must be the first one */ if (dev-config-desc.bNumInterfaces != 1 intf-cur_altsetting-desc.bInterfaceNumber != 0) return -ENODEV; ... Is there a special reason for not allowing devices with USB interface index 0 for video ? I'm experimenting with a device that has the video interface at index 3 and two audio interfaces at index 0 and 1 (index two is missing !). And the follow-up question: can we assume that all device handled by the gspca-driver have vendor specific video interfaces ? Then we could change the code to ... /* the USB video interface must be of class vendor */ if (intf-cur_altsetting-desc.bInterfaceClass != USB_CLASS_VENDOR_SPEC) return -ENODEV; ... Hi Frank, For webcam devices, the interface class is meaningful only when set to USB_CLASS_VIDEO (UVC). Otherwise, I saw many different values. For video on a particular interface, the subdriver must call the function gspca_dev_probe2() as this is done in spca1528 and xirlink_cit. Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Question about USB interface index restriction in gspca
On Thu, 15 Sep 2011 23:46:57 +0200 Frank Schäfer fschaefer@googlemail.com wrote: For webcam devices, the interface class is meaningful only when set to USB_CLASS_VIDEO (UVC). Otherwise, I saw many different values. Does that mean that there are devices out in the wild that report for example USB_CLASS_WIRELESS_CONTROLLER for the video interface ??? For video on a particular interface, the subdriver must call the function gspca_dev_probe2() as this is done in spca1528 and xirlink_cit. Hmm, sure, that would work... But wouldn't it be better to improve the interface check and merge the two probing functions ? The subdrivers can decide which interfaces are (not) probed and the gspca core does plausability checks (e.g. bulk/isoc endpoint ? usb class ?). Generally, the first interface is the video device, and the function gspca_dev_probe() works well enough. The function gspca_dev_probe2() is used by only 2 subdrivers and the way to find the correct interface is not easy. For example, the webcam 047d:5003 (subdriver spca1528) has 3 interfaces (class vendor specific). The 1st one has only one altsetting with only one interrupt endpoint, the 2nd one has 8 altsettings, each with only one isochronous endpoint, and the last one has one altsetting with 3 endpoints (bulk in, bulk out and interrupt). At the first glance, it is easy to know the right interface, but writing generic code to handle such webcams seems rather complicated. So, if your webcam is in the 99.99% which use the interface 0, use gspca_dev_probe(), otherwise, YOU know the right interface, so, call gspca_dev_probe2(). Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Question about USB interface index restriction in gspca
On Mon, 19 Sep 2011 22:13:12 +0200 Frank Schäfer fschaefer@googlemail.com wrote: So, if your webcam is in the 99.99% which use the interface 0, use gspca_dev_probe(), otherwise, YOU know the right interface, so, call gspca_dev_probe2(). Isn't it also possible that we don't know the right interface and it is not interface 0 ? ;-) I hope that the interface does not change each time you unplug/replug the webcam :), but if different webcams with a same device ID may use different interfaces, you should have to develop specific code in the subdriver... -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 3.2] gspca for_v3.2
Hi Mauro, This set includes the patches: http://patchwork.linuxtv.org/patch/7358 http://patchwork.linuxtv.org/patch/114 Cheers. The following changes since commit e553000a14ead0e265a8aa4d241c7b3221e233e3: [media] sr030pc30: Remove empty s_stream op (2011-09-21 12:48:45 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v3.2 Frank Schaefer (1): gspca - sn9c20x: Fix status LED device 0c45:62b3. Jean-François Moine (10): gspca - benq: Remove the useless function sd_isoc_init gspca - main: Use a better altsetting for image transfer gspca - main: Handle the xHCI error on usb_set_interface() gspca - topro: New subdriver for Topro webcams gspca - spca1528: Increase the status waiting time gspca - spca1528: Add some comments and update copyright gspca - spca1528: Change the JPEG quality of the images gspca - spca1528: Don't force the USB transfer alternate setting gspca - main: Version change to 2.14.0 gspca - main: Display the subdriver name and version at probe time Wolfram Sang (1): gspca - zc3xx: New webcam 03f0:1b07 HP Premium Starter Cam Documentation/video4linux/gspca.txt |3 + drivers/media/video/gspca/Kconfig| 10 + drivers/media/video/gspca/Makefile |2 + drivers/media/video/gspca/benq.c | 15 - drivers/media/video/gspca/gspca.c| 225 ++- drivers/media/video/gspca/sn9c20x.c |2 +- drivers/media/video/gspca/spca1528.c | 26 +- drivers/media/video/gspca/topro.c| 4989 ++ drivers/media/video/gspca/zc3xx.c|1 + 9 files changed, 5180 insertions(+), 93 deletions(-) create mode 100644 drivers/media/video/gspca/topro.c -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.38] gspca for_2.6.38
The following changes since commit fc43dd115e1c07af122440971177451cef5c45c0: [media] MEDIA: RC: Provide full scancodes for TT-1500 remote control (2010-12-27 19:26:56 -0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.38 Jean-François Moine (9): gspca - main: Fix some warnings gspca - pac7302/pac7311: Fix some warnings gspca: Bad comment gspca - zc3xx: Keep sorted the device table gspca - zc3xx: Use the new video control mechanism gspca - zc3xx: The sensor of the VF0250 is a GC0303 gspca - vc032x: Cleanup source gspca - stv06xx/st6422: Use the new video control mechanism gspca - sonixj: Bad clock for om6802 in 640x480 drivers/media/video/gspca/gspca.c | 10 +- drivers/media/video/gspca/gspca.h |2 +- drivers/media/video/gspca/pac7302.c|2 +- drivers/media/video/gspca/pac7311.c|2 +- drivers/media/video/gspca/sonixj.c |2 +- drivers/media/video/gspca/stv06xx/stv06xx_st6422.c | 272 --- drivers/media/video/gspca/stv06xx/stv06xx_st6422.h | 10 - drivers/media/video/gspca/vc032x.c | 74 +++--- drivers/media/video/gspca/zc3xx.c | 290 ++-- 9 files changed, 251 insertions(+), 413 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: RFC: Move the deprecated et61x251 and sn9c102 to staging
On Sun, 2 Jan 2011 12:25:21 +0100 Hans Verkuil hverk...@xs4all.nl wrote: It seems to me that et61x251 will also stay there for a long time, as there are just two devices supported by gspca driver, while et61x251 supports 25. Btw, we currently have a conflict with this USB ID: USB_DEVICE(0x102c, 0x6151), Both etoms and et61x251 support it, and there's no #if to disable it on one driver, if both drivers are compiled. We need to disable it either at gspca_etoms or at et61x251, in order to avoid users of having a random experience with this device. Surely such devices should be removed from et61x251 or sn9c102 as soon as they are added to gspca? The et61x251 wants to manage all etoms webcams, but only the 102c:6251 is handled (sensor tas5130d1b - the 102c:6151 contains a pas106). The other USB ID's should be removed from this driver. About sn9c102, some people say that the sn9c102 is working better than gspca. Also, both drivers et61x251 and sn9c102 support cropping while gspca does not. Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] gspca fix backports for 2.6.36
On Thu, 6 Jan 2011 09:28:36 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: This patch series backport POWER INV fixes for sonixj sensors. Jean, I'm currently without any sensorj camera. Could you please test this backport? Greg already backported two patches of this series. Those patches should be applied after stable patches he sent yesterday (151/152 and 152/152). All patches are at the ML. Hi Mauro, I have no sonixj webcam and my contacts would not know how to test. The patches seem fine to me. Anyway, if there is no error while patching and compiling, they should work. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.38] gspca for_2.6.38
The following changes since commit 353b61709a555fab9745cb7aea18e1c376c413ce: [media] radio-si470x: Always report support for RDS (2011-01-11 14:44:28 -0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_2.6.38 Jean-François Moine (9): gspca: Version change. gspca: Remove __devinit, __devinitconst and __devinitdata gspca: Remove useless instructions gspca - ov519: Cleanup source and add a comment gspca - ov534: Clearer debug messages gspca - ov534: Propagate errors to higher level gspca - ov534: Use the new video control mechanism gspca - sonixj: Infrared bug fix and enhancement gspca - sonixj: Add LED (illuminator) control to the webcam 0c45:614a. drivers/media/video/gspca/benq.c |2 +- drivers/media/video/gspca/conex.c|4 +- drivers/media/video/gspca/cpia1.c|2 +- drivers/media/video/gspca/etoms.c|4 +- drivers/media/video/gspca/finepix.c |2 +- drivers/media/video/gspca/gl860/gl860.c |2 +- drivers/media/video/gspca/gspca.c|2 +- drivers/media/video/gspca/jeilinj.c |2 +- drivers/media/video/gspca/jpeg.h |4 +- drivers/media/video/gspca/konica.c |2 +- drivers/media/video/gspca/m5602/m5602_core.c |2 +- drivers/media/video/gspca/mars.c |2 +- drivers/media/video/gspca/mr97310a.c |2 +- drivers/media/video/gspca/ov519.c|8 +- drivers/media/video/gspca/ov534.c| 473 +++--- drivers/media/video/gspca/ov534_9.c |2 +- drivers/media/video/gspca/pac207.c |2 +- drivers/media/video/gspca/pac7302.c |4 +- drivers/media/video/gspca/pac7311.c |4 +- drivers/media/video/gspca/sn9c2028.c |2 +- drivers/media/video/gspca/sn9c20x.c |2 +- drivers/media/video/gspca/sonixb.c |4 +- drivers/media/video/gspca/sonixj.c | 92 +++--- drivers/media/video/gspca/spca1528.c |2 +- drivers/media/video/gspca/spca500.c |2 +- drivers/media/video/gspca/spca501.c |2 +- drivers/media/video/gspca/spca505.c |2 +- drivers/media/video/gspca/spca508.c |2 +- drivers/media/video/gspca/spca561.c |2 +- drivers/media/video/gspca/sq905.c|2 +- drivers/media/video/gspca/sq905c.c |2 +- drivers/media/video/gspca/sq930x.c |2 +- drivers/media/video/gspca/stk014.c |2 +- drivers/media/video/gspca/stv0680.c |2 +- drivers/media/video/gspca/stv06xx/stv06xx.c |2 +- drivers/media/video/gspca/sunplus.c |2 +- drivers/media/video/gspca/t613.c |2 +- drivers/media/video/gspca/tv8532.c |2 +- drivers/media/video/gspca/vc032x.c |2 +- drivers/media/video/gspca/xirlink_cit.c |2 +- drivers/media/video/gspca/zc3xx.c|2 +- 41 files changed, 218 insertions(+), 443 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38
On Thu, 13 Jan 2011 12:38:04 +0100 Antonio Ospite osp...@studenti.unina.it wrote: Jean-François Moine (9): [...] gspca - ov534: Use the new video control mechanism In this commit, is there a reason why you didn't rename also sd_setagc() into setagc() like for the other functions? I am going to test the changes and report back if there's anything more, I like the cleanup tho. Hi Antonio, With the new video control mechanism, the '.set_control' function is called only when capture is active. Otherwise, the '.set' function is called in any case, and here, it activates/inactivates the auto white balance control... Oh, I forgot to disable the awb when the agc is disabled! Thank you for reporting any problem. BTW, the webcam 06f8:3002 which had been removed some time ago is being tested. I will add it to this subdriver as soon as it works correctly. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.38] gspca for_v2.6.38
The following changes since commit e5fb95675639f064ca40df7ad319f1c380443999: [media] vivi: fix compiler warning (2011-01-23 12:34:08 -0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.38 Jean-François Moine (3): gspca - zc3xx: Bad delay when given by a table gspca - zc3xx: Fix bad images with the sensor hv7131r gspca - zc3xx: Discard the partial frames drivers/media/video/gspca/zc3xx.c | 31 ++- 1 files changed, 26 insertions(+), 5 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.39] gspca for_v2.6.39
The following changes since commit 6148a47ac3872092d4bc438bec6dff16654d: Merge branch 'rc-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6 (2011-02-09 16:56:33 -0800) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.39 Jean-François Moine (16): gspca - sonixj: Move the avg lum computation to a separate function gspca - sonixj: Better scanning of isochronous packets gspca - sonixj: Have the same JPEG quality for encoding and decoding gspca - sonixj: Update the JPEG quality for best image transfer gspca - sonixj: Fix start sequence of sensor mt9v111 gspca - sonixj: Adjust autogain for sensor mt9v111 gspca - sonixj: Simplify GPIO setting when audio present gspca - sonixj: Same init for all bridges but the sn9c102p gspca - sonixj: Set both pins for infrared of mt9v111 webcams gspca - sonixj, zc3xx: Let some bandwidth for audio when USB 1.1 gspca - ov534: Use the new control mechanism gspca - ov534: Add the webcam 06f8:3002 and sensor ov767x gspca - ov534: Add saturation control for ov767x gspca - sonixj: The pin S_PWR_DN is inverted for sensor mi0360 gspca - ov519: Add the sensor ov2610ae gspca - ov519: Add the 800x600 resolution for sensors ov2610/2610ae Documentation/video4linux/gspca.txt |1 + drivers/media/video/gspca/ov519.c | 90 +++- drivers/media/video/gspca/ov534.c | 980 +-- drivers/media/video/gspca/sonixj.c | 353 - drivers/media/video/gspca/zc3xx.c |4 + 5 files changed, 912 insertions(+), 516 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] v4l-utils: Add the JPEG Lite decoding function
Hi Hans, I got the permission to relicense the JPEG Lite decoding to the LGPL. If you want to test the nw80x driver, get the gspca tarball from my web page (2.12.12). I added your webcam which should directly work (p35u - chip nw801). Best regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ jpgl.pat Description: Binary data
[GIT PATCHES FOR 2.6.39] gspca for_v2.6.39
The following changes since commit 41f3becb7bef489f9e8c35284dd88a1ff59b190c: [media] V4L DocBook: update V4L2 version (2011-03-11 18:09:02 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.39 Hans de Goede (1): gspca - sonixb: Update inactive flags to reflect autogain setting Jean-François Moine (9): gspca - zc3xx: Remove double definition gspca - zc3xx: Cleanup source gspca: New file autogain_functions.h gspca - sonixb: Use the new control mechanism gspca - sonixb: Clenup source gspca - jeilinj / stv06xx: Fix some warnings gspca - ov519: Add exposure and autogain controls for ov2610/2610ae gspca - main: Cleanup source gspca - nw80x: New subdriver for Divio based webcams Documentation/video4linux/gspca.txt|9 + drivers/media/video/gspca/Kconfig |9 + drivers/media/video/gspca/Makefile |2 + drivers/media/video/gspca/autogain_functions.h | 179 ++ drivers/media/video/gspca/gspca.c | 13 +- drivers/media/video/gspca/jeilinj.c|2 - drivers/media/video/gspca/nw80x.c | 2443 drivers/media/video/gspca/ov519.c | 120 +- drivers/media/video/gspca/sonixb.c | 306 ++-- drivers/media/video/gspca/stv06xx/stv06xx.c|2 - drivers/media/video/gspca/zc3xx-reg.h |2 - drivers/media/video/gspca/zc3xx.c | 48 +- include/linux/videodev2.h |1 + 13 files changed, 2888 insertions(+), 248 deletions(-) create mode 100644 drivers/media/video/gspca/autogain_functions.h create mode 100644 drivers/media/video/gspca/nw80x.c -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.39] gspca for_v2.6.39
The following changes since commit d2803205ff3be8e8ea4634709799606c5d5294b5: [media] via-camera: Fix OLPC serial check (2011-03-21 21:48:25 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.39 Jean-François Moine (9): gspca - nw80x: Cleanup source gspca - nw80x: The webcam dsb-c110 is the same as the twinkle gspca - nw80x: Do some initialization at probe time gspca - nw80x: Fix the gain, exposure and autogain gspca - nw80x: Check the bridge from the webcam type gspca - nw80x: Fix some image resolutions gspca - nw80x: Get the sensor ID when bridge et31x110 gspca - nw80x: Fix exposure for some webcams gspca - zc3xx: Add exposure control for sensor hv7131r Patrice Chotard (1): gspca - main: Add endpoint direction test in alt_xfer drivers/media/video/gspca/gspca.c |3 +- drivers/media/video/gspca/nw80x.c | 858 - drivers/media/video/gspca/zc3xx.c | 76 +++- 3 files changed, 351 insertions(+), 586 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] pwc: Handle V4L2_CTRL_FLAG_NEXT_CTRL in queryctrl
Signed-off-by: Jean-François Moine moin...@free.fr
---
drivers/media/video/pwc/pwc-v4l.c | 23 +--
1 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/pwc/pwc-v4l.c
b/drivers/media/video/pwc/pwc-v4l.c
index aa87e46..f85c512 100644
--- a/drivers/media/video/pwc/pwc-v4l.c
+++ b/drivers/media/video/pwc/pwc-v4l.c
@@ -379,8 +379,27 @@ static int pwc_s_input(struct file *file, void *fh,
unsigned int i)
static int pwc_queryctrl(struct file *file, void *fh, struct v4l2_queryctrl *c)
{
- int i;
-
+ int i, idx;
+ u32 id;
+
+ id = c-id;
+ if (id V4L2_CTRL_FLAG_NEXT_CTRL) {
+ id = V4L2_CTRL_ID_MASK;
+ id++;
+ idx = -1;
+ for (i = 0; i ARRAY_SIZE(pwc_controls); i++) {
+ if (pwc_controls[i].id id)
+ continue;
+ if (idx = 0
+ pwc_controls[i].id pwc_controls[idx].id)
+ continue;
+ idx = i;
+ }
+ if (idx 0)
+ return -EINVAL;
+ memcpy(c, pwc_controls[idx], sizeof pwc_controls[0]);
+ return 0;
+ }
for (i = 0; i sizeof(pwc_controls) / sizeof(struct v4l2_queryctrl);
i++) {
if (pwc_controls[i].id == c-id) {
PWC_DEBUG_IOCTL(ioctl(VIDIOC_QUERYCTRL) found\n);
--
1.7.4.1
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40
The following changes since commit d58307d6a1e2441ebaf2d924df4346309ff84c7d: [media] anysee: add more info about known board configs (2011-04-19 10:35:37 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.40 Antonio Ospite (2): Add Y10B, a 10 bpp bit-packed greyscale format. gspca - kinect: New subdriver for Microsoft Kinect Jean-François Moine (1): gspca - zc3xx: Adjust the mc501cb exchanges Patrice Chotard (5): gspca - jeilinj: suppress workqueue gspca - jeilinj: use gspca_dev-usb_err to forward error to upper layer gspca - jeilinj: add 640*480 resolution support gspca - jeilinj: Add SPORTSCAM_DV15 camera support gspca - jeilinj: add SPORTSCAM specific controls Documentation/DocBook/media-entities.tmpl |1 + Documentation/DocBook/v4l/pixfmt-y10b.xml | 43 +++ Documentation/DocBook/v4l/pixfmt.xml |1 + Documentation/DocBook/v4l/videodev2.h.xml |3 + Documentation/video4linux/gspca.txt |1 + drivers/media/video/gspca/Kconfig |9 + drivers/media/video/gspca/Makefile|2 + drivers/media/video/gspca/jeilinj.c | 581 - drivers/media/video/gspca/kinect.c| 427 + drivers/media/video/gspca/zc3xx.c | 42 +-- include/linux/videodev2.h |3 + 11 files changed, 905 insertions(+), 208 deletions(-) create mode 100644 Documentation/DocBook/v4l/pixfmt-y10b.xml create mode 100644 drivers/media/video/gspca/kinect.c -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: gspca_zc3xx (HV7131R sensor) driver brocken
On Sun, 8 May 2011 13:37:52 +0200 Roman B. rbys...@gmail.com wrote: since the upgrade of the kernel to 2.6.37.1 my webcamera (046d:08d7 Logitech, Inc. QuickCam Communicate STX) is brocken. The problem is exactly the same as in this bug report: https://bugzilla.kernel.org/show_bug.cgi?id=24242 The problem of contrast seems to dissapear in the new 2.6.39-rc4 kernel, but that time the camera response is brocken. I'm not sure how to technically describe it correctly. I think the fps is very slow, causing a slight movement of the object create ugly picture where everything is blurred. I would be very glad to get my camera back working, as it was before. (I'm just wondering why should one change something at all... ) I suppose the maintainer of the gspca driver is Jean-Francois Moine. However he seems not to react to the bugs in bugzilla. The simple search [snip] Hi Roman, Right, I am so busy that I never look at bugzilla! Why do bugs appear in zc3xx? This subdriver handles more than one hundred webcams. Most of the treatment was inherited from the gspca v1 by Michel Xhaard who gave me the sources and let me alone without any information. In zc3xx, many webcams are driven by sequences copied from ms-windows USB traces and it is not easy to add them standard controls such as light frequency filtering. My fault, sometimes, I am too sure of a change and it goes into a kernel without test. I am a bit more careful now, and I have about 10 fixes which are waiting for testers.. Otherwise, it seems that the contast problem #24242 was fixed (see commit 3d244065cb8764e). But I did not know about this fps problem. May you get the last gspca test version from my web site and do a usbmon trace? (I need the webcam connection up to no more than 1 second of streaming) Regards. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40
The following changes since commit f9b51477fe540fb4c65a05027fdd6f2ecce4db3b: [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.40 Jean-François Moine (10): gspca - cpia1: Fix some warnings. gspca - kinect: Remove __devinitdata gspca - stk014 / t613: Accept the index 0 in querymenu gspca - main: Version change to 2.13 gspca - main: Remove USB traces gspca - cpia1: Remove a bad conditional compilation instruction gspca: Unset debug by default gspca: Fix some warnings tied to 'no debug' gspca - sunplus: Simplify code and fix some warnings gspca - sunplus: Simplify code and fix some errors when 'debug' drivers/media/video/gspca/cpia1.c |6 +-- drivers/media/video/gspca/gl860/gl860.c | 15 + drivers/media/video/gspca/gspca.c |4 +- drivers/media/video/gspca/gspca.h |6 +- drivers/media/video/gspca/kinect.c |2 +- drivers/media/video/gspca/spca508.c |5 +- drivers/media/video/gspca/stk014.c | 15 ++--- drivers/media/video/gspca/sunplus.c | 99 ++ drivers/media/video/gspca/t613.c| 17 ++ drivers/media/video/gspca/zc3xx.c |5 +- 10 files changed, 61 insertions(+), 113 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40
The following changes since commit f9b51477fe540fb4c65a05027fdd6f2ecce4db3b: [media] DVB: return meaningful error codes in dvb_frontend (2011-05-09 05:47:20 +0200) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.40 Jean-François Moine (9): gspca - cpia1: Fix some warnings. gspca - kinect: Remove __devinitdata gspca - stk014 / t613: Accept the index 0 in querymenu gspca - main: Version change to 2.13 gspca - main: Remove USB traces gspca - cpia1: Remove a bad conditional compilation instruction gspca: Unset debug by default gspca: Fix some warnings tied to 'no debug' gspca - sunplus: Fix some warnings and simplify code drivers/media/video/gspca/cpia1.c |6 +-- drivers/media/video/gspca/gl860/gl860.c | 15 + drivers/media/video/gspca/gspca.c |4 +- drivers/media/video/gspca/gspca.h |6 +- drivers/media/video/gspca/kinect.c |2 +- drivers/media/video/gspca/spca508.c |5 +- drivers/media/video/gspca/stk014.c | 15 ++--- drivers/media/video/gspca/sunplus.c | 99 ++ drivers/media/video/gspca/t613.c| 17 ++ drivers/media/video/gspca/zc3xx.c |5 +- 10 files changed, 61 insertions(+), 113 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH FOR 2.6.39] gspca - ov519: Fix a regression for ovfx2 webcams
By git commit c42cedbb658b, the bulk transfer size was changed to a lower
value for resolutions != 1600x1200, but the image extraction routine still
worked with the previous value, giving bad truncated images.
Signed-off-by: Jean-François Moine moin...@free.fr
---
drivers/media/video/gspca/ov519.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/gspca/ov519.c
b/drivers/media/video/gspca/ov519.c
index 36a46fc..5ac2f3c 100644
--- a/drivers/media/video/gspca/ov519.c
+++ b/drivers/media/video/gspca/ov519.c
@@ -4478,7 +4478,7 @@ static void ovfx2_pkt_scan(struct gspca_dev *gspca_dev,
gspca_frame_add(gspca_dev, INTER_PACKET, data, len);
/* A short read signals EOF */
- if (len OVFX2_BULK_SIZE) {
+ if (len gspca_dev-cam.bulk_size) {
/* If the frame is short, and it is one of the first ones
the sensor and bridge are still syncing, so drop it. */
if (sd-first_frame) {
--
1.7.5.1
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH FOR 2.6.39] gspca - ov519: Change the ovfx2 bulk transfer size
The 'normal' bulk transfer size did not work for 800x600.
By git commit c42cedbb658b, this 'normal' size was used for 1600x1200 only.
It will now be used back again for all resolutions but 800x600.
Signed-off-by: Jean-François Moine moin...@free.fr
---
drivers/media/video/gspca/ov519.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/gspca/ov519.c
b/drivers/media/video/gspca/ov519.c
index 5ac2f3c..caf438a 100644
--- a/drivers/media/video/gspca/ov519.c
+++ b/drivers/media/video/gspca/ov519.c
@@ -609,7 +609,7 @@ static const struct v4l2_pix_format ovfx2_ov3610_mode[] = {
* buffers, there are some pretty strict real time constraints for
* isochronous transfer for larger frame sizes).
*/
-/*jfm: this value works well for 1600x1200, but not 800x600 - see isoc_init */
+/*jfm: this value does not work for 800x600 - see isoc_init */
#define OVFX2_BULK_SIZE (13 * 4096)
/* I2C registers */
@@ -3511,7 +3511,7 @@ static int sd_isoc_init(struct gspca_dev *gspca_dev)
switch (sd-bridge) {
case BRIDGE_OVFX2:
- if (gspca_dev-width == 1600)
+ if (gspca_dev-width != 800)
gspca_dev-cam.bulk_size = OVFX2_BULK_SIZE;
else
gspca_dev-cam.bulk_size = 7 * 4096;
--
1.7.5.1
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 2.6.40] gspca for_v2.6.40
The following changes since commit 87cf028f3aa1ed51fe29c36df548aa714dc7438f: [media] dm1105: GPIO handling added, I2C on GPIO added, LNB control through GPIO reworked (2011-05-21 11:10:28 -0300) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git for_v2.6.40 Jean-François Moine (6): gspca - ov519: Fix a regression for ovfx2 webcams gspca - ov519: Change the ovfx2 bulk transfer size gspca: Remove coarse_expo_autogain.h gspca - stv06xx: Set a lower default value of gain for hdcs sensors gspca - ov519: New sensor ov9600 with bridge ovfx2 gspca - ov519: Set the default frame rate to 15 fps drivers/media/video/gspca/coarse_expo_autogain.h | 116 - drivers/media/video/gspca/ov519.c| 117 ++--- drivers/media/video/gspca/stv06xx/stv06xx_hdcs.h |2 +- 3 files changed, 101 insertions(+), 134 deletions(-) delete mode 100644 drivers/media/video/gspca/coarse_expo_autogain.h -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Make nchg variable signed because the code compares this variable against negative values.
On Wed, 25 May 2011 21:07:17 -0300
Mauro Carvalho Chehab mche...@redhat.com wrote:
This patch looks ok to me, although the description is not 100%.
The sonixj driver compares the value for nchg with
if (sd-nchg -6 || sd-nchg = 12) {
With u8, negative values won't work.
Please check.
Hi Mauro and Hans Petter,
With all the messages in the list, I did not noticed this patch.
Indeed, the fix is correct. I was wondering why there were still
problems with the image size in sonixj. They should disappear now.
Thanks.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG
On Wed, 25 May 2011 17:34:32 -0400
Jarod Wilson ja...@redhat.com wrote:
diff --git a/drivers/media/video/gspca/kinect.c
b/drivers/media/video/gspca/kinect.c
index 66671a4..26fc206 100644
--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -34,7 +34,7 @@ MODULE_AUTHOR(Antonio Ospite osp...@studenti.unina.it);
MODULE_DESCRIPTION(GSPCA/Kinect Sensor Device USB Camera Driver);
MODULE_LICENSE(GPL);
-#ifdef DEBUG
+#ifdef GSPCA_DEBUG
int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
D_USBI | D_USBO | D_V4L2;
#endif
Hi Jarod,
Sorry, it is not the right fix. In fact, the variable gspca_debug must
not be defined in gspca subdrivers:
--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -34,11 +34,6 @@
MODULE_DESCRIPTION(GSPCA/Kinect Sensor Device USB Camera Driver);
MODULE_LICENSE(GPL);
-#ifdef DEBUG
-int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
- D_USBI | D_USBO | D_V4L2;
-#endif
-
struct pkt_hdr {
uint8_t magic[2];
uint8_t pad;
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PATCHES FOR 3.0] gspca jpgl
The following changes since commit c21fd1a8c68ce3f49b00caf10337169262cfb8ad: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6 (2011-05-21 00:13:03 -0700) are available in the git repository at: git://linuxtv.org/jfrancois/gspca.git jpgl Jean-François Moine (1): v4l: Documentation about the JPGL pixel format Documentation/DocBook/v4l/pixfmt.xml |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/14] Remove linux/version.h from most drivers/media
On Sun, 26 Jun 2011 13:06:20 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: drivers/media/video/gspca/gspca.c | 12 +++--- Hi Mauro, I could not find the gspca.c changes in your patch set. Cheers. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/14] Remove linux/version.h from most drivers/media
On Sun, 26 Jun 2011 15:55:08 -0300
Mauro Carvalho Chehab mche...@redhat.com wrote:
I'll move it to the right changeset at the version 2 of this series.
Hi Mauro,
I have some changes to the gspca.c patch
- the version must stay 2.12.0
- the 'info' may be simplified:
diff --git a/drivers/media/video/gspca/gspca.c
b/drivers/media/video/gspca/gspca.c
index e526aa3..1aa6ae2 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -24,7 +24,6 @@
#define MODULE_NAME gspca
#include linux/init.h
-#include linux/version.h
#include linux/fs.h
#include linux/vmalloc.h
#include linux/sched.h
@@ -51,11 +50,12 @@
#error DEF_NURBS too big
#endif
+#define DRIVER_VERSION_NUMBER 2.12.0
+
MODULE_AUTHOR(Jean-François Moine http://moinejf.free.fr);
MODULE_DESCRIPTION(GSPCA USB Camera Driver);
MODULE_LICENSE(GPL);
-
-#define DRIVER_VERSION_NUMBER KERNEL_VERSION(2, 12, 0)
+MODULE_VERSION(DRIVER_VERSION_NUMBER);
#ifdef GSPCA_DEBUG
int gspca_debug = D_ERR | D_PROBE;
@@ -1291,7 +1291,6 @@ static int vidioc_querycap(struct file *file, void *priv,
}
usb_make_path(gspca_dev-dev, (char *) cap-bus_info,
sizeof(cap-bus_info));
- cap-version = DRIVER_VERSION_NUMBER;
cap-capabilities = V4L2_CAP_VIDEO_CAPTURE
| V4L2_CAP_STREAMING
| V4L2_CAP_READWRITE;
@@ -2478,10 +2477,7 @@ EXPORT_SYMBOL(gspca_auto_gain_n_exposure);
/* -- module insert / remove -- */
static int __init gspca_init(void)
{
- info(v%d.%d.%d registered,
- (DRIVER_VERSION_NUMBER 16) 0xff,
- (DRIVER_VERSION_NUMBER 8) 0xff,
- DRIVER_VERSION_NUMBER 0xff);
+ info(v DRIVER_VERSION_NUMBER registered);
return 0;
}
static void __exit gspca_exit(void)
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2 10/13] [media] gspca: don't include linux/version.h
On Mon, 27 Jun 2011 23:17:34 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: Instead of handling a per-driver driver version, use the per-subsystem one. As reviewed by Jean-Francois Moine moin...@free.fr: - the 'info' may be simplified: Reviewed-by: Jean-Francois Moine moin...@free.fr Acked-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Acked-by: Jean-Francois Moine moin...@free.fr -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] gspca/zc3xx: add usb_id for HP Premium Starter Cam
On Sat, 2 Jul 2011 10:07:41 +0200 Wolfram Sang w.s...@pengutronix.de wrote: On Wed, Jun 15, 2011 at 02:16:42PM +0200, Wolfram Sang wrote: Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- Ping. Who is picking this up? Anything to be done on my side? Sorry, I was a bit busy and I did not see your mail. May you add an entry in Documentation/video4linux/gspca.txt and resubmit? Thanks. Fixes https://bugzilla.kernel.org/show_bug.cgi?id=13479 drivers/media/video/gspca/zc3xx.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) [snip] -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
