Mauro,
On Wed, 26 May 2010 15:05:11 +0200, Jean Delvare wrote:
> IR support on FusionHDTV cards is broken since kernel 2.6.31. One side
> effect of the switch to the standard binding model for IR I2C devices
> was to let i2c-core do the probing instead of the ir-kbd-i2c driver.
>
The probe method used by i2c_new_probed_device() may not be suitable
for all cases. Let the caller provide its own, optional probe
function.
Signed-off-by: Jean Delvare
Acked-by: Mauro Carvalho Chehab
---
Documentation/i2c/instantiating-devices |2 +-
drivers/i2c/i2c-core.c
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.
Signed-off-by: Jean Delvare
Acked-by: Mauro Carvalho Chehab
---
drivers/i2c/i2c-core.c|7 +++
drivers/media/video/cx23885/cx23885-i2c.c |
Hi Wolfram,
On Wed, 9 Jun 2010 17:05:40 +0200, Wolfram Sang wrote:
> Hi Jean,
>
> On Tue, Jun 08, 2010 at 10:01:00AM +0200, Jean Delvare wrote:
> > Now that i2c-core offers the possibility to provide custom probing
> > function for I2C devices, let's make use of it.
&g
_each_drv() and from every
other function which raises this problem, or we must disable that new
type of warning gcc 4.6.0 generates. Depends which warnings we value
more, as we can't sanely have both.
> mutex_unlock(&core_lock);
>
> return 0;
--
Jean Delvare
--
To
don't want to install anything:
http://lxr.linux.no/linux
http://lxr.linux.no/#linux+v2.6.34/drivers/char/tpm/tpm.c#L451
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> firmware_revision = SBP2_ROM_VALUE_MISSING;
> model = ud->flags & UNIT_DIRECTORY_MODEL_ID ?
> ud->model_id : SBP2_ROM_VALUE_MISSING;
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi David,
On Mon, 14 Jun 2010 14:28:57 -0700, David Daney wrote:
> On 06/14/2010 01:53 PM, Jean Delvare wrote:
> > Hi Justin,
> >
> > On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
> >> could be a right solution, could be wrong
> >> here is t
Hi Justin,
On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
> On 06/14/2010 01:53 PM, Jean Delvare wrote:
> > Hi Justin,
> >
> > On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
> >> could be a right solution, could be wrong
> &
On Tue, 15 Jun 2010 09:20:39 -0700, David Daney wrote:
> On 06/15/2010 04:40 AM, Jean Delvare wrote:
> > __process_new_adapter() calls i2c_do_add_adapter() which always returns
> > 0. Why should I check the return value of bus_for_each_drv() when I
> > know it will always
disable IR support (coming soon.)
Signed-off-by: Jean Delvare
---
drivers/media/video/cx88/cx88-cards.c |1 +
drivers/media/video/cx88/cx88-i2c.c |6 +-
drivers/media/video/cx88/cx88.h |1 +
3 files changed, 7 insertions(+), 1 deletion(-)
--- linux-2.6.34-rc3.orig/drivers/media
It might be useful to be able to disable the IR support, either for
debugging purposes, or just for users who know they won't use the IR
remote control anyway. On many cards, IR support requires expensive
polling/sampling which is better avoided if never needed.
Signed-off-by: Jean De
he
> adapter lock is not released until the register read is done.
>
> Signed-off-by: Andy Walls
Good catch.
Acked-by: Jean Delvare
Note that cx25840_and_or() still has a (smaller and less dangerous)
race window. If several calls to cx25840_and_or() happen in parallel on
the same
On Tue, 20 Jul 2010 08:35:26 -0400, Andy Walls wrote:
> On Tue, 2010-07-20 at 08:42 +0200, Jean Delvare wrote:
> > Hi Andy,
> >
> > On Mon, 19 Jul 2010 21:11:46 -0400, Andy Walls wrote:
> > > There was a small window between writing the cx25840 register
> > &g
VIDEO_ADV7180 is listed twice in v4l/versions.txt: once in [2.6.31]
and once in [2.6.26]. As I have tested that it builds fine in 2.6.26,
drop the former entry.
Signed-off-by: Jean Delvare
---
v4l/versions.txt |1 -
1 file changed, 1 deletion(-)
--- v4l-dvb.orig/v4l/versions.txt 2010
pply, so it would be good to make sure it fixes your problem before
actually applying it.
Thanks!
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ke
Hi Mauro,
On Tue, 02 Feb 2010 17:09:05 -0200, Mauro Carvalho Chehab wrote:
> > From: Jean Delvare
> > Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants
> >
> > Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131
> > Analog (card
require a
> test of all
> the 107 boards that are on init1. I bet you'll break several of them with
> this change.
Under the assumption that saa7134_hwinit1() only touches GPIOs
connected to IR receivers (and it certainly looks like this to me) I
fail to see how these pins not being ini
On Wed, 10 Feb 2010 16:40:03 -0200, Mauro Carvalho Chehab wrote:
> Jean Delvare wrote:
> > Under the assumption that saa7134_hwinit1() only touches GPIOs
> > connected to IR receivers (and it certainly looks like this to me) I
> > fail to see how these pins not being initi
.
This fixes bug #15184:
http://bugzilla.kernel.org/show_bug.cgi?id=15184
Signed-off-by: Jean Delvare
---
As this fixes a regression, I suggest pushing to Linus quickly. This is
a candidate for 2.6.32-stable too.
linux/drivers/media/video/bt8xx/bttv-driver.c |1 +
linux/drivers/media/video
Add a new module parameter "disable_ir" to disable IR support. Several
other drivers do that already, and this can be very handy for
debugging purposes.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/bt8xx/bttv-driver.c |9 +++--
1 file changed, 7 insertions(+), 2
. The patch is really simple and I see no formatting issue. Should
I just resend it?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 24 Feb 2010 10:10:16 -0300, Mauro Carvalho Chehab wrote:
> Hi Jean,
>
> Jean Delvare wrote:
>
> > I have 3 patches pending which aren't in your list. I can see them in
> > patchwork:
> >
> > http://patchwork.kernel.org/patch/79755/
> > ht
.
>
> We can see, that even those always doing best on it, can't provide the
> missing informations for different LNA stuff after the
> Hauppauge/Pinnacle merge until now.
>
> If you claim to know it better, please share with us.
I'm not claiming anything, and to be hones
hes end of non-void function
>
> Signed-off-by: Márton Németh
Good catch.
Acked-by: Jean Delvare
Douglas, please apply quickly.
> ---
> diff -r 41c5482f2dac linux/drivers/media/video/bt8xx/bttv-i2c.c
> --- a/linux/drivers/media/video/bt8xx/bttv-i2c.c Thu Mar 04 02:49:46
> 2010
f just getting the command.
> Currently, em28xx-input has one I2C IR already changed to this mode (seek
> for full_code for the differences).
>
> You'll basically need to change the IR tables to contain address+command, and
> inform the used protocol (RC5/NEC) on it. The getkey functi
break;
>
None of my patches removed this statement, and IR_TYPE_NEC itself seems
to be new in kernel 2.6.33, so I admit I don't quite understand how I
my i2c changes could be responsible for the regression.
Anyway, glad that you managed to fix it.
--
Jean Delvare
--
To unsubscr
h the patch upstream without it, and if it takes too long,
I'll probably just discard the patch and move to other tasks.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info
.32.2 and test that the remote control works even
when _not_ passing any card parameter to the driver.
If you ever need to remove the patch, use:
$ cd ~/src/linux-2.6.32
$ patch -p2 -R <
~/download/saa7134-Fix-IR-support-of-some-ASUS-TV-FM-7135-variants.patch
I hope my instructions are cle
On Sun, 14 Mar 2010 20:34:34 +0100, Daro wrote:
> W dniu 14.03.2010 09:26, Jean Delvare pisze:
> > It will be easier with the kernel you compiled yourself. First of all,
> > download the patch from:
> > http://patchwork.kernel.org/patch/75883/raw/
> >
> > Then, mov
hat case, we'd need to use reads to detect it. The
i2c core doesn't give us enough control to do this cleanly, but this
could be added if the need exists. In the meantime, we can do the probe
ourselves and instantiate the device unconditionally (by using
i2c_new_device instead of i2c_new_pr
On Tue, 16 Mar 2010 12:05:02 +0100, Jean Delvare wrote:
> Executive summary (as I understand it): the card that no longer works
> is a DViCO FusionHDTV7 Dual Express
> (CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP), bridge driver cx23885. It
> has 2 xc5000 chips at I2C address 0x64 (on
so every actor can do the changes if/when they see fit.
> And why does coccinelle apparently find this in e.g. cs5345.c but not in
> saa7115.c, which has exactly the same construct? For that matter, I think
> almost all v4l i2c drivers do this.
That I can't say, sorry.
Hi Hans, Mark, Wolfram,
On Sun, 21 Mar 2010 17:09:56 +0100, Hans Verkuil wrote:
> On Sunday 21 March 2010 15:14:17 Mark Brown wrote:
> > On Sun, Mar 21, 2010 at 02:46:55PM +0100, Jean Delvare wrote:
> > > On Sat, 20 Mar 2010 23:02:49 +0100, Hans Verkuil wrote:
> >
>
Replying to myself...
On Sun, 21 Mar 2010 14:46:55 +0100, Jean Delvare wrote:
> I get the feeling that this would be a job for managed resources as
> some drivers already do for I/O ports and IRQs. Managed resources don't
> care about symmetry of allocation and freeing, by des
several programs in the i2c-tools package, which can be used to
this purpose:
* i2cdetect
* i2cdump
* i2cget
* i2cset
With these 4 tools, almost all SMBus transaction types are covered.
This is sufficient in most cases in my experience. If not, these tools
can certainly get extended, at
Can the fix below please be picked quickly? This is a regression, the
fix should go upstream ASAP. Thanks.
On Fri, 19 Mar 2010 14:42:50 +0100, Jean Delvare wrote:
> IR support on FusionHDTV cards is broken since kernel 2.6.31. One side
> effect of the switch to the standard binding model
.
Can't we have the cx88 driver poll the remote control only when the
device node is opened? I believe this would save some power by allowing
the CPU to stay in higher C states.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the bo
Hi Mauro,
On Wed, 31 Mar 2010 14:46:37 -0300, Mauro Carvalho Chehab wrote:
> Hi Jean,
>
> Jean Delvare wrote:
> > Hi Andrzej,
> >
> > Last year, you submitted a fix for the cx88 remote control not behaving
> > properly on some cards. The fix works fine for
The probe method used by i2c_new_probed_device() may not be suitable
for all cases. Let the caller provide its own, optional probe
function.
Signed-off-by: Jean Delvare
---
Documentation/i2c/instantiating-devices |2
drivers/i2c/i2c-core.c| 65
Now that i2c-core offers the possibility to provide custom probing
function for I2C devices, let's make use of it.
Signed-off-by: Jean Delvare
---
I wasn't too sure where to put the custom probe function: in each driver,
in the ir-common module or in the v4l2-common module. I went for
Hi Andy,
On Sun, 04 Apr 2010 21:54:39 -0400, Andy Walls wrote:
> On Sun, 2010-04-04 at 16:14 +0200, Jean Delvare wrote:
> > Now that i2c-core offers the possibility to provide custom probing
> > function for I2C devices, let's make use of it.
> >
> > Signed-off
Hi Mauro,
On Mon, 05 Apr 2010 15:26:32 -0300, Mauro Carvalho Chehab wrote:
> Jean Delvare wrote:
> > Now that i2c-core offers the possibility to provide custom probing
> > function for I2C devices, let's make use of it.
> >
> > Signed-off-by: Jean Delvare
> &
Hi Mauro,
On Tue, 06 Apr 2010 02:34:46 -0300, Mauro Carvalho Chehab wrote:
> Jean Delvare wrote:
> > On Mon, 05 Apr 2010 15:26:32 -0300, Mauro Carvalho Chehab wrote:
> >> Please, don't add new things at ir-common module. It basically contains the
> >> decoding func
Hi Mauro,
On Fri, 09 Apr 2010 01:09:08 -0300, Mauro Carvalho Chehab wrote:
> Jean Delvare wrote:
> > There are no other probing functions yet, this is the first one. I have
> > added the mechanism to i2c-core for these very IR chips.
> >
> > Putting all probe functions
> + struct hexium *hexium;
> int ret;
>
> DEB_EE((".\n"));
>
Looks correct.
Acked-by: Jean Delvare
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
support for SCI-based features of the OLPC XO-1 laptop:
- EC-driven system wakeups
>
> Signed-off-by: Randy Dunlap
> Reported-by: Johannes Berg
> Cc: Jean Delvare
> Cc: Tony Lindgren
> Cc: Grant Likely
> Signed-off-by: Luciano Coelho
> ---
>
> I guess t
FD_SUPPORT is not. -- Luca]
> >
> > Signed-off-by: Randy Dunlap
> > Reported-by: Johannes Berg
> > Cc: Jean Delvare
> > Cc: Tony Lindgren
> > Cc: Grant Likely
> > Signed-off-by: Luciano Coelho
> > ---
> >
> > I guess this should
es Digital Potentiometers"
> @@ -344,6 +328,12 @@ config ISL29020
> This driver can also be built as a module. If so, the module
> will be called isl29020.
>
> +config SENSORS_LIS3LV02D
> + tristate
> + depends on INPUT
> + select INPUT_POLLDEV
>
; config MFD_CORE
> tristate
I think I prefer Luciano's proposal, for the same reasons given for the
misc device drivers patch. But here again I'm not the one making the
decision, so it's up to Samuel to decide which patch he wants to apply.
--
Jean Delvare
--
To un
On Mon, 5 Sep 2011 16:19:35 +0200, Arnd Bergmann wrote:
> On Monday 05 September 2011, Jean Delvare wrote:
> > As said before, I'm not sure. Yes, it makes it easier to select misc
> > device drivers from Kconfig files. But it also makes it impossible to
> > deselect all m
debugging or
experimentation.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Commit a90f933507859941c4a58028d7593a80f57895c4 accidentally removed
the piece of code setting the i2c algo pointer. Restore it.
That's what happens when you put two code statements on the same
line...
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
---
Sorry about this, I didn
cial complexity that will make Kconfig almost
> unreadable.
>
> I still think that the easiest way to solve this is to add some logic that
> will
> hide the menu if a condition doesn't happen. Something like:
> menu FOO
> prompt if BAR
>
> or
>
code in question never
runs. As the code additionally expects that I2C_HW_B_HDPVR may not
be defined, we can delete it now and let the lirc_zilog driver
maintainer rewrite this piece of code.
Big thanks for Hans Verkuil for doing all the hard work :)
Signed-off-by: Jean Delvare
Cc: Hans
Drivers don't need to include , especially not when
they don't use anything that header file provides.
Signed-off-by: Jean Delvare
Cc: Michael Hunold
Cc: Mauro Carvalho Chehab
---
drivers/media/common/saa7146_i2c.c|1 -
drivers/media/video/ir-kbd-i2c.c |1 -
drive
It's about time to make it clear that i2c_adapter.id is deprecated.
Hopefully this will remind the last user to move over to a different
strategy.
Signed-off-by: Jean Delvare
Cc: Hans Verkuil
Cc: Jarod Wilson
---
drivers/i2c/i2c-mux.c |1 -
include/linux/i2c.h |2 +-
2 files ch
) and properly return error on adapter registration failure.
Signed-off-by: Jean Delvare
Cc: Michel Ludwig
Cc: Stefan Ringel
---
Untested, I don't have the hardware.
drivers/staging/tm6000/tm6000-i2c.c | 27 ++-
1 file changed, 10 insertions(+), 17 dele
Signed-off-by: Jean Delvare
Cc: Michel Ludwig
Cc: Stefan Ringel
---
drivers/staging/tm6000/tm6000-i2c.c | 12
1 file changed, 12 deletions(-)
--- linux-2.6.36-rc7.orig/drivers/staging/tm6000/tm6000-i2c.c 2010-10-13
10:30:09.0 +0200
+++ linux-2.6.36-rc7/drivers
LL;
This statement seems equally unneeded, maybe you could remove it too?
Unless you want to provide a separate patch for this, as there are 5
other drivers doing the same.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 13 Nov 2010 12:34:23 -0200, Mauro Carvalho Chehab wrote:
> Em 05-11-2010 18:07, Jean Delvare escreveu:
> > Drivers don't need to include , especially not when
> > they don't use anything that header file provides.
> >
> > Signed-off-by: Jean Delvare
Hi Wolfram,
Sorry for the late answer.
On Mon, 15 Nov 2010 23:28:15 +0100, Wolfram Sang wrote:
> On Wed, Nov 10, 2010 at 03:14:13PM +0100, Wolfram Sang wrote:
> > The i2c-core does this already.
> >
> > Reported-by: Jean Delvare
> > Signed-off-by: Wolfram Sang
&
hould be clarified soon
> (I've added Kamil to Cc).
Already clarified behind the scenes ;-) The patch should be discarded.
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> message or buffer arrays that contain only one element.
Please note that I resigned from my position of i2c subsystem
maintainer, so I will not handle this. If you think this is important,
you'll have to resubmit and Wolfram will decide what he wants to do
about it.
--
Jean Delvare
--
Hi Mauro,
Thanks for your reply.
On Thu, 08 Mar 2012 08:21:20 -0300, Mauro Carvalho Chehab wrote:
> Em 12-02-2012 08:19, Jean Delvare escreveu:
> > Reported by kmemleak.
> >
> > Signed-off-by: Jean Delvare
> > Cc: Mauro Carvalho Chehab
> > Cc: Devin Heitmuell
On Mon, 12 Mar 2012 07:28:02 -0300, Mauro Carvalho Chehab wrote:
> Em 12-03-2012 07:04, Jean Delvare escreveu:
> > "!d" can't actually happen, so it doesn't matter. d is passed by
> > dib0700_rc_setup() when calling usb_fill_bulk_urb(), and
> > dib0700_rc_s
L or the
driver would crash right away.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
Cc: Devin Heitmueller
---
Devin, am I missing something?
drivers/media/dvb/dvb-usb/dib0700_core.c |3 ---
1 file changed, 3 deletions(-)
--- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_co
Reported by kmemleak.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
Cc: Devin Heitmueller
---
Changes since v1:
* Don't free the URB when it is still in use.
* Fix a second leak (transfer_buffer).
drivers/media/dvb/dvb-usb/dib0700_core.c |7 ++-
1 file changed, 6 inser
Hi Mauro,
On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote:
> On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare wrote:
> > --- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_core.c
> > 2012-03-13 11:09:13.0 +0100
> > +++ linux-3.3-rc7/driv
Hi Mauro,
On Tue, 20 Mar 2012 09:17:54 -0300, Mauro Carvalho Chehab wrote:
> Em 20-03-2012 04:20, Jean Delvare escreveu:
> > On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote:
> >> Yet, I'd be more happy if Jean's patch could check first if the status
DIV_ROUND_CLOSEST is faster if the compiler knows it will only be
dealing with unsigned dividends.
Signed-off-by: Jean Delvare
Cc: Andrew Morton
Cc: Guenter Roeck
Cc: Mauro Carvalho Chehab
---
drivers/media/rc/mceusb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.6
The Terratec Cinergy T PCIe Dual is based on the CX23885, and uses
MT2063, DRX-3913k and DRX-3916k chips, so select the relevant drivers.
Signed-off-by: Jean Delvare
Cc: Stefan Ringel
Cc: Mauro Carvalho Chehab
---
drivers/media/video/cx23885/Kconfig |2 ++
1 file changed, 2 insertions
Hi Mauro,
On Tue, 18 Sep 2012 12:49:53 -0300, Mauro Carvalho Chehab wrote:
> Em 01-09-2012 15:53, Jean Delvare escreveu:
> > DIV_ROUND_CLOSEST is faster if the compiler knows it will only be
> > dealing with unsigned dividends.
> >
> > Signed-off-by: Jean Delvare
&g
Module parameter descriptions need not be terminated with a newline.
Signed-off-by: Jean Delvare
Cc: Hans Verkuil
Cc: Mauro Carvalho Chehab
---
drivers/media/i2c/sony-btf-mpx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.10-rc1.orig/drivers/media/i2c/sony-btf-mpx.c
Improvements to dvb-apps/femon:
* femon: Share common code
* femon: Display SNR in dB
* femon: Handle -EOPNOTSUPP
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
;C' : ' ',
- fe_info.viterbi ? 'V' : ' ',
- fe_info.sync ? 'Y' : ' ',
- fe_info.lock ? 'L' : ' ',
+ printf ("signal %04x | snr %04x | ber %08x | unc %08x |
",
fe_info.ucblocks);
} else {
printf ("signal %04x | snr %04x | ber %08x | unc %08x |
",
fe_info.signal_strength,
--
Jean Delvare
--
To unsubscribe from this list: send the li
else
+ printf ("snr | ");
+ if (got_info & DVBFE_INFO_BER)
+ printf ("ber %08x | ", fe_info.ber);
+ else
+ printf ("ber | ");
+ if (got_info & DVBFE_INFO_UNCORRECTED_BLOCKS)
+ printf ("unc %08x | ", fe_info.ucblocks);
+ else
+ printf ("unc | ");
}
if (fe_info.lock)
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
self won't care, it just passes the request down to the
underlying i2c bus driver. Most driver implementations will assume
proper buffer addresses as soon as size > 0, so passing NULL instead
would crash them. In short, don't do that.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
y for not having seen that. I can do that.
Eek, no, you can't, not in the general case at least. sizeof(*val) will
return the size of the _first_ element of the destination buffer, which
has nothing to do with the length of that buffer (which in turn might
be rightfully longer than the read lengt
ove.
I am not opposed to the idea of i2c_msg initialization helper macros,
but please don't mix that with actual code changes which could have bad
side effects.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a m
er to use isn't at the top of my priority list. And
I see the extra work for the pre-processor, so we need a good reason
for doing that.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
at
the device is supported since kernel 2.6.26, which looks promising.
However, before I actually buy it, I would love to hear from someone
actually using this device under Linux. Anyone? Is there anything to
worry about, or can I just buy it?
Thanks,
--
Jean Delvare
--
To unsubscribe from this l
Reported by kmemleak.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
Cc: Devin Heitmueller
---
I am not familiar with the usb API, are we also supposed to call
usb_kill_urb() in the error case maybe?
drivers/media/dvb/dvb-usb/dib0700_core.c |2 ++
1 file changed, 2 insertions
.
In practice I get 67% with my antenna fully amplified and 51% with
no amplification. This is close enough to what I get on my other
DVB-T adapter with the same antenna.
Signed-off-by: Jean Delvare
Cc: Steven Toth
---
This was written without a datasheet so this is essentially
guess work.
dr
and unlocking are
taking place inside i2c_transfer(), not at its boundaries. I'm looking
into this now.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
messages are logged. We don't want to log messages while
holding a rt_mutex.
* No check is done on the existence of adap->algo->master_xfer. It
is thus the caller's responsibility to ensure that the function is
OK to call.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
i2c_smbus_read_word_data(client, reg);
> - return data < 0 ? data : swab16(data);
> + return i2c_smbus_read_word_swapped(client, reg);
> +
Stray blank line.
> }
> (...)
Other than this, looks all OK:
Acked-by: Jean Delvare
Obviously depends on the i2c patch, which will go upstr
art
As far as I can tell, this fixes a bug too, the original code would not
work on big-endian machines.
Acked-by: Jean Delvare
> ---
> drivers/media/video/mt9p031.c |5 ++---
> drivers/media/video/mt9t001.c |5 ++---
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
e, decoder or the like.
So let's simply get rid of the broken and useless code.
I'm also adding I2C_FUNC_I2C, as the driver and hardware support plain
I2C messaging.
[1] http://marc.info/?l=linux-i2c&m=117499415208244&w=2
Signed-off-by: Jean Delvare
---
drivers/media/video/usbv
i's proposal share the idea of storing information
about the device capabilities (max block read and write lengths, but we
could also put there alignment requirements or support for repeated
start condition.) in a private structure. If we generalize the
functions then this information would have t
plitting block reads in continuous
chunks won't always work either. Which makes some sense if you think
about it: if both the slave and the controller supported larger blocks
then there would be no need to split the transfer into multiple
messages in the first place.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
" from all drivers, to avoid any confusion. This
is the best way to ensure that the comments won't go out of sync
again. Anyone interested in the implementation details would rather
look at the code itself.
Signed-off-by: Jean Delvare
---
drivers/media/video/au0828/au0828-i2c.c |
ystems need something similar then
we can consider moving the code to i2c-core or some generic i2c helper
module.
If you count on me to drive it, I am afraid it will take months, given
my current workload and various tasks with a much higher priority than
this. I will however be happy to help with
On Wed, 09 Nov 2011 10:02:08 -0200, Mauro Carvalho Chehab wrote:
> Em 09-11-2011 08:37, Jean Delvare escreveu:
> > Speaking of struct i2c_client, I seem to remember that the dvb
> > subsystem doesn't use it much at the moment. This might be an issue if
> > you intend to
Hi Antti,
As an additional note, it just occurred to me that what you are working
on is somewhat related to Mark Brown's regmap. Look in
drivers/base/regmap and see if maybe you can reuse and/or extend Mark's
approach.
--
Jean Delvare
--
To unsubscribe from this list: send the line &q
I tried with kernels 3.4.30, 3.5.7, 3.6.0, 3.6.11, 3.7.10 and 3.8.2, with
exactly the same results.
How would I debug this further?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, powered antenna causes that kind of issue?
Oliver, out of curiosity, what antenna are you using? The
Terratec-provided one, or another one?
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
I would like to see these statistics improved. I am willing to help,
however the drxk driver is rather complex (at least to my eyes) and I
do not have a datasheet so I wouldn't know where to start. Is there
anyone who can work on this and/or provide some guidance?
Thanks,
--
Jean Delvare
Hi Oliver,
On Wed, 06 Mar 2013 19:07:01 +0100, Oliver Schinagl wrote:
> On 03/06/13 16:03, Jean Delvare wrote:
> > It turns out that my problem is the antenna. I was using the antenna I
> > have been using with my previous card, which is an internal DVB-T
> > antenna with am
201 - 300 of 369 matches
Mail list logo
