Use dev_err instead of pt1_printk
o reduce object code size
o remove now unused pt1_printk macro
Neaten dev_level uses in pt3
o add missing newlines
o align arguments
o remove unnecessary OOM messages as there's a generic one
o typo fixes in messages
Signed-off-by: Joe Perches j...@perches.com
On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote:
Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall amber.rose.thr...@gmail.com
escreveu:
Fixed various coding style issues, including strings over 80 characters
long and many
deprecated printk's have been replaced with proper
On Fri, 2014-10-03 at 02:58 +0300, Antti Palosaari wrote:
On 10/02/2014 07:45 PM, Joe Perches wrote:
On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote:
Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall
amber.rose.thr...@gmail.com escreveu:
Fixed various coding style issues
No caller or macro uses the return value so make it void.
Signed-off-by: Joe Perches j...@perches.com
---
This change is associated to a desire to eventually
change printk to return void.
drivers/media/tuners/tda18271-common.c | 19 ---
drivers/media/tuners/tda18271-priv.h
On Mon, 2014-08-11 at 02:11 +0530, Suman Kumar wrote:
Fixes a coding style issue of 'lines over 80 char' reported by
checkpatch.pl
[]
diff --git a/drivers/media/platform/soc_camera/soc_camera.c
b/drivers/media/platform/soc_camera/soc_camera.c
[]
@@ -1430,7 +1434,7 @@ static int
On Mon, 2014-08-04 at 13:40 +0300, Dan Carpenter wrote:
On Mon, Aug 04, 2014 at 12:17:14PM +0200, Martin Kepplinger wrote:
[]
+ if (dev) {
+ dev_dbg(dev-bus_adap.usb_dev-dev,
+ tuner parameters: freq: %d bw: 0x%02x gi: 0x%02x\n,
+
On Thu, 2014-07-10 at 12:50 +0300, Andy Shevchenko wrote:
I have considered to modify hex_dump_to_buffer() to return how many
bytes it actually proceed to the buffer. In that case we can directly
print to m-buf like other seq_foo calls do.
But I still have doubts about it. Any opinion?
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote:
Instead of custom approach let's use recently introduced seq_hex_dump()
helper.
Doesn't this also change the output from
to
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote:
This introduces a new helper and switches current users to use it.
While seq_print_hex_dump seems useful, I'm not sure
existing forms can be changed to use it if any output
content changes.
seq_ is supposed to be a stable API.
--
To
On Wed, 2014-07-09 at 22:39 +0200, Marek Vasut wrote:
The above function looks like almost verbatim copy of print_hex_dump(). The
only
difference I can spot is that it's calling seq_printf() instead of printk().
Can
you not instead generalize print_hex_dump() and based on it's invocation,
:
if (bar())
goto err;
break;
}
Signed-off-by: Joe Perches j...@perches.com
---
AFAIK there's still no automatic detection of those cases.
There can be now...
scripts/checkpatch.pl | 10 ++
1 file changed, 10 insertions(+)
diff
Remove the now unnecessary memset too.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/common/saa7146/saa7146_core.c | 15 ++-
drivers/media/common/saa7146/saa7146_fops.c | 5 +++--
drivers/media/pci/bt8xx/bt878.c | 16
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel.
Done with a simple cocci script and some typing.
Joe Perches (22):
pci-dma-compat: Add pci_zalloc_consistent helper
atm: Use
On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote:
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote:
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel
On Sat, 2014-06-07 at 16:41 +0200, Salva Peiró wrote:
After the zeroing the whole struct struct media_entity_desc u_ent,
it is no longer necessary to memset(0) its u_ent.name field.
trivia:
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
[]
@@ -106,8 +106,6 @@ static
On Sat, 2014-05-24 at 20:47 +0200, Manuel Schölling wrote:
To be future-proof and for better readability the time comparisons are
modified to use time_before_eq() instead of plain, error-prone math.
A couple of unrelated, trivial notes: (repeated a few times)
diff --git
On Thu, 2014-03-06 at 11:55 +0100, Laurent Pinchart wrote:
We thus need the #define DEBUG it appear before the first time device.h is
included, either directly or indirectly. Adding #define DEBUG to iss.h won't
work now as iss.h is included after all system includes (which is the usual
On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote:
Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define
CONFIG_DEBUG'. 'DEBUG' needs to be defined for dev_dbg() to have any effect.
Not quite. If CONFIG_DYNAMIC_DEBUG is set, these
dev_dbg statements are compiled
On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
Would you recommend to drop driver-specific Kconfig options related to
debugging and use CONFIG_DYNAMIC_DEBUG instead ?
For development, sure, if there's sufficient memory.
For embedded systems with limited memory, using
dynamic_debug
On Thu, 2014-03-06 at 02:27 +0100, Laurent Pinchart wrote:
On Wednesday 05 March 2014 17:00:37 Joe Perches wrote:
On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
Would you recommend to drop driver-specific Kconfig options related to
debugging and use CONFIG_DYNAMIC_DEBUG
On Thu, 2014-03-06 at 02:52 +0100, Laurent Pinchart wrote:
Hi again Laurent
I've thought about that, but it would require iss.h to be included before all
other headers. I've also thought about creating an iss-debug.h header to be
included first just to #define DEBUG, but decided to go for
On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote:
dev_*() assumes 'go' is already initialized, so need use pr_*() instead
of before 'go' initialized.
[]
diff --git a/drivers/staging/media/go7007/go7007-usb.c
b/drivers/staging/media/go7007/go7007-usb.c
[]
@@ -1057,7 +1057,7 @@ static int
Joe Perches (8):
Documentation: Remove OOM message after input_allocate_device
cell: Remove OOM message after input_allocate_device
hid: Remove OOM message after input_allocate_device
input: Remove OOM message after input_allocate_device
media: Remove OOM message after
Emitting an OOM message isn't necessary after input_allocate_device
as there's a generic OOM and a dump_stack already done.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/rc/imon.c | 8 ++--
drivers/media/usb/em28xx/em28xx-input.c | 4 +---
drivers/media/usb
These aren't necessary after switch and while statements.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/common/b2c2/flexcop-sram.c | 6 +++---
drivers/media/dvb-frontends/cx24110.c| 2 +-
drivers/media/dvb-frontends/cx24123.c| 2 +-
drivers/media
On Tue, 2013-09-24 at 14:52 +0200, Tomasz Stanislawski wrote:
On 09/23/2013 07:44 PM, Joe Perches wrote:
On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote:
On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote:
May I ask what is the rationale for this patch
On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote:
On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote:
May I ask what is the rationale for this patch?
To reduce a few lines of code?
This patch makes source code more generic-like and easier to follow (mxd_r*
On Mon, 2013-09-16 at 16:37 -0700, Kees Cook wrote:
Make sure that a format string cannot accidentally leak into the printk
buffer.
[]
diff --git a/drivers/media/dvb-frontends/dib9000.c
b/drivers/media/dvb-frontends/dib9000.c
[]
@@ -649,7 +649,7 @@ static int dib9000_risc_debug_buf(struct
Convert the uses mac addresses to ETH_ALEN so
it's easier to find and verify where mac addresses
need to be __aligned(2)
Change from initial submission:
- Remove include/acpi/actbl2.h conversion
It's a file copied from outside ACPI sources
Joe Perches (3):
uapi: Convert some uses of 6
It's convenient to have ethernet mac addresses use
ETH_ALEN to be able to grep for them a bit easier and
also to ensure that the addresses are __aligned(2).
Add #include linux/if_ether.h as necessary.
Signed-off-by: Joe Perches j...@perches.com
Acked-by: Mauro Carvalho Chehab m.che
)
Just note that it's unaligned.
Joe Perches (3):
uapi: Convert some uses of 6 to ETH_ALEN
include: Convert ethernet mac address declarations to use ETH_ALEN
ethernet: Convert mac address uses of 6 to ETH_ALEN
drivers/net/ethernet/8390/ax88796.c| 4 +-
drivers/net
It's convenient to have ethernet mac addresses use
ETH_ALEN to be able to grep for them a bit easier and
also to ensure that the addresses are __aligned(2).
Add #include linux/if_ether.h as necessary.
Signed-off-by: Joe Perches j...@perches.com
Acked-by: Mauro Carvalho Chehab m.che
On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote:
On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote:
It's convenient to have ethernet mac addresses use
ETH_ALEN to be able to grep for them a bit easier and
also to ensure that the addresses are __aligned(2).
[]
diff --git
It's convenient to have ethernet mac addresses use
ETH_ALEN to be able to grep for them a bit easier and
also to ensure that the addresses are __aligned(2).
Add #include linux/if_ether.h as necessary.
Signed-off-by: Joe Perches j...@perches.com
---
include/acpi/actbl2.h | 4
Convert the uses mac addresses to ETH_ALEN so
it's easier to find and verify where mac addresses
need to be __aligned(2)
Joe Perches (3):
uapi: Convert some uses of 6 to ETH_ALEN
include: Convert ethernet mac address declarations to use ETH_ALEN
ethernet: Convert mac address uses of 6
On Tue, 2013-07-23 at 00:16 +0300, Antti Palosaari wrote:
On 07/22/2013 03:15 AM, Joe Perches wrote:
commit d7104bffcfb ([media] MAINTAINERS: add drivers/media/tuners/it913x*)
used the incorrect file patterns. Fix it.
[]
Acked-by: Antti Palosaari cr...@iki.fi
PS. It wasn't that commit
On Thu, 2013-07-18 at 20:59 +0530, Prabhakar Lad wrote:
Use the dev_* message logging API instead of raw printk.
[]
diff --git a/drivers/media/platform/davinci/vpbe.c
b/drivers/media/platform/davinci/vpbe.c
[]
@@ -595,7 +595,7 @@ static int vpbe_initialize(struct device *dev, struct
On Sat, 2013-07-13 at 14:20 +0530, Prabhakar Lad wrote:
Use the dev_* message logging API instead of raw printk.
[]
diff --git a/drivers/media/platform/davinci/vpbe.c
b/drivers/media/platform/davinci/vpbe.c
[]
@@ -735,7 +735,7 @@ static int vpbe_initialize(struct device *dev, struct
On Fri, 2013-02-15 at 16:18 -0500, Jarod Wilson wrote:
On Wed, Feb 13, 2013 at 09:36:04AM +0300, Dan Carpenter wrote:
On Tue, Feb 12, 2013 at 01:20:36PM -0800, Joe Perches wrote:
His email bounces and he hasn't done work on
these sections in a couple of years.
I've added him to the CC
His email bounces and he hasn't done work on
these sections in a couple of years.
Signed-off-by: Joe Perches j...@perches.com
---
MAINTAINERS | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1d0651e..8d47b3a 100644
--- a/MAINTAINERS
+++ b
On Wed, 2013-02-13 at 03:38 +0100, thomas schorpp wrote:
On 12.02.2013 22:20, Joe Perches wrote:
His email bounces and he hasn't done work on
these sections in a couple of years.
[]
diff --git a/MAINTAINERS b/MAINTAINERS
[]
-M: Jarod Wilson ja...@wilsonet.com
Not bouncing:
- RCPT
alloc failures already get standardized OOM
messages and a dump_stack.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/staging/media/as102/as102_usb_drv.c | 4 +---
drivers/staging/media/go7007/go7007-fw.c| 24 +++-
drivers/staging/media/go7007/s2250-loader.c
On Sat, 2013-02-02 at 16:30 -0300, Ezequiel Garcia wrote:
ptr = kmalloc(sizeof(foo));
if (!ptr) {
pr_err(Cannot allocate memory for foo\n);
return -ENOMEM;
}
His argue against it was that kmalloc already takes care of
reporting/printking
a good deal of interesting
On Fri, 2012-12-21 at 18:43 -0200, Mauro Carvalho Chehab wrote:
Em Mon, 5 Nov 2012 20:39:33 +0900
YAMANE Toshiaki yamaneto...@gmail.com escreveu:
fixed below checkpatch error.
- ERROR: trailing statements should be on next line
Signed-off-by: YAMANE Toshiaki yamaneto...@gmail.com
On Wed, 2012-11-28 at 16:06 -0300, Ezequiel Garcia wrote:
On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia elezegar...@gmail.com
wrote:
This is a large patchset that replaces struct memcpy with struct assignment,
whenever possible at drivers/media.
[]
A simplified version of the semantic
On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
fixed below checkpatch warnings.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then
pr_err(... to printk(KERN_ERR ...
- WARNING: Prefer
On Mon, 2012-11-05 at 16:22 +0100, Greg Kroah-Hartman wrote:
On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote:
On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote:
On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote:
fixed below checkpatch warnings
On Tue, 2012-10-23 at 11:44 -0700, Andrey Smirnov wrote:
This patch adds all necessary header files and Kbuild plumbing for the
core driver for Silicon Laboratories Si476x series of AM/FM tuner
chips.
[]
+#ifdef DEBUG
+#define DBG_BUFFER(device, header, buffer, bcount) \
On Sun, 2012-10-07 at 19:18 +0200, Julia Lawall wrote:
On Sun, 7 Oct 2012, walter harms wrote:
Am 07.10.2012 18:44, schrieb Julia Lawall:
On Sun, 7 Oct 2012, walter harms wrote:
Am 07.10.2012 17:38, schrieb Julia Lawall:
Introduce use of I2c_MSG_READ/WRITE/OP, for readability.
struct
On Sun, 2012-10-07 at 20:56 +0200, Julia Lawall wrote:
Some people thought that it would be nice to have the macros rather than
the inlined field initializations, especially since there is no flag for
write. A separate question is whether an array of one element is useful,
or whether one
On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote:
On Sun, 7 Oct 2012, Joe Perches wrote:
Are READ and WRITE the action names? They are really the important
information in this case.
Yes, most (all?) uses of _READ and _WRITE macros actually
perform some I/O.
I2C_MSG_READ_DATA
No need to duplicate normal kernel logging capabilities.
Add pr_fmt and convert pr_reg to pr_info.
Remove pr_reg macros.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/rc/fintek-cir.c | 32 +
drivers/media/rc/nuvoton-cir.c | 145
On Sun, 2012-01-29 at 01:44 +0900, Masanari Iida wrote:
Correct KERN_ERROR to KERN_ERR in
drivers/media/video/saa7164/saa7164.h
Signed-off-by: Masanari Iida standby2...@gmail.com
[]
diff --git a/drivers/media/video/saa7164/saa7164.h
b/drivers/media/video/saa7164/saa7164.h
[]
@@ -613,7
Likely misuse of vs .
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/omap24xxcam-dma.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/omap24xxcam-dma.c
b/drivers/media/video/omap24xxcam-dma.c
index 1d54b86..3ea38a8 100644
On Tue, 2011-10-18 at 22:02 +0200, Piotr Chmura wrote:
Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/
[]
diff --git linux/drivers/staging/media/as102/as102_fe.c
linuxb/drivers/staging/media/as102/as102_fe.c
[]
@@ -408,6 +408,8 @@
/* init frontend callback
On Tue, 2011-10-18 at 22:54 +0200, Piotr Chmura wrote:
On Tue, 18 Oct 2011 13:28:39 -0700
Joe Perches j...@perches.com wrote:
On Tue, 2011-10-18 at 22:02 +0200, Piotr Chmura wrote:
Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/
[]
diff --git linux/drivers
On Sat, 2011-09-17 at 11:34 +0200, Martin Hostettler wrote:
Adds board support for an MT9M032 based camera to omap3evm.
All of the logging messages could be
prefixed by the printk subsystem if you
add #define pr_fmt before any #include
diff --git a/arch/arm/mach-omap2/board-omap3evm-camera.c
On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote:
So what is recommended way to ensure patch is correct currently?
a) before commit
Use checkpatch.
b) after commit
Make the output of the commit log look like a patch.
--
To unsubscribe from this list: send the line unsubscribe
On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote:
On 09/06/2011 06:15 PM, Joe Perches wrote:
On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote:
So what is recommended way to ensure patch is correct currently?
a) before commit
Use checkpatch.
b) after commit
Make
On Sat, 2011-09-03 at 21:21 -0300, Mauro Carvalho Chehab wrote:
Except for patches 06 and 14, the other patches were
acked by the maintainers or by me,
After reviewing it again, Jean-Francois did ack 14/14.
https://lkml.org/lkml/2011/8/22/293
--
To unsubscribe from this list: send the line
On Sat, 2011-08-27 at 09:28 -0400, Andy Walls wrote:
On Wed, 2011-08-24 at 14:42 -0700, Joe Perches wrote:
On Wed, 2011-08-24 at 06:34 -0400, Andy Walls wrote:
On Sun, 2011-08-21 at 15:56 -0700, Joe Perches wrote:
Add pr_fmt.
Convert printks to pr_level.
Convert printks without
On Sat, 2011-08-27 at 19:05 +0200, Jean-Francois Moine wrote:
On Sat, 27 Aug 2011 09:42:32 -0700
Joe Perches j...@perches.com wrote:
Andy, I fully understand how this stuff works.
You apparently don't (yet).
Look at include/linux/printk.h
#ifndef pr_fmt
#define pr_fmt(fmt) fmt
On Wed, 2011-08-24 at 06:34 -0400, Andy Walls wrote:
On Sun, 2011-08-21 at 15:56 -0700, Joe Perches wrote:
Add pr_fmt.
Convert printks to pr_level.
Convert printks without KERN_level to appropriate pr_level.
Removed embedded prefixes when pr_fmt was added.
Use ##__VA_ARGS__ for variadic
On Mon, 2011-08-22 at 10:50 +0200, Jean-Francois Moine wrote:
On Sun, 21 Aug 2011 15:56:57 -0700
Joe Perches j...@perches.com wrote:
Add pr_fmt.
Convert usb style logging macros to pr_level.
Remove now unused old usb style logging macros.
Hi Joe,
Hello Jean-Francois.
Sorry, but I do
First block of logging message cleanups for drivers/media.
Joe Perches (14):
[media] saa7146: Use current logging styles
[media] rc-core.h: Surround macro with do {} while (0)
[media] ene_ir: Use current logging styles
[media] winbond-cir: Use current logging styles
[media] bt8xx: Use
Add pr_fmt, convert printks to pr_level.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/rc/winbond-cir.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
index bec8abc..13f54b5 100644
Add pr_fmt and convert usb style logging macro uses to pr_level.
Coalesce format strings.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/gspca/m5602/m5602_core.c|9 +++--
drivers/media/video/gspca/m5602/m5602_mt9m111.c | 28 ++
drivers/media/video
Add pr_fmt.
Convert usb style logging macros to pr_level.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/gspca/sn9c20x.c | 74 ++-
1 files changed, 38 insertions(+), 36 deletions(-)
diff --git a/drivers/media/video/gspca/sn9c20x.c
b
Add pr_fmt.
Convert usb style logging macros to pr_level.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/gspca/t613.c | 12 +++-
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/media/video/gspca/t613.c b/drivers/media/video/gspca/t613.c
index
Add pr_fmt.
Convert usb style logging macros to pr_level.
Coalesce formats.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/gspca/pac207.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/media/video/gspca/pac207.c
b/drivers/media
Add pr_fmt.
Convert usb style logging macros to pr_level.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/gspca/finepix.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/gspca/finepix.c
b/drivers/media/video/gspca/finepix.c
Macros coded with if statements should be do { if... } while (0)
so the macros can be used in other if tests.
Use ##__VA_ARGS__ for variadic macro as well.
Signed-off-by: Joe Perches j...@perches.com
---
include/media/rc-core.h |7 +--
1 files changed, 5 insertions(+), 2 deletions
Add pr_fmt.
Convert printks to pr_level.
Convert printks without KERN_level to appropriate pr_level.
Removed embedded prefixes when pr_fmt was added.
Use ##__VA_ARGS__ for variadic macros.
Coalesce format strings.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/cx18/cx18-alsa
Add pr_fmt.
Convert ene_warn and ene_notice to pr_level.
Use pr_debug in __dbg macro and a little neatening.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/rc/ene_ir.c | 73 +++--
drivers/media/rc/ene_ir.h | 19 +++
2 files
Use the more current logging styles with pr_fmt.
Remove now unnecessary private include.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/common/tuners/tda18212.c | 31 ++-
drivers/media/common/tuners/tda18212_priv.h | 44 ---
2 files
Resubmittal of patches from November 2010 and a few new ones.
Joe Perches (15):
s390: Convert vmalloc/memset to vzalloc
x86: Convert vmalloc/memset to vzalloc
atm: Convert vmalloc/memset to vzalloc
drbd: Convert vmalloc/memset to vzalloc
char: Convert vmalloc/memset to vzalloc
isdn
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/videobuf2-dma-sg.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/video/videobuf2-dma-sg.c
b/drivers/media/video/videobuf2-dma-sg.c
index b2d9485..15d79a8 100644
--- a/drivers/media
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/dvb/siano/smsusb.c |9 +++--
drivers/media/rc/imon.c |2 +-
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/media/dvb/siano/smsusb.c b/drivers/media/dvb/siano/smsusb.c
index 50d4338..0b8da57
On Wed, 2010-11-17 at 10:55 +0100, Arnd Bergmann wrote:
On Tuesday 16 November 2010, Joe Perches wrote:
static inline u32 MCDE_channel_path(u32 chnl, u32 fifo, u32 type, u32 ifc,
u32 link)
{
return ((chnl 16) |
(fifo 12) |
(type 8
On Tue, 2010-11-16 at 16:29 +0100, Jimmy RUBIN wrote:
+/* Channel path */
+#define MCDE_CHNLPATH(__chnl, __fifo, __type, __ifc, __link) \
+ (((__chnl) 16) | ((__fifo) 12) | \
+ ((__type) 8) | ((__ifc) 4) | ((__link) 0))
+enum mcde_chnl_path {
+ /* Channel A */
+
On Mon, 2010-11-15 at 10:52 +0100, Jimmy RUBIN wrote:
Just trivia:
[]
It'd be nice to change to continuous_running
Continous_running [...]
It was just a spelling comment.
continous
continuous
+int mcde_dsi_dcs_write(struct mcde_chnl_state *chnl, u8 cmd, u8*
data, int len)
+{
+
Joe Perches (11):
drivers/i2c/busses/i2c-nforce2.c: Remove unnecessary casts of pci_get_drvdata
drivers/ide/pmac.c: Remove unnecessary casts of pci_get_drvdata
drivers/media/dvb/ngene/ngene-core.c: Remove unnecessary casts of
pci_get_drvdata
drivers/misc/ibmasm/module.c: Remove
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/dvb/ngene/ngene-core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/ngene/ngene-core.c
b/drivers/media/dvb/ngene/ngene-core.c
index 4caeb16..1999e35 100644
--- a/drivers/media/dvb/ngene
ya trivial series...
Joe Perches (44):
arch/arm: Remove unnecessary semicolons
arch/microblaze: Remove unnecessary semicolons
arch/um: Remove unnecessary semicolons
drivers/cpufreq: Remove unnecessary semicolons
drivers/gpio: Remove unnecessary semicolons
drivers/i2c: Remove
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/cx88/cx88-blackbird.c |2 +-
drivers/media/video/davinci/vpfe_capture.c |2 +-
drivers/media/video/em28xx/em28xx-cards.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/cx88
On Wed, 2010-11-10 at 13:04 +0100, Jimmy Rubin wrote:
This patch adds support for MCDE, Memory-to-display controller
found in the ST-Ericsson ux500 products.
Just trivia:
diff --git a/drivers/video/mcde/mcde_hw.c b/drivers/video/mcde/mcde_hw.c
[]
+#define dsi_rfld(__i, __reg, __fld) \
+
.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/staging/cx25821/cx25821-alsa.c | 71
drivers/staging/cx25821/cx25821-audio-upstream.c | 66
drivers/staging/cx25821/cx25821-cards.c|2 +
drivers/staging/cx25821/cx25821-core.c
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/dvb/ngene/ngene-core.c |3 +--
drivers/media/video/mx3_camera.c |3 +--
drivers/media/video/pwc/pwc-if.c |3 +--
drivers/media/video/videobuf-dma-sg.c |3 +--
4 files changed, 4 insertions(+), 8 deletions
output
Remove any KERN_level from WARN uses
Coalesce formats
Align WARN arguments
Add some missing newlines to WARN uses
Add some missing first test argument (1, fmt, args) to WARN uses
Joe Perches (39):
include/asm-generic/bug.h: Update WARN macros
arch/alpha: Update WARN uses
arch/arm: Update
Add missing newlines.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/s5p-fimc/fimc-core.c |2 +-
drivers/media/video/sr030pc30.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-core.c
b/drivers/media
Converted if (debug = 2) printk(KERN_DEBUG... to if debug = 2) dprintk(...)
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/common/tuners/max2165.c | 10 --
drivers/media/dvb/frontends/atbm8830.c|8 +++-
drivers/media/dvb/frontends/lgs8gxx.c
Found using strings vmlinux | grep ^..*.
and a couple of other cleanups of logging message format strings.
Joe Perches (10):
arch/x86/kernel/apic/io_apic.c: Typo fix WARNING
drivers/atm/eni.c: Remove multiple uses of KERN_level
drivers/hid/hid-input.c: Remove KERN_DEBUG from dbg_hid use
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/video/zoran/zoran_device.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/zoran/zoran_device.c
b/drivers/media/video/zoran/zoran_device.c
index 6f846ab..ea8a1e9 100644
--- a/drivers
Just fill the array as necessary and terminate with 0
Signed-off-by: Joe Perches j...@perches.com
---
diff --git a/drivers/media/video/zoran/zoran_device.c
b/drivers/media/video/zoran/zoran_device.c
index 6f846ab..b02007e 100644
--- a/drivers/media/video/zoran/zoran_device.c
+++ b/drivers/media
On Sat, 2010-09-11 at 16:59 +0300, Andy Shevchenko wrote:
drivers/media/dvb/mantis/mantis_core.c |5 +
drivers/media/dvb/mantis/mantis_ioc.c |9 +
Hi Andy.
I think these are clearer and more commonly used as:
dprintk(verbose, MANTIS_ERROR, 0,
+ MAC
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/IR/imon.c|6 +++---
drivers/media/common/saa7146_vbi.c |4 ++--
drivers/media/common/saa7146_video.c |4 ++--
drivers/media/dvb/bt8xx/dst_ca.c |2 +-
drivers/media/video/cx18
Use the standard error logging mechanisms.
Add #define pr_fmt(fmt) KBUILD_MODNAME :%s fmt, __func__
Remove __func__ from err calls, add '\n', rename to pr_err
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/IR/imon.c | 73 ++-
1 files
On Sun, 2010-06-20 at 11:58 -0400, Jarod Wilson wrote:
On Jun 20, 2010, at 3:20 AM, Joe Perches j...@perches.com wrote:
Use the standard error logging mechanisms.
Add #define pr_fmt(fmt) KBUILD_MODNAME :%s fmt, __func__
Remove __func__ from err calls, add '\n', rename to pr_err
Eh. If we're
Signed-off-by: Joe Perches j...@perches.com
---
drivers/media/dvb/siano/smscoreapi.c |4 +---
drivers/media/video/w9968cf.c|3 +--
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/dvb/siano/smscoreapi.c
b/drivers/media/dvb/siano/smscoreapi.c
index
to a function.
Joe Perches (11):
arch/ia64/hp/common/sba_iommu.c: Rename dev_info to adi
drivers/usb/host/hwa-hc.c: Rename dev_info to hdi
drivers/usb/wusbcore/wusbhc.h: Remove unused dev_info from struct wusb_port
drivers/s390/block/dcssblk.c: Rename dev_info to ddi
drivers/edac/amd: Rename
101 - 200 of 220 matches
Mail list logo
