Re: [PATCH v4 0/6] davinci vpbe: dm6446 v4l2 driver

Hans Verkuil hverk...@xs4all.nl writes: version4 : addressed Hans's comments on: 1. replaced mutex_lock_interruptible() with mutex_lock() 2. replaced ntsc and pal macros with new equivalent macros 3. simplifying the code in the if-else condition 4. minor code corrections For the whole

Re: [PATCH v9 5/8] davinci vpbe: platform specific additions

Manjunath Hadli manjunath.ha...@ti.com writes: This patch implements the overall device creation for the Video display driver Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri m-kariche...@ti.com Acked-by: Hans Verkuil hverk...@xs4all.nl This one still

Re: [PATCH v16 1/3] davinci vpbe: changes to common files

Manjunath Hadli manjunath.ha...@ti.com writes: Implemented a common and single mapping for DAVINCI_SYSTEM_MODULE_BASE to be used by all davinci platforms. Please use a more descriptive subject. This patch hs nothing to do with VPBE, so please send it as a standalone patch. Thanks, Kevin

Re: [PATCH v16 2/3] davinci vpbe: platform specific additions

Manjunath Hadli manjunath.ha...@ti.com writes: This patch implements the overall device creation for the Video display driver, initializes the platform variables and implements platform functions including setting video clocks. This is dm644x specific. Please use 'davinci: dm644x: VPBE' as

Re: [PATCH 3/9] dm355 ccdc module for vpfe capture driver

Karicheri, Muralidharan m-kariche...@ti.com writes: Laurent, Thanks for reviewing this. I have not gone through all of your comments, but would like to respond to the following one first. I will respond to the rest as I do the rework. I've had a quick look at the DM355 and DM6446

Re: [PATCH 9/10 - v2] remove outdated video driver files of dm6446

m-kariche...@ti.com writes: From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com Remove outdated driver files from davinci git tree Can you add another patch that removes the old Kconfig/Makfile entries as well (of course, this only applied to davinci git and not mainline.) Also,

Re: [PATCH 0/11 - v3] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

and dynamically Muralidhara Karicheri Reviewed by: Hans Verkuil hverk...@xs4all.nl Reviewed by: Laurent Pinchart laurent.pinch...@skynet.be Reviewed by: Alexey Klimov klimov.li...@gmail.com Reviewed by: Kevin Hilman khil...@deeprootsystems.com Reviewed by: David Brownell davi...@pacbell.net

Re: [PATCH 2/6 v5] Support for TVP7002 in dm365 board

santiago.nu...@ridgerun.com writes: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides support for TVP7002 in architecture definitions within DM365. Signed-off-by: Santiago Nunez-Corrales santiago.nu...@ridgerun.com --- arch/arm/mach-davinci/board-dm365-evm.c |

Re: [PATCH v1 1/4] DM365 Platform support for VPFE

Hilman khil...@deeprootsystems.com Signed-off-by: Neil Sikka neilsi...@ti.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com for this patch, but the rest of the series needs to be reviewed by linux-media folks. Kevin --- Applies to Kevin Hilman's linux-davinci repository arch/arm

Re: [PATCH v1 1/4] DM365 Platform support for VPFE

for the update, I'll drop from my queue and wait for updated version. Kevin -Original Message- From: davinci-linux-open-source-boun...@linux.davincidsp.com [mailto:davinci-linux-open-source-boun...@linux.davincidsp.com] On Behalf Of Kevin Hilman Sent: Thursday, October 15, 2009 7:18 PM

Re: [PATCH 2/6 v5] Support for TVP7002 in dm365 board

Santiago Nunez-Corrales snu...@ridgerun.com writes: Kevin Hilman wrote: santiago.nu...@ridgerun.com writes: From: Santiago Nunez-Corrales santiago.nu...@ridgerun.com This patch provides support for TVP7002 in architecture definitions within DM365. Signed-off-by: Santiago Nunez

Re: architecture part of video driver patch

Karicheri, Muralidharan m-kariche...@ti.com writes: Kevin, Following patch merged to v4l-dvb linux-next has an architectural part as attached. If you have not merged it to your next branch for linux-davinci tree, please do so at your earliest convenience so that they are in sync. OK,

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

m-kariche...@ti.com writes: From: Muralidharan Karicheri m-kariche...@ti.com v1 - updated based on comments from Vaibhav Hiremath. On DM365 we use only vpss master clock, where as on DM355 and DM6446, we use vpss master and slave clocks for vpfe capture and AM3517 we use internal clock

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

Karicheri, Muralidharan m-kariche...@ti.com writes: Kevin, +/** + * vpfe_disable_clock() - Disable clocks for vpfe capture driver + * @vpfe_dev - ptr to vpfe capture device + * + * Disables clocks defined in vpfe configuration. + */ static void vpfe_disable_clock(struct vpfe_device

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

Karicheri, Muralidharan m-kariche...@ti.com writes: Kevin, I think I have figured it out... First issue was that I was adding my entry at the end of dm644x_clks[] array. I need to add it before the CLK(NULL, NULL, NULL) secondly, your suggestion didn't work as is. This is what I had to

Re: [PATCH - v1 1/2] V4L - vpfe capture - make clocks configurable

Karicheri, Muralidharan m-kariche...@ti.com writes: Kevin, I think I have figured it out... First issue was that I was adding my entry at the end of dm644x_clks[] array. I need to add it before the CLK(NULL, NULL, NULL) secondly, your suggestion didn't work as is. This is what I had to

Re: Embedded Linux Conference

Hans Verkuil hverk...@xs4all.nl writes: Just FYI: I'll be attending the Embedded Linux Conference in San Francisco, April 6th-8th (http://www.embeddedlinuxconference.com/elc_2009). This might be a good opportunity to discuss omap and davinci V4L2 issues face-to-face. Let me know if you

Re: Embedded Linux Conference

Hans Verkuil wrote: On Tuesday 17 March 2009 01:14:28 Steve Sakoman wrote: On Mon, Mar 16, 2009 at 3:56 PM, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@deeprootsystems.com [090316 15:52]: Hans Verkuil hverk...@xs4all.nl writes: Just FYI: I'll be attending the Embedded Linux

Re: [RFC 1/7] ARM: DaVinci: DM646x Video: Platform and board specific setup

chaithr...@ti.com writes: From: Chaithrika U S chaithr...@ti.com Add pin mux definitions, display device setup, clock setup functions Add pin mux related code for the display device, also add platform device and resource structures. Also define a platform specific clock setup function that

Re: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp

Omar Ramirez Luna omar.rami...@ti.com writes: Add mmu hwmod data for ipu and dsp. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com [...] +static struct omap_hwmod omap44xx_ipu_mmu_hwmod = { + .name = ipu_mmu, + .class = omap44xx_mmu_hwmod_class, +

Re: [PATCH v3 4/4] OMAP3/4: iommu: adapt to runtime pm

Omar Ramirez Luna omar.rami...@ti.com writes: Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations, reset and sysconfig handling. Tidspbridge uses a macro removed with this patch, for now the value is hardcoded to avoid breaking

Re: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp

Ramirez Luna, Omar omar.rami...@ti.com writes: Hi, On Fri, Nov 4, 2011 at 6:23 PM, Kevin Hilman khil...@ti.com wrote: +     .flags          = HWMOD_INIT_NO_RESET, Why is this needed? ... +     .flags          = HWMOD_INIT_NO_RESET, And this? I have this because the hwmod complains

Re: [PATCH v2 05/11] OMAP4: Add base addresses for ISS

Sergio Aguirre saagui...@ti.com writes: NOTE: This isn't the whole list of features that the ISS supports, but the only ones supported at the moment. Signed-off-by: Sergio Aguirre saagui...@ti.com [...] diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h

Re: [PATCH v2 04/11] OMAP4: hwmod: Include CSI2A and CSIPHY1 memory sections

+Benoit, Aguirre, Sergio saagui...@ti.com writes: Hi Vaibhav, Thanks for the comments. On Thu, Dec 1, 2011 at 12:34 AM, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of

Re: [PATCH v2 04/11] OMAP4: hwmod: Include CSI2A and CSIPHY1 memory sections

Aguirre, Sergio saagui...@ti.com writes: [...] Also, work with Benoit to make sure at the scripts that autogenerate this data are updated to include these two regions. Ok. As a side note, I might need more addresses for the rest of the ISP components later on. I'll enable more subsystems

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

are defined for ccdc driver as per comments from Kevin Hilman. This adds platform code for ccdc driver on DM355 and DM6446. Reviewed-by: Vaibhav Hiremath hvaib...@ti.com Reviewed-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

Karicheri, Muralidharan m-kariche...@ti.com writes: CLK(NULL, rto, rto_clk), CLK(NULL, usb, usb_clk), + CLK(dm355_ccdc, master, vpss_master_clk), + CLK(dm355_ccdc, slave, vpss_slave_clk), I still don't understand why you have to add new entries here and can't simply rename the

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

In the future, please do not top-post. Inline replies are preferred so context can be followed. I've moved your reply into context below with some more comments... Karicheri, Muralidharan m-kariche...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

Karicheri, Muralidharan m-kariche...@ti.com writes: Kevin, OK, I'm not extremely familar with the whole video architecture here, but are all of these drivers expected to be doing clk_get() and clk_enable()? [MK]Many IPs on DaVinci VPFE would require vpss master clock. So it is better to do

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

Karicheri, Muralidharan m-kariche...@ti.com writes: Can I remove it through a separate patch? This patch is already merged in Hans tree. Hmm, arch patches should not be merged yet as I have not ack'd them. Kevin -Original Message- From: Kevin Hilman [mailto:khil

Re: [PATCH - v3 4/4] DaVinci - vpfe-capture-converting ccdc drivers to platform driver

Hiremath, Vaibhav hvaib...@ti.com writes: [Hiremath, Vaibhav] Hi Kevin and Murali, Sorry for jumping into this discussion so late, Can we use clk_add_alias() function exported by clkdev.c file here? With this board specific file can define aliases for all required platform_data keeping

Re: [PATCH - v4 4/4] DaVinci-vpfe-capture-converting-ccdc-drivers-to-platform-drivers

the two patches sent earlier to change the clock configuration and converting ccdc drivers to platform drivers. This has updated comments against v2 of these patches. Two new clocks master and slave are defined for ccdc driver as per comments from Kevin Hilman. This adds platform code for ccdc

Re: [PATCH - v4 2/4] V4L-vpfe-capture-converting dm355 ccdc driver to a platform driver

. Following are the changes done:- 1) clocks are configured using generic clock names 2) converting the driver to a platform driver 3) cleanup - consolidate all static variables inside a structure, ccdc_cfg Reviewed-by: Kevin Hilman khil...@deeprootsystems.com Reviewed-by: Vaibhav

Re: [PATCH - v4 1/4] V4L-vpfe_capture-remove-clock and platform code

importanty. For the benefit of reading the git history later, and also for those of us less familiar with the details of these drivers, we rely heavily on a good changelog. Kevin Reviewed-by: Vaibhav Hiremath hvaib...@ti.com Reviewed-by: Kevin Hilman khil...@deeprootsystems.com Reviewed-by: Hans

Re: [PATCH - v4 4/4] DaVinci-vpfe-capture-converting-ccdc-drivers-to-platform-drivers

. Thanks. This combines the two patches sent earlier to change the clock configuration and converting ccdc drivers to platform drivers. This has updated comments against v2 of these patches. Two new clocks master and slave are defined for ccdc driver as per comments from Kevin Hilman

Re: [PATCH - v4 1/4] V4L-vpfe_capture-remove-clock and platform code

Karicheri, Muralidharan m-kariche...@ti.com writes: [...] Also, this doesn't accuratly reflect the changes done in the patch. Here the clock configuration isn't moved, it's removed. You should mention it being removed here and added to platform-specific code in subsequent patches. Sorry to

Re: [PATCH - v4 1/4] V4L - vpfe_capture-remove clock and platform code

of the ccdc patches and platform patches 2-4) 2) Added proper error codes for ccdc register function Reviewed-by: Vaibhav Hiremath hvaib...@ti.com Reviewed-by: Kevin Hilman khil...@deeprootsystems.com Reviewed-by: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Hans Verkuil hverk

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

Hans Verkuil hverk...@xs4all.nl writes: On Monday 22 June 2009 10:14:30 chaithrika wrote: Kevin, I think this patch has to be taken into DaVinci tree so that it can be submitted upstream. This patch has to be present in the Linux tree for Hans to prepare a pull request for DM646x display

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

Chaithrika U S chaithr...@ti.com writes: Platform specific display device setup for DM646x EVM Add platform device and resource structures. Also define a platform specific clock setup function that can be accessed by the driver to configure the clock and CPLD. This patch is dependent on a

Re: [PATCH] Subject: [PATCH v3 1/4] ARM: DaVinci: DM646x Video: Platform and board specific setup

Kevin Hilman khil...@deeprootsystems.com writes: Chaithrika U S chaithr...@ti.com writes: Platform specific display device setup for DM646x EVM Add platform device and resource structures. Also define a platform specific clock setup function that can be accessed by the driver to configure

[PATCH] V4L/DVB: dm646x: fix DMA_nnBIT_MASK

Fix deprecated use of DMA_nnBIT_MASK which now gives a compiler warning. Signed-off-by: Kevin Hilman khil...@deeprootsystems.com --- This compiler warning patch is on top of the master branch of Mauro's linux-next tree. arch/arm/mach-davinci/dm646x.c |2 +- 1 files changed, 1 insertions

Re: [PATCH v4] ARM: DaVinci: DM646x Video: Platform and board specific setup

Kevin Hilman khil...@deeprootsystems.com writes: chaithrika chaithr...@ti.com writes: Russell, Requesting your ack on this patch. Chaithrika, Mauro, We don't need Russell's ack on this. You've incorporated his comments and my signoff is enough for stuff under arch/arm/mach-davinci

Re: [PATCH] V4L/DVB: dm646x: fix DMA_nnBIT_MASK

Kevin Hilman khil...@deeprootsystems.com writes: Fix deprecated use of DMA_nnBIT_MASK which now gives a compiler warning. Signed-off-by: Kevin Hilman khil...@deeprootsystems.com --- This compiler warning patch is on top of the master branch of Mauro's linux-next tree. Ping

Re: [PATCH v1 - 1/5] DaVinci - restructuring code to support vpif capture driver

On Mon, Aug 24, 2009 at 6:09 AM, Mauro Carvalho Chehabmche...@infradead.org wrote: Em Thu, 20 Aug 2009 16:27:40 -0500 Karicheri, Muralidharan m-kariche...@ti.com escreveu: Kevin Mauro, Do I need to wait or this can be resolved by either of you for my work to proceed? Murali, If I fix

davinci vs. v4l2: lots of conflicts in merge for linux-next

OK, this has gotten a bit out of control, to the point where I cannot solve this myself. This is partially due to me being on the road and not keeping a close enough eye on the various video patches. I've pushed a new 'davinci-next' branch to davinci git[1] which is what I would like to make

Re: davinci vs. v4l2: lots of conflicts in merge for linux-next

20874 new phone: 301-407-9583 Old Phone : 301-515-3736 (will be deprecated) email: m-kariche...@ti.com -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, August 26, 2009 5:00 AM To: Karicheri, Muralidharan; Mauro Carvalho Chehab Cc: linux-media

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

Hi Sakari, Sakari Ailus sakari.ai...@iki.fi writes: The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to the actual CSI-2 receivers outside the ISP itself. Allow changing this configuration from the ISP driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi These

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

Sakari Ailus sakari.ai...@iki.fi writes: Hi Kevin, Thanks for the comments! On Tue, Oct 09, 2012 at 01:50:04PM -0700, Kevin Hilman wrote: Hi Sakari, Sakari Ailus sakari.ai...@iki.fi writes: The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to the actual CSI-2

Re: [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver

Hi Martin, On Tue, Jun 28, 2016 at 12:17 PM, Martin Blumenstingl wrote: > Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different > register layout for their Infrared Remoete Controller. The decoder mode > is now configured in another register.

Re: [PATCH 09/10] media: vpif: use a configurable i2c_adapter_id for vpif display

; Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Acked-by: Kevin Hilman <khil...@baylibre.com> > --- > arch/arm/mach-davinci/board-da850-evm.c | 1 + > drivers/media/platform/davinci/vpif_display.c | 2 +- > include/media/davinci/vpif_types.h

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

is not complete since there isn't currently a way to define the output_routing in the V4L2 drivers (c.f. s_routing) via DT. > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> minor nit below, otherwise Reviewed-by: Kevin Hilman <khil...@baylibre.com> > --- > arch/

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

v_count = 1; > > - /* EVM (UI card) uses i2c adapter 1 (not default: zero) */ > - if (of_machine_is_compatible("ti,da850-evm")) > - da850_vpif_capture_config.i2c_adapter_id = 1; > - oops, my bad. Acked-by: Kevin Hilman <khil...@baylibre.com> &

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

On Fri, Dec 16, 2016 at 4:49 PM, Kevin Hilman <khil...@baylibre.com> wrote: > Hans Verkuil <hverk...@xs4all.nl> writes: > >> On 07/12/16 19:30, Kevin Hilman wrote: >>> Prepare the groundwork for adding DT support for davinci VPIF drivers. >>> This seri

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

Kevin Hilman <khil...@baylibre.com> writes: > Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: > >> There's a stray tab in da850_vpif_legacy_init(). Remove it. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > Fo

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

Kevin Hilman <khil...@baylibre.com> writes: > Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: > >> Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > I'll fold this one into the original since it's not yet merged. Oops, Sekhar has alr

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

Hi Bartosz, Bartosz Golaszewski writes: > Similarly to vpif capture: we need to register the vpif display driver > and the corresponding adv7343 encoder in pdata-quirks as the DT > support is not complete. > > Signed-off-by: Bartosz Golaszewski

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Acked-by: Kevin Hilman <khil...@baylibre.com> > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+),

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski I'll fold this one into the original since it's not yet merged. Kevin > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

Sekhar Nori <nsek...@ti.com> writes: > On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote: >> Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: >> >>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because >>> the i2c ada

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

Bartosz Golaszewski writes: > There's a stray tab in da850_vpif_legacy_init(). Remove it. > > Signed-off-by: Bartosz Golaszewski Folding into the original, Kevin > --- > arch/arm/mach-davinci/pdata-quirks.c | 2 +- > 1 file changed, 1

Re: [PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin

O_5, 0) }; > > +static const unsigned int ir_in_ao_pins[] = {PIN(GPIOAO_7, 0) }; > + I'm trying to keep the names here so they match the datasheet, which calls this remote_input_ao. Please update throughout the patch. Otherwise looks good to me. Feel free to add Reviewed-by: Kevin Hilman &l

Re: [PATCH v4 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder

new bindings so the driver knows which register has to be > used. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> > Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com> Acked-by: Kevin Hilman <khil...@baylibre.com> Mauro, are you t

Re: [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver

Martin Blumenstingl writes: > Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different > register layout for their Infrared Remoete Controller. The decoder mode > is now configured in another register. Without the changes to the > meson-ir driver

[RFC PATCH 1/6] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[RFC PATCH 5/6] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/d

[RFC PATCH 3/6] ARM: dts: davinci: da850: add VPIF

Add VPIF and VPIF capture nodes to da850. Note that these are separate nodes because the current media drivers have two separate drivers for vpif and vpif_capture. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- arch/arm/boot/dts/da850.dtsi | 28

[RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

osed to be done via DT? Not-Yet-Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 132 +- include/media/davinci/vpif_types.h| 9 +- 2 files changed, 134 insertions(+), 7 deletions(-) diff --git a/dri

[RFC PATCH 4/6] ARM: dts: davinci: da850-lcdk: enable VPIF capture

Enable video capture via the on-board TVP5147 decoder hooked up to ch0 one of the VPIF capture input. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- arch/arm/boot/dts/da850-lcdk.dts | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/bo

[RFC PATCH 2/6] ARM: davinci: da8xx: VPIF: enable DT init

Add basic support for DT initializaion of VPIF (capture) via DT. Clocks and mux still need to happen in this file until there are real clock and pinctrl drivers, but the video nodes and subdevs can all come from DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- arch/arm/mach-d

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

Kevin Hilman <khil...@baylibre.com> writes: > This series attempts to add DT support to the davinci VPIF capture > driver. > > I'm not sure I've completely grasped the proper use of the ports and > endpoints stuff, so this RFC is primarily to get input on whether I'm

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

Hans Verkuil <hverk...@xs4all.nl> writes: > Hi Kevin, > > On 10/26/2016 01:55 AM, Kevin Hilman wrote: >> This series attempts to add DT support to the davinci VPIF capture >> driver. >> >> I'm not sure I've completely grasped the proper use of the po

Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

On Fri, Nov 18, 2016 at 4:32 PM, Kevin Hilman <khil...@baylibre.com> wrote: > Cc: Rob Herring <r...@kernel.org> > Signed-off-by: Kevin Hilman <khil...@baylibre.com> > --- > .../devicetree/bindings/media/ti,vpif-capture.txt | 65 > ++ &g

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Hi Sakari, Sakari Ailus <sakari.ai...@iki.fi> writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capt

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Hi Sakari, Sakari Ailus <sakari.ai...@iki.fi> writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capt

[PATCH v2 0/4] [media] davinci: VPIF: add DT support

Add DT support, including getting subdevs from DT ports/endpoints. Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4): [media] davinci: add support for DT init [media] davinci: vpif_capture

[PATCH v2 1/4] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[PATCH v2 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/d

[PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

Cc: Rob Herring <r...@kernel.org> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create

Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

Arnd Bergmann <a...@arndb.de> writes: > On Friday, November 18, 2016 4:32:08 PM CET Kevin Hilman wrote: >> + >> +Required properties: >> +- compatible: must be "ti,vpif-capture" >> +- reg: physical base address and length of the registers set for the d

Re: [PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Hans Verkuil <hverk...@xs4all.nl> writes: > On 19/11/16 01:32, Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disabled locking when calling the subdev. >> >> Signed-off-by: Kevin Hilman <khil...@ba

[PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/d

[PATCH v3 1/4] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[PATCH v3 0/4] [media] davinci: VPIF: add DT support

Add DT support, including getting subdevs from DT ports/endpoints. Changes since v2: - DT binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4

[PATCH v3 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/me

Re: [PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

Hans Verkuil <hverk...@xs4all.nl> writes: > On 22/11/16 02:44, Kevin Hilman wrote: >> Cc: Rob Herring <r...@kernel.org> >> Signed-off-by: Kevin Hilman <khil...@baylibre.com> >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >>

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Hi Rob, Rob Herring <r...@kernel.org> writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman <khil...@baylibre.com> >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >>

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Rob Herring <r...@kernel.org> writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman <khil...@baylibre.com> >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >

[PATCH v2 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

Cc: Rob Herring <r...@kernel.org> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../devicetree/bindings/media/ti,vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,vpif.txt | 8 +++ 2 files changed, 73 insertions(+) create mode 100644 D

[PATCH 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/d

[PATCH 1/4] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/d

Re: [PATCH 3/5] [media] rc: meson-ir: Fix module autoload

T*Camlogic,meson-gxbb-irC* > alias: of:N*T*Camlogic,meson-gxbb-ir > alias: of:N*T*Camlogic,meson8b-irC* > alias: of:N*T*Camlogic,meson8b-ir > alias: of:N*T*Camlogic,meson6-irC* > alias: of:N*T*Camlogic,meson6-ir > > Signed-off-by: J

[PATCH v4 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 138 +- include/media/d

[PATCH v4 4/4] [media] dt-bindings: add TI VPIF documentation

Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../devicetree/bindings/media/ti,da850-vpif.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt diff --git a/Documentation/devicetree/bi

[PATCH v4 1/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH v4 0/4] davinci: VPIF: add DT support

binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4): [media] davinci: vpif_capture: don't lock over s_stream [media] davinci: VPIF: add basic

[PATCH v4 2/4] [media] davinci: VPIF: add basic support for DT init

. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 48 ++- drivers/media/platform/davinci/vpif_capture.c | 6 drivers/media/platform/davinci/vpif_display.c | 6 3 files changed, 59 insertions(+), 1 de

Re: [PATCH v5 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking

Laurent Pinchart <laurent.pinch...@ideasonboard.com> writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 06 Dec 2016 21:08:24 Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disable

  1   2   >