Re: [PATCH] viafb camera controller driver

2010-10-19 Thread Laurent Pinchart
kernel release has one or more essential building blocks in place. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] viafb camera controller driver

2010-10-19 Thread Laurent Pinchart
Hi Mauro, On Tuesday 19 October 2010 12:46:11 Mauro Carvalho Chehab wrote: Em 19-10-2010 05:52, Laurent Pinchart escreveu: On Tuesday 19 October 2010 08:54:40 Hans Verkuil wrote: On Tuesday, October 19, 2010 05:20:17 Jonathan Corbet wrote: On Sat, 16 Oct 2010 10:44:56 -0300 Mauro Carvalho

Re: [PATCH] viafb camera controller driver

2010-10-19 Thread Laurent Pinchart
Hi Mauro, On Tuesday 19 October 2010 16:49:25 Mauro Carvalho Chehab wrote: Em 19-10-2010 11:05, Laurent Pinchart escreveu: It is not a big lock: it doesn't stop other CPU's, doesn't affect other hardware, not even another V4L device. Basically, what this new lock does is to serialize

Re: soc_camera device

2010-10-19 Thread Laurent Pinchart
subdev pad-level API. Look at the MT9T001 driver in http://git.linuxtv.org/pinchartl/media.git?a=shortlog;h=refs/heads/media- mt9t001 for sample code. Please read the http://www.spinics.net/lists/linux-media/msg23744.html mail thread for more information. -- Regards, Laurent Pinchart

Re: [PATCH] V4L/DVB: Add the via framebuffer camera controller driver

2010-10-20 Thread Laurent Pinchart
and no I2C reads (or, if they can, the feature isn't used by the Windows driver and can't be understood by reverse engineering). Most sensor drivers will perform I2C reads at least to identify the sensor. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe

Re: OMAP 3530 camera ISP forks and new media framework

2010-10-22 Thread Laurent Pinchart
://git.linuxtv.org/pinchartl/media.git from Laurent Pinchart. Both have an folder drivers/media/video/isp and are written for the new media controller architecture if I am right. Take Laurent's branch it has all the current patches in it. My gitorious tree isn't updated anymore. (I just had forgotten

Re: [GIT PATCHES FOR 2.6.37] Use modaliases to load I2C modules

2010-10-23 Thread Laurent Pinchart
Hi Mauro, On Saturday 23 October 2010 02:02:01 Mauro Carvalho Chehab wrote: Em 06-10-2010 05:45, Laurent Pinchart escreveu: The following changes since commit c8dd732fd119ce6d562d5fa82a10bbe75a376575: V4L/DVB: gspca - sonixj: Have 0c45:6130 handled by sonixj instead of sn9c102 (2010

Re: [PATCH 7/8] v4l: Add EBUSY error description for VIDIOC_STREAMON

2010-10-24 Thread Laurent Pinchart
should do in the first place anyway. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: controls, subdevs, and media framework

2010-10-26 Thread Laurent Pinchart
implemented yet. It's still unclear how exactly it will be implemented in the future. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: OMAP 3530 camera ISP forks and new media framework

2010-10-28 Thread Laurent Pinchart
Hi Michael, On Thursday 28 October 2010 12:28:46 Michael Jones wrote: Laurent Pinchart wrote: First of all, you need to get the latest OMAP3 ISP driver sources. The most recent OMAP3 ISP driver for the N900 can be found in the omap3isp- rx51 git tree on gitorious.org (devel branch from

Re: New media framework user space usage

2010-10-28 Thread Laurent Pinchart
); if (!mt9p031) return -ENOMEM; v4l2_i2c_subdev_init(mt9p031-subdev, client, mt9p031_subdev_ops); Add mt9p031-subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; here to create a subdev node for the sensor. [snip] -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line

Re: New media framework user space usage

2010-10-28 Thread Laurent Pinchart
ISP CCDC output) Replace all occurences of 1024x768 by your sensor native resolution, and mt9t001 3-005d by the sensur subdev name. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: New media framework user space usage

2010-11-01 Thread Laurent Pinchart
, 0xbec111cc) = 0 ioctl(3, VIDIOC_QBUF, 0xbec111cc) = 0 ioctl(3, VIDIOC_QBUF, 0xbec111cc) = 0 ioctl(3, VIDIOC_STREAMON, 0xbec11154) = 0 ioctl(3, VIDIOC_DQBUF strace gets stuck in mid of this line. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send

Re: New media framework user space usage

2010-11-01 Thread Laurent Pinchart
that does not work? You can't read physical memory like that. Userspace applications can only access their virtual memory space. You could mmap() /dev/mem but it's not worth the effort. Well now I put the debug message in the kernel code. That's a better solution. -- Regards, Laurent Pinchart

Re: New media framework user space usage

2010-11-03 Thread Laurent Pinchart
worked but the ADC did not... But the heck - I was never that close :) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: media-ctl header patch

2010-11-03 Thread Laurent Pinchart
controller code will reach the mainline kernel. It should be safe to ignore the compilation warning for now. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: OMAP3530 ISP irqs disabled

2010-11-03 Thread Laurent Pinchart
and the problem is in the dma part. No, the signals are not accessible directly in the ISP. What you could do, however, is read them as GPIOs. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: OMAP3530 ISP irqs disabled

2010-11-03 Thread Laurent Pinchart
or equal to 64 you will get a black image. As a quick hack you can replace ccdc-clamp.dcsubval = 64; with ccdc-clamp.dcsubval = 0; in isp_ccdc_init(). The correct solution is to use the VIDIOC_PRIVATE_ISP_CCDC_CFG ioctl to configure the DC subtraction value to 0. -- Regards, Laurent Pinchart

Re: [GIT PATCHES FOR 2.6.37] Use modaliases to load I2C modules

2010-11-04 Thread Laurent Pinchart
Hi Mauro, On Saturday 23 October 2010 15:30:18 Mauro Carvalho Chehab wrote: Em 23-10-2010 09:27, Laurent Pinchart escreveu: On Saturday 23 October 2010 02:02:01 Mauro Carvalho Chehab wrote: Em 06-10-2010 05:45, Laurent Pinchart escreveu: The following changes since commit

Re: OMAP3530 ISP irqs disabled

2010-11-08 Thread Laurent Pinchart
direction, better wait for Laurent's answer. :-) Sorry for the late reply, I've been travelling for the past two weeks and had no hardware to test this on. I will try the latest code on a board with a parallel sensor and I'll let you know if I can reproduce the problem. -- Regards, Laurent

[PATCH 0/2] Use modaliases to load I2C modules

2010-11-09 Thread Laurent Pinchart
as soon as the bad cafe-ccic merge conflict resolution gets there. Laurent Pinchart (2): v4l: Remove hardcoded module names passed to v4l2_i2c_new_subdev* (2) v4l: Remove module_name argument to the v4l2_i2c_new_subdev* functions drivers/media/radio/radio-si4713.c|2

[PATCH 1/2] v4l: Remove hardcoded module names passed to v4l2_i2c_new_subdev* (2)

2010-11-09 Thread Laurent Pinchart
aliases table with names corresponding to what the drivers modified here use. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/cafe_ccic.c |3 +-- drivers/media/video/s5p-fimc/fimc-capture.c |2 +- drivers/media/video/via-camera.c

[PATCH 2/2] v4l: Remove module_name argument to the v4l2_i2c_new_subdev* functions

2010-11-09 Thread Laurent Pinchart
The argument isn't used anymore by the functions, remote it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/radio/radio-si4713.c|2 +- drivers/media/video/au0828/au0828-cards.c |4 ++-- drivers/media/video/bt8xx/bttv-cards.c

Re: [PATCH 2/2] v4l: Remove module_name argument to the v4l2_i2c_new_subdev* functions

2010-11-09 Thread Laurent Pinchart
Hi Antonio, On Tuesday 09 November 2010 16:33:25 Antonio Ospite wrote: On Tue, 9 Nov 2010 16:30:28 +0100 Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: The argument isn't used anymore by the functions, remote it. s/remote/remove/ Oops :-) Thanks, I'll fix that when sending

[GIT PATCHES FOR 2.6.37] Use modaliases to load I2C modules (part 2)

2010-11-10 Thread Laurent Pinchart
Laurent Pinchart (2): v4l: Remove hardcoded module names passed to v4l2_i2c_new_subdev* (2) v4l: Remove module_name argument to the v4l2_i2c_new_subdev* functions drivers/media/radio/radio-si4713.c|2 +- drivers/media/video/au0828/au0828-cards.c |4 ++-- drivers

Re: mediabus enums

2010-11-11 Thread Laurent Pinchart
seems quite high to me, I suppose it should then be YUYV8_1X16. Notice, that these codes do not define the complete bus topology, e.g., they say nothing about sync signals. This is a separate topic. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux

Re: mediabus enums

2010-11-12 Thread Laurent Pinchart
Hi Manjunath, On Friday 12 November 2010 17:00:36 Hadli, Manjunath wrote: On Thu, Nov 11, 2010 at 22:17:23, Laurent Pinchart wrote: On Thursday 11 November 2010 16:32:02 Guennadi Liakhovetski wrote: On Wed, 10 Nov 2010, Hadli, Manjunath wrote: Hello Guennadi, Your media-bus

Re: [omap3isp RFC][PATCH 02/10] omap3isp: ccdc: Write SYN_MODE.INPMOD based on fmt

2010-11-15 Thread Laurent Pinchart
please squash this with the previous patch ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [omap3isp RFC][PATCH 00/10] YUV support for CCDC + cleanups

2010-11-15 Thread Laurent Pinchart
. But that will be sent separately in another RFC patchlist. Please share your review comments. Apart from one minor comment on patch 02/10, this set looks fine to me. Could you please resend it with patches 01/10 and 02/10 squashed ? -- Regards, Laurent Pinchart -- To unsubscribe from this list

Re: [omap3isp][PATCH v2 0/9] YUV support for CCDC + cleanups

2010-11-16 Thread Laurent Pinchart
Hi Sergio, Thanks for the patches. I've reviewed and tested them and found no issue. They will be a small delay as I need to sync our internal tree with the public tree before applying them. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: An article on the media controller

2010-11-17 Thread Laurent Pinchart
for the review. -- Best regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-17 Thread Laurent Pinchart
*parent; /* device parent */ + + /* device info */ + int minor; + unsigned long flags;/* Use bitops to access flags */ + + /* callbacks */ + void (*release)(struct media_devnode *mdev); +}; -- Regards, Laurent Pinchart -- To unsubscribe from this list

Re: Question about setting V4L2_CID_AUTO_WHITE_BALANCE control to FALSE

2010-11-17 Thread Laurent Pinchart
is that the behaviour might be hardware dependent. Some hardware won't offer option 1, so drivers will be forced to go for option 2. (I'm not totally sure that's why the specification isn't clear about the expected behaviour, but it's at least a good justification for it :-)) -- Regards, Laurent Pinchart

Re: [PATCH 1/1] videobuf: Initialize lists in videobuf_buffer.

2010-11-17 Thread Laurent Pinchart
uninitialized list entries. It is not as if this is a big deal to initialize them properly. I disagree with that. List heads must be initialized, but there's no point in initializing list entries. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: Translation faults with OMAP ISP

2010-11-17 Thread Laurent Pinchart
. Any ideas on the problem? Ouch. First of all, could you please make sure you run the latest code ? Many bugs have been fixed in the last few months. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [omap3isp][PATCH v2 5/9] omap3isp: Remove unused CBUFF register access

2010-11-19 Thread Laurent Pinchart
module at all here, with no plans to use it in the future. It might not be worth it keeping the register definitions. I have no strong feeling about it, I'm fine with both choices. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

[PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-subdev.h |4 1 files changed, 4

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Hi Hans, On Friday 19 November 2010 14:42:31 Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Hi Guennadi, On Friday 19 November 2010 14:49:44 Guennadi Liakhovetski wrote: On Fri, 19 Nov 2010, Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream

Re: Translation faults with OMAP ISP

2010-11-19 Thread Laurent Pinchart
setting them up for the CCDC output, probably not (unless you have a bug in your CCDC links setup, but I doubt that). -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Hi Guennadi, On Friday 19 November 2010 15:15:11 Guennadi Liakhovetski wrote: On Fri, 19 Nov 2010, Laurent Pinchart wrote: On Friday 19 November 2010 14:42:31 Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when

[PATCH] v4l: Include linux/videodev2.h in media/v4l2-ctrls.h

2010-11-19 Thread Laurent Pinchart
The later makes extensive use of structures defined in the former. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-ctrls.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h

Re: Translation faults with OMAP ISP

2010-11-19 Thread Laurent Pinchart
Hi David, On Friday 19 November 2010 16:06:21 David Cohen wrote: On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote: On 11/19/2010 07:13 AM, Laurent Pinchart wrote: On Friday 19 November 2010 15:08:38 Lane Brooks wrote: On 11/19/2010 06:29 AM, David Cohen wrote: On Thu

Re: [omap3isp] Prefered patch base for latest code? (was: RE: Translation faults with OMAP ISP)

2010-11-19 Thread Laurent Pinchart
you want your patches to be applied before Monday, which won't happen anyway, please base them on the linuxtv tree :-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [omap3isp] Prefered patch base for latest code? (was: RE: Translation faults with OMAP ISP)

2010-11-19 Thread Laurent Pinchart
tree are always pushed to linuxtv and gitorious at the same time (or mostly). Please don't use the gitorious tree for anything else than trying the driver on the N900. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent

2010-11-20 Thread Laurent Pinchart
of correctness we should replace isp_reg_writel() by isp_reg_clr_set() in ispccp2_mem_configure(), which will only make a difference on ES 1.0 devices that have basically no users. Is that OK with both of you ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe

Re: [omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-20 Thread Laurent Pinchart
] to generate it. [1] http://coccinelle.lip6.fr/ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [omap3isp RFC][PATCH 0/4] Improve inter subdev interaction

2010-11-20 Thread Laurent Pinchart
the media controller and the omap3isp driver :-) Until then let's not spam linux-omap with patches for a driver they don't know about. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: Zooming with V4L2

2010-11-20 Thread Laurent Pinchart
and V4L2_CID_ZOOM_RELATIVE? I guess it also depends on how zooming is done for most of the V4L2 user application out there. The V4L2_CID_ZOOM_* controls are really meant for optical zoom. Digital zoom should be implemented using cropping. -- Regards, Laurent Pinchart -- To unsubscribe from

[PATCH 0/5] [FOR 2.6.37] uvcvideo: BKL removal

2010-11-21 Thread Laurent Pinchart
Hi everybody, Here are 5 patches to the uvcvideo driver that implements proper locking where it was missing and switch from ioctl to unlocked_ioctl, getting rid of the BKL. As locking can be tricky, patch review would be appreciated. Laurent Pinchart (5): uvcvideo: Lock controls mutex when

[PATCH 1/5] uvcvideo: Lock controls mutex when querying menus

2010-11-21 Thread Laurent Pinchart
uvc_find_control() must be called with the controls mutex locked. Fix uvc_query_v4l2_menu() accordingly. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/uvc/uvc_ctrl.c | 48 +++- drivers/media/video/uvc/uvc_v4l2.c | 36

[PATCH 2/5] uvcvideo: Move mutex lock/unlock inside uvc_free_buffers

2010-11-21 Thread Laurent Pinchart
Callers outside uvc_queue.c should not be forced to lock/unlock the queue mutex manually. Move the mutex operations inside uvc_free_buffers(). Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/uvc/uvc_queue.c | 57

[PATCH 3/5] uvcvideo: Move mmap() handler to uvc_queue.c

2010-11-21 Thread Laurent Pinchart
The mmap() implementation belongs to the video buffers queue, move it there. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/uvc/uvc_queue.c | 76 +++ drivers/media/video/uvc/uvc_v4l2.c | 67

[PATCH 5/5] uvcvideo: Convert to unlocked_ioctl

2010-11-21 Thread Laurent Pinchart
The uvcvideo driver now locks all ioctls correctly on its own, the BKL isn't needed anymore. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/uvc/uvc_v4l2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/uvc

[PATCH 4/5] uvcvideo: Lock stream mutex when accessing format-related information

2010-11-21 Thread Laurent Pinchart
The stream mutex protects access to the struct uvc_streaming ctrl, cur_format and cur_frame fields as well as to the hardware probe control. Lock it appropriately. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/uvc/uvc_v4l2.c | 76

Re: [PATCH 1/5] uvcvideo: Lock controls mutex when querying menus

2010-11-21 Thread Laurent Pinchart
Hi Hans, Thanks for the comment. On Sunday 21 November 2010 22:18:41 Hans Verkuil wrote: On Sunday, November 21, 2010 21:32:49 Laurent Pinchart wrote: uvc_find_control() must be called with the controls mutex locked. Fix uvc_query_v4l2_menu() accordingly. Signed-off-by: Laurent

Re: [PATCH 4/5] uvcvideo: Lock stream mutex when accessing format-related information

2010-11-21 Thread Laurent Pinchart
Hi Hans, Thanks for the comment. On Sunday 21 November 2010 22:23:38 Hans Verkuil wrote: On Sunday, November 21, 2010 21:32:52 Laurent Pinchart wrote: The stream mutex protects access to the struct uvc_streaming ctrl, cur_format and cur_frame fields as well as to the hardware probe

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-21 Thread Laurent Pinchart
with you ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Race condition between v4l2_open() and video_unregister_device()

2010-11-21 Thread Laurent Pinchart
be unregistered between the video_devdata() and video_get() calls. Could you confirm my analysis ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH FOR 2.6.37] Revert V4L/DVB: v4l2-dev: remove unnecessary lock around atomic clear_bit

2010-11-22 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-dev.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-dev.c b/drivers/media/video/v4l2-dev.c index 03f7f46..f777da6 100644 --- a/drivers/media/video/v4l2-dev.c

What should poll() return when a device is unregistered ? (was media: Media device node support)

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 November 2010 10:08:06 Hans Verkuil wrote: On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: Hi Jonathan, I forgot to answer one of your comments. On Wednesday 17 November 2010 01:31:15 Jonathan Corbet wrote: [snip] +static unsigned int

Re: Zooming with V4L2

2010-11-22 Thread Laurent Pinchart
. Whether it's downscaling or upscaling (or even no scaling it all for a specific resolution) is not really relevant here. It depends on the output resolution but it's still digital zoom that should be implemented using the crop API. -- Regards, Laurent Pinchart -- To unsubscribe from this list

Re: Zooming with V4L2

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 November 2010 12:23:49 Hans de Goede wrote: On 11/22/2010 11:59 AM, Laurent Pinchart wrote: On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote: Hello, Laurent, Thank you for the reply. In our case, most of the time the sensor outputs bigger image size than

Re: Zooming with V4L2

2010-11-22 Thread Laurent Pinchart
On Monday 22 November 2010 12:34:04 Laurent Pinchart wrote: On Monday 22 November 2010 12:23:49 Hans de Goede wrote: On 11/22/2010 11:59 AM, Laurent Pinchart wrote: On Sunday 21 November 2010 00:50:59 Shuzhen Wang wrote: Hello, Laurent, Thank you for the reply. In our case

Re: [PATCH 1/5] uvcvideo: Lock controls mutex when querying menus

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 November 2010 10:21:41 Hans Verkuil wrote: On Sunday, November 21, 2010 22:45:48 Laurent Pinchart wrote: On Sunday 21 November 2010 22:18:41 Hans Verkuil wrote: On Sunday, November 21, 2010 21:32:49 Laurent Pinchart wrote: uvc_find_control() must be called

Re: [omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-22 Thread Laurent Pinchart
as-is, and we'll wait for Laurent's coccinelle-assisted changes on top in the future. Is that correct? As you need to resubmit the serie anyway, I'd appreciate if you could already make the change. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH FOR 2.6.37] Revert V4L/DVB: v4l2-dev: remove unnecessary lock around atomic clear_bit

2010-11-22 Thread Laurent Pinchart
Hi Hans, On Tuesday 23 November 2010 01:14:28 Hans Verkuil wrote: On Monday, November 22, 2010 12:20:25 Hans Verkuil wrote: On Monday, November 22, 2010 11:21:27 Laurent Pinchart wrote: Removing the mutex_lock/unlock around clear_bit allowed device_unregister() to race with v4l2_open

Re: [PATCH FOR 2.6.37] Revert V4L/DVB: v4l2-dev: remove unnecessary lock around atomic clear_bit

2010-11-23 Thread Laurent Pinchart
Hi Hans, On Tuesday 23 November 2010 10:47:10 Hans Verkuil wrote: On Tuesday, November 23, 2010 01:21:45 Laurent Pinchart wrote: On Tuesday 23 November 2010 01:14:28 Hans Verkuil wrote: On Monday, November 22, 2010 12:20:25 Hans Verkuil wrote: On Monday, November 22, 2010 11:21:27

Re: Media framework backwards compatibility

2010-11-23 Thread Laurent Pinchart
the format on the connected pad at streamon time. This allows preallocating buffers for snapshot capture to lower snapshot latency. Making set_format configure the connected subdev directly would break this. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line

Re: Zooming with V4L2

2010-11-24 Thread Laurent Pinchart
space daemon, who in turn talks back to the driver to control the hardware. That's even worse. No userspace daemons please. I guess I will need to conform to the cropping/scaling interface then. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: Zooming with V4L2

2010-11-24 Thread Laurent Pinchart
then communicates with a userspace daemon. That's something you want to avoid. Apologies if I got it wrong. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[RFC/PATCH v4 0/7] V4L2 subdev userspace API

2010-11-24 Thread Laurent Pinchart
Hi everybody, Here's the fourth version of the V4L2 subdev userspace API patches. Nothing new under the sun, the patches have just been rebased on top of 2.6.37-rc3. You can find them as usual in http://git.linuxtv.org/pinchartl/media.git (media-0001-subdev-devnode branch). Laurent Pinchart (6

[RFC/PATCH v4 1/7] v4l: Share code between video_usercopy and video_ioctl2

2010-11-24 Thread Laurent Pinchart
-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-ioctl.c | 218 - 1 files changed, 71 insertions(+), 147 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index dd9283f..1e01554

[RFC/PATCH v4 2/7] v4l: subdev: Don't require core operations

2010-11-24 Thread Laurent Pinchart
There's no reason to require subdevices to implement the core operations. Remove the check for non-NULL core operations when initializing the subdev. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-subdev.h |3 +-- 1 files changed, 1 insertions(+), 2

[RFC/PATCH v4 3/7] v4l: subdev: Merge v4l2_i2c_new_subdev_cfg and v4l2_i2c_new_subdev

2010-11-24 Thread Laurent Pinchart
v4l2_i2c_new_subdev_board in the ivtv and cafe-ccic drivers. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/cafe_ccic.c | 12 +--- drivers/media/video/ivtv/ivtv-i2c.c | 12 +--- drivers/media/video/v4l2-common.c |7 ++- include/media

[RFC/PATCH v4 4/7] v4l: subdev: Add device node support

2010-11-24 Thread Laurent Pinchart
Create a device node named subdevX for every registered subdev. As the device node is registered before the subdev core::s_config function is called, return -EGAIN on open until initialization completes. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Vimarsh

[RFC/PATCH v4 7/7] v4l: subdev: Events support

2010-11-24 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/video4linux/v4l2-framework.txt | 18 ++ drivers/media/video/v4l2-subdev.c| 75 +- include/media/v4l2-subdev.h | 10 3 files changed, 102 insertions(+), 1 deletions

[RFC/PATCH v4 5/7] v4l: subdev: Uninline the v4l2_subdev_init function

2010-11-24 Thread Laurent Pinchart
The function isn't small or performance sensitive enough to be inlined. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-subdev.c | 42 +--- include/media/v4l2-subdev.h | 16 + 2 files changed, 31

[RFC/PATCH v4 6/7] v4l: subdev: Control ioctls support

2010-11-24 Thread Laurent Pinchart
Pass the control-related ioctls to the subdev driver through the core operations. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/video4linux/v4l2-framework.txt | 16 drivers/media/video/v4l2-subdev.c| 24

[RFC/PATCH v6 00/12] Media controller (core and V4L2)

2010-11-24 Thread Laurent Pinchart
on the linux-media list. I'm looking forward to the storm of comments that will start in response to this e-mail. Hopefully it won't hurt (too much) :-). Laurent Pinchart (10): media: Media device node support media: Media device media: Entities, pads and links media: Media device information

[RFC/PATCH v6 01/12] media: Media device node support

2010-11-24 Thread Laurent Pinchart
. The code is based on video/v4l2-dev.c. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/Kconfig | 13 ++ drivers/media/Makefile| 10 +- drivers/media/media-devnode.c | 321 + include/media/media-devnode.h

[RFC/PATCH v6 02/12] media: Media device

2010-11-24 Thread Laurent Pinchart
The media_device structure abstracts functions common to all kind of media devices (v4l2, dvb, alsa, ...). It manages media entities and offers a userspace API to discover and configure the media device internal topology. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

[RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-24 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- Documentation/DocBook/v4l/media-controller.xml | 20 +++ Documentation/media-framework.txt | 149 drivers/media/Makefile

[RFC/PATCH v6 05/12] media: Reference count and power handling

2010-11-24 Thread Laurent Pinchart
are increased/decreased in media_entity_get/put to prevent module unloading when an entity is referenced. Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com

[RFC/PATCH v6 06/12] media: Media device information query

2010-11-24 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/DocBook/media-entities.tmpl | 12 ++ Documentation/DocBook/v4l/media-controller.xml | 10 ++ Documentation/DocBook/v4l/media-func-close.xml | 59 + Documentation/DocBook/v4l/media-func-ioctl.xml

[RFC/PATCH v6 07/12] media: Entities, pads and links enumeration

2010-11-24 Thread Laurent Pinchart
are returned during the enumeration process. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- Documentation/DocBook/media-entities.tmpl |8 + Documentation/DocBook/v4l/media-controller.xml |2

[RFC/PATCH v6 08/12] media: Links setup

2010-11-24 Thread Laurent Pinchart
can not be activated or deactivated. Activating and deactivating a link has effects on entities' use count. Those changes are automatically propagated through the graph. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off

[RFC/PATCH v6 10/12] v4l: Add a media_device pointer to the v4l2_device structure

2010-11-24 Thread Laurent Pinchart
ownership of the drvdata anymore. To maintain compatibility with drivers that rely on v4l2_device storing a pointer to itself in the device's drvdata, v4l2_device_register() will keep doing so if the drvdata is NULL. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation

[RFC/PATCH v6 11/12] v4l: Make video_device inherit from media_entity

2010-11-24 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- Documentation/video4linux/v4l2-framework.txt | 38 +++-- drivers/media/video/v4l2-dev.c | 47 +++--- include/media/v4l2-dev.h

[RFC/PATCH v6 12/12] v4l: Make v4l2_subdev inherit from media_entity

2010-11-24 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ai...@maxwell.research.nokia.com --- Documentation/video4linux/v4l2-framework.txt | 23 ++ drivers/media/video/v4l2-device.c| 39 drivers/media/video/v4l2

[RFC/PATCH v4 00/12] Sub-device pad-level operations

2010-11-24 Thread Laurent Pinchart
/pinchartl/media.git as usual (media-0003-subdev-pad branch). Antti Koskipaa (1): v4l: v4l2_subdev userspace crop API Laurent Pinchart (10): v4l: Move the media/v4l2-mediabus.h header to include/linux v4l: Replace enums with fixed-sized fields in public structure v4l: Rename

[RFC/PATCH v4 02/12] v4l: Replace enums with fixed-sized fields in public structure

2010-11-24 Thread Laurent Pinchart
The v4l2_mbus_framefmt structure will be part of the public userspace API and used (albeit indirectly) as an ioctl argument. As such, its size must be fixed across userspace ABIs. Replace the v4l2_field and v4l2_colorspace enums by __u32 fields. Signed-off-by: Laurent Pinchart laurent.pinch

[RFC/PATCH v4 01/12] v4l: Move the media/v4l2-mediabus.h header to include/linux

2010-11-24 Thread Laurent Pinchart
The header defines the v4l2_mbus_framefmt structure which will be used by the V4L2 subdevs userspace API. Change the type of the v4l2_mbus_framefmt::code field to __u32, as enum sizes can differ between different ABIs on the same architectures. Signed-off-by: Laurent Pinchart laurent.pinch

[RFC/PATCH v4 03/12] v4l: Rename V4L2_MBUS_FMT_GREY8_1X8 to V4L2_MBUS_FMT_Y8_1X8

2010-11-24 Thread Laurent Pinchart
For consistency with the V4L2_MBUS_FMT_Y10_1X10 format. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9m001.c|2 +- drivers/media/video/mt9v022.c|4 ++-- drivers/media/video/ov6650.c | 10 +- drivers/media

[RFC/PATCH v4 05/12] v4l: Add 8-bit YUYV on 16-bit bus and SGRBG10 media bus pixel codes

2010-11-24 Thread Laurent Pinchart
- V4L2_MBUS_FMT_YVYU16_1X16 for 8-bit YVYU on 16-bit bus - V4L2_MBUS_FMT_VYUY16_1X16 for 8-bit VYUY on 16-bit bus Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/linux/v4l2-mediabus.h | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include

[RFC/PATCH v4 06/12] v4l: Add remaining RAW10 patterns w DPCM pixel code variants

2010-11-24 Thread Laurent Pinchart
This adds following formats: - V4L2_MBUS_FMT_SRGGB10_1X10 - V4L2_MBUS_FMT_SGBRG10_1X10 - V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8 - V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8 - V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8 Signed-off-by: Sergio Aguirre saagui...@ti.com Signed-off-by: Laurent Pinchart laurent.pinch

[RFC/PATCH v4 08/12] v4l: v4l2_subdev pad-level operations

2010-11-24 Thread Laurent Pinchart
Add a v4l2_subdev_pad_ops structure for the operations that need to be performed at the pad level such as format-related operations. Pad format-related operations use v4l2_mbus_framefmt instead of v4l2_format. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media

[RFC/PATCH v4 07/12] v4l: Create v4l2 subdev file handle structure

2010-11-24 Thread Laurent Pinchart
From: Stanimir Varbanov svarba...@mm-sol.com Used for storing subdev information per file handle and hold V4L2 file handle. Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com Signed-off-by: Antti Koskipaa antti.koski...@nokia.com Signed-off-by: Laurent Pinchart laurent.pinch

[RFC/PATCH v4 04/12] v4l: Group media bus pixel codes by types and sort them alphabetically

2010-11-24 Thread Laurent Pinchart
in the enumeration, so they are given an explicit numerical value. When inserting a new pixel code developers must use and update the next free value. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/linux/v4l2-mediabus.h | 77

[RFC/PATCH v4 12/12] v4l: v4l2_subdev userspace crop API

2010-11-24 Thread Laurent Pinchart
From: Antti Koskipaa antti.koski...@nokia.com This patch adds the VIDIOC_SUBDEV_S_CROP and G_CROP ioctls to the userland API. CROPCAP is not implemented because it's redundant. Signed-off-by: Antti Koskipaa antti.koski...@nokia.com Signed-off-by: Laurent Pinchart laurent.pinch

<    1   2   3   4   5   6   7   8   9   10   >