Re: PATCH- gspca: added chipset revision sensor

2009-12-15 Thread Luis Maia

Jean-Francois Moine wrote:

On Tue, 15 Dec 2009 03:45:00 +
Luis Maia lm...@royalhat.org wrote:

  
Added extra chipset revision (sensor) to fix camera zc0301 with  ID: 
0ac8:301b .

Since i own one of this cameras fixed and tested it.



  

-

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c 
linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
--- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c2009-12-14 
17:47:25.0 +

+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
2009-12-15 02:42:13.0 +
@@ -6868,6 +6868,7 @@
 {0x8001, 0x13},
 {0x8000, 0x14},/* CS2102K */
 {0x8400, 0x15},/* TAS5130K */
+{0xe400, 0x15},
 };
 
 static int vga_3wr_probe(struct gspca_dev *gspca_dev)

@@ -7634,7 +7635,7 @@
 {USB_DEVICE(0x0698, 0x2003)},
 {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
 {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-{USB_DEVICE(0x0ac8, 0x301b)},
+{USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
 {USB_DEVICE(0x0ac8, 0x303b)},
 {USB_DEVICE(0x0ac8, 0x305b), .driver_info =
SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},



Hello Luis,

I don't understand your patch:
1) you added 0xe400 in the chipset table giving the sensor tas5130c K
2) in the device table you say that the 0ac8:301b sensor is a pb0330
   (but this information is not used: the sensor type in .driver_info
   may be only pas106 for sif probe or mc501cb/tas5130_vf0250 for no
   probe.

What is exactly the sensor of your webcam?

  


Sensor for my webcam is tas5130K, sorry my bad .i forgot to remove the line 
from .driver_info and didn't noticed.
Thus correct information is on the device table.
I bought a pack of webcams from the same suplier with same model for friends, 
i'm waiting for feedback from the patch.


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: PATCH- gspca: added chipset revision sensor

2009-12-15 Thread Luis Maia
I found an email that discussed the similar problem that my camera had, 
showing up just a black screen, it's dated but  i think maybe it wasn't 
fully solved because there's no answer.


http://osdir.com/ml/drivers.spca50x.devel/2006-11/msg00036.html

Note the : /  /Vimicro/zc3xx.h: [zcxx_probeSensor:307] sensor 3w Vga 
??? 0xC400


/Do you know if this was solved?!
Because i suspect that maybe there are more 0x?400 revision of the chipset.
Btw, if this is a pattern could we consider to mask the bits in retword 
(retword = 0x0FFF)?

Because looking at the current table it seems to make more sense.

Best regards,
Luis Maia.
Jean-Francois Moine wrote:

On Tue, 15 Dec 2009 10:25:29 -0300
leandro Costantino lcostant...@gmail.com wrote:

  

Jean,
let me know , if you need to the test this patch, since i added the
tas1530k long time ago, and still have the webcam :)
Best Regards

On Tue, Dec 15, 2009 at 4:54 AM, Jean-Francois Moine
moin...@free.fr wrote:


On Tue, 15 Dec 2009 03:45:00 +
Luis Maia lm...@royalhat.org wrote:

  

Added extra chipset revision (sensor) to fix camera zc0301 with
 ID: 0ac8:301b .
Since i own one of this cameras fixed and tested it.

-


diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c
linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
--- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c2009-12-14
17:47:25.0 +
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
2009-12-15 02:42:13.0 +
@@ -6868,6 +6868,7 @@
 {0x8001, 0x13},
 {0x8000, 0x14},/* CS2102K */
 {0x8400, 0x15},/* TAS5130K */
+{0xe400, 0x15},
 };

 static int vga_3wr_probe(struct gspca_dev *gspca_dev)
@@ -7634,7 +7635,7 @@
 {USB_DEVICE(0x0698, 0x2003)},
 {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
 {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-{USB_DEVICE(0x0ac8, 0x301b)},
+{USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
 {USB_DEVICE(0x0ac8, 0x303b)},
 {USB_DEVICE(0x0ac8, 0x305b), .driver_info =
SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},



Hello Luis and Leandro,

Thanks for the patch. Luis said his sensor is the tas5130K, so the 2nd
part of the patch is useless. But, maybe, Leandro, have you heard about
other chipset revision IDs?

Best regards.

  


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


PATCH- gspca: added chipset revision sensor

2009-12-14 Thread Luis Maia

Hello,

Added extra chipset revision (sensor) to fix camera zc0301 with  ID: 
0ac8:301b .

Since i own one of this cameras fixed and tested it.

Best Regards,
Luis Maia

-

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c 
linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
--- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c2009-12-14 
17:47:25.0 +
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c2009-12-15 
02:42:13.0 +

@@ -6868,6 +6868,7 @@
{0x8001, 0x13},
{0x8000, 0x14},/* CS2102K */
{0x8400, 0x15},/* TAS5130K */
+{0xe400, 0x15},
};

static int vga_3wr_probe(struct gspca_dev *gspca_dev)
@@ -7634,7 +7635,7 @@
{USB_DEVICE(0x0698, 0x2003)},
{USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
{USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-{USB_DEVICE(0x0ac8, 0x301b)},
+{USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
{USB_DEVICE(0x0ac8, 0x303b)},
{USB_DEVICE(0x0ac8, 0x305b), .driver_info = SENSOR_TAS5130C_VF0250},
{USB_DEVICE(0x0ac8, 0x307b)},

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c 
linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
--- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c2009-12-14 
17:47:25.0 +
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c  2009-12-15 
02:42:13.0 +
@@ -6868,6 +6868,7 @@
{0x8001, 0x13},
{0x8000, 0x14}, /* CS2102K */
{0x8400, 0x15}, /* TAS5130K */
+   {0xe400, 0x15},
 };
 
 static int vga_3wr_probe(struct gspca_dev *gspca_dev)
@@ -7634,7 +7635,7 @@
{USB_DEVICE(0x0698, 0x2003)},
{USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
{USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-   {USB_DEVICE(0x0ac8, 0x301b)},
+   {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
{USB_DEVICE(0x0ac8, 0x303b)},
{USB_DEVICE(0x0ac8, 0x305b), .driver_info = SENSOR_TAS5130C_VF0250},
{USB_DEVICE(0x0ac8, 0x307b)},