[PATCH v4 12/14] cx231xx: remove direct register PWR_CTL_EN modification that switches port3

2014-10-30 Thread Matthias Schwarzott
The only remaining place that modifies the relevant bit is in function cx231xx_set_Colibri_For_LowIF Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c

[PATCH v4 13/14] cx231xx: drop unconditional port3 switching

2014-10-30 Thread Matthias Schwarzott
All switching should be done by i2c mux adapters. Drop explicit dont_use_port_3 flag. Drop info message about switch. Only the removed code in start_streaming is questionable: It did switch the port_3 flag without accessing i2c in between. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti

[PATCH v4 07/14] cx231xx: add wrapper to get the i2c_adapter pointer

2014-10-30 Thread Matthias Schwarzott
This is a preparation for mapping I2C_1_MUX_1 and I2C_1_MUX_3 later to the seperate muxed i2c adapters. Map mux adapters to I2C_1 for now. Add local variables for i2c_adapters in dvb_init to get line lengths shorter. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari

[PATCH v4 14/14] cx231xx: scan all four existing i2c busses instead of the 3 masters

2014-10-30 Thread Matthias Schwarzott
The scanning itself just fails (as before this series) but now the correct busses are scanned. V2: Changed to symbolic names where muxed adapters can be seen directly. V3: Comment about scanning busses ordered by physical port numbers. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti

[PATCH v4 08/14] cx231xx: remember status of i2c port_3 switch

2014-10-30 Thread Matthias Schwarzott
This is used later for is_tuner function that switches i2c behaviour for some tuners. V2: Add comments about possible improvements for port_3 switch function. V3: Fix coding style. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 12 drivers

[PATCH v4 03/14] cx231xx: delete i2c_client per bus

2014-10-30 Thread Matthias Schwarzott
For each i2c master there is a i2c_client allocated that could be deleted now that its only two users have been changed to use their own i2c_client. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 7 --- drivers/media/usb

[PATCH v4 00/14] cx231xx: Use muxed i2c adapters instead of custom switching

2014-10-30 Thread Matthias Schwarzott
Hi! This time the series got only small updates from Antti's review. Additionally I added a patch to no longer directly modify the content of the port3 switch bit in PWR_CTL_EN (from function cx231xx_set_power_mode). Now there are two places where I wonder what happens: 1. cx231xx_set_Colibri_F

[PATCH v4 02/14] cx231xx: use own i2c_client for eeprom access

2014-10-30 Thread Matthias Schwarzott
This is a preparation for deleting the otherwise useless i2c_clients that are allocated for all the i2c master adapters. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-cards.c | 24 +--- 1 file changed, 13 insertions

[PATCH V3 12/13] cx231xx: drop unconditional port3 switching

2014-10-01 Thread Matthias Schwarzott
All switching should be done by i2c mux adapters. Drop explicit dont_use_port_3 flag. Drop info message about switch. Only the removed code in start_streaming is questionable: It did switch the port_3 flag without accessing i2c in between. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti

[PATCH V3 11/13] cx231xx: register i2c mux adapters for master1 and use as I2C_1_MUX_1 and I2C_1_MUX_3

2014-10-01 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/Kconfig| 1 + drivers/media/usb/cx231xx/cx231xx-core.c | 5 drivers/media/usb/cx231xx/cx231xx-i2c.c | 44 +++- drivers/media/usb/cx231xx/cx231xx.h | 4

[PATCH V3 09/13] cx231xx: let is_tuner check the real i2c port and not the i2c master number

2014-10-01 Thread Matthias Schwarzott
Get used i2c port from bus_nr and status of port_3 switch. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx

[PATCH V3 13/13] cx231xx: scan all four existing i2c busses instead of the 3 masters

2014-10-01 Thread Matthias Schwarzott
The scanning itself just fails (as before this series) but now the correct busses are scanned. V2: Changed to symbolic names where muxed adapters can be seen directly. V3: Comment about scanning busses ordered by physical port numbers. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti

[PATCH V3 10/13] cx231xx: change usage of I2C_1 to the real i2c port

2014-10-01 Thread Matthias Schwarzott
change almost all instances of I2C_1 to I2C_1_MUX_3 Only these cases are changed to I2C_1_MUX_1: * All that have dont_use_port_3 set. * CX231XX_BOARD_HAUPPAUGE_EXETER, old code did explicitly not switch to port3. * eeprom access for 930C Signed-off-by: Matthias Schwarzott Reviewed-by: Antti

[PATCH V3 05/13] cx231xx: Modifiy the symbolic constants for i2c ports and describe

2014-10-01 Thread Matthias Schwarzott
Change to I2C_0 ... I2C_2 for the master ports and add I2C_1_MUX_1 and I2C_1_MUX_3 for the muxed ones. V2: Renamed mux adapters to seperate them from master adapters. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx.h | 9 + 1 file

[PATCH V3 07/13] cx231xx: add wrapper to get the i2c_adapter pointer

2014-10-01 Thread Matthias Schwarzott
This is a preparation for mapping I2C_1_MUX_1 and I2C_1_MUX_3 later to the seperate muxed i2c adapters. Map mux adapters to I2C_1 for now. Add local variables for i2c_adapters in dvb_init to get line lengths shorter. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari

[PATCH V3 04/13] cx231xx: give each master i2c bus a seperate name

2014-10-01 Thread Matthias Schwarzott
V2: Use snprintf to construct the complete name Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c index a30d400

[PATCH V3 02/13] cx231xx: use own i2c_client for eeprom access

2014-10-01 Thread Matthias Schwarzott
This is a preparation for deleting the otherwise useless i2c_clients that are allocated for all the i2c master adapters. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-cards.c | 24 +--- 1 file changed, 13 insertions

cx231xx: Use muxed i2c adapters instead of custom switching

2014-10-01 Thread Matthias Schwarzott
This series changes cx231xx driver to use standard muxed i2c busses. Everything works as before (tested with Hauppauge WinTV-930C-HD). Also the scanning is changed to these new busses, but still does not work (as before). Change scanning to read 1 byte instead of 0 only works for one bus. V2: T

[PATCH V3 06/13] cx231xx: Use symbolic constants for i2c ports instead of numbers

2014-10-01 Thread Matthias Schwarzott
Replace numbers by the constants of same value and same meaning. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-cards.c | 62 +++ 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/media/usb

[PATCH V3 01/13] cx231xx: let i2c bus scanning use its own i2c_client

2014-10-01 Thread Matthias Schwarzott
This is a preparation for deleting the otherwise useless i2c_clients that are allocated for all the i2c master adapters. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 17 +++-- drivers/media/usb/cx231xx/cx231xx.h

[PATCH V3 08/13] cx231xx: remember status of i2c port_3 switch

2014-10-01 Thread Matthias Schwarzott
This is used later for is_tuner function that switches i2c behaviour for some tuners. V2: Add comments about possible improvements for port_3 switch function. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 10 ++ drivers/media/usb/cx231xx/cx231xx.h

[PATCH V3 03/13] cx231xx: delete i2c_client per bus

2014-10-01 Thread Matthias Schwarzott
For each i2c master there is a i2c_client allocated that could be deleted now that its only two users have been changed to use their own i2c_client. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 7 --- drivers/media/usb

Re: [PATCH V2 04/13] cx231xx: give each master i2c bus a seperate name

2014-10-01 Thread Matthias Schwarzott
On 01.10.2014 21:22, Antti Palosaari wrote: > > > On 10/01/2014 08:20 AM, Matthias Schwarzott wrote: >> Signed-off-by: Matthias Schwarzott >> --- >> drivers/media/usb/cx231xx/cx231xx-i2c.c | 5 + >> 1 file changed, 5 insertions(+) >> >> d

Re: [PATCH V2 13/13] cx231xx: scan all four existing i2c busses instead of the 3 masters

2014-10-01 Thread Matthias Schwarzott
omment to the code. Regards Matthias > > On 10/01/2014 08:20 AM, Matthias Schwarzott wrote: >> The scanning itself just fails (as before this series) but now the >> correct busses are scanned. >> >> V2: Changed to symbolic names where muxed adapters can be seen di

Re: [PATCH V2 08/13] cx231xx: remember status of i2c port_3 switch

2014-10-01 Thread Matthias Schwarzott
t; Antti > > > > On 10/01/2014 08:20 AM, Matthias Schwarzott wrote: >> If remembering is not stable enough, this must be changed to query >> from the register when needed. >> >> Signed-off-by: Matthias Schwarzott >> --- >> drivers/media/usb/cx231xx/c

Re: [PATCH V2 2/2] si2165: do load firmware without extra header

2014-09-30 Thread Matthias Schwarzott
On 01.10.2014 07:58, Matthias Schwarzott wrote: > The new file has a different name: dvb-demod-si2165-d.fw > > Count blocks instead of reading count from extra header. > Calculate CRC during upload and compare result to what chip calcuated. > Use 0x01 instead of real patch versio

[PATCH V2 1/2] get_dvb_firmware: si2165: drop the extra header from the firmware

2014-09-30 Thread Matthias Schwarzott
Store it with a different name based on hardware revision. V2: change firmware filename to lower case. Signed-off-by: Matthias Schwarzott --- Documentation/dvb/get_dvb_firmware | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/Documentation/dvb

[PATCH V2 2/2] si2165: do load firmware without extra header

2014-09-30 Thread Matthias Schwarzott
check the version of it. V2: change firmware filename to lower case. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/Kconfig | 1 + drivers/media/dvb-frontends/si2165.c | 105 ++ drivers/media/dvb-frontends/si2165_priv.h | 2 +- 3

[PATCH V2 10/13] cx231xx: change usage of I2C_1 to the real i2c port

2014-09-30 Thread Matthias Schwarzott
change almost all instances of I2C_1 to I2C_1_MUX_3 Only these cases are changed to I2C_1_MUX_1: * All that have dont_use_port_3 set. * CX231XX_BOARD_HAUPPAUGE_EXETER, old code did explicitly not switch to port3. * eeprom access for 930C Signed-off-by: Matthias Schwarzott --- drivers/media/usb

[PATCH V2 13/13] cx231xx: scan all four existing i2c busses instead of the 3 masters

2014-09-30 Thread Matthias Schwarzott
The scanning itself just fails (as before this series) but now the correct busses are scanned. V2: Changed to symbolic names where muxed adapters can be seen directly. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-core.c | 6 ++ drivers/media/usb/cx231xx/cx231xx

[PATCH V2 11/13] cx231xx: register i2c mux adapters for master1 and use as I2C_1_MUX_1 and I2C_1_MUX_3

2014-09-30 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/Kconfig| 1 + drivers/media/usb/cx231xx/cx231xx-core.c | 5 drivers/media/usb/cx231xx/cx231xx-i2c.c | 44 +++- drivers/media/usb/cx231xx/cx231xx.h | 4 +++ 4 files changed, 53

[PATCH V2 12/13] cx231xx: drop unconditional port3 switching

2014-09-30 Thread Matthias Schwarzott
All switching should be done by i2c mux adapters. Drop explicit dont_use_port_3 flag. Drop info message about switch. Only the removed code in start_streaming is questionable: It did switch the port_3 flag without accessing i2c in between. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti

[PATCH V2 05/13] cx231xx: Modifiy the symbolic constants for i2c ports and describe

2014-09-30 Thread Matthias Schwarzott
Change to I2C_0 ... I2C_2 for the master ports and add I2C_1_MUX_1 and I2C_1_MUX_3 for the muxed ones. V2: Renamed mux adapters to seperate them from master adapters. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx.h | 9 + 1 file changed, 5 insertions(+), 4

[PATCH V2 07/13] cx231xx: add wrapper to get the i2c_adapter pointer

2014-09-30 Thread Matthias Schwarzott
This is a preparation for mapping I2C_1_MUX_1 and I2C_1_MUX_3 later to the seperate muxed i2c adapters. Map mux adapters to I2C_1 for now. Add local variables for i2c_adapters in dvb_init to get line lengths shorter. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx

[PATCH V2 08/13] cx231xx: remember status of i2c port_3 switch

2014-09-30 Thread Matthias Schwarzott
If remembering is not stable enough, this must be changed to query from the register when needed. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +++ drivers/media/usb/cx231xx/cx231xx.h| 1 + 2 files changed, 4 insertions(+) diff --git a/drivers

[PATCH V2 09/13] cx231xx: let is_tuner check the real i2c port and not the i2c master number

2014-09-30 Thread Matthias Schwarzott
Get used i2c port from bus_nr and status of port_3 switch. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx

[PATCH V2 06/13] cx231xx: Use symbolic constants for i2c ports instead of numbers

2014-09-30 Thread Matthias Schwarzott
Replace numbers by the constants of same value and same meaning. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-cards.c | 62 +++ 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/media/usb

[PATCH V2 01/13] cx231xx: let i2c bus scanning use its own i2c_client

2014-09-30 Thread Matthias Schwarzott
This is a preparation for deleting the otherwise useless i2c_clients that are allocated for all the i2c master adapters. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 17 +++-- drivers/media/usb/cx231xx/cx231xx.h

[PATCH V2 00/13] cx231xx: Use muxed i2c adapters instead of custom switching

2014-09-30 Thread Matthias Schwarzott
This series changes cx231xx driver to use standard muxed i2c busses. Everything works as before (tested with Hauppauge WinTV-930C-HD). Also the scanning is changed to these new busses, but still does not work (as before). Change scanning to read 1 byte instead of 0 only works for one bus. V2: T

[PATCH V2 02/13] cx231xx: use own i2c_client for eeprom access

2014-09-30 Thread Matthias Schwarzott
This is a preparation for deleting the otherwise useless i2c_clients that are allocated for all the i2c master adapters. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-cards.c | 24 +--- 1 file changed, 13 insertions

[PATCH V2 04/13] cx231xx: give each master i2c bus a seperate name

2014-09-30 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c index a30d400..178fa48 100644 --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c

[PATCH V2 03/13] cx231xx: delete i2c_client per bus

2014-09-30 Thread Matthias Schwarzott
For each i2c master there is a i2c_client allocated that could be deleted now that its only two users have been changed to use their own i2c_client. Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 7 --- drivers/media/usb

Re: [PATCH 04/12] cx231xx: give each master i2c bus a seperate name

2014-09-25 Thread Matthias Schwarzott
On 25.09.2014 17:04, Antti Palosaari wrote: > So this patch adds bus number to adapter name as postfix? > > "cx231xx" => "cx231xx-1" > Yes, it is attached, and the result looks like * cx231xx #0-0 * cx231xx #0-1 * cx231xx #0-2 > I have no clear opinion for that. I think name should be given when

Re: [PATCH 02/12] cx231xx: use own i2c_client for eeprom access

2014-09-25 Thread Matthias Schwarzott
prom chips uses REPEATED START condition > for reads (means it could be broken even now). > > regards > Antti > > On 09/25/2014 08:07 AM, Matthias Schwarzott wrote: >> Signed-off-by: Matthias Schwarzott >> --- >> drivers/media/usb/cx231xx/cx231xx-cards.c | 24

[PATCH 04/12] cx231xx: give each master i2c bus a seperate name

2014-09-24 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c index a30d400..178fa48 100644 --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c

[PATCH 02/12] cx231xx: use own i2c_client for eeprom access

2014-09-24 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-cards.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c index 791f00c..092fb85 100644

[PATCH 07/12] cx231xx: remember status of port_3 switch

2014-09-24 Thread Matthias Schwarzott
Is remembering stable enough, or must this state be queried from the register when needed. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +++ drivers/media/usb/cx231xx/cx231xx.h| 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/media

[PATCH 05/12] cx231xx: Use symbolic constants for i2c ports

2014-09-24 Thread Matthias Schwarzott
use already existing I2C_0 ... I2C_3 Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-cards.c | 62 +++ drivers/media/usb/cx231xx/cx231xx.h | 8 ++-- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/media/usb

[PATCH 12/12] cx231xx: scan all four existing i2c busses instead of the 3 masters

2014-09-24 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-core.c | 6 ++ drivers/media/usb/cx231xx/cx231xx-i2c.c | 8 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c

[PATCH 11/12] cx231xx: drop unconditional port3 switching

2014-09-24 Thread Matthias Schwarzott
All switching should be done by i2c mux adapters. Drop explicit dont_use_port_3 flag. Drop info message about switch. Only the removed code in start_streaming is questionable: It did switch the port_3 flag without accessing i2c in between. Signed-off-by: Matthias Schwarzott --- drivers/media

[PATCH 10/12] cx231xx: register i2c mux adapters for master1 and use as I2C_1 and I2C_3

2014-09-24 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/Kconfig| 1 + drivers/media/usb/cx231xx/cx231xx-core.c | 5 drivers/media/usb/cx231xx/cx231xx-i2c.c | 45 ++-- drivers/media/usb/cx231xx/cx231xx.h | 4 +++ 4 files changed, 53

[PATCH 08/12] cx231xx: let is_tuner check the real i2c port and not the i2c master number

2014-09-24 Thread Matthias Schwarzott
get used i2c port from bus_nr and status of port_3 switch Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx

[PATCH 03/12] cx231xx: delete i2c_client per bus

2014-09-24 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 7 --- drivers/media/usb/cx231xx/cx231xx.h | 1 - 2 files changed, 8 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c index 67a1391..a30d400

[PATCH 06/12] cx231xx: add wrapper to get the i2c_adapter pointer

2014-09-24 Thread Matthias Schwarzott
Already map unused I2C_3 to adapter number 1 to prepare for switching. Add local variables for i2c_adapters in dvb_init to get line lengths shorter. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-cards.c | 8 +++--- drivers/media/usb/cx231xx/cx231xx-dvb.c | 42

[PATCH 09/12] cx231xx: change usage of I2C_1 to the real i2c port

2014-09-24 Thread Matthias Schwarzott
change almost all instances of I2C_1 to I2C_3 Keep I2C_1 for these cases: * All that have dont_use_port_3 set. * CX231XX_BOARD_HAUPPAUGE_EXETER, old code did explicitly not switch to port3. * eeprom access for 930C Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx

[PATCH 01/12] cx231xx: let i2c bus scanning use its own i2c_client

2014-09-24 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-i2c.c | 17 +++-- drivers/media/usb/cx231xx/cx231xx.h | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx

Re: [PATCH 7/7] si2165: do load firmware without extra header

2014-09-22 Thread Matthias Schwarzott
On 23.09.2014 00:58, Mauro Carvalho Chehab wrote: > Em Sun, 31 Aug 2014 13:35:12 +0200 > Matthias Schwarzott escreveu: > >> The new file has a different name: dvb-demod-si2165-D.fw >> >> Count blocks instead of reading count from extra header. >> Calculate CRC du

[PATCH] cx231xx: use i2c mux instead of own switching

2014-09-21 Thread Matthias Schwarzott
and are automatically scanned. This patch should be tested for more of the affected devices to make sure it is correct. To get rid of lines greater 80 columns one could save the tuner and demod i2c_adap in local variables. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx

[PATCH] Si2165: Add experimental DVB-C support for HVR-4400/HVR-5500

2014-09-09 Thread Matthias Schwarzott
This patch is sent out, because I got multiple requests for it. So here it is. It works only for HVR-4400/HVR-5500. For WinTV-HVR-930C-HD it fails with bad/no reception for unknown reasons. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/si2165.c | 132

[PATCH 4/7] [media] cx231xx: Add support for Hauppauge WinTV-HVR-901H (1114xx)

2014-08-31 Thread Matthias Schwarzott
: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-cards.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c index a03a31a..791f00c 100644 --- a/drivers/media/usb/cx231xx/cx231xx

[PATCH 3/7] [media] cx231xx: Add support for Hauppauge WinTV-HVR-900H (111xxx)

2014-08-31 Thread Matthias Schwarzott
Add support for: [2040:b138] Hauppauge WinTV HVR-900H (111xxx) The hardware is similar to [2040:b130] Hauppauge WinTV 930C-HD (model 1113xx) The only difference is the demod Si2161 instead of Si2165 (but both are supported by the si2165 driver). Signed-off-by: Matthias Schwarzott

[PATCH 6/7] get_dvb_firmware: si2165: drop the extra header from the firmware

2014-08-31 Thread Matthias Schwarzott
Store it with a different name based on hardware revision. Signed-off-by: Matthias Schwarzott --- Documentation/dvb/get_dvb_firmware | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/Documentation/dvb/get_dvb_firmware b/Documentation/dvb/get_dvb_firmware

[PATCH 5/7] [media] mceusb: add support for more cx231xx devices

2014-08-31 Thread Matthias Schwarzott
model 1113xx) Signed-off-by: Matthias Schwarzott --- drivers/media/rc/mceusb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index 45b0894..383e24a 100644 --- a/drivers/media/rc/mceusb.c +++ b/drivers/media/rc/mceusb.c @@ -397,6 +3

[PATCH 0/7] Add support for Si2161 demod and improve firmware handling

2014-08-31 Thread Matthias Schwarzott
This series adds support for Si2161 based devices. cx231xx based WinTV-HVR-900-H works with it. cx231xx based WinTV-HVR-901-H should also work. Additionally it simplifies firmware structure by no longer adding a seperate header as suggested by Antti. Regards Matthias -- To unsubscribe from thi

[PATCH 7/7] si2165: do load firmware without extra header

2014-08-31 Thread Matthias Schwarzott
check the version of it. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/Kconfig | 1 + drivers/media/dvb-frontends/si2165.c | 105 ++ drivers/media/dvb-frontends/si2165_priv.h | 2 +- 3 files changed, 66 insertions(+), 42 deletions

[PATCH 1/7] si2165: Load driver for all hardware revisions

2014-08-31 Thread Matthias Schwarzott
Current firmware is only for revision D. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/si2165.c | 26 +- drivers/media/dvb-frontends/si2165_priv.h | 2 +- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/media/dvb

[PATCH 2/7] si2165: enable Si2161 support

2014-08-31 Thread Matthias Schwarzott
Additionally print chip name with revision symbolically. This is a preparation for supporting new Hauppauge WinTV-HVR-900-H based on cx231xx. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/si2165.c | 39 +--- 1 file changed, 27 insertions

Re: [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator

2014-08-31 Thread Matthias Schwarzott
On 27.08.2014 17:29, tsk...@gmail.com wrote: > From: Akihiro Tsukada > Hi Akihiro, > This patch adds driver for tc90522 demodulator chips. > The chip contains 4 demod modules that run in parallel and are independently > controllable via separate I2C addresses. > Two of the modules are for ISDB-T

Re: [PATCH] m88ts2022: fix high symbol rate transponders missing on 32bit platform.

2014-08-16 Thread Matthias Schwarzott
On 16.08.2014 14:53, Antti Palosaari wrote: > > > I will look that more carefully on end of next week, go through possible > symbol rates and rounding errors. > > Maybe it should be something like that (didn't test any way, may not > even compile): > f_3db_hz = div_u64((u64) (c->symbol_rate * 13

[PATCH] si2165: change return type of si2165_wait_init_done from bool to int

2014-08-04 Thread Matthias Schwarzott
In case of an error -EINVAL will be mis-casted to 1. This was triggered by a coccinelle warning. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/si2165.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers

Re: [media] si2165: Add demod driver for DVB-T only

2014-08-02 Thread Matthias Schwarzott
On 01.08.2014 17:23, Dan Carpenter wrote: > Hello Matthias Schwarzott, > Hello Dan, > The patch 3e54a1697ace: "[media] si2165: Add demod driver for DVB-T > only" from Jul 22, 2014, leads to the following static checker > warning: > > drivers/m

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

2014-07-30 Thread Matthias Schwarzott
On 29.07.2014 21:45, Antti Palosaari wrote: > > Do you need to know whole firmware version? There is only 1 byte to be used and it is called patch version. > How did you obtain it, from > sniff? Yes - but it also is visible in code near crc version (see below). > What happens if you don't tell fw

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

2014-07-29 Thread Matthias Schwarzott
On 29.07.2014 13:34, Antti Palosaari wrote: > > > On 07/29/2014 11:53 AM, Antonio Ospite wrote: >> On Tue, 29 Jul 2014 07:37:44 +0200 >> Matthias Schwarzott wrote: >> >>> On 23.07.2014 22:10, Antonio Ospite wrote: >>>> On Wed, 23 Jul 201

Re: [PATCH] [media] mceusb: select default keytable based on vendor

2014-07-29 Thread Matthias Schwarzott
On 29.07.2014 16:06, Mauro Carvalho Chehab wrote: > Em Tue, 29 Jul 2014 07:45:29 +0200 > Matthias Schwarzott escreveu: > >> On 27.07.2014 22:47, Mauro Carvalho Chehab wrote: >>> Some vendors have their on keymap table that are used on >>> all (or almost all) m

Re: [PATCH] [media] mceusb: select default keytable based on vendor

2014-07-28 Thread Matthias Schwarzott
On 27.07.2014 22:47, Mauro Carvalho Chehab wrote: > Some vendors have their on keymap table that are used on > all (or almost all) models for that vendor. > > So, instead of specifying the keymap table per USB ID, > let's use the Vendor ID's table by default. > > At the end, this will mean less c

Re: [PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-28 Thread Matthias Schwarzott
arvalho Chehab escreveu: >>> >>>> Em Sun, 27 Jul 2014 11:32:26 +0200 >>>> Matthias Schwarzott escreveu: >>>> >>>>> >>>>> Hi Mauro. >>>>> >>>>> On 26.07.2014 21:27, Mauro Carvalho Chehab wro

Re: [PATCH] si2135: Declare the structs even if frontend is not enabled

2014-07-28 Thread Matthias Schwarzott
On 28.07.2014 15:38, Mauro Carvalho Chehab wrote: > As reported by Kbuildtest: > >In file included from drivers/media/usb/cx231xx/cx231xx-dvb.c:35:0: >drivers/media/dvb-frontends/si2165.h:57:9: warning: 'struct si2165_config' > declared inside parameter list [enabled by default] > st

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

2014-07-28 Thread Matthias Schwarzott
On 23.07.2014 22:10, Antonio Ospite wrote: > On Wed, 23 Jul 2014 21:03:14 +0200 > Matthias Schwarzott wrote: > > [...] >> The crc value: >> It protects the content of the file until it is in the demod - so >> calculating it on my own would only check if the data is

Re: [PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-27 Thread Matthias Schwarzott
Hi Mauro. On 26.07.2014 21:27, Mauro Carvalho Chehab wrote: > Tried to apply your patch series, but there's something wrong on it. > > See the enclosed logs. I suspect that you missed a patch adding the > proper tuner for this device. well, tuner_type is set to TUNER_ABSENT, and for me the oops

Re: [PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

2014-07-23 Thread Matthias Schwarzott
On 23.07.2014 11:20, Antti Palosaari wrote: > Moikka Matthias > Moikka Antti, > On 07/22/2014 11:12 PM, Matthias Schwarzott wrote: >> + >> +my $CRC="\x0A\xCC"; >> +my $BLOCKS_MAIN="\x27"; >> +open FW,">$fwfile"; >

[PATCH 3/8] cx23885: Add si2165 support for HVR-5500

2014-07-22 Thread Matthias Schwarzott
The same card entry is used for HVR-4400 and HVR-5500. Only HVR-5500 has been tested. Signed-off-by: Matthias Schwarzott --- drivers/media/pci/cx23885/Kconfig | 1 + drivers/media/pci/cx23885/cx23885-cards.c | 17 +--- drivers/media/pci/cx23885/cx23885-dvb.c | 43

[PATCH 1/8] get_dvb_firmware: Add firmware extractor for si2165

2014-07-22 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- Documentation/dvb/get_dvb_firmware | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Documentation/dvb/get_dvb_firmware b/Documentation/dvb/get_dvb_firmware index d91b8be..26c623d 100755 --- a

[PATCH 2/8] si2165: Add demod driver for DVB-T only

2014-07-22 Thread Matthias Schwarzott
DVB-T was tested with 8MHz BW channels in germany This driver is the simplest possible, it uses automatic mode for all parameters (TPS). Added spectrum inversion support. Signed-off-by: Matthias Schwarzott --- drivers/media/dvb-frontends/Kconfig |9 + drivers/media/dvb-frontends

[PATCH 0/8] add si2165 demod driver

2014-07-22 Thread Matthias Schwarzott
This series adds support for Si2165 demod. The driver is DVB-T only for now. Then it adds support for these devices: * Hauppauge WinTV 930C-HD model 1113xx * Hauppauge WinTV 930C-HD model 1114xx * Hauppauge HVR-5500 (add DVB-T support) * PCTV QuatroStick 521e * PCTV QuatroStick 522e Regards Matth

[PATCH 8/8] cx231xx: Add [2013:025e] PCTV QuatroStick 522e

2014-07-22 Thread Matthias Schwarzott
The hardware is identical to Hauppauge WinTV 930C-HD (model 1114xx) Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-cards.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx

[PATCH 6/8] cx231xx: Add digital support for [2040:b131] Hauppauge WinTV 930C-HD (model 1114xx)

2014-07-22 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/Kconfig | 1 + drivers/media/usb/cx231xx/cx231xx-cards.c | 42 + drivers/media/usb/cx231xx/cx231xx-dvb.c | 63 +++ drivers/media/usb/cx231xx/cx231xx.h | 1 + 4 files

[PATCH 7/8] cx231xx: Add [2013:0259] PCTV QuatroStick 521e

2014-07-22 Thread Matthias Schwarzott
The hardware is identical to Hauppauge WinTV 930C-HD (model 1113xx) Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-cards.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx

[PATCH 4/8] cx231xx: prepare for i2c_client attachment

2014-07-22 Thread Matthias Schwarzott
This is needed to support PCTV QuatroStick 522e which uses a si2157. The si2157 driver is written using i2c_client attachment. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/usb/cx231xx

[PATCH 5/8] cx231xx: Add digital support for [2040:b130] Hauppauge WinTV 930C-HD (model 1113xx)

2014-07-22 Thread Matthias Schwarzott
After loading the driver the first open to dvb device node fails. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/Kconfig | 1 + drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 + drivers/media/usb/cx231xx/cx231xx-cards.c | 92 ++ drivers

Re: [PATCH] si2157: Fix DVB-C bandwidth.

2014-07-22 Thread Matthias Schwarzott
On 22.07.2014 13:09, Luis Alves wrote: > This patch fixes DVB-C reception. > Without setting the bandwidth to 8MHz the received stream gets corrupted. Hi Luis, I also wonder if some code should default to bandwidth of 8MHz if none is set. But then I grepped for it and found code in drivers/media

Different Devices identical hardware

2014-07-21 Thread Matthias Schwarzott
Hi, I want to add support for Hauppauge WinTV 930C-HD and PCTV QuatroStick 521e. The namess and USB-IDs are different, but the hardware is the same. Should there be in this case one card entry in cx231xx driver or two? Two would have the advantage that the correct name of the device could be disp

[PATCH 3/3] si2157: Add support for spectral inversion

2014-07-15 Thread Matthias Schwarzott
This is needed for PCTV 522e support. Signed-off-by: Matthias Schwarzott --- drivers/media/tuners/si2157.c | 3 +++ drivers/media/tuners/si2157.h | 5 + drivers/media/tuners/si2157_priv.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/media/tuners/si2157.c b/drivers

[PATCH 2/3] em28xx-dvb: Prepare for si2157 driver getting more parameters

2014-07-15 Thread Matthias Schwarzott
Modify all users of si2157_config to correctly initialize all not listed values to 0. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/em28xx/em28xx-dvb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c

[PATCH 1/3] cxusb: Prepare for si2157 driver getting more parameters

2014-07-15 Thread Matthias Schwarzott
Modify all users of si2157_config to correctly initialize all not listed values to 0. Signed-off-by: Matthias Schwarzott --- drivers/media/usb/dvb-usb/cxusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb/cxusb.c b/drivers/media/usb/dvb-usb/cxusb.c index ad20c39

Re: [PATCH 1/2] si2157: Add support for spectrum inversion

2014-07-15 Thread Matthias Schwarzott
On 15.07.2014 13:08, Antti Palosaari wrote: > Moikka Matthias! > Idea of patch is correct, but I think implementation not. You set FE to > si2157_config on variable define, but on that point FE is NULL. FE > pointer is populated by demodulator driver, si2168. Right? Right, I looked into si2168_pro

[PATCH 2/2] si2157: Add get_if_frequency callback

2014-07-15 Thread Matthias Schwarzott
This is needed for PCTV 522e support. Signed-off-by: Matthias Schwarzott --- drivers/media/tuners/si2157.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c index 4dbd3f1..06153fa 100644 --- a/drivers/media/tuners/si2157.c

[PATCH 1/2] si2157: Add support for spectrum inversion

2014-07-15 Thread Matthias Schwarzott
This is needed for PCTV 522e support. Modify all users of si2157_config to correctly initialize all not mentioned values to 0. Signed-off-by: Matthias Schwarzott --- drivers/media/tuners/si2157.c | 3 +++ drivers/media/tuners/si2157.h | 5 + drivers/media/tuners

Re: [PATCH 0/4] wintv 930c-hd: Add basic support

2014-07-01 Thread Matthias Schwarzott
On 01.07.2014 21:55, Matthias Schwarzott wrote: > This patch series is the third version of my si2165 driver. > It supports only DVB-T and was tested on 8MHz channels in germany. > > Maybe the si2165 driver also works on other si2165/si2163/si2161 based cards. > I forgot to mentio

[PATCH 1/4] get_dvb_firmware: Add firmware extractor for si2165

2014-07-01 Thread Matthias Schwarzott
Signed-off-by: Matthias Schwarzott --- Documentation/dvb/get_dvb_firmware | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/Documentation/dvb/get_dvb_firmware b/Documentation/dvb/get_dvb_firmware index d91b8be..26c623d 100755 --- a

[PATCH 3/4] cx231xx: Add [2040:b130] Hauppauge WinTV 930C-hd 1113xx

2014-07-01 Thread Matthias Schwarzott
Reading eeprom works TODO: * Analog is untested * after loading the driver the first open to dvb device node fails Signed-off-by: Matthias Schwarzott --- drivers/media/usb/cx231xx/Kconfig | 1 + drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 + drivers/media/usb/cx231xx/cx231xx

<    1   2   3   >