Re: [PATCH 5/9] IR: extend interfaces to support more device settings

On Thu, 2010-07-29 at 09:25 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit...@gmail.com wrote: Also reuse LIRC_SET_MEASURE_CARRIER_MODE as LIRC_SET_LEARN_MODE (LIRC_SET_LEARN_MODE will start carrier reports if possible, and tune receiver to wide band mode) I don't

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Wed, 2010-07-28 at 23:52 -0400, Jarod Wilson wrote: On Thu, Jul 29, 2010 at 02:40:43AM +0300, Maxim Levitsky wrote: Hi, This is second version of the patchset. Hopefully, I didn't forget to address all comments. In addition to comments, I changed helper function that processes

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 11:38 -0400, Andy Walls wrote: On Thu, 2010-07-29 at 17:41 +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 09:23 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 02:40, Maxim Levitsky wrote: [...] In addition to comments, I changed helper

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 19:15 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 19:26, Maxim Levitsky wrote: On Thu, 2010-07-29 at 11:38 -0400, Andy Walls wrote: On Thu, 2010-07-29 at 17:41 +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 09:23 +0200, Christoph Bartelmus wrote

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 18:58 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 17:41, Maxim Levitsky wrote: [...] Note that I send timeout report with zero value. I don't think that this value is importaint. This does not sound good. Of course the value is important

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 21:42 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit...@gmail.com wrote: On Thu, 2010-07-29 at 18:58 +0200, Christoph Bartelmus wrote: Hi Maxim, on 29 Jul 10 at 17:41, Maxim Levitsky wrote: [...] Note that I send timeout report with zero

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 21:35 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit...@gmail.com wrote: [...] Could you explain exactly how timeout reports work? [...] So, timeout report is just another sample, with a mark attached, that this is last sample? right

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Thu, 2010-07-29 at 17:57 -0400, Jarod Wilson wrote: On Thu, Jul 29, 2010 at 5:28 PM, Jarod Wilson ja...@redhat.com wrote: On Thu, Jul 29, 2010 at 11:04:47PM +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 21:35 +0200, Christoph Bartelmus wrote: Hi! Maxim Levitsky maximlevit

Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver

On Fri, 2010-07-30 at 01:07 +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 17:57 -0400, Jarod Wilson wrote: On Thu, Jul 29, 2010 at 5:28 PM, Jarod Wilson ja...@redhat.com wrote: On Thu, Jul 29, 2010 at 11:04:47PM +0300, Maxim Levitsky wrote: On Thu, 2010-07-29 at 21:35 +0200

[PATCH 0/9 v2] IR: few fixes, additions and ENE driver

new ioctl for learning mode still need to add carrier detect, timeout reports, and rx filter * replaced int with bool in my driver, plus few cleanups. * added myself to maintainers of the ene driver * added another PNP ID to ene driver Best regards, Maxim Levitsky -- To unsubscribe

[PATCH 01/13] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR

[PATCH 02/13] IR: minor fixes:

* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |4 +--- drivers

[PATCH 03/13] IR: replace spinlock with mutex.

Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1

[PATCH 04/13] IR: fix locking in ir_raw_event_work

It is prefectly possible to have ir_raw_event_work running concurently on two cpus, thus we must protect it from that situation. Maybe better solution is to ditch the workqueue at all and use good 'ol thread per receiver, and just wake it up... Signed-off-by: Maxim Levitsky maximlevit

[PATCH 05/13] IR: JVC: make repeat work

Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions

[PATCH 06/13] IR: nec decoder: fix repeat.

Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-nec-decoder.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 07/13] IR: NECX: support repeat

This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-nec-decoder.c | 16 ++-- 2 files changed, 15 insertions(+), 2 deletions

[PATCH 08/13] IR: Allow not to compile keymaps in.

Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

(a byte for example). Also remove constness from ir_dev_props, because it now contains timeout settings that driver might want to change Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR

[PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

Still missing features: carrier report timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-lirc-codec.c | 112 +++--- include/media

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir

Re: Can I expect in-kernel decoding to work out of box?

On Wed, 2010-07-28 at 10:13 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 07:40, Jon Smirl escreveu: On Wed, Jul 28, 2010 at 2:30 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Tue, 2010-07-27 at 22:33 -0400, Jarod Wilson wrote: On Tue, Jul 27, 2010 at 9:29 PM, Jon Smirl jonsm

[PATCH 1/9] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media

[PATCH 2/9] IR: minor fixes:

* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +-- drivers

[PATCH 3/9] IR: replace spinlock with mutex.

Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1

[PATCH 4/9] IR: add helper functions for ir input devices that send ir timing data in small chunks, and alternation between pulses and spaces isn't guaranteed.

Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR/ir-raw-event.c | 86 +++ include/media/ir-core.h | 24 +- 4 files changed, 109

[PATCH 5/9] IR: extend interfaces to support more device settings

Also reuse LIRC_SET_MEASURE_CARRIER_MODE as LIRC_SET_LEARN_MODE (LIRC_SET_LEARN_MODE will start carrier reports if possible, and tune receiver to wide band mode) This IOCTL isn't yet used by lirc, so this won't break userspace. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers

[PATCH 6/9] IR: actually allow not to compile keymaps in..

Currntly, ir device registration fails if keymap requested by driver is not found... Fix that by always compiling in the empty keymap, and using it as a failback Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 7/9] IR: actualy report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. (Providing that in-kernel decoding understands remote's protocol. Hint: it doesn't) Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |5 + 1 files changed, 5

[PATCH 8/9] IR: Add ENE input driver.

Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 11 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 1019 + drivers/media/IR/ene_ir.h | 228 ++ 4 files changed, 1259 insertions(+), 0

Re: [PATCH 4/9] IR: add helper functions for ir input devices that send ir timing data in small chunks, and alternation between pulses and spaces isn't guaranteed.

On Wed, 2010-07-28 at 13:09 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: Please provide a smaller subject. Feel free to add a more detailed description, but subjects longer then 74 bytes end by causing some troubles when using git commands. I didn't

Re: [PATCH 3/9] IR: replace spinlock with mutex.

On Wed, 2010-07-28 at 13:03 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. You should

Re: [PATCH 2/9] IR: minor fixes:

On Wed, 2010-07-28 at 13:01 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: * lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what

Re: [PATCH 8/9] IR: Add ENE input driver.

On Wed, 2010-07-28 at 14:10 -0300, Mauro Carvalho Chehab wrote: Em 28-07-2010 12:14, Maxim Levitsky escreveu: Signed-off-by: Maxim Levitsky maximlevit...@gmail.com Please, instead of patch 9/9, do a patch moving ENE driver from staging into drivers/media/IR, and then a patch porting

Re: Can I expect in-kernel decoding to work out of box?

On Wed, 2010-07-28 at 17:13 -0300, Mauro Carvalho Chehab wrote: Andy, Em 28-07-2010 15:18, Andy Walls escreveu: On Wed, 2010-07-28 at 13:35 -0400, Jon Smirl wrote: On Wed, Jul 28, 2010 at 1:02 PM, Andy Walls awa...@md.metrocast.net wrote: On Wed, 2010-07-28 at 12:42 -0300, Mauro

Re: [PATCH 1/9] IR: Kconfig fixes

On Wed, 2010-07-28 at 10:36 -0700, Randy Dunlap wrote: On Wed, 28 Jul 2010 18:14:03 +0300 Maxim Levitsky wrote: Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR

Re: [PATCH 4/9] IR: add helper functions for ir input devices that send ir timing data in small chunks, and alternation between pulses and spaces isn't guaranteed.

On Wed, 2010-07-28 at 16:57 -0400, Jarod Wilson wrote: On Wed, Jul 28, 2010 at 01:46:27PM -0400, Jarod Wilson wrote: On Wed, Jul 28, 2010 at 06:14:06PM +0300, Maxim Levitsky wrote: Signed-off-by: Maxim Levitsky maximlevit...@gmail.com With the caveat of requiring an improved changelog

[no subject]

Subject: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver Hi, This is second version of the patchset. Hopefully, I didn't forget to address all comments. In addition to comments, I changed helper function that processes samples so it sends last space as soon as timeout is reached. This

[PATCH 1/9] IR: Kconfig fixes

Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR

[PATCH 2/9] IR: minor fixes:

* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |4 +--- drivers

[PATCH 3/9] IR: replace spinlock with mutex.

Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1

[PATCH 5/9] IR: extend interfaces to support more device settings

doesn't have space to indicate that. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |2 + drivers/media/IR/ir-lirc-codec.c | 119 +++--- drivers/media/IR/ir-raw-event.c | 13 ++--- include/media/ir-core.h

[PATCH 6/9] IR: Allow not to compile keymaps in.

Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 4/9] IR: add helper function for hardware with small o/b buffer.

(a byte for example). Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR/ir-raw-event.c | 86 +++ include/media/ir-core.h | 24

[PATCH 7/9] IR: report unknown scancodes the in-kernel decoders found.

This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/ir-keytable.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir

[PATCH 9/9] IR: Port ene driver to new IR subsystem and enable it.

it is accurate already. Signed-off-by: Maxim Levitsky maximlevit...@gmail.com --- drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 589 + drivers/media/IR/ene_ir.h | 32 +-- 4 files changed, 241

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

? Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v2] Another approach to IR

On Tue, 2009-12-01 at 10:08 -0500, Jon Smirl wrote: While reading all of these IR threads another way of handling IR occurred to me that pretty much eliminates the need for LIRC and configuration files in default cases. The best way to make everything just work is to eliminate it. The

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

On Mon, 2009-11-30 at 07:57 -0500, Andy Walls wrote: On Mon, 2009-11-30 at 09:56 -0200, Mauro Carvalho Chehab wrote: Andy Walls wrote: On Sun, 2009-11-29 at 09:49 -0800, Ray Lee wrote: On Sun, Nov 29, 2009 at 9:28 AM, Maxim Levitsky maximlevit...@gmail.com wrote: This has zero

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

push to put lircd, the userspace daemon's functionality into kernel. This has zero advantages besides good developer feeling that My system has one less daemon... Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

On Sat, 2009-11-28 at 12:20 +0100, Krzysztof Halasa wrote: Maxim Levitsky maximlevit...@gmail.com writes: If we add in-kernel decoding, we still will end up with two different decoding, one in kernel and one in lirc. And that's good. Especially for a popular and simple protocol

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

On Sat, 2009-11-28 at 16:25 +0100, Krzysztof Halasa wrote: Maxim Levitsky maximlevit...@gmail.com writes: And that's good. Especially for a popular and simple protocol such as RC5. Actually, it's not about adding the decoder. It's about fixing it. I can fix it. This is nonsense

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

On Sat, 2009-11-28 at 16:44 +0100, Krzysztof Halasa wrote: Maxim Levitsky maximlevit...@gmail.com writes: Generic decoder that lirc has is actually much better and more tolerant that protocol specific decoders that you propose, Actually, it is not the case. Why do you think it's better

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

On Sat, 2009-11-28 at 11:45 -0500, Jon Smirl wrote: On Sat, Nov 28, 2009 at 10:35 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Sat, 2009-11-28 at 16:25 +0100, Krzysztof Halasa wrote: Maxim Levitsky maximlevit...@gmail.com writes: And that's good. Especially for a popular

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

On Sat, 2009-11-28 at 13:56 -0500, Jon Smirl wrote: On Sat, Nov 28, 2009 at 1:45 PM, Maxim Levitsky maximlevit...@gmail.com wrote: On Sat, 2009-11-28 at 11:45 -0500, Jon Smirl wrote: What are other examples of user space IR drivers? many libusb based drivers? If these drivers

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

sources, and convert that to input events. Whats wrong with that? If we add in-kernel decoding, we still will end up with two different decoding, one in kernel and one in lirc. Could we finally end this discussion and move forward? Best regards, Maxim Levitsky -- To unsubscribe from this list: send

Re: IR raw input is not sutable for input system

On Tue, 2009-11-24 at 19:32 -0800, Trent Piepho wrote: On Wed, 25 Nov 2009, Maxim Levitsky wrote: Its not the case. There are many protocols, I know that by experimenting with my universal remote. There are many receivers, and all have different accuracy. Most remotes aren't designed

Re: IR raw input is not sutable for input system

think we were taking about such devices. I have no objection that devices that *do* decode the protocol, they should be handled inside kernel. But devices that send raw pulse/space data should be handled in lirc that will feed the data back to the kernel via uinput. Best regards, Maxim Levitsky

<    1   2