Re: [PATCH v3 05/24] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > There is a pin conflict with GPIO_6. This pin functions as a power > input pin to the OV5642 camera sensor, but ENET uses it as the h/w > workaround for erratum ERR006687, to wake-up the ARM cores on normal > RX and TX packet done

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > Both hang off the same i2c2 bus, so they require different (and non- > default) i2c slave addresses. > > The OV5642 connects to the parallel-bus mux input

Re: [PATCH v3 15/24] media: Add userspace header file for i.MX

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls and events > generated by the i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam > ---

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-13 Thread Philipp Zabel
Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > --- > Documentation/media/v4l-drivers/imx.rst | 443 ++ > drivers/staging/media/Kconfig | 2 + > drivers/stagi

Re: [PATCH 1/4] video: add HDMI state notifier support

2017-01-13 Thread Philipp Zabel
gt; > Signed-off-by: Hans Verkuil Acked-by: Philipp Zabel regards Philipp > --- > drivers/video/Kconfig | 3 + > drivers/video/Makefile| 1 + > drivers/video/hdmi-notifier.c | 134 > ++ > include/linux/hdmi-notifier.

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-16 Thread Philipp Zabel
Hi Steve, On Sat, 2017-01-14 at 12:26 -0800, Steve Longerbeam wrote: > > On 01/13/2017 03:05 AM, Philipp Zabel wrote: > > Hi Steve, > > > > Am Donnerstag, den 12.01.2017, 15:22 -0800 schrieb Steve Longerbeam: [...] > >> I would > >> imagine it will nee

Re: [PATCH v3 01/24] [media] dt-bindings: Add bindings for i.MX media driver

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-13 at 11:03 -0800, Steve Longerbeam wrote: > > On 01/13/2017 03:55 AM, Philipp Zabel wrote: > > Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > >> Add bindings documentation for the i.MX media driver. > >> > &

Re: [PATCH v3 06/24] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-13 at 15:04 -0800, Steve Longerbeam wrote: > > On 01/13/2017 04:03 AM, Philipp Zabel wrote: > > Am Freitag, den 06.01.2017, 18:11 -0800 schrieb Steve Longerbeam: > >> Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > >> Both

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-16 Thread Philipp Zabel
On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: [...] > >> +Unprocessed Video Capture: > >> +-- > >> + > >> +Send frames directly from sensor to camera interface, with no > >> +conversions: > >> + > >> +-> ipu_smfc -> camif > > I'd call this capture interface, thi

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-16 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. s/Serial/Sensor/ > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Kconfig | 13 + > drivers/staging/media/imx/Makefile | 2 + > d

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-18 Thread Philipp Zabel
Hi Baruch, On Sun, 2017-01-15 at 12:33 +0200, Baruch Siach wrote: > The Freescale provided imx-vpu looks for firmware files under > /lib/firmware/vpu > by default. Make coda look there for firmware files to ease the update path. > > Cc: Fabio Estevam > Signed-off-by: Baruch Siach > --- > v3: a

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-19 Thread Philipp Zabel
Hi Baruch, On Wed, 2017-01-18 at 21:33 +0200, Baruch Siach wrote: [...] > > To increase the number of firmware paths, coda_fw_callback has to be > > modified, too. Otherwise it will just ignore firmware[2]: > > Thanks for catching that. But shouldn't we make the firmware files list a > NULL > t

Re: [PATCH v4 0/7] Add support for Video Data Order Adapter

2017-01-20 Thread Philipp Zabel
do not print a message if VDOA cannot be found > > - Patch 6/7: Do not change the CODA context in coda_try_fmt() > > - Patch 6/7: Allocate an additional internal frame if the VDOA is in use > > > > Michael Tretter (3): > > [media] coda: fix frame index to returned erro

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-20 Thread Philipp Zabel
from a requirement of a customer and is not > > necessary here. > > > > - The FIM must be explicitly enabled in the fim child node under the CSI > > port nodes, using the status property. If not enabled, FIM v4l2 controls > > will not appear in the vide

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-23 Thread Philipp Zabel
On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > > There is a VDIC entity in the i.MX IPU that performs de-interlacing with > > hardware filters for motion compensation. Some of the motion compensation > > modes ("low" and "medium" motion) require that the VDIC receive video > > frame

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-23 Thread Philipp Zabel
Hi Steve, On Sun, 2017-01-22 at 18:31 -0800, Steve Longerbeam wrote: > > On 01/16/2017 05:47 AM, Philipp Zabel wrote: > > On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: > > [...] > >>>> +Unprocessed Video Capture: > >>>> +---

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
On Mon, 2017-01-23 at 12:08 +0100, Hans Verkuil wrote: > On 01/23/2017 12:00 PM, Philipp Zabel wrote: > > On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > As long as it is mentioned in the TODO, and ideally in the Kconfig as well, > then I'm fine with it. >

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-24 Thread Philipp Zabel
Hi Steve, Hans, [added Laurent to Cc: who I believe might have an opinion on the media bus formats, too. Sorry for the wall of text, I have put a marker where the MEDIA_BUS argument starts] The central issue seems to be that I think media pad links / media bus formats should describe physical lin

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
Hi Steve, On Mon, 2017-01-23 at 17:45 -0800, Steve Longerbeam wrote: > > On 01/23/2017 05:38 PM, Steve Longerbeam wrote: > > > >> > >>> Second, ignoring the above locking issue for a moment, > >>> v4l2_pipeline_pm_use() > >>> will call s_power on the sensor _first_, then the mipi csi-2 s_power, >

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-01-24 Thread Philipp Zabel
On Wed, 2017-01-18 at 17:44 -0800, Steve Longerbeam wrote: > > On 01/14/2017 02:42 PM, Steve Longerbeam wrote: > > > >>> +/* parse inputs property from a sensor node */ > >>> +static void of_parse_sensor_inputs(struct imx_media_dev *imxmd, > >>> +struct imx_media_subdev

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-24 Thread Philipp Zabel
Hi Hans, On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > > controlled either by register bit fields

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

2017-01-24 Thread Philipp Zabel
Hi Steve, On Mon, 2017-01-09 at 20:43 +0100, Philipp Zabel wrote: > On the other hand, there is currently no way to communicate to userspace > that the IC can't downscale bilinearly, but only to 1/2 or 1/4 of the > input resolution, and then scale up bilinearly for there. This

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 00:01 +, Russell King - ARM Linux wrote: [...] > The iMX6 manuals call for a very specific seven sequence of initialisation > for CSI2, which begins with: > > 1. reset the D-PHY. > 2. place MIPI sensor in LP-11 state > 3. perform D-PHY initialisation > 4. configure CSI2 l

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Mon, 2017-01-30 at 17:22 -0800, Steve Longerbeam wrote: > > On 01/30/2017 04:45 PM, Russell King - ARM Linux wrote: > > > > Hi, > > > > Trying this driver with an imx219 camera (which works with Philipp's > > driver) results in not much happening... no /dev/media* node for it, > > no subdevs, n

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > The central issue seems to be that I think media pad links / media bus > > formats should describe physical links, such as parallel or serial > > buses, and the formats of pixels flowing through them, whereas Steve > > would lik

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 13:14 +, Russell King - ARM Linux wrote: > On Tue, Jan 31, 2017 at 11:09:24AM +0100, Philipp Zabel wrote: > > On Mon, 2017-01-30 at 13:06 +, Russell King - ARM Linux wrote: > > > To help illustrate my point, consider the

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
Hi Steve, I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some observations: # Link pipeline media-ctl -l "'tc358743 1-000f':0->'imx6-mipi-csi2':0[1]" media-ctl -l "'imx6-mipi-csi2':1->'ipu1_csi0_mux':0[1]" m

Re: [PATCH v3 00/24] i.MX Media Driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 14:54 +0100, Philipp Zabel wrote: > Hi Steve, > > I have just tested the imx-media-staging-md-wip branch on a Nitrogen6X > with a tc358743 (BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board). Some > observations: > > # Link pipeline > media-ctl -l &qu

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: [...] > +static int csi_set_fmt(struct v4l2_subdev *sd, > +struct v4l2_subdev_pad_config *cfg, > +struct v4l2_subdev_format *sdformat) > +{ > + struct csi_priv *priv = v4l2_get_subdevdata(sd); > +

Re: [PATCH v3 17/24] media: imx: Add CSI subdev driver

2017-01-31 Thread Philipp Zabel
On Tue, 2017-01-31 at 16:51 +0100, Philipp Zabel wrote: > On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > [...] > > +static int csi_set_fmt(struct v4l2_subdev *sd, > > + struct v4l2_subdev_pad_config *cfg, > > + struct v4l2

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-01 Thread Philipp Zabel
On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: [...] > > # Set pad formats > > media-ctl --set-v4l2 "'tc358743 1-000f':0[fmt:UYVY/1920x1080]" > > media-ctl --set-v4l2 "'imx6-mipi-csi2':1[fmt:UYVY2X8/1920x1080]" > > media-ctl --set-v4l2 "'ipu1_csi0_mux':2[fmt:UYVY2X8/1920x1080]" > > medi

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-01 Thread Philipp Zabel
On Wed, 2017-02-01 at 10:11 +, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2017 at 10:30:57AM +0100, Philipp Zabel wrote: > > On Tue, 2017-01-31 at 17:26 -0800, Steve Longerbeam wrote: > > [...] > > > right, need to fix that. Probably by poking the attached >

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-02 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + > drivers/staging/media/imx/imx-mi

Re: [PATCH v3 12/24] add mux and video interface bridge entity functions

2017-02-06 Thread Philipp Zabel
On Sun, 2017-02-05 at 17:36 +0200, Laurent Pinchart wrote: > Hi Steve, > > Thank you for the patch > > On Friday 06 Jan 2017 18:11:30 Steve Longerbeam wrote: > > From: Philipp Zabel > > > > Signed-off-by: Philipp Zabel > > --- > > Documenta

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-07 Thread Philipp Zabel
017 04:48 PM, Laurent Pinchart wrote: > > >>> On Tuesday 24 Jan 2017 18:07:55 Steve Longerbeam wrote: > > >>>> On 01/24/2017 04:02 AM, Philipp Zabel wrote: > > >>>>> On Fri, 2017-01-20 at 15:03 +0100, Hans Verkuil wrote: > > >>>>

[PATCH 0/4] media-ctl: frame interval propagation and colorimetry

2017-02-07 Thread Philipp Zabel
tches fix that and also print the frame interval if set. The final patch adds colorimetry support to the pad formats. regards Philipp Philipp Zabel (4): media-ctl: add pad support to set/get_frame_interval media-ctl: print the configured frame interval media-ctl: propagate frame interval

[PATCH 1/4] media-ctl: add pad support to set/get_frame_interval

2017-02-07 Thread Philipp Zabel
This allows to set and get the frame interval on pads other than pad 0. Signed-off-by: Philipp Zabel --- utils/media-ctl/libv4l2subdev.c | 24 ++-- utils/media-ctl/v4l2subdev.h| 4 ++-- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/utils/media-ctl

[PATCH 2/4] media-ctl: print the configured frame interval

2017-02-07 Thread Philipp Zabel
After the pad format, also print the frame interval, if already configured. Signed-off-by: Philipp Zabel --- utils/media-ctl/media-ctl.c | 8 1 file changed, 8 insertions(+) diff --git a/utils/media-ctl/media-ctl.c b/utils/media-ctl/media-ctl.c index 50adbe91..1be880c6 100644 --- a

[PATCH 3/4] media-ctl: propagate frame interval

2017-02-07 Thread Philipp Zabel
Same as the media bus format, the frame interval should be propagated from output pads to connected entities' input pads. Signed-off-by: Philipp Zabel --- utils/media-ctl/libv4l2subdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/utils/media-ctl/libv4l2sub

[PATCH 4/4] media-ctl: add colorimetry support

2017-02-07 Thread Philipp Zabel
media-ctl can be used to propagate v4l2 subdevice pad formats from source pads of one subdevice to another one's sink pads. These formats include colorimetry information, so media-ctl should be able to print or change it using the --set/get-v4l2 option. Signed-off-by: Philipp Zabel ---

[PATCH] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-02-07 Thread Philipp Zabel
The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel --- This is a patch against the current imx-media-staging-md-wip branch. S_FMT wouldn't update the cropping rectangle d

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-02-08 Thread Philipp Zabel
Hi Sakari, On Tue, 2017-02-07 at 22:46 +0200, Sakari Ailus wrote: > Hi Steve, > > On Fri, Jan 06, 2017 at 06:11:31PM -0800, Steve Longerbeam wrote: > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > >

[PATCH 1/2] [media] tc358743: put lanes in STOP state before starting streaming

2017-02-08 Thread Philipp Zabel
Without calling tc358743_set_csi after stopping streaming (or calling tc358743_s_dv_timings or tc358743_set_fmt from userspace after stopping the stream), the i.MX6 MIPI CSI2 input fails waiting for lanes to enter STOP state when streaming is started again. Signed-off-by: Philipp Zabel

[PATCH 2/2] [media] tc358743: extend colorimetry support

2017-02-08 Thread Philipp Zabel
The video output format can freely be chosen to be 24-bit SRGB or 16-bit YUV 4:2:2 in either SMPTE170M or REC709 color space. In all three modes the output can be full or limited range. Signed-off-by: Philipp Zabel --- drivers/media/i2c/tc358743.c | 118

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-09 Thread Philipp Zabel
On Wed, 2017-02-08 at 15:23 -0800, Steve Longerbeam wrote: [...] > >> + > >> +static int imxcsi2_get_fmt(struct v4l2_subdev *sd, > >> + struct v4l2_subdev_pad_config *cfg, > >> + struct v4l2_subdev_format *sdformat) > >> +{ > >> + struct imxcsi2_dev *csi2 =

Re: [PATCH 2/2] [media] tc358743: extend colorimetry support

2017-02-10 Thread Philipp Zabel
> On 02/08/2017 11:53 AM, Philipp Zabel wrote: > > @@ -1486,16 +1506,40 @@ static int tc358743_get_fmt(struct v4l2_subdev *sd, > > > > switch (vi_rep & MASK_VOUT_COLOR_SEL) { > > case MASK_VOUT_COLOR_RGB_FULL: > > + format->format.co

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-13 Thread Philipp Zabel
oes) only if the sensor can still be configured in step 6. Also, 3./4./5. are csi2 code, 6. is sensor code, and 7. is csi2 code again. For reliable startup we need csi2 receiver code to be called on both sides of the sensor enabling its clock lane. --8<-- >From f12758caa3e

[PATCH v2 1/2] [media] tc358743: put lanes in STOP state before starting streaming

2017-02-13 Thread Philipp Zabel
Without calling tc358743_set_csi after stopping streaming (or calling tc358743_s_dv_timings or tc358743_set_fmt from userspace after stopping the stream), the i.MX6 MIPI CSI2 input fails waiting for lanes to enter STOP state when streaming is started again. Signed-off-by: Philipp Zabel

[PATCH v2 2/2] [media] tc358743: extend colorimetry support

2017-02-13 Thread Philipp Zabel
The video output format can freely be chosen to be 24-bit SRGB or 16-bit YUV 4:2:2 in either SMPTE170M or REC709 color space. In all three modes the output can be full or limited range. Signed-off-by: Philipp Zabel --- Changes since v1: - Determine colorspace and xfer_func from the S_V_COLOR

[PATCH v2 1/4] media-ctl: add pad support to set/get_frame_interval

2017-02-13 Thread Philipp Zabel
This allows to set and get the frame interval on pads other than pad 0. Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus --- Changes since v1: - use "pad %s/%u" instead of "entity %s pad %u" in debug message --- utils/media-ctl/libv4l2subdev.c | 24 ++---

[PATCH v2 2/4] media-ctl: print the configured frame interval

2017-02-13 Thread Philipp Zabel
After the pad format, also print the frame interval, if already configured. Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus --- utils/media-ctl/media-ctl.c | 8 1 file changed, 8 insertions(+) diff --git a/utils/media-ctl/media-ctl.c b/utils/media-ctl/media-ctl.c index 572bcf7

[PATCH v2 4/4] media-ctl: add colorimetry support

2017-02-13 Thread Philipp Zabel
media-ctl can be used to propagate v4l2 subdevice pad formats from source pads of one subdevice to another one's sink pads. These formats include colorimetry information, so media-ctl should be able to print or change it using the --set/get-v4l2 option. Signed-off-by: Philipp Zabel Ack

[PATCH v2 3/4] media-ctl: propagate frame interval

2017-02-13 Thread Philipp Zabel
Same as the media bus format, the frame interval should be propagated from output pads to connected entities' input pads. Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus --- utils/media-ctl/libv4l2subdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/

Re: [PATCH v2 4/4] media-ctl: add colorimetry support

2017-02-13 Thread Philipp Zabel
On Mon, 2017-02-13 at 10:40 +0100, Hans Verkuil wrote: > On 02/13/2017 10:33 AM, Philipp Zabel wrote: > > media-ctl can be used to propagate v4l2 subdevice pad formats from > > source pads of one subdevice to another one's sink pads. These formats > > include colorimetry

Re: [PATCH v2 4/4] media-ctl: add colorimetry support

2017-02-13 Thread Philipp Zabel
On Mon, 2017-02-13 at 11:48 +0200, Sakari Ailus wrote: > Hi Hans, > > On Mon, Feb 13, 2017 at 10:40:41AM +0100, Hans Verkuil wrote: > ... > > > @@ -839,6 +951,157 @@ enum v4l2_field v4l2_subdev_string_to_field(const > > > char *string) > > > return (enum v4l2_field)-1; > > > } > > > > > > +s

Re: [PATCH v2 2/2] [media] tc358743: extend colorimetry support

2017-02-13 Thread Philipp Zabel
On Mon, 2017-02-13 at 11:05 +0100, Hans Verkuil wrote: [...] > > @@ -1469,38 +1477,88 @@ static int tc358743_s_stream(struct v4l2_subdev > > *sd, int enable) > > > > /* --- PAD OPS --- */ > > > > -static int tc358743_get_fmt(struct v4l2_subdev *sd, > > - stru

[PATCH v3 2/4] media-ctl: print the configured frame interval

2017-02-13 Thread Philipp Zabel
After the pad format, also print the frame interval, if already configured. Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus --- utils/media-ctl/media-ctl.c | 8 1 file changed, 8 insertions(+) diff --git a/utils/media-ctl/media-ctl.c b/utils/media-ctl/media-ctl.c index 572bcf7

[PATCH v3 1/4] media-ctl: add pad support to set/get_frame_interval

2017-02-13 Thread Philipp Zabel
This allows to set and get the frame interval on pads other than pad 0. Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus --- utils/media-ctl/libv4l2subdev.c | 24 ++-- utils/media-ctl/v4l2subdev.h| 4 ++-- 2 files changed, 16 insertions(+), 12 deletions(-) diff

[PATCH v3 3/4] media-ctl: propagate frame interval

2017-02-13 Thread Philipp Zabel
Same as the media bus format, the frame interval should be propagated from output pads to connected entities' input pads. Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus --- utils/media-ctl/libv4l2subdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/

[PATCH v3 4/4] media-ctl: add colorimetry support

2017-02-13 Thread Philipp Zabel
media-ctl can be used to propagate v4l2 subdevice pad formats from source pads of one subdevice to another one's sink pads. These formats include colorimetry information, so media-ctl should be able to print or change it using the --set/get-v4l2 option. Signed-off-by: Philipp Zabel Ack

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-14 Thread Philipp Zabel
Hi Steve, On Mon, 2017-02-13 at 15:20 -0800, Steve Longerbeam wrote: [...] > > It seems the OV5640 driver never puts its the CSI-2 lanes into stop > > state while not streaming. > > Yes I found that as well. > > But good news, I finally managed to coax the OV5640's clock lane > into LP-11 state!

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-15 Thread Philipp Zabel
Hi Steve, On Tue, 2017-02-14 at 18:27 -0800, Steve Longerbeam wrote: [...] > > > > # Provide an EDID to the HDMI source > > v4l2-ctl -d /dev/v4l-subdev2 --set-edid=file=edid-1080p.hex > > I can probably generate this Intel hex file myself from sysfs > edid outputs, but for convenience do you mind

Re: [PATCH v4 36/36] media: imx: propagate sink pad formats to source pads

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: [...] > diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c > b/drivers/staging/media/imx/imx-ic-prpencvf.c > index dd9d499..c43f85f 100644 > --- a/drivers/staging/media/imx/imx-ic-prpencvf.c > +++ b/drivers/staging/media/imx/imx-ic-p

Re: [PATCH v4 30/36] media: imx: update capture dev format on IDMAC output pad set_fmt

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > When configuring the IDMAC output pad formats (in ipu_csi, > ipu_ic_prpenc, and ipu_ic_prpvf subdevs), the attached capture > device format must also be updated. > > Signed-off-by: Steve Longerbeam > Suggested

Re: [PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > The previous API and negotiation of mbus codes and pixel formats > was broken, and has been completely redone. > > The negotiation of media bus codes should be as follows: > > CSI: > > sink pad direct src pad IDMAC src pad > -

Re: [PATCH v4 17/36] media: Add userspace header file for i.MX

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls and events > generated by the i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam > --- > inc

Re: [PATCH v4 01/36] [media] dt-bindings: Add bindings for i.MX media driver

2017-02-16 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > Add bindings documentation for the i.MX media driver. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 66 > + > 1 file changed, 66 insertions(+) > create mode 1006

Re: [PATCH v4 18/36] media: Add i.MX media core driver

2017-02-16 Thread Philipp Zabel
640 > +-- > + > +Similarly to SabreLite, the SabreSD supports a parallel interface > +OV5642 module on IPU1 CSI0, and a MIPI CSI-2 OV5640 module. The OV5642 > +connects to i2c bus 1 and the OV5640 to i2c bus 2. > + > +The device tree for SabreSD includes

Re: [PATCH v4 18/36] media: Add i.MX media core driver

2017-02-17 Thread Philipp Zabel
On Thu, 2017-02-16 at 17:33 -0800, Steve Longerbeam wrote: > > On 02/16/2017 05:02 AM, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > >> + > >> +- Clean up and move the ov5642 subdev driver to drivers/media/i2c, and >

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Thu, 2017-02-16 at 22:57 +, Russell King - ARM Linux wrote: > On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: > > > > > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > >On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: > > >>In version 4: > >

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-17 Thread Philipp Zabel
On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile | 1 + > drivers/staging/media/imx/imx6-

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 10:56 +, Russell King - ARM Linux wrote: > On Fri, Feb 17, 2017 at 11:39:11AM +0100, Philipp Zabel wrote: > > On Thu, 2017-02-16 at 22:57 +, Russell King - ARM Linux wrote: > > > On Thu, Feb 16, 2017 at 02:27:41PM -0800, Stev

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 11:06 +, Russell King - ARM Linux wrote: > On Fri, Feb 17, 2017 at 11:47:59AM +0100, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > > +static void csi2_dphy_init(struct csi2_dev *csi2) > > > +{ > >

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: > > On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: > >> In version 4: > > > > With this version, I get: > > > > [28762.892053] imx6-mipi-csi2: LP-11 timeout, ph

Re: [PATCH v4 23/36] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 11:47 +0100, Philipp Zabel wrote: > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > > for sensors with a MIPI CSI2 interface. > > > > Signed-off-by: Steve Longe

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-17 Thread Philipp Zabel
On Fri, 2017-02-17 at 14:22 +0200, Sakari Ailus wrote: > Hi Philipp, Steve and Russell, > > On Fri, Feb 17, 2017 at 12:43:38PM +0100, Philipp Zabel wrote: > > On Thu, 2017-02-16 at 14:27 -0800, Steve Longerbeam wrote: > > > > > > On 02/16/2017 02:20 PM, Russell K

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-21 Thread Philipp Zabel
On Mon, 2017-02-20 at 16:18 -0800, Steve Longerbeam wrote: > > On 02/20/2017 04:13 PM, Russell King - ARM Linux wrote: > > On Tue, Feb 21, 2017 at 12:04:10AM +0200, Sakari Ailus wrote: > >> On Wed, Feb 15, 2017 at 06:19:31PM -0800, Steve Longerbeam wrote: > >>> From: Russell King > >>> > >>> Sett

Re: [PATCH v4 15/36] platform: add video-multiplexer subdevice driver

2017-02-21 Thread Philipp Zabel
On Sun, 2017-02-19 at 23:02 +0100, Pavel Machek wrote: > Hi! > > > From: Philipp Zabel > > > > This driver can handle SoC internal and external video bus multiplexers, > > controlled either by register bit fields or by a GPIO. The subdevice > > pa

Re: [PATCH v4 33/36] media: imx: redo pixel format enumeration and negotiation

2017-02-23 Thread Philipp Zabel
Hi Steve, On Wed, 2017-02-22 at 15:52 -0800, Steve Longerbeam wrote: > Hi Philipp, > > > On 02/16/2017 03:32 AM, Philipp Zabel wrote: > > On Wed, 2017-02-15 at 18:19 -0800, Steve Longerbeam wrote: > >> The previous API and negotiation of mbus codes and pixel forma

[PATCH] [media] coda: restore original firmware locations

2017-03-01 Thread Philipp Zabel
mware compatibility location") Cc: Baruch Siach Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-comm

[PATCH] [media] coda: implement encoder stop command

2017-03-02 Thread Philipp Zabel
There is no need to call v4l2_m2m_try_schedule to kick off draining the bitstream buffer for the encoder, but we have to wake up the destination queue in case there are no new OUTPUT buffers to be encoded and userspace is already polling for new CAPTURE buffers. Signed-off-by: Philipp Zabel

Re: [PATCH] [media] coda: implement encoder stop command

2017-03-02 Thread Philipp Zabel
Hi Jean-Michel, On Thu, 2017-03-02 at 11:02 +0100, Jean-Michel Hautbois wrote: > Hi Philipp, > > 2017-03-02 10:51 GMT+01:00 Philipp Zabel : > > There is no need to call v4l2_m2m_try_schedule to kick off draining the > > bitstream buffer for the encoder, but we have to wa

[PATCH] [media] coda: disable BWB for all codecs on CODA 960

2017-03-02 Thread Philipp Zabel
ut decoded frames to memory, so there is an "enable_bwb" module parameter to turn it back on. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 7 ++- drivers/media/platform/coda/coda_regs.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff -

[PATCH 1/4] [media] coda: Use && instead of & for non-bitfield conditions

2017-03-03 Thread Philipp Zabel
From: Michael Tretter streamon and streamoff are used as boolean values, not as bitfields. Therefore, the logical && should be used to combine them. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 2 +- 1 file changed, 1 i

[PATCH 3/4] [media] coda: pad first h.264 buffer to 512 bytes

2017-03-03 Thread Philipp Zabel
The bitstream reader needs 512 bytes ready to read to examine the headers in the first frame. If that frame is too small, prepend it with a filler NAL. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c | 28 ++-- drivers/media/platform/coda/coda

[PATCH 4/4] [media] coda: disable reordering for baseline profile h.264 streams

2017-03-03 Thread Philipp Zabel
With reordering enabled, the sequence init in CODA960 firmware requests an unreasonable number of internal frames for some baseline profile streams. Disabling the reordering feature manually if baseline streams are detected fixes this problem. Signed-off-by: Lucas Stach Signed-off-by: Philipp

[PATCH 2/4] [media] coda: keep queued buffers on a temporary list during start_streaming

2017-03-03 Thread Philipp Zabel
-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c| 28 ++-- drivers/media/platform/coda/coda-common.c | 29 ++--- drivers/media/platform/coda/coda.h| 2 +- 3 files changed, 45 insertions(+), 14 deletions(-) diff --git a

Re: [PATCH] [media] coda: implement encoder stop command

2017-03-03 Thread Philipp Zabel
On Thu, 2017-03-02 at 17:30 +0100, Jean-Michel Hautbois wrote: > > > > + /* If there is no buffer in flight, wake up */ > > + if (ctx->qsequence == ctx->osequence) { > > Not sure about this one, I would have done something like : > if (!(ctx->fh.m2m_ctx->job_flags)) { This field is

Re: [PATCH] [media] coda: restore original firmware locations

2017-03-08 Thread Philipp Zabel
On Wed, 2017-03-08 at 11:38 +0100, Hans Verkuil wrote: > On 01/03/17 16:36, Philipp Zabel wrote: > > Recently, an unfinished patch was merged that added a third entry to the > > beginning of the array of firmware locations without changing the code > > to also look at th

[PATCH v2] [media] coda: restore original firmware locations

2017-03-08 Thread Philipp Zabel
mware compatibility location") Cc: Baruch Siach Signed-off-by: Philipp Zabel Acked-by: Baruch Siach Reviewed-by: Fabio Estevam --- Changes since v1: - moved fw assignment after ARRAY_SIZE check, to avoid reading into fw from undefined memory --- drivers/media/platform/coda/coda-com

Re: [PATCH] coda: enable with COMPILE_TEST

2017-03-08 Thread Philipp Zabel
mp;Media Coda multi-standard codec IP" > - depends on VIDEO_DEV && VIDEO_V4L2 && ARCH_MXC > + depends on VIDEO_DEV && VIDEO_V4L2 > + depends on ARCH_MXC || COMPILE_TEST Yes, that could be helpful. Acked-by: Philipp Zabel > depends on HAS

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-13 Thread Philipp Zabel
On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: > On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote: > > The vast majority of existing drivers do not implement them nor the user > > space expects having to set them. Making that mandatory would break existing > > user s

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-03-14 Thread Philipp Zabel
On Tue, 2017-03-14 at 08:34 +0100, Hans Verkuil wrote: > On 03/13/2017 10:03 PM, Sakari Ailus wrote: > > Hi Steve, > > > > On Mon, Mar 13, 2017 at 11:06:22AM -0700, Steve Longerbeam wrote: > >> > >> > >> On 03/13/2017 06:55 AM, Philipp Zabel wrote:

[PATCH v2 05/14] [media] rc: sunxi-cir: simplify optional reset handling

2017-03-15 Thread Philipp Zabel
ditionally. Signed-off-by: Philipp Zabel --- drivers/media/rc/sunxi-cir.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index 25b0061678102..4b785dd775c11 100644 --- a/drivers/media/rc/sunxi-c

[PATCH v2 04/14] [media] st_rc: simplify optional reset handling

2017-03-15 Thread Philipp Zabel
ditionally. Signed-off-by: Philipp Zabel Acked-by: Patrice Chotard --- drivers/media/rc/st_rc.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c index f0d7190e39195..0ac1879f75069 100644 --- a/drivers/media/rc/st_

[PATCH v2 03/14] [media] coda: simplify optional reset handling

2017-03-15 Thread Philipp Zabel
trol_reset unconditionally. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index eb6548f46cbac..0cf

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Philipp Zabel
On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs > > > with those, it will likely run with any other application. > > > > > > > I would like t

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-16 Thread Philipp Zabel
On Thu, 2017-03-16 at 10:47 +0100, Philippe De Muyter wrote: > On Thu, Mar 16, 2017 at 10:26:00AM +0100, Philipp Zabel wrote: > > On Wed, 2017-03-15 at 14:55 -0400, Nicolas Dufresne wrote: > > > Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Philipp Zabel
On Fri, 2017-03-17 at 11:42 +, Russell King - ARM Linux wrote: > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > > We're all very driver-development-driven, and userspace gets very little > > attention in general. So before just throwing in the towel we should take > > a good lo

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Philipp Zabel
On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: [...] > The big question, waiting for an answer on the last 8 years is > who would do that? Such person would need to have several different > hardware from different vendors, in order to ensure that it has > a generic solution. > > I

<    3   4   5   6   7   8   9   10   11   12   >