Please ignore this message
Please ignore this message. I've been trying to send a patch to this list since yesterday without success. This message is just to validate my mailing list subscription. -rm -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Please ignore this message
Hi Mauro, On Fri, Apr 23, 2010 at 2:14 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: You don't need to be subscribed to be able to sending patches, but you need to be sure that you don't have any html attachments on your email, as vger will simply discard anything that it might contain a spam (including html emails). Sorry to make you loose your time. Shame on me... Now I discovered that Majordomo didn't forward the e-mail I sent to my account, only to the other list members... Due to my fault, the patch I sent arrived two times[1] [2] according to patchwork. -rm [1] https://patchwork.kernel.org/patch/94156/ [2] https://patchwork.kernel.org/patch/93688/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cx25821-video-upstream.c: Added severity to printk calls
Signed-off-by: Ricardo Maraschini xrma...@gmail.com
--- a/linux/drivers/staging/cx25821/cx25821-video-upstream.cSun Apr 18
11:12:11 2010 -0300
+++ b/linux/drivers/staging/cx25821/cx25821-video-upstream.cTue Apr 20
11:21:17 2010 -0300
@@ -257,7 +257,7 @@
if (!dev-_is_running) {
printk
- (cx25821: No video file is currently running so return!\n);
+ (KERN_INFO cx25821: No video file is currently running so
return!\n);
return;
}
/* Disable RISC interrupts */
@@ -345,19 +345,19 @@
if (IS_ERR(myfile)) {
const int open_errno = -PTR_ERR(myfile);
- printk(%s(): ERROR opening file(%s) with errno = %d!\n,
+ printk(KERN_ERR %s(): ERROR opening file(%s) with errno =
%d!\n,
__func__, dev-_filename, open_errno);
return PTR_ERR(myfile);
} else {
if (!(myfile-f_op)) {
- printk(%s: File has no file operations registered!,
+ printk(KERN_ERR %s: File has no file operations
registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
}
if (!myfile-f_op-read) {
- printk(%s: File has no READ operations registered!,
+ printk(KERN_ERR %s: File has no READ operations
registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -410,7 +410,7 @@
container_of(work, struct cx25821_dev, _irq_work_entry);
if (!dev) {
- printk(ERROR %s(): since container_of(work_struct) FAILED!\n,
+ printk(KERN_ERR ERROR %s(): since container_of(work_struct)
FAILED!\n,
__func__);
return;
}
@@ -436,12 +436,12 @@
if (IS_ERR(myfile)) {
const int open_errno = -PTR_ERR(myfile);
- printk(%s(): ERROR opening file(%s) with errno = %d!\n,
+ printk(KERN_ERR %s(): ERROR opening file(%s) with errno =
%d!\n,
__func__, dev-_filename, open_errno);
return PTR_ERR(myfile);
} else {
if (!(myfile-f_op)) {
- printk(%s: File has no file operations registered!,
+ printk(KERN_ERR %s: File has no file operations
registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -449,7 +449,7 @@
if (!myfile-f_op-read) {
printk
- (%s: File has no READ operations registered!
Returning.,
+ (KERN_ERR %s: File has no READ operations
registered! Returning.,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -525,7 +525,7 @@
if (!dev-_dma_virt_addr) {
printk
- (cx25821: FAILED to allocate memory for Risc buffer!
Returning.\n);
+ (KERN_ERR cx25821: FAILED to allocate memory for Risc
buffer! Returning.\n);
return -ENOMEM;
}
@@ -546,7 +546,7 @@
if (!dev-_data_buf_virt_addr) {
printk
- (cx25821: FAILED to allocate memory for data buffer!
Returning.\n);
+ (KERN_ERR cx25821: FAILED to allocate memory for data
buffer! Returning.\n);
return -ENOMEM;
}
@@ -641,20 +641,20 @@
} else {
if (status FLD_VID_SRC_UF)
printk
- (%s: Video Received Underflow Error Interrupt!\n,
+ (KERN_ERR %s: Video Received Underflow Error
Interrupt!\n,
__func__);
if (status FLD_VID_SRC_SYNC)
- printk(%s: Video Received Sync Error Interrupt!\n,
+ printk(KERN_ERR %s: Video Received Sync Error
Interrupt!\n,
__func__);
if (status FLD_VID_SRC_OPC_ERR)
- printk(%s: Video Received OpCode Error Interrupt!\n,
+ printk(KERN_ERR %s: Video Received OpCode Error
Interrupt!\n,
__func__);
}
if (dev-_file_status == END_OF_FILE) {
- printk(cx25821: EOF Channel 1 Framecount = %d\n,
+ printk(KERN_ERR cx25821: EOF Channel 1 Framecount = %d\n,
dev-_frame_count);
return -1;
}
@@ -794,7 +794,7 @@
int str_length = 0;
if (dev-_is_running) {
- printk(Video Channel is still running so return!\n);
+ printk
[PATCH] cx25821-video-upstream.c: Added severity to printk calls
Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com
--- a/linux/drivers/staging/cx25821/cx25821-video-upstream.cSun Apr 18
11:12:11 2010 -0300
+++ b/linux/drivers/staging/cx25821/cx25821-video-upstream.cTue Apr 20
11:21:17 2010 -0300
@@ -257,7 +257,7 @@
if (!dev-_is_running) {
printk
- (cx25821: No video file is currently running so return!\n);
+ (KERN_INFO cx25821: No video file is currently running so
return!\n);
return;
}
/* Disable RISC interrupts */
@@ -345,19 +345,19 @@
if (IS_ERR(myfile)) {
const int open_errno = -PTR_ERR(myfile);
- printk(%s(): ERROR opening file(%s) with errno = %d!\n,
+ printk(KERN_ERR %s(): ERROR opening file(%s) with errno =
%d!\n,
__func__, dev-_filename, open_errno);
return PTR_ERR(myfile);
} else {
if (!(myfile-f_op)) {
- printk(%s: File has no file operations registered!,
+ printk(KERN_ERR %s: File has no file operations
registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
}
if (!myfile-f_op-read) {
- printk(%s: File has no READ operations registered!,
+ printk(KERN_ERR %s: File has no READ operations
registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -410,7 +410,7 @@
container_of(work, struct cx25821_dev, _irq_work_entry);
if (!dev) {
- printk(ERROR %s(): since container_of(work_struct) FAILED!\n,
+ printk(KERN_ERR ERROR %s(): since container_of(work_struct)
FAILED!\n,
__func__);
return;
}
@@ -436,12 +436,12 @@
if (IS_ERR(myfile)) {
const int open_errno = -PTR_ERR(myfile);
- printk(%s(): ERROR opening file(%s) with errno = %d!\n,
+ printk(KERN_ERR %s(): ERROR opening file(%s) with errno =
%d!\n,
__func__, dev-_filename, open_errno);
return PTR_ERR(myfile);
} else {
if (!(myfile-f_op)) {
- printk(%s: File has no file operations registered!,
+ printk(KERN_ERR %s: File has no file operations
registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -449,7 +449,7 @@
if (!myfile-f_op-read) {
printk
- (%s: File has no READ operations registered!
Returning.,
+ (KERN_ERR %s: File has no READ operations
registered! Returning.,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -525,7 +525,7 @@
if (!dev-_dma_virt_addr) {
printk
- (cx25821: FAILED to allocate memory for Risc buffer!
Returning.\n);
+ (KERN_ERR cx25821: FAILED to allocate memory for Risc
buffer! Returning.\n);
return -ENOMEM;
}
@@ -546,7 +546,7 @@
if (!dev-_data_buf_virt_addr) {
printk
- (cx25821: FAILED to allocate memory for data buffer!
Returning.\n);
+ (KERN_ERR cx25821: FAILED to allocate memory for data
buffer! Returning.\n);
return -ENOMEM;
}
@@ -641,20 +641,20 @@
} else {
if (status FLD_VID_SRC_UF)
printk
- (%s: Video Received Underflow Error Interrupt!\n,
+ (KERN_ERR %s: Video Received Underflow Error
Interrupt!\n,
__func__);
if (status FLD_VID_SRC_SYNC)
- printk(%s: Video Received Sync Error Interrupt!\n,
+ printk(KERN_ERR %s: Video Received Sync Error
Interrupt!\n,
__func__);
if (status FLD_VID_SRC_OPC_ERR)
- printk(%s: Video Received OpCode Error Interrupt!\n,
+ printk(KERN_ERR %s: Video Received OpCode Error
Interrupt!\n,
__func__);
}
if (dev-_file_status == END_OF_FILE) {
- printk(cx25821: EOF Channel 1 Framecount = %d\n,
+ printk(KERN_ERR cx25821: EOF Channel 1 Framecount = %d\n,
dev-_frame_count);
return -1;
}
@@ -794,7 +794,7 @@
int str_length = 0;
if (dev-_is_running) {
- printk(Video Channel is still running so return!\n
[PATCH] cx25821-video-upstream.c: Added severity to printk calls
Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com
--- a/linux/drivers/staging/cx25821/cx25821-video-upstream.c Sun
Apr 18 11:12:11 2010 -0300
+++ b/linux/drivers/staging/cx25821/cx25821-video-upstream.c Tue
Apr 20 11:21:17 2010 -0300
@@ -257,7 +257,7 @@
if (!dev-_is_running) {
printk
- (cx25821: No video file is currently running so return!\n);
+ (KERN_INFO cx25821: No video file is currently
running so return!\n);
return;
}
/* Disable RISC interrupts */
@@ -345,19 +345,19 @@
if (IS_ERR(myfile)) {
const int open_errno = -PTR_ERR(myfile);
- printk(%s(): ERROR opening file(%s) with errno = %d!\n,
+ printk(KERN_ERR %s(): ERROR opening file(%s) with
errno = %d!\n,
__func__, dev-_filename, open_errno);
return PTR_ERR(myfile);
} else {
if (!(myfile-f_op)) {
- printk(%s: File has no file operations registered!,
+ printk(KERN_ERR %s: File has no file
operations registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
}
if (!myfile-f_op-read) {
- printk(%s: File has no READ operations registered!,
+ printk(KERN_ERR %s: File has no READ
operations registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -410,7 +410,7 @@
container_of(work, struct cx25821_dev, _irq_work_entry);
if (!dev) {
- printk(ERROR %s(): since container_of(work_struct) FAILED!\n,
+ printk(KERN_ERR ERROR %s(): since
container_of(work_struct) FAILED!\n,
__func__);
return;
}
@@ -436,12 +436,12 @@
if (IS_ERR(myfile)) {
const int open_errno = -PTR_ERR(myfile);
- printk(%s(): ERROR opening file(%s) with errno = %d!\n,
+ printk(KERN_ERR %s(): ERROR opening file(%s) with
errno = %d!\n,
__func__, dev-_filename, open_errno);
return PTR_ERR(myfile);
} else {
if (!(myfile-f_op)) {
- printk(%s: File has no file operations registered!,
+ printk(KERN_ERR %s: File has no file
operations registered!,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -449,7 +449,7 @@
if (!myfile-f_op-read) {
printk
- (%s: File has no READ operations
registered! Returning.,
+ (KERN_ERR %s: File has no READ operations
registered! Returning.,
__func__);
filp_close(myfile, NULL);
return -EIO;
@@ -525,7 +525,7 @@
if (!dev-_dma_virt_addr) {
printk
- (cx25821: FAILED to allocate memory for Risc
buffer! Returning.\n);
+ (KERN_ERR cx25821: FAILED to allocate memory for
Risc buffer! Returning.\n);
return -ENOMEM;
}
@@ -546,7 +546,7 @@
if (!dev-_data_buf_virt_addr) {
printk
- (cx25821: FAILED to allocate memory for data
buffer! Returning.\n);
+ (KERN_ERR cx25821: FAILED to allocate memory for
data buffer! Returning.\n);
return -ENOMEM;
}
@@ -641,20 +641,20 @@
} else {
if (status FLD_VID_SRC_UF)
printk
- (%s: Video Received Underflow Error Interrupt!\n,
+ (KERN_ERR %s: Video Received Underflow
Error Interrupt!\n,
__func__);
if (status FLD_VID_SRC_SYNC)
- printk(%s: Video Received Sync Error Interrupt!\n,
+ printk(KERN_ERR %s: Video Received Sync Error
Interrupt!\n,
__func__);
if (status FLD_VID_SRC_OPC_ERR)
- printk(%s: Video Received OpCode Error Interrupt!\n,
+ printk(KERN_ERR %s: Video Received OpCode
Error Interrupt!\n,
__func__);
}
if (dev-_file_status == END_OF_FILE) {
- printk(cx25821: EOF Channel 1 Framecount = %d\n,
+ printk(KERN_ERR cx25821: EOF Channel 1 Framecount = %d\n,
dev-_frame_count);
return -1;
}
@@ -794,7 +794,7 @@
int str_length = 0;
if (dev-_is_running) {
- printk(Video Channel is still running so return!\n);
+ printk(KERN_INFO Video Channel is still running so return!\n);
return 0
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300 @@ -1401,8 +1401,6 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev-ts_gen_cntrl = 0x08; - struct cx88_core *core = dev-core; - cx_set(MO_GP0_IO, 0x0101); cx_clear(MO_GP0_IO, 0x01); -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Little fix on switch identation - cx88-dvb
Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 10:29:09 2010 -0300 @@ -1238,7 +1238,7 @@ fe-ops.tuner_ops.set_config(fe, ctl); } break; -case CX88_BOARD_PINNACLE_HYBRID_PCTV: + case CX88_BOARD_PINNACLE_HYBRID_PCTV: case CX88_BOARD_WINFAST_DTV1800H: fe0-dvb.frontend = dvb_attach(zl10353_attach, cx88_pinnacle_hybrid_pctv, -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Hi Randy, On Tue, Mar 23, 2010 at 4:45 PM, Randy Dunlap randy.dun...@oracle.com wrote: Did you test this patch (by building this driver)? I think not. I tried to compile with the patch, but in a wrong way. Sorry. I'm going to adjust the patch and send again. Also, the Signed-off-by: line should be before the patch, not after it. Thanks, I will remember this. -rm -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
On Tue, Mar 23, 2010 at 5:48 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: How do you think this actually addresses the warning in question? You still have the declaration of the variable in the middle of the switch statement. My mistake, sorry. I'm working on it. Thanks for your tip, I really appreciate that. -rm -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
