Re: uvcvideo: IR camera lights only every second frame

Hi On Tue, Oct 30, 2018 at 4:49 PM Kieran Bingham wrote: > > Hi Jiri, > > On 30/10/2018 14:36, Jiri Slaby wrote: > > Hi, > > > > I have a Dell Lattitude 7280 with two webcams. The standard one works > > fine (/dev/video0). The other one is an IR camera (/dev/video1). The > > camera proper works

[PATCH v3 1/2] [media] imx214: device tree binding

Document bindings for imx214 camera sensor Cc: devicet...@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- Changelog from v2: Laurent Pinchart: -Spell checks -Remove frequency -Identation -Data lanes order Thanks! .../devicetree/bindings/media/i2c/imx214.txt | 52

[PATCH] media: smiapp: Remove unused loop

The loop seemed to be made to calculate max, but max is not used in that function. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/smiapp/smiapp-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c

Power Management and lens-focus

Hello I have started using the lens-focus property: ad5820: dac@0c { compatible = "adi,ad5820"; reg = <0x0c>; VANA-supply = <_l23>; enable-gpios = < 26 GPIO_ACTIVE_HIGH>; }; camera_rear@60 { lens-focus = <>; }; I was testing my device using the following setup: qv4l2 grabbing images and yavta

[PATCH v2] libv4l: Add support for BAYER10P format conversion

Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/bayer.c

Re: [PATCH] libv4l: Add support for BAYER10P format conversion

Hi Hans On Fri, Sep 21, 2018 at 9:38 AM Hans de Goede wrote: > > Hi, > > On 20-09-18 22:04, Ricardo Ribalda Delgado wrote: > > Add support for 10 bit packet Bayer formats: > > -V4L2_PIX_FMT_SBGGR10P > > -V4L2_PIX_FMT_SGBRG10P > > -V4L2_PIX_FMT

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > > [snip] > > > > > > > +

ad5820: Sorry for the invalid v3

HI Sorry, I did not check the produced files before sending them with git send-email. It has been a long day. Please ignore v3 and use v4. I will write 100 times: I will check my patches before sending them to the mailing list Cheers -- Ricardo Ribalda

[PATCH] libv4l: Add support for BAYER10P format conversion

Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/bayer.c

[RFP] Media Summit: Save/Restore controls from MTD

Industrial/Scientific sensors usually come with very extensive calibration information such as: per column gain, list of dead/pixels, temperature sensor offset... etc We are saving that information on an flash device that is located by the sensor. I would like some minutes (15 max) to show you

[PATCH v2] media: v4l2-ctrl: Fix flags field on Control events

that exports the internal flags to userspace. Reported-by: Dimitrios Katsaros <patcherw...@gmail.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Attention: Maybe we want to cc stable. v2: Suggested-by Hans Verkuil <hverk...@xs4all.nl> -Define struct

[PATCH] media: v4l2-ctrl: Fix flags field on Control events

that exports the internal flags to userspace. Reported-by: Dimitrios Katsaros <patcherw...@gmail.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Maybe we should cc stable on this one. drivers/media/v4l2-core/v4l2-ctrls.c | 16 1 file

[PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

max_width and max_height are swap with step_width and step_height. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Since that this bug has been here for ever. I do not know if we should notify stable or not I have also cut the lines to respect the 80 char lim

[PATCH] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

max_width and max_height are swap with step_width and step_height. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Since that this bug has been here for ever. I do not know if we should notify stable or not I have also cut the lines to respect the 80 char limit d

Re: [ANN] Call for topics for the media mini-summit on Friday Oct 27 in Prague

Hi Hans On Fri, Sep 1, 2017 at 11:46 AM, Hans Verkuil wrote: > > > Also, if you plan to attend, please let me know. It is open for all, but it is > nice if we know beforehand who we can expect. > I plan to attend. I do not have any specific topic right now, but as the date

[PATCH] v4l2-ctl: Show HSV encodings names

: Default YCbCr/HSV Encoding: Hue 0 - 179 Quantization : Default Flags : Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- utils/v4l2-ctl/v4l2-ctl.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/utils/v4

[PATCH 3/3] qv4l2: Support for HSV encodings

Support set/get and override of HSV encodings. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- utils/qv4l2/general-tab.cpp | 4 +++- utils/qv4l2/qv4l2.cpp | 5 - utils/qv4l2/tpg-tab.cpp | 4 +++- 3 files changed, 10 insertions(+), 3 deletions(-) diff

[PATCH 1/2] v4l2-tpg: Init hv_enc field with a valid value

Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c b/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c index 28d7b072d867..e47b46e2d26c 100644 --- a/drivers

[PATCH 2/2] vivid: Set color_enc on HSV formats

HSV formats were missing the color encoding, which leads to an invalid ycbcr_enc value during get_fmt and try_fmt. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/platform/vivid/vivid-vid-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[PATCH 2/3] qv4l: support for HSV formats via OpenGL.

Support for HSV32 and HSV24. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- utils/qv4l2/capture-win-gl.cpp | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/utils/qv4l2/capture-win-gl.cpp b/utils/qv4l2/capture-win-

[PATCH 1/3] libv4lconvert: Add support for V4L2_PIX_FMT_{HSV24, HSV32}

HSV32 and HSV24 are single plane interleaved Hue Saturation Value formats. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- lib/libv4lconvert/libv4lconvert-priv.h | 3 ++ lib/libv4lconvert/libv4lconvert.c | 62 +++ lib/libv4lconvert/rg

[GIT PULL] HSV formats v2

: vsp1: Add support for capture and output in HSV formats Ricardo Ribalda Delgado (12): videodev2.h Add HSV formats Documentation: Add HSV format Documentation: Add Ricardo Ribalda vivid: Code refactor for color encoding vivid: Add support for HSV formats vivid

[GIT PULL] HSV formats

to 1242d7e43b9053cd649ac5ec81aad8597e88ab46: [media] vsp1: Add support for capture and output in HSV formats (2016-09-07 10:41:52 +0200) Laurent Pinchart (1): [media] vsp1: Add support for capture and output in HSV formats Ricardo Ribalda Delgado (12

Re: [PATCH] v4l: vsp1: Add support for capture and output in HSV formats

Hi Laurent, On Wed, Sep 7, 2016 at 9:09 AM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: >> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> > > Do you mean Acked-by ? Acked-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.

Re: [PATCH] v4l: vsp1: Add support for capture and output in HSV formats

through without performing any processing. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v5_2 10/12] [media] videodev2.h Add HSV encoding

Some hardware maps the Hue between 0 and 255 instead of 0-179. Support this format with a new field hsv_enc. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- v5_2: s/s_rgb_or_yuv/s_rgb_or_hsv/ Thanks Hans!! include/uapi/linux/videodev2.

Re: [PATCH v5 10/12] [media] videodev2.h Add HSV encoding

Hello Hans: > > That should be is_rgb_or_hsv. Sorry about that! I am resending v5_2 with only that patch fixed > > All other patches look OK. Thanks > > It would be useful though if you could rebase on top of > https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=sycc. > I have a pull

[PATCH v5 08/12] [media] vivid: Fix YUV555 and YUV565 handling

precalculate_color() had a optimization that avoided duplicated conversion for YUV formats. This optimization did not take into consideration YUV444, YUV555, YUV565 or limited range quantization. This patch keeps the optimization, but fixes the wrong handling. Signed-off-by: Ricardo Ribalda

[PATCH v5 04/12] [media] vivid: Code refactor for color encoding

Replace is_yuv with color_enc Which can be used by other color encodings such us HSV. This change should ease the review of the following patches. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c

[PATCH v5 06/12] [media] vivid: Rename variable

r_y and g_u now also contain the H and V components on the HSV formats. Rename the variables to reflect this. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +- 1 file changed, 105 inse

[PATCH v5 07/12] [media] vivid: Introduce TPG_COLOR_ENC_LUMA

Simplifies handling of Gray formats. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 26 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 6 +++--- include/media/v4l2

[PATCH v5 05/12] [media] vivid: Add support for HSV formats

This patch adds support for V4L2_PIX_FMT_HSV24 and V4L2_PIX_FMT_HSV32. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 93 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 14 include

[PATCH v5 12/12] [media] vivid: Add support for HSV encoding

Support HSV encoding. Most of the logic is replicated from ycbcr_enc. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 25 + drivers/media/platform/vivid/vivid-core.h | 1 + drivers

[PATCH v5 00/12] Add HSV format

file Thanks! Suggested by Hans Verkuil <hverk...@xs4all.nl> -Rebase over master and docs-next -Introduce TPG_COLOR_ENC_LUMA for gray formats -CodeStyle Thanks! v2: Suggested by Mauro Carvalho Chehab <mche...@osg.samsung.com>, -Rebase on top of docs-next (port documentation to .rst) Ricardo R

[PATCH v5 10/12] [media] videodev2.h Add HSV encoding

Some hardware maps the Hue between 0 and 255 instead of 0-179. Support this format with a new field hsv_enc. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- include/uapi/linux/videodev2.h | 32 +++- 1 file changed, 27 insertions(+), 5 del

[PATCH v5 02/12] [media] Documentation: Add HSV format

Describe the HSV formats Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/hsv-formats.rst | 19 +++ Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 158 + Documentation/media/uapi/v4l/pixfmt.rst

[PATCH v5 11/12] [media] Documentation: Add HSV encodings

Describe the hsv_enc field and its use. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/pixfmt-002.rst| 12 ++- Documentation/media/uapi/v4l/pixfmt-003.rst| 14 ++-- Documentation/media/uapi/v4l/pixfmt-0

[PATCH v5 09/12] [media] vivid: Local optimization

Avoid duplicated clamps when possible. Suggested-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-)

[PATCH v5 03/12] [media] Documentation: Add Ricardo Ribalda

My initials were on the Changelog, but there was no link to my name. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/v4l2.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/media/uapi/v4l/v4l2.rst b/Documentation

[PATCH v5 01/12] [media] videodev2.h Add HSV formats

. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c

Re: [PATCH 0658/1285] Replace numeric parameter like 0444 with macro

Hi On Tue, Aug 2, 2016 at 1:34 PM, Baole Ni wrote: > thus, I suggest replacing the numeric parameter with the macro. For what my opinion is worth it... I found more comprehensive the octal values than the macros, but maybe it is because I am old and dream in hexadecimal

[PATCH v2] [media] Documentation: Fix V4L2_CTRL_FLAG_VOLATILE

-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- v2: By Hans Verkuil <hansv...@cisco.com> -Fix some syntax errors By Mauro Carvalho Chehab <mche...@kernel.org> -Add hyperlinks Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 11 +++ 1 file changed, 7 insertions(

[PATCH] [media] Documentation: Fix V4L2_CTRL_FLAG_VOLATILE

V4L2_CTRL_FLAG_VOLATILE behaviour when V4L2_CTRL_FLAG_EXECUTE_ON_WRITE is set was not properly explained. Reported-by: Dimitrios Katsaros <patcherw...@gmail.com> Credit-to: Hans Verkuil <hansv...@cisco.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>

Re: [PATCH v4 09/12] [media] vivid: Local optimization

Hi Philipp: On Mon, Jul 18, 2016 at 4:16 PM, Philipp Zabel wrote: > I had the best looking result with this variant, btw: > > y >>= 4; > cb >>= 4; > cr >>= 4; > if (tpg->real_quantization == V4L2_QUANTIZATION_LIM_RANGE) { >

Re: [PATCH v4 09/12] [media] vivid: Local optimization

Hi Philipp On Mon, Jul 18, 2016 at 3:13 PM, Philipp Zabel wrote: > Since the constant expressions are evaluated at compile time, you are > not actually removing shifts. The code generated for precalculate_color > by gcc 5.4 even grows by one asr instruction with this

[PATCH v4 01/12] [media] videodev2.h Add HSV formats

. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH v4 04/12] [media] vivid: Code refactor for color encoding

Replace is_yuv with color_enc Which can be used by other color encodings such us HSV. This change should ease the review of the following patches. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c

[PATCH v4 00/12] Add HSV format

aster and docs-next -Introduce TPG_COLOR_ENC_LUMA for gray formats -CodeStyle Thanks! v2: Suggested by Mauro Carvalho Chehab <mche...@osg.samsung.com>, -Rebase on top of docs-next (port documentation to .rst) Ricardo Ribalda Delgado (12): [media] videodev2.h Add HSV formats [media] Do

[PATCH v4 03/12] [media] Documentation: Add Ricardo Ribalda

My initials were on the Changelog, but there was no link to my name. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/v4l2.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/media/uapi/v4l/v4l2.rst b/Documentation

[PATCH v4 07/12] [media] vivid: Introduce TPG_COLOR_ENC_LUMA

Simplifies handling of Gray formats. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 26 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 6 +++--- include/media/v4l2

[PATCH v4 10/12] [media] videodev2.h Add HSV encoding

Some hardware maps the Hue between 0 and 255 instead of 0-179. Support this format with a new field hsv_enc. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- include/uapi/linux/videodev2.h | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-)

[PATCH v4 05/12] [media] vivid: Add support for HSV formats

This patch adds support for V4L2_PIX_FMT_HSV24 and V4L2_PIX_FMT_HSV32. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 93 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 14 include

[PATCH v4 08/12] [media] vivid: Fix YUV555 and YUV565 handling

precalculate_color() had a optimization that avoided duplicated conversion for YUV formats. This optimization did not take into consideration YUV444, YUV555, YUV565 or limited range quantization. This patch keeps the optimization, but fixes the wrong handling. Signed-off-by: Ricardo Ribalda

[PATCH v4 06/12] [media] vivid: Rename variable

r_y and g_u now also contain the H and V components on the HSV formats. Rename the variables to reflect this. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +- 1 file changed, 105 inse

[PATCH v4 02/12] [media] Documentation: Add HSV format

Describe the HSV formats Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/hsv-formats.rst | 19 +++ Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 158 + Documentation/media/uapi/v4l/pixfmt.rst

[PATCH v4 12/12] [media] vivid: Add support for HSV encoding

Support HSV encoding. Most of the logic is replicated from ycbcr_enc. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 25 + drivers/media/platform/vivid/vivid-core.h | 1 + drivers

[PATCH v4 11/12] [media] Documentation: Add HSV encodings

Describe the hsv_enc field and its use. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/pixfmt-002.rst| 12 ++- Documentation/media/uapi/v4l/pixfmt-003.rst| 14 ++-- Documentation/media/uapi/v4l/pixfmt-0

[PATCH v4 09/12] [media] vivid: Local optimization

Avoid duplicated data shifts when possible. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-cor

Re: [PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

Hi Hans On Mon, Jul 18, 2016 at 10:51 AM, Hans Verkuil wrote: >> + int y, cb, cr; >> + bool ycbbr_valid = false; > > I guess you mean ycbcr_valid? Yes, I think the medical term is Saturday dyslexia :) It is fixed on the next version. Thanks! -- To unsubscribe from

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

Hi Hans On Sat, Jul 16, 2016 at 5:28 PM, Hans Verkuil wrote: > >> + >> +enum v4l2_rgb_encoding { >> + V4L2_RGB_ENC_FULL = 32, >> + V4L2_HSV_ENC_16_235 = 33, >> +}; > > No. I was trying to fit also Laurent special 16-235 RGB format. I will remove it on

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

Hi On Sat, Jul 16, 2016 at 4:12 PM, Laurent Pinchart wrote: > I'd still like to know about it for my personal information :-) Maybe it is just a very cheap gamma. > >> Anyway, I am inclined to use ycbcr_enc as well. > > I'm glad we agree. > Are you thinking

Re: [PATCH v3 9/9] [media] vivid: Local optimization

Hi On Sat, Jul 16, 2016 at 12:41 PM, Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> wrote: > - cr = clamp(cr, 16 << 4, 240 << 4); > + y = clamp(y >> 4, 16, 235); > + cb = clamp(cb >> 4,

[PATCH v3 8/9] [media] vivid: Fix YUV555 and YUV565 handling

precalculate_color() had a optimization that avoided duplicated conversion for YUV formats. This optimization did not take into consideration YUV444, YUV555, YUV565 or limited range quantization. This patch keeps the optimization, but fixes the wrong handling. Signed-off-by: Ricardo Ribalda

[PATCH v3 6/9] [media] vivid: Rename variable

r_y and g_u now also contain the H and V components on the HSV formats. Rename the variables to reflect this. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +- 1 file changed, 105 inse

[PATCH v3 2/9] [media] Documentation: Add HSV format

Describe the HSV formats Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/hsv-formats.rst | 19 +++ Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 158 + Documentation/media/uapi/v4l/pixfmt.rst

[PATCH v3 9/9] [media] vivid: Local optimization

Avoid duplicated data shifts when possible. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-cor

[PATCH v3 3/9] [media] Documentation: Add Ricardo Ribalda

My initials were on the Changelog, but there was no link to my name. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/v4l2.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/media/uapi/v4l/v4l2.rst b/Documentation

[PATCH v3 0/9] Add HSV format

-Rebase over master and docs-next -Introduce TPG_COLOR_ENC_LUMA for gray formats -CodeStyle Thanks! v2: Suggested by Mauro Carvalho Chehab <mche...@osg.samsung.com>, -Rebase on top of docs-next (port documentation to .rst) Ricardo Ribalda Delgado (9): [media] videodev2.h Add HS

[PATCH v3 7/9] [media] vivid: Introduce TPG_COLOR_ENC_LUMA

Simplifies handling of Gray formats. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 26 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 6 +++--- include/media/v4l2

[PATCH v3 1/9] [media] videodev2.h Add HSV formats

. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH v3 4/9] [media] vivid: code refactor for color encoding

Replace is_yuv with color_enc Which can be used by other color encodings such us HSV. This change should ease the review of the following patches. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c

[PATCH v3 5/9] [media] vivid: Add support for HSV formats

This patch adds support for V4L2_PIX_FMT_HSV24 and V4L2_PIX_FMT_HSV32. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 93 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 14 include

Re: [PATCH v2 2/6] [media] Documentation: Add HSV format

help me? Thanks! On Fri, Jul 15, 2016 at 8:11 PM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Ricardo, > > Thank you for the patch. > > On Friday 15 Jul 2016 18:13:15 Ricardo Ribalda Delgado wrote: >> Describe the HSV formats >> >>

[PATCH v2 1/6] [media] videodev2.h Add HSV formats

. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH v2 6/6] [media] vivid: Rename variable

r_y and g_u now also contain the H and V components on the HSV formats. Rename the variables to reflect this. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +- 1 file changed, 105 inse

[PATCH v2 2/6] [media] Documentation: Add HSV format

Describe the HSV formats Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/hsv-formats.rst | 19 ++ Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 253 + Documentation/media/uapi/v4l/pixfmt.rst

[PATCH v2 5/6] [media] vivid: Add support for HSV formats

This patch adds support for V4L2_PIX_FMT_HSV24 and V4L2_PIX_FMT_HSV32. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 94 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 14 include

[PATCH v2 4/6] [media] vivid: code refactor for color representation

Replace is_yuv with color_representation. Which can be used by HSV formats. This change should ease the review of the following patches. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 44 ++--- d

[PATCH v2 0/6] Add HSV format

! Changelog v2: Suggested by Mauro Carvalho Chehab <mche...@osg.samsung.com>, -Rebase on top of docs-next (port documentation to .rst) @mchehab, You were right, there was no conflict after the rebase, Thanks! Ricardo Ribalda Delgado (6): [media] videodev2.h Add HSV formats [media] Documentation: A

[PATCH v2 3/6] [media] Documentation: Add Ricardo Ribalda

My initials were on the Changelog, but there was no link to my name. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/media/uapi/v4l/v4l2.rst | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/media/uapi/v4l/v4l2.rst b/Documentation

Re: [PATCH 2/6] [media] Documentation: Add HSV format

Hi Mauro On Fri, Jul 15, 2016 at 5:28 PM, Mauro Carvalho Chehab wrote: > Hi Ricardo, > > I'm not seeing patch 1. That is because you blacklisted me :P https://lkml.org/lkml/2016/7/15/455 I resend it to you right away. > > Anyway, please send documentation patches

[PATCH 1/6] [media] videodev2.h Add HSV formats

. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4 2 files changed, 6 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH 5/6] [media] vivid: Add support for HSV formats

This patch adds support for V4L2_PIX_FMT_HSV24 and V4L2_PIX_FMT_HSV32. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 94 +++-- drivers/media/platform/vivid/vivid-vid-common.c | 14 include

[PATCH 4/6] [media] vivid: code refactor for color representation

Replace is_yuv with color_representation. Which can be used by HSV formats. This change should ease the review of the following patches. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 44 ++--- d

[PATCH 2/6] [media] Documentation: Add HSV format

Describe the HSV formats. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- .../DocBook/media/v4l/pixfmt-packed-hsv.xml| 195 + Documentation/DocBook/media/v4l/pixfmt.xml | 13 ++ Documentation/DocBook/media/v4l/v4l2.xml

[PATCH 0/6] Add HSV format

Ribalda Delgado (6): [media] videodev2.h Add HSV formats [media] Documentation: Add HSV format [media] Documentation: Add Ricardo Ribalda as author [media] vivid: code refactor for color representation [media] vivid: Add support for HSV formats [media] vivid: Rename variable

[PATCH 6/6] [media] vivid: Rename variable

r_y and g_u now also contain the H and V components on the HSV formats. Rename the variables to reflect this. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +- 1 file changed, 105 inse

[PATCH 3/6] [media] Documentation: Add Ricardo Ribalda as author

My initials were on the Changelog, but there was no link to my mail. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Documentation/DocBook/media/v4l/v4l2.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/DocBook/media/v4l/v4l2.

[PATCH v3 2/4] vb2: Merge vb2_internal_dqbuf and vb2_dqbuf

After all the code refactoring, vb2_internal_dqbuf is only called by vb2_dqbuf. Since the function it is very simple, there is no need to have two functions. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-v4l2.

[PATCH v3 4/4] vb2: Fix comment

The comment was referencing the wrong function. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l

[PATCH v3 1/4] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-v4l2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/v4l2-core/videobuf2-v4l2.c b/drivers/media/v4l2-core/videobuf2-v4l2.c index 7f366f1b0377..6d14df3

[PATCH v3 3/4] vb2: Merge vb2_internal_qbuf and vb2_qbuf

After all the code refactoring, vb2_internal_dqbuf is only called by vb2_dqbuf. Since the function it is very simple, there is no need to have two functions. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-v4l2.c | 14 +--

[PATCH v2 1/4] vb2: Merge vb2_internal_dqbuf and vb2_dqbuf

After all the code refactoring, vb2_internal_dqbuf is only called by vb2_dqbuf. Since the function it is very simple, there is no need to have two functions. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-v4l2.

[PATCH v2 4/4] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-v4l2.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/v4l2-core/videobuf2-v4l2.c b/drivers/media/v4l2-core/videobuf2-v4l2.c index ba3467468e55..9cfbb6e

[PATCH v2 3/4] vb2: Fix comment

The comment was referencing the wrong function. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l

[PATCH v2 2/4] vb2: Merge vb2_internal_qbuf and vb2_qbuf

After all the code refactoring, vb2_internal_dqbuf is only called by vb2_dqbuf. Since the function it is very simple, there is no need to have two functions. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-v4l2.c | 14 +--

[PATCH] v4l2-compliance: Check V4L2_BUF_FLAG_DONE

According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF and QBUF: V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or VIDIOC_DQBUF it is always cleared .. This patch implements this check. Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- Hell

Re: [PATCH] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

erk...@xs4all.nl> wrote: > On 06/20/2016 11:01 AM, Ricardo Ribalda Delgado wrote: >> According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF: >> >> V4L2_BUF_FLAG_DONE 0x0004 ... After calling the VIDIOC_QBUF or >> VIDIOC_DQBUF it is always cleared ... >> &g

[PATCH] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

Katsaros <patcherw...@gmail.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com> --- drivers/media/v4l2-core/videobuf2-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-co

RFC: HSV format

Hi HSV is a cylindrical-coordinate representation of a color. It is very useful for computer vision because the Hue component can be used to segment a scene. My plan was to add a format in videodev2.h and then add support for vivid, libv4l2-convert and qv4l2. There are also plans to prepare a

  1   2   3   4   5   >