This ioctl returns the default value of one or more extended controls.
It has the same interface as VIDIOC_EXT_CTRLS.
It is needed due to the fact that QUERYCTRL was not enough to
provide the initial value of pointer type controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
documentation
-Split in multiple patches
-Comments by Hans:
-Rename ioctl to G_DEF_EXT_CTRL
-Much! better implementation of def_to_user
THANKS!
Ricardo Ribalda Delgado (27):
media/v4l2-core: Add argument def_value to g_ext_ctrl
media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS
videodev2.h
Add documentation for new ioctl.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
Documentation/DocBook/media/v4l/v4l2.xml | 8
Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 13 +
Documentation/video4linux/v4l2-controls.txt
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/saa7115.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c
index 0eae5f4471e2..c227dc11b136 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tda7432.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tda7432.c b/drivers/media/i2c/tda7432.c
index cf93021a6500..efff7d48ce9e 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/wm8739.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/wm8739.c b/drivers/media/i2c/wm8739.c
index 3be73f6a40e9..003c07bee16f 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/saa717x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/saa717x.c b/drivers/media/i2c/saa717x.c
index 7d517361e419..e1f94e0131e2 100644
--- a/drivers/media/i2c
This function returns the default value of an extended control. Provides
sub-devices with the same functionality as ioctl VIDIOC_G_DEF_EXT_CTRLS.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
include/media/v4l2-ctrls.h
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/cs53l32a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/cs53l32a.c b/drivers/media/i2c/cs53l32a.c
index 27400c16ef9a..9358350278cc 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/adv7393.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/adv7393.c b/drivers/media/i2c/adv7393.c
index 558f19154eb9..e59e29335c83 100644
--- a/drivers/media/i2c
Via control framework
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/adv7343.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c
index 7c50833e7d17..9753fb545f17 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/ivtv/ivtv-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/ivtv/ivtv-gpio.c
b/drivers/media/pci/ivtv/ivtv-gpio.c
index af52def700cc..d16f210670e2 100644
If def_value is set, the default value for the controls is returned.
Helper function def_to_user is also added with the same interface as
cur_to_user or new_to_user.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
drivers
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tvp7002.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
index 05077cffd235..006170ebe3da 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/radio/saa7706h.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/radio/saa7706h.c b/drivers/media/radio/saa7706h.c
index ec805b09c608..cac1496da7e2 100644
--- a/drivers
Referenced file has moved
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
include/uapi/linux/videodev2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index b9468a3b833e..b059237f0214
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/msp3400-driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/msp3400-driver.c
b/drivers/media/i2c/msp3400-driver.c
index dcc68ec71732..10837564af8e 100644
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tvp514x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c
index 24e47279e30c..d69708aac627 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tvaudio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tvaudio.c b/drivers/media/i2c/tvaudio.c
index 0c50e5285cf6..05972a5d2c68 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/sr030pc30.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/sr030pc30.c b/drivers/media/i2c/sr030pc30.c
index b62b6ddc4356..23836801218a 100644
--- a/drivers/media
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tlv320aic23b.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tlv320aic23b.c b/drivers/media/i2c/tlv320aic23b.c
index ef87f7b09ea2..4e279de8e194 100644
Add newly created core op to the example.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
Documentation/video4linux/v4l2-controls.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/video4linux/v4l2-controls.txt
b/Documentation/video4linux/v4l2
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/cx25840/cx25840-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/cx25840/cx25840-core.c
b/drivers/media/i2c/cx25840/cx25840-core.c
index e15a789ad596
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/vpx3220.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/vpx3220.c b/drivers/media/i2c/vpx3220.c
index 016e766e72ba..60d635250b19 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/bt819.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/bt819.c b/drivers/media/i2c/bt819.c
index 76b334a6a56d..b3e9ac3616b5 100644
--- a/drivers/media/i2c/bt819.c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/wm8775.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c
index bee7946faa7c..45d4873aca74 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/cs5345.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/cs5345.c b/drivers/media/i2c/cs5345.c
index 34b76a9e7515..ad3c89585909 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/saa7110.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/saa7110.c b/drivers/media/i2c/saa7110.c
index 99689ee57d7e..964cc2cf1508 100644
--- a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/saa717x.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/ivtv/ivtv-gpio.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media
Remove no longer used compat control ops, as they are not used in their
bridge drivers.
Working tree can be found at
https://github.com/ribalda/linux/tree/compat_control_clean
Ricardo Ribalda Delgado (12):
media/i2c/adv7343: Remove compat control ops
media/i2c/adv7393: Remove compat control
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tvp514x.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/adv7393.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tlv320aic23b.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tda7432.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/adv7343.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tvp7002.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/wm8739.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c/wm8739
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/radio/saa7706h.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/sr030pc30.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c
They are no longer used in old non-control-framework
bridge drivers.
Reported-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/cs5345.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/i2c/cs5345
Hello Hans
On Fri, Jun 12, 2015 at 3:41 PM, Hans Verkuil hverk...@xs4all.nl wrote:
I did a quick analysis and for the following i2c modules you can just remove
the
compat control ops altogether since they are no longer used in old
non-control-framework
bridge drivers:
saa7706
Hello Hans
On Tue, Jun 16, 2015 at 8:09 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Ricardo,
This patch series looks good to me. I'll wait a bit to see if anyone else has
comments. If not, then I'll merge for 4.3.
If this is merged in 4.3 I need to fix the documentation.
Please use the
Add documentation for new ioctl.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
v4:
-Add Author information
-Set kernel version to 4,3
Documentation/DocBook/media/v4l/v4l2.xml | 20
.../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 13
This ioctl returns the default value of one or more extended controls.
It has the same interface as VIDIOC_EXT_CTRLS.
It is needed due to the fact that QUERYCTRL was not enough to
provide the initial value of pointer type controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
! better implementation of def_to_user
THANKS!
Ricardo Ribalda Delgado (19):
media/v4l2-core: Add argument def_value to g_ext_ctrl
media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS
videodev2.h: Fix typo in comment
media/usb/uvc: Implement vivioc_g_def_ext_ctrls
media/pci/saa7164
Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not
use the controller framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/usb/uvc/uvc_v4l2.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers
If def_value is set, the default value for the controls is returned.
Helper function def_to_user is also added with the same interface as
cur_to_user or new_to_user.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/platform/omap3isp/ispvideo.c | 2 +-
drivers
Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not
use the controller framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 28
1 file changed, 28 insertions(+)
diff --git
Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not
use the controller framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/saa7164/saa7164-vbi.c | 28
1 file changed, 28 insertions(+)
diff --git
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/vpx3220.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/vpx3220.c b/drivers/media/i2c/vpx3220.c
index 016e766e72ba..60d635250b19 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/wm8775.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/wm8775.c b/drivers/media/i2c/wm8775.c
index bee7946faa7c..45d4873aca74 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/msp3400-driver.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/msp3400-driver.c
b/drivers/media/i2c/msp3400-driver.c
index dcc68ec71732..10837564af8e 100644
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/saa7115.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c
index 0eae5f4471e2..c227dc11b136 100644
--- a/drivers/media/i2c
Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not
use the controller framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/saa7164/saa7164-encoder.c | 28
1 file changed, 28 insertions(+)
diff --git
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/saa7110.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/saa7110.c b/drivers/media/i2c/saa7110.c
index 99689ee57d7e..964cc2cf1508 100644
--- a/drivers/media/i2c
Referenced file has moved
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
include/uapi/linux/videodev2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index b9468a3b833e..b059237f0214
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/bt819.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/bt819.c b/drivers/media/i2c/bt819.c
index 76b334a6a56d..b3e9ac3616b5 100644
--- a/drivers/media/i2c/bt819.c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/cs53l32a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/cs53l32a.c b/drivers/media/i2c/cs53l32a.c
index 27400c16ef9a..9358350278cc 100644
--- a/drivers/media/i2c
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/cx25840/cx25840-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/cx25840/cx25840-core.c
b/drivers/media/i2c/cx25840/cx25840-core.c
index e15a789ad596
Via control framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/i2c/tlv320aic23b.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tlv320aic23b.c b/drivers/media/i2c/tlv320aic23b.c
index ef87f7b09ea2..4e279de8e194 100644
This function returns the default value of an extended control. Provides
sub-devices with the same functionality as ioctl VIDIOC_G_DEF_EXT_CTRLS.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
include/media/v4l2-ctrls.h
Add documentation for new ioctl.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
Documentation/DocBook/media/v4l/v4l2.xml | 8
Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 13 +
Documentation/video4linux/v4l2-controls.txt
Add newly created core op to the example.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
Documentation/video4linux/v4l2-controls.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/video4linux/v4l2-controls.txt
b/Documentation/video4linux/v4l2
Hello Hans
On Mon, Jun 1, 2015 at 9:05 AM, Hans Verkuil hverk...@xs4all.nl wrote:
Currently the colors for the Y16 and Y16_BE pixelformats are in the range
0x-0xff00. So pure white (0x) is never created.
Improve this by using the same byte for both LSB and MSB so the full range
is
Hello
I have a subdevice that can produce images at a programmable interval,
i.e. at different fps.
I was using the callback enum_frameintervals to negotiate the frame
rate, but since 4.1 it is gone in favor of enum_frame_interval.
enum_frame_interval, seems to only return one value for fps.
ping?
On Mon, Aug 10, 2015 at 2:04 PM, Ricardo Ribalda Delgado
ricardo.riba...@gmail.com wrote:
Hello Hans, Sakari and Laurent:
I am back from holidays :). Shall I prepare a new patchset with the
suggestion from Hans?
Thanks!
On Mon, Jul 20, 2015 at 4:31 PM, Hans Verkuil hverk
Replace ctrls_class with which on all the codebase
Changes in Documentation
(Thanks!)
Ricardo Ribalda Delgado (10):
videodev2.h: Fix typo in comment
videodev2.h: Extend struct v4l2_ext_controls
media/v4l2-compat-ioctl32: Simple stylechecks
media/core: Replace ctrl_class with which
media
Ribalda Delgado ricardo.riba...@gmail.com
---
.../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 6 +++---
drivers/media/pci/saa7164/saa7164-encoder.c| 6 +++---
drivers/media/pci/saa7164/saa7164-vbi.c| 6 +++---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +-
drivers
The next patches on the serie need this modifications to pass clean
checkpath.pl.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/media
Referenced file has moved
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
include/uapi/linux/videodev2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 3228fbebcd63..72fa3e490e30
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/saa7164/saa7164-vbi.c | 57 +++--
1 file changed, 33
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/saa7164/saa7164-encoder.c | 55 -
1 file changed, 31
Vidioc-g-ext-ctrls can now be used to get the default value of the
controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
Documentation/DocBook/media/v4l/v4l2.xml | 9 +
.../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 22 ++
2
So it can be used to get the default value of a control.
Without this change it is not possible to get get the
default value of array controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
include/uapi/linux/videodev2.h | 7 ++-
1 file changed, 6 insertions(+), 1
Support for new field which on v4l2_ext_controls, used to get the
default value of one or more controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
I missed a ;... sorry about that
drivers/media/v4l2-core/v4l2-ctrls.c | 34 +-
1 file
Support for new field which on v4l2_ext_controls, used to get the
default value of one or more controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 34 +-
1 file changed, 29 insertions(+), 5
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/usb/uvc/uvc_v4l2.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 17 -
1 file changed, 16 insertions(+), 1
Hello Hans
With this patch I guess two of my previous patches are not needed.
Shall i resend the patchset or you just cherry pick the appropriate
ones?
Thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Acked-By: Mike Isely is...@pobox.com
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
changes v3:
By Mike Isely is...@pobox.com
elevate the call
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/saa7164/saa7164-encoder.c | 55 -
1 file changed, 31
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/pci/saa7164/saa7164-vbi.c | 57 +++--
1 file changed, 33
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 17 -
1 file changed, 16 insertions(+), 1
Referenced file has moved
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
include/uapi/linux/videodev2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 3228fbebcd63..72fa3e490e30
):
Suggested by Hans Verkuil hverk...@xs4all.nl
Replace ioctl implementation with a new union on the struct v4l2_ext_controls
THANKS!
Ricardo Ribalda Delgado (8):
videodev2.h: Fix typo in comment
videodev2.h: Extend struct v4l2_ext_controls
media/v4l2-core: struct struct v4l2_ext_controls
So it can be used to get the default value of a control.
Without this change it is not possible to get get the
default value of array controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
include/uapi/linux/videodev2.h | 7 ++-
1 file changed, 6 insertions(+), 1
Vidioc-g-ext-ctrls can now be used to get the default value of the
controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
Documentation/DocBook/media/v4l/v4l2.xml | 9 +
Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 14 ++
2
Support for new field which on v4l2_ext_controls, used to get the
default value of one or more controls.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/v4l2-core/v4l2-ctrls.c | 35 ++-
1 file changed, 30 insertions(+), 5
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
drivers/media/usb/uvc/uvc_v4l2.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion
Hello Hans, Sakari and Laurent:
I am back from holidays :). Shall I prepare a new patchset with the
suggestion from Hans?
Thanks!
On Mon, Jul 20, 2015 at 4:31 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On 07/20/2015 03:52 PM, Ricardo Ribalda Delgado wrote:
Hello
I have no preference over
Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not
use the controller framework.
Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
---
Changelog
v4: Comments by Laurent Pinchart laurent.pinch...@ideasonboard.com
Remove unneeded uvc_ctrl_begin()
drivers
Hello Laurent
On Thu, Jul 16, 2015 at 10:27 AM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
I'd argue that even just two drivers would be enough :-) Especially given that
the proposed implementation for uvcvideo is wrong.
This is why we have the review process :P. I do my best,
Hi Sakari
Thanks for your review!
On Fri, Jul 17, 2015 at 9:13 AM, Sakari Ailus sakari.ai...@iki.fi wrote:
#define VIDIOC_QUERY_EXT_CTRL_IOWR('V', 103, struct
v4l2_query_ext_ctrl)
+#define VIDIOC_G_DEF_EXT_CTRLS _IOWR('V', 104, struct
v4l2_ext_controls)
I assume that if
Hello
I have no preference over the two implementations, but I see an issue
with this suggestion.
What happens to out out tree drivers, or drivers that don't support
this functionality?
With the ioctl, the user receives a -ENOTTY. So he knows there is
something wrong with the driver.
With
of New ioct VIDIOC_G_DEF_EXT_CTRLS):
Suggested by Hans Verkuil <hverk...@xs4all.nl>:
Replace ioctl implementation with a new union on the struct v4l2_ext_controls
THANKS!
Ricardo Ribalda Delgado (6):
videodev2.h: Extend struct v4l2_ext_controls
media/core: Replace ctrl_class with which
So it can be used to get the default value of a control.
Without this change it is not possible to get get the
default value of array controls.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
---
include/uapi/linux/videodev2.h | 7 ++-
1 file changed, 6 insertions
y: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
---
.../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 6 +++---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +-
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 2 +-
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 6
Support for new field which on v4l2_ext_controls, used to get the
default value of one or more controls.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
---
drivers/media/v4l2-core/v4l2-ctrls.c | 34 +-
1 file changed, 29 insertions
This driver does not use the control infrastructure.
Add support for the new field which on structure
v4l2_ext_controls
Signed-off-by: Ricardo Ribalda Delgado <ricardo.riba...@gmail.com>
---
drivers/media/usb/uvc/uvc_v4l2.c | 20
1 file changed, 20 insertions(+)
diff
201 - 300 of 415 matches
Mail list logo