Re: [PATCH 1/5] CSI camera interface driver for MX1

On Fri, Mar 27, 2009 at 08:33:27AM +0100, Holger Schurig wrote: Sparse is another tool which can be used while building the kernel to increase the build time checking, but it can be quite noisy, so please only look at stuff which pops up for your specific area. To get rid of some of the

Re: [PATCH 1/5] CSI camera interface driver for MX1

On Fri, Mar 27, 2009 at 05:18:18PM +0200, Darius Augulis wrote: You use an FIQ for SoF, and spin_lock_irqsave() to protect. Don't they only disable IRQs and not FIQs? But it seems your FIQ cannot cause any trouble, so, it should be fine. Do you really need an FIQ? This is precisely the

Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

On Wed, Feb 18, 2009 at 07:09:55AM -0800, Agustin wrote: Guennadi, Guennadi Liakhovetski wrote: diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c index 1f154d0..91e6e4e 100644 --- a/drivers/dma/ipu/ipu_idmac.c +++ b/drivers/dma/ipu/ipu_idmac.c @@ -28,6 +28,9 @@

<    1   2   3   4   5