From: Markus Elfring
Date: Sat, 16 Sep 2017 10:15:29 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/radio/radio-maxiradio.c | 4 +---
1 file changed, 1 inse
From: Markus Elfring
Date: Sat, 16 Sep 2017 12:35:43 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete two error messages for a failed memory allocation
Improve a size determination
Delete an unnecessary variable initialisat
From: Markus Elfring
Date: Sat, 16 Sep 2017 11:23:53 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/radio/radio-mr800.c | 2 --
1 file changed, 2 deletions(-)
From: Markus Elfring
Date: Sat, 16 Sep 2017 11:34:11 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was det
From: Markus Elfring
Date: Sat, 16 Sep 2017 11:39:50 +0200
The variable "retval" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/media/radio/radio-mr800.c | 2 +-
1 file changed, 1 ins
From: Markus Elfring
Date: Sat, 16 Sep 2017 14:05:45 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
Delete an unnecessary goto statement
Delete an unnecessary variable initi
From: Markus Elfring
Date: Sat, 16 Sep 2017 13:28:38 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/radio/radio-wl1273.c | 1 -
1 file changed, 1 deletion(-
From: Markus Elfring
Date: Sat, 16 Sep 2017 13:53:22 +0200
* Remove an extra goto statement.
* Delete the label "out" which became unnecessary with this refactoring.
Signed-off-by: Markus Elfring
---
drivers/media/radio/radio-wl1273.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
From: Markus Elfring
Date: Sat, 16 Sep 2017 13:55:56 +0200
The local variable "r" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/media/radio/radio-wl1273.c | 2 +-
1 file changed, 1 insertion(+)
From: Markus Elfring
Date: Sat, 16 Sep 2017 15:16:17 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
Improve a size determination
Delete an unnecessary variable initialisatio
From: Markus Elfring
Date: Sat, 16 Sep 2017 14:53:49 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/radio/si470x/radio-si470x-usb.c | 1 -
1 file changed, 1
From: Markus Elfring
Date: Sat, 16 Sep 2017 14:58:06 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was det
From: Markus Elfring
Date: Sat, 16 Sep 2017 15:08:39 +0200
The variable "retval" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/media/radio/si470x/radio-si470x-usb.c | 2 +-
1 file ch
From: Markus Elfring
Date: Sat, 16 Sep 2017 16:15:44 +0200
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/radio/si4713/radio-platform-si4713.c | 1 -
drivers/me
From: Markus Elfring
Date: Sat, 16 Sep 2017 18:03:21 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/media/tuners/fc0012.c | 3 +--
1 file
From: Markus Elfring
Date: Sat, 16 Sep 2017 17:47:52 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/tuners/fc0012.c | 1 -
1 file changed, 1 deletion(-)
di
From: Markus Elfring
Date: Sat, 16 Sep 2017 17:55:27 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was det
From: Markus Elfring
Date: Sat, 16 Sep 2017 20:12:34 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation
Improve three size determinations
drivers/media/tuners/it913x.c | 3 +--
From: Markus Elfring
Date: Sat, 16 Sep 2017 19:40:47 +0200
* Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
* Delete the label "err" and the variable "ret" which became unnecessary
with this refactoring.
Signe
From: Markus Elfring
Date: Sat, 16 Sep 2017 20:06:01 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Sat, 16 Sep 2017 21:48:45 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve three size determinations
drivers/media/tuners/m88rs6000t.c | 13 ++
From: Markus Elfring
Date: Sat, 16 Sep 2017 21:24:27 +0200
* Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
* Add a jump target so that the function "kfree" will be always called
with a non-null pointer.
Sig
From: Markus Elfring
Date: Sat, 16 Sep 2017 21:38:03 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Sun, 17 Sep 2017 08:48:24 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination in two functions
drivers/media/tuners/si2157.c
From: Markus Elfring
Date: Sun, 17 Sep 2017 08:20:04 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/tuners/si2157.c | 1 -
1 file changed, 1 deletion(-)
di
From: Markus Elfring
Date: Sun, 17 Sep 2017 08:32:17 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Sun, 17 Sep 2017 10:03:45 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve three size determinations
drivers/media/tuners/tda18212.c | 13
From: Markus Elfring
Date: Sun, 17 Sep 2017 09:33:58 +0200
* Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
* Add a jump target so that the function "kfree" will be always called
with a non-null pointer.
Sig
From: Markus Elfring
Date: Sun, 17 Sep 2017 09:42:17 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:11:02 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/media/usb/airspy/airspy.c | 6 ++
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:00:09 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/airspy/airspy.c | 4 +---
1 file changed, 1 insertio
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:03:21 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was det
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:40:31 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/au0828/au0828-core.c | 4 +---
1 file changed, 1 ins
From: Markus Elfring
Date: Sun, 17 Sep 2017 15:25:35 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Use common error handling code in cpia2_usb_probe()
Adjust two function calls together with a variable assignment
Delete unneces
From: Markus Elfring
Date: Sun, 17 Sep 2017 12:40:14 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cpia2/cpia2_usb.c | 1
From: Markus Elfring
Date: Sun, 17 Sep 2017 12:56:50 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cpia2/cpia2_usb.c | 7 +
From: Markus Elfring
Date: Sun, 17 Sep 2017 13:23:47 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: kfree(NULL) is safe and this check is probably not required
Thus fix the affected source code place.
Signed-off-by: Markus Elfring
---
drivers/media/usb/
From: Markus Elfring
Date: Sun, 17 Sep 2017 13:32:45 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
Signed-off-by: Markus Elfring
---
drivers
From: Markus Elfring
Date: Sun, 17 Sep 2017 21:30:12 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (8):
Delete eight error messages for a failed memory allocation
Adjust 56 checks for null pointers
Improve six size determinations
D
From: Markus Elfring
Date: Sun, 17 Sep 2017 17:43:47 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cx231xx/cx231xx-core.c | 14 ++
drivers/
From: Markus Elfring
Date: Sun, 17 Sep 2017 18:23:06 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code pla
From: Markus Elfring
Date: Sun, 17 Sep 2017 18:38:50 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Sun, 17 Sep 2017 18:53:16 +0200
The variable "result" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cx231xx/cx231xx-dvb.c | 2 +-
1 file changed,
From: Markus Elfring
Date: Sun, 17 Sep 2017 20:10:34 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cx231xx/cx231xx-dvb.c | 135 +---
1 file changed, 53
From: Markus Elfring
Date: Sun, 17 Sep 2017 20:28:00 +0200
The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cx231xx/cx231xx-cards.c | 2 +-
1 file changed, 1 ins
From: Markus Elfring
Date: Sun, 17 Sep 2017 20:22:15 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cx231xx/cx231xx-card
From: Markus Elfring
Date: Sun, 17 Sep 2017 21:07:39 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring
---
drivers/media/usb/cx231xx/cx231xx-417.c | 61 -
1 file changed, 29
From: Markus Elfring
Date: Mon, 18 Sep 2017 09:51:23 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation in dvb_usbv2_probe()
Improve a size determination in two functions
driver
From: Markus Elfring
Date: Mon, 18 Sep 2017 09:25:19 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | 3 ---
1 file changed, 3 d
From: Markus Elfring
Date: Mon, 18 Sep 2017 09:36:33 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Mon, 18 Sep 2017 14:54:32 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (6):
Delete an error message for a failed memory allocation in
go7007_load_encoder()
Adjust 35 checks for null pointers
Improve a siz
From: Markus Elfring
Date: Mon, 18 Sep 2017 10:52:42 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/go7007/go7007-driver.c | 1 -
1 file changed, 1 dele
From: Markus Elfring
Date: Mon, 18 Sep 2017 11:13:27 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code pla
From: Markus Elfring
Date: Mon, 18 Sep 2017 11:27:30 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detec
From: Markus Elfring
Date: Mon, 18 Sep 2017 13:50:45 +0200
Adjust jump targets so that a bit of exception handling can be better
reused at the end of this function.
This refactoring might fix also an error situation where the
function "i2c_unregister_device" was not called after a software failu
From: Markus Elfring
Date: Mon, 18 Sep 2017 14:28:59 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/go7007/snd-go7007.c |
From: Markus Elfring
Date: Mon, 18 Sep 2017 14:35:43 +0200
The variable "ret" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/media/usb/go7007/snd-go7007.c | 2 +-
1 file changed, 1 in
From: Markus Elfring
Date: Mon, 18 Sep 2017 17:47:58 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/gspca.c | 6 ++
1 file changed, 2 insertions
From: Markus Elfring
Date: Mon, 18 Sep 2017 18:40:05 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/gspca.c | 17 +
From: Markus Elfring
Date: Mon, 18 Sep 2017 19:24:24 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/jl2005bcd.c | 4 +---
1 file changed, 1 insert
From: Markus Elfring
Date: Mon, 18 Sep 2017 21:30:58 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/sq905.c | 4 +---
1 file changed, 1 insertion(
From: Markus Elfring
Date: Mon, 18 Sep 2017 22:05:22 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Return directly after a failed kmalloc()
drivers/media/usb/gspca/vicam.c |
From: Markus Elfring
Date: Mon, 18 Sep 2017 21:48:55 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/vicam.c | 4 +---
1 file changed, 1 insertion(
From: Markus Elfring
Date: Mon, 18 Sep 2017 21:56:55 +0200
* Return directly after a call of the function "kmalloc" failed
at the beginning.
* Delete the jump target "exit" which became unnecessary
with this refactoring.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/vicam.c |
From: Markus Elfring
Date: Tue, 19 Sep 2017 20:21:23 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete three error messages for a failed memory allocation
Improve a size determination in hdpvr_alloc_buffers()
Return an error
From: Markus Elfring
Date: Tue, 19 Sep 2017 09:33:26 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/hdpvr/hdpvr-core.c | 8 ++--
drivers/media/usb/
From: Markus Elfring
Date: Tue, 19 Sep 2017 19:27:53 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was det
From: Markus Elfring
Date: Tue, 19 Sep 2017 19:32:36 +0200
* Return an error code without storing it in an intermediate variable.
* Delete the local variable "retval" which became unnecessary
with this refactoring.
Signed-off-by: Markus Elfring
---
drivers/media/usb/hdpvr/hdpvr-video.c | 3
From: Markus Elfring
Date: Wed, 20 Sep 2017 08:28:48 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Use common error handling code in pvr2_ioread_get_buffer()
Delete an unnecessary check before kfree() in two functions
Delete un
From: Markus Elfring
Date: Tue, 19 Sep 2017 21:50:05 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/pvrusb2/pvrusb2-iore
From: Markus Elfring
Date: Tue, 19 Sep 2017 22:12:49 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: kfree(NULL) is safe and this check is probably not required
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
drivers/media/usb
From: Markus Elfring
Date: Wed, 20 Sep 2017 08:15:51 +0200
Do not use curly brackets at some source code places
where a single statement should be sufficient.
Signed-off-by: Markus Elfring
---
drivers/media/usb/pvrusb2/pvrusb2-ioread.c | 38 --
1 file changed, 15 in
>> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client,
>> /* initialize the audio */
>> if (write_regs(audio, aud_regs) < 0) {
>> dev_err(&client->dev, "error initializing audio\n");
>> -goto fail;
>> +goto e_io;
>
> Preserve the e
From: Markus Elfring
Date: Wed, 20 Sep 2017 14:30:55 +0200
Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
This refactoring might fix also an error situation where the
function "kfree" was not called after a software failure
was noticed in
From: Markus Elfring
Date: Wed, 20 Sep 2017 18:18:28 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Delete three error messages for a failed memory allocation in s2255_probe()
Adjust 13 checks for null pointers
Improve two size
From: Markus Elfring
Date: Wed, 20 Sep 2017 16:30:13 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/s2255/s2255drv.c | 13 -
1 file changed, 4
From: Markus Elfring
Date: Wed, 20 Sep 2017 16:46:19 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code pl
From: Markus Elfring
Date: Wed, 20 Sep 2017 16:56:20 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Wed, 20 Sep 2017 17:45:13 +0200
Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
Signed-off-by: Markus Elfring
---
drivers/media/usb/s2255/s2255drv.c | 17 +
1 file changed, 9 insertions(+), 8 del
From: Markus Elfring
Date: Wed, 20 Sep 2017 17:50:36 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected functions.
Signed-off-by: Markus Elfring
---
driver
> If smscore_register_device() succeeds then mdev is freed when we call
> smsusb_term_device(intf); The call tree is:
Thanks for your constructive information.
How do you think about another implementation detail in this function then?
May the statement “kfree(mdev);” be executed before “smsus
From: Markus Elfring
Date: Wed, 20 Sep 2017 21:03:45 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Use common error handling code in ttusb_probe()
Improve two size determinations in ttusb_probe()
Adjust eight checks for null po
From: Markus Elfring
Date: Wed, 20 Sep 2017 20:25:24 +0200
Add two jump targets so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-budget/dvb-
From: Markus Elfring
Date: Wed, 20 Sep 2017 20:46:11 +0200
* The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix an affected source code place.
* Replace the specification of data structures by variable references
a
From: Markus Elfring
Date: Wed, 20 Sep 2017 20:53:13 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code pla
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>
> You've been told several times that this stuff doesn't work.
This functionality might not exactly work in the way that you expect so far.
> Try applying this patch with `git am` and you'll
>> Would you like to clarify corresponding concerns any more?
>>
>
> Look at the `git log`
I did this also for a moment.
> and it just copies those lines:
The Git software preserves these three message fields
(when special characters were used in the commit message).
Can you accept such softw
From: Markus Elfring
Date: Thu, 21 Sep 2017 17:00:17 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Use common error handling code in usbvision_set_input()
Use common error handling code in usbvision_set_compress_params()
Delete
From: Markus Elfring
Date: Thu, 21 Sep 2017 11:50:54 +0200
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
* Replace the local variable "proc" by the identifier "__func__".
*
From: Markus Elfring
Date: Thu, 21 Sep 2017 12:45:49 +0200
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
* Replace the local variable "proc" by the identifier "__func__".
* Use the interface "dev_err" instead of "printk".
Signed-off
From: Markus Elfring
Date: Thu, 21 Sep 2017 16:24:20 +0200
Do not use curly brackets at some source code places
where a single statement should be sufficient.
Signed-off-by: Markus Elfring
---
drivers/media/usb/usbvision/usbvision-core.c | 71
1 file changed, 31 in
From: Markus Elfring
Date: Thu, 21 Sep 2017 16:47:28 +0200
* Replace the local variable "proc" by the identifier "__func__".
* Use the interface "dev_err" instead of "printk" in these functions.
Signed-off-by: Markus Elfring
---
drivers/media/usb/usbvision/usbvision-core.c | 18 +++---
From: Markus Elfring
Date: Thu, 21 Sep 2017 21:20:12 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Use common error handling code in uvc_ioctl_g_ext_ctrls()
Adjust 14 checks for null pointers
Add some spaces for better code rea
From: Markus Elfring
Date: Thu, 21 Sep 2017 20:47:02 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/uvc/uvc_v4l2.c | 13
From: Markus Elfring
Date: Thu, 21 Sep 2017 21:00:21 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code pla
From: Markus Elfring
Date: Thu, 21 Sep 2017 21:12:29 +0200
Use space characters at some source code places according to
the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/media/usb/uvc/uvc_v4l2.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
dif
>> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct
>> usb_usbvision *usbvision)
>> USB_DIR_OUT | USB_TYPE_VENDOR |
>> USB_RECIP_ENDPOINT, 0,
>> (__u16) USBVISION_PCM_THR1, value, 6, HZ);
>> +i
> No. Multi-line indents get curly braces for readability.
Which of the proposed change possibilities do you not like especially at the
moment?
Regards,
Markus
From: Markus Elfring
Date: Fri, 22 Sep 2017 17:45:33 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/sn9c20x.c | 17
From: Markus Elfring
Date: Fri, 22 Sep 2017 18:45:07 +0200
Adjust a jump target so that a bit of exception handling can be better
reused at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/gspca/spca500.c |
201 - 300 of 517 matches
Mail list logo
