driver unbind
>
> Heiner Kallweit (12):
> media: rc: make fifo size for raw events configurable via rc_dev
> media: rc: nuvoton: decrease size of raw event fifo
I might be wrong but I think these last two changes are broken, see my last
message to the list on this.
Sean
--
To
rflow in the kfifo and unable to decode it?
Sean
> ---
> drivers/media/rc/nuvoton-cir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/rc/nuvoton-cir.c b/drivers/media/rc/nuvoton-cir.c
> index 99b303b..e98c955 100644
> --- a/drivers/media/rc/nuvoton-cir.c
lirc_unregister_driver(minor);
}
return err ? err : minor;
}
Sean
>
> Signed-off-by: Andi Shyti <andi.sh...@samsung.com>
> ---
> drivers/media/rc/lirc_dev.c | 44 ++--
> include/media/lirc_dev.h| 12 +
On Fri, Jul 01, 2016 at 09:30:35PM +0900, Andi Shyti wrote:
> Hi Sean,
>
> > > The ir-spi is a simple device driver which supports the
> > > connection between an IR LED and the MOSI line of an SPI device.
> > >
> > > The driver, indeed, use
rface is not compatible with other lirc devices; there is no
way of determining whether this is a regular lirc device or this new
flavour you've invented.
Also I don't see what justifies this new interface. This can be
implemented in rc-core in less lines of code and it will be entirely
compatible with e
ia/v4l/lirc_device_interface.xml and there
should be at least one driver using it.
If you want to write a new driver which does IR transmit, it's best
to use the rc-core interface like the existing drivers and do
not use the lirc interface. Most of the other drivers which implement
IR transmit use rc-core too.
On Wed, Jun 29, 2016 at 10:20:44PM +0900, Andi Shyti wrote:
> The Lirc framework works mainly with receivers, but there is
> nothing that prevents us from using it for transmitters as well.
The lirc interface already provides for transmitting IR.
> For that we need to have more control on the
On Mon, Apr 25, 2016 at 09:16:51PM -0600, Wade Berrier wrote:
> On Apr 25 18:15, Sean Young wrote:
> > On Sun, Apr 24, 2016 at 10:06:33PM -0600, Wade Berrier wrote:
> > > Hello,
> > >
> > > I have a mceusb compatible transceiver that only seems to work with
&
to 32
That's odd. Can you post a "lsusb -vvv" of the device please?
Thanks,
Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Sean Young <s...@mess.org>
---
drivers/media/rc/mceusb.c | 21 +
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index 35155ae..85823e8 100644
--- a/drivers/media/rc/mceusb.c
+++ b/drivers
This function just submits the urb much like mceusb_dev_resume; removing
it simplifies mce_request_packet.
Also add missing usb_kill_urb to mce_dev_probe.
Signed-off-by: Sean Young <s...@mess.org>
---
drivers/media/rc/mceusb.c | 77 +++
1 file c
On Wed, Apr 13, 2016 at 02:07:49PM +0800, kbuild test robot wrote:
> Hi Sean,
>
> [auto build test ERROR on linuxtv-media/master]
> [also build test ERROR on v4.6-rc3 next-20160412]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving th
These can be done with regular c99 constructs, which makes the
code cleaner and more transparent.
Signed-off-by: Sean Young <s...@mess.org>
---
drivers/hid/hid-picolcd_cir.c | 3 +--
drivers/media/common/siano/smsir.c | 2 +-
drivers/media/i2c/cx25840/cx25840-ir.c
.timeout = 0, \
> - .carrier_report = 0 }
> +#define DEFINE_IR_RAW_EVENT(event) struct ir_raw_event event = {}
Seems fine. I've always kinda wondered why this macro is needed.
Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 17, 2016 at 07:40:59AM +0100, Heiner Kallweit wrote:
> Am 16.03.2016 um 23:28 schrieb Sean Young:
> > On Wed, Mar 16, 2016 at 10:18:38PM +0100, Heiner Kallweit wrote:
> >> + u8 pulse:1;
> >> + u8 reset:1;
> >> + u
init_timer(_dev->flush_timer);
> + gpio_dev->flush_timer.function = flush_timer;
> + gpio_dev->flush_timer.data = (unsigned long)gpio_dev;
You could use "setup_timer(_dev->flush_timer, flush_timer, (unsigned
long)gpio_dev);" here.
> +
> rc =
ut can be overridden through the use of the LIRC_SET_REC_TIMEOUT
> ioctl.
>
> Signed-off-by: Eric Nelson <e...@nelint.com>
Acked-by: Sean Young <s...@mess.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of
On Mon, Sep 14, 2015 at 07:34:10AM -0700, Eric Nelson wrote:
> Thanks Shawn,
>
> On 09/14/2015 03:00 AM, Sean Young wrote:
> > On Fri, Sep 11, 2015 at 07:00:24AM -0700, Eric Nelson wrote:
> >> Many decoders require a trailing space (period without IR illumination)
>
On Mon, Sep 14, 2015 at 08:05:24AM -0700, Eric Nelson wrote:
> Thanks again Sean,
>
> On 09/14/2015 07:54 AM, Sean Young wrote:
> > On Mon, Sep 14, 2015 at 07:34:10AM -0700, Eric Nelson wrote:
> >> Thanks Shawn,
> >>
> >> On 09/14/2015 03:00 AM, Sean You
.
A common value for this is 100ms, I'm not sure what use it has to have
it configurable. It's nice to have it exposed in rc_dev->timeout.
Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
simply be removed? None of the other drivers
do these checks.
Sean
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index c83292ad1b34..ec74244a3853 100644
--- a/drivers/media/rc/redrat3.c
+++ b/drivers
On Fri, Jun 05, 2015 at 03:55:38PM +0100, Sean Young wrote:
On Fri, Jun 05, 2015 at 11:27:41AM -0300, Mauro Carvalho Chehab wrote:
Don't assume that IR_MAX_DURATION is a bitmask. It isn't.
The patch is right, but note that IR_MAX_DURATION is 0x, and in
all these cases it is being
.
+}
+EXPORT_SYMBOL_GPL(cec_delete_adapter);
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
control the PVR software while the TV
remote controls your Kodi frontend). An idea I borrowed from Jon Smirl
(who posted a similar proof-of-concept based on debugfs back in the
days).
That would be very nice thing to have, but that is a separate from this.
Sean
--
To unsubscribe from this list: send
On Mon, Mar 30, 2015 at 11:18:19PM +0200, David Härdeman wrote:
On Thu, Mar 19, 2015 at 09:50:11PM +, Sean Young wrote:
This patch series tries to fix the lirc interface and extend it so it can
be used to send/recv scancodes in addition to raw IR:
- Make it possible to receive scancodes
to avoid
circular dependencies.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/Kconfig | 15 +++--
drivers/media/rc/Makefile| 6 +-
drivers/media/rc/ir-lirc-codec.c | 117 ---
drivers/media/rc/lirc_dev.c | 18 +-
drivers/media
The send mode has to be switched to LIRC_MODE_SCANCODE and then you can
send one scancode with a write. The encoding is the same as for receiving
scancodes.
FIXME: Currently only the nec encoder can encode IR.
FIXME: The decoders should be renamed (codec?)
Signed-off-by: Sean Young s...@mess.org
If the device cannot transmit then -ENOSYS should be returned. Also clarify
that the ioctl should return modes, not features. The values happen to be
identical.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/ir-lirc-codec.c | 11 +--
1 file changed, 9 insertions(+), 2
bound of a duty cycle. No
hardware has implemented this; why would you.
Since there never was, or will be, an implementation of these, this is not
an ABI change.
Signed-off-by: Sean Young s...@mess.org
---
.../DocBook/media/v4l/lirc_device_interface.xml| 16
include/media
LIRC_MODE_SCANCODE will
be enabled (else the lirc device will never produce anything).
Signed-off-by: Sean Young s...@mess.org
---
.../DocBook/media/v4l/lirc_device_interface.xml| 31 +---
drivers/media/rc/Kconfig | 4 +--
drivers/media/rc/ir-lirc-codec.c
Since the lirc bridge is not a decoder we can remove its protocol. The
keymap existed only to select the protocol.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/keymaps/Makefile | 1 -
drivers/media/rc/keymaps/rc-lirc.c | 42 --
drivers/media
Provide simple tools for displaying raw IR and received scancodes, and
sending them.
Todo:
- ir-rec cannot enable protocol decoders
- ir-send should accept scancode on commandline
- long options
Signed-off-by: Sean Young s...@mess.org
---
configure.ac | 3 +
utils/Makefile.am
function, but it is static in
rc-main.c, so it
cannot be used in other kernel modules. Any hints, Sean?
Why is it problematic if keypresses are passed to the input layer?
You can only set the default keymap for an rc-device from kernel space; from
user space you can clear the table using input
);
+ p-ir = NULL;
+ kfree(ir);
+ return -ENOMEM;
+
+}
Thanks
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
= p;
+ dev-open = prospero_ir_open;
+ dev-close = prospero_ir_close;
+ dev-driver_type = RC_DRIVER_IR_RAW;
+ dev-timeout = 10 * 1000 * 1000;
There is a MS_TO_NS() macro for this.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
);
+
+ if (!cec_devnode_is_registered(cecdev))
+ return -EIO;
+ return 0;
+}
Both read and write do nothing; they should either -ENOSYS or the fuctions
should be removed.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
rc_keydown_notimeout() can be called for each key press.
I guess a new keymap should exist too.
HTH
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This fixes the driver on arm.
Reported-by: Steven Guitton kelt...@gmail.com
Tested-by: Steven Guitton kelt...@gmail.com
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/redrat3.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/rc/redrat3.c b
On Mon, Nov 17, 2014 at 12:59:09PM -0200, Mauro Carvalho Chehab wrote:
Em Sun, 9 Nov 2014 21:35:17 +
Sean Young s...@mess.org escreveu:
On Thu, Nov 06, 2014 at 08:56:47AM -0500, Andy Walls wrote:
On November 6, 2014 8:54:28 AM EST, Andy Walls awalls.c...@gmail.com
wrote:
Sean
On Sun, Nov 09, 2014 at 09:32:07AM +0100, Beniamino Galvani wrote:
Amlogic Meson SoCs include a infrared remote control receiver that can
operate in two modes: NEC mode in which the hardware decodes frames
using the NEC IR protocol, and general mode in which the receiver
simply reports the
On Thu, Nov 06, 2014 at 08:56:47AM -0500, Andy Walls wrote:
On November 6, 2014 8:54:28 AM EST, Andy Walls awalls.c...@gmail.com wrote:
Sean,
Ir-kbd-i2c was never intended for Tx.
You can transmit *short* arbitrary pulse-space streams with the zilog
chip, by feeding it a parameter block
zilog z8 opcodes nor space/pulse information.
Does anyone have any contacts at Hauppauge who could help with this?
Thanks,
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Thu, Nov 06, 2014 at 11:05:49AM -0200, Mauro Carvalho Chehab wrote:
Hi Sean,
Em Thu, 06 Nov 2014 12:46:29 +
Sean Young s...@mess.org escreveu:
On Fri, Oct 31, 2014 at 05:35:41PM +0300, Dan Carpenter wrote:
On Fri, Oct 31, 2014 at 04:26:45PM +0200, Aya Mahfouz wrote:
On Fri
On Mon, Nov 03, 2014 at 02:49:45PM -0200, Mauro Carvalho Chehab wrote:
Em Mon, 20 Jan 2014 12:36:26 -0500
Jarod Wilson ja...@redhat.com escreveu:
On Sun, Jan 19, 2014 at 09:56:48PM +, Sean Young wrote:
On Sun, Jan 19, 2014 at 10:05:15PM +0100, Martin Kittel wrote:
Hi Mauro, hi
This is a complete re-write inspired by the original lirc driver.
Signed-off-by: Sean Young s...@mess.org
---
MAINTAINERS|6 +
drivers/media/rc/Kconfig | 15 +++
drivers/media/rc/Makefile |1 +
drivers/media/rc/igorplugusb.c | 261
This driver has been replaced by an rc-core driver for the same hardware.
Signed-off-by: Sean Young s...@mess.org
---
drivers/staging/media/lirc/Kconfig|6 -
drivers/staging/media/lirc/Makefile |1 -
drivers/staging/media/lirc/lirc_igorplugusb.c | 508
On Tue, Sep 09, 2014 at 02:10:43AM +0400, Alexey Khoroshilov wrote:
mceusb_init_rc_dev() does usb_get_dev(), but there is no any
usb_put_dev() in the driver.
drivers/media/rc/imon.c suffers from the same problem.
Thanks
Sean
--
To unsubscribe from this list: send the line unsubscribe linux
On Thu, Aug 28, 2014 at 11:16:16PM +0800, Zhangfei Gao wrote:
From: Guoxiong Yan yanguoxi...@huawei.com
IR transmitter driver for Hisilicon hix5hd2 soc
By default all protocols are disabled.
For example nec decoder can be enabled by either
1. ir-keytable -p nec
2. echo nec
On Wed, Aug 27, 2014 at 04:49:59PM +0800, zhangfei wrote:
On 08/21/2014 06:07 PM, Sean Young wrote:
On Thu, Aug 21, 2014 at 05:24:44PM +0800, Zhangfei Gao wrote:
It would be useful is rdev-input_phys, rdev-input_id,
rdev-timeout, rdev-rx_resolution are set correctly.
OK, will set rdev
On Wed, Aug 27, 2014 at 06:10:28PM +0800, zhangfei wrote:
On 08/27/2014 05:51 PM, Sean Young wrote:
On Wed, Aug 27, 2014 at 04:49:59PM +0800, zhangfei wrote:
On 08/21/2014 06:07 PM, Sean Young wrote:
IR. There is be no reason to run lircd if you use this method.
Do you mean kernel decoder
On Thu, Aug 21, 2014 at 05:24:44PM +0800, Zhangfei Gao wrote:
From: Guoxiong Yan yanguoxi...@huawei.com
IR transmitter driver for Hisilicon hix5hd2 soc
Signed-off-by: Guoxiong Yan yanguoxi...@huawei.com
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
---
drivers/media/rc/Kconfig
-urb_in-transfer_flags |= URB_NO_TRANSFER_DMA_MAP;
I've tested this patch and it does fix my mceusb device with bulk
endpoints on xhci. So
Tested-by: Sean Young s...@mess.org
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
to a state where it just works for me without
modifications, I just need to know which changes I can get away
without breaking it for everybody else =)
As things are right now the RC input feel very sluggish and
unresponsive using a RC-6 6A remote and a ite-cir receiver.
Sean
--
To unsubscribe
);
if (err)
--
1.8.3.2
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 22, 2014 at 05:46:28PM +0200, Antti Seppälä wrote:
On 21 January 2014 14:28, Sean Young s...@mess.org wrote:
On Mon, Jan 20, 2014 at 09:39:43PM +0200, Antti Seppälä wrote:
This patch series introduces a simple sysfs file interface for reading
and writing wakeup scancodes to rc
On Wed, Jan 22, 2014 at 09:10:58PM +0200, Antti Seppälä wrote:
On 22 January 2014 18:29, Sean Young s...@mess.org wrote:
On Wed, Jan 22, 2014 at 05:46:28PM +0200, Antti Seppälä wrote:
On 21 January 2014 14:28, Sean Young s...@mess.org wrote:
On Mon, Jan 20, 2014 at 09:39:43PM +0200, Antti
protocol, maybe it should be exported (readonly) via
sysfs?
I'm happy to help with a winbond-cir implementation; I have the hardware.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Wed, Jan 15, 2014 at 09:55:59PM -0500, Jarod Wilson wrote:
On Wed, Jan 15, 2014 at 04:52:45PM +, Sean Young wrote:
On Wed, Jan 15, 2014 at 01:49:17PM -0200, Mauro Carvalho Chehab wrote:
Hi Martin,
Em Wed, 11 Dec 2013 21:34:55 +0100
Martin Kittel li...@martin-kittel.de
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/iguanair.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index fdae05c..99a3a5a 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/iguanair.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index 99a3a5a..a83519a 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers/media
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/mceusb.c | 92 +++
1 file changed, 28 insertions(+), 64 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index a25bb15..3a4f95f 100644
--- a/drivers/media/rc
A number of recent bug reports involve usb_submit_urb() failing which was
only reported with debug parameter on. In addition, remove custom debug
function.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/mceusb.c | 180 ++
1 file changed
the repeat and keyup logic isn't used unless there is
a keypress, which results in non-keypress keydown events turning on the
LED and not turning it off again.
Yes, this is a bug. I have a similar patch waiting to be submitted but
you beat me to it.
Acked-by: Sean Young s...@mess.org
On Wed, Jan 15, 2014 at 01:49:17PM -0200, Mauro Carvalho Chehab wrote:
Hi Martin,
Em Wed, 11 Dec 2013 21:34:55 +0100
Martin Kittel li...@martin-kittel.de escreveu:
Hi Mauro, hi Sean,
thanks for considering the patch. I have added an updated version at the
end of this mail
is this? Could you provide lsusb -vvv output please?
Also what usb hub are you using? Another user is reporting problems with an
xhci hub.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
set CONFIG_USB_DEBUG and see if you get more information?
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 05, 2013 at 10:05:45PM +0530, Rajil Saraswat wrote:
On 5 December 2013 18:54, Sean Young s...@mess.org wrote:
I really don't know why that would happen. If I understand it correctly
this is an error that is returned by the usb host controller driver.
Could you set
to add a default line
at the switch to shut it up.
Mauro, I have a different way of solving this which also cleans up the code
a little. I'll send a patch shortly.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/iguanair.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index 19632b1..7f05e19 100644
--- a/drivers/media/rc/iguanair.c
+++ b
On Mon, Oct 14, 2013 at 11:07:48AM -0300, Mauro Carvalho Chehab wrote:
Em Mon, 14 Oct 2013 15:16:20 +0200
Tom Gundersen t...@jklm.no escreveu:
Not sure about lirc_wpc8769l. David/Sean/Juan can have a better view.
I've just had a cursory look at lirc_wpc8769l. The device does look similar
On Thu, Aug 29, 2013 at 12:29:00PM +0100, Srinivas KANDAGATLA wrote:
On 29/08/13 10:11, Sean Young wrote:
On Wed, Aug 28, 2013 at 04:33:50PM +0100, Srinivas KANDAGATLA wrote:
From: Srinivas Kandagatla srinivas.kandaga...@st.com
+config RC_ST
+ tristate ST remote control receiver
On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote:
From: Srinivas Kandagatla srinivas.kandaga...@st.com
This patch adds support to ST RC driver, which is basically a IR/UHF
receiver and transmitter. This IP is common across all the ST parts for
settop box platforms. IRB is
On Fri, Aug 16, 2013 at 11:53:48AM +0100, Srinivas KANDAGATLA wrote:
Thanks Sean for the comments.
On 16/08/13 09:38, Sean Young wrote:
On Wed, Aug 14, 2013 at 06:27:01PM +0100, Srinivas KANDAGATLA wrote:
[...]
+ /* discard the entire collection in case of errors
logged into the X
session.
Thanks. Only the IR transmit urb submits results in error ENOSPC.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
same device and it works fine with 3.10.4 vanilla,
whether X is running out or not. Please can you send the output of
usbmon while issuing irsend (just the interface with the mce device).
Thanks
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
on its own bus (i.e root hub which does
not share bus with another device, see lsusb output).
If that does not work, could you capture the usbmon output while starting
X and then irsend, to see if your X config somehow affects it.
Sean
--
To unsubscribe from this list: send the line unsubscribe
Many devices with an ir receiver also have a feedback led. Add the
led trigger to support this.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/rc-main.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 1cf382a
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/ttusbir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c
index 891762d..d8de205 100644
--- a/drivers/media/rc/ttusbir.c
+++ b/drivers/media/rc/ttusbir.c
@@ -302,6 +302,7
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/Kconfig | 2 ++
drivers/media/rc/redrat3.c | 83 --
2 files changed, 82 insertions(+), 3 deletions(-)
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index 7fa6b22
Note that with the rc-feedback trigger, the cir-rx trigger is now
redundant. The cir-tx trigger is not used by default; if this
functionality is desired then it should exist in rc-core, not in
a driver.
Also make sure that the led is suspended on suspend.
Signed-off-by: Sean Young s...@mess.org
The length in the header excludes the header itself, so we're getting
spurious readings.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/redrat3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index
);
+ if (!rdev-users++)
+ rval = rdev-open(rdev);
+
+ if (rval)
+ rdev-users--;
+
+ return rval;
This looks racey. Some locking is needed, I think rc_dev-lock should work
fine for this. Here and in the lirc code path too.
Sean
}
static void ir_close
On Fri, Jul 12, 2013 at 09:55:28AM +0100, Srinivas KANDAGATLA wrote:
From: Srinivas Kandagatla srinivas.kandaga...@st.com
The use case is simple, if any rc device has allowed protocols =
RC_TYPE_LIRC and map_name = RC_MAP_LIRC set, the driver open will be never
called. The reason for this
: 251,
should be 0
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/redrat3.c | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index 12167a6..3749443 100644
--- a/drivers/media/rc/redrat3.c
+++ b
The lirc interface allows 255 u32 spaces and pulses, which are usec. If
the driver can handle this (e.g. winbond-cir) you can produce hours of
meaningless IR data and there is no method of interrupting it.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/ir-lirc-codec.c | 11
All lirc drivers that can transmit, return EINVAL when they are passed
more than IR data than they can send. That is, except for two drivers
which I touched.
Signed-off-by: Sean Young s...@mess.org
---
Documentation/DocBook/media/v4l/lirc_device_interface.xml | 4 +++-
drivers/media/rc
This one must have missed the conversion c003ab1b [media] rc-core:
add separate defines for protocol bitmaps and numbers.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/usb/dvb-usb/m920x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb
: http://git.linuxtv.org/media_tree.git
Lastly a better subject line would be helpful, this is the headline
for the commit.
Looks good otherwise.
Sean
--- a/drivers/media/rc/mceusb.c 2013-04-07 22:49:54.0 -0500
+++ b/drivers/media/rc/mceusb.c 2013-04-14 12:18:30.0
received the full packet:
689 if (rr3-bytes_read be16_to_cpu(rr3-irdata.header.length))
690 /* we're still accumulating data */
691 return 0;
HTH and thanks for checking my changes.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux
to NULL resulting in rc_free_device being a noop.
Signed-off-by: Jiri Slaby jsl...@suse.cz
Cc: Sean Young s...@mess.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/ttusbir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
for that. However, some else has beaten you
to it, I'm afraid:
http://www.spinics.net/lists/linux-media/msg62058.html
I guess it's up Mauro to decide which one to accept.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
The redrat hardware cannot handle periods of larger than 32767us,
limit appropriately. Also fix memory leak in redrat3_get_timeout.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/redrat3.c | 53
1 files changed, 24 insertions(+), 29
Spotted by sparse.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/redrat3.c | 71 +++
1 files changed, 12 insertions(+), 59 deletions(-)
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
index ec655b8..12167a6 100644
This driver has various minor issues and could be simpler.
Sean Young (3):
[media] redrat3: limit periods to hardware limits
[media] redrat3: remove memcpys and fix unaligned memory access
[media] redrat3: missing endian conversions and warnings
drivers/media/rc/redrat3.c | 457
In stead of doing a memcpy from #defined offset, declare structs which
describe the incoming and outgoing data accurately.
Tested on first generation RedRat.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/redrat3.c | 351 +---
1 files
think this behavior is actually desired since there is no pinctrl
for exynos5 and we don't want it to break. However I think your error
should be more along the lines of pinctrl_get_select_default failed.
You should also print and return PTR_RET(pctrl) instead of EINVAL.
Sean
Has anyone been looking into CT_DIGITAL_WINDOW_CONTROL or
CT_REGION_OF_INTEREST_CONTROL support? Just starting to look at the
uvc 1.5 spec and seeing these features.
Sean
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
) {
+ DRM_ERROR(no platform data specified\n);
+ return -EINVAL;
+ }
+ }
+
+ pctrl = devm_pinctrl_get_select_default(dev);
+ if (IS_ERR(pctrl)) {
Will this work for exynos5? AFAICT, there's no pinctrl setup for it.
Sean
led_classdev_resume already sets the led.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/ttusbir.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c
index 78be8a9..f9226b8 100644
--- a/drivers/media/rc
This transceiver expects the set IR TX ports and IR data as seperate
packets, like the Windows driver does. Remove unnecessary kzalloc.
Signed-off-by: Sean Young s...@mess.org
---
drivers/media/rc/mceusb.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff
901 - 1000 of 1080 matches
Mail list logo
