Re: rc rc0: two consecutive events of type space & strange ir-keytable behaviour

On Fri, May 24, 2019 at 11:45:25AM +0200, Frédéric Deghetto wrote: > Hi Sean, > > Here are the outputs: > ir-keytable: > Found /sys/class/rc/rc0/ (/dev/input/event1) with: > Driver gpio_ir_recv, table rc-rc6-mce > Supported protocols: other lirc rc-5 rc-5-sz jvc sony nec sanyo > mc

Re: rc rc0: two consecutive events of type space & strange ir-keytable behaviour

On Fri, May 24, 2019 at 07:31:03AM +0200, Frédéric Deghetto wrote: > Probably related to this issue; ir-keytable -a /etc/rc_maps.conf -v gives: > > /sys/class/rc/rc0/protocols protocol rc-5 (disabled) > /sys/class/rc/rc0/protocols protocol nec (disabled) > /sys/class/rc/rc0/protocols protocol rc-6

[PATCH 2/3] media: em28xx: use common code for decoding nec scancodes

Tested on WinTV-HVR-930C. Signed-off-by: Sean Young --- drivers/media/usb/em28xx/em28xx-input.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28xx-input.c index e757a71d247f

[PATCH 3/3] media: em28xx: use usb_to_input_id() rather than handrolling it

This also populates the version member correctly. Signed-off-by: Sean Young --- drivers/media/usb/em28xx/em28xx-input.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28xx-input.c index

[PATCH 1/3] media: em28xx: give RC device proper name

Give the RC device the name of the board rather than "1-2:1.0 IR". Signed-off-by: Sean Young --- drivers/media/usb/em28xx/em28xx-input.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers/media/usb/em28xx/em28

Re: [PATCH] media: rc-main: clean-up two warnings

ymbol 'protocol'. > drivers/media/rc/rc-main.c:1541 store_wakeup_protocols() error: > uninitialized symbol 'protocol'. > > So, change it a little bit in order to avoid such warning. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Sean Young > --- >

[GIT PULL FOR v5.3] RC & DVB

g of table registration Neil Armstrong (1): media: rc: meson-ir: update with SPDX Licence identifier Oliver Neukum (1): media: dvb: usb: fix use after free in dvb_usb_device_exit Sean Young (2): media: au0828: fix null dereference in error path media: dvb: warning about

[PATCH v2] media: dvb: warning about dvb frequency limits produces too much noise

debug message for frequency intervals") Cc: # 5.0 Signed-off-by: Sean Young --- drivers/media/dvb-core/dvb_frontend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c index fbdb4ecc7c50..74

[PATCH 2/2] media: dvb: remove replace frontend_debug with dynamic debug

This simplifies the code a little. This does move a dev_dbg() into a timing sensitive code path. This is in the microseconds order so dev_dbg() should not make a difference. Signed-off-by: Sean Young --- drivers/media/dvb-core/dvb_frontend.c | 39 +-- 1 file changed, 18

[PATCH 1/2] media: dvb: warning about dvb frequency limits produces too much noise

This can be a debug message. dvb_frontend: dvb_frontend_get_frequency_limits: frequency interval: tuner: 4500...86000, frontend: 4425...86725 Fixes: 00ecd6bc7128 ("media: dvb_frontend: add debug message for frequency intervals") Cc: # 5.0 Signed-off-by:

[GIT PULL FOR v5.2] dvb & rc fixes

Hi Mauro, Just some minor fixes. Note that the seco-cec fix was already sent as a GIT FIXES request but seems to have been lost, so now resending with stable tag. Sean The following changes since commit 1c3ec30bb23023d738b538e64ac3028902d53692: media: index.rst: exclude Indexes section from l

Re: missing patch on v4l-utils-1.14 / 1.16

On Mon, Apr 08, 2019 at 09:04:56PM +0200, Gregor Jasny wrote: > Hello, > > It seems that commit 6e21f6f34c1d7c3a7a059062e1ddd9705c984e2c is also > missing on 1.16 (in addition to 1.14). Otherwise the return paths are still > messed up: > > > ret = dvb_fe_open_fname(parms, dvb_dev->path, flags

Re: [PATCH 07/13] si2157: Briefly wait for tuning operation to complete

On Mon, Apr 08, 2019 at 01:14:08PM -0500, Brad Love wrote: > > On 05/04/2019 05.29, Sean Young wrote: > > On Sat, Dec 29, 2018 at 11:51:16AM -0600, Brad Love wrote: > >> Some software reports no signal found on a frequency due to immediately > >> checking for lock

Re: [PATCH v4 4/4] pvrusb2: Add Hauppauge HVR1955/1975 devices

Hi Brad, On Mon, Apr 08, 2019 at 01:01:43PM -0500, Brad Love wrote: > > On 05/04/2019 10.29, Sean Young wrote: > > On Fri, Apr 05, 2019 at 04:24:24PM +0100, Sean Young wrote: > >> On Wed, Feb 27, 2019 at 01:16:06PM -0600, Brad Love wrote: > > > +p

Re: [PATCH v4 4/4] pvrusb2: Add Hauppauge HVR1955/1975 devices

On Fri, Apr 05, 2019 at 04:24:24PM +0100, Sean Young wrote: > On Wed, Feb 27, 2019 at 01:16:06PM -0600, Brad Love wrote: > +pr_info("%s(): resetting 160xxx demod\n", __func__); > > + /* TODO: not sure this is proper pl

Re: [PATCH v4 4/4] pvrusb2: Add Hauppauge HVR1955/1975 devices

On Wed, Feb 27, 2019 at 01:16:06PM -0600, Brad Love wrote: > Includes support to identify and use two Hauppauge device. > HVR-1955: > - LGDT3306a ATSC/QAM demod > - si2177 tuner > - cx25840 decoder for analog tv/composite/s-video/audio > > HVR-1975 dual-frontend: > - LGDT3306a ATSC/QAM demod > - s

Re: [PATCH v2 05/12] si2157: Add analog tuning related functions

On Wed, Feb 27, 2019 at 12:27:39PM -0600, Brad Love wrote: > Include set_analog_params, get_frequency, and get_bandwidth. > > Tested with NTSC and PAL standards via ch3/4 generator. Other standards > are included, but are untested due to lack of generator. There are quite a few warnings from chec

Re: [PATCH 2/2] cx25840-core: Set media controller taint for pads

On Mon, Jan 14, 2019 at 07:24:08PM -0600, Brad Love wrote: > Fixes: 9d6d20e652 ("v4l2-mc: switch it to use the new approach to setup > pipelines") > > Without "taint" set for signal type, devices > with analog capture fail during probe: > > [5.821715] cx231xx 3-2:1.1: v4l2 driver version 0.0

Re: [PATCH 07/13] si2157: Briefly wait for tuning operation to complete

On Sat, Dec 29, 2018 at 11:51:16AM -0600, Brad Love wrote: > Some software reports no signal found on a frequency due to immediately > checking for lock as soon as set_params returns. This waits up 40ms for > tuning operation, then from 30-150ms (dig/analog) for signal lock before > returning from

Re: [PATCH v4 2/4] pvrusb2: Add multiple dvb frontend support

On Wed, Feb 27, 2019 at 01:16:04PM -0600, Brad Love wrote: > All changes are equivalent and backwards compatible. > All current devices have been changed to use fe[0] > Cleanup has been added to dvb init to support cleanup after failure. Just very minor note. Here you are adding suppport for 2 fro

Re: [PATCH] si2168: Change from DVB-T to DVB-T/T2 autodetect

Hi Brad, On Sat, Dec 29, 2018 at 12:00:18PM -0600, Brad Love wrote: > DVB-T2 support can be a bit lacking in user land, this provides a module > parameter to allow setting the PLP to auto detect DVB-T and DVB-T2 > signals after tuning. If a DVB-T2 signal is found the signal is > processed as DVB-T

Re: print frequency debug only if dvb_frontend_debug is enables

On Thu, Mar 28, 2019 at 11:44:00AM +0100, Peter Holik wrote: > Hi! > > Every transponder switch from my vdr causes this debug message "frequency > interval: tuner: ..., frontend: ..." in syslog. > > I think this should only happen if dvb_frontend_debug parameter is set. > > cu Peter You need a

Re: [PATCH] media: rc: xbox_remote: add protocol and set timeout

On Sun, Mar 24, 2019 at 10:43:51AM +0100, Matthias Reichl wrote: > The timestamps in ir-keytable -t output showed that the Xbox DVD > IR dongle decodes scancodes every 64ms. The last scancode of a > longer button press is decodes 64ms after the last-but-one which > indicates the decoder doesn't use

[PATCH v4l-utils] keytable: improve description of ir-keytable

Signed-off-by: Sean Young --- utils/keytable/ir-keytable.1.in | 8 +--- utils/keytable/keytable.c | 10 +++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/utils/keytable/ir-keytable.1.in b/utils/keytable/ir-keytable.1.in index 3ea7ea51..5237f0be 100644 --- a

[PATCH v4l-utils] keytable: no need to explain -s option separately

Signed-off-by: Sean Young --- utils/keytable/ir-keytable.1.in | 7 ++- utils/keytable/keytable.c | 6 ++ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/utils/keytable/ir-keytable.1.in b/utils/keytable/ir-keytable.1.in index a717b8da..f3a2b9c8 100644 --- a/utils

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

Hi Sam, On Tue, Mar 26, 2019 at 08:35:44AM +0100, Samuel CHEMLA wrote: > Hi, > > > I am struggling with valgrind because it always complain with either : > ASan runtime does not come first in initial library list; you > should either link runtime to your application or manually preload it >

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

On Wed, Mar 20, 2019 at 08:38:52PM +0100, Gregor Jasny wrote: > Hello Mauro, > > On 19.03.19 20:45, Mauro Carvalho Chehab wrote: > > Hi Gregor, > > > > Samuel reported in priv that the issues he had with user after free were > > solved by the patchsets merged at 1.12 and 1.16 stable branches. > >

Re: ir-keytable known bug -- fails to work when device specified

On Tue, Mar 19, 2019 at 08:14:45PM -0400, Adam Di Carlo wrote: > Sean Young writes: > > Adam wrote: > >> Rather than document all this, isn't better to clean it up in the > >> source? I can probably come up with a patch for this issue in fairly > >> short

Re: ir-keytable known bug -- fails to work when device specified

property of the input device which it is not. Actually I think the whole -d option is misleading and not really useful. I think the right solution is to just remove it completely. Sean >From 57fde44ec8723e6c15143f72055bd586628c3d8b Mon Sep 17 00:00:00 2001 From: Sean Young Date: Tue, 19 Mar 2019 1

[PATCH v4l-utils] keytable: minor rewording from TABLE to KEYMAP

Signed-off-by: Sean Young --- utils/keytable/ir-keytable.1.in | 15 +-- utils/keytable/keytable.c | 6 +++--- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/utils/keytable/ir-keytable.1.in b/utils/keytable/ir-keytable.1.in index c0844945..9a354be4 100644 --- a

[PATCH v4l-utils] libdvbv5: leaks and double free in dvb_fe_open_fname()

: Sean Young --- lib/libdvbv5/dvb-dev-local.c | 2 +- lib/libdvbv5/dvb-fe.c| 18 -- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/lib/libdvbv5/dvb-dev-local.c b/lib/libdvbv5/dvb-dev-local.c index e98b967a..2de9a614 100644 --- a/lib/libdvbv5/dvb-dev

[PATCH v4l-utils] lircd2toml: convert lircd.conf rc6 remote definitions

Signed-off-by: Sean Young --- contrib/lircd2toml.py | 63 ++- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/contrib/lircd2toml.py b/contrib/lircd2toml.py index b1aa2403..9b93f198 100755 --- a/contrib/lircd2toml.py +++ b/contrib

Re: [PATCH] media: si2168: add parameter to disable DVB-T support

On Sat, Mar 09, 2019 at 12:21:48AM +0200, Stefan Becker wrote: > Some DVB clients are broken and only recognize the DVB-T/T2 support in > the frontend. Thus they are unable to use the frontend in DVB-C mode. > One example is the incomplete DVBv5 API support added in mythtv 0.30: > >https://cod

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

Hi, On Tue, Mar 12, 2019 at 04:07:23PM +0100, Gregor Jasny wrote: > Hello Mauro, > > below you find a bug report about an use-after-free in dvbv5-zap. > > On 12.03.19 13:37, CHEMLA Samuel wrote: > > please find a bug report that seems to concern ARMHF builds of dvbv5-zap > > (dvb-tool package) :

[GIT PULL FOR v5.2] Some DVB and RC fixes

Hi Mauro, Just some minor fixes and device support for Avermedia TD310. Thanks, Sean The following changes since commit 15d90a6ae98e6d2c68497b44a491cb9efbb98ab1: media: dvb/earth-pt1: fix wrong initialization for demod blocks (2019-03-04 06:17:02 -0500) are available in the Git repository

[PATCH v4l-utils 2/2] lircd2toml: detect NEC if bit 0 and 1 are inverted

This fixes conversion of: http://lirc.sourceforge.net/remotes/goldstar/VCR Signed-off-by: Sean Young --- contrib/lircd2toml.py | 36 1 file changed, 36 insertions(+) diff --git a/contrib/lircd2toml.py b/contrib/lircd2toml.py index f2f7cdd3

[PATCH v4l-utils 1/2] lircd2toml: honour pre_data for rc-mm remote definitions

Signed-off-by: Sean Young --- contrib/lircd2toml.py | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/contrib/lircd2toml.py b/contrib/lircd2toml.py index 72ee50e3..f2f7cdd3 100755 --- a/contrib/lircd2toml.py +++ b/contrib/lircd2toml.py @@ -349,7 +349,7

[PATCH v4l-utils] lircd2toml: toggle_bit is offset from bits including pre-data

This causes the following lircd.conf to be converted incorrectly. http://lirc.sourceforge.net/remotes/cambridge_audio/X40A Signed-off-by: Sean Young --- contrib/lircd2toml.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/lircd2toml.py b

[GIT FIXES FOR v5.1] seco build fix

13:21:00 +) Sean Young (1): media: seco: depend on CONFIG_RC_CORE=y when not a module drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v4l-utils] Add man page describing rc_keymap toml file

Signed-off-by: Sean Young --- configure.ac| 1 + utils/ir-ctl/ir-ctl.1.in| 2 +- utils/keytable/.gitignore | 1 + utils/keytable/Makefile.am | 4 +- utils/keytable/ir-keytable.1.in | 1 + utils/keytable/rc_keymap.5.in | 251

Re: [PATCH] media: drxk: add a missed check of the return value of write16

On Tue, Dec 25, 2018 at 02:03:07AM -0600, Kangjie Lu wrote: > write16() could fail. The fix inserts a check for its return value > in case it fails. > > Signed-off-by: Kangjie Lu Unless it is tested on the actual hardware we can't apply this. This could introduce regressions. Sean > --- > dri

Re: [PATCH v2] media: si2165: fix a missing check of return value

On Fri, Dec 21, 2018 at 09:24:46AM +0100, Matthias Schwarzott wrote: > Am 21.12.18 um 05:54 schrieb Kangjie Lu: > > si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find > > that "val_tmp" will be an uninitialized value when regmap_read() fails. > > "val_tmp" is then assigned to

Re: [linux-next:master 1790/12310] drivers/media/platform/seco-cec/seco-cec.c:355: undefined reference to `devm_rc_allocate_device'

allocate_device(dev, RC_DRIVER_SCANCODE); So the config has: CONFIG_CEC_CORE=y CONFIG_RC_CORE=m CONFIG_VIDEO_SECO_CEC=y CONFIG_VIDEO_SECO_RC=y So devm_rc_allocate_device() is in a module, while seco-cec is not. CONFIG_VIDEO_SECO_RC itself is a boolean and depends on CONFIG_RC_CORE. Sean >From

[PATCH v4l-utils] ir-ctl: various typos

Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 4 ++-- utils/ir-ctl/ir-ctl.c | 2 +- utils/keytable/keytable.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.1.in b/utils/ir-ctl/ir-ctl.1.in index c3ab118f..03fcf438 100644 --- a/utils/ir

[GIT FIXES FOR v5.1] pt1 fix

Hi Mauro, A late fix for pt1 dvb driver. Thanks, Sean The following changes since commit 26b190053ec0db030697e2e19a8f8f13550b9ff7: media: a few more typos at staging, pci, platform, radio and usb (2019-03-01 10:02:25 -0500) are available in the Git repository at: git://linuxtv.org/syoung

[GIT FIXES FOR v5.1] RC fix

/media_tree.git for-v5.1c for you to fetch changes up to f02f2c180ebb88d216bab9290b7c5ba7d17f45e6: Revert "media: rc: some events are dropped by userspace" (2019-02-22 09:28:41 +) ---- Sean Young (1): Revert "media:

[PATCH] Revert "media: rc: some events are dropped by userspace"

uevent (UEVENT_BUFFER_SIZE) and no event is generated. Revert for now until we figure out a different solution. This reverts commit fec225a04330d0f222d24feb5bea045526031675. Cc: # 4.20+ Reported-by: Christian Holpert Signed-off-by: Sean Young --- drivers/media/rc/rc-main.c | 13 - 1

Re: [PATCH V2 2/2] Add suport for Avermedia TD310

s/suport/support in title. On Wed, Feb 20, 2019 at 10:36:16PM +0100, Jose Alberto Reguero wrote: > This patch add support for Avermedia TD310 usb stik. stick > > Signed-off-by: Jose Alberto Reguero > > diff -upr linux/drivers/media/usb/dvb-usb-v2/af9035.c > linux.new/drivers/media/usb/dvb-

Re: [PATCH V2 1/2] af9035: init i2c already in it930x_frontend_attach

On Wed, Feb 20, 2019 at 10:36:04PM +0100, Jose Alberto Reguero wrote: > This patch init i2c in it930x_frontend_attach instead of it930x_tuner_attach. This needs to describe why you are moving it. We can see in the patch that you've moved it. Something like "we need i2c to be available in it930x_f

Re: [PATCH] Add suport for Avermedia TD310

On Wed, Feb 20, 2019 at 01:49:28PM +0100, Jose Alberto Reguero wrote: > El 20 de febrero de 2019 10:37:15 CET, Sean Young escribió: > >On Tue, Feb 19, 2019 at 11:51:25PM +0100, Jose Alberto Reguero wrote: > >> El 19 de febrero de 2019 22:57:31 CET, Sean Young > >escrib

Re: [PATCH 1/3] [media] rc/keymaps: add keytable for Pine64 IR Remote Controller

On Mon, Feb 18, 2019 at 09:59:36PM +, Jonas Karlman wrote: > This RC map is based on remote key schema at [1], the mouse button key > did not have an obvious target and was mapped to KEY_CONTEXT_MENU. How about BTN_LEFT ? Thanks, Sean > > [1] http://files.pine64.org/doc/Pine%20A64%20Schema

Re: [PATCH] Add suport for Avermedia TD310

On Tue, Feb 19, 2019 at 11:51:25PM +0100, Jose Alberto Reguero wrote: > El 19 de febrero de 2019 22:57:31 CET, Sean Young escribió: > >On Mon, Feb 11, 2019 at 11:13:25PM +0100, Jose Alberto Reguero wrote: > >> This patch add support for Avermedia TD310 usb stik. > >>

Re: [PATCH] Add suport for Avermedia TD310

On Mon, Feb 11, 2019 at 11:13:25PM +0100, Jose Alberto Reguero wrote: > This patch add support for Avermedia TD310 usb stik. > This patch must be aplied after this one: > https://patchwork.linuxtv.org/patch/40087/ That patch is marked Changes Requested. Please fix that patch first, and then re-sub

Re: DVB-T2 Stick

Hi, On Wed, Jan 30, 2019 at 11:32:12AM +0100, Gonsolo wrote: > Hi! > > The following patch adds support for the Logilink VG0022A DVB-T2 stick. > After patching and building the kernel it shows up with lsusb and I > used w_scan to scan for channels and vlc for watching. > The original patches were

[PATCH v4l-utils 1/2] ir-ctl/keytable: add see also to reference to man pages

Add hint to how you can start to figure out what protocol a remote uses. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in| 3 +++ utils/keytable/ir-keytable.1.in | 9 + 2 files changed, 12 insertions(+) diff --git a/utils/ir-ctl/ir-ctl.1.in b/utils/ir-ctl/ir-ctl.1.in

[PATCH v4l-utils 2/2] rc-mm protocol support

Signed-off-by: Sean Young --- utils/common/ir-encode.c | 3 +++ utils/keytable/keytable.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/utils/common/ir-encode.c b/utils/common/ir-encode.c index ccc75032..4bd1b694 100644 --- a/utils/common/ir-encode.c +++ b/utils/common/ir-encode.c

Re: [PATCH 07/14] media: rc: fix several typos

On Mon, Feb 18, 2019 at 02:29:01PM -0500, Mauro Carvalho Chehab wrote: > Use codespell to fix lots of typos over frontends. > > Manually verified to avoid false-positives. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Sean Young > --- > dri

Re: [PATCH] media: dvb/earth-pt1: fix wrong initialization for demod blocks

Hello, Thank you for your patch. On Thu, Jan 10, 2019 at 06:56:23PM +0900, tsk...@gmail.com wrote: > From: Akihiro Tsukada > > earth-pt1 driver was decomposed/restructured by the commit: b732539efdba > ("media: dvb: earth-pt1: decompose pt1 driver into sub drivers"), > but it introduced a probl

[GIT PULL FOR v5.1] RC fixes v2

Hi Mauro, Here are the last RC fixes for 5.1, this time with the documentation warnings fixed. Thanks, Sean The following changes since commit 46c039d06b6ecabb94bd16c3a999b28dc83b79ce: media: cx25840: mark pad sig_types to fix cx231xx init (2019-02-18 12:33:20 -0500) are available in the Gi

Re: [GIT PULL FOR v5.1] RC fixes

On Mon, Feb 18, 2019 at 02:22:52PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 8 Feb 2019 22:15:22 + > Sean Young escreveu: > > > Hi Mauro, > > > > Here are the last RC fixes for 5.1. > > > > Thanks, > > > &g

[GIT PULL FOR v5.1] RC fixes

Hi Mauro, Here are the last RC fixes for 5.1. Thanks, Sean The following changes since commit 6fd369dd1cb65a032f1ab9227033ecb7b759656d: media: vimc: fill in bus_info in media_device_info (2019-02-07 12:38:59 -0500) are available in the Git repository at: git://linuxtv.org/syoung/media_tr

Re: [RFC PATCH 8/8] dvb-core: fix epoll() by calling poll_wait first

, dvb_dvr_poll() and > dvb_ca_en50221_io_poll(). Fix this, otherwise epoll() > can timeout when it shouldn't. > > Signed-off-by: Hans Verkuil Reviewed-by: Sean Young > --- > drivers/media/dvb-core/dmxdev.c | 8 > drivers/media/dvb-core/dvb_ca_en50221.c | 5 ++--- &g

Re: [RFC PATCH 1/8] cec: fix epoll() by calling poll_wait first

ts) > res |= EPOLLPRI; > - poll_wait(filp, &fh->wait, poll); > mutex_unlock(&adap->lock); > return res; > } > -- > 2.20.1 Reviewed-by: Sean Young Sean

[PATCH v4l-utils] Print receiver timeout

Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index 7ecb1317..f8f4e0aa 100644 --- a/utils/ir-ctl/ir-ctl.c +++ b/utils/ir-ctl/ir-ctl.c @@ -708,8 +708,13 @@ static

Re: [PATCH 1/2] selftests: Use lirc.h from kernel tree, not from system

On Tue, Jan 22, 2019 at 08:51:01AM -0700, shuah wrote: > On 1/17/19 8:29 AM, Sean Young wrote: > > When the system lirc.h is older than v4.16, you will get errors like: > > > > ir_loopback.c:32:16: error: field ‘proto’ has incomplete type > >enum rc_proto pro

[PATCH 2/2] media: rc: rcmm decoder and encoder

From: Patrick Lerda media: add support for RCMM infrared remote controls. Signed-off-by: Patrick Lerda Signed-off-by: Sean Young --- MAINTAINERS | 5 + drivers/media/rc/Kconfig | 13 ++ drivers/media/rc/Makefile| 1 + drivers

[PATCH 1/2] selftests: Use lirc.h from kernel tree, not from system

When the system lirc.h is older than v4.16, you will get errors like: ir_loopback.c:32:16: error: field ‘proto’ has incomplete type enum rc_proto proto; Cc: Shuah Khan Signed-off-by: Sean Young --- tools/testing/selftests/ir/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH 0/2] rcmm with minor tweaks and selftest

Hi Patrick, I've made some very minor/cosmetic changes and added rcmm to the selftest; I didn't want to just add them to the tree without showing to you first. Let me know what you think. Thanks Sean Patrick Lerda (1): media: rc: rcmm decoder and encoder Sean Young (1): self

[PATCH 1/2] ir-ctl: Rename no-wideband to narrowband

Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 2 +- utils/ir-ctl/ir-ctl.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.1.in b/utils/ir-ctl/ir-ctl.1.in index 2a148c70..10d4d594 100644 --- a/utils/ir-ctl/ir-ctl.1.in +++ b/utils/ir-ctl/ir

[PATCH 2/2] ir-ctl: imon protocol can be encoded too

Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/ir-ctl/ir-ctl.1.in b/utils/ir-ctl/ir-ctl.1.in index 10d4d594..226bf606 100644 --- a/utils/ir-ctl/ir-ctl.1.in +++ b/utils/ir-ctl/ir-ctl.1.in @@ -181,7 +181,7 @@ pulse

[GIT PULL FOR v5.1] Various fixes

Hi Mauro, Here are some of the dvb fixes and the rc fixes for 5.1. Please pull. Thanks, Sean The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247: media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500) are available in the Gi

[PATCH] keytable: add support for iMON RSC remote pointer

This remote has a small joystick which acts like a mouse. Support decoding this. Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/Makefile.am | 2 +- utils/keytable/bpf_protocols/bpf_helpers.h| 192 +++--- utils/keytable/bpf_protocols/imon_rsc.c | 156

Re: [PATCH v5 1/1] media: rc: rcmm decoder

Hi Patrick, On Sat, Dec 08, 2018 at 02:18:05AM +0100, Patrick Lerda wrote: > media: add support for RCMM infrared remote controls. > > Signed-off-by: Patrick Lerda Sorry about the delay in getting this reviewed. December was a very busy month for me. > --- > MAINTAINERS

Re: [PATCH v5 1/1] media: rc: rcmm decoder

Hi Patrick, On Thu, Dec 13, 2018 at 11:41:01PM +0100, Patrick Lerda wrote: > Hi Sean, > >    Is the v5 OK? Sorry I'm currently at the Linux Foundation Hyperledger event in Basel, I'll be back next week and then I'll do a proper review. Looks good at first glance. Thanks Sean

Re: bug report cxusb oops

at the firmware and device loads correctly on an older > machine running an i386 platform and 3.13 kernel It would be helpful to know if this can be reproduced on the current media tree, see: https://git.linuxtv.org/media_tree.git/about/ Thanks, Sean > > > On 12/10/18 11:30 PM

Re: bug report cxusb oops

Hi, On Mon, Dec 10, 2018 at 10:51:33AM +1100, David Howe wrote: > hi > > using the experimental version of the media stack and i get this > > [   80.606898] dvb-usb: found a 'DViCO FusionHDTV DVB-T NANO2 w/o firmware' > in cold state, will try to load a firmware > [   80.620010] dvb-usb: downloa

Re: [PATCHv3 1/1] Add ir-rcmm-driver

Hi Patrick, On Fri, Dec 07, 2018 at 10:57:21AM +0100, Patrick LERDA wrote: > Add support for RCMM infrared remote controls. > > Signed-off-by: Patrick Lerda Other than the Signed-off-by this looks exactly like the v2 version; did you see my other comments on the v2 patch? Thanks Sean > --- >

[GIT PULL FOR v4.21] Two DVB patches

Hi Mauro, Two small dvb fixes which would be nice to have in 4.21. Thanks, Sean The following changes since commit 3c28b91380dd1183347d32d87d820818031ebecf: media: stkwebcam: Bugfix for wrong return values (2018-12-05 14:10:48 -0500) are available in the Git repository at: git://linuxtv.o

Re: [PATCH] [PATCHv2] Add ir-rcmm-driver

On Wed, Dec 05, 2018 at 01:29:33AM +0100, patrick9...@free.fr wrote: > From: Patrick LERDA > We need a Signed-off-by: here. https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > --- > drivers/media/rc/Kconfig |

[PATCH bpf-next v3] media: bpf: add bpf function to report mouse movement

Some IR remotes have a directional pad or other pointer-like thing that can be used as a mouse. Make it possible to decode these types of IR protocols in BPF. Cc: net...@vger.kernel.org Signed-off-by: Sean Young --- drivers/media/rc/bpf-lirc.c | 24 +++ include/uapi/linux

Re: [PATCH] Add ir-rcmm-driver

On Tue, Dec 04, 2018 at 09:20:25PM +0100, patrick9...@free.fr wrote: > From: Patrick LERDA > > --- > drivers/media/rc/Kconfig | 10 ++ > drivers/media/rc/Makefile | 1 + > drivers/media/rc/ir-rcmm-decoder.c | 185 + > drivers/media/rc/rc-core-pri

[GIT PULL FOR v4.21] more dvb fixes

): media: usb: dvb-usb: remove old friio driver Malcolm Priestley (2): media: lmedm04: Move usb buffer to lme2510_state. media: lmedm04: use dvb_usbv2_generic_rw_locked Nikita Gerasimov (1): media: rtl28xxu: add support for Sony CXD2837ER slave demod Sean Young (1): media

Re: [PATCH 3/4] media: lmedm04: Move interrupt buffer to priv buffer.

On Thu, Nov 29, 2018 at 10:30:15PM +, Malcolm Priestley wrote: > Interrupt is always present throught life time of > there is no dma element move this buffer to private > area of driver. > > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 26 +---

Re: [PATCH 1/4] media: lmedm04: Add missing usb_free_urb to free, interrupt urb

On Thu, Nov 29, 2018 at 10:29:31PM +, Malcolm Priestley wrote: > The interrupt urb is killed but never freed add the function > > Cc: sta...@vger.kernel.org > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [PATCH] [media] dib7000p: Remove dead code

On Tue, Dec 04, 2018 at 09:57:14AM -0200, Mauro Carvalho Chehab wrote: > Em Tue, 4 Dec 2018 10:26:40 + > Sean Young escreveu: > > > On Mon, Sep 17, 2018 at 07:39:36PM -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 17 Sep 2018 10:58:32 -0700 > >

Re: [PATCH] [media] dib7000p: Remove dead code

is to estimate the streaming bit rate. > > I don't remember anymore from where the dib8000 formula came. > > My guts tell that time interleaving shouldn't do much changes (if any) > to the bit rate. I suspect that removing the dead code is likely > OK, but I'll t

Re: Astrometa DVB-T2 2018 update

On Mon, Nov 05, 2018 at 07:12:52PM +, Bob Goddard wrote: > Enable Sony CXD2837ER slave demon on the Astrometa DVB-T2, known as the 2018 > update. > > Originally based on the patch by kapitanf at > https://github.com/torvalds/linux/pull/567, it was not quite right. This is > more correct, bu

[GIT PULL FOR v4.21] dvb fixes

alcolm Priestley (1): media: dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER Neil Armstrong (3): media: cxd2880-spi: fix probe when dvb_attach fails media: cxd2880-spi: Add optional vcc regulator media: sony-cxd2880: add optional vcc regulator to bindings Sea

Re: [PATCH] media: dvb: fix a missing-check bug

Hi Wenwen, On Mon, Oct 29, 2018 at 01:46:04PM -0500, Wenwen Wang wrote: > Hello, > > Can anyone confirm this bug? Thanks! > > Wenwen > > On Fri, Oct 19, 2018 at 9:12 AM Wenwen Wang wrote: > > > > In dvb_audio_write(), the first byte of the user-space buffer 'buf' is > > firstly copied and chec

Re: [PATCH dvb v1 4/4] media: dvb_frontend: remove __func__ from dev_dbg()

On Tue, Oct 30, 2018 at 05:14:51PM +0100, Victor Toso wrote: > From: Victor Toso > > As dynamic debug can be instructed to add the function name to the > debug output using +f switch, we can remove __func__ from all > dev_dbg() calls. If not, a user that sets +f in dynamic debug would > get dupli

Re: [PATCH dvb v1 3/4] media: dvb-usb-v2: remove __func__ from dev_dbg()

On Tue, Oct 30, 2018 at 05:14:50PM +0100, Victor Toso wrote: > From: Victor Toso > > As dynamic debug can be instructed to add the function name to the > debug output using +f switch, we can remove __func__ from all > dev_dbg() calls. If not, a user that sets +f in dynamic debug would > get dupli

Re: [PATCH v2] media: bpf: add bpf function to report mouse movement

Hi Daniel, On Mon, Nov 26, 2018 at 01:55:36AM +0100, Daniel Borkmann wrote: > Hi Sean, > > On 11/23/2018 12:50 PM, Sean Young wrote: > > Some IR remotes have a directional pad or other pointer-like thing that > > can be used as a mouse. Make it possible to decode these type

[PATCH] media: saa7134: rc-core maintains users count, no need to duplicate

This simplifies the code a little. Tested with suspend and resume. Signed-off-by: Sean Young --- drivers/media/pci/saa7134/saa7134-core.c | 8 +-- drivers/media/pci/saa7134/saa7134-input.c | 68 --- drivers/media/pci/saa7134/saa7134.h | 9 ++- 3 files changed, 18

[PATCH v4l-utils] keytable: do not install bpf protocols decoders with execute permission

/rpm/pull/604 Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/keytable/bpf_protocols/Makefile.am b/utils/keytable/bpf_protocols/Makefile.am index 1b90411b..d1f04cb4 100644 --- a/utils/keytable

[PATCH v2] media: bpf: add bpf function to report mouse movement

Some IR remotes have a directional pad or other pointer-like thing that can be used as a mouse. Make it possible to decode these types of IR protocols in BPF. Cc: net...@vger.kernel.org Signed-off-by: Sean Young --- drivers/media/rc/bpf-lirc.c | 24 +++ include

[PATCH v4l-utils] keytable: match every entry in rc_maps.cfg, not just the first

Signed-off-by: Sean Young --- utils/keytable/keytable.c | 71 --- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c index e15440de..df9cfc49 100644 --- a/utils/keytable/keytable.c +++ b/utils

Re: TechnoTrend CT2-4500 remote not working

Martin, On Wed, Nov 14, 2018 at 09:51:38PM +0100, martin.kono...@mknetz.de wrote: > > It would be interesting to see what the device is sending. Please can you > > turn > > on dynamic debug for ir-kbd-i2c.c: > > > > echo "file ir-kbd-i2.c +p" > /sys/kernel/debug/dynamic_debug/control > > > > Tr

Re: TechnoTrend CT2-4500 remote not working

On Sat, Nov 10, 2018 at 10:35:29PM +0100, martin.kono...@mknetz.de wrote: > Hi all, > > the remote on my TechnoTrend CT2-4500 is not working with kernel 4.18. > The TV-card itself works fine: > > cx25840 6-0044: loaded v4l-cx23885-avcore-01.fw firmware (16382 bytes) > cx23885: cx23885_dvb_registe

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

Hi Peter, On Thu, Nov 08, 2018 at 10:13:38PM +0100, Peter Seiderer wrote: > Thanks, works for the buildroot use case (disabling > bpf support unconditionally)... > > The reason to provide copies of the linux kernel headers in v4l-utils > is to be independent of old(-er) headers provided by toolc

[PATCH] keytable: fix BPF protocol compilation on mips

Linux +compiler or give up. > #error Use a Linux compiler or give up. This requires __linux__ to be defined. Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/keytable/bpf_protocols/Makefile

<    1   2   3   4   5   6   7   8   9   10   >