Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On 04/04/2017 04:10 PM, Russell King - ARM Linux wrote: On Thu, Mar 30, 2017 at 07:25:49PM +0200, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On 04/04/2017 05:40 PM, Steve Longerbeam wrote: On 04/04/2017 04:10 PM, Russell King - ARM Linux wrote: On Thu, Mar 30, 2017 at 07:25:49PM +0200, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

On 03/30/2017 10:25 AM, Philipp Zabel wrote: The TVP5150 DT bindings specify a single output port (port 0) that corresponds to the video output pad (pad 1, DEMOD_PAD_VID_OUT). Signed-off-by: Philipp Zabel --- I'm trying to get this to work with a TVP5150 analog TV

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

On 04/04/2017 05:47 AM, Sakari Ailus wrote: Hi Steve, Philipp and Pavel, On Mon, Mar 27, 2017 at 05:40:34PM -0700, Steve Longerbeam wrote: From: Philipp Zabel <p.za...@pengutronix.de> This driver can handle SoC internal and external video bus multiplexers, controlled either by regist

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On 04/06/2017 08:25 AM, Philipp Zabel wrote: On Thu, 2017-04-06 at 16:10 +0100, Russell King - ARM Linux wrote: On Thu, Apr 06, 2017 at 05:01:52PM +0200, Philipp Zabel wrote: On Thu, 2017-04-06 at 15:05 +0100, Russell King - ARM Linux wrote: On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp

[PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

this has not already been done. The exception is ic-prpencvf at the source pad, since the Image Converter outputs fixed quantization and Y`CbCr encoding. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-ic-prp.c | 5 ++- drivers/staging/med

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

On 04/13/2017 03:09 AM, Philipp Zabel wrote: Hi Steve, thanks for cleaning this up. Apart from the comments below, this looks good to me. On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: This patch adds a call to imx_media_fill_empty_mbus_fields() in the *_try_fmt() functions

[PATCH v5 10/39] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

) are thus moved into i2cmux. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 65 +--- 1 file changed, 44 insertions(+), 21 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/ar

[PATCH v5 36/39] media: imx: redo pixel format enumeration and negotiation

(u32 *code, u32 index, enum codespace_sel cs_sel); The tables have been split into separate tables for YUV and RGB formats to support the implementation of the above. The subdev's .enum_mbus_code() and .set_fmt() operations have been rewritten using the above APIs. Signed-off-by: Steve Longerbeam

[PATCH v5 39/39] media: imx: propagate sink pad formats to source pads

propagation in this case was easy, just have only a single format shared by both pads. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-ic-prp.c| 31 +++--- drivers/staging/media/imx/imx-ic-prpencvf.c | 86 ++- drivers/staging/med

[PATCH v5 34/39] media: imx: csi: add __csi_get_fmt

Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Suggested-by: Russell King <li...@armlinux.org.uk> --- drivers/staging/media/imx/imx-medi

[PATCH v5 35/39] media: imx: csi/fim: add support for frame intervals

From: Russell King <rmk+ker...@armlinux.org.uk> Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Signed-off-by: Steve Longerbeam <steve_longer

[PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

From: Philipp Zabel <p.za...@pengutronix.de> The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam &l

[PATCH v5 29/39] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

max zoneorder to allow larger video buffer allocations. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/configs/imx_v6_v7_defconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/c

[PATCH v5 28/39] media: imx: Add MIPI CSI-2 Receiver subdev driver

Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c

[PATCH v5 26/39] media: imx: Add VDIC subdev driver

register_subdev(>sd); + if (ret) + goto free; + + return 0; +free: + mutex_destroy(>lock); + return ret; +} + +static int imx_vdic_remove(struct platform_device *pdev) +{ + struct v4l2_subdev *sd = platform_get_drvdata(pdev); + struct vdic_priv *priv = v4l2_get_subdevdata(sd); + + v4l2_info(sd, "Removing\n"); + + v4l2_async_unregister_subdev(sd); + mutex_destroy(>lock); + media_entity_cleanup(>entity); + + return 0; +} + +static const struct platform_device_id imx_vdic_ids[] = { + { .name = "imx-ipuv3-vdic" }, + { }, +}; +MODULE_DEVICE_TABLE(platform, imx_vdic_ids); + +static struct platform_driver imx_vdic_driver = { + .probe = imx_vdic_probe, + .remove = imx_vdic_remove, + .id_table = imx_vdic_ids, + .driver = { + .name = "imx-ipuv3-vdic", + }, +}; +module_platform_driver(imx_vdic_driver); + +MODULE_DESCRIPTION("i.MX VDIC subdev driver"); +MODULE_AUTHOR("Steve Longerbeam <steve_longerb...@mentor.com>"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:imx-ipuv3-vdic"); -- 2.7.4

[PATCH v5 22/39] media: Add userspace header file for i.MX

This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls for the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h

[PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- include/uapi/Kbuild | 1 + include/uapi/media/Kbuild | 1 + 2 files changed, 2 insertions(+) create mode 100644 include/uapi/media/Kbuild diff --git a/includ

[PATCH v5 17/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/v4l2-core/v4l2-mc.c | 48 +++ include/media/v4l

[PATCH v5 20/39] platform: add video-multiplexer subdevice driver

tionality of this driver, but allows for it to be merged now, before adding the chaining support. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/platform/Kconfig | 8 + drivers/media/platform/Makefile| 2 + drivers/media/plat

[PATCH v5 23/39] media: Add i.MX media core driver

Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Documentation/media/v4l-drivers/imx.rst | 560 drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile

[PATCH v5 15/39] [media] v4l2: add a frame interval error event

Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is outside the nominal frame interval by some tolerance value. Signed-off-by: Steve Longerbeam

[PATCH v5 19/39] [media] add Omnivision OV5640 sensor driver

This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile

[PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

callbacks. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/media/v4l2-core/v4l2-subdev.c | 50 +++ include/media/v4l2-subdev.h | 10 +++ 2 files changed, 60 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-subde

[PATCH v5 14/39] add mux and video interface bridge entity functions

From: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Documentation/media/uapi/mediactl/me

[PATCH v5 13/39] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dts

[PATCH v5 16/39] [media] v4l2: add a new-frame before end-of-frame event

Add a NEW_FRAME_BEFORE_EOF event to signal that a video capture or output device has signaled a new frame is ready before a previous frame has completed reception or transmission. This usually indicates a DMA read/write channel is having trouble gaining bus access. Signed-off-by: Steve Longerbeam

[PATCH v5 11/39] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

, that chip is needed by more functions (usb and adv7180). Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/i

[PATCH v5 05/39] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

muxes for the connections from parallel sensors. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl.dtsi | 180 + arch/arm/boot/dts/imx6q.dtsi | 116 ++ arch/arm/boot/dts/imx6qd

[PATCH v5 03/39] [media] dt/bindings: Add bindings for OV5640

Add device tree binding documentation for the OV5640 camera sensor. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- .../devicetree/bindings/media/i2c/ov5640.txt | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devi

[PATCH v5 12/39] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/bo

[PATCH v5 09/39] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

available for testing, the ov5642 node is currently disabled. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl-sabresd.dts | 5 ++ arch/arm/boot/dts/imx6q-sabresd.dts| 5 ++ arch/arm/boot/dts/imx6qdl-sabresd.dtsi

[PATCH v5 27/39] media: imx: Add IC subdev drivers

directly from the CSI or from the VDIC. Scaled output is limited to 1024x1024 resolution. Output frames are routed to the capture device. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/

[PATCH v5 37/39] media: imx: csi: add frame skipping support

From: Philipp Zabel <p.za...@pengutronix.de> The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.co

[PATCH v5 33/39] media: imx: mipi-csi2: enable setting and getting of frame rates

s part of the negotiation. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx6-mipi-csi2.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/drivers/stag

[PATCH v5 30/39] media: imx: add support for bayer formats

From: Russell King <rmk+ker...@armlinux.org.uk> Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam &l

[PATCH v5 31/39] media: imx: csi: add support for bayer formats

destination is IDMAC output pad when passthrough conditions exist: bayer formats and 16-bit parallel buses. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-media-csi.c | 52 +-- 1 file changed, 43 insertions(+), 9

[PATCH v5 32/39] media: imx: csi: fix crop rectangle changes in set_fmt

ed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/imx-media-csi.c | 35 --- 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/imx/imx-medi

[PATCH v5 25/39] media: imx: Add CSI subdev driver

This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Kconfig | 14 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c

[PATCH v5 24/39] media: imx: Add Capture Device Interface

. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging/media/imx/Makefile| 1 + drivers/staging/media/imx/imx-media-capture.c | 655 ++ 2 files changed, 656 insertions(+) create mode 100644 drivers/staging/media/imx/imx

[PATCH v5 08/39] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

-2 receiver on mipi_csi. The OV5642 node is disabled temporarily while the subdev driver is cleaned up and submitted later. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl-sabrelite.dts | 5 ++ arch/arm/boot/dts/imx6q-sabrelite.dts| 5 ++

[PATCH v5 06/39] ARM: dts: imx6qdl: add capture-subsystem device

Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 8958c4a..a959c76

[PATCH v5 00/39] i.MX Media Driver

frame skipping support media: imx: csi: fix crop rectangle reset in sink set_fmt Russell King (4): media: imx: add support for bayer formats media: imx: csi: add support for bayer formats media: imx: mipi-csi2: enable setting and getting of frame rates media: imx: csi/fim: add support f

[PATCH v5 04/39] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/bo

[PATCH v5 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

From: Philipp Zabel <p.za...@pengutronix.de> Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.c

[PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

oards that have the HW workaround for ERR006687") Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b

[PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

On 03/05/2017 02:41 PM, Russell King - ARM Linux wrote: On Sat, Mar 04, 2017 at 04:37:43PM -0800, Steve Longerbeam wrote: On 03/04/2017 02:56 AM, Sakari Ailus wrote: That's a bit of a special situation --- still there are alike conditions on existing hardware. You should return the buffers

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/03/2017 03:06 PM, Russell King - ARM Linux wrote: On Thu, Mar 02, 2017 at 06:02:57PM +0200, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/03/2017 11:17 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 02, 2017 at 06:12:43PM -0800, Steve Longerbeam wrote: On 03/02/2017 03:48 PM, Steve Longerbeam wrote: On 03/02/2017 08:02 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

On 03/03/2017 03:45 AM, Sakari Ailus wrote: On Thu, Mar 02, 2017 at 03:07:21PM -0800, Steve Longerbeam wrote: On 03/02/2017 07:53 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:15PM -0800, Steve Longerbeam wrote: Add a new FRAME_TIMEOUT event to signal that a video

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 12:26 PM, Pavel Machek wrote: Hi! I tend to agree with that. I agree as well. This is in line with how existing drivers behave, too. Well, sounds like there is consensus on this topic. I guess I'll go ahead and remove the control inheritance support. I suppose having a

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward. Think

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 07:32 AM, Sakari Ailus wrote: Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: Em Sat, 11 Mar 2017 12:32:43 +0100 Hans Verkuil escreveu: On 10/03/17 16:09, Mauro Carvalho Chehab wrote: Em Fri, 10 Mar 2017 13:54:28

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:08:23AM -0800, Steve Longerbeam wrote: On 03/11/2017 07:32 AM, Sakari Ailus wrote: Hi Mauro and Hans, On Sat, Mar 11, 2017 at 10:14:08AM -0300, Mauro Carvalho Chehab wrote: Em Sat, 11 Mar 2017 12:32:43 +0100

Re: [PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

On 03/11/2017 05:41 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:52:58PM -0800, Steve Longerbeam wrote: If the pads on both sides of a link specify a frame interval, then those frame intervals should match. Create the exported function v4l2_subdev_link_validate_frame_interval

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/11/2017 03:39 AM, Hans Verkuil wrote: On 10/03/17 19:37, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured

Re: [PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

On 03/11/2017 05:49 AM, Sakari Ailus wrote: Hi Steve, On Thu, Mar 09, 2017 at 08:53:01PM -0800, Steve Longerbeam wrote: Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> The existing V4L2 UAPI headers are under includ

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/11/2017 10:51 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:14:49AM -0800, Steve Longerbeam wrote: On 03/11/2017 03:39 AM, Hans Verkuil wrote: It's fine to use an internal event as long as the end-user doesn't see it. But if you lose vsyncs, then you never capture

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has no indication the error

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 03:14 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 08:25:49AM -0300, Mauro Carvalho Chehab wrote: This situation is there since 2009. If I remember well, you tried to write such generic plugin in the past, but never finished it, apparently because it is too

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM Linux wrote: I really don't think expecting the user to understand and configure the pipeline is a sane way forward. Think

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote: If it's too difficult to get the imx219 csi-2 transmitter into the LP-11 state on power on, perhaps the csi-2 receiver can be a little more lenient on the transmitter

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link multiple times, and imx_media_link_notify() complies, and so csi_s_power(OFF) gets called multiple times

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 12:47 PM, Russell King - ARM Linux wrote: Another issue. The "reboot and the /dev/video* devices come up in a completely different order" problem seems to exist with this version. The dot graph I supplied previously had "ipu1_csi0 capture" on /dev/video4. I've just rebooted,

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 01:16 PM, Steve Longerbeam wrote: On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually nothing preventing userland from disabling a link multiple times, and imx_media_link_notify() complies

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 01:36 PM, Steve Longerbeam wrote: On 03/12/2017 01:16 PM, Steve Longerbeam wrote: On 03/12/2017 12:44 PM, Steve Longerbeam wrote: On 03/12/2017 12:29 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 12:21:45PM -0700, Steve Longerbeam wrote: There's actually

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/11/2017 11:37 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 07:31:18PM -0800, Steve Longerbeam wrote: On 03/11/2017 10:59 AM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 10:54:55AM -0800, Steve Longerbeam wrote: On 03/11/2017 10:45 AM, Russell King - ARM

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 10:51 AM, Russell King - ARM Linux wrote: I've just looked at my test system's dmesg, and spotted this in the log. It's been a while since these popped out of the kernel, so I don't know what caused them (other than the obvious, a media-ctl command.) My script which sets this up

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:05:06PM -0700, Steve Longerbeam wrote: On 03/12/2017 12:57 PM, Russell King - ARM Linux wrote: On Sat, Mar 11, 2017 at 04:30:53PM -0800, Steve Longerbeam wrote: If it's too difficult to get the imx219 csi-2

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/10/2017 03:30 PM, Pavel Machek wrote: On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured

Re: [PATCH v5 00/39] i.MX Media Driver

er, I meant I will integrate this patch. And verify/fix possible breakage for non-bayer passthrough. Steve On 03/13/2017 02:30 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 08:16:25AM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/13/2017 01:16 AM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 09:26:41PM -0700, Steve Longerbeam wrote: On 03/12/2017 01:22 PM, Russell King - ARM Linux wrote: What I had was this patch for your v3. I never got to testing your v4 because of the LP-11 problem. In v5

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

On 03/13/2017 06:55 AM, Philipp Zabel wrote: On Mon, 2017-03-13 at 13:27 +, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 03:16:48PM +0200, Sakari Ailus wrote: The vast majority of existing drivers do not implement them nor the user space expects having to set them. Making that

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/13/2017 10:10 AM, Hans Verkuil wrote: On 03/13/2017 06:06 PM, Steve Longerbeam wrote: On 03/13/2017 03:53 AM, Hans Verkuil wrote: On 03/13/2017 11:45 AM, Russell King - ARM Linux wrote: On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/14/2017 09:21 AM, Nicolas Dufresne wrote: Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: On 03/11/2017 07:14 PM, Steve Longerbeam wrote: The event must be user visible, otherwise the user has

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

On 03/14/2017 09:47 AM, Russell King - ARM Linux wrote: On Tue, Mar 14, 2017 at 12:21:31PM -0400, Nicolas Dufresne wrote: My main concern here based on what I'm reading, is that this driver is not even able to notice immediately that a produced frame was corrupted (because it's out of sync).

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 03:10 PM, Mauro Carvalho Chehab wrote: Em Sun, 12 Mar 2017 21:13:24 + Russell King - ARM Linux escreveu: On Sun, Mar 12, 2017 at 05:59:28PM -0300, Mauro Carvalho Chehab wrote: Yet, udev/systemd has some rules that provide an unique name for V4L

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/12/2017 02:09 PM, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 08:40:37PM +, Russell King - ARM Linux wrote: On Sun, Mar 12, 2017 at 01:36:32PM -0700, Steve Longerbeam wrote: But hold on, if my logic is correct, then why did the CSI power-off get reached in your case

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

On 03/04/2017 02:56 AM, Sakari Ailus wrote: Hi Steve, On Fri, Mar 03, 2017 at 02:43:51PM -0800, Steve Longerbeam wrote: On 03/03/2017 03:45 AM, Sakari Ailus wrote: On Thu, Mar 02, 2017 at 03:07:21PM -0800, Steve Longerbeam wrote: On 03/02/2017 07:53 AM, Sakari Ailus wrote: Hi Steve

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/02/2017 03:48 PM, Steve Longerbeam wrote: On 03/02/2017 08:02 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

On 03/02/2017 07:53 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:15PM -0800, Steve Longerbeam wrote: Add a new FRAME_TIMEOUT event to signal that a video capture or output device has timed out waiting for reception or transmit completion of a video frame. Signed-off

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/02/2017 08:02 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam <steve_long

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

On 03/02/2017 03:48 PM, Steve Longerbeam wrote: On 03/02/2017 08:02 AM, Sakari Ailus wrote: Hi Steve, On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video

Re: [PATCH v6 19/39] media: Add i.MX media core driver

On 04/06/2017 02:43 AM, Philipp Zabel wrote: On Mon, 2017-03-27 at 17:40 -0700, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> [...] diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging

Re: [PATCH] [media] staging/imx: always select VIDEOBUF2_DMA_CONTIG

Thanks, Reviewed-by: Steve Longerbeam <steve_longerb...@mentor.com> Steve On 08/07/2017 03:49 AM, Arnd Bergmann wrote: I ran into a rare build error during randconfig testing: drivers/staging/media/imx/imx-media-capture.o: In function `capture_stop_streaming': imx-media-capture.c:

Re: [PATCH] [media] media: imx: use setup_timer

Thanks, Reviewed-by: Steve Longerbeam <steve_longerb...@mentor.com> Tested-by: Steve Longerbeam <steve_longerb...@mentor.com> Steve On 08/13/2017 11:39 AM, Cihangir Akturk wrote: Use setup_timer function instead of initializing timer with the function and data fields. Generated

Re: [PATCH 6/6] [media] media: imx: capture: constify vb2_ops structures

Thanks, Reviewed-by: Steve Longerbeam <steve_longerb...@mentor.com> Steve On 08/05/2017 03:47 AM, Julia Lawall wrote: These vb2_ops structures are only stored in the ops field of a vb2_queue structure, which is declared as const. Thus the vb2_ops structures themselves can be const.

Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API

Hi Akturk, this has already been fixed, see 4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency"). Steve On 08/14/2017 04:00 AM, Cihangir Akturk wrote: This driver uses various v4l2_subdev_get_try_*() functions provided by V4L2 sub-device userspace API. Current configuration of

Re: [PATCH v2] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

d Bergmann <a...@arndb.de> --- v2: fix type mismatch v3: rework of_parse_subdev() as well. Thanks! Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> Tested-by: Philipp Zabel <p.za...@pengutronix.de> Looks fine to me. Tested on SabreAuto with affected pipelines. Reviewed-by: Ste

Re: [PATCH] [media] imx: csi: enable double write reduction

Hi Philipp, On 07/19/2017 05:22 AM, Philipp Zabel wrote: For 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write memory bandwidth by 25%. Signed-off-by: Philipp Zabel ---

Re: [PATCH] [media] ov5640: Remove unneeded gpiod NULL check

Acked-by: Steve Longerbeam <steve_longerb...@mentor.com> On 07/19/2017 07:41 PM, Fabio Estevam wrote: From: Fabio Estevam <fabio.este...@nxp.com> The gpiod API checks for NULL descriptors, so there is no need to duplicate the check in the driver. Signed-off-by: Fabio Estevam

[PATCH] media: imx: prpencvf: enable double write reduction

For the write channels with 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write memory bandwidth by at least 25% (more with rotation enabled). Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> --- drivers/staging

Re: [PATCH] [media] imx: add VIDEO_V4L2_SUBDEV_API dependency

Acked-by: Steve Longerbeam <steve_longerb...@mentor.com> On 07/21/2017 09:21 AM, Arnd Bergmann wrote: Without this, I get a build error: drivers/staging/media/imx/imx-media-vdic.c: In function '__vdic_get_fmt': drivers/staging/media/imx/imx-media-vdic.c:554:10: error: implicit decla

Re: [PATCH] media: imx: prpencvf: enable double write reduction

duplicate U/V samples on the bus in the first place? Anyway, thanks for the heads-up on this. Steve On 07/22/2017 02:21 PM, Steve Longerbeam wrote: For the write channels with 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write

<    1   2   3   4   5   6   7   8   9   10   >