Hi Sam,
On 04/16/2018 05:26 AM, Hans Verkuil wrote:
On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote:
Can anyone verify if the OV5640 driver works with input clocks other
than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
is acceptable, but I am running into issues while
On 04/23/2018 12:14 AM, Sakari Ailus wrote:
Hi Steve,
On Tue, Mar 20, 2018 at 05:37:21PM -0700, Steve Longerbeam wrote:
Adds v4l2_async_register_fwnode_subdev(), which is a convenience function
for parsing a sub-device's fwnode port endpoints for connected remote
sub-devices, registering
Hi Sakari, Hans, Mauro,
What is the status on this patch-set?
Thanks,
Steve
On 03/20/2018 05:37 PM, Steve Longerbeam wrote:
This patchset converts the imx-media driver and its dependent
subdevs to use subdev notifiers.
There are a couple shortcomings in v4l2-core that prevented
subdev
Reviewed-by: Steve Longerbeam <steve_longerb...@mentor.com>
On 03/15/2018 12:13 PM, Peter Seiderer wrote:
- enables gstreamer v4l2src lost frame detection, e.g:
0:00:08.685185668 348 0x54f520 WARN v4l2src
gstv4l2src.c:970:gst_v4l2src_create: lost frames detected: count =
141 -
Reviewed-by: Steve Longerbeam <steve_longerb...@mentor.com>
On 03/15/2018 12:13 PM, Peter Seiderer wrote:
- fixes gstreamer v4l2src warning:
0:00:00.716640334 349 0x164f720 WARN v4l2bufferpool
gstv4l2bufferpool.c:1195:gst_v4l2_buffer_pool_dqbuf: Driver
should nev
Hi Sakari,
Thanks for the review...
On 03/15/2018 02:30 AM, Sakari Ailus wrote:
Hi Steve,
Thanks for the patchset. Please see my comments below.
On Sat, Mar 10, 2018 at 11:58:31AM -0800, Steve Longerbeam wrote:
Generalize v4l2_async_notifier_fwnode_has_async_subdev() to allow
searching
Rename the imx-media root async notifier from "subdev_notifier" to
simply "notifier", so as not to confuse it with true subdev notifiers.
No functional changes.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
drivers/staging/medi
because imx_media_create_of_links() checks if a fwnode link already
exists before creating.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
drivers/staging/media/imx/imx-media-dev.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/s
, or keeping an internal master asd_list, since this is
moved to the notifier's asd_list.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
drivers/staging/media/imx/imx-media-dev.c | 110 ++
drivers/staging/media/imx/imx-media-internal-sd.c | 5 +-
d
The move to subdev notifiers fixes one assumption of OF graph parsing.
If a subdevice has non-video related ports, the subdev driver knows not
to follow those ports when adding remote devices to its subdev notifier.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
d
to the imx-media
root notifier.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
drivers/staging/media/imx/imx-media-of.c | 106 +++
1 file changed, 8 insertions(+), 98 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-of.c
b/drivers/s
Generalize v4l2_async_notifier_fwnode_has_async_subdev() to allow
searching for any type of async subdev, not just fwnodes. Rename to
v4l2_async_notifier_has_async_subdev() and pass it an asd pointer.
TODO: support asd compare with CUSTOM match type in asd_equal().
Signed-off-by: Steve
.
The remaining patches update the subdev drivers to register a
subdev notifier with endpoint parsing, and the changes to imx-media
to support that.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
Acked-by: Philipp Zabel <p.za...@pengutronix.de>
History:
v3:
- code
with the subdevs array allocated.
In v4l2_async_notifier_has_async_subdev(), __v4l2_async_notifier_register(),
and v4l2_async_notifier_cleanup(), alternatively operate on the subdevs
array or a non-empty notifier->asd_list.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
--
s[] array,
(in the notifier completion callback), so that driver has been
modified to iterate through the notifier->asd_list instead.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 10 +--
drivers/media/v4l2-core/v4l2-async.c
Adds v4l2_async_register_fwnode_subdev(), which is a convenience function
for parsing a sub-device's fwnode port endpoints for connected remote
sub-devices, registering a sub-device notifier, and then registering
the sub-device itself.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.
Parse neighbor remote devices on the CSI port, add them to a subdev
notifier, and register the subdev notifier for the CSI, by calling
v4l2_async_register_fwnode_subdev().
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
drivers/staging/media/imx/imx-media-csi.
and return 0.
__v4l2_async_notifier_parse_fwnode_endpoints() will then continue
parsing the remaining port endpoints of the device.
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
Changes since v2:
- none
Changes since v1:
- don't pass an empty endpoint to the parse_endpoint ca
Parse neighbor remote devices on the video muxes input ports, add them to a
subdev notifier, and register the subdev notifier for the video mux, by
calling v4l2_async_register_fwnode_subdev().
Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
---
Changes since v2:
- none
Changes
Parse neighbor remote devices on the MIPI CSI-2 input port, add
them to a subdev notifier, and register the subdev notifier for the
MIPI CSI-2 receiver, by calling v4l2_async_register_fwnode_subdev().
csi2_parse_endpoints() is modified to be the parse_endpoint callback.
Signed-off-by: Steve
_default() error.
devm_pinctrl_get_select_default() may return -ENODEV when the CSI pinctrl
entry is not found, so better not to propagate the error in the -ENODEV
case to avoid a regression.
Suggested-by: Philipp Zabel <p.za...@pengutronix.de>
Signed-off-by: Fabio Estevam <fabio.este...@nxp.com>
R
osition
gpu: ipu-v3: image-convert: disable double buffering if necessary
gpu: ipu-v3: image-convert: allow three rows or columns
Steve Longerbeam (1):
gpu: ipu-cpmem: add WARN_ON_ONCE() for unaligned dma buffers
drivers/gpu/ipu-v3/ipu-cpmem.c| 6 +
drivers/gpu/
On 09/18/2018 02:34 AM, Philipp Zabel wrote:
+/*
+ * Tile left edges are required to be aligned to multiples of 8 bytes
+ * by the IDMAC.
+ */
+static inline u32 tile_left_align(const struct ipu_image_pixfmt *fmt)
+{
+ return fmt->planar ? 8 * fmt->uv_width_dec : 64 / fmt->bpp;
+}
alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Steve Longerbeam (12):
media: videodev2.h: Add more field helper macros
gpu: ipu-csi: Swap fields according to input/output field types
gpu: ipu-v3: Add planar
type is
'interlaced', that is a full frame is transmitted, or exists in
memory, as top field lines interlaced with bottom field lines.
Signed-off-by: Steve Longerbeam
---
Changes since v3:
- none
Changes since v2:
- none
Changes since v1:
- add the complement macro V4L2_FIELD_IS_INTERLACED
- remove
Awesome, thanks Philipp.
For the whole series:
Acked-by: Steve Longerbeam
Tested-by: Steve Longerbeam
on i.MX6q SabreSD.
On 10/19/18 5:15 AM, Philipp Zabel wrote:
Hi,
this is the fourth version of the i.MX mem2mem scaler series.
An alignment issue with 24-bit RGB formats has been
On 10/19/18 2:53 AM, Philipp Zabel wrote:
Hi Tim,
On Thu, 2018-10-18 at 15:53 -0700, Tim Harvey wrote:
[...]
Philipp,
Thanks for submitting this!
I'm hoping this lets us use non-IMX capture devices along with the IMX
media controller entities to so we can use hardware
On 10/18/18 10:56 AM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 4:37 PM Steve Longerbeam wrote:
On 10/17/18 4:05 PM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 2:33 PM Steve Longerbeam wrote:
Hi Tim,
On 10/17/18 1:38 PM, Tim Harvey wrote:
On Mon, Jun 4, 2018 at 1:58 AM Krzysztof Hałasa
On 10/17/18 4:10 AM, Philipp Zabel wrote:
On Fri, 2018-10-12 at 17:33 -0700, Steve Longerbeam wrote:
On 09/18/2018 02:34 AM, Philipp Zabel wrote:
+/*
+ * Tile left edges are required to be aligned to multiples of 8 bytes
+ * by the IDMAC.
+ */
+static inline u32 tile_left_align(const
On 10/17/18 4:05 PM, Tim Harvey wrote:
On Wed, Oct 17, 2018 at 2:33 PM Steve Longerbeam wrote:
Hi Tim,
On 10/17/18 1:38 PM, Tim Harvey wrote:
On Mon, Jun 4, 2018 at 1:58 AM Krzysztof Hałasa wrote:
I've just tested the PAL setup: in currect situation (v4.17 + Steve's
fix-csi-interlaced.2
Hi Philipp,
On 10/12/18 5:29 PM, Steve Longerbeam wrote:
But one last thing. Conversions to and from YV12 are producing images
with wrong colors, it looks like the .uv_swapped boolean needs to be
checked
additionally somewhere. Any ideas?
Sorry, this was my fault. I fixed this in
&quo
Hi Jean-Michel,
We've done some work with another FPD-Link de-serializer (ds90ux940) and
IIRC we had some trouble figuring out how to coax the lanes into LP-11
state. But on the ds90ux940 it can be done by setting bit 7 in the CSI
Enable Port registers (offsets 0x13 and 0x14). But the
(resending as plain text)
On 10/21/18 10:43 AM, Philipp Zabel wrote:
On Fri, Oct 19, 2018 at 01:19:10PM -0700, Steve Longerbeam wrote:
On 10/19/18 2:53 AM, Philipp Zabel wrote:
Hi Tim,
On Thu, 2018-10-18 at 15:53 -0700, Tim Harvey wrote:
[...]
Philipp,
Thanks for submitting this!
I'm
Hi Philipp,
Thanks, I've been meaning this too. Comments below.
On 11/5/18 7:03 AM, Philipp Zabel wrote:
While subdevice and video device are in the same pipeline, pass
subdevice events on to userspace via the video device node.
Signed-off-by: Philipp Zabel
---
This would allow to see
Hi Philipp,
On 11/5/18 7:20 AM, Philipp Zabel wrote:
Prepare for mbus format being smaller than the written rectangle
due to burst size.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-capture.c | 55 +--
1 file changed, 38 insertions(+), 17
Hi Philipp,
On 11/5/18 7:20 AM, Philipp Zabel wrote:
Allowing to compose captured images into larger memory buffers
will let us lift alignment restrictions on CSI crop width.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-ic-prpencvf.c | 3 +-
On 11/5/18 7:20 AM, Philipp Zabel wrote:
The CSI subdevice shouldn't have to care about IDMAC line start
address alignment. With compose rectangle support in the capture
driver, it doesn't have to anymore.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-capture.c | 9
On 11/9/18 6:50 AM, Philipp Zabel wrote:
On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote:
On 11/5/18 7:20 AM, Philipp Zabel wrote:
The CSI subdevice shouldn't have to care about IDMAC line start
address alignment. With compose rectangle support in the capture
driver, it doesn't
On 10/04/2018 06:41 AM, Hans Verkuil wrote:
On 10/04/18 01:21, Steve Longerbeam wrote:
Hi Hans,
On 10/01/2018 03:07 AM, Hans Verkuil wrote:
Hi Steve,
On 08/01/2018 09:12 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source
On 10/04/2018 12:34 PM, Hans Verkuil wrote:
On 10/04/2018 08:53 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
History:
v4:
- rebased
.
- fix bug with resetting crop/compose rectangles.
- add a patch that fixes a field order bug in VDIC indirect mode.
- remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
Suggested-by: Nicolas Dufresne .
- add macro V4L2_FIELD_IS_INTERLACED().
Steve Longerbeam (11):
media: videodev2
stripped from v4l2-async and v4l2-subdev
docs are updated to reflect the new method of adding asd's to notifiers.
Signed-off-by: Steve Longerbeam
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
Patches 01-14 are
Tested-by: Philipp Zabel
on i.MX6 with Toshiba
stripped from v4l2-async and v4l2-subdev
docs are updated to reflect the new method of adding asd's to notifiers.
Signed-off-by: Steve Longerbeam
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
Patches 01-14 are
Tested-by: Philipp Zabel
on i.MX6 with Toshiba
, or keeping an internal master asd_list, since this is
moved to the notifier's asd_list.
Signed-off-by: Steve Longerbeam
---
Changes since v6:
- none
Changes since v5:
- remove reference to notifier.num_subdevs and call
v4l2_async_notifier_init(). Suggested by Sakari Ailus.
---
drivers/staging
and return 0.
__v4l2_async_notifier_parse_fwnode_endpoints() will then continue
parsing the remaining port endpoints of the device.
Signed-off-by: Steve Longerbeam
Acked-by: Hans Verkuil
---
Changes since v6:
- none
Changes since v5:
- none
Changes since v4:
- none
Changes since v3:
- none
Changes
Hi Hans,
On 10/01/2018 03:07 AM, Hans Verkuil wrote:
Hi Steve,
On 08/01/2018 09:12 PM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
I reviewed
On 12/5/18 10:50 AM, Hans Verkuil wrote:
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
+{
+ struct mem2mem_priv *priv
17/2018 02:00 AM, Steve Longerbeam wrote:
A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.
History:
v5:
- Added a regression fix to allow empty endpoints to CSI (fix for imx6q
Hi Hans,
On 12/6/18 4:32 AM, Hans Verkuil wrote:
On 12/06/18 00:13, Steve Longerbeam wrote:
On 12/5/18 10:50 AM, Hans Verkuil wrote:
On 12/05/2018 02:20 AM, Steve Longerbeam wrote:
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void
Hi Hans, Philipp,
One comment on my side...
On 12/3/18 7:21 AM, Hans Verkuil wrote:
+void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev)
+{
+ struct mem2mem_priv *priv = to_mem2mem_priv(vdev);
+ struct video_device *vfd = priv->vdev.vfd;
+
+
Hi Fabio,
On 11/22/18 11:17 AM, Fabio Estevam wrote:
Hi Philipp,
On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel wrote:
There are empty endpoint nodes (without remote-endpoint property)
labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees
for board DT implementers'
Reviewed-by: Steve Longerbeam
On 11/23/18 4:50 AM, Fabio Estevam wrote:
On a imx6q-wandboard the following warnings are observed:
[4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote port
parent
[4.336118] video-mux 20e.iomuxc-gpr:ipu2_csi1_mux: bad remote port
the static register value table
has been sent to the sensor in the ov5640_load_regs() function.
Fixes: 476dec012f4c ("media: ov5640: Add horizontal and vertical totals")
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
Acked-by: Steve Longerbeam
Tes
MIPI capture often failed and returned all-purple frames.
fixes: f22996db44e2 ("media: ov5640: add support of DVP parallel interface")
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
Acked-by: Steve Longerbeam
Tested-by: Loic Poulain
on Dragonboard-410c
Hi Hughes,
The whole series,
Acked-by: Steve Longerbeam
and
Tested-by: Steve Longerbeam
on i.MX6q SabreSD with MIPI CSI-2 OV5640 module
On 09/11/2018 06:48 AM, Hugues Fruchet wrote:
This patch serie fixes some problems around exposure & gain in OV5640 driver.
The 4th patch a
-by: Steve Longerbeam
---
drivers/staging/media/imx/imx-media-utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-utils.c
b/drivers/staging/media/imx/imx-media-utils.c
index 8aa13403b09d..0eaa353d5cb3 100644
--- a/drivers/staging/media
.
Signed-off-by: Marek Vasut
Cc: Steve Longerbeam
Cc: Philipp Zabel
Steve, Philipp,
I saw there was a discussion about this patch, but no clear answer whether
or not this patch is OK. If it is, then please Ack this patch.
Marking this patch as Obsoleted since I have no seen any activity for a long
Vasut
Cc: Philipp Zabel
Cc: Steve Longerbeam
Same here, I cannot merge with out Acks since I don't know the details
of the imx hardware.
I'm marking this patch as Obsoleted since there has been no activity for a long
time.
Hi Hans, yes that's fine. IIRC this issue has been fixed a different w
901 - 958 of 958 matches
Mail list logo