Re: Remaining BKL users, what to do

2010-09-16 Thread Steven Rostedt
On Thu, 2010-09-16 at 16:32 +0200, Arnd Bergmann wrote: The big kernel lock is gone from almost all code in linux-next, this is the status of what I think will happen to the remaining users: kernel/trace/blktrace.c: Should be easy. Ingo? Steven? Jens, Git blame shows this to be your

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-18 Thread Steven Rostedt
On Tue, 2010-10-19 at 12:45 +1000, Dave Airlie wrote: On Tue, Oct 19, 2010 at 12:24 PM, Greg KH g...@kroah.com wrote: So, there is no need for the i830 driver? Can it just be removed because i915 works instead? No because it provides a different userspace ABI to the i915 driver to a

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-19 Thread Steven Rostedt
On Tue, 2010-10-19 at 09:26 +0200, Arnd Bergmann wrote: On Tuesday 19 October 2010 06:52:32 Dave Airlie wrote: I might be able to find some hardware still lying around here that uses an i810. Not sure unless I go hunting it. But I get the impression that if the kernel is a single-CPU

Re: Failed build on randconfig for DVB_DIB modules

2010-11-12 Thread Steven Rostedt
Sorry for the late reply, but KS and LPC got in the way. Also added kbuild to the Cc. On Tue, 2010-10-26 at 09:37 -0200, Mauro Carvalho Chehab wrote: Hi Steven, Em 26-10-2010 02:15, Steven Rostedt escreveu: I'm currently finishing up an automated test program (that I will be publishing

Re: Failed build on randconfig for DVB_DIB modules

2010-11-12 Thread Steven Rostedt
On Fri, 2010-11-12 at 22:54 -0500, Steven Rostedt wrote: Or we just don't test for define(MODULE). If either CONFIG_DVB_DIB3000MC or CONFIG_DVB_DIB3000MC_MODULE are defined, the code must be there, because, if this code is built as both a module and builtin, only the builtin will be created

[PATCH] saa7134: Fix strange kconfig dependency on RC_CORE

2011-03-10 Thread Steven Rostedt
-by: Mauro Carvalho Chehab mche...@redhat.com Cc: Michal Marek mma...@suse.cz Cc: linux-kbuild linux-kbu...@vger.kernel.org Signed-off-by: Steven Rostedt rost...@goodmis.org --- drivers/media/video/saa7134/Kconfig |1 + 1 file changed, 1 insertion(+) Index: linux-test.git/drivers/media/video/saa7134

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Steven Rostedt
On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote: On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long end, + gfp_t flag) +{ + unsigned long pfn =

Re: [PATCH 05/12] mm: alloc_contig_range() added

2011-03-31 Thread Steven Rostedt
On Thu, Mar 31, 2011 at 09:02:41AM -0700, Dave Hansen wrote: On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: + ret = 0; + while (!PageBuddy(pfn_to_page(start (~0UL ret + if (WARN_ON(++ret = MAX_ORDER)) + return -EINVAL;

Re: [PATCH 05/12] mm: alloc_contig_range() added

2011-03-31 Thread Steven Rostedt
On Thu, Mar 31, 2011 at 06:26:45PM +0200, Michal Nazarewicz wrote: In any case, please pull the ++ret bit out of the WARN_ON(). Some people like to do: #define WARN_ON(...) do{}while(0) to save space on some systems. I don't think that's the case. Even if WARN_ON() decides not to

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Tue, Apr 02, 2013 at 06:59:14PM +0200, Peter Zijlstra wrote: So how about we call the thing something like: struct ww_mutex; /* wound/wait */ Reading this I can't help but think of Elmer Fudd saying Round Robin as Wound Wobin -- Steve int mutex_wound_lock(struct ww_mutex *); /*

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Thu, Apr 04, 2013 at 06:38:36PM +0200, Peter Zijlstra wrote: On Thu, 2013-04-04 at 15:31 +0200, Daniel Vetter wrote: Hm, I guess your aim with the TASK_DEADLOCK wakeup is to bound the wait times of older task. No, imagine the following: struct ww_mutex A, B; struct mutex C;

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Thu, Apr 04, 2013 at 06:41:02PM +0200, Peter Zijlstra wrote: On Thu, 2013-04-04 at 15:31 +0200, Daniel Vetter wrote: The thing is now that you're not expected to hold these locks for a long time - if you need to synchronously stall while holding a lock performance will go down the

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Thu, Apr 04, 2013 at 06:56:58PM +0200, Daniel Vetter wrote: I think for starters we need to have a slightly more interesting example: 3 threads O, M, Y: O has the oldest ww_age/ticket, Y the youngest, M is in between. 2 ww_mutexes: A, B Y has already acquired ww_mutex A, M has

Re: [PATCH] [RFC] mutex: w/w mutex slowpath debugging

2013-04-30 Thread Steven Rostedt
On Tue, 2013-04-30 at 20:45 +0200, Daniel Vetter wrote: /** diff --git a/kernel/mutex.c b/kernel/mutex.c index 66807c7..1cc3487 100644 --- a/kernel/mutex.c +++ b/kernel/mutex.c @@ -827,6 +827,35 @@ int __sched mutex_trylock(struct mutex *lock) EXPORT_SYMBOL(mutex_trylock); #ifndef

Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-10 Thread Steven Rostedt
On Thu, Sep 10, 2009 at 09:30:03AM -0600, Jonathan Corbet wrote: On Thu, 10 Sep 2009 18:37:34 + iceberg str...@ispras.ru wrote: In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: Mutex must be unlocked before exit 1. On paths starting with mutex lock in line 1912,

Re: [RESUBMIT] [PATCH] Replace mentions of list_struct to list_head

2014-11-13 Thread Steven Rostedt
On Fri, 14 Nov 2014 05:09:55 +0400 Andrey Utkin andrey.krieger.ut...@gmail.com wrote: There's no such thing as list_struct. I guess there isn't. Signed-off-by: Andrey Utkin andrey.krieger.ut...@gmail.com Acked-by: Steven Rostedt rost...@goodmis.org -- Steve --- drivers/gpu/drm/radeon

Re: [PATCH 2/2] [media] videobuf2: add trace events

2015-06-25 Thread Steven Rostedt
On Thu, 25 Jun 2015 12:01:27 +0200 Philipp Zabel p.za...@pengutronix.de wrote: diff --git a/include/trace/events/v4l2.h b/include/trace/events/v4l2.h index 89d0497..3d15cf1 100644 --- a/include/trace/events/v4l2.h +++ b/include/trace/events/v4l2.h @@ -175,9 +175,108 @@ SHOW_FIELD

Re: [PATCH v3 3/3] [media] videobuf2: add trace events

2015-08-03 Thread Steven Rostedt
On Tue, 28 Jul 2015 09:53:20 +0200 Philipp Zabel p.za...@pengutronix.de wrote: I tried this yesterday and failed to figure out a satisfactory way to do it since the vb2 trace point macros reuse the v4l2 enum definitions and __print_symbolic/flags macros. The alternative would be to just

[PATCH] cx231xx: Use wake_up_interruptible() instead of wake_up_interruptible_nr()

2015-08-20 Thread Steven Rostedt
even remove the function wake_up_interruptible_nr(). Signed-off-by: Steven Rostedt rost...@goodmis.org --- diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c index c6ff896..9798160 100644 --- a/drivers/media/usb/cx231xx/cx231xx-video.c +++ b/drivers

Re: [PATCH] [media] v4l2: move tracepoint generation into separate file

2015-08-06 Thread Steven Rostedt
: __tracepoint_vb2_buf_queue undefined! Suggested-by: Steven Rostedt rost...@goodmis.org ;-) -- Steve Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [very-RFC 6/8] Add TSN event-tracing

2016-06-12 Thread Steven Rostedt
Miller" <da...@davemloft.net> > Cc: Steven Rostedt <rost...@goodmis.org> (maintainer:TRACING) > Cc: Ingo Molnar <mi...@redhat.com> (maintainer:TRACING) > Signed-off-by: Henrik Austad <haus...@cisco.com> > --- > include/trace/events/tsn.h | 349 &g

Re: [very-RFC 6/8] Add TSN event-tracing

2016-06-12 Thread Steven Rostedt
On Sun, 12 Jun 2016 23:25:10 +0200 Henrik Austad wrote: > > > +#include > > > +#include > > > +/* #include */ > > > + > > > +/* FIXME: update to TRACE_CLASS to reduce overhead */ > > > > I'm curious to why I didn't do this now. A class would make less > > duplication of