Re: [RFC v3 03/13] [media] exynos5-fimc-is: Add driver core files

2013-08-03 Thread Sylwester Nawrocki
On 08/02/2013 05:02 PM, Arun Kumar K wrote: This driver is for the FIMC-IS IP available in Samsung Exynos5 SoC onwards. This patch adds the core files for the new driver. Signed-off-by: Arun Kumar K Signed-off-by: Kilyeon Im --- drivers/media/platform/exynos5-is/fimc-is-core.c | 394 +

Re: [RFC v3 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-08-03 Thread Sylwester Nawrocki
e common video +interfaces bindings, defined in video-interfaces.txt. This one looks good to me. Feel free to add Reviewed-by: Sylwester Nawrocki I'm adding the Device Tree maintainers at Cc so we can possibly get their Ack. -- Thanks, Sylwester -- To unsubscribe from this list: se

Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-08-03 Thread Sylwester Nawrocki
and FIMC-LITE +device binding is defined in exynos-fimc-lite.txt. diff --git a/drivers/media/platform/exynos5-is/exynos5-mdev.c b/drivers/media/platform/exynos5-is/exynos5-mdev.c new file mode 100644 index 000..b59738f --- /dev/null +++ b/drivers/media/platform/exynos5-is/exynos5-mdev.c @@ -

Re: [RFC v3 00/13] Exynos5 IS driver

2013-08-03 Thread Sylwester Nawrocki
Hi Arun, On 08/02/2013 05:02 PM, Arun Kumar K wrote: The patch series add support for Exynos5 camera subsystem. It re-uses mipi-csis and fimc-lite from exynos4-is and adds a new media device and fimc-is device drivers for exynos5. The media device supports asynchronos subdev registration for the

Re: [RFC v2 06/10] exynos5-fimc-is: Adds isp subdev

2013-08-03 Thread Sylwester Nawrocki
Hi Arun, On 08/02/2013 06:31 AM, Arun Kumar K wrote: [...] + * Video node ioctl operations + */ +static int isp_querycap_output(struct file *file, void *priv, + struct v4l2_capability *cap) +{ + strncpy(cap->driver, ISP_DRV_NAME, sizeof(cap->driver) -

[GIT PULL FOR 3.11] Exynos/S5P fixes

2013-08-02 Thread Sylwester Nawrocki
bayer formats exynos-gsc: Register v4l2 device Sachin Kamat (1): s5p-g2d: Fix registration failure Sylwester Nawrocki (1): exynos4-is: Fix entity unregistration on error path drivers/media/platform/exynos-gsc/gsc-core.c |9 - drivers/media/platform/exynos-gsc/gsc

[PATCH] V4L: Drop meaningless video_is_registered() call in v4l2_open()

2013-08-02 Thread Sylwester Nawrocki
mutex_unlock(vdev->lock); } Remove the remaining video_is_registered() call as it doesn't provide any real protection and just adds unnecessary overhead. The drivers need to perform the unregistration check themselves inside their file operation handlers, while holding respectiv

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-02 Thread Sylwester Nawrocki
Hi Vikas, On 08/02/2013 12:10 PM, Vikas Sajjan wrote: > yeah, we could not allocate CMA region for FIMD, because the function > dma_declare_contiguous() needs "dev" as the first argument and we have > access to "dev" node only if it is NON-DT way of probing like the way > it is done in arch/arm/ma

Re: [PATCH 3/3] [media] exynos4-is: Fix potential NULL pointer dereference

2013-08-02 Thread Sylwester Nawrocki
Hi Sachin, On 08/02/2013 08:32 AM, Sachin Kamat wrote: > dev->of_node could be NULL. Hence check for the same and return before > dereferencing it in the subsequent error message. > > Signed-off-by: Sachin Kamat > --- > drivers/media/platform/exynos4-is/fimc-lite.c |3 +++ > 1 file changed,

Re: [PATCH v4 5/7] v4l: Renesas R-Car VSP1 driver

2013-08-01 Thread Sylwester Nawrocki
Hi Laurent, On 08/01/2013 12:03 AM, Laurent Pinchart wrote: On Wednesday 31 July 2013 23:02:05 Sylwester Nawrocki wrote: On 07/31/2013 05:52 PM, Laurent Pinchart wrote: The VSP1 is a video processing engine that includes a blender, scalers, filters and statistics computation. Configurable

Re: [PATCH v4 5/7] v4l: Renesas R-Car VSP1 driver

2013-07-31 Thread Sylwester Nawrocki
Hi Laurent, just a few small remarks... On 07/31/2013 05:52 PM, Laurent Pinchart wrote: The VSP1 is a video processing engine that includes a blender, scalers, filters and statistics computation. Configurable data path routing logic allows ordering the internal blocks in a flexible way. Due to

[PATCH] v4l2-async: Use proper list head for iteration over registered subdevs

2013-07-31 Thread Sylwester Nawrocki
This fixes regression introduced in commit b426b3a660c85faf6e1ca1c92c6d [media] V4L: Merge struct v4l2_async_subdev_list with struct v4l2_subdev Signed-off-by: Sylwester Nawrocki --- drivers/media/v4l2-core/v4l2-async.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[GIT PULL] v4l2-async API updates

2013-07-29 Thread Sylwester Nawrocki
reference (2013-07-29 16:13:10 +0200) Sylwester Nawrocki (6): V4L: Drop bus_type check in v4l2-async match functions V4L: Rename v4l2_async_bus_* to v4l2_async_match_* V4L: Add V4L2_ASYNC_MATCH_OF subdev matching type

Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework

2013-07-29 Thread Sylwester Nawrocki
e documentation for dt binding can be found at > Documentation/devicetree/bindings/phy/phy-bindings.txt > > Cc: Tomasz Figa > Cc: Greg Kroah-Hartman > Signed-off-by: Kishon Vijay Abraham I > Acked-by: Felipe Balbi > Tested-by: Sylwester Nawrocki > --- >

Re: [GIT PULL] v4l2-async API updates

2013-07-29 Thread Sylwester Nawrocki
Mauro, please ignore this pull request, there is an issue in one patch. I'll re-send it fixed in a while. On 07/29/2013 02:02 PM, Sylwester Nawrocki wrote: > Hi Mauro, > > This includes a couple updates to the v4l2-async API: an addition > of a method of matching subdevs by

[GIT PULL] v4l2-async API updates

2013-07-29 Thread Sylwester Nawrocki
reference (2013-07-29 13:44:54 +0200) Sylwester Nawrocki (6): V4L: Drop bus_type check in v4l2-async match functions V4L: Rename v4l2_async_bus_* to v4l2_async_match_* V4L: Add V4L2_ASYNC_MATCH_OF subdev matching type

[PATCH] exynos4-is: Fix entity unregistration on error path

2013-07-29 Thread Sylwester Nawrocki
x2c/0x80) [ 78.02] [] (do_filp_open+0x2c/0x80) from [] (do_sys_open+0xf4/0x1a8) [ 78.025000] [] (do_sys_open+0xf4/0x1a8) from [] (ret_fast_syscall+0x0/0x30) [ 78.035000] Code: 1a93 e10f6000 f10c0080 e2845004 (e1953f9f) Reported-by: Andrzej Hajda Signed-off-by: Sylwester Nawro

Re: [REVIEW PATCH 4/6] exynos4-is: Add clock provider for the external clocks

2013-07-29 Thread Sylwester Nawrocki
Hi Arun, On 07/29/2013 07:52 AM, Arun Kumar K wrote: > Hi Sylwester, > > On Wed, Jul 24, 2013 at 12:09 AM, Sylwester Nawrocki > wrote: >> This patch adds clock provider to expose the sclk_cam0/1 clocks >> for image sensor subdevs. >> >> Signed-off-by:

Re: [PATCH] [media] exynos-gsc: Register v4l2 device

2013-07-29 Thread Sylwester Nawrocki
2m.c > @@ -751,6 +751,7 @@ int gsc_register_m2m_device(struct gsc_dev *gsc) > gsc->vdev.release = video_device_release_empty; > gsc->vdev.lock = &gsc->lock; > gsc->vdev.vfl_dir = VFL_DIR_M2M; > + gsc->vdev.v4l2_dev =

Re: [PATCH] mt9v032: Use the common clock framework

2013-07-26 Thread Sylwester Nawrocki
Hi Laurent, On 07/26/2013 03:15 PM, Laurent Pinchart wrote: On Friday 26 July 2013 15:11:08 Sylwester Nawrocki wrote: On 07/05/2013 12:55 PM, Laurent Pinchart wrote: Configure the device external clock using the common clock framework instead of a board code callback function. Signed-off-by

Re: [PATCH] mt9v032: Use the common clock framework

2013-07-26 Thread Sylwester Nawrocki
Hi Laurent, On 07/05/2013 12:55 PM, Laurent Pinchart wrote: Configure the device external clock using the common clock framework instead of a board code callback function. Signed-off-by: Laurent Pinchart --- drivers/media/i2c/mt9v032.c | 16 ++-- include/media/mt9v032.h | 4

Re: [PATCH] V4L: Add driver for Samsung S5K5BAF camera sensor

2013-07-25 Thread Sylwester Nawrocki
Hi Hans, On 07/25/2013 04:42 PM, Hans Verkuil wrote: > > Would it be an idea to create a library with rectangle manipulation functions? > Looking at this driver and similar ones as well that I had to deal with that > support cropping/scaling/composing I see a lot of rectangle manipulation. > > Mo

Re: [PATCH RFC 0/5] v4l2-async DT support improvement and cleanups

2013-07-25 Thread Sylwester Nawrocki
Hi Guennadi, On 07/24/2013 01:36 PM, Guennadi Liakhovetski wrote: > On Mon, 22 Jul 2013, Sylwester Nawrocki wrote: >> Hello, >> >> This is a few patches for the v4l2-async API I wrote while adding >> the asynchronous subdev registration support to the exynos4-i

Re: [PATCH RFC 4/5] V4L2: Rename subdev field of struct v4l2_async_notifier

2013-07-25 Thread Sylwester Nawrocki
Hi Gueannadi, On 07/24/2013 01:26 PM, Guennadi Liakhovetski wrote: > On Mon, 22 Jul 2013, Sylwester Nawrocki wrote: > >> > This is a purely cosmetic change. Since the 'subdev' member >> > points to an array of subdevs it seems more intuitive to name >> &g

Re: [PATCH RFC 3/5] V4L2: Add V4L2_ASYNC_MATCH_OF subdev matching type

2013-07-25 Thread Sylwester Nawrocki
Hi Guennadi, On 07/24/2013 01:21 PM, Guennadi Liakhovetski wrote: > Hi Sylwester > > On Mon, 22 Jul 2013, Sylwester Nawrocki wrote: > >> Add support for matching by device_node pointer. This allows >> the notifier user to simply pass a list of device_node pointers

Re: [PATCH RFC 0/5] v4l2-async DT support improvement and cleanups

2013-07-25 Thread Sylwester Nawrocki
On 07/24/2013 12:16 PM, Hans Verkuil wrote: > On Mon 22 July 2013 20:04:42 Sylwester Nawrocki wrote: >> Hello, >> >> This is a few patches for the v4l2-async API I wrote while adding >> the asynchronous subdev registration support to the exynos4-is >> driver. >

Re: [PATCH RFC 0/5] v4l2-async DT support improvement and cleanups

2013-07-25 Thread Sylwester Nawrocki
Hi Laurent, On 07/24/2013 12:06 PM, Laurent Pinchart wrote: > Hi Sylwester, > > Thanks for the patches. > > On Monday 22 July 2013 20:04:42 Sylwester Nawrocki wrote: >> Hello, >> >> This is a few patches for the v4l2-async API I wrote while adding >> the a

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Sylwester Nawrocki
On 07/24/2013 08:32 PM, Arnd Bergmann wrote: > On Tuesday 23 July 2013, Tomasz Figa wrote: >> On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: >>> On Tue, 23 Jul 2013, Tomasz Figa wrote: Where would you want to have those phy_address arrays stored? There are no board files when booti

Re: [PATCH v2 3/5] v4l: Add media format codes for ARGB8888 and AYUV8888 on 32-bit busses

2013-07-24 Thread Sylwester Nawrocki
/v4l/subdev-formats.xml @@ -97,31 +97,39 @@ [...] + + V4L2_MBUS_FMT_ARGB888_1X24 This should be V4L2_MBUS_FMT_ARGB888_1X32, right ? Fix this correction feel free to add: Reviewed-by: Sylwester Nawrocki + 0x100d + [...] diff --git a/include/uapi/linux/v4l2

Re: [PATCH v2 4/5] v4l: Add V4L2_PIX_FMT_NV16M and V4L2_PIX_FMT_NV61M formats

2013-07-24 Thread Sylwester Nawrocki
formats API. Signed-off-by: Laurent Pinchart Looks good, Reviewed-by: Sylwester Nawrocki Thanks, Sylwester --- Documentation/DocBook/media/v4l/pixfmt-nv16m.xml | 170 +++ Documentation/DocBook/media/v4l/pixfmt.xml | 1 + include/uapi/linux/videodev2.h

[PATCH] V4L: s5c73m3: Add device tree support

2013-07-24 Thread Sylwester Nawrocki
From: Andrzej Hajda This patch adds the V4L2 asychronous subdev registration and device tree support. Common clock API is used to control the sensor master clock from within the subdev driver. Signed-off-by: Sylwester Nawrocki Signed-off-by: Andrzej Hajda Signed-off-by: Kyungmin Park

[PATCH] V4L: s5c73m3: Add format propagation for TRY formats

2013-07-24 Thread Sylwester Nawrocki
From: Andrzej Hajda Resolution set on ISP pad of S5C73M3-OIF subdev should be propagated to source pad for TRY and ACTIVE formats. The patch adds missing propagation for TRY format. Signed-off-by: Andrzej Hajda Signed-off-by: Kyungmin Park Signed-off-by: Sylwester Nawrocki --- drivers/media

Re: [PATCH RFC 4/5] V4L2: Rename subdev field of struct v4l2_async_notifier

2013-07-24 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/23/2013 05:50 PM, Prabhakar Lad wrote: > On Mon, Jul 22, 2013 at 11:34 PM, Sylwester Nawrocki > wrote: >> This is a purely cosmetic change. Since the 'subdev' member >> points to an array of subdevs it seems more intuitive to name >> it i

Re: width and height of JPEG compressed images

2013-07-24 Thread Sylwester Nawrocki
Hi Thomas, On 07/22/2013 10:40 AM, Thomas Vajzovic wrote: > On 21 July 2013 21:38 Sylwester Nawrocki wrote: >> On 07/19/2013 10:28 PM, Sakari Ailus wrote: >>> On Sat, Jul 06, 2013 at 09:58:23PM +0200, Sylwester Nawrocki wrote: >>>> On 07/05/2013 10:22 AM, Thomas

Re: width and height of JPEG compressed images

2013-07-24 Thread Sylwester Nawrocki
Hi, On 07/24/2013 09:47 AM, Thomas Vajzovic wrote: > On 23 July 2013 23:21 Sakari Ailus wrote: >> On Sun, Jul 21, 2013 at 10:38:18PM +0200, Sylwester Nawrocki wrote: >>> On 07/19/2013 10:28 PM, Sakari Ailus wrote: >>>> On Sat, Jul 06, 2013 at 09:58:23PM +0200, Sylw

[REVIEW PATCH 5/6] exynos4-is: Use external s5k6a3 sensor driver

2013-07-23 Thread Sylwester Nawrocki
e and retrieved from the internal table, which is selected based on the compatible property of an image sensor. To use the Exynos4x12 internal ISP the S5K6A3 sensor driver (drivers/ media/i2c/s5k6a3.c) is now required. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/

[REVIEW PATCH 6/6] exynos4-is: Add support for asynchronous sensor subddevs registration

2013-07-23 Thread Sylwester Nawrocki
Add support registering external sensor subdevs using the v4l2-async API. The async API is used only for sensor subdevs and only for platforms instatiated from Device Tree. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 163

[REVIEW PATCH 4/6] exynos4-is: Add clock provider for the external clocks

2013-07-23 Thread Sylwester Nawrocki
This patch adds clock provider to expose the sclk_cam0/1 clocks for image sensor subdevs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- .../devicetree/bindings/media/samsung-fimc.txt | 17 +++- drivers/media/platform/exynos4-is/media-dev.c | 92

[REVIEW PATCH 2/6] V4L: s5k6a3: Add support for asynchronous subdev registration

2013-07-23 Thread Sylwester Nawrocki
This patch converts the driver to use v4l2 asynchronous subdev registration API an the common clock API. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/i2c/s5k6a3.c | 63 1 file changed, 52 insertions(+), 11

[REVIEW PATCH 1/6] V4L: Add driver for s5k6a3 image sensor

2013-07-23 Thread Sylwester Nawrocki
mware. This driver can be updated in future, should anyone need it to be a regular subdev driver where the main CPU communicates with the sensor directly. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/i2c/Kconfig |8 ++ drivers/media/i2c/Makefile |

[REVIEW PATCH 3/6] exynos4-is: Simplify sclk_cam clocks handling

2013-07-23 Thread Sylwester Nawrocki
: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c index 91f21e2

[REVIEW PATCH 0/6] exynos4-is: Asynchronous subdev registration support

2013-07-23 Thread Sylwester Nawrocki
ing this series before having a proper implementation for clk_unregister() in the clock framework, so you are not blocked with your Exynos5 FIMC-IS works. This series with all dependencies can be found at: http://git.linuxtv.org/snawrocki/samsung.git/exynos4-is-clk Thanks, Sylwester Sylwester Nawr

Re: width and height of JPEG compressed images

2013-07-22 Thread Sylwester Nawrocki
Hi Thomas, On 07/15/2013 11:18 AM, Thomas Vajzovic wrote: On 10 July 2013 20:44 Sylwester Nawrocki wrote: On 07/07/2013 10:18 AM, Thomas Vajzovic wrote: On 06 July 2013 20:58 Sylwester Nawrocki wrote: On 07/05/2013 10:22 AM, Thomas Vajzovic wrote: I am writing a driver for the sensor

[PATCH RFC 1/5] V4L2: Drop bus_type check in v4l2-async match functions

2013-07-22 Thread Sylwester Nawrocki
These match_* functions are internal callbacks and are always invoked only after checking asd->bus_type. So drop redundant checks in match_i2c() and match_platform() functions. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/v4l2-core/v4l2-async.c |

[PATCH RFC 3/5] V4L2: Add V4L2_ASYNC_MATCH_OF subdev matching type

2013-07-22 Thread Sylwester Nawrocki
Add support for matching by device_node pointer. This allows the notifier user to simply pass a list of device_node pointers corresponding to sub-devices. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/v4l2-core/v4l2-async.c |9 + include/media

[PATCH RFC 5/5] V4L2: Fold struct v4l2_async_subdev_list with struct v4l2_subdev

2013-07-22 Thread Sylwester Nawrocki
By integrating the v4l2-async API internals a bit more with the core overall the v4l2-async code becomes a bit simpler and easier to follow. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/v4l2-core/v4l2-async.c | 67

[PATCH RFC 0/5] v4l2-async DT support improvement and cleanups

2013-07-22 Thread Sylwester Nawrocki
its subdevs. I thought it's a reasonable and simple enough way to support device tree based systems. Comments/other ideas are of course welcome. Thanks, Sylwester Sylwester Nawrocki (5): V4L2: Drop bus_type check in v4l2-async match functions V4L2: Rename v4l2_async_bus

[PATCH RFC 2/5] V4L2: Rename v4l2_async_bus_* to v4l2_async_match_*

2013-07-22 Thread Sylwester Nawrocki
enum v4l2_async_bus_type also selects a method subdevs are matched in the notification handlers, rename it to v4l2_async_match_type so V4L2_ASYNC_MATCH_OF entry can be further added for matching by device tree node pointer. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park

[PATCH RFC 4/5] V4L2: Rename subdev field of struct v4l2_async_notifier

2013-07-22 Thread Sylwester Nawrocki
This is a purely cosmetic change. Since the 'subdev' member points to an array of subdevs it seems more intuitive to name it in plural form. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/soc_camera/soc_camera.c |2 +- drivers/media/v4l2

Re: width and height of JPEG compressed images

2013-07-21 Thread Sylwester Nawrocki
Hi Sakari, On 07/19/2013 10:28 PM, Sakari Ailus wrote: On Sat, Jul 06, 2013 at 09:58:23PM +0200, Sylwester Nawrocki wrote: On 07/05/2013 10:22 AM, Thomas Vajzovic wrote: Hello, I am writing a driver for the sensor MT9D131. This device supports digital zoom and JPEG compression. Although I

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sylwester Nawrocki
On 07/21/2013 05:48 PM, Greg KH wrote: On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform d

Re: Few Doubts on adding DT nodes for bridge driver

2013-07-21 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/21/2013 08:20 AM, Prabhakar Lad wrote: Hi Sylwester, Guennadi, I am working on adding DT support for VPIF driver, initially to get some hands dirty on working on Capture driver and later will move ahead to add for the display. I have added asynchronous probing support for th

Re: [PATCH 2/4] videobuf2-dma-sg: Replace vb2_dma_sg_desc with sg_table

2013-07-19 Thread Sylwester Nawrocki
Hi Ricardo, On 07/19/2013 09:58 AM, Ricardo Ribalda Delgado wrote: > Replace the private struct vb2_dma_sg_desc with the struct sg_table so > we can benefit from all the helping functions in lib/scatterlist.c for > things like allocating the sg or compacting the descriptor > > Signed-off-by: Rica

Re: [PATCH v3] media: i2c: tvp7002: add OF support

2013-07-17 Thread Sylwester Nawrocki
On 07/17/2013 06:20 PM, Prabhakar Lad wrote: > From: "Lad, Prabhakar" > > add OF support for the tvp7002 driver. > > Signed-off-by: Lad, Prabhakar > --- > This patch depends on https://patchwork.kernel.org/patch/2828800/ > > Changes for v3: > 1: Fixed review comments pointed by Sylwester.

Re: [PATCH RFC FINAL v5] media: OF: add "sync-on-green-active" property

2013-07-17 Thread Sylwester Nawrocki
x27;From' tag above isn't needed. It wasn't added automatically, was it ? Unless there are comments from others I think this patch should be merged together with the users of this new property. Acked-by: Sylwester Nawrocki Regards, Sylwester > --- > Changes for v5:

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-17 Thread Sylwester Nawrocki
On 07/17/2013 06:55 AM, Arun Kumar K wrote: > On Wed, Jul 17, 2013 at 3:33 AM, Sylwester Nawrocki > wrote: >> On 07/09/2013 02:04 PM, Arun Kumar K wrote: >>> >>> On Wed, Jun 26, 2013 at 12:57 PM, Hans Verkuil wrote: >>>> >>>> On Fri May 31

Re: [RFC v2 06/10] exynos5-fimc-is: Adds isp subdev

2013-07-16 Thread Sylwester Nawrocki
On 07/09/2013 01:42 PM, Arun Kumar K wrote: + /* Check if same as sensor width& height */ >> >> + sensor_width = p->sensor->drvdata->pixel_width; >> + sensor_height = p->sensor->drvdata->pixel_height; >> + if ((sensor_width != f->fmt.pix_mp.width) || >> +

Re: [RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-07-16 Thread Sylwester Nawrocki
Hi Arun, On 07/09/2013 02:04 PM, Arun Kumar K wrote: On Wed, Jun 26, 2013 at 12:57 PM, Hans Verkuil wrote: On Fri May 31 2013 15:03:23 Arun Kumar K wrote: FIMC-IS uses certain sensors which are exclusively controlled from the IS firmware. This patch adds the sensor subdev for the fimc-is sens

Re: [RFC v2 01/10] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-07-16 Thread Sylwester Nawrocki
Hi Arun, On 07/09/2013 01:08 PM, Arun Kumar K wrote: On Fri, Jun 21, 2013 at 4:15 AM, Sylwester Nawrocki wrote: On 05/31/2013 03:03 PM, Arun Kumar K wrote: [...] Signed-off-by: Arun Kumar K --- .../devicetree/bindings/media/exynos5-fimc-is.txt | 41 1 file

Re: [PATCH RFC v4] media: OF: add "sync-on-green-active" property

2013-07-16 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/16/2013 07:19 PM, Prabhakar Lad wrote: From: "Lad, Prabhakar" This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar --- Changes for v4: 1: Fixed review comments pointed by Sylwester. Changes for v3: 1: Fixed

Re: [RFC PATCH 0/5] Matrix and Motion Detection support

2013-07-16 Thread Sylwester Nawrocki
Hi Hans, On 07/08/2013 09:22 AM, Hans Verkuil wrote: > On Sun July 7 2013 23:50:30 Sylwester Nawrocki wrote: >> On 06/28/2013 02:27 PM, Hans Verkuil wrote: >>> This patch series adds support for matrices and motion detection and >>> converts the solo6x10 driver to use

Re: [PATCH v2] media: i2c: adv7343: add OF support

2013-07-14 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/13/2013 01:12 PM, Prabhakar Lad wrote: From: "Lad, Prabhakar" add OF support for the adv7343 driver. Signed-off-by: Lad, Prabhakar --- Changes for v2: 1: Fixed naming of properties. .../devicetree/bindings/media/i2c/adv7343.txt | 54 drivers/

Re: [PATCH v2 2/2] media: i2c: tvp7002: add OF support

2013-07-14 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/12/2013 06:43 AM, Prabhakar Lad wrote: On Fri, Jul 12, 2013 at 3:34 AM, Sylwester Nawrocki wrote: On 07/11/2013 07:09 PM, Prabhakar Lad wrote: [...] And include/media/tvp70002.h: * fid_polarity: * 0 -> the field ID output is set to logi

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-07-14 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/12/2013 06:29 AM, Prabhakar Lad wrote: On Fri, Jul 12, 2013 at 2:45 AM, Sylwester Nawrocki wrote: On 07/11/2013 01:41 PM, Prabhakar Lad wrote: [...] diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c index aa59639..1a54530 100644 --- a

Re: [PATCH v2 2/2] media: i2c: tvp7002: add OF support

2013-07-11 Thread Sylwester Nawrocki
On 07/11/2013 07:09 PM, Prabhakar Lad wrote: [...] diff --git a/Documentation/devicetree/bindings/media/i2c/tvp7002.txt b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt new file mode 100644 index 000..9daebe1 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-07-11 Thread Sylwester Nawrocki
On 07/11/2013 01:41 PM, Prabhakar Lad wrote: [...] diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c index aa59639..1a54530 100644 --- a/drivers/media/v4l2-core/v4l2-of.c +++ b/drivers/media/v4l2-core/v4l2-of.c @@ -100,6 +100,26 @@ static void v4l2_of_parse_parall

[PATCH] DocBook: Fix typo in V4L2_CID_JPEG_COMPRESSION_QUALITY reference

2013-07-11 Thread Sylwester Nawrocki
Replace the erroneous V4L2_CID_JPEG_IMAGE_QUALITY control name with V4L2_CID_JPEG_COMPRESSION_QUALITY. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- .../DocBook/media/v4l/vidioc-g-jpegcomp.xml|4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: width and height of JPEG compressed images

2013-07-10 Thread Sylwester Nawrocki
Hi Tom, On 07/07/2013 10:18 AM, Thomas Vajzovic wrote: On 06 July 2013 20:58 Sylwester Nawrocki wrote: On 07/05/2013 10:22 AM, Thomas Vajzovic wrote: I am writing a driver for the sensor MT9D131. This device supports digital zoom and JPEG compression. The hardware reads AxB sensor pixels

Re: [RFC PATCH 1/5] v4l2: add matrix support.

2013-07-09 Thread Sylwester Nawrocki
On 07/08/2013 09:15 AM, Hans Verkuil wrote: > On Sun July 7 2013 23:50:51 Sylwester Nawrocki wrote: >> On 06/28/2013 02:27 PM, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> This patch adds core support for matrices: querying, getting and setting. >>

Re: [PATCH V6 0/4] Generic PHY driver for the Exynos SoC DP PHY

2013-07-09 Thread Sylwester Nawrocki
and v6: > * Re-based on git://gitorious.org/linuxphy/linuxphy.git I'm not sure if we really need to keep the documentation of the original binding. Anyway, for the whole series, please feel free to ad my Reviewed-by: Sylwester Nawrocki -- Thanks, Sylwester -- To unsubscribe from this

Re: [RFC PATCH 1/5] v4l2: add matrix support.

2013-07-07 Thread Sylwester Nawrocki
On 06/28/2013 02:27 PM, Hans Verkuil wrote: From: Hans Verkuil This patch adds core support for matrices: querying, getting and setting. Two initial matrix types are defined for motion detection (defining regions and thresholds). Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-d

Re: [RFC PATCH 0/5] Matrix and Motion Detection support

2013-07-07 Thread Sylwester Nawrocki
Hi Hans, On 06/28/2013 02:27 PM, Hans Verkuil wrote: This patch series adds support for matrices and motion detection and converts the solo6x10 driver to use these new APIs. See the RFCv2 for details on the motion detection API: http://www.mail-archive.com/linux-media@vger.kernel.org/msg62085.

Re: [RFC] Support for events with a large payload

2013-07-06 Thread Sylwester Nawrocki
On 07/03/2013 09:34 PM, Laurent Pinchart wrote: On Wednesday 03 July 2013 02:01:59 Sakari Ailus wrote: On Mon, Jun 24, 2013 at 03:40:14PM +0200, Hans Verkuil wrote: ... Since the payloads are larger I am less concerned about speed. There is one problem, though: if you dequeue the event and the

Re: Samsung i2c subdev drivers that set sd->name

2013-07-06 Thread Sylwester Nawrocki
Hi Laurent, On 07/05/2013 01:30 PM, Laurent Pinchart wrote: On Thursday 04 July 2013 22:19:20 Sylwester Nawrocki wrote: On 07/04/2013 01:13 PM, Hans Verkuil wrote: On Thu 4 July 2013 00:49:36 Laurent Pinchart wrote: On Thursday 27 June 2013 11:53:15 Sylwester Nawrocki wrote: On 06/27/2013

Re: width and height of JPEG compressed images

2013-07-06 Thread Sylwester Nawrocki
Hi Thomas, Cc: Sakari and Laurent On 07/05/2013 10:22 AM, Thomas Vajzovic wrote: Hello, I am writing a driver for the sensor MT9D131. This device supports digital zoom and JPEG compression. Although I am writing it for my company's internal purposes, it will be made open-source, so I would l

Re: [PATCH] Update email to m.che...@samsung.com

2013-07-05 Thread Sylwester Nawrocki
On 07/05/2013 04:18 PM, Mauro Carvalho Chehab wrote: The email mche...@redhat.com is no longer valid. Move it to m.che...@samsung.com. Signed-off-by: Mauro Carvalho Chehab --- Mauro, it seems these changes are incorrect and don't belong to this patch: .../arm/Samsung/clksrc-change-registe

Re: Samsung i2c subdev drivers that set sd->name

2013-07-04 Thread Sylwester Nawrocki
On 07/04/2013 01:13 PM, Hans Verkuil wrote: On Thu 4 July 2013 00:49:36 Laurent Pinchart wrote: Hello, On Thursday 27 June 2013 11:53:15 Sylwester Nawrocki wrote: On 06/27/2013 08:43 AM, Hans Verkuil wrote: On Wed June 26 2013 11:00:51 Sakari Ailus wrote: On Tue, Jun 25, 2013 at 06:55:49PM

Re: [PATCH 0/2] V4L2 OF fixes

2013-07-03 Thread Sylwester Nawrocki
On 07/03/2013 12:52 PM, Laurent Pinchart wrote: Hello, Here are two small fixes for the V4L2 OF parsing code. The patches should be self-explanatory. Hi Laurent, Thank you for fixing what I've messed up in the Guennadi's original patch. For both patches: Acked-by: Sylweste

Re: [PATCH V3 2/3] phy: Add driver for Exynos DP PHY

2013-07-01 Thread Sylwester Nawrocki
On 07/01/2013 07:24 AM, Jingoo Han wrote: Add a PHY provider driver for the Samsung Exynos SoC DP PHY. Signed-off-by: Jingoo Han Cc: Sylwester Nawrocki Acked-by: Felipe Balbi --- .../devicetree/bindings/phy/samsung-phy.txt|8 ++ drivers/phy/Kconfig

Re: [PATCH V3 3/3] video: exynos_dp: Use the generic PHY driver

2013-07-01 Thread Sylwester Nawrocki
Hi Jingoo, On 07/01/2013 07:24 AM, Jingoo Han wrote: Use the generic PHY API instead of the platform callback to control the DP PHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms. Since Exynos is currently a dt-only platform upstream, how

Re: Question: interaction between selection API, ENUM_FRAMESIZES and S_FMT?

2013-06-30 Thread Sylwester Nawrocki
On 06/30/2013 10:55 PM, Mauro Carvalho Chehab wrote: Em Sun, 30 Jun 2013 22:28:55 +0200 Sylwester Nawrocki escreveu: Hi Hans, On 06/24/2013 02:48 PM, Hans Verkuil wrote: Hi all, While working on extending v4l2-compliance with cropping/selection test cases I decided to add support for that

Re: Question: interaction between selection API, ENUM_FRAMESIZES and S_FMT?

2013-06-30 Thread Sylwester Nawrocki
Hi Hans, On 06/24/2013 02:48 PM, Hans Verkuil wrote: Hi all, While working on extending v4l2-compliance with cropping/selection test cases I decided to add support for that to vivi as well (this would give applications a good test driver to work with). However, I ran into problems how this sho

Re: [PATCH v2 2/2] media: i2c: tvp7002: add OF support

2013-06-30 Thread Sylwester Nawrocki
Hi, On 06/22/2013 07:44 PM, Prabhakar Lad wrote: From: "Lad, Prabhakar" add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-06-30 Thread Sylwester Nawrocki
: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicetree-disc...@lists.ozlabs.org Cc: linux-...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: Kyungmin Park Do you really

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-29 Thread Sylwester Nawrocki
Hi, On 06/29/2013 10:57 AM, Kishon Vijay Abraham I wrote: On Friday 28 June 2013 03:41 PM, Sylwester Nawrocki wrote: On 06/28/2013 10:17 AM, Hui Wang wrote: On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote: Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 receiver and MIPI

Re: [RFC PATCH 0/3] [media] s5p-jpeg: Add support for Exynos4x12 and 5250

2013-06-29 Thread Sylwester Nawrocki
plenty time... [1] https://patchwork.linuxtv.org/patch/18345/ Thanks, Sylwester George Joseph Palathingal (2): [media] s5p-jpeg: Add support for Exynos4x12 and 5250 [media] s5p-jpeg: Add DT support to JPEG driver Sylwester Nawrocki (1): ARM: dts: Add documentation for Samsung JPEG driver b

[PATCH v4 5/5] ARM: Samsung: Remove the MIPI PHY setup code

2013-06-28 Thread Sylwester Nawrocki
respective PHY consumer drivers and a platform device for the PHY provider should be defined. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Acked-by: Kukjin Kim --- arch/arm/mach-exynos/include/mach/regs-pmu.h|5 -- arch/arm/mach-s5pv210/include/mach

[PATCH v4 4/5] [media] exynos4-is: Use the generic MIPI CSIS PHY driver

2013-06-28 Thread Sylwester Nawrocki
Use the generic PHY API instead of the platform callback to control the MIPI CSIS DPHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Acked

[PATCH v4 3/5] video: exynos_mipi_dsim: Use the generic PHY driver

2013-06-28 Thread Sylwester Nawrocki
Use the generic PHY API instead of the platform callback to control the MIPI DSIM DPHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Acked-b

[PATCH v4 2/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-28 Thread Sylwester Nawrocki
Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 receiver and MIPI DSI transmitter DPHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi --- Changes since v3: - replaced spin_(un)lock_irq_{save,restore} with spin_{lock,unlock}. - DT

[PATCH v4 1/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi

2013-06-28 Thread Sylwester Nawrocki
Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi --- arch/arm/boot/dts/exynos4.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot

[PATCH v4 0/5] Generic PHY driver for the Exynos SoC MIPI CSI-2/DSI DPHYs

2013-06-28 Thread Sylwester Nawrocki
tv.org/snawrocki/samsung.git/exynos-mipi-phy This branch is based on the 'for-next' branch from: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git and the patch series: http://www.spinics.net/lists/arm-kernel/msg254667.html [1] https://lkml.org/lkml/2013/6/26/259 Syl

Re: [PATCH V2 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Sylwester Nawrocki
Hi, On 06/28/2013 12:27 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 12:35 Fri 28 Jun , Felipe Balbi wrote: >> > On Fri, Jun 28, 2013 at 04:18:23PM +0900, Jingoo Han wrote: >>> > > Use the generic PHY API instead of the platform callback to control >>> > > the DP PHY. The 'phy_label' field

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-28 Thread Sylwester Nawrocki
On 06/28/2013 10:17 AM, Hui Wang wrote: > On 06/26/2013 11:02 PM, Sylwester Nawrocki wrote: >> Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 >> receiver and MIPI DSI transmitter DPHYs. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by:

Re: [PATCH 1/3] phy: Add driver for Exynos DP PHY

2013-06-28 Thread Sylwester Nawrocki
Hi, On 06/28/2013 11:31 AM, Kishon Vijay Abraham I wrote: >> diff --git >> a/Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt >> b/Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt >> new file mode 100644 >> index 000..8b6fa79 >> --- /dev/null

Re: [PATCH RFC v3] s5k5baf: add camera sensor driver

2013-06-27 Thread Sylwester Nawrocki
ols. > - S5K5BAF-ISP - Image Signal Processor, formats up to 1600x1200, > pre/post ISP cropping, downscaling via selection API, controls. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Andrzej Hajda > Signed-off-by: Kyungmin Park > --- > v3: > - narrowed s

Re: Samsung i2c subdev drivers that set sd->name

2013-06-27 Thread Sylwester Nawrocki
On 06/27/2013 08:43 AM, Hans Verkuil wrote: > On Wed June 26 2013 11:00:51 Sakari Ailus wrote: >> On Tue, Jun 25, 2013 at 06:55:49PM +0200, Sylwester Nawrocki wrote: >>> On 06/24/2013 10:54 AM, Hans Verkuil wrote: >>>> Hi Sylwester, >>>> >>>> I

Re: [PATCH v4] [media] mem2mem: add support for hardware buffered queue

2013-06-27 Thread Sylwester Nawrocki
ide. At the same > time, the last few frames can be decoded from the bitstream with mem2mem > device > runs that don't need a new input buffer at the v4l2 output side. The decoder > command ioctl can be used to put the decoder into the ringbuffer draining > end-of-stream mode.

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-27 Thread Sylwester Nawrocki
On 06/27/2013 09:52 AM, Felipe Balbi wrote: > On Wed, Jun 26, 2013 at 05:02:22PM +0200, Sylwester Nawrocki wrote: >> Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 >> receiver and MIPI DSI transmitter DPHYs. >> >> Signed-off-by: Sylwester Nawrocki

[PATCH v3 3/5] video: exynos_mipi_dsim: Use the generic PHY driver

2013-06-26 Thread Sylwester Nawrocki
Use the generic PHY API instead of the platform callback to control the MIPI DSIM DPHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi --

<    3   4   5   6   7   8   9   10   11   12   >