From: Phil Carmody phil.carm...@partner.samsung.com
Merge the two sets of flags into one array to simplify accessing
arbitrary bits from them.
Signed-off-by: Phil Carmody phil.carm...@partner.samsung.com
---
drivers/media/platform/exynos4-is/fimc-is-param.c | 80 ++---
Remove unused macros and fields of struct fimc_is_video.
Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-isp.h | 13 +
drivers/media/platform/exynos4-is/media-dev.h
Add a video capture node for the FIMC-IS ISP IP block. The Exynos4x12
FIMC-IS ISP IP block has 2 DMA interfaces that allow to capture raw
Bayer and YUV data to memory. Currently only the DMA2 output is and
raw Bayer data capture is supported.
Signed-off-by: Sylwester Nawrocki s.nawro
is started. The VIDIOC_CREATE_BUFS
ioctl is not yet supported.
Thanks,
Sylwester
Phil Carmody (1):
exynos4-is: Simplify bitmask usage
Sylwester Nawrocki (6):
exynos4-is: Remove leftovers of non-dt FIMC-LITE support
exynos4-is: Remove unused code
exynos4-is: Refactor vidioc_s_fmt
repository at:
git://linuxtv.org/snawrocki/samsung.git v3.10-fixes-2
Sylwester Nawrocki (4):
exynos4-is: Prevent NULL pointer dereference when firmware isn't
loaded
exynos4-is: Ensure fimc-is clocks are not enabled until properly
configured
exynos4-is: Fix reported colorspace
(struct vb2_queue *vq);
+
void v4l2_m2m_ctx_release(struct v4l2_m2m_ctx *m2m_ctx);
void v4l2_m2m_buf_queue(struct v4l2_m2m_ctx *m2m_ctx, struct vb2_buffer *vb);
--
Sylwester Nawrocki
Samsung RD Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line unsubscribe
Hi All,
(replying to myself, probably a bad sign... ;))
On 05/09/2013 05:36 PM, Sylwester Nawrocki wrote:
Currently the media device link_notify callback is invoked before the
actual change of state of a link when the link is being enabled, and
after the actual change of state when the link
On 01/22/2013 09:24 AM, Andrzej Hajda wrote:
Function media_entity_remote_source actually returns the remote pad to
the given one, regardless if this is the source or the sink pad.
Name media_entity_remote_pad is more adequate for this function.
It seems this patch had slipped through the
This patch set fixes couple issues that cause warnings seen in the media
daily build. Any testing/ack are welcome, as these patches are completely
untested yet.
Sylwester Nawrocki (5):
s5c73m3: Do not ignore errors from regulator_enable()
s5p-tv: Don't ignore return value
...@samsung.com
Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com
---
drivers/media/i2c/s5c73m3/s5c73m3-core.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
index d3e867a
’, declared with attribute warn_unused_result
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com
---
drivers/media/platform/s5p-tv/sii9234_drv.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/media/platform
-tv/sdo_drv.c:269:18: warning: ignoring return value
of ‘regulator_enable’,
declared with attribute warn_unused_result
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com
---
drivers/media/platform/s5p-tv/sdo_drv.c | 22
with attribute warn_unused_result
Cc: Tomasz Stanislawski t.stanisl...@samsung.com
Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/media
to the
get_dec_status callback. It seems the get_dec_status callback is not used
anyway, as there is no corresponding s5p_mfc_hw_call().
Cc: Kamil Debski k.deb...@samsung.com
Cc: Arun Kumar K arun...@samsung.com
Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com
---
WARNING: This patch
Hi,
On 05/25/2013 11:17 AM, Prabhakar Lad wrote:
From looking at Figure 8 TVP7002 Application Example in the TVP7002's
datasheet
([2], p. 52) and your initial TVP7002 patches it looks like what you want is
to
specify polarity of the SOGOUT signal, so the processor that receives this
On 05/25/2013 04:26 PM, Prabhakar Lad wrote:
Thus it might make sense to have only following integer properties (added
as needed):
composite-sync-active
sync-on-green-active
sync-on-comp-active
sync-on-luma-active
This would allow to specify polarity of each signal and at the same
Prabhakar,
On 05/16/2013 03:18 PM, Lad Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch adds sync-on-green property as part of
endpoint properties and also support to parse them in the parser.
--- a/Documentation/devicetree/bindings/media/video-interfaces.txt
+++
Hi Sakari,
On 05/21/2013 07:30 PM, Sakari Ailus wrote:
Hi Sylwester,
My apologies for the late answer.
No problem at all, thank you for your follow up.
Sylwester Nawrocki wrote:
On 05/08/2013 06:26 PM, Sakari Ailus wrote:
On Tue, May 07, 2013 at 04:04:10PM +0200, Sylwester Nawrocki wrote
Hi,
On 05/16/2013 06:53 AM, Prabhakar Lad wrote:
diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt
b/Documentation/devicetree/bindings/media/video-interfaces.txt index
e022d2d..6bf87d0 100644
--- a/Documentation/devicetree/bindings/media/video-interfaces.txt
+++
On 05/15/2013 02:52 PM, Lad Prabhakar wrote:
diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt
b/Documentation/devicetree/bindings/media/video-interfaces.txt
index e022d2d..6bf87d0 100644
--- a/Documentation/devicetree/bindings/media/video-interfaces.txt
+++
On 05/16/2013 09:54 AM, Hans Verkuil wrote:
#define V4L2_EVENT_MOTION_DET 5
/**
* struct v4l2_event_motion_det - motion detection event
* @flags: if set to V4L2_EVENT_MD_VALID_FRAME, then the
* frame_sequence field is
Hi Hans,
On 05/13/2013 11:32 AM, Hans Verkuil wrote:
This RFC looks at adding support for motion detection to V4L2. This is the main
missing piece that prevents the go7007 and solo6x10 drivers from being moved
into mainline from the staging directory.
This is the second version of this RFC.
Hi George,
Thanks for the patches. Sorry, I can't review the $subject patch in detail
as is, there is way too many things done in this single patch. It looks more
like a driver replacement. It is even hard to edit due to its size in my
e-mail client.
Hence, may I ask you to split it into
On 05/14/2013 01:53 PM, George Joseph wrote:
From: George Joseph Palathingalgeorge...@samsung.com
Adding DT support to the driver. Driver supports Exynos 4210, 4412 and 5250.
Signed-off-by: George Joseph Palathingalgeorge...@samsung.com
Cc: devicetree-disc...@lists.ozlabs.org
---
: Fix incorrect variable type
Sylwester Nawrocki (1):
exynos4-is: Correct fimc-lite compatible property description
.../devicetree/bindings/media/exynos-fimc-lite.txt |2 +-
drivers/media/i2c/s5c73m3/s5c73m3-core.c |2 +-
drivers/media/platform/exynos4-is/fimc-is-regs.c
/media-entity.c
cae9aa2c Sylwester Nawrocki 2013-05-08 471
cae9aa2c Sylwester Nawrocki 2013-05-08 472 void
media_entity_remove_links(struct media_entity *entity)
cae9aa2c Sylwester Nawrocki 2013-05-08 473 {
cae9aa2c Sylwester Nawrocki 2013-05-08 474 if (WARN_ON_ONCE(entity-parent
.
With an assumption that media links should be created only after
they are registered to a media device and with the graph mutex held.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Reviewed-by: Andrzej Hajda a.ha...@samsung.com
[locking error in the initial patch version]
Reported-by: Dan Carpenter
subsystems.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
This patch should be applied after:
[PATCH] clk: samsung: Add CLK_IGNORE_UNUSED flag for the sysreg clocks
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org
an entity is
registered to its media device, and with the graph mutex held.
I'm open to opinions whether it's good or not and possibly suggestions
on how those issues could be handled differently.
Thanks,
Sylwester
Sylwester Nawrocki (2):
media: Add function removing all media entity links
V4L
.
With an assumption that media links should be created only after
they are registered to a media device and with the graph mutex held.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Reviewed-by: Andrzej Hajda a.ha...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media
before they can be linked.
It is also assumed the media links should be created/removed with
the media graph's mutex held.
The above implies that the caller of v4l2_device_unregister_subdev()
must not hold the graph's mutex.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Reviewed
This patch adds device tree support for the S5P/Exynos SoC
JPEG codec IP block.
Cc: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/media/samsung-s5p-jpeg.txt
Ensure the compatible property for FIMC-LITE IP blocks is properly
documented, a cutpaste error fix.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/media/exynos-fimc-lite.txt |2 +-
1 file changed, 1
The s5c73m3 sensor node should be off an I2C bus controller node.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
.../devicetree/bindings/media/samsung-fimc.txt | 26 ++--
1 file changed, 13 insertions
and to prepare it for addition of
remaining subdevs and video nodes.
This series depends on [RFC PATCH 0/2] Media entity links handling
http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/64214
Thanks,
Sylwester
Sylwester Nawrocki (13):
exynos4-is: Remove platform_device_id table
The driver id_table is unused since all SoCs containing the FIMC-LITE
IP block have been dt-only. Just remove it.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-lite.c | 14
Fill in properly bus_info and card fields and set device_caps.
The querycap ioctl handler is renamed for consistency with the
other ioctls.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc
Create a common module (exynos4-common.ko) that will hold common
functions used across video device and subdev drivers contained
in the .../exynos4-is directory.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media
This patch introduces common structure for the video entities
to handle all video nodes and media pipelines associated with
them in more generic way.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4
the device to query the capabilities.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-capture.c | 96 +++---
drivers/media/platform/exynos4-is/fimc-core.h|3 +
drivers
at the all modules.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-capture.c | 59 ++
drivers/media/platform/exynos4-is/fimc-core.h|2 -
drivers/media/platform/exynos4
Use pm_runtime_put_sync() instead of pm_runtime_put() to avoid races
in handling the 'state' bit flags when the fimc-capture drivers'
runtime_resume callback is called from the PM workqueue.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
This enumeration is now private to exynos4-is and the exynos5 camera
subsystem driver may have the subdevs handling designed differently.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc
' argument is added
to the link_notify callback: MEDIA_DEV_NOTIFY_PRE_LINK_CH indicates
notification before link's state change and
MEDIA_DEV_NOTIFY_POST_LINK_CH corresponds to a notification after
link flags change.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park
is not immutable any more and there is more subdevs than
just sensor, MIPI-CSIS and FIMC(-LITE).
The graph is now walked and for each video node found a media pipeline
which ends at this node is disabled/enabled (the subdevs are powered on/
off).
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed
Ensure the v4l2_device notifications from sensor subdev works
also after the media links reconfiguration.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/media-dev.c | 47
mutex allows safe unregistration of the video
nodes at any time.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-capture.c |4
drivers/media/platform/exynos4-is/fimc-lite.c|4
It's not a critical error to call __fimc_pipeline_close() with missing
sensor subdev entity. Replace WARN_ON() with pr_warn() and return 0
instead of -EINVAL to fix control flow in some conditions.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p
Hi Sachin,
On 05/09/2013 04:50 PM, Sachin Kamat wrote:
George from my team is working on adding JPEG IP support for 4412 and
5250 SoCs which is quite different from 4210.
In this regard he has refactored the driver to accomodate the changes
required for the new IP and also added DT support.
On 05/08/2013 03:46 PM, Laurent Pinchart wrote:
Use the devm_gpio_request_one() managed function to simplify cleanup
code paths.
Signed-off-by: Laurent Pinchartlaurent.pinch...@ideasonboard.com
Acked-by: Sylwester Nawrocki s.nawro...@samsung.com
--
To unsubscribe from this list: send the line
On 05/08/2013 03:46 PM, Laurent Pinchart wrote:
Use the devm_gpio_request_one() managed function to simplify cleanup
code paths.
Signed-off-by: Laurent Pinchartlaurent.pinch...@ideasonboard.com
Acked-by: Sylwester Nawrocki s.nawro...@samsung.com
--
To unsubscribe from this list: send the line
Hi Sakari :-)
On 05/08/2013 06:26 PM, Sakari Ailus wrote:
On Tue, May 07, 2013 at 04:04:10PM +0200, Sylwester Nawrocki wrote:
On 05/07/2013 02:35 PM, Hans Verkuil wrote:
A metadata plane works well if you have substantial amounts of data (e.g.
histogram
data) but it has the disadvantage
On 05/07/2013 02:35 PM, Hans Verkuil wrote:
A metadata plane works well if you have substantial amounts of data (e.g.
histogram
data) but it has the disadvantage of requiring you to use the MPLANE buffer
types,
something which standard apps do not support. I definitely think that is
Hi Sachin,
On 05/02/2013 07:03 AM, Sachin Kamat wrote:
NULL check on clocks obtained using common clock APIs should not
be done. Use IS_ERR only.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Changes since v1:
Initialised clocks to invalid value.
---
On 05/02/2013 01:04 PM, Laurent Pinchart wrote:
Replace the manual validity checks for the reset GPIO with the
gpio_is_valid() function.
Signed-off-by: Laurent Pinchartlaurent.pinch...@ideasonboard.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/i2c/mt9p031.c
Sachin,
On 04/30/2013 06:51 AM, Sachin Kamat wrote:
clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL
to IS_ERR only.
Signed-off-by: Sachin Kamatsachin.ka...@linaro.org
---
drivers/media/platform/exynos4-is/fimc-lite.c |2 +-
1 file changed, 1 insertion(+), 1
On 04/30/2013 08:16 AM, Sachin Kamat wrote:
clk_unprepare checks for NULL pointer. Hence convert IS_ERR_OR_NULL
to IS_ERR only.
Signed-off-by: Sachin Kamatsachin.ka...@linaro.org
---
drivers/media/platform/s3c-camif/camif-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 04/29/2013 11:24 AM, Sachin Kamat wrote:
NULL check on clocks obtained using common clock APIs should not
be done. Use IS_ERR only.
Signed-off-by: Sachin Kamatsachin.ka...@linaro.org
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 10 +-
1 file changed, 5 insertions(+), 5
On 04/30/2013 03:27 PM, Mark Brown wrote:
On Mon, Apr 22, 2013 at 03:23:29PM +0900, Kyungmin Park wrote:
I don't think it's not required, each tree has each own mailing list. don't
need to post all patches to samsung-soc list.
It can be useful to get system level input on some stuff, I guess
Hi Shaik,
Thanks for the updated patch series.
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote:
Current fimc_pipeline is tightly coupled with exynos4-is media
device driver. And this will not allow to use the same pipeline
across different exynos series media device drivers.
This patch
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote:
This patch adds,
1] Exynos5 soc compatibility to the fimc-lite driver
2] Multiple dma output buffer support as from Exynos5 onwards,
fimc-lite h/w ip supports multiple dma buffers.
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote:
FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards.
This patch adds the functionality of using shadow registers by
checking the driver data.
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
---
On 04/24/2013 09:41 AM, Shaik Ameer Basha wrote:
FIMC-IS firmware needs all the MIPI-CSIS interrupts to be enabled.
This patch enables all those MIPI interrupts and adds the Exynos5
compatible string.
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
---
device driver developed by
s/developed/written ?
+ * Sylwester Nawrocki s.nawro...@samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published
+ * by the Free Software Foundation, either version 2
Hi,
On 04/26/2013 03:18 PM, Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
add OF support for the adv7343 driver.
+++ b/Documentation/devicetree/bindings/media/i2c/adv7343.txt
@@ -0,0 +1,69 @@
+* Analog Devices adv7343 video encoder
+
+The ADV7343 are high speed,
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
Just couple remarks below.
+static const struct bfin_disp_format bfin_disp_formats[] = {
+ {
+ .desc= YCbCr 4:2:2 Interleaved UYVY 8bits,
This string will like get truncated, since buffer is only 32 character
long
On 04/26/2013 06:44 AM, Sachin Kamat wrote:
When 'node' is NULL, the print statement tries to dereference it.
Remove it from the error message.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/media/platform/exynos4-is/mipi-csis.c |3 +--
1 file changed, 1 insertion(+),
On 04/26/2013 10:52 AM, Sachin Kamat wrote:
When 'node' is NULL, the print statement tries to dereference it.
Hence replace the variable with the one that is accessible.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Changes since v1:
Used pdev-dev.of_node-full_name for node name.
Hi Guennadi,
On 04/23/2013 03:01 PM, Guennadi Liakhovetski wrote:
On Mon, 22 Apr 2013, Laurent Pinchart wrote:
On Monday 15 April 2013 13:57:17 Sylwester Nawrocki wrote:
On 04/12/2013 05:40 PM, Guennadi Liakhovetski wrote:
+
+ if (notifier-unbind
On 04/25/2013 11:49 AM, Kamil Debski wrote:
Hi,
This set of patches adds support for copy time stamp handling in the following
mem2mem drivers:
* CODA video codec
* Exynos GScaler
* m2m-deinterlace
* mx2_emmaprp
* Exynos G2D
* Exynos Jpeg
In addition there is a slight optimisation for
Hi Scott,
On 04/24/2013 11:26 AM, Scott Jiang wrote:
+ struct v4l2_device v4l2_dev;
+ /* v4l2 control handler */
+ struct v4l2_ctrl_handler ctrl_handler;
This handler seems to be unused, I couldn't find any code adding controls
to it. Any initialization of this handler is
)
Sachin Kamat (2):
exynos4-is: Fix potential null pointer dereferencing
exynos4-is: Convert index variable to signed
Sylwester Nawrocki (15):
s5c73m3: Fix remove() callback to free requested resources
s5c73m3: Add missing subdev .unregistered callback
on the driver's name.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-capture.c | 11 ---
drivers/media/platform/exynos4-is/fimc-core.c| 13 -
drivers/media/platform
-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/mipi-csis.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c
b/drivers/media/platform
On 04/22/2013 11:56 AM, Tomasz Figa wrote:
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote:
On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote:
3) after those two changes, all that remains is to fix compliance with
Common Clock Framework, in other words:
On 04/22/2013 12:03 PM, Inki Dae wrote:
Also looks good to me. But what if power domain was disabled without pm
runtime? In this case, you must enable the power domain at machine code
or
bootloader somewhere. This way would not only need some hard codes to
turn
the
the host
driver modules while the sensor driver stays loaded.
[1]
http://git.linuxtv.org/snawrocki/samsung.git/commitdiff/f7007880a37c28beef845aa0787696aa8cead1cd
Sylwester Nawrocki (12):
s5c73m3: Fix remove() callback to free requested resources
s5c73m3: Add missing subdev .unregistered
Make sure v4l2_device_unregister_subdev() is called for both:
oif and sensor subdev and both media entities are freed on
driver removal.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/i2c/s5c73m3/s5c73m3-core.c
This is needed to free any resources requested in
the .registered subdev op.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/i2c/s5c73m3/s5c73m3-core.c |7 +++
1 file changed, 7 insertions(+)
diff --git
-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-is-i2c.c|3 ---
drivers/media/platform/exynos4-is/fimc-is-sensor.c |1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/media/platform/exynos4
Ensure the value of struct v4l2_subdev::flags field as set
in v4l2_subdev_init() is preserved when initializing it in
the subdev drivers.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc
() callback is the
media entity cleanup call.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-is-sensor.c | 26 ++--
1 file changed, 8 insertions(+), 18 deletions(-)
diff --git
It's an I2C client driver and it must not overwrite the struct v4l2_subdev
dev_priv field, which is used by the v4l2 core to store a pointer to
struct i2c_client.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media
Add missing v4l2_device_unregister_subdev() call for the FIMC-IS subdevs
(currently there is only the FIMC-IS-ISP subdev) so corresponding resources
are properly freed upon the media device driver module removal.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyugmin Park
-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-lite.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c
b/drivers/media/platform/exynos4-is/fimc
Currently there is unbalanced module_put() on the s5p-csis module
which prevents it from being unloaded. The subdev's owner module
has reference count decremented in v4l2_device_unregister_subdev()
so just remove this erroneous call.
Cc: sta...@vger.kernel.org # 3.8
Signed-off-by: Sylwester
Ensure both debugfs: fimc_is directory and the fw_log file
are properly removed in the driver cleanup sequence.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-is.c |2 +-
1 file
Ensure there is no unbalanced pm_runtime_put().
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/media/platform/exynos4-is/fimc-is.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers
On 04/22/2013 04:03 PM, Sylwester Nawrocki wrote:
This patch series includes fixes for several issues found during
testing all exynos4-is device drivers build as modules. The exynos4-is
build with all sub-drivers as 'M' is hopefully now free of all serious
issues, but one. I.e. the requirement
Hi,
On 04/20/2013 10:16 PM, Sergei Shtylyov wrote:
From: Vladimir Barinovvladimir.bari...@cogentembedded.com
Add OKI Semiconductor ML86V7667 video decoder driver.
Signed-off-by: Vladimir Barinovvladimir.bari...@cogentembedded.com
[Sergei: added v4l2_device_unregister_subdev() call to the
Hi Scott,
On 04/17/2013 08:57 AM, Scott Jiang wrote:
Hi Sylwester ,
@@ -9,7 +9,18 @@ config VIDEO_BLACKFIN_CAPTURE
To compile this driver as a module, choose M here: the
module will be called bfin_capture.
+config VIDEO_BLACKFIN_DISPLAY
+ tristate Blackfin Video
Hi Sachin,
On 04/16/2013 08:16 AM, Sachin Kamat wrote:
Hi Sylwester,
On 15 April 2013 20:51, Sylwester Nawrocki s.nawro...@samsung.com wrote:
- if (!fimc-drv_data || fimc-id = fimc-drv_data-num_entities ||
- fimc-id 0) {
- dev_err(dev, Invalid driver data
Signal Processor, formats up to 1600x1200,
pre/post ISP cropping, downscaling via selection API, controls.
Signed-off-by: Andrzej Hajda a.ha...@samsung.com
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
It's worth
Cc: Mark, Mike
On 04/16/2013 07:36 PM, Mauro Carvalho Chehab wrote:
Em 16-04-2013 12:30, Laurent Pinchart escreveu:
Hi Mauro,
On Monday 15 April 2013 09:42:48 Mauro Carvalho Chehab wrote:
Em Mon, 15 Apr 2013 12:19:23 +0200 Laurent Pinchart escreveu:
On Sunday 14 April 2013 16:59:58 Mauro
Hi Guennadi,
On 04/12/2013 05:40 PM, Guennadi Liakhovetski wrote:
Currently bridge device drivers register devices for all subdevices
synchronously, tupically, during their probing. E.g. if an I2C CMOS sensor
is attached to a video bridge device, the bridge driver will create an I2C
device
Hi Sachin,
On 04/15/2013 02:03 PM, Sachin Kamat wrote:
If fimc-drv_data is NULL, then fimc-drv_data-num_entities would
cause NULL pointer dereferencing.
While at it also remove the check for fimc-id being negative as 'id' is
unsigned variable and can't be less than 0.
Signed-off-by: Sachin
Hi Guennadi,
On 04/12/2013 08:13 AM, Guennadi Liakhovetski wrote:
On Thu, 11 Apr 2013, Sylwester Nawrocki wrote:
On 04/11/2013 11:59 AM, Guennadi Liakhovetski wrote:
On Mon, 8 Apr 2013, Guennadi Liakhovetski wrote:
Mostly just a re-spin of v7 with minor modifications.
Guennadi
Hello,
On 04/13/2013 01:52 AM, Scott Jiang wrote:
This is a bridge driver for blackfin diplay device.
It can work with ppi or eppi interface. DV timings
are supported.
Signed-off-by: Scott Jiangscott.jiang.li...@gmail.com
---
drivers/media/platform/blackfin/Kconfig| 15 +-
On 04/11/2013 02:13 AM, Mauro Carvalho Chehab wrote:
Em Thu, 11 Apr 2013 02:04:53 +0200
Arnd Bergmann a...@arndb.de escreveu:
In multiplatform configurations, we cannot include headers
provided by only the exynos platform. Fortunately a number
of drivers that include those headers do not
in fimc-isp.c (2013-04-10 14:04:29
+0200)
Sylwester Nawrocki (8):
s5p-mfc: Remove potential uninitialized variable usage
exynos4-is: Move the subdev group ID definitions to public header
exynos4-is: Make fimc-lite
901 - 1000 of 2695 matches
Mail list logo
