Re: [RFC v4 07/18] vb2: dma-contig: Remove redundant sgt_base field

2017-05-10 Thread Tomasz Figa
Hi Sakari, Some comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used > by USERPTR. > > Unify the

Re: [RFC v4 13/18] vb2: Don't sync cache for a buffer if so requested

2017-05-10 Thread Tomasz Figa
Hi Sakari, Few comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > From: Samu Onkalo > > The user may request to the driver (vb2) to skip the cache maintenance > operations in case the buffer does not need cache

Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-10 Thread Tomasz Figa
Hi Raj, On Thu, May 11, 2017 at 12:12 PM, Mani, Rajmohan <rajmohan.m...@intel.com> wrote: > Hi Tomasz, > Thanks for the reviews. Please see comments inline. > >> -Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: Tuesday,

Re: [PATCH v4] dw9714: Initial driver for dw9714 VCM

2017-05-11 Thread Tomasz Figa
On Thu, May 11, 2017 at 4:24 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Thu, May 11, 2017 at 04:02:35PM +0800, Tomasz Figa wrote: >> Hi Sakari, >> >> On Thu, May 11, 2017 at 3:55 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >>

Re: [PATCH v4] dw9714: Initial driver for dw9714 VCM

2017-05-11 Thread Tomasz Figa
Hi Raj, Thanks for re-spin. Still a bit more comments inline. (I missed few more before, sorry.) On Thu, May 11, 2017 at 1:00 PM, Rajmohan Mani wrote: > DW9714 is a 10 bit DAC, designed for linear > control of voice coil motor. [snip] > +static int

Re: [PATCH v4] dw9714: Initial driver for dw9714 VCM

2017-05-11 Thread Tomasz Figa
Hi Sakari, On Thu, May 11, 2017 at 3:55 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Thu, May 11, 2017 at 02:30:31PM +0800, Tomasz Figa wrote: > ... >> > + >> > +/* >> > + * This function sets the vcm position, so it cons

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Tomasz Figa
Hi Sakari, On Tue, May 9, 2017 at 4:55 AM, Sakari Ailus wrote: > Hi Rajmohan, > > A few comments below... > > On Sun, May 07, 2017 at 04:33:24AM -0700, rajmohan.m...@intel.com wrote: [snip] >> + rval = v4l2_async_register_subdev(_dev->sd); >> + if (rval < 0) >> +

Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Tomasz Figa
Hi Rajmohan, Some comments below. On Mon, May 8, 2017 at 10:36 PM, Rajmohan Mani wrote: > DW9714 is a 10 bit DAC, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides control to set the desired focus. > >

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Tomasz Figa
On Tue, May 9, 2017 at 6:40 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Tue, May 09, 2017 at 04:30:40PM +0800, Tomasz Figa wrote: >> Hi Sakari, >> >> On Tue, May 9, 2017 at 4:55 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >>

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Tomasz Figa
On Wed, May 10, 2017 at 2:27 PM, Inki Dae <inki@samsung.com> wrote: > Hi Tomasz, > > 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: >> Hi Everyone, >> >> On Wed, May 10, 2017 at 9:24 AM, Inki Dae <inki@samsung.com> wrote: >>> >>> >

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-09 Thread Tomasz Figa
Hi Everyone, On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote: > > > 2017년 04월 26일 07:21에 Sakari Ailus 이(가) 쓴 글: >> Hi Marek, >> >> On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: >>> Hi Laurent, >>> >>> On 2017-04-20 12:25, Laurent Pinchart wrote: Hi

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Tomasz Figa
+Rafael, Kevin and Ulf, On Tue, May 9, 2017 at 8:16 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Tue, May 09, 2017 at 07:38:26PM +0800, Tomasz Figa wrote: >> On Tue, May 9, 2017 at 6:40 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> >

Re: [PATCH] dw9714: Initial driver for dw9714 VCM

2017-05-09 Thread Tomasz Figa
On Tue, May 9, 2017 at 9:22 PM, Tomasz Figa <tf...@chromium.org> wrote: > +Rafael, Kevin and Ulf, > > On Tue, May 9, 2017 at 8:16 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> Hi Tomasz, >> >> On Tue, May 09, 2017 at 07:38:26PM +0800, Tomasz Figa wr

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-05-09 Thread Tomasz Figa
On Tue, May 2, 2017 at 9:00 PM, Sakari Ailus wrote: > Hi Yong, > > Thanks for the patches! Some comments below. > > On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: >> + >> +/ FBPT operations / >> + >> +static void

Re: [PATCH 05/12] intel-ipu3: css: tables

2017-06-08 Thread Tomasz Figa
Hi Yong, On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > Coeff, config parameters etc const definitions for > IPU3 programming. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-tables.c | 9621 > >

Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs

2017-06-07 Thread Tomasz Figa
On Thu, Jun 8, 2017 at 2:16 PM, Joe Perches <j...@perches.com> wrote: > On Thu, 2017-06-08 at 13:39 +0900, Tomasz Figa wrote: >> On Thu, Jun 8, 2017 at 12:24 PM, Hirokazu Honda <hi...@chromium.org> wrote: >> > Hi, >> > >> > I completely underst

Re: [PATCH v2] [media] vb2: core: Lower the log level of debug outputs

2017-06-07 Thread Tomasz Figa
On Thu, Jun 8, 2017 at 12:24 PM, Hirokazu Honda wrote: > Hi, > > I completely understand bitmask method now. > I agree to the idea, but it is necessary to change the specification of > a debug parameter. > (We probably need to change a document about that?) > For example,

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Tomasz Figa
Hi Sakari, On Thu, Jun 8, 2017 at 6:59 AM, Sakari Ailus <sakari.ai...@linux.intel.com> wrote: > Hi Tomasz, > > On Tue, Jun 06, 2017 at 07:13:19PM +0900, Tomasz Figa wrote: >> Hi Yong, Tuukka, >> >> +CC IOMMU ML and Joerg. (Technically you should resend this pat

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-09 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 3:07 AM, Robin Murphy <robin.mur...@arm.com> wrote: > On 08/06/17 15:35, Tomasz Figa wrote: >> On Thu, Jun 8, 2017 at 10:22 PM, Robin Murphy <robin.mur...@arm.com> wrote: >>> On 07/06/17 10:47, Tomasz Figa wrote: >>>>

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Wed, Jun 07, 2017 at 05:35:13PM +0900, Tomasz Figa wrote: >> Hi Yong, Tuukka, >> >> Continuing from yesterday. Please see comments inline. >> >> >

Re: [PATCH 1/5] [media] rockchip/rga: v4l2 m2m support

2017-06-27 Thread Tomasz Figa
Hi Jacob, Please see my comments inline. On Mon, Jun 26, 2017 at 11:51 PM, Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha

Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-06-27 Thread Tomasz Figa
On Mon, Jun 26, 2017 at 11:51 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > On Mon, Jun 12, 2017 at 06:59:18PM +0900, Tomasz Figa wrote: > >> >> > + if (WARN_ON(freq <= 0)) >> > + return -EINVAL; >> >> It generally does

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-05-25 Thread Tomasz Figa
Hi Yong, On Wed, May 10, 2017 at 12:27 AM, Tomasz Figa <tf...@chromium.org> wrote: > On Tue, May 2, 2017 at 9:00 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> Hi Yong, >> >> Thanks for the patches! Some comments below. >> >> On Sat, Apr

Re: [PATCH v4] dw9714: Initial driver for dw9714 VCM

2017-05-25 Thread Tomasz Figa
Hi Raj, On Thu, May 11, 2017 at 3:30 PM, Tomasz Figa <tf...@chromium.org> wrote: > Hi Raj, > > Thanks for re-spin. Still a bit more comments inline. (I missed few > more before, sorry.) > > On Thu, May 11, 2017 at 1:00 PM, Rajmohan Mani <rajmohan.m...@intel.com>

Re: [PATCH v3 1/1] [media] i2c: add support for OV13858 sensor

2017-05-29 Thread Tomasz Figa
On Mon, May 29, 2017 at 3:49 PM, Yang, Hyungwoo <hyungwoo.y...@intel.com> wrote: > > Hello Tomasz, > > Here's my comments. > > Thanks, > Hyungwoo > > -----Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: Sunday, May 28, 2

Re: [PATCH v3 1/1] [media] i2c: add support for OV13858 sensor

2017-05-28 Thread Tomasz Figa
Hi Hyungwoo, On Mon, May 29, 2017 at 8:26 AM, Yang, Hyungwoo wrote: > > Hi Sakari, > > Here's my comments. > > -Hyungwoo > > > -Original Message- >> From: Sakari Ailus [mailto:sakari.ai...@iki.fi] >> Sent: Saturday, May 27, 2017 1:31 PM >> To: Yang, Hyungwoo

[PATCH RFC] v4l2-core: Use kvmalloc() for potentially big allocations

2017-05-31 Thread Tomasz Figa
Signed-off-by: Tomasz Figa <tf...@chromium.org> --- drivers/media/v4l2-core/v4l2-async.c | 4 ++-- drivers/media/v4l2-core/v4l2-ctrls.c | 25 + drivers/media/v4l2-core/v4l2-event.c | 8 +--- drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++

Re: [PATCH RFC] v4l2-core: Use kvmalloc() for potentially big allocations

2017-05-31 Thread Tomasz Figa
On Wed, May 31, 2017 at 9:09 PM, Marek Szyprowski <m.szyprow...@samsung.com> wrote: > Hi Tomasz, > > > On 2017-05-31 08:58, Tomasz Figa wrote: >> >> There are multiple places where arrays or otherwise variable sized >> buffer are allocated through V4L2 core cod

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-07 Thread Tomasz Figa
Hi Yong, Tuukka, Continuing from yesterday. Please see comments inline. > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: [snip] >> + ptr = ipu3_mmu_alloc_page_table(mmu_dom, false); >> + if (!ptr) >> + goto fail_page_table; >> + >> + /* >> +

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-07 Thread Tomasz Figa
Hi Yong, +Robin, Joerg, IOMMU ML Please see my comments inline. On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > IPU3 mmu based DMA mapping driver > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/Kconfig | 6 + >

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-08 Thread Tomasz Figa
On Thu, Jun 8, 2017 at 10:22 PM, Robin Murphy <robin.mur...@arm.com> wrote: > On 07/06/17 10:47, Tomasz Figa wrote: >> Hi Yong, >> >> +Robin, Joerg, IOMMU ML >> >> Please see my comments inline. >> >> On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi &

Re: [RFC] V4L2 unified low-level decoder API

2017-06-08 Thread Tomasz Figa
On Thu, Jun 8, 2017 at 8:11 PM, ayaka wrote: > > > On 06/08/2017 06:56 PM, Hans Verkuil wrote: >> >> Hi Alexandre, >> >> On 08/06/17 11:59, Alexandre Courbot wrote: >>> >>> On Thu, Jun 8, 2017 at 5:56 PM, Pawel Osciak >>> wrote: Hi, On

Re: [PATCH 03/12] intel-ipu3: Add DMA API implementation

2017-06-07 Thread Tomasz Figa
Hi Alan, On Thu, Jun 8, 2017 at 2:45 AM, Alan Cox wrote: >> > + struct ipu3_mmu *mmu = to_ipu3_mmu(dev); >> > + dma_addr_t daddr = iommu_iova_to_phys(mmu->domain, dma_handle); >> > + >> > + clflush_cache_range(phys_to_virt(daddr), size); >> >> You

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-05 Thread Tomasz Figa
Uhm, +Laurent. Sorry for the noise. On Tue, Jun 6, 2017 at 1:30 PM, Tomasz Figa <tf...@chromium.org> wrote: > Hi Yong, > > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi <yong@intel.com> wrote: >> Add the IPU3 specific processing parameter format >> V4L2_META_FMT

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-05 Thread Tomasz Figa
Hi Yong, On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > Add the IPU3 specific processing parameter format > V4L2_META_FMT_IPU3_PARAMS and metadata formats > for 3A and other statistics: Please see my comments inline. > > V4L2_META_FMT_IPU3_PARAMS >

Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-06-13 Thread Tomasz Figa
Hi Tuukka, Thanks for your replies. Please see mine inline. On Tue, Jun 13, 2017 at 5:58 PM, Tuukka Toivonen <tuukka.toivo...@intel.com> wrote: > Hi Tomasz, > > On Monday, June 12, 2017 18:59:18 Tomasz Figa wrote: >> By any chance, doesn't the hardware provide some simple m

Re: [PATCH v2 12/12] intel-ipu3: imgu top level pci device

2017-06-17 Thread Tomasz Figa
On Sat, Jun 17, 2017 at 9:00 AM, Zhi, Yong wrote: > Hi, Andy, > >> -Original Message- >> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] >> Sent: Friday, June 16, 2017 3:59 PM >> To: Zhi, Yong >> Cc: Linux Media Mailing List

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-09 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 5:26 PM, Tuukka Toivonen <tuukka.toivo...@intel.com> wrote: > Hi Tomasz, > > Couple of small comments below. > > On Wednesday, June 07, 2017 17:35:13 Tomasz Figa wrote: >> >> +static void ipu3_mmu_domain_free(struct iommu_domain *d

Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-06-12 Thread Tomasz Figa
Hi Yong, Please see my comments inline. On Wed, Jun 7, 2017 at 10:34 AM, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/Kconfig

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-09 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 8:16 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Fri, Jun 09, 2017 at 02:59:10PM +0900, Tomasz Figa wrote: >> On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> >> >> +static void

Re: [PATCH 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-06-13 Thread Tomasz Figa
though. Best regards, Tomasz > > Thanks, > > Yong > >> -Original Message- >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Tomasz Figa >> Sent: Tuesday, June 13, 2017 5:01 PM >> To: Zhi, Yo

Re: [PATCH 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-06-13 Thread Tomasz Figa
Hi Yong, On Wed, Jun 14, 2017 at 5:17 AM, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/Kconfig|2 + >

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-16 Thread Tomasz Figa
On Fri, Jun 16, 2017 at 5:49 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Fri, Jun 16, 2017 at 05:35:52PM +0900, Tomasz Figa wrote: >> On Fri, Jun 16, 2017 at 5:25 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> > Hi Tomasz, >> >

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-16 Thread Tomasz Figa
On Fri, Jun 16, 2017 at 5:25 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Tomasz, > > On Fri, Jun 16, 2017 at 02:52:07PM +0900, Tomasz Figa wrote: >> On Tue, Jun 6, 2017 at 7:09 PM, Tomasz Figa <tf...@chromium.org> wrote: >> > On Tue, Jun 6, 2017 at 5:04

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-16 Thread Tomasz Figa
On Fri, Jun 16, 2017 at 6:19 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > On Fri, Jun 16, 2017 at 06:03:13PM +0900, Tomasz Figa wrote: >> On Fri, Jun 16, 2017 at 5:49 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> > Hi Tomasz, >> > >> > On Fr

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-15 Thread Tomasz Figa
On Tue, Jun 6, 2017 at 7:09 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Tue, Jun 6, 2017 at 5:04 PM, Hans Verkuil <hverk...@xs4all.nl> wrote: >> On 06/06/17 09:25, Sakari Ailus wrote: >>> Hi Tomasz, >>> >>> On Tue, Jun 06, 2017 at 01:30:41PM +09

Re: [PATCH 07/12] intel-ipu3: css: firmware management

2017-06-16 Thread Tomasz Figa
Hi Yong, Please see my comments inline. On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > Functions to load and install imgu FW blobs > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-abi.h| 1572 > >

[PATCH] v4l2-core: Use kvmalloc() for potentially big allocations

2017-06-18 Thread Tomasz Figa
_array(). Purposedly not touching videobuf1, as it is deprecated, has only few users remaining and would rather be seen removed instead. Signed-off-by: Tomasz Figa <tf...@chromium.org> Acked-by: Marek Szyprowski <m.szyprow...@samsung.com> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com&g

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-19 Thread Tomasz Figa
Hi Laurent, Thanks for looking at this! On Mon, Jun 19, 2017 at 6:17 PM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Tomasz, > > On Friday 16 Jun 2017 17:35:52 Tomasz Figa wrote: >> On Fri, Jun 16, 2017 at 5:25 PM, Sakari Ailus wrote: >> > On F

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-06 Thread Tomasz Figa
Hi Yong, Tuukka, +CC IOMMU ML and Joerg. (Technically you should resend this patch including them.) On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > From: Tuukka Toivonen > > This driver translates Intel IPU3 internal virtual > address to

Re: [PATCH 01/12] videodev2.h, v4l2-ioctl: add IPU3 meta buffer format

2017-06-06 Thread Tomasz Figa
On Tue, Jun 6, 2017 at 5:04 PM, Hans Verkuil <hverk...@xs4all.nl> wrote: > On 06/06/17 09:25, Sakari Ailus wrote: >> Hi Tomasz, >> >> On Tue, Jun 06, 2017 at 01:30:41PM +0900, Tomasz Figa wrote: >>> Uhm, +Laurent. Sorry for the noise. >>> >&g

Re: [PATCH v1] media: ov13858: Fix 4224x3136 video flickering at some vblanks

2017-09-15 Thread Tomasz Figa
Hi Chiranjeevi, On Thu, Sep 14, 2017 at 7:38 AM, Chiranjeevi Rapolu wrote: > Previously, the sensor was outputting blank every other frame at 4224x3136 > video when vblank was in the range [79, 86]. This resulted in video > flickering. > > Omni Vision recommends us

Re: [PATCH v2] media: ov13858: Fix 4224x3136 video flickering at some vblanks

2017-09-18 Thread Tomasz Figa
lude Tomasz clarifications in the commit message. Thanks for explanation. It makes perfect sense now. Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz

Re: [GIT PULL] linux-firmware: intel: Add Kabylake IPU3 firmware

2017-08-23 Thread Tomasz Figa
Hi Kyle, Are you perhaps the right person to take a look at this? Thanks in advance. (Judging by git log. Sorry if that's not the case.) Best regards, Tomasz On Tue, Aug 15, 2017 at 8:32 PM, Tomasz Figa <tf...@chromium.org> wrote: > Hi everyone, > > On Sat, Aug 5, 2017 a

Re: [RFC PATCH 0/5] Rockchip ISP1 Driver

2017-11-15 Thread Tomasz Figa
Hi Jacob, Thanks for sending the series! On Wed, Nov 15, 2017 at 3:29 PM, Jacob Chen wrote: > This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > SoC. > > TODO: > - Thomas is rewriting the binding code between isp, phy, sensors, i hope we >

Re: notifier is skipped in some situations

2017-11-24 Thread Tomasz Figa
Hi Sakari, We have the following graph: ISP (registers notifier for v4l2_dev) | PHY (registers notifier for v4l2_subdev, just like sensors for flash/focuser) | \ sensor0 sensor1 ... Both ISP and PHY are completely separate drivers not directly aware of each other,

Re: notifier is skipped in some situations

2017-11-24 Thread Tomasz Figa
On Fri, Nov 24, 2017 at 6:17 PM, Sakari Ailus <sakari.ai...@linux.intel.com> wrote: > Hi Tomasz, > > On Fri, Nov 24, 2017 at 06:03:26PM +0900, Tomasz Figa wrote: >> Hi Sakari, >> >> We have the following graph: >> >> ISP (registers notifier for v4

Re: [PATCH v4 00/12] Intel IPU3 ImgU patchset

2017-12-04 Thread Tomasz Figa
Hi Raj, On Tue, Dec 5, 2017 at 9:13 AM, Mani, Rajmohan wrote: > Hi Hans, > > Thanks for your patience and sharing your thoughts on this. > >> Subject: Re: [PATCH v4 00/12] Intel IPU3 ImgU patchset >> >> Hi Rajmohan, >> >> On 11/17/2017 03:58 AM, Mani, Rajmohan wrote: >>

[RFC PATCH] media: v4l2-device: Link subdevices to their parent devices if available

2017-12-14 Thread Tomasz Figa
of the video_device struct with the value of dev field of the v4l2_subdev struct. In case of subdevices without a parent struct device, the field will be NULL and the old behavior will be preserved by the semantics of __video_register_device(). Signed-off-by: Tomasz Figa <tf...@chromium.org> --- drivers/medi

[PATCH] media: v4l2-fwnode: Check subdev count after checking port

2017-11-15 Thread Tomasz Figa
Fix this by moving the check below the port index check. Fixes: 9ca465312132 ("media: v4l: fwnode: Support generic parsing of graph endpoints in a device") Signed-off-by: Tomasz Figa <tf...@chromium.org> --- drivers/media/v4l2-core/v4l2-fwnode.c | 10 +- 1 file changed, 5 inserti

Re: [PATCH] [media] dw9714: Set the v4l2 focus ctrl step as 1

2017-11-01 Thread Tomasz Figa
On Thu, Nov 2, 2017 at 1:00 PM, Tomasz Figa <tf...@chromium.org> wrote: > Hi Sakari, > > On Thu, Aug 31, 2017 at 6:28 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> Hi Rajmohan, >> >> On Wed, Aug 30, 2017 at 10:48:52AM -0700, Rajmohan Mani wrote: >&

Re: [PATCH] [media] dw9714: Set the v4l2 focus ctrl step as 1

2017-11-01 Thread Tomasz Figa
Hi Sakari, On Thu, Aug 31, 2017 at 6:28 AM, Sakari Ailus wrote: > Hi Rajmohan, > > On Wed, Aug 30, 2017 at 10:48:52AM -0700, Rajmohan Mani wrote: >> Current v4l2 focus ctrl step value of 16, limits >> the minimum granularity of focus positions to 16. >> Setting this value as

Re: [RFC PATCH 0/9] V4L2 Jobs API WIP

2017-10-25 Thread Tomasz Figa
Hi Laurent, On Thu, Oct 26, 2017 at 12:48 AM, Laurent Pinchart wrote: > Hello, > > On Monday, 23 October 2017 11:45:01 EEST Alexandre Courbot wrote: >> On Thu, Oct 19, 2017 at 11:43 PM, Sakari Ailus wrote: >> > On Thu, Sep 28, 2017 at

Re: [RFC PATCH 0/9] V4L2 Jobs API WIP

2017-10-25 Thread Tomasz Figa
Hi Sakari, On Thu, Oct 19, 2017 at 11:43 PM, Sakari Ailus wrote: > Hi Alexandre, > > On Thu, Sep 28, 2017 at 06:50:18PM +0900, Alexandre Courbot wrote: >> Hi everyone, >> [snip] > > Still it shouldn't be forgotten that if the framework is geared towards > helping drivers

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-07 Thread Tomasz Figa
Hi Baruch, On Thu, May 3, 2018 at 6:09 PM Baruch Siach wrote: > Hi Jacob, > On Thu, Mar 08, 2018 at 05:47:55PM +0800, Jacob Chen wrote: > > +static int rkisp1_isp_sd_s_power(struct v4l2_subdev *sd, int on) > > +{ > > + struct rkisp1_device *isp_dev = sd_to_isp_dev(sd); >

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-07 Thread Tomasz Figa
On Mon, May 7, 2018 at 3:38 PM Baruch Siach <bar...@tkos.co.il> wrote: > Hi Tomasz, > On Mon, May 07, 2018 at 06:13:27AM +0000, Tomasz Figa wrote: > > On Thu, May 3, 2018 at 6:09 PM Baruch Siach <bar...@tkos.co.il> wrote: > > > On Thu, Mar 08, 2018 at 0

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Tomasz Figa
Hi Jason, On Wed, May 9, 2018 at 6:28 PM Chen, JasonX Z wrote: > Hello Tomasz > >> +/* Test Pattern Control */ > >> +#define IMX258_REG_TEST_PATTERN0x0600 > >> +#define IMX258_TEST_PATTERN_DISABLE0 > >> +#define IMX258_TEST_PATTERN_SOLID_COLOR

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-08 Thread Tomasz Figa
> This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > Signed-off-by: Andy Yeh <andy@intel.com> > Signed-off-by: Alan Chiang <alanx.chi...@intel.com> > Reviewed-by: Sakari Ailus <sakari.ai...@linux.intel.com> > Reviewed-

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Tomasz Figa
On Thu, May 10, 2018 at 5:33 PM Yeh, Andy <andy@intel.com> wrote: > Hi Tomasz, > -Original Message----- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Thursday, May 10, 2018 3:04 PM > To: Zheng, Jian Xu <jian.xu.zh...@intel.com> > Cc: Chen, Jas

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Tomasz Figa
On Thu, May 10, 2018 at 6:11 PM Zheng, Jian Xu <jian.xu.zh...@intel.com> wrote: > Hi Tomasz, > > -Original Message- > > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > > ow...@vger.kernel.org] On Behalf Of Tomasz Figa > > Sent: Thursday, M

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-10 Thread Tomasz Figa
On Thu, May 10, 2018 at 3:56 PM Zheng, Jian Xu <jian.xu.zh...@intel.com> wrote: > Hi Tomasz, > > -Original Message- > > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > > ow...@vger.kernel.org] On Behalf Of Tomasz Figa > > Sent: Wednesday,

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-12 Thread Tomasz Figa
On Sat, May 12, 2018 at 9:52 PM Sakari Ailus <sakari.ai...@linux.intel.com> wrote: > On Thu, May 10, 2018 at 09:15:31AM +0000, Tomasz Figa wrote: > > On Thu, May 10, 2018 at 6:11 PM Zheng, Jian Xu <jian.xu.zh...@intel.com> > > wrote: > > > > > Hi

Re: [PATCH] media: intel-ipu3: cio2: Handle IRQs until INT_STS is cleared

2018-05-10 Thread Tomasz Figa
10 deletions(-) In case you're waiting for me with this one: Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz

Re: [PATCH 01/28] venus: hfi_msgs: correct pointer increment

2018-05-18 Thread Tomasz Figa
event.profile = profile_level->profile; > event.level = profile_level->level; > - data_ptr += sizeof(profile_level); > + data_ptr += sizeof(*profile_level); > break; > default: > break; Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz

Re: [PATCH 01/28] venus: hfi_msgs: correct pointer increment

2018-05-18 Thread Tomasz Figa
On Fri, May 18, 2018 at 5:52 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > Hi Tomasz, > Thanks for the review! > On 05/18/2018 11:33 AM, Tomasz Figa wrote: > > Hi Stanimir, > > > > Thanks for the series. I'll be gradually reviewing s

Re: [PATCH v2 01/29] venus: hfi_msgs: correct pointer increment

2018-05-18 Thread Tomasz Figa
evel = profile_level->level; > - data_ptr += sizeof(profile_level); > + data_ptr += sizeof(*profile_level); > break; > default: > break; > -- > 2.14.1 (Posted to v1 originally, since I missed v2.) Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz

Re: [PATCH v2 02/29] venus: hfi: preparation to support venus 4xx

2018-05-18 Thread Tomasz Figa
Hi Stanimir, On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > This covers the differences between 1xx,3xx and 4xx. > Signed-off-by: Stanimir Varbanov > --- >drivers/media/platform/qcom/venus/core.h | 4 ++ >

Re: [PATCH v6 04/17] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2018-05-16 Thread Tomasz Figa
Hi Jacob, On Wed, May 16, 2018 at 11:54 PM Jacob Chen wrote: > 2018-05-16 22:39 GMT+08:00 Jacob Chen : > > Hi Laurent, > > > > 2018-05-16 13:20 GMT+08:00 Laurent Pinchart < laurent.pinch...@ideasonboard.com>: > >> Hi Jacob, > >> > >> Thank you for

Re: [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver

2018-05-16 Thread Tomasz Figa
Hi Jacob, Shunqian, On Thu, Mar 8, 2018 at 6:49 PM Jacob Chen wrote: [snip] > +static const struct of_device_id rkisp1_plat_of_match[] = { > + { > + .compatible = "rockchip,rk3288-cif-isp", > + .data = _isp_clk_data, > + }, { > +

Re: [PATCHv13 22/28] Documentation: v4l: document request API

2018-05-23 Thread Tomasz Figa
Hi Laurent, Thanks for detailed review. Please let me add my thoughts inline as well. On Fri, May 18, 2018 at 11:46 PM Laurent Pinchart < laurent.pinch...@ideasonboard.com> wrote: > Hi Hans, > Thank you for the patch. > On Thursday, 3 May 2018 17:53:12 EEST Hans Verkuil wrote: [snip] > >

Re: [PATCH v2 11/29] venus: venc,vdec: adds clocks needed for venus 4xx

2018-05-24 Thread Tomasz Figa
Hi Stanimir, On Tue, May 15, 2018 at 5:10 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > This extends the clocks number to support suspend and resume > on Venus version 4xx. > Signed-off-by: Stanimir Varbanov > --- >

Re: RFC: Request API and memory-to-memory devices

2018-05-25 Thread Tomasz Figa
On Fri, May 25, 2018 at 11:17 PM Sakari Ailus wrote: > Hi Hans, > On Thu, May 24, 2018 at 10:44:13AM +0200, Hans Verkuil wrote: > > Memory-to-memory devices have one video node, one internal control handler > > but two vb2_queues (DMA engines). While often there is

Re: [PATCH v2 12/29] venus: add common capability parser

2018-05-24 Thread Tomasz Figa
Hi Stanimir, On Tue, May 15, 2018 at 5:08 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: [snip] > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index 41eef376eb2d..381bfdd688db 100644 > ---

Re: RFC: Request API and memory-to-memory devices

2018-05-24 Thread Tomasz Figa
On Thu, May 24, 2018 at 5:44 PM Hans Verkuil wrote: > Memory-to-memory devices have one video node, one internal control handler > but two vb2_queues (DMA engines). While often there is one buffer produced > for every buffer consumed, but this is by no means standard. E.g.

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

2018-05-25 Thread Tomasz Figa
On Fri, May 25, 2018 at 5:47 AM Sakari Ailus wrote: > Hi Jacopo, > On Thu, May 24, 2018 at 10:07:38PM +0200, jacopo mondi wrote: > ... > > > > about that, but I wonder why setting controls should be enabled only > > > > when streaming. I would have expected

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-24 Thread Tomasz Figa
On Thu, May 24, 2018 at 8:30 PM Baruch Siach <bar...@tkos.co.il> wrote: > Hi Tomasz, > On Mon, May 07, 2018 at 06:41:50AM +0000, Tomasz Figa wrote: > > On Mon, May 7, 2018 at 3:38 PM Baruch Siach <bar...@tkos.co.il> wrote: > > > On Mon, May 07, 2018 at 06

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

2018-05-25 Thread Tomasz Figa
On Fri, May 25, 2018 at 4:12 PM jacopo mondi <jac...@jmondi.org> wrote: > Hi Tomasz, > On Fri, May 25, 2018 at 03:18:38PM +0900, Tomasz Figa wrote: > > On Fri, May 25, 2018 at 5:47 AM Sakari Ailus < sakari.ai...@linux.intel.com> > > wrote: > > > > &

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-18 Thread Tomasz Figa
+Hu, Jerry W +Mani, Rajmohan +Sakari Ailus FYI On Fri, May 18, 2018 at 4:07 AM Mauro Carvalho Chehab < mchehab+sams...@kernel.org> wrote: > Hi all, > The goal of this e-mail is to schedule a meeting in order to discuss > improvements at the media subsystem in order to support complex camera >

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-18 Thread Tomasz Figa
On Sat, May 19, 2018 at 12:15 AM Nicolas Dufresne wrote: > Le vendredi 18 mai 2018 à 15:38 +0300, Laurent Pinchart a écrit : > > > Before libv4l, media support for a given device were limited to a few > > > apps that knew how to decode the format. There were even cases were

Re: [PATCH v2 03/29] venus: hfi: update sequence event to handle more properties

2018-05-18 Thread Tomasz Figa
On Tue, May 15, 2018 at 5:14 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > HFI version 4xx can pass more properties in the sequence change > event, extend the event structure with them. > Signed-off-by: Stanimir Varbanov > --- >

Re: [PATCH v2 04/29] venus: hfi_cmds: add set_properties for 4xx version

2018-05-18 Thread Tomasz Figa
On Tue, May 15, 2018 at 5:13 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > Adds set_properties method to handle newer 4xx properties and > fall-back to 3xx for the rest. > Signed-off-by: Stanimir Varbanov > --- >

Re: [PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus 4xx

2018-05-18 Thread Tomasz Figa
On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > Add AXI halt support for version 4xx by using venus wrapper > registers. > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 17

Re: [PATCH v2 08/29] venus: hfi_venus: fix suspend function for venus 3xx versions

2018-05-18 Thread Tomasz Figa
On Tue, May 15, 2018 at 5:11 PM Stanimir Varbanov < stanimir.varba...@linaro.org> wrote: > This fixes the suspend function for Venus 3xx versions by > add a check for WFI (wait for interrupt) bit. This bit > is on when the ARM9 is idle and entered in low power mode. > Signed-off-by: Stanimir

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Tomasz Figa
On Wed, Jun 6, 2018 at 7:51 PM Pavel Machek wrote: > > HI! > > > > > Thanks for coming up with this proposal. Please see my comments below. > > > > > > > > > Ok, can I get any comments on this one? > > > > > v4l2_open_complex("/file/with/descriptor", 0) can be used to open > > > > > whole

Re: [ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

2018-06-18 Thread Tomasz Figa
Hi Paul, On Mon, Jun 18, 2018 at 5:42 PM Paul Elder wrote: > > > > Hello all, > > On June 4, 2018 10:33:03 PM GMT+09:00, Mauro Carvalho Chehab > wrote: > >Hi all, > > > >I consolidated hopefully all comments I receive on the past > >announcement > >with regards to the complex camera workshop

Re: [PATCH v6 04/12] intel-ipu3: Implement DMA mapping functions

2018-06-18 Thread Tomasz Figa
On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > > From: Tomasz Figa > > This driver uses IOVA space for buffer mapping through IPU3 MMU > to transfer data between imaging pipelines and system DDR. > > Signed-off-by: Tomasz Figa > Signed-off-by: Yong Zhi > --- >

Re: [PATCH v6 03/12] intel-ipu3: mmu: Implement driver

2018-06-18 Thread Tomasz Figa
On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > > From: Tomasz Figa > > This driver translates IO virtual address to physical > address based on two levels page tables. > > Signed-off-by: Tomasz Figa > Signed-off-by: Yong Zhi > --- > drivers/media/p

Re: [PATCH v6 02/12] intel-ipu3: Add user space API definitions

2018-06-18 Thread Tomasz Figa
Hi Yong, On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > > Define the structures and macros to be used by public. > > Signed-off-by: Yong Zhi > Signed-off-by: Rajmohan Mani > --- > include/uapi/linux/intel-ipu3.h | 1403 > +++ > 1 file changed, 1403

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-06-13 Thread Tomasz Figa
Hi Sakari, On Wed, Jun 13, 2018 at 11:36 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Sat, May 19, 2018 at 12:37:34AM +0900, Tomasz Figa wrote: > > +Hu, Jerry W +Mani, Rajmohan +Sakari Ailus > > > > FYI > > On Fri, May 18, 2018 at 4:07 AM Mauro Carvalho Che

Re: [ANN v2] Complex Camera Workshop - Tokyo - Jun, 19

2018-06-07 Thread Tomasz Figa
certainly important targets, > more can be added) unmodified, which will allow usage of the vendor > binary provided for Chrome OS or Android on regular Linux systems. > > It would make sense to design a modular camera stack, and try to make > most components as platform-independent as

<    1   2   3   4   >