[PATCH v3] staging: lirc_zilog: Clean up lirc zilog error codes
According the coding style guidelines, the ENOSYS error code must be returned in case of a non existent system call. This code has been replaced with the ENOTTY error code indicating a missing functionality. Signed-off-by: Yves Lemée <yves.lemee.ker...@gmail.com> --- v3: Fixed patch subject Fixed patch revision description v2: Improved punctuation drivers/staging/media/lirc/lirc_zilog.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c index 015e41bd036e..26dd32d5b5b2 100644 --- a/drivers/staging/media/lirc/lirc_zilog.c +++ b/drivers/staging/media/lirc/lirc_zilog.c @@ -1249,7 +1249,7 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg) break; case LIRC_GET_REC_MODE: if (!(features & LIRC_CAN_REC_MASK)) - return -ENOSYS; + return -ENOTTY; result = put_user(LIRC_REC2MODE (features & LIRC_CAN_REC_MASK), @@ -1257,21 +1257,21 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg) break; case LIRC_SET_REC_MODE: if (!(features & LIRC_CAN_REC_MASK)) - return -ENOSYS; + return -ENOTTY; result = get_user(mode, uptr); if (!result && !(LIRC_MODE2REC(mode) & features)) - result = -EINVAL; + result = -ENOTTY; break; case LIRC_GET_SEND_MODE: if (!(features & LIRC_CAN_SEND_MASK)) - return -ENOSYS; + return -ENOTTY; result = put_user(LIRC_MODE_PULSE, uptr); break; case LIRC_SET_SEND_MODE: if (!(features & LIRC_CAN_SEND_MASK)) - return -ENOSYS; + return -ENOTTY; result = get_user(mode, uptr); if (!result && mode != LIRC_MODE_PULSE) -- 2.13.2
[PATCH v2] [media] lirc_zilog: Clean up lirc zilog error codes
According the coding style guidelines, the ENOSYS error code must be returned in case of a non existent system call. This code has been replaced with the ENOTTY error code indicating a missing functionality. v2: Improved punctuation Fixed patch subject Signed-off-by: Yves Lemée <yves.lemee.ker...@gmail.com> --- drivers/staging/media/lirc/lirc_zilog.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c index 015e41bd036e..26dd32d5b5b2 100644 --- a/drivers/staging/media/lirc/lirc_zilog.c +++ b/drivers/staging/media/lirc/lirc_zilog.c @@ -1249,7 +1249,7 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg) break; case LIRC_GET_REC_MODE: if (!(features & LIRC_CAN_REC_MASK)) - return -ENOSYS; + return -ENOTTY; result = put_user(LIRC_REC2MODE (features & LIRC_CAN_REC_MASK), @@ -1257,21 +1257,21 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg) break; case LIRC_SET_REC_MODE: if (!(features & LIRC_CAN_REC_MASK)) - return -ENOSYS; + return -ENOTTY; result = get_user(mode, uptr); if (!result && !(LIRC_MODE2REC(mode) & features)) - result = -EINVAL; + result = -ENOTTY; break; case LIRC_GET_SEND_MODE: if (!(features & LIRC_CAN_SEND_MASK)) - return -ENOSYS; + return -ENOTTY; result = put_user(LIRC_MODE_PULSE, uptr); break; case LIRC_SET_SEND_MODE: if (!(features & LIRC_CAN_SEND_MASK)) - return -ENOSYS; + return -ENOTTY; result = get_user(mode, uptr); if (!result && mode != LIRC_MODE_PULSE) -- 2.13.2
[PATCH] Clean up lirc zilog error codes
According the coding style guidelines, the ENOSYS error code must be returned in case of a non existent system call. This code has been replaced with the ENOTTY error code indicating, a missing functionality. Signed-off-by: Yves Lemée <yves.lemee.ker...@gmail.com> --- drivers/staging/media/lirc/lirc_zilog.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c index 015e41bd036e..26dd32d5b5b2 100644 --- a/drivers/staging/media/lirc/lirc_zilog.c +++ b/drivers/staging/media/lirc/lirc_zilog.c @@ -1249,7 +1249,7 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg) break; case LIRC_GET_REC_MODE: if (!(features & LIRC_CAN_REC_MASK)) - return -ENOSYS; + return -ENOTTY; result = put_user(LIRC_REC2MODE (features & LIRC_CAN_REC_MASK), @@ -1257,21 +1257,21 @@ static long ioctl(struct file *filep, unsigned int cmd, unsigned long arg) break; case LIRC_SET_REC_MODE: if (!(features & LIRC_CAN_REC_MASK)) - return -ENOSYS; + return -ENOTTY; result = get_user(mode, uptr); if (!result && !(LIRC_MODE2REC(mode) & features)) - result = -EINVAL; + result = -ENOTTY; break; case LIRC_GET_SEND_MODE: if (!(features & LIRC_CAN_SEND_MASK)) - return -ENOSYS; + return -ENOTTY; result = put_user(LIRC_MODE_PULSE, uptr); break; case LIRC_SET_SEND_MODE: if (!(features & LIRC_CAN_SEND_MASK)) - return -ENOSYS; + return -ENOTTY; result = get_user(mode, uptr); if (!result && mode != LIRC_MODE_PULSE) -- 2.13.2
Re: Nova-T 500 Dual DVB-T
CC [M] /home/mythtv/v4l-dvb/v4l/tuner-simple.o CC [M] /home/mythtv/v4l-dvb/v4l/tuner-types.o ... CC [M] /home/mythtv/v4l-dvb/v4l/radio-si4713.o CC [M] /home/mythtv/v4l-dvb/v4l/radio-maestro.o CC [M] /home/mythtv/v4l-dvb/v4l/radio-miropcm20.o /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:20:23: error: sound/aci.h: No such file or directory /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c: In function 'pcm20_mute': /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:46: error: implicit declaration of function 'snd_aci_cmd' /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:46: error: 'ACI_SET_TUNERMUTE' undeclared (first use in this function) /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:46: error: (Each undeclared identifier is reported only once /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:46: error: for each function it appears in.) /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c: In function 'pcm20_stereo': /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:51: error: 'ACI_SET_TUNERMONO' undeclared (first use in this function) /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c: In function 'pcm20_setfreq': /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:63: error: dereferencing pointer to incomplete type /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:63: error: dereferencing pointer to incomplete type /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:70: error: 'ACI_WRITE_TUNE' undeclared (first use in this function) /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c: In function 'pcm20_init': /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:225: error: implicit declaration of function 'snd_aci_get_aci' /home/mythtv/v4l-dvb/v4l/radio-miropcm20.c:225: warning: assignment makes pointer from integer without a cast make[3]: *** [/home/mythtv/v4l-dvb/v4l/radio-miropcm20.o] Error 1 make[3]: *** Waiting for unfinished jobs make[2]: *** [_module_/home/mythtv/v4l-dvb/v4l] Error 2 make[2]: Leaving directory `/home/mythtv/Téléchargements/linux-2.6.32.2' make[1]: *** [default] Erreur 2 make[1]: quittant le répertoire « /home/mythtv/v4l-dvb/v4l » make: *** [all] Erreur 2 Yves -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Nova-T 500 Dual DVB-T
Yves a écrit : Douglas Schilling Landgraf a écrit : Hello Yves, On 12/20/2009 03:21 AM, Yves wrote: Hi, I have a Nova-T 500 Dual DVB-T card that used to work very well under Mandriva 2008.1 (kernel 2.6.24.7). I moved to Mandriva 2009.1, then 2010.0 (kernel 2.6.31.6) and it doesn't work well any more. Scan can't find channels. I tried hading options dvb-usb-dib0700 force_lna_activation=1 in /etc/modprobe.conf. It improve just a bit. Scan find only a few channels. If I revert to Mandriva 2008.1 (in another partition), all things are good (without adding anything in modprobe.conf). Is there a new version of the driver (dvb_usb_dib0700) that correct this behavior. If not, how to install the driver from kernel 2.6.24.7 in kernel 2.6.31.6 ? Please try the current driver available at v4l/dvb develpment tree and share your results here. hg clone http://linuxtv.org/hg/v4l-dvb make make rmmod make install Finally, just restart your machine and test your favourite application. For additional info: http://www.linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Hello Douglas, Unfortunately, the compilation did not succeed: $ make make -C /home/mythtv/v4l-dvb/v4l make[1]: entrant dans le répertoire « /home/mythtv/v4l-dvb/v4l » perl scripts/make_config_compat.pl /lib/modules/2.6.31.6-desktop-1mnb/source ./.myconfig ./config-compat.h creating symbolic links... make -C firmware prep make[2]: Entering directory `/home/mythtv/v4l-dvb/v4l/firmware' make[2]: Leaving directory `/home/mythtv/v4l-dvb/v4l/firmware' make -C firmware make[2]: Entering directory `/home/mythtv/v4l-dvb/v4l/firmware' CC ihex2fw Generating vicam/firmware.fw Generating dabusb/firmware.fw Generating dabusb/bitstream.bin Generating ttusb-budget/dspbootcode.bin Generating cpia2/stv0672_vp4.bin Generating av7110/bootcode.bin make[2]: Leaving directory `/home/mythtv/v4l-dvb/v4l/firmware' Kernel build directory is /lib/modules/2.6.31.6-desktop-1mnb/build make -C /lib/modules/2.6.31.6-desktop-1mnb/build SUBDIRS=/home/mythtv/v4l-dvb/v4l modules make[2]: Entering directory `/usr/src/linux-2.6.31.6-desktop-1mnb' CC [M] /home/mythtv/v4l-dvb/v4l/tuner-xc2028.o CC [M] /home/mythtv/v4l-dvb/v4l/tuner-simple.o CC [M] /home/mythtv/v4l-dvb/v4l/tuner-types.o CC [M] /home/mythtv/v4l-dvb/v4l/mt20xx.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-cards.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-core.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-i2c.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-tvaudio.o CC
Re: Nova-T 500 Dual DVB-T
Douglas Schilling Landgraf a écrit : Hello Yves, On 12/20/2009 03:21 AM, Yves wrote: Hi, I have a Nova-T 500 Dual DVB-T card that used to work very well under Mandriva 2008.1 (kernel 2.6.24.7). I moved to Mandriva 2009.1, then 2010.0 (kernel 2.6.31.6) and it doesn't work well any more. Scan can't find channels. I tried hading options dvb-usb-dib0700 force_lna_activation=1 in /etc/modprobe.conf. It improve just a bit. Scan find only a few channels. If I revert to Mandriva 2008.1 (in another partition), all things are good (without adding anything in modprobe.conf). Is there a new version of the driver (dvb_usb_dib0700) that correct this behavior. If not, how to install the driver from kernel 2.6.24.7 in kernel 2.6.31.6 ? Please try the current driver available at v4l/dvb develpment tree and share your results here. hg clone http://linuxtv.org/hg/v4l-dvb make make rmmod make install Finally, just restart your machine and test your favourite application. For additional info: http://www.linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Hello Douglas, Unfortunately, the compilation did not succeed: $ make make -C /home/mythtv/v4l-dvb/v4l make[1]: entrant dans le répertoire « /home/mythtv/v4l-dvb/v4l » perl scripts/make_config_compat.pl /lib/modules/2.6.31.6-desktop-1mnb/source ./.myconfig ./config-compat.h creating symbolic links... make -C firmware prep make[2]: Entering directory `/home/mythtv/v4l-dvb/v4l/firmware' make[2]: Leaving directory `/home/mythtv/v4l-dvb/v4l/firmware' make -C firmware make[2]: Entering directory `/home/mythtv/v4l-dvb/v4l/firmware' CC ihex2fw Generating vicam/firmware.fw Generating dabusb/firmware.fw Generating dabusb/bitstream.bin Generating ttusb-budget/dspbootcode.bin Generating cpia2/stv0672_vp4.bin Generating av7110/bootcode.bin make[2]: Leaving directory `/home/mythtv/v4l-dvb/v4l/firmware' Kernel build directory is /lib/modules/2.6.31.6-desktop-1mnb/build make -C /lib/modules/2.6.31.6-desktop-1mnb/build SUBDIRS=/home/mythtv/v4l-dvb/v4l modules make[2]: Entering directory `/usr/src/linux-2.6.31.6-desktop-1mnb' CC [M] /home/mythtv/v4l-dvb/v4l/tuner-xc2028.o CC [M] /home/mythtv/v4l-dvb/v4l/tuner-simple.o CC [M] /home/mythtv/v4l-dvb/v4l/tuner-types.o CC [M] /home/mythtv/v4l-dvb/v4l/mt20xx.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-cards.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-core.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-i2c.o CC [M] /home/mythtv/v4l-dvb/v4l/cx88-tvaudio.o CC [M] /home/mythtv
Nova-T 500 Dual DVB-T
Hi, I have a Nova-T 500 Dual DVB-T card that used to work very well under Mandriva 2008.1 (kernel 2.6.24.7). I moved to Mandriva 2009.1, then 2010.0 (kernel 2.6.31.6) and it doesn't work well any more. Scan can't find channels. I tried hading options dvb-usb-dib0700 force_lna_activation=1 in /etc/modprobe.conf. It improve just a bit. Scan find only a few channels. If I revert to Mandriva 2008.1 (in another partition), all things are good (without adding anything in modprobe.conf). Is there a new version of the driver (dvb_usb_dib0700) that correct this behavior. If not, how to install the driver from kernel 2.6.24.7 in kernel 2.6.31.6 ? regards Yves -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
request for help: Asus Europa2 OEM parity error
Hi, As I reported before (i am sorry for insisting, and I understand that working without the card is not so easy), this card (Asus Europa2 OEM [card=100,autodetected]) does not work with kernel 2.6.26 and later (2.6.25 is OK, at least for DVB) in 2.6.25, composite input, DVB are working. radio is not working . analog TV seems to be working (very poor antenna, hard to say) in 2.6.26 (and later, up to 2.6.30) composite input is working, DVB is not working (tzap does not lock), radio is not working (don't remember for analog TV). dmesg warns about parity error. any help would be greatly appreciated... many thanks in advance Yves here is what dmesg is saying with i2c_debug=1 and irq_debug=1 __ __ for 2.6.30, with latest v4l-dvb [r...@localhost v4l-dvb]# make unload make make install dmesg -c 21/dev/null modprobe saa7134 i2c_debug=1 irq_debug=1 [r...@localhost v4l-dvb]# dmesg Linux video capture interface: v2.00 saa7130/34: v4l2 driver version 0.2.15 loaded saa7134[0]: found at :02:03.0, rev: 1, irq: 19, latency: 32, mmio: 0xf9ffe000 saa7134[0]: subsystem: 1043:4860, board: Asus Europa2 OEM [card=100,autodetected] saa7134[0]: board init: gpio is 0 IRQ 19/saa7134[0]: IRQF_DISABLED is not guaranteed on shared IRQs saa7134[0]: i2c xfer: a0 00 saa7134[0]: i2c xfer: a1 =43 =10 =60 =48 =54 =20 =1c =00 =43 =43 =a9 =1c =55 =d2 =b2 =92 =00 =ff =86 =0f =ff =20 =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =01 =40 =01 =03 =03 =02 =03 =04 =08 =ff =00 =4c =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =1d =00 =c2 =86 =10 =01 =01 =0d =01 =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff =ff saa7134[0]: i2c eeprom 00: 43 10 60 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7134[0]: i2c eeprom 10: 00 ff 86 0f ff 20 ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom 20: 01 40 01 03 03 02 03 04 08 ff 00 4c ff ff ff ff saa7134[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom 40: ff 1d 00 c2 86 10 01 01 0d 01 ff ff ff ff ff ff saa7134[0]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[0]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff i2c-adapter i2c-1: Invalid 7-bit address 0x7a saa7134[0]: i2c xfer: 8e ERROR: NO_DEVICE saa7134[0]: i2c xfer: e2 ERROR: NO_DEVICE saa7134[0]: i2c xfer: 5a ERROR: NO_DEVICE saa7134[0]: i2c xfer: 10 07 02 saa7134[0]: i2c xfer: 84 ERROR: NO_DEVICE saa7134[0]: i2c xfer: 86 saa7134[0]: i2c xfer: 86 00 saa7134[0]: i2c xfer: 87 =11 =10 =10 =10 =10 =10 =10 =10 saa7134[0]: i2c xfer: 86 1f saa7134[0]: i2c xfer: 87 =10 saa7134[0]: i2c xfer: 86 2f saa7134[0]: i2c xfer: 87 =10 saa7134[0]: i2c xfer: 86 01 02 saa7134[0]: i2c xfer: 86 00 00 saa7134[0]: i2c xfer: 86 07 saa7134[0]: i2c xfer: 87 =10 saa7134[0]: i2c xfer: 86 00 d6 30 tuner 1-0043: chip found @ 0x86 (saa7134[0]) tda9887 1-0043: creating new instance tda9887 1-0043: tda988[5/6/7] found saa7134[0]: i2c xfer: 86 00 c0 00 00 saa7134[0]: i2c xfer: c0 ERROR: NO_DEVICE saa7134[0]: i2c xfer: c2 tuner 1-0061: chip found @ 0xc2 (saa7134[0]) saa7134[0]: i2c xfer: c2 0b dc 9c 60 saa7134[0]: i2c xfer: c2 0b dc 86 54 saa7134[0]: i2c xfer: c3 =30 tuner-simple 1-0061: creating new instance tuner-simple 1-0061: type set to 63 (Philips FMD1216ME MK3 Hybrid Tuner) saa7134[0]: i2c xfer: 86 00 00 00 00 saa7134[0]: i2c xfer: c2 1b 6f 86 52 saa7134[0]: i2c xfer: 86 00 02 00 00 saa7134[0]: i2c xfer: 86 00 00 00 00 saa7134[0]: i2c xfer: c2 1b 6f 86 52 saa7134[0]: i2c xfer: 86 00 00 00 00
