Re: [PATCH v2 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread javier Martin
On 27 January 2012 19:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 26 Jan 2012, Javier Martin wrote: The way discard buffer was previously handled lead to possible races that made a buffer that was not yet ready to be overwritten by new video data. This is easily detected

Re: [PATCH v2 4/4] media i.MX27 camera: handle overflows properly.

2012-01-30 Thread javier Martin
On 27 January 2012 19:16, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: (removed bar...@tkos.co.il - it bounces) On Thu, 26 Jan 2012, Javier Martin wrote: Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  Changes since v1:  - Make ifs in irq callback mutually

[PATCH v3 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-30 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v2: - Return ENOTTY for VIDIOC_CREATE_BUFS - Check buffer size properly. - Do not remove unfixed FIXME. - Remove mx25 queued buffers from the queue list at release. --- drivers/media/video/mx2_camera.c | 289

[PATCH v3 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-30 Thread Javier Martin
Add start_stream and stop_stream callback in order to enable and disable the eMMa-PrP properly and save CPU usage avoiding IRQs when the device is not streaming. This also makes the driver return 0 as the sequence number of the first frame. Signed-off-by: Javier Martin javier.mar...@vista

[PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread Javier Martin
and two discard buffers have been added to make them flow trough the pipeline of queues and thus provide suitable event ordering. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v2: - Remove BUG_ON when active list is empty. - Replace empty list checks with warnings

[PATCH v3 4/4] media i.MX27 camera: handle overflows properly.

2012-01-30 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v2: - Use true and false for bool variables. --- drivers/media/video/mx2_camera.c | 38 -- 1 files changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/media/video

[PATCH 1/2] media: tvp5150: Add cropping support.

2012-01-31 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/tvp5150.c | 127 +++-- 1 files changed, 122 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c index c58c8d5..b1476f6

[PATCH 2/2] media: tvp5150: support g_mbus_fmt callback.

2012-01-31 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/tvp5150.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c index b1476f6..e292c46 100644 --- a/drivers/media/video/tvp5150.c

Re: OV2640 and iMX25PDK - help needed

2012-02-02 Thread javier Martin
. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

[dmaengine] [Q] jiffies value does not increase in dma_sync_wait()

2012-02-03 Thread javier Martin
is not triggered and I've found that the value of jiffies does not increase between loop iterations (i. e. it's like time didn't advance). Does anyobody know what reasons could make jiffies not being updated? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los

Re: [dmaengine] [Q] jiffies value does not increase in dma_sync_wait()

2012-02-03 Thread javier Martin
Hi Russell, On 3 February 2012 10:10, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 03, 2012 at 09:37:48AM +0100, javier Martin wrote: I've introduced a couple of printk() to check why this timeout is not triggered and I've found that the value of jiffies does not increase

Re: [dmaengine] [Q] jiffies value does not increase in dma_sync_wait()

2012-02-03 Thread javier Martin
On 3 February 2012 10:24, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 03, 2012 at 10:22:00AM +0100, javier Martin wrote: Hi Russell, On 3 February 2012 10:10, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 03, 2012 at 09:37:48AM +0100, javier

Re: videobuf2 porting

2012-02-06 Thread javier Martin
? If the driver you are trying to port supports old videobuf framework this patch might be useful for you: http://patchwork.linuxtv.org/patch/9719/ -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista

Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread javier Martin
Hi Guennadi, thank you for your attention. On 6 February 2012 19:33, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier Thanks for the update! Let's see, whether this one can be improved a bit more. On Mon, 30 Jan 2012, Javier Martin wrote: The way discard buffer was previously

Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread javier Martin
On 7 February 2012 09:22, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier On Tue, 7 Feb 2012, javier Martin wrote: [snip] Guennadi, before I send v4: Do you agree with the other patches 1, 2 and 4? Yes, this time I haven't found anything their to complain about:-) So, feel

[PATCH v4 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread Javier Martin
and two discard buffers have been added to make them flow trough the pipeline of queues and thus provide suitable event ordering. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- - Add proper locking to avoid races between IRQ and stop callbacks. - If a list is unexpectedly empty want

Re: [PATCH v4 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-09 Thread javier Martin
Hi Guennadi, I understand you are probably quite busy right now but it would be great if you could ack this patch. The sooner you merge it the sooner I will start working on the cleanup series. I've got some time on my hands now. Thank you. On 7 February 2012 11:14, Javier Martin javier.mar

Re: [PATCH v4 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-10 Thread javier Martin
Hi Guennadi, On 9 February 2012 23:36, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier On Thu, 9 Feb 2012, javier Martin wrote: Hi Guennadi, I understand you are probably quite busy right now but it would be great if you could ack this patch. The sooner you merge it the sooner

[PATCH 0/6] media: i.MX27 camera: Clean up series.

2012-02-13 Thread Javier Martin
Hi Guennadi, This is the clean up series I promised to send this week. This has to be applied on top of my previous patches. These are already discussed issues so I don't think you have any concerns with them. While I wait for your confirmation, I'm going to prepare a new patch in order to

[PATCH 1/6] media: i.MX27 camera: Remove goto from mx2_videobuf_queue().

2012-02-13 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index e70d26f..1f046a3 100644 --- a/drivers/media

[PATCH 2/6] media: i.MX27 camera: Use list_first_entry() whenever possible.

2012-02-13 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c | 28 +--- 1 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 1f046a3..13be305

[PATCH 4/6] media: i.MX27 camera: return IRQ_NONE if no IRQ status bit is set.

2012-02-13 Thread Javier Martin
If active_bufs() list is empty and no IRQ status bit is set we are probably dealing with a share IRQ. Return IRQ_NONE in this case. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions

[PATCH 3/6] media: i.MX27 camera: Use spin_lock() inside the IRQ handler.

2012-02-13 Thread Javier Martin
We don't need to use spin_lock_irqsave() since there are not any other IRQs that can race with this ISR. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media

[PATCH 5/6] media: i.MX27 camera: fix compilation warning.

2012-02-13 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index d9028f1..8ccdb4a 100644

[PATCH 6/6] media: i.MX27 camera: more efficient discard buffer handling.

2012-02-13 Thread Javier Martin
Some elements of 'mx2_buffer' are grouped together in another auxiliary structure. This way we don't need to have unused 'vb2_buffer' structures for both discard buffers. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c | 77

[PATCH v2 5/6] media: i.MX27 camera: fix compilation warning.

2012-02-13 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index d9028f1..06017a0 100644

Re: [PATCH 5/6] media: i.MX27 camera: fix compilation warning.

2012-02-13 Thread javier Martin
On 13 February 2012 15:10, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier On Mon, 13 Feb 2012, Javier Martin wrote: Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  drivers/media/video/mx2_camera.c |   16  1 files changed, 8 insertions(+), 8

[PATCH] media: i.MX27 camera: Add resizing support.

2012-02-14 Thread Javier Martin
If the attached video sensor cannot provide the requested image size, try to use resizing engine included in the eMMa-PrP IP. This patch supports both averaging and bilinear algorithms. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c | 251

Re: [PATCH v3 4/4] media i.MX27 camera: handle overflows properly.

2012-02-20 Thread javier Martin
of this patch. I hope to have it ready for tomorrow. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
-EINVAL; .try_fmt() really shouldn't fail. It's the same issue as with s_fmt, I will fix it. I'll try to send a v2 tomorrow. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
this makes sure that resizing won't be applied to unknown formats. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-21 Thread javier Martin
On 21 February 2012 10:24, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Tue, 21 Feb 2012, javier Martin wrote: On 21 February 2012 09:39, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier One more thing occurred to me: I don't see anywhere in your patch checking

[PATCH v4 4/4] media i.MX27 camera: handle overflows properly.

2012-02-22 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v3: - Reset the channels properly. --- drivers/media/video/mx2_camera.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/media/video

[PATCH v2 2/6] media: i.MX27 camera: Use list_first_entry() whenever possible.

2012-02-22 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v1: - Adapt to [PATCH v4 4/4] media i.MX27 camera: handle overflows properly. --- drivers/media/video/mx2_camera.c | 26 -- 1 files changed, 12 insertions(+), 14 deletions(-) diff --git

[PATCH v2 6/6] media: i.MX27 camera: more efficient discard buffer handling.

2012-02-22 Thread Javier Martin
Some elements of 'mx2_buffer' are grouped together in another auxiliary structure. This way we don't need to have unused 'vb2_buffer' structures for both discard buffers. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v1: - Adapt to [PATCH v4 4/4] media i.MX27

Re: [PATCH v4 4/4] media i.MX27 camera: handle overflows properly.

2012-02-22 Thread javier Martin
apply fine as they are. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [PATCH] media: i.MX27 camera: Add resizing support.

2012-02-22 Thread javier Martin
is a pointer whose size is 4bytes. I will just left this unchanged with your permission. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list

[PATCH v2] media: i.MX27 camera: Add resizing support.

2012-02-22 Thread Javier Martin
If the attached video sensor cannot provide the requested image size, try to use resizing engine included in the eMMa-PrP IP. This patch supports both averaging and bilinear algorithms. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v1: - Fix several cosmetic

Re: [PATCH v2 2/6] media: i.MX27 camera: Use list_first_entry() whenever possible.

2012-02-27 Thread javier Martin
On 27 February 2012 09:49, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier On Wed, 22 Feb 2012, Javier Martin wrote: Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  Changes since v1:  - Adapt to [PATCH v4 4/4] media i.MX27 camera: handle overflows properly

[PATCH v3] media: i.MX27 camera: Add resizing support.

2012-02-28 Thread Javier Martin
If the attached video sensor cannot provide the requested image size, try to use resizing engine included in the eMMa-PrP IP. This patch supports both averaging and bilinear algorithms. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v2: - Don't modify controller

Re: [PATCH 1/2] media: tvp5150: Add cropping support.

2012-03-02 Thread javier Martin
Hi all, I've been using and testing these patches successfully for a month. Do you have any comments on them? Do you think they are ready to be merged? [PATCH 1/2] media: tvp5150: Add cropping support [PATCH 2/2] media: tvp5150: Add g_mbus_fmt_callback -- Javier Martin Vista Silicon S.L. CDTUC

Re: [PATCH 1/2] media: tvp5150: Add cropping support.

2012-03-02 Thread javier Martin
On 2 March 2012 09:37, Marco Cavallini koansoftw...@gmail.com wrote: javier Martin ha scritto, Il 02/03/2012 09:35: Hi all, I've been using and testing these patches successfully for a month. Do you have any comments on them? Do you think they are ready to be merged? [PATCH 1/2] media

[Q] media: V4L2 compressed frames and s_fmt.

2012-03-14 Thread javier Martin
frame. However, it does not mention anything special about width and height. Does it make sense setting width and height for h.264/mpeg4 formats? [1] http://v4l2spec.bytesex.org/spec/c2030.htm#V4L2-PIX-FORMAT -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s

Re: [Q] media: V4L2 compressed frames and s_fmt.

2012-03-15 Thread javier Martin
Hi Kamil, Sakari, thank you for your replies. On 15 March 2012 14:19, Kamil Debski k.deb...@samsung.com wrote: Hi Javier, Sakari, From: Sakari Ailus [mailto:sakari.ai...@iki.fi] Sent: 15 March 2012 12:04 Hi Javier, (Cc Kamil.) On Wed, Mar 14, 2012 at 12:22:43PM +0100, javier Martin

[Q] ov7670: green line in VGA resolution

2012-03-19 Thread javier Martin
://kernel.ubuntu.com/git?p=bradf/backup.ubuntu-maverick/.git;a=commitdiff;h=e4182762eaf3c80b2f5c8d1d373409d7c2843579;hp=e770cc1e35a3f11cffd1f38f52060e3e38b4fbf7 But I don't know how these values can be extrapolated to the VGA case. Has anybody found the same issue? Regards. -- Javier Martin Vista

Re: [Q] ov7670: green line in VGA resolution

2012-03-20 Thread javier Martin
Hi Jonathan, thank you for your attention. On 19 March 2012 18:44, Jonathan Corbet cor...@lwn.net wrote: On Mon, 19 Mar 2012 17:27:06 +0100 javier Martin javier.mar...@vista-silicon.com wrote: I suspect the problem is related to the fact that this sensor has an array of 656 x 488 pixels

[PATCH] media: i.MX2: eMMa-PrP: Allow userptr IO mode.

2012-03-20 Thread Javier Martin
Userptr can be very useful if this device is requested to use video buffers allocated by another processing device. So that buffers don't need to be copied. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_emmaprp.c |4 ++-- 1 files changed, 2

[Q] What sensor does s5K6aa driver support?

2012-03-26 Thread javier Martin
as a replacement? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH 0/3] media: tvp5150: Fix mbus format to UYUV instead of YUYV.

2012-03-26 Thread Javier Martin
[PATCH 1/3] media: tvp5150: Fix mbus format. [PATCH 2/3] media: mx2_camera: Fix mbus format handling. [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

[PATCH 1/3] media: tvp5150: Fix mbus format.

2012-03-26 Thread Javier Martin
According to p.14 fig 3-3 of the datasheet (SLES098A) this decoder transmits data in UYVY format. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/tvp5150.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/tvp5150

[PATCH 2/3] media: mx2_camera: Fix mbus format handling.

2012-03-26 Thread Javier Martin
Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags so that the driver can negotiate with the attached sensor whether the mbus format needs convertion from UYUV to YUYV or not. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- arch/arm/plat-mxc/include/mach/mx2_cam.h |2

[PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

2012-03-26 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- arch/arm/mach-imx/mach-imx27_visstrim_m10.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c index 3128cfe..4db00c6

Re: [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

2012-03-26 Thread javier Martin
On 26 March 2012 14:10, Baruch Siach bar...@tkos.co.il wrote: Hi Javier, On Mon, Mar 26, 2012 at 01:20:04PM +0200, Javier Martin wrote: Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  arch/arm/mach-imx/mach-imx27_visstrim_m10.c |    2 +-  1 files changed, 1 insertions

[PATCH v2 0/3] media: tvp5150: Fix mbus format to UYUV instead of YUYV.

2012-03-26 Thread Javier Martin
Changes since v2: - Swap order of patches 3 and 4 to make the series bisectable. [PATCH v2 1/3] media: tvp5150: Fix mbus format. [PATCH v2 2/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16. [PATCH v2 3/3] media: mx2_camera: Fix mbus format handling. -- To unsubscribe from this list: send

[PATCH v2 1/3] media: tvp5150: Fix mbus format.

2012-03-26 Thread Javier Martin
According to p.14 fig 3-3 of the datasheet (SLES098A) this decoder transmits data in UYVY format. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/tvp5150.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/tvp5150

[PATCH v2 2/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

2012-03-26 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- arch/arm/mach-imx/mach-imx27_visstrim_m10.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c index 3128cfe..4db00c6

[PATCH v2 3/3] media: mx2_camera: Fix mbus format handling.

2012-03-26 Thread Javier Martin
Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags so that the driver can negotiate with the attached sensor whether the mbus format needs convertion from UYUV to YUYV or not. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- arch/arm/plat-mxc/include/mach/mx2_cam.h |2

Re: [RFC] Support for 'Coda' video codec IP.

2012-06-20 Thread javier Martin
Hi Fabio, On 20 June 2012 05:26, Fabio Estevam feste...@gmail.com wrote: Hi Javier, On Tue, Jun 19, 2012 at 11:11 AM, Javier Martin javier.mar...@vista-silicon.com wrote: This patch adds support for the video encoder present in the i.MX27. It currently support encoding in H.264

Re: [RFC] Support for 'Coda' video codec IP.

2012-06-20 Thread javier Martin
drop this platform data it is OK with you if I don't add device tree support by now? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send

Re: [RFC] Support for 'Coda' video codec IP.

2012-06-20 Thread javier Martin
, for example linear irqdomain. Do you plan to add pinctrl support for i.MX27 and i.MX21? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send

Re: [RFC] Support for 'Coda' video codec IP.

2012-07-02 Thread javier Martin
=i.MX27nodeId=018rH3ZrDR66AFfpsp=1tab=Design_Tools_Tab -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [RFC] Support for 'Coda' video codec IP.

2012-07-02 Thread javier Martin
On 2 July 2012 12:54, Sascha Hauer s.ha...@pengutronix.de wrote: On Mon, Jul 02, 2012 at 12:36:46PM +0200, javier Martin wrote: Hi Sascha, I almost have a final version ready which includes multi-instance support (not tested though) [1]. As I stated, we assumed the extra effort of looking

Re: [RFC] Support for 'Coda' video codec IP.

2012-07-02 Thread javier Martin
On 2 July 2012 13:13, javier Martin javier.mar...@vista-silicon.com wrote: On 2 July 2012 12:54, Sascha Hauer s.ha...@pengutronix.de wrote: On Mon, Jul 02, 2012 at 12:36:46PM +0200, javier Martin wrote: Hi Sascha, I almost have a final version ready which includes multi-instance support

media: i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-06 Thread Javier Martin
This driver wasn't converted to the new clock changes (clk_prepare_enable/clk_disable_unprepare). Also naming of emma-prp related clocks for the i.MX27 was not correct. Signed-of-by: Javier Martin javier.mar...@vista-silicon.com --- diff --git a/arch/arm/mach-imx/clk-imx27.c b/arch/arm/mach-imx

Re: media: i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-06 Thread javier Martin
On 6 July 2012 08:43, Sascha Hauer s.ha...@pengutronix.de wrote: Hi Javier, On Fri, Jul 06, 2012 at 08:31:49AM +0200, Javier Martin wrote: This driver wasn't converted to the new clock changes (clk_prepare_enable/clk_disable_unprepare). Also naming of emma-prp related clocks for the i.MX27

[PATCH] [v2] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-06 Thread Javier Martin
This driver wasn't converted to the new clock changes (clk_prepare_enable/clk_disable_unprepare). Also naming of emma-prp related clocks for the i.MX27 was not correct. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- arch/arm/mach-imx/clk-imx27.c|8 --- drivers/media

Re: [PATCH] [v2] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-06 Thread javier Martin
On 6 July 2012 09:34, Sascha Hauer s.ha...@pengutronix.de wrote: On Fri, Jul 06, 2012 at 09:13:11AM +0200, Javier Martin wrote: This driver wasn't converted to the new clock changes (clk_prepare_enable/clk_disable_unprepare). Also naming of emma-prp related clocks for the i.MX27

[PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-06 Thread Javier Martin
This driver wasn't converted to the new clock changes (clk_prepare_enable/clk_disable_unprepare). Also naming of emma-prp related clocks for the i.MX27 was not correct. --- Enable clocks only for i.MX27. --- arch/arm/mach-imx/clk-imx27.c|8 +++-- drivers/media/video/mx2_camera.c | 67

Re: [PATCH v3][for_v3.5] media: mx2_camera: Fix mbus format handling

2012-07-06 Thread javier Martin
Hi, can this patch be applied please? It solves a BUG for 3.5. Guennadi, Fabio, could you give me an ack for this? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: [PATCH v3][for_v3.5] media: mx2_camera: Fix mbus format handling

2012-07-06 Thread javier Martin
On 6 July 2012 13:00, javier Martin javier.mar...@vista-silicon.com wrote: Hi, can this patch be applied please? It solves a BUG for 3.5. Guennadi, Fabio, could you give me an ack for this? Regards. But it should be applied after this one to preserve bisectability: http

Re: [PATCH v3][for_v3.5] media: mx2_camera: Fix mbus format handling

2012-07-06 Thread javier Martin
Hi Guennadi, On 6 July 2012 13:09, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 6 Jul 2012, javier Martin wrote: Hi, can this patch be applied please? It solves a BUG for 3.5. Guennadi, Fabio, could you give me an ack for this? Sorry? This patch has been applied and proven

Re: [PATCH v3][for_v3.5] media: mx2_camera: Fix mbus format handling

2012-07-06 Thread javier Martin
Hi Guennadi, On 6 July 2012 13:39, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 6 Jul 2012, javier Martin wrote: Hi Guennadi, On 6 July 2012 13:09, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 6 Jul 2012, javier Martin wrote: Hi, can this patch be applied

[PATCH 0/3] Add support for 'Coda' video codec IP.

2012-07-06 Thread Javier Martin
This patch provides support for the codadx6 that is inside the i.MX27. Currently only H.264 and MPEG4 Part-2 encoding operations are supported. This is a refined version of the RFC sent two weeks ago [1]. The following tasks have been addressed since then: - Get rid of 'runtime' structure. -

[PATCH 3/3] Visstrim M10: Add support for Coda.

2012-07-06 Thread Javier Martin
Support the codadx6 that is included in the i.MX27 SoC. --- arch/arm/mach-imx/mach-imx27_visstrim_m10.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c index

[PATCH 1/3] i.MX: coda: Add platform support for coda in i.MX27.

2012-07-06 Thread Javier Martin
a/arch/arm/plat-mxc/devices/platform-imx27-coda.c b/arch/arm/plat-mxc/devices/platform-imx27-coda.c new file mode 100644 index 000..8b12aac --- /dev/null +++ b/arch/arm/plat-mxc/devices/platform-imx27-coda.c @@ -0,0 +1,37 @@ +/* + * Copyright (C) 2012 Vista Silicon + * Javier Martin javier.mar

Re: [PATCH v3][for_v3.5] media: mx2_camera: Fix mbus format handling

2012-07-09 Thread javier Martin
On 6 July 2012 14:55, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier Thanks for the patch, and sorry for delay. I was away first 10 days of June and still haven't come round to cleaning up my todo list since then... On Fri, 1 Jun 2012, Javier Martin wrote: Remove

Re: [PATCH v3][for_v3.5] media: mx2_camera: Fix mbus format handling

2012-07-09 Thread javier Martin
Javier Thanks for the patch, and sorry for delay. I was away first 10 days of June and still haven't come round to cleaning up my todo list since then... On Fri, 1 Jun 2012, Javier Martin wrote: [snip] @@ -1024,14 +1039,28 @@ static int mx2_camera_set_bus_param(struct

[PATCH v4] media: mx2_camera: Fix mbus format handling

2012-07-09 Thread Javier Martin
Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags so that the driver can negotiate with the attached sensor whether the mbus format needs convertion from UYUV to YUYV or not. --- Changes since v3: Do not provide pass-through for UYVY8. --- arch/arm/plat-mxc/include/mach/mx2_cam.h |2

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-09 Thread javier Martin
On 9 July 2012 09:28, Sascha Hauer s.ha...@pengutronix.de wrote: On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: This driver wasn't converted to the new clock changes (clk_prepare_enable/clk_disable_unprepare). Also naming of emma-prp related clocks for the i.MX27

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-09 Thread javier Martin
On 9 July 2012 09:43, Sascha Hauer s.ha...@pengutronix.de wrote: On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote: On 9 July 2012 09:28, Sascha Hauer s.ha...@pengutronix.de wrote: On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: This driver wasn't converted

Re: [PATCH 2/3] media: coda: Add driver for Coda video codec.

2012-07-09 Thread javier Martin
On 9 July 2012 10:19, Philipp Zabel p.za...@pengutronix.de wrote: Am Montag, den 09.07.2012, 10:07 +0200 schrieb javier Martin: [...] +static int vidioc_s_parm(struct file *file, void *priv, struct v4l2_streamparm *a) +{ + struct coda_ctx *ctx = fh_to_ctx(priv

[PATCH v2 3/3] Visstrim M10: Add support for Coda.

2012-07-09 Thread Javier Martin
Support the codadx6 that is included in the i.MX27 SoC. --- Changes since v1: - Use 'arm_memblock_steal'. --- arch/arm/mach-imx/mach-imx27_visstrim_m10.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c

[PATCH] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

2012-07-10 Thread Javier Martin
--- drivers/media/video/mx2_camera.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index d5355de..4a96989 100644 --- a/drivers/media/video/mx2_camera.c +++ b/drivers/media/video/mx2_camera.c @@ -1370,6

[PATCH v2] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

2012-07-11 Thread Javier Martin
--- drivers/media/video/mx2_camera.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index d5355de..eda98fc 100644 --- a/drivers/media/video/mx2_camera.c +++ b/drivers/media/video/mx2_camera.c @@

[PATCH v5] media: mx2_camera: Fix mbus format handling

2012-07-11 Thread Javier Martin
Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags so that the driver can negotiate with the attached sensor whether the mbus format needs convertion from UYUV to YUYV or not. --- drivers/media/video/mx2_camera.c | 28 +++- 1 file changed, 23 insertions(+), 5

[PATCH 0/2] Add video deinterlacing support.

2012-07-11 Thread Javier Martin
[PATCH 1/2] media: Add mem2mem deinterlacing driver. [PATCH 2/2] i.MX27: Visstrim_M10: Add support for deinterlacing -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/2] media: Add mem2mem deinterlacing driver.

2012-07-11 Thread javier Martin
Hi Hans, thank you for your comments. On 11 July 2012 11:45, Hans Verkuil hverk...@xs4all.nl wrote: Hi Javier! Thanks for the patch. On Wed 11 July 2012 10:55:03 Javier Martin wrote: Some video decoders such as tvp5150 provide separate video fields (V4L2_FIELD_SEQ_TB). This driver uses

Re: [PATCH v5] media: mx2_camera: Fix mbus format handling

2012-07-11 Thread javier Martin
Hi, On 11 July 2012 12:08, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, Thanks for the patch. On Wednesday 11 July 2012 09:56:49 Javier Martin wrote: Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags so that the driver can negotiate with the attached sensor

[PATCH v6] media: mx2_camera: Fix mbus format handling

2012-07-11 Thread Javier Martin
Do not use MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags. The driver must negotiate with the attached sensor whether the mbus format is UYUV or YUYV and set CSICR1 configuration accordingly. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c

[PATCH] media: mx2_camera: Add YUYV output format.

2012-07-12 Thread Javier Martin
Add explicit conversions from UYVY and YUYV to YUYV so that csicr1 configuration can be set properly for each format. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c | 40 ++ 1 file changed, 40 insertions

[PATCH] media: mx2_camera: Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags.

2012-07-12 Thread Javier Martin
These flags are not used any longer and can be safely removed since the following patch: http://www.spinics.net/lists/linux-media/msg50165.html Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- arch/arm/plat-mxc/include/mach/mx2_cam.h |2 -- 1 file changed, 2 deletions

[PATCH 1/2 v2] media: Add mem2mem deinterlacing driver.

2012-07-12 Thread Javier Martin
effect in the image but this can be accepted for some low quality applications. Currently YUV420 and YUYV formats are supported but can be extended later. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v1: - Added support for V4L2_FIELD_SEQ_BT

[PATCH 2/2 v2] i.MX27: Visstrim_M10: Add support for deinterlacing driver.

2012-07-12 Thread Javier Martin
Visstrim_M10 have a tvp5150 whose video output must be deinterlaced. The new mem2mem deinterlacing driver is very useful for that purpose. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v1: - Removed commented out code. --- arch/arm/mach-imx/mach

Re: [PATCH v3] media: coda: Add driver for Coda video codec.

2012-07-18 Thread javier Martin
below. Fine. Am Donnerstag, den 12.07.2012, 09:11 +0200 schrieb Javier Martin: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards. Currently only support for the codadx6 included in the i.MX27 SoC is added. H.264 and MPEG4 video encoding

Re: [PATCH v3] media: coda: Add driver for Coda video codec.

2012-07-18 Thread javier Martin
On 18 July 2012 10:35, Philipp Zabel p.za...@pengutronix.de wrote: Hi Javier, Am Mittwoch, den 18.07.2012, 09:12 +0200 schrieb javier Martin: [...] I see there is a comment about the expected register setting not working for CODA_REG_BIT_STREAM_CTRL in start_streaming(). Could

Re: [PATCH v3] media: coda: Add driver for Coda video codec.

2012-07-18 Thread javier Martin
On 18 July 2012 11:22, Philipp Zabel p.za...@pengutronix.de wrote: Hi Javier, Am Mittwoch, den 18.07.2012, 11:01 +0200 schrieb javier Martin: On 18 July 2012 10:35, Philipp Zabel p.za...@pengutronix.de wrote: Hi Javier, Am Mittwoch, den 18.07.2012, 09:12 +0200 schrieb javier Martin

Re: [PATCH v3] media: coda: Add driver for Coda video codec.

2012-07-18 Thread javier Martin
On 18 July 2012 14:12, Philipp Zabel p.za...@pengutronix.de wrote: Am Mittwoch, den 18.07.2012, 11:26 +0200 schrieb javier Martin: On 18 July 2012 11:22, Philipp Zabel p.za...@pengutronix.de wrote: Hi Javier, Am Mittwoch, den 18.07.2012, 11:01 +0200 schrieb javier Martin: On 18 July 2012

Re: [PATCH v4] media: coda: Add driver for Coda video codec.

2012-07-18 Thread javier Martin
Hi Hans, thank you for your review. On 18 July 2012 13:00, Hans Verkuil hverk...@xs4all.nl wrote: Hi Javier! On Wed 18 July 2012 12:21:35 Javier Martin wrote: Coda is a range of video codecs from ChipsMedia that support H.264, H.263, MPEG4 and other video standards. Currently only support

Re: [PATCH] media: mx2_camera: Add YUYV output format.

2012-07-20 Thread javier Martin
On 12 July 2012 10:56, Javier Martin javier.mar...@vista-silicon.com wrote: Add explicit conversions from UYVY and YUYV to YUYV so that csicr1 configuration can be set properly for each format. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mx2_camera.c

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-20 Thread javier Martin
On 20 July 2012 13:19, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Javier Thanks for the patch On Mon, 9 Jul 2012, javier Martin wrote: On 9 July 2012 10:07, Sascha Hauer s.ha...@pengutronix.de wrote: On Mon, Jul 09, 2012 at 09:46:03AM +0200, javier Martin wrote: On 9 July

<    1   2   3   4   5   >