[PATCH 0/2] Patches for TVP7002

2010-08-03 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com The patch TVP7002: Changed register values depends on http://www.mail-archive.com/linux-media@vger.kernel.org/msg20769.html Mats Randgaard (2): TVP7002: Return V4L2_DV_INVALID if any of the errors occur. TVP7002: Changed register values

[PATCH 2/2] TVP7002: Changed register values.

2010-08-03 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Register values changed according to the data sheet and Texas Instruments DaVinci_PSP_03_02_00_37. - TVP7002_RGB_COARSE_CLAMP_CTL changed to the default value in data sheet. - TVP7002_HPLL_PHASE_SEL deleted because the registers

[PATCH 1/2] TVP7002: Return V4L2_DV_INVALID if any of the errors occur.

2010-08-03 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Mats Randgaard mats.randga...@tandberg.com --- drivers/media/video/tvp7002.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/tvp7002.c b/drivers/media/video/tvp7002.c index 48f5c76

[RFC/PATCH 0/5] DaVinci VPIF: Support for DV preset and DV timings.

2010-10-22 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Support for DV preset and timings added to vpif_capture and vpif_display drivers. Functions for debugging are added and the code is improved as well. Mats Randgaard (5): vpif_cap/disp: Add debug functionality vpif: Move and extend ch_params

[RFC/PATCH 2/5] vpif: Move and extend ch_params[]

2010-10-22 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com - The ch_params tables in vpif_capture.c and vpif_display.c are moved to a common table in vpif.c. Then it is easier to maintain the table. - The new table is extended with all the DV formats supportet by TVP7002. - The field fps is removed from

[RFC/PATCH 3/5] vpif_cap/disp: Added support for DV presets

2010-10-22 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Added functions to set/get/query/enum DV presets. Signed-off-by: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Hans Verkuil hans.verk...@tandberg.com --- drivers/media/video/davinci/vpif_capture.c | 143

[RFC/PATCH 4/5] vpif_cap/disp: Added support for DV timings

2010-10-22 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Added functions to set and get custom DV timings. Signed-off-by: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Hans Verkuil hans.verk...@tandberg.com --- drivers/media/video/davinci/vpif_capture.c | 119

[RFC/PATCH 5/5] vpif_cap/disp: Cleanup, improved comments

2010-10-22 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Hans Verkuil hans.verk...@tandberg.com --- drivers/media/video/davinci/vpif.h | 13 ++--- drivers/media/video/davinci/vpif_capture.c | 13

[RFCv2/PATCH 2/5] vpif: Consolidate formats from capture and display

2010-10-28 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com - The ch_params tables in vpif_capture.c and vpif_display.c are moved to a common table in vpif.c. Then it is easier to maintain the table. - The field fps is removed from the struct vpif_channel_config_params because it is not used. Signed

[RFCv2/PATCH 3/5] vpif_cap/disp: Add support for DV presets

2010-10-28 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com - Added functions to set/get/query/enum DV presets for vpif_caputre and vpif_display. - The format specification table is extended with all the DV formats supportet by TVP7002. support DV formats. Signed-off-by: Mats Randgaard mats.randga

[RFCv2/PATCH 5/5] vpif_cap/disp: Cleanup, improved comments

2010-10-28 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Hans Verkuil hans.verk...@tandberg.com Acked-by: Murali Karicheri mkarich...@gmail.com Acked-by: Vaibhav Hiremath hvaib...@ti.com --- drivers/media/video/davinci/vpif.h

[RFCv2/PATCH 4/5] vpif_cap/disp: Added support for DV timings

2010-10-28 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Added functions to set and get custom DV timings. Signed-off-by: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Hans Verkuil hans.verk...@tandberg.com Acked-by: Vaibhav Hiremath hvaib...@ti.com --- drivers/media/video/davinci

[RFCv2/PATCH 1/5] vpif_cap/disp: Add debug functionality

2010-10-28 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com The following functions are added to the drivers: - vpif_g_chip_ident - vpif_dbg_g_register - vpif_dbg_s_register - vpif_log_status Signed-off-by: Mats Randgaard mats.randga...@tandberg.com Signed-off-by: Hans Verkuil hans.verk

[RFCv2/PATCH 0/5] DaVinci VPIF: Support for DV preset and DV timings.

2010-10-28 Thread mats . randgaard
From: Mats Randgaard mats.randga...@tandberg.com Support for DV preset and timings added to vpif_capture and vpif_display drivers. Functions for debugging are added and the code is improved as well. Mats Randgaard (5): vpif_cap/disp: Add debug functionality vpif: Consolidate formats from

[PATCH 3/5] vpif_cap/disp: Add support for DV presets

2010-12-16 Thread mats . randgaard
From: Mats Randgaard mats.randga...@cisco.com - Added functions to set/get/query/enum DV presets for vpif_caputre and vpif_display. - The format specification table is extended with all the DV formats supportet by TVP7002. support DV formats. Signed-off-by: Mats Randgaard mats.randga

[PATCH 5/5] vpif_cap/disp: Cleanup, improved comments

2010-12-16 Thread mats . randgaard
From: Mats Randgaard mats.randga...@cisco.com Signed-off-by: Mats Randgaard mats.randga...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Murali Karicheri mkarich...@gmail.com Acked-by: Vaibhav Hiremath hvaib...@ti.com --- drivers/media/video/davinci/vpif.h | 13

[PATCH 0/5] DaVinci VPIF: Support for DV preset and DV timings.

2010-12-16 Thread mats . randgaard
From: Mats Randgaard mats.randga...@cisco.com Support for DV preset and timings added to vpif_capture and vpif_display drivers. Functions for debugging are added and the code is improved as well. Mats Randgaard (5): vpif_cap/disp: Add debug functionality vpif: Consolidate formats from

[PATCH 4/5] vpif_cap/disp: Added support for DV timings

2010-12-16 Thread mats . randgaard
From: Mats Randgaard mats.randga...@cisco.com Added functions to set and get custom DV timings. Signed-off-by: Mats Randgaard mats.randga...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Vaibhav Hiremath hvaib...@ti.com --- drivers/media/video/davinci/vpif_capture.c

[PATCH 1/5] vpif_cap/disp: Add debug functionality

2010-12-16 Thread mats . randgaard
From: Mats Randgaard mats.randga...@cisco.com The following functions are added to the drivers: - vpif_g_chip_ident - vpif_dbg_g_register - vpif_dbg_s_register - vpif_log_status Signed-off-by: Mats Randgaard mats.randga...@cisco.com Signed-off-by: Hans Verkuil hans.verk

[PATCH 2/5] vpif: Consolidate formats from capture and display

2010-12-16 Thread mats . randgaard
From: Mats Randgaard mats.randga...@cisco.com - The ch_params tables in vpif_capture.c and vpif_display.c are moved to a common table in vpif.c. Then it is easier to maintain the table. - The field fps is removed from the struct vpif_channel_config_params because it is not used. Signed-off

V4L2_IN_ST_NO_SYNC

2011-11-04 Thread Mats Randgaard
lock? Vertical sync lock? Both? Tuner locked on signal? Something else? A few lines above is V4L2_IN_ST_NO_H_LOCK described under Analog Video as No horizontal sync lock. Is V4L2_IN_ST_NO_SYNC the same as V4L2_IN_ST_NO_H_LOCK, but for digital video? Anyone who knows? Regards, Mats

v4l2_mbus_config flags for CSI-2

2014-12-02 Thread Mats Randgaard (matrandg)
V4L2_MBUS_CSI2_CHANNEL_X according to the number of lanes in use? Thanks, Mats Randgaard -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: v4l2_mbus_config flags for CSI-2

2014-12-02 Thread Mats Randgaard (matrandg)
Thanks for responding so quickly, Sakari! On 12/02/2014 01:45 PM, Sakari Ailus wrote: Hi Mats, On Tue, Dec 02, 2014 at 12:49:07PM +0100, Mats Randgaard (matrandg) wrote: Hi, I am writing a driver for Toshiba TC358743 HDMI to CSI-2 bridge. The chip has four CSI lanes. Toshiba recommends

Re: [RFC v01] Driver for Toshiba TC358743 CSI-2 to HDMI bridge

2015-02-17 Thread Mats Randgaard (matrandg)
test if that works fine for you as well! Regards, Mats Randgaard -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v01] Driver for Toshiba TC358743 CSI-2 to HDMI bridge

2015-01-08 Thread Mats Randgaard (matrandg)
Thanks for testing the driver! On 01/08/2015 06:12 PM, Philipp Zabel wrote: Hi Mats, Am Montag, den 15.12.2014, 19:21 +0100 schrieb matra...@cisco.com: From: Mats Randgaard matra...@cisco.com The driver is tested on our hardware and all the implemented features works as expected. Missing

Re: [PATCH 16/16] [media] Add MAINTAINERS entry for the adv7180

2015-01-13 Thread Mats Randgaard (matrandg)
-device-drivers I think the web address should be http://ez.analog.com/community/video It is written much more about ADV7180 there, and people asking questions about video devices has been directed to the Video forum in the past. Regards, Mats Randgaard +S:Supported +F:drivers

Re: [RFC 02/12] [media] tc358743: register v4l2 asynchronous subdevice

2015-05-04 Thread Mats Randgaard (matrandg)
the kernel we use is too old to support async subdevs. Regards, Mats Randgaard + err = v4l2_async_register_subdev(sd); + if (err 0) + goto err_hdl; + INIT_DELAYED_WORK(state-delayed_work_enable_hotplug, tc358743_delayed_work_enable_hotplug

Re: [RFC 03/12] [media] tc358743: support probe from device tree

2015-05-04 Thread Mats Randgaard (matrandg)
present, .type = V4L2_CTRL_TYPE_BOOLEAN, + .min = 0, + .max = 1, + .step = 1, This is already fixed in the latest version of the driver. The rest of the code seems to be a hack for your hardware. Regards, Mats Randgaard .def = 0, .flags

Re: [RFC 05/12] [media] tc358743: fix lane number calculation to include blanking

2015-05-04 Thread Mats Randgaard (matrandg)
-vbackporch; By the way, V4L2_DV_BT_FRAME_WIDTH(bt) and V4L2_DV_BT_FRAME_HEIGHT(bt) can be used to calculate total frame width and height. Regards, Mats Randgaard u32 bits_pr_pixel = (state-mbus_fmt_code == MEDIA_BUS_FMT_UYVY8_1X16) ? 16 : 24; - u32 bps = bt-width

Re: [RFC 10/12] [media] tc358743: detect chip by ChipID instead of IntMask

2015-05-04 Thread Mats Randgaard (matrandg)
); + } tc358743_clear_interrupt_status(sd); Are there other registers that are not reset? If so, I think the driver should reset them all during initialization. Regards, Mats Randgaard -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [RFC 00/12] TC358743 async subdev and dt support

2015-05-04 Thread Mats Randgaard (matrandg)
return E2BIG from G_EDID The code seems fine to me, but I am not able to test it: * [media] tc358743: add direct interrupt handling * [media] tc358743: allow event subscription The rest of the patches are commented inline. Regards, Mats Randgaard On 03/30/2015 01:10 PM, Philipp Zabel wrote

Re: [RFC 04/12] [media] tc358743: fix set_pll to enable PLL with default frequency

2015-05-04 Thread Mats Randgaard (matrandg)
* pdata-pll_fbd) / pdata-pll_prd; Yes, that is a bug that should be fixed! The calculation of hsck is fixed in the latest version of the driver. Regards, Mats Randgaard -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: [RFC 00/12] TC358743 async subdev and dt support

2015-04-08 Thread Mats Randgaard (matrandg)
, Philipp Zabel wrote: Hi Mats, did you have time to work on the TC358743 driver some more in the meanwhile? These are the changes I have made locally to v1 to get it to work on i.MX6. regards Philipp Mats Randgaard (1): [media] Driver for Toshiba TC358743 CSI-2 to HDMI bridge Philipp Zabel (11

Re: [PATCH 1/4] tc358743: don't use variable length array for I2C writes

2015-08-12 Thread Mats Randgaard (matrandg)
; struct i2c_msg msg; - u8 data[2 + n]; + + if ((2 + n) sizeof(state-wr_data)) + v4l2_warn(sd, i2c wr reg=%04x: len=%d is too big!\n, + reg, 2 + n); msg.addr = client-addr; msg.buf = data; Acked-by: Mats Randgaard matra...@cisco.com

Re: [PATCH 2/3] [media] tc358743: Add OF device ID table

2017-02-22 Thread Mats Randgaard (matrandg)
CC: Philipp Zabel who added device tree support to this driver Regards, Mats Randgaard On 02/22/2017 05:11 PM, Javier Martinez Canillas wrote: The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption

Re: [PATCH] i2c: tc358743: remove useless variable assignment in tc358743_isr

2017-06-16 Thread Mats Randgaard (matrandg)
Thanks! You could remove intstatus &= ~MASK_HDMI_INT; in line 1289 as well. Regards, Mats Randgaard On 15/06/2017, 18:49, "Gustavo A. R. Silva" <garsi...@embeddedor.com> wrote: Remove useless variable assignment in function tc358743_isr(). The value stored in