Re: [PATCH] [media] gspca: Stop using GFP_DMA for buffers for USB bulk transfers

2018-05-13 Thread Adam Baker
to determine as it is dependent on the DMA controller in question. The USB stack now ensures that everything works correctly as long as the memory is allocated with kmalloc() so acked by me for sq905.c but, is anyone taking care of fixing the kmalloc() documentation? Adam Baker

Re: [PATCH 1/2] si2168: Implement own I2C adapter locking

2015-05-31 Thread Adam Baker
to that, it was possible tuner I2C message interrupts firmware command sequence. Reported-by: Adam Baker li...@baker-net.org.uk Signed-off-by: Antti Palosaari cr...@iki.fi --- Reviewed-by: Adam Baker li...@baker-net.org.uk Having looked over this I can't see any remaining deadlocks or failures to provide adequate

Re: [PATCH 2/2] si2157: implement signal strength stats

2015-05-31 Thread Adam Baker
On 29/05/15 22:05, Antti Palosaari wrote: Implement DVBv5 signal strength stats. Returns dBm. Signed-off-by: Antti Palosaari cr...@iki.fi --- Tested-by: Adam Baker li...@baker-net.org.uk I don't have the test gear to verify the absolute levels but the signal level readings were close

Locking in Si2157 and Si2168 drivers.

2015-05-10 Thread Adam Baker
bus and the bus on the far side of the gate. My current thought is that si2168_select doesn't need to take the si2168 i2c_mutex as the demod can't do anything with the bus anyway until the bus_lock is freed Thanks Adam Baker -- To unsubscribe from this list: send the line unsubscribe linux-media

divide error in dib7000p driver

2015-03-19 Thread Adam Baker
Hi, After upgrading my DVB recording PC I started observing the error shown below every couple of days (I've only shown the first instance but I usually get a pair of identical errors). Unfortunately I upgraded hardware and OS at the same time so it is hard to be certain exactly what the

Re: USB mini-summit at LinuxCon Vancouver

2011-08-10 Thread Adam Baker
On Tuesday 09 August 2011, Hans de Goede wrote: Hi, On 08/09/2011 10:31 PM, Adam Baker wrote: On Tuesday 09 August 2011, Hans de Goede wrote: snip It has also just occured to me that it might be possible to solve the issues we are facing just in the kernel. At the moment when

Re: USB mini-summit at LinuxCon Vancouver

2011-08-09 Thread Adam Baker
On Tuesday 09 August 2011, Hans de Goede wrote: Hi, On 08/09/2011 04:19 PM, Alan Stern wrote: Does it really make sense to combine 5 drivers into one? Right, that is not the plan. The plan is to simply stop having 2 drivers for 1 logical (and physical) block. So we go from 10 drivers,

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Adam Baker
libusb (The best hope I can think of at the moment is to get the distros to accept a patch for it to add the extra required API call(s) and for libgphoto to use the extra features in that patch if it detects it is supported at compile time). Adam Baker -- To unsubscribe from this list: send

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-08 Thread Adam Baker
On Monday 08 August 2011, Mauro Carvalho Chehab wrote: I will send a second reply to this message, which deals in particular with the list of abilities you outlined above. The point is, the situation as to that list of abilities is more chaotic than is generally realized. And when people

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-07 Thread Adam Baker
On Friday 05 August 2011, Hans de Goede wrote: This sounds to be a good theme for the Workshop, or even to KS/2011. Agreed, although we don't need to talk about this for very long, the solution is basically: 1) Define a still image retrieval API for v4l2 devices (there is only 1

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-07 Thread Adam Baker
On Monday 08 August 2011, Alan Stern wrote: On Sun, 7 Aug 2011, Adam Baker wrote: I've addec Hans de Geode and linux-usb to the CC as this response picks up on a related discussion about the usb mini summit. On Friday 05 August 2011, Theodore Kilgore wrote: If you can solve

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-04 Thread Adam Baker
/re-attaching-after-usb-detach-kernel-driver-np- td6068.html Adam Baker -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-04 Thread Adam Baker
and gamma correction that was copied from libgphoto2). Regards Adam Baker -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Workshop-2011] Media Subsystem Workshop 2011

2011-08-04 Thread Adam Baker
On Thursday 04 August 2011, Theodore Kilgore wrote: On Thu, 4 Aug 2011, Adam Baker wrote: On Thursday 04 August 2011, Theodore Kilgore wrote: As far as I know, /dev/sdx signifies a device which is accessible by something like the USB mass storage protocols, at the very least. So

Re: Power frequency detection.

2010-12-19 Thread Adam Baker
On Sunday 19 Dec 2010, Theodore Kilgore wrote: Finally, one concern that I have in the back of my mind is the question of control settings for a camera which streams in bulk mode and requires the setup of a workqueue. The owner of the camera says that he has encountered no problems with

Re: pac207: problem with Trust USB webcam

2010-02-16 Thread Adam Baker
which suggests that the packaged libv4l is fine and it is just the apps that are an issue. Adam Baker -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: libv4l release: 0.5.97: the whitebalance release!

2009-04-18 Thread Adam Baker
On Saturday 18 Apr 2009, Hans de Goede wrote: Ah, you are using v4l2-ctl, not v4l2ucp, and that uses V4L2_CTRL_FLAG_NEXT_CTRL control enumeration. My code doesn't handle V4L2_CTRL_FLAG_NEXT_CTRL (which is a bug). I'm not sure when I'll have time to fix this. Patches welcome, or in the mean

[PATCH][libv4l] Support V4L2_CTRL_FLAG_NEXT_CTRL for fake controls

2009-04-18 Thread Adam Baker
-off-by: Adam Baker li...@baker-net.org.uk --- This isn't extensively tested but v4l2ucp (and my version does use the flag) now lists both fake and original control for a camera with both and adds the fake controls for a camera with none. --- --- libv4l-0.5.97/libv4lconvert/control/libv4lcontrol.c

Re: libv4l release: 0.5.97: the whitebalance release!

2009-04-17 Thread Adam Baker
On Friday 17 Apr 2009, Hans de Goede wrote: I've tested it by plugging in the sq905 camera, verifying the whitebablance control is present and working, unplugging the sq905 and plugging in the pac207 and using up arrow to restart v4l2ucp and svv so I think I've eliminated most finger

Re: gpsca kernel BUG when disconnecting camera while streaming with mmap (2.6.29-rc8)

2009-04-02 Thread Adam Baker
On Thursday 02 Apr 2009, Stian Skjelstad wrote: Stian Skjelstad st...@nixia.no wrote: [snip] usb 2-2: USB disconnect, address 47 gspca: urb status: -108 gspca: urb status: -108 gspca: disconnect complete BUG: unable to handle kernel NULL pointer dereference at 0014 IP:

[PATCH v2 0/4] Sensor orientation reporting

2009-03-29 Thread Adam Baker
Hi, Based on the limited feedback from last time I'm assuming people are generally happy with this so I've updated according to Jean-Francois Moine's comments and added documentation. Again this features only the minimum changes in libv4l to make some use of the info. -- To unsubscribe from

Re: [PATCH v2 1/4] Sensor orientation reporting

2009-03-29 Thread Adam Baker
Add support to the SQ-905 driver to pass back to user space the sensor orientation information obtained from the camera during init. Modifies gspca and the videodev2.h header to create the necessary API. Signed-off-by: Adam Baker li...@baker-net.org.uk --- diff -r d8d701594f71 linux/drivers/media

[PATCH v2 2/4] Specify SHELL in documentation Makefile

2009-03-29 Thread Adam Baker
The Makefile for the V4L2 spec uses bash extensions but was using the default system shell, change it to explicitly request bash. Signed-off-by: Adam Baker li...@baker-net.org.uk --- diff -r d8d701594f71 v4l2-spec/Makefile --- a/v4l2-spec/MakefileSun Mar 29 08:45:36 2009 +0200 +++ b/v4l2

Re: [RFC][PATCH 1/2] Sensor orientation reporting

2009-03-27 Thread Adam Baker
On Friday 27 Mar 2009, Mauro Carvalho Chehab wrote: On Sun, 15 Mar 2009 22:29:48 + Adam Baker li...@baker-net.org.uk wrote: Add support to the SQ-905 driver to pass back to user space the sensor orientation information obtained from the camera during init. Modifies gspca

Re: [RFC][PATCH 0/2] Sensor orientation reporting

2009-03-16 Thread Adam Baker
On Monday 16 March 2009, Hans de Goede wrote: Both patches look good to me. A complaint about lack of documentation wouldn't have gone amiss. Unfortunately having just remembered that I should have done that I'm struggling to get the current docbook to compile (So far I've suffered Ubuntu not

[RFC][PATCH 0/2] Sensor orientation reporting

2009-03-15 Thread Adam Baker
Hi all, I've finally got round to writing a sample patch to support the proposed mechanism of reporting sensor orientation to user space. It is split into 2 parts, part 1 contains the kernel changes and part 2 the libv4l changes. In order to keep the patch simple I haven't attempted to add

[RFC][PATCH 2/2] Sensor orientation reporting

2009-03-15 Thread Adam Baker
Add check to libv4l of the sensor orientation as reported by VIDIOC_ENUMINPUT Signed-off-by: Adam Baker li...@baker-net.org.uk --- diff -r a647c2dfa989 v4l2-apps/lib/libv4l/libv4lconvert/libv4lconvert.c --- a/v4l2-apps/lib/libv4l/libv4lconvert/libv4lconvert.cTue Jan 20 11:25:54 2009

Re: Results of the 'dropping support for kernels 2.6.22' poll

2009-03-07 Thread Adam Baker
On Saturday 07 March 2009, Trent Piepho wrote: Audio was out of tree.  If they had a better system, like v4l-dvb does, they might well still be out of tree.  And aren't there some wireless packages that are out of tree? Wireless development is done in tree and then copied to a compat tree that

[PATCH] Support alternate resolutions for sq905

2009-03-03 Thread Adam Baker
Add support for the alternate resolutions offered by SQ-905 based cameras. As well as 320x240 all cameras can do 160x120 and some can do 640x480. Signed-off-by: Adam Baker li...@baker-net.org.uk --- The patch to detect orientation needs to follow this as that is also simplified by the modified

Re: [RFC] How to pass camera Orientation to userspace

2009-02-23 Thread Adam Baker
On Monday 23 February 2009, Mauro Carvalho Chehab wrote: On Sat, 21 Feb 2009 12:53:57 +0100 Hans Verkuil hverk...@xs4all.nl wrote: Hi Adam, Sorry for the late reply, it's been very busy. Me too. 1) Reuse the existing HFLIP and VFLIP controls, marking them as read-only Pros : No

Re: Adding a control for Sensor Orientation

2009-02-17 Thread Adam Baker
) And everyone agrees with the need to solve the issue you have. There was just the question of were to store that information. Whoever is pushing this change (you? Adam Baker? I must admit I'm not sure) should write a small RFC with possible solutions and pros and cons, post it, and when a consensus

[RFC] How to pass camera Orientation to userspace

2009-02-17 Thread Adam Baker
for backward compatibility). With no detection capability the driver provided info should be ignored for USB IDs in the built in table. Thoughts please Adam Baker -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Adding a control for Sensor Orientation

2009-02-14 Thread Adam Baker
v4l2_device. Thoughts please. Adam Baker -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

libv4l and HFLIP / VFLIP again

2009-02-07 Thread Adam Baker
listed in v4lconvert_flags so that eventually (once we are confident no-one running 2.6.29 will want a new libv4l) that functionality can be removed from libv4l. What is the preferred version of libv4l to prepare patches against? Is it http://linuxtv.org/hg/~hgoede/v4l-dvb Adam Baker

[PATCH v3] Add support for sq905 based cameras to gspca

2009-02-06 Thread Adam Baker
Add initial support for cameras based on the SQ Technologies SQ-905 chipset (USB ID 2770:9120) to V4L2 using the gspca infrastructure. Currently only supports one resolution and doesn't attempt to inform libv4l what image flipping options are needed. Signed-off-by: Adam Baker li...@baker

Re: [PATCH] Add support for sq905 based cameras to gspca

2009-02-04 Thread Adam Baker
On Wednesday 04 February 2009, Andy Walls wrote: On Tue, 2009-02-03 at 22:09 +, Adam Baker wrote: On Tuesday 03 February 2009, Jean-Francois Moine wrote: Indeed, the problem is there! You must have only one process reading the webcam! I do not see how this can work with these 2

Re: [PATCH] Add support for sq905 based cameras to gspca

2009-02-04 Thread Adam Baker
On Wednesday 04 February 2009, kilg...@banach.math.auburn.edu wrote: snip description of attempting to stream from 2 cameras at once 4. After removing the first camera which was plugged in, I tried to start the stream from the second one. The stream will not start. A message says that Cannot

Re: [PATCH] Add support for sq905 based cameras to gspca

2009-02-03 Thread Adam Baker
; Any use of that pointer past that point is a bug (the downside is that doing so would have turned the current bug into a hard to spot memory leak). At 03:37:35 Alan Stern wrote On Mon, 2 Feb 2009, Adam Baker wrote: This shouldn't be a problem for sq905 (which doesn't use these URBs

[PATCH] Make sure gspca cleans up USB resources during disconnect

2009-02-03 Thread Adam Baker
is still valid (multiple calls are OK as destroy_urbs checks for pointers already being NULL. Signed-off-by: Adam Baker li...@baker-net.org.uk --- diff -r 4d0827823ebc linux/drivers/media/video/gspca/gspca.c --- a/linux/drivers/media/video/gspca/gspca.c Tue Feb 03 10:42:28 2009 +0100 +++ b/linux

Re: Bug in gspca USB webcam driver

2009-02-02 Thread Adam Baker
(s) should be put in an error state and destroy_urbs() should be called immediately. Then when gspca_stream_off() calls destroy_urbs() again there would be no more work left to do. Alan Stern Adam Baker -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: Bug in gspca USB webcam driver

2009-02-02 Thread Adam Baker
On Monday 02 February 2009, Alan Stern wrote: On Mon, 2 Feb 2009, Adam Baker wrote: snip To summarize: Unplugging the camera while it is in use by a program causes an oops (particularly on an SMP machine). The problem is that gspca_stream_off() calls destroy_urbs(), which in turn

Re: RFC: Where to store camera properties (upside down, needs sw whitebalance, etc). ?

2009-01-16 Thread Adam Baker
On Friday 16 January 2009, Olivier Lorin wrote: snip discussion of cameras needing image flipping capability in libv4l The use of the buffer flags makes the life easier as this flag is read for every image. So we can solve for the flip/rotation issues with the help of two new buffer flags: