Re: [PATCH 05/24] media: v4l2-dev: convert VFL_TYPE_* into an enum

On Mon, Oct 09, 2017 at 07:19:11AM -0300, Mauro Carvalho Chehab wrote: > Using enums makes easier to document, as it can use kernel-doc > markups. It also allows cross-referencing, with increases the > kAPI readability. > All changes look legit. But I'd expect cx88_querycap() return type

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

Hi Anton, Nothing serious, just some purist nitpicking below. On Wed, Aug 02, 2017 at 06:17:02PM +0400, Anton Sviridenko wrote: > 24 GPIO pins from 32 available on solo6x10 chips are exported > to gpiolib. First 8 GPIOs are reserved for internal use on capture card > boards, GPIOs in range 8:15

Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

Colin Ian King <colin.k...@canonical.com> Acked-by: Andrey Utkin <andrey_ut...@fastmail.com>

Re: [PATCH] [media] solo6x10: fix detection of TW2864B chips

on these cards with > > [276582.344942] solo6x10 :07:00.0: Probing Softlogic 6110 > [276582.402151] solo6x10 :07:00.0: Could not initialize any techwell chips > [276582.402781] solo6x10: probe of :07:00.0 failed with error -22 > > Signed-off-by: Anton Sviridenko <

[PATCH 2/2] MAINTAINERS: solo6x10: update Andrey Utkin email

Updating my personal email address in solo6x10. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 026af206660b..885badfa4fa7 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 1/2] MAINTAINERS: solo6x10, tw5864: add Anton Sviridenko

Anton Sviridenko is now in charge of drivers in Bluecherry. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bdd1fe5..026af206660b 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

On Thu, May 18, 2017 at 11:06:43AM -0300, Mauro Carvalho Chehab wrote: > As such macro will check if the expression is true, it may fall through, as > warned: > On both cases, it means an error, so, let's return an error > code, to make gcc happy. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> Signed-off-by: Andrey Utkin <andrey_ut...@fastmail.com> Please welcome Anton who is now in charge of solo6x10 and tw5864 support and development in Bluecherry company, I have sent out to him the hardware samples I po

Re: [PATCH] [media] tveeprom: get rid of unused arg on tveeprom_hauppauge_analog()

On Fri, Mar 03, 2017 at 07:33:43AM -0300, Mauro Carvalho Chehab wrote: > tveeprom_hauppauge_analog() used to need the I2C adapter in > order to print debug messages. As it now uses pr_foo() facilities, > this is not needed anymore. > > So, get rid of it. Hi Mauro, Thanks for CCing :) > diff

Re: [PATCH] [media] tw5864: use dev_warn instead of WARN to shut up warning

on is correct. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks for the patch. Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> See the note below. > --- > drivers/media/pci/tw5864/tw5864-video.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

On Tue, Feb 28, 2017 at 09:20:53AM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin > <andrey.ut...@corp.bluecherry.net> wrote: > > Retcode checking takes place everywhere, but currently it overwrites > > supplied structs with potentially-unini

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

Hi Arnd, Thanks for sending this patch. On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: > tw5864_frameinterval_get() only initializes its output when it successfully > identifies the video standard in tw5864_input. We get a warning here because > gcc can't always track the state

Re: [PATCH 4/6] [media] tw5864: improve subscribe event handling

Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net>

Re: [PATCH 3/6] [media] solo6x10: improve subscribe event handling

Hi Gustavo, Thanks for the patches, and sorry for delay. Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net>

Re: [PATCH] solo6x10: use designated initializers

On Fri, Jan 06, 2017 at 01:21:10PM -0800, Kees Cook wrote: > > Since `ops` is static, what about this? > > For the variant given below, you have my signoff. > > > >> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c > >> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c > >> @@ -350,7 +350,7 @@

Re: [PATCH] solo6x10: use designated initializers

On Fri, Dec 16, 2016 at 05:05:36PM -0800, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from

Re: [PATCH v2] [media] cx88: make checkpatch.pl happy

Thanks for your hard work at beautification of this driver :) >From reviewing the diff over v1, it looks good. Also thanks for deep explanations you gave me for my comments. On Sat, Nov 19, 2016 at 07:27:30PM -0200, Mauro Carvalho Chehab wrote: > > Suggested-by: Andrey Utkin &

Re: [PATCH] [media] cx88: make checkpatch.pl happy

This is from checkpatch run on cx88 source files with "-f", not your patch files, right? I guess it might produce less changes if run on patches. On Sat, Nov 19, 2016 at 10:14:05AM -0200, Mauro Carvalho Chehab wrote: > Usually, I don't like fixing coding style issues on non-staging > drivers, as

Re: [PATCH 08/35] [media] cx88: convert it to use pr_foo() macros

gt; Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Reviewed-by: Andrey Utkin <andrey_ut...@fastmail.com> > --- a/drivers/media/pci/cx88/cx88-cards.c > +++ b/drivers/media/pci/cx88/cx88-cards

Re: [PATCH 09/35] [media] cx88: make checkpatch happier

broken. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Reviewed-by: Andrey Utkin <andrey_ut...@fastmail.com> > --- a/drivers/media/pci/cx88/cx88-cards.c > +++ b/drivers/media/pci/cx88/cx88-cards.c > @@ -2911,33 +2906,33 @@ static const struct { >

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, Oct 24, 2016 at 10:11:15PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 23:28:44 +0100 > Andrey Utkin <andrey_ut...@fastmail.com> escreveu: > > > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > > From: Markus Elfring

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 24 Oct 2016 22:08:47 +0200 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. >

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Mon, Oct 24, 2016 at 05:32:33PM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 28 Sep 2016 07:21:44 +0200 > khal...@piap.pl (Krzysztof Hałasa) escreveu: > > > Andrey Utkin <andrey_ut...@fastmail.com> writes: > > > > > Lockup happens only on 6010. I

Re: [PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

On Mon, Oct 24, 2016 at 06:57:25AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin <andrey.ut...@corp.bluecherry.net> writes: > > > --- a/drivers/media/pci/solo6x10/solo6x10.h > > +++ b/drivers/media/pci/solo6x10/solo6x10.h > > @@ -284,7 +284,10 @@ static inline u32

Re: [PATCH 1/1] [media] mb86a20s: always initialize a return value

On Sun, Oct 23, 2016 at 07:09:10PM +0200, Nicolas Iooss wrote: > Hello, > > I sent the following patch (available on > https://patchwork.kernel.org/patch/9325035/) a few weeks ago and got no > feedback even though the bug it fixes seems to still exist in > linux-next. Did I do something wrong?

Re: em28xx WinTV dualHD in Raspbian

On Sat, Oct 22, 2016 at 07:36:13PM +0200, ps0...@yahoo.de wrote: > Hopefully some driver expert can get the second tuner working, that would be > awesome What's the problem? I don't see it described in this discussion thread. -- To unsubscribe from this list: send the line "unsubscribe

[PATCH v2] media: solo6x10: fix lockup by avoiding delayed register write

g and barriers") Cc: sta...@vger.kernel.org Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- This is a second submission, the first one was "[PATCH] [media] solo6x10: avoid delayed register write" from 22 Sep 2016, with same content. Dear maintainers - please tak

Re: [PATCH] [media] solo6x10: avoid delayed register write

On Thu, Sep 22, 2016 at 03:03:31AM +0300, Andrey Utkin wrote: > This fixes a lockup at device probing which happens on some solo6010 > hardware samples. This is a regression introduced by commit e1ceb25a1569 > ("[media] SOLO6x10: remove unneeded register locking and barriers"

Re: [PATCH 54/57] [media] platform: don't break long lines

On Mon, Oct 17, 2016 at 09:44:19PM +0300, Laurent Pinchart wrote: > Hi Andrey, > > On Monday 17 Oct 2016 20:39:45 Andrey Utkin wrote: > > Maybe the remaining manual work may be outsourced to seekers of janitor > > tasks? > > I'm fine with that, but we should

Re: [PATCH] [media] tw5864: crop picture width to 704

On Thu, Sep 22, 2016 at 03:04:20AM +0300, Andrey Utkin wrote: > Previously, width of 720 was used, but it gives 16-pixel wide black bar > at right side of encoded picture. > > Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> > --- > drivers/media/pci/tw

Re: [PATCH 54/57] [media] platform: don't break long lines

On Mon, Oct 17, 2016 at 04:45:06PM +0300, Laurent Pinchart wrote: > If you really want to perform such a change, let's not make lines > unnecessarily long either. You should add a line break after the first and > second argument: > > dprintk(ctx->dev, > "%s

[PATCH v1] media: saa7146: Fix for "[BUG] process stuck when closing saa7146 [dvb_ttpci]"

x8f Reported-by: Philipp Matthias Hahn <pmhahn+vi...@pmhahn.de> Tested-by: Philipp Matthias Hahn <pmhahn+vi...@pmhahn.de> Signed-off-by: Andrey Utkin <andrey_ut...@fastmail.com> --- Dear maintainers, Please check whether the used buffer status (DONE) is correct for this situ

Re: [PATCH] [media] : Removing warnings caught by checkpatch.pl

On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote: > static int iss_video_queue_setup(struct vb2_queue *vq, > - unsigned int *count, unsigned int *num_planes, > - unsigned int sizes[], struct device > *alloc_devs[]) > +

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Tue, Sep 27, 2016 at 01:33:49PM +0200, Krzysztof Hałasa wrote: > Thanks. I can see you have quite a set of video devices there. > I will see what I can do with this. Yeah, I have got also 4-chip tw5864 board here :) Bluecherry decided to switch to it because they are available for retail

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Tue, Sep 27, 2016 at 07:27:53AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin <andrey_ut...@fastmail.com> writes: > > >> Does (only) adding the > >> > >>pci_read_config_word(solo_dev->pdev, PCI_STATUS, ); > >> > >> in s

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Mon, Sep 26, 2016 at 07:38:05AM +0200, Krzysztof Hałasa wrote: > Andrey Utkin <andrey_ut...@fastmail.com> writes: > > > On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > >> I wonder if the following fixes the problem (completely untested). >

Re: TW2866 i2c driver and solo6x10

So is the actual machine x86 or ARM? Do the tw28xx chips behind the bus (i2c as you said) show up in any way at all? Is something like i2c controller available? Or it's ARM and we should tell kernel how to "find" the i2c line by feeding correct devicetree to it? -- To unsubscribe from this list:

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Thu, Sep 22, 2016 at 10:51:37AM +0200, Krzysztof Hałasa wrote: > I wonder if the following fixes the problem (completely untested). I have given this a run, and it still hangs. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

[PATCH] [media] tw5864: crop picture width to 704

Previously, width of 720 was used, but it gives 16-pixel wide black bar at right side of encoded picture. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- drivers/media/pci/tw5864/tw5864-reg.h | 8 drivers/media/pci/tw5864/tw5864-video.c | 13 +++-- 2

[PATCH] [media] solo6x10: avoid delayed register write

alled from solo_motion_config(). This extra "flushing" is not fundamentally needed for every write, but apparently the code in driver assumes such behaviour at last in some places. Actual fix was proposed by Hans Verkuil. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> ---

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Wed, Sep 21, 2016 at 03:16:57PM +0200, Krzysztof Hałasa wrote: > Hans Verkuil writes: > > > That was probably the reason for the pci_read_config_word in the reg_write > > code. Try putting that back (and just that). > > Yes. I guess a single pci_read_config_word() would

tw5864 - call to hardware owners

Hi all, I would love to hear from anybody who owns any sample of PCIE board with TW5864 chip. It is possible to buy from here http://www.provideo.com.tw/Products.htm?link=web/DVR%20Card_Hardward.htm I guess there are more companies selling boards with it. So there is a driver, "tw5864",

Re: TW2866 i2c driver and solo6x10

I'm going to have quite constrained time for participation in this driver development, but still I think this is perspective project which is in line with trend of exposing internal details of complex media hardware for configuration by V4L2 framework. Also tw286x are used in both tw5864 and

[PATCH] Potential fix for "[BUG] process stuck when closing saa7146 [dvb_ttpci]"

Hi Philipp, Please try this patch. It is purely speculative as I don't have the hardware, but I hope my approach is right. --- drivers/media/common/saa7146/saa7146_video.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/common/saa7146/saa7146_video.c

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

On Thu, Sep 15, 2016 at 03:15:53PM +0200, Hans Verkuil wrote: > It could be related to the fact that a PCI write may be delayed unless > it is followed by a read (see also the comments in > drivers/media/pci/ivtv/ivtv-driver.h). Thanks for explanation! > That was probably the reason for the

solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

Hi Krzysztof, Me and one more solo6010 board user experience machine lockup when solo6x10 module is loaded on kernel series starting with 4.3 (despite solo6110 board probes just fine on all kernels). That is, 3.16, 3.18, 4.1 and 4.2 are tested and fine, and 4.3, 4.4, and others up to current

Re: [PATCH 0/2] [media] tw5864 constify some structures

On Tue, Sep 13, 2016 at 02:02:36AM +0300, Andrey Utkin wrote: > tw5864 is a recently submitted driver and it is currently present only > in media tree. Oops, have just fetched linux-next updates, tw5864 is already in next. -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 1/2] [media] tw5864: constify vb2_ops structure

Inspired by "[media] pci: constify vb2_ops structures" patch from Julia Lawall (dated 9 Sep 2016). Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- drivers/media/pci/tw5864/tw5864-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 2/2] [media] tw5864: constify struct video_device template

tw5864_video_template is used for filling of actual video_device structures. It is copied by value, and is not used for anything else. Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- drivers/media/pci/tw5864/tw5864-video.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 0/2] [media] tw5864 constify some structures

tw5864 is a recently submitted driver and it is currently present only in media tree. Recent patches submitted by Julia Lawall urged me to make similar changes in this driver. Andrey Utkin (2): [media] tw5864: constify vb2_ops structure [media] tw5864: constify struct video_device template

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

On Sat, Sep 10, 2016 at 01:21:10PM +0300, Oliver Collyer wrote: > > >> I have written a patch for FFmpeg that deals with the problem for both > >> devices so it’s not really an issue for me anymore, but I’m not sure > >> if the patch will get accepted in their master git as it’s a little > >>

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

On Sat, Sep 10, 2016 at 10:37:08AM +0300, Oliver Collyer wrote: > Ok, so I’ve provided all these logs requested by Andrey in an earlier > message but I’m unsubscribing from this list now. Fine. You'll be able to post here, as well as receive replies for this thread, without subscription. > I

Re: [PATCH] [media] pci: constify vb2_ops structures

On Fri, Sep 09, 2016 at 10:31:30PM +0800, Julia Lawall wrote: > Will this soon reach linux-next? No idea. Indeed it's simpler if you leave your patch as is, and then later we patch this new driver separately. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of

[PATCH] v4l2-ctl: Fix unneeded dot in "no hsync lock"

From: Andrey Utkin <andrey_ut...@fastmail.com> Signed-off-by: Andrey Utkin <andrey_ut...@fastmail.com> --- utils/v4l2-ctl/v4l2-ctl-io.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/v4l2-ctl/v4l2-ctl-io.cpp b/utils/v4l2-ctl/v4l2-ctl-io.cpp index e778

Re: [PATCH] [media] pci: constify vb2_ops structures

video.c|2 +- > 13 files changed, 13 insertions(+), 13 deletions(-) Applies and compiles cleanly on media tree. But please regenerate this patch on git://linuxtv.org/media_tree.git - it has a new driver by me, drivers/media/pci/tw5864 , which is affected. Otherwise Acked-by: A

Re: [PATCH] [media] pci: constify snd_pcm_ops structures

Thanks for looking into this. I have tested that it compiles and passes checks (C=2) cleanly after this patch. Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> While we're at it, what about constification of *-core.c:static struct pci_driver *_pci_driver = { *-video.c:static

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

On Tue, Sep 06, 2016 at 01:51:51PM +0300, Oliver Collyer wrote: > So today I installed Ubuntu 16.04 on another PC (this one a high spec machine > with a Rampage V Extreme motherboard) and I reproduced exactly the same > errors and trace. > > Rebooting the same PC back into Windows 10 and using

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

On Mon, Sep 05, 2016 at 10:43:49PM +0300, Oliver Collyer wrote: > I do not have any knowledge of uvcvideo and the associated classes apart from > the studying I’ve done the past day or two, but it seems likely that error > -71 and the later setting of V4L2_BUF_FLAG_ERROR are linked. Also, the

Re: [PATCH 1/2] [media] tw5864-core: remove double irq lock code

Just received a notification from patchwork that my alternative patch on this was rejected as not applicable. Thanks to Hans Verkuil - he has applied a reversion of Mauro's wrong patch and also applied my patch in his repo, git://linuxtv.org/hverkuil/media_tree.git (branch for-v4.9c). As I see

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

Hi! Seems like weird error in V4L subsystem or in uvcvideo driver, in the most standard usage scenario. Please retry with kernel and FFmpeg as new as possible, best if compiled from latest upstream sources. For kernel please try release 4.7.2 or even linux-next

Re: [PATCH 1/2] [media] tw5864-core: remove double irq lock code

Hi Mauro, Have you received my letter which is cited below? I also tried to get in touch with you on #linuxtv. On Thu, Aug 25, 2016 at 05:46:06PM +0300, Andrey Utkin wrote: > For some reason (maybe "unlisted recipients"?), my reply didn't get > through to maillists. Re

Re: [PATCH 1/2] [media] tw5864-core: remove double irq lock code

For some reason (maybe "unlisted recipients"?), my reply didn't get through to maillists. Resending my reply. On Wed, Aug 24, 2016, at 19:30, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/pci/tw5864/tw5864-core.c:160 tw5864_h264_isr() error: > double lock

[PATCH] [media] tw5864-core: remove excessive irqsave

is correct, but second irqsave is superfluous, and using same "flags" variable is just wrong. Reported-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Signed-off-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> --- drivers/media/pci/tw5864/tw5864-core.c | 4 ++-- 1 file

Re: [PATCH 2/2] [media] tw5864: remove two unused vars

On Wed, Aug 24, 2016 at 01:30:40PM -0300, Mauro Carvalho Chehab wrote: > Remove those two vars that aren't used, as reported by smatch: Acked-by: Andrey Utkin <andrey.ut...@corp.bluecherry.net> Sorry for missing this. Thanks a lot. -- To unsubscribe from this list: send the line &qu

Re: Linux support for current StarTech analog video capture device (SAA711xx)

On Fri, Aug 19, 2016 at 01:52:23PM +, Steve Preston wrote: > Hello everyone, > > Sorry for the slow response. Several people have offered to help and this is > greatly appreciated. I'm not the occultation person actually doing the dev > work on our Linux project. You should CC your Linux

Re: Linux support for current StarTech analog video capture device (SAA711xx)

On Tue, Aug 16, 2016 at 09:29:49PM +, Steve Preston wrote: > I realize this is a long shot but I was directed to this mailing list as one > possibility  . >   > I work with a group of amateur astronomers who use analog video cameras to > record occultations ( www.occulations.org ).  Several

Re: TW2866 i2c driver and solo6x10

On Wed, Aug 03, 2016 at 03:26:39PM -0500, Marty Plummer wrote: > An understanable sentement, but its not just about me (though I actually own > two > of the same dvr's). There is a large number, if reports are to be believed, of > more or less identical dvr systems with the same security holes

Re: TW2866 i2c driver and solo6x10

On Wed, Jul 27, 2016 at 11:51:22PM -0500, Marty Plummer wrote: > I have one of those rebranded chinese security dvrs, the ones with all the > gaping > security holes. I'd like to fix that up and setup a good rtsp server on it, > but > first comes low-level stuff, drivers and such. I've been

Re: [PATCH v4] [media] pci: Add tw5864 driver - fixed few style nits, going to resubmit soon

Found and fixed few very minor coding style nits, will resubmit in few days, now still waiting for comments to v4. https://github.com/bluecherrydvr/linux/commits/tw5864 commit 31f7c98a144cb3fb8a94662f002d9b6142d1f390 Author: Andrey Utkin <andrey.ut...@corp.bluecherry.net> Date: Wed Jul

Re: [PATCH v4] [media] pci: Add tw5864 driver

On Mon, Jul 11, 2016 at 09:40:53AM -0700, Joe Perches wrote: > Each of these blocks will start with the dev_ prefix > and the subsequent lines will not have the same prefix Yes. I have checked how it looks before submitting, but I didn't see this as a problem. I don't mind changing that (anyway I

Re: [PATCH v3] Add tw5864 driver

Thanks for review Hans! On Mon, Jul 11, 2016 at 07:58:38AM +0200, Hans Verkuil wrote: > > +" v4l2-ctl --device $dev --set-ctrl=video_gop_size=1; done\n" > > Replace $dev by /dev/videoX > > Wouldn't it make more sense to default to this? And show the warning only if > P-frames are enabled? I

[PATCH] media: solo6x10: increase FRAME_BUF_SIZE

In practice, devices sometimes return frames larger than current buffer size, leading to failure in solo_send_desc(). It is not clear which minimal increase in buffer size would be enough, so this patch doubles it, this should be safely assumed as sufficient. Signed-off-by: Andrey Utkin

Re: [PATCH v2] Add tw5864 driver

known video quality issues in a printed warning..."). On Fri, Jul 01, 2016 at 03:35:40PM +0200, Hans Verkuil wrote: > On 06/10/2016 12:11 AM, Andrey Utkin wrote: > > + cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS; > > This line can be dropped: the v4l2

Re: [PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

On Mon, Jun 27, 2016 at 11:12:42AM +0200, Hans Verkuil wrote: > Andrey, > > Since you are the original author, can you give me your Signed-off-by line? No, as increasing buffer size by few kilobytes doesn't change anything. I've increased it from 200 to 204, then found new occurances of the

Re: [PATCH v2] Add tw5864 driver

Update: added local change - to require fewer DMA buffers; - to require fewer vb2_queue buffers; - don't require vb2_queue buffers to be DMA-capable. https://github.com/bluecherrydvr/linux/commit/410a86b08d230ff2a401ac9f5be3b30f8b29f30d -- To unsubscribe from this list: send the line

How should I use kernel-defined i2c structs in this driver

Could anybody please give a hint - which kernel-defined i2c objects, and how many of them, I need to define and use to substitute these driver-defined functions i2c_read(), i2c_write() ? https://github.com/bluecherrydvr/linux/blob/release/tw5864/1.16/drivers/media/pci/tw5864/tw5864-config.c In a

Re: [PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

On Wed, May 04, 2016 at 01:21:20PM -0300, Ismael Luceno wrote: > From: Andrey Utkin <andrey.ut...@corp.bluecherry.net> > > Such frame size is met in practice. Also report oversized frames. > > [ismael: Reworked warning and commit message] > > Signed-off-by: Ismael Luc

Re: [PATCH 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

On Wed, May 4, 2016 at 5:04 PM, Hans Verkuil wrote: > BTW, looking at the MAINTAINERS file I see two email addresses for Andrey, > neither of which is the fastmail.com address this email came from. Now I'm replying from corporate email. > Andrey, it might be a good idea to

Re: [PATCH 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

On Sat, Apr 30, 2016 at 12:17:08AM -0300, Ismael Luceno wrote: > Such frame size is met in practice. Also report oversized frames. > > Based on patches by Andrey Utkin <andrey.ut...@corp.bluecherry.net>. If it is based on my patches([1] [2]), then why you claim authorship and wh

[PATCH] Add tw5864 driver - cover letter

From: Andrey Utkin <andrey.ut...@corp.bluecherry.net> This is a driver for multimedia devices based on Techwell/Intersil TW5864 chip. It is basically written from scratch. There was an awful reference driver for 2.6 kernel, which is nearly million lines of code and requires half a dozen s

[PATCH] Add tw5864 driver - cover letter

contacting manufacturer regarding such issues, but unfortunately they can do little to help us. Andrey Utkin (1): Add tw5864 driver MAINTAINERS |7 + drivers/staging/media/Kconfig|2 + drivers/staging/media/Makefile |1

Re: [RFC PATCH v0] Add tw5864 driver

On Fri, 11 Mar 2016 10:59:02 +0100 Hans Verkuil wrote: > While userspace may specify FIELD_ANY when setting a format, the > driver should always map that to a specific field setting and should > never return FIELD_ANY back to userspace. > > In this case, the 'field' field of

Re: [RFC PATCH v0] Add tw5864 driver

On Fri, 11 Mar 2016 09:00:18 +0100 Hans Verkuil wrote: > The reason is likely to be the tw5864_queue_setup function which has > not been updated to handle CREATE_BUFS support correctly. It should > look like this: > > static int tw5864_queue_setup(struct vb2_queue *q, >

Re: [RFC PATCH v0] Add tw5864 driver

Hi Hans! Some improvements took place on the driver, including cleaner v4l2-compliance tests passing. But there's a single test failure I don't understand. In the code of v4l2-compliance, it seems like an API call CREATE_BUFS is supposed to fail with EINVAL. But in case of my driver, which

Re: [RFC PATCH v0] Add tw5864 driver

METADATA etc. in my code. Please let me know if this can be sorted out in cleaner way. On Sun, Jan 3, 2016 at 7:38 AM, Leon Romanovsky <l...@leon.nu> wrote: > On Sun, Jan 03, 2016 at 03:41:42AM +0200, Andrey Utkin wrote: > >> +/* >> + * TW5864 driver - Exp-Golomb code

Re: On Lindent shortcomings and massive style fixing

On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab wrote: > IMHO, there are two problems by letting indent breaking long > lines: > > 1) indent would break strings on printks. This is something that we don't > want to break strings on multiple lines in the Kernel;

On Lindent shortcomings and massive style fixing

tps://github.com/bluecherrydvr/linux.git , branch tw5864_stable, drivers/staging/media/tw5864 Current output of "checkpatch.pl -f" for all source files in the driver is here: https://gist.github.com/andrey-utkin/12295148475e34ef948b Thanks in advance. -- To unsubscribe from this list: send the li

H264 headers generation for driver

This is a new chapter of tw5864 video grabber & encoder driver development drama. Last state of code is here (tw5864 branch, drivers/staging/media/tw5864): https://github.com/bluecherrydvr/linux/tree/tw5864/drivers/staging/media/tw5864 Currently I use a third-side LGPL library for H.264 headers

Help to debug h264 headers (or video) generation in kernel driver

I'm working on Linux kernel driver for multimedia grabber and H264 encoder based on Techwell/Intersil 5864 chip. Of course it will be open and pushed into upstream kernel. The device produces H264 encoded data, but it lacks any headers. The reference driver generates headers and glues frames

Re: [x264-devel] Help to debug h264 headers (or video) generation in kernel driver

On Sat, Sep 26, 2015 at 10:44 AM, Max Lapshin wrote: > Do you get some packets from this device or it is a bytestream? Oh hi a linux.org.ru buddy :) I get headerless binary data portions of known length, one portion for each encoded video frame. NAL headers generation is

Re: tw5864 driver development, help needed

An update: see there: http://ffmpeg.org/pipermail/ffmpeg-devel/2015-July/175796.html -- Bluecherry developer. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: tw5864 driver development, help needed

An update with a request for help. Asking for help with h264 headers generation. Both copying headers from similar videos and porting headers generation code from reference driver don't work for me (ref driver is weird and very complicated, so porting involved importing of lots of code, but still

Re: tw5864 driver development, help needed

On Fri, Jul 3, 2015 at 5:23 PM, Andrey Utkin andrey.ut...@corp.bluecherry.net wrote: Up... we are moving much slower than we expected, desperately needing help. Running reference driver with Ubuntu 9 (with kernel 2.6.28.10) with 16-port card shows that the reference driver fails to work

Re: Subjective maturity of tw6869, cx25821, bluecherry/softlogic drivers

On Fri, Jul 3, 2015 at 1:46 PM, Krzysztof Hałasa khal...@piap.pl wrote: Also, TW686x are (mini) PCIe while SOLO6110 (and earlier SOLO6010 which produces MPEG4 part 2 instead of H.264) are (mini) PCI. solo6110 is PCI-E, not PCI. -- Bluecherry developer. -- To unsubscribe from this list: send

Re: tw5864 driver development, help needed

On Wed, Jun 3, 2015 at 1:03 AM, Andrey Utkin andrey.ut...@corp.bluecherry.net wrote: Hi! I am working on making a Linux driver for TW5864-based videoaudio capture and encoding PCI boards. The driver is to be submitted for inclusion to Linux upstream. The following two links are links to boards

tw5864 driver development, help needed

Hi! I am working on making a Linux driver for TW5864-based videoaudio capture and encoding PCI boards. The driver is to be submitted for inclusion to Linux upstream. The following two links are links to boards available for buying: http://www.provideo.com.tw/web/DVR%20Card_TW-310.htm

Re: On register r/w macros/procedures of drivers/media/pci

On Mon, Apr 20, 2015 at 3:45 PM, Krzysztof Hałasa khal...@piap.pl wrote: Andrey Utkin andrey.ut...@corp.bluecherry.net writes: Please check first digit. I mean _5_864, in your post there's 6869. Ok, I just thought it may be a typo. I can now see 5864 is a H.264 encoder, while 686x

Re: On register r/w macros/procedures of drivers/media/pci

On Mon, Apr 20, 2015 at 2:18 PM, Krzysztof Hałasa khal...@piap.pl wrote: Andrey Utkin andrey.ut...@corp.bluecherry.net writes: I am starting a work on driver for techwell tw5864 media grabberencoder. If this is tw6864 then I have a driver mostly completed. Actually I'm using tw6869 but I

On register r/w macros/procedures of drivers/media/pci

I am starting a work on driver for techwell tw5864 media grabberencoder. I am basing on tw68 driver (mentorship, advising and testing by board owners are appreciated). And here (and in some other drivers/media/pci/ drivers) I see what confuses me: tw68-core.c: dev-lmmio =

Re: On register r/w macros/procedures of drivers/media/pci

On Sun, Apr 19, 2015 at 11:28 AM, Hans Verkuil hverk...@xs4all.nl wrote: Check the types of llmio and bbmio: u32 __iomem *lmmio; u8 __iomem *bmmio; So the values of the pointers are the same, but the types are not. So 'lmmio + 1' ==

  1   2   >