Re: [PATCH] media: s5p-jpeg: don't return a value on a void function

ed int exynos3250_jpeg_operating(void __iomem *regs) Reviewed-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com>

Re: [PATCH] media: s5p-jpeg: Fix off-by-one problem

el.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index faac816.

[PATCH 1/2] media: s5p-jpeg: don't overwrite result's "size" member

ent caused the actually used "size" member of the passed structure to assume a meaningless value. Fixes: 6c96dbbc2aa9f5b4a ("[media] s5p-jpeg: add support for 5433") Fixes: 14a2de14dc0619bf9 ("media: s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue") Sign

[PATCH 2/2] media: s5p-jpeg: set w/h when encoding

q_data w/h must be set when encoding. Fixes: 1c84e7f9d5dc596be (media: s5p-jpeg: Add support for resolution change event) Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 8 ++-- 1 file changed, 6 insertions(+), 2 del

[PATCH 0/2] More s5p-jpeg fixes

Hi All, The first patch in the series fixes decoding path, the second patch fixes encoding path. Please see appropriate commit messages. Andrzej Pietrasiewicz (2): media: s5p-jpeg: don't overwrite result's "size" member media: s5p-jpeg: set w/h when encoding drivers/media/platfor

[PATCH 1/5] media: platform: s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.

From: Tony K Nadackal In case of corrupt images, multiple interrupts may occur due to different error scenarios. Since we are removing the src and dest buffers in the first interrupt itself, crash occurs in the second error interrupts. Disable the global interrupt before

[PATCH 3/5] media: platform: s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function

se e.g. bootloader uses the codec and leaves it in a bad state. Signed-off-by: Tony K Nadackal <tony...@samsung.com> [Updated commit message] Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 1 file changed, 4 i

[PATCH 2/5] media: platform: s5p-jpeg: disable encoder/decoder in exynos4-like hardware after use

Clearing the bits turns off the encoder/decoder. If the hardware is not turned off after use, at subsequent uses it does not work in a stable manner, resulting in incorrect interrupt status value being read and e.g. erroneous read of compressed bitstream size. Signed-off-by: Andrzej Pietrasiewicz

[PATCH 4/5] media: platform: s5p-jpeg: fix number of components macro

The value to be processed must be first masked and then shifted, not the other way round. Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platfo

[PATCH 5/5] media: platform: s5p-jpeg: directly use parsed subsampling on 5433

On 5433 variant JPEG data is parsed by hardware only from SOS marker, so subsampling is parsed by software. As such, its value need not be translated from hardware-specific encoding to V4L2 encoding. Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5

[PATCH 0/5] s5p-jpeg fixes

, please see appropriate commit messages. Rebased onto Mauro's master. Andrzej Pietrasiewicz (3): media: platform: s5p-jpeg: disable encoder/decoder in exynos4-like hardware after use media: platform: s5p-jpeg: fix number of components macro media: platform: s5p-jpeg: directly use parsed

Re: [PATCH v3 8/8] [media] s5p-jpeg: Add stream error handling for Exynos5420

report BUF_STATE_ERROR to videobuf2. Signed-off-by: Henry-Ruey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 9 - 1 file cha

Re: [PATCH v3 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

lt;thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/j

Re: [PATCH v3 7/8] [media] s5p-jpeg: Add support for resolution change event

format before CAPTURE queues streamoff. This event is used in the Chromium browser project by the V4L2 JPEG Decode Accelerator (V4L2JDA) to allocate output buffer. Signed-off-by: Henry-Ruey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com>

Re: [PATCH v3 5/8] [media] s5p-jpeg: Split s5p_jpeg_parse_hdr()

-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 42 - 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/drivers/media/platf

Re: [PATCH v3 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

sca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platf

Re: [PATCH v3 3/8] [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr()

W dniu 27.06.2017 o 18:08, Thierry Escande pisze: This patch modifies the s5p_jpeg_parse_hdr() function so it only modifies the passed s5p_jpeg_q_data structure if the jpeg header parsing is successful. Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: A

Re: [PATCH v3 2/8] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

.@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.

Re: [PATCH v3 1/8] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 19 +++ 1 file changed, 19 i

Re: [PATCH v3 0/8] [media] s5p-jpeg: Various fixes and improvements

Hi Thierry, W dniu 27.06.2017 o 18:08, Thierry Escande pisze: Hi, This series contains various fixes and improvements for the Samsung s5p-jpeg driver. Most of these patches come from the Chromium v3.8 kernel tree. Thank you for the series. It looks good to me. Andrzej

Re: [PATCH v2 1/6] [media] s5p-jpeg: Reset the Codec before doing a soft reset

Hi Thierry, W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: Abhilash Kesavan This patch resets the encoding and decoding register bits before doing a soft reset. Here are my thoughts after consulting the documentation: Signed-off-by: Tony K Nadackal

Re: [PATCH v2 4/6] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

Hi Thierry, W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

Hi Thierry, W dniu 19.06.2017 o 15:50, Thierry Escande pisze: Hi Andrzej, On 16/06/2017 17:38, Andrzej Pietrasiewicz wrote: Hi Thierry, Thank you for the patch. Can you give a use case for resolution change event? Unfortunately, the original commit does not mention any clear use case. I've

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

Hi Thierry, Thank you for the patch. Can you give a use case for resolution change event? Also plase see inline. W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: henryhsu This patch adds support for resolution change event to notify clients so they can prepare

Re: [PATCH v2 6/6] [media] s5p-jpeg: Add stream error handling for Exynos5420

Hi Thierry, Thank you for the patch. Please see inline. W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: henryhsu On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means there is a syntax error or an unrecoverable error on compressed file when

Re: [PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

Hi, W dniu 13.06.2017 o 20:46, Jacek Anaszewski pisze: Hi Thierry, On 06/07/2017 02:34 PM, Thierry Escande wrote: Hi Jacek, On 02/06/2017 21:50, Jacek Anaszewski wrote: Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: From: Abhilash Kesavan This patch

Re: [PATCH 3/4] [media] s5p-jpeg: don't return a random width/height

value (although it shouldn't happen, in practice). So, explicitly set both to zero, just in case. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 8

Re: [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

Hi Mauro, W dniu 21.09.2015 o 13:41, Mauro Carvalho Chehab pisze: I think the media subsystem can take patches 1-3 and whoever does DT patches can take this patch, right? The cover letter explains that the series is rebased onto Mauro's master with Kukjin's branch merged. The latter does

Re: [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

Hi Hans, W dniu 21.09.2015 o 11:50, Hans Verkuil pisze: On 18-09-15 16:21, Andrzej Pietrasiewicz wrote: From: Marek Szyprowski <m.szyprow...@samsung.com> Add Exynos 5433 jpeg h/w codec node. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Signed-off-by: Andrzej P

[PATCH 1/4] s5p-jpeg: generalize clocks handling

t clocks are needed for each variant. This is a preparation for adding Exynos 5433 variant support, which needs 4 clocks of names not compatible with any previous version of jpeg hw module. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> [Rebase and commit message] Signed-off-by: Andr

[PATCH 0/4] Exynos 5433 jpeg h/w codec support

for 4.4. Rebased onto Mauro's master with the branch mentioned above merged. This patch series also adds Andrzej Pietrasiewicz and Jacek Anaszewski as maintainers of drivers/media/platform/s5p-jpeg. Andrzej is the original author of the driver, and has committed support for three Exynos chip models

[PATCH 3/4] MAINTAINERS: add exynos jpeg codec maintainers

Add Andrzej Pietrasiewicz and Jacek Anaszewski as maintainers of drivers/media/platform/s5p-jpeg. Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8133cef..ee9240b

[PATCH 2/4] s5p-jpeg: add support for 5433

elsewhere. There is also a difference in how the hardware is put to work in device_run. Data structures are extended as appropriate to accommodate the above changes. Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- .../bindings/media/exynos-jpeg-codec.txt

[PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

From: Marek Szyprowski <m.szyprow...@samsung.com> Add Exynos 5433 jpeg h/w codec node. Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 21 +++

[PATCH] media: s5p-jpeg: Eliminate double kfree

are not nullified between the two calls, so this is harmful. This patch fixes the driver so that video_device_release() is not called twice for the same object. Rebased onto Mauro's master. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 14

[PATCHv3 2/2] media: s5p-jpeg: add 5420 family support

JPEG IP found in Exynos5420 is similar to what is in Exynos3250, but there are some subtle differences which this patch takes into account. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- .../bindings/media/exynos-jpeg-codec.txt | 2 +- drivers/media/platform/s5p-jpeg

[PATCHv3 1/2] ARM: dts: exynos5420: add nodes for jpeg codec

Add nodes for jpeg codec in Exynos5420 SoC. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 73c1851

[PATCHv3 0/2] Support for JPEG IP on Exynos542x

v1..v2: - implemented changes resulting from Jacek's review - removed iommu entries in device tree nodes as iommu is not available at this moment - added hw3250_compat and htbl_reinit flags to s5p_jpeg_variant, which simplifies the code a bit Andrzej Pietrasiewicz (2): ARM: dts: exynos5420: add

[PATCHv2 1/2] ARM: dts: exynos5420: add nodes for jpeg codec

Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 73c1851..f8f583c 100644 --- a/arch/arm/boot/dts

[PATCHv2 2/2] media: s5p-jpeg: add 5420 family support

JPEG IP found in Exynos5420 is similar to what is in Exynos3250, but there are some subtle differences which this patch takes into account. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- .../bindings/media/exynos-jpeg-codec.txt | 2 +- drivers/media/platform/s5p-jpeg

[PATCHv2 0/2] Support for JPEG IP on Exynos542x

Jacek's review - removed iommu entries in device tree nodes as iommu is not available at this moment - added hw3250_compat and htbl_reinit flags to s5p_jpeg_variant, which simplifies the code a bit Andrzej Pietrasiewicz (2): ARM: dts: exynos5420: add nodes for jpeg codec media: s5p-jpeg: add

[PATCH 2/2] media: s5p-jpeg: add 5420 family support

JPEG IP found in Exynos5420 is similar to what is in Exynos3250, but there are some subtle differences which this patch takes into account. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- .../bindings/media/exynos-jpeg-codec.txt | 2 +- drivers/media/platform/s5p-jpeg

[PATCH 0/2] Support for JPEG IP on Exynos542x

This short series adds support for JPEG IP on Exynos542x SoC. The first patch adds necessary device tree nodes and the second one does JPEG IP support proper. The JPEG IP on Exynos542x is similar to what is on Exynos3250, there just slight differences. Andrzej Pietrasiewicz (2): ARM: dts

[PATCH 1/2] ARM: dts: exynos5420: add nodes for jpeg codec

Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 73c1851..c8722d9 100644 --- a/arch/arm/boot/dts

Re: [PATCH] usb: gadget: f_uvc fix transition to video_ioctl2

W dniu 28.08.2014 o 13:28, Laurent Pinchart pisze: snip diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c index 5209105..95dc1c6 100644 --- a/drivers/usb/gadget/function/f_uvc.c +++ b/drivers/usb/gadget/function/f_uvc.c @@ -411,6 +411,7 @@

[PATCH] usb: gadget: f_uvc fix transition to video_ioctl2

UVC video node is a TX device from the point of view of the gadget, so we cannot rely on the video struct being filled with zeros, because VFL_DIR_TX is actually 1. Suggested-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- drivers/usb

RE: [PATCH] [media] s5p-jpeg: Make the output format setting conditional

Hello, On March 19, 2012 12:35 PM Sachin Kamat wrote: Subject: [PATCH] [media] s5p-jpeg: Make the output format setting conditional S5P-JPEG IP on Exynos4210 SoC supports YCbCr422 and YCbCr420 as decoded output formats. But the driver used to fix the output format as YCbCr422. This is now

RE: [PATCH] media: jpeg: add driver for a version 2.x of jpeg H/W

Hello송영목, In general I think the v2x support should be designed to require as little code changes as possible, and they should be related to pure hardware differences only. Please see comments inline. The tables (quantization, Huffman) logically contain mostly the same data both in v3 and v2x

RE: [PATCH] media: jpeg: add driver for a version 2.x of jpeg H/W

On Monday, March 05, 2012 3:00 PM Andrzej Pietrasiewicz wrote: I forgot to sign my last post. One might think I was being rude. So I fix it below. Hello송영목, In general I think the v2x support should be designed to require as little code changes as possible, and they should be related

[PATCH] s5p-jpeg: Adapt to new controls

of the destination image for decoding, depending on the destination format. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-jpeg/jpeg-core.c | 17 ++--- 1 files changed, 10 insertions(+), 7

RE: [PATCH] media: vb2: vmalloc-based allocator user pointer handling

Hello Laurent, Thank you for quickly responding with a review. As for coding style remarks I generally agree. However, Guennadi seems to have a different opinion on one of them. On Wednesday, November 02, 2011 2:54 PM Laurent Pinchart wrote: This can cause an AB-BA deadlock, and will be

[PATCH] media: vb2: vmalloc-based allocator user pointer handling

vmalloc-based allocator user pointer handling Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/videobuf2-vmalloc.c | 86 ++- 1 files changed, 85 insertions(+), 1 deletions

RE: [PATCH 1/1] ARM: EXYNOS4: JPEG: driver initial release

Hello Sakari, On Saturday, October 15, 2011 12:08 PM, Sakari Ailus wrote: -Original Message- From: Sakari Ailus [mailto:sakari.ai...@iki.fi] Sent: Saturday, October 15, 2011 12:08 PM To: Andrzej Pietrasiewicz Cc: linux-media@vger.kernel.org; Kyungmin Park; Marek Szyprowski Subject

[PATCH 0/1] ARM: EXYNOS4: JPEG: driver initial release

the available formats are: V4L2_PIX_FMT_JPEG for source and V4L2_PIX_FMT_YUYV and V4L2_PIX_FMT_YUV420 for destination. In order for the driver to work a separate board definition and device registration patch is required; it is sent to linux-samsung-soc mailing list. Andrzej Pietrasiewicz Andrzej

RE: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates

Hello again, Mauro, On Thursday, January 13, 2011 9:46 AM Andrzej Pietrasiewicz wrote: Hello Mauro, On Wednesday, January 12, 2011 9:24 PM Mauro Carvalho Chehab wrote: Em 12-01-2011 08:25, Marek Szyprowski escreveu: Hello Mauro, I've rebased our fimc and saa patches onto