Re: Regression: DVBSky S960 USB tuner doesn't work in 4.10 or newer

On 04/18/2018 07:49 AM, Olli Salonen wrote: Thank you for your response Peter! Indeed, it seems strange. dvbsky.c driver seems to use mutex_lock in very much the same way as many other drivers. I've now confirmed that I can get a 4.10 kernel with working DVBSky S960 by reverting the following

Re: [PATCH v4] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

On 03/30/2018 04:21 PM, Akihiro TSUKADA wrote: I simply cannot see why it cannot work. Just add i2c adapter and suitable logic there. Transaction on your example is simply and there is no problem to implement that kind of logic to demod i2c adapter. I might be totally wrong, but... i2c

Re: [PATCH v4 1/5] dvb-frontends/dvb-pll: add i2c driver support

On 03/28/2018 08:00 PM, tsk...@gmail.com wrote: From: Akihiro Tsukada registers the module as an i2c driver, but keeps dvb_pll_attach() untouched for compatibility. Signed-off-by: Akihiro Tsukada --- Changes since v3: - use standard i2c_device_id instead

Re: [PATCH v4] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

On 03/28/2018 03:37 PM, Akihiro TSUKADA wrote: Hi, thanks for the comment. You should implement i2c adapter to demod driver and not add such glue to that USB-bridge. I mean that "relayed" stuff, i2c communication to tuner via demod. I2C-mux may not work I think as there is no gate-style

Re: [PATCH v3 1/5] dvb-frontends/dvb-pll: add i2c driver support

On 03/26/2018 09:06 PM, tsk...@gmail.com wrote: From: Akihiro Tsukada registers the module as an i2c driver, but keeps dvb_pll_attach() untouched for compatibility. Signed-off-by: Akihiro Tsukada --- drivers/media/dvb-frontends/dvb-pll.c | 49

Re: [PATCH v4] dvb-usb/friio, dvb-usb-v2/gl861: decompose friio and merge with gl861

On 03/27/2018 08:47 PM, tsk...@gmail.com wrote: From: Akihiro Tsukada Friio device contains "gl861" bridge and "tc90522" demod, for which the separate drivers are already in the kernel. But friio driver was monolithic and did not use them, practically copying those features.

[GIT PULL] af9013/af9015 improvements

to 3a11388095b992f0da01238adaec8b68cbad5c09: af9015: correct some coding style issues (2018-03-14 01:32:56 +0200) Antti Palosaari (18): af9013: change lock detection slightly af9013: dvbv5 signal strength af9013: dvbv5 cnr

[PATCH 07/18] af9013: convert inittabs suitable for regmap_update_bits

Convert inttabs to format (reg, mask, val) which are suitable parameters to pass directly for regmap_update_bits. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 62 +- drivers/media/dvb-frontends/af9013_priv.h

[PATCH 14/18] af9015: refactor copy firmware to slave demod

Small improvements. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 88 +-- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/usb/dvb-usb-v2/af

[PATCH 03/18] af9013: dvbv5 cnr

Implement dvbv5 cnr. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 88 +-- drivers/media/dvb-frontends/af9013_priv.h | 1 + 2 files changed, 84 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb-fro

[PATCH 10/18] af9013: remove all legacy media attach releated stuff

No one is binding that driver through media attach so remove it and all related dead code. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 80 drivers/media/dvb-frontends/af9013.h | 42 --- 2

[PATCH 05/18] af9013: wrap dvbv3 statistics via dvbv5

Driver has calculated dvbv5 statistics, so use those as a base for legacy dvbv3 statistics. Wrap and convert needed values to dvbv3, remove old dvbv3 statistic implementations. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c

[PATCH 15/18] af9015: enhance streaming config

sleep power consumption slightly. 3) Reduce USB buffersize slightly, from 130848 to 98136 bytes Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 220 ++ drivers/media/usb/dvb-usb-v2/af9015.h | 14 +-- 2 files change

[PATCH 04/18] af9013: dvbv5 ber and per

Implement dvbv5 ber and per. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 73 +++- 1 file changed, 72 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/

[PATCH 18/18] af9015: correct some coding style issues

Correct coding style issues reported mostly by checkpatch.pl. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 172 +- 1 file changed, 88 insertions(+), 84 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af901

[PATCH 06/18] af9015: fix logging

Pass correct device to dev_* logging functions, which allows us to remove redundant KBUILD_MODNAME and __func__ parameters from log format. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 160 +- 1 file chang

[PATCH 12/18] af9015: use af9013 demod pid filters

PID filters are moved to af9013 demod driver as those are property of demod. As pid filters are now implemented correctly by demod driver, we could enable pid filter support for possible slave demod too on dual tuner configuration. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers

[PATCH 08/18] af9013: add i2c mux adapter for tuner bus

Add muxed i2c adapter for demod tuner i2c bus gate control. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/Kconfig | 2 +- drivers/media/dvb-frontends/af9013.c | 126 +- drivers/media/dvb-frontends/af9013.h

[PATCH 09/18] af9015: attach demod using i2c binding

af9013 demod driver has i2c binding. Use it. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 158 -- drivers/media/usb/dvb-usb-v2/af9015.h | 4 +- 2 files changed, 96 insertions(+), 66 deletions(-) diff --git a/d

[PATCH 02/18] af9013: dvbv5 signal strength

Implement dvbv5 signal strength estimate. We know tuner dependent -80dBm and -50dBm agc values, construct line equation and use it to map agc value to signal strength estimate. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.

[PATCH 13/18] af9015: refactor firmware download

Small revise, no functional changes. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 39 +++ 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c b/drivers/media/u

[PATCH 01/18] af9013: change lock detection slightly

Whilst rewritten largely, the basic logic remains same with one exception: do not return immediately on success case. We are going to add statistics that function and cannot return too early. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.

[PATCH 17/18] af9015: convert to regmap api

Use regmap for chip register access. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/Kconfig | 1 + drivers/media/usb/dvb-usb-v2/af9015.c | 209 ++ drivers/media/usb/dvb-usb-v2/af9015.h | 2 + 3 files changed, 115 inse

[PATCH 16/18] dvb-usb-v2: add probe/disconnect callbacks

Add probe and disconnect callbacks that behaves similarly than ones used commonly on Linux driver model. We need those to get early / late access to driver in order to use normal probe time stuff, like regmap, extra bus adapters and so. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- d

[PATCH 11/18] af9013: add pid filter support

af9013 demod has pid filter. Add support for it. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 52 drivers/media/dvb-frontends/af9013.h | 5 2 files changed, 57 insertions(+) diff --git a/drivers/med

Re: [PATCH] media: dvb-usb-v2: stop using coherent memory for URBs

On 03/08/2018 09:09 PM, Mauro Carvalho Chehab wrote: There's no need to use coherent buffers there. So, let the DVB core do the allocation. That should give some performance gain outside x86. Hello! I am not familiar with that change, but I think you know what you do. Feel free to apply!

Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making code match

On 03/07/2018 06:39 PM, Ron Economos wrote: I'm almost 100% sure that the patch I submitted (and was committed in Linux 4.16-rc1) for the si2168 fixes Nigel's issue. I would suggest that Nigel's patch be retired.

Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code match

On 12/14/2017 04:48 PM, Mauro Carvalho Chehab wrote: Em Tue, 19 Sep 2017 13:13:52 +0100 Nigel Kettlewell escreveu: [re-sending as plain text] Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. Using firmware v4.0.11 the 292e would

Re: [PATCH v2 1/2] si2168: Add spectrum inversion property

On 01/18/2018 03:58 AM, Brad Love wrote: On 2018-01-17 16:08, Brad Love wrote: On 2018-01-17 16:02, Antti Palosaari wrote: On 01/17/2018 11:52 PM, Brad Love wrote: Some tuners produce inverted spectrum, but the si2168 is not currently set up to accept it. This adds an optional parameter

Re: [PATCH v2 1/2] si2168: Add spectrum inversion property

On 01/17/2018 11:52 PM, Brad Love wrote: Some tuners produce inverted spectrum, but the si2168 is not currently set up to accept it. This adds an optional parameter to set the frontend up to receive inverted spectrum. Parameter is optional and only boards who enable inversion will utilize

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

On 01/16/2018 10:14 PM, Brad Love wrote: On 2018-01-16 13:32, Antti Palosaari wrote: On 01/16/2018 07:31 PM, Brad Love wrote: On 2018-01-15 23:07, Antti Palosaari wrote: Hello And what is rationale here, is there some use case demod must be active and ts set to tristate (disabled)? Just put

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

On 01/16/2018 07:31 PM, Brad Love wrote: On 2018-01-15 23:07, Antti Palosaari wrote: Hello And what is rationale here, is there some use case demod must be active and ts set to tristate (disabled)? Just put demod sleep when you don't use it. regards Antti Hello Antti, Perhaps

Re: [PATCH 6/7] si2168: Announce frontend creation failure

hmmm, IIRC driver core even prints some error when driver probe fails? After that you could enable module debug logging to see more information. So I don't see point for that change. regards Antti On 01/12/2018 06:19 PM, Brad Love wrote: The driver outputs on success, but is silent on

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

Hello And what is rationale here, is there some use case demod must be active and ts set to tristate (disabled)? Just put demod sleep when you don't use it. regards Antti On 01/12/2018 06:19 PM, Brad Love wrote: Includes a function to set TS MODE property os si2168. The function either

Re: [PATCH 3/7] si2157: Add hybrid tuner support

media_entity_cleanup(>ent); + goto fail_instance; + } + } +#endif + mutex_unlock(_list_mutex); + + if (instance != 1) + dev_info(>dev, "Silicon Labs %s successfully attached\n", +

Re: [PATCH] [media] tda18212: fix use-after-free in tda18212_remove()

On 12/15/2017 08:40 PM, Daniel Scheller wrote: On Fri, 15 Dec 2017 20:12:18 +0200 Antti Palosaari <cr...@iki.fi> wrote: On 12/15/2017 08:00 PM, Daniel Scheller wrote: Hi, On Fri, 15 Dec 2017 19:30:18 +0200 Antti Palosaari <cr...@iki.fi> wrote: Thanks for your reply. H

Re: [PATCH] [media] tda18212: fix use-after-free in tda18212_remove()

On 12/15/2017 08:00 PM, Daniel Scheller wrote: Hi, On Fri, 15 Dec 2017 19:30:18 +0200 Antti Palosaari <cr...@iki.fi> wrote: Thanks for your reply. Hello I think shared frontend structure, which is owned by demod driver, should be there and valid on time tuner driver is removed. An

Re: [PATCH] [media] tda18212: fix use-after-free in tda18212_remove()

54.028991] == [ 154.029006] Disabling lock debugging due to kernel taint Fix this by removing the memcpy and the NULL assign. Cc: Antti Palosaari <cr...@iki.fi> Signed-off-by: Daniel Scheller <d.schel...@gmx.net> --- drivers/media/tuners/tda18212.c | 5

Re: rc-core: how to use hid (hardware) decoder?

On 07/15/2017 12:05 PM, Sean Young wrote: Hello, On Fri, Jul 14, 2017 at 04:14:05AM +0300, Antti Palosaari wrote: Moikka! Some remote controller receivers uses HID interface. I looked rc-core implementation, but failed to find how it could be used for hid. I need somehow get scancodes

rc-core: how to use hid (hardware) decoder?

Moikka! Some remote controller receivers uses HID interface. I looked rc-core implementation, but failed to find how it could be used for hid. I need somehow get scancodes and keycodes out from rc-core and write those to hardware which then generate hid events. Also, I am not sure if kernel

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 03:04 AM, Antti Palosaari wrote: On 07/13/2017 02:45 AM, Jasmin J. wrote: Hello Antti! Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 02:45 AM, Jasmin J. wrote: Hello Antti! Have you ever looked that coding style doc? Yes I read it several times already and used it in my daily work in my previous company. Beside the Multi-line comment style, which I will fix in a follow up, you mentioned other issues. Please

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 02:23 AM, Jasmin J. wrote: Hello Antti! Quickly looking this patch serie I noticed few other coding style mistakes. You should read kernel coding style documentation first, and then make changes according to doc. In fact I used checkpatch.pl to find the issues and fixed them.

Re: [PATCH] Added support for the TerraTec T1 DVB-T USB tuner [IT9135 chipset]

On 06/29/2017 08:55 PM, Nuno Henriques wrote: Signed-off-by: Nuno Henriques --- drivers/media/dvb-core/dvb-usb-ids.h | 1 + drivers/media/usb/dvb-usb-v2/af9035.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/media/dvb-core/dvb-usb-ids.h

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

On 07/13/2017 02:00 AM, Jasmin J. wrote: From: Jasmin Jessich Fixed all: WARNING: Block comments use * on subsequent lines Also multiline comments should be written like this: /* * Comment. */ Quickly looking this patch serie I noticed few other coding style mistakes.

Re: [PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

On 06/21/2017 06:50 PM, Daniel Scheller wrote: Am Wed, 21 Jun 2017 09:30:27 +0300 schrieb Antti Palosaari <cr...@iki.fi>: On 06/20/2017 08:45 PM, Daniel Scheller wrote: From: Daniel Scheller <d.schel...@gmx.net> Add signal-to-noise-ratio as provided by the demodulator in decibe

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

On 06/21/2017 08:20 PM, Mauro Carvalho Chehab wrote: Em Wed, 21 Jun 2017 19:14:40 +0200 Daniel Scheller escreveu: Am Wed, 21 Jun 2017 14:08:08 -0300 schrieb Mauro Carvalho Chehab : Em Wed, 21 Jun 2017 18:53:47 +0200 Daniel Scheller

Re: [PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

On 06/20/2017 08:45 PM, Daniel Scheller wrote: From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are

Re: [PATCH 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

On 06/20/2017 08:45 PM, Daniel Scheller wrote: From: Daniel Scheller This adds the basics to stv0367ddb_get_frontend() to be able to properly provide signal statistics in DVBv5 format. Also adds UCB readout and provides those values. Signed-off-by: Daniel Scheller

Re: [PATCH] [media] ddbridge: use pr_* macros in favor of printk

On 06/20/2017 08:44 PM, Daniel Scheller wrote: From: Daniel Scheller Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. This also improves the tda18212_ping reporting a bit so users know that if pinging wasn't successful, bad things might happen.

[GIT PULL 4.13] af9015/af9013 changes

to 2a32db020ab01e3ac99febad90a42112aa28b2ee: af9013: refactor power control (2017-06-18 05:42:25 +0300) Antti Palosaari (15): af9015: use correct 7-bit i2c addresses af9013: move config values directly under driver state

[PATCH 11/15] af9013: add configurable TS output pin

On serial TS mode output pin could be selected from D0 or D7. Add configuration option to for it. Rename TS mode config option prefix from AF9013_TS_ to AF9013_TS_MODE_. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.

[PATCH 03/15] af9013: add i2c client bindings

Add kernel i2c driver bindings. That allows dev_* logging, regmap and more. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 321 ++- drivers/media/dvb-frontends/af9013.h | 84 + 2 files changed, 241 inse

[PATCH 13/15] af9015: move 2nd demod power-up wait different location

We need to wait 2nd demod power-up before download firmware. Move that wait to more correct location. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-

[PATCH 10/15] af9015: enable 2nd TS flow control when dual mode

It needs to be enabled in order to get stream from slave af9013 demod. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9015.c b/d

[PATCH 07/15] af9013: fix error handling

Use typical (return 0/goto err/return err) error handling everywhere. Add missing error handling where missing. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 86 +--- 1 file changed, 51 insertions(+), 35 del

[PATCH 15/15] af9013: refactor power control

Move power-up and power-down functionality to init/sleep ops and get rid of old function. Fixes and simplifies power-up functionality slightly. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 93 ++-- 1 file chang

[PATCH 02/15] af9013: move config values directly under driver state

It shorten, as typed chars, access to config values as there is one pointer less. Also, when config/platform data is passed to driver there could be some values that are not relevant to store state as such or not needed to store at all. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- d

[PATCH 14/15] af9013: refactor firmware download routine

Refactor firmware download routine. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 65 +--- 1 file changed, 30 insertions(+), 35 deletions(-) diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/med

[PATCH 01/15] af9015: use correct 7-bit i2c addresses

Driver was using wrong "8-bit" i2c addresses for demods and tuners. Internal demod i2c address was not set at all. These are needed to be fixed before proper i2c client binding is used. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-

[PATCH 12/15] af9013: remove unneeded register writes

Removed register writes are already chip defaults, are not required, are set later or belong to AF9015 USB interface. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 42 1 file changed, 42 deletions(-) diff

[PATCH 08/15] af9013: add dvbv5 cnr

Add support for DVBv5 CNR. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c index a6b88ae..68091f2 100644 --- a/d

[PATCH 05/15] af9013: fix logging

We can simplify logging as we now have a proper i2c client to pass for kernel dev_* logging functions. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 202 +-- 1 file changed, 100 insertions(+), 102 deletions(-) diff

[PATCH 04/15] af9033: use kernel 64-bit division

Replace own binary division with 64-bit multiply and division. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/af9013.c | 34 +++ drivers/media/dvb-frontends/af9013_priv.h | 1 + 2 files changed, 4 insertions(+), 31 del

[PATCH 06/15] af9013: convert to regmap api

Use regmap for register access. Own low level i2c read and write routines for regmap is still needed because chip uses single command byte in addition to typical i2c register access. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/Kconfig | 1 + d

[PATCH 09/15] af9015: fix and refactor i2c adapter algo logic

* fix write+read when write has more than one byte * remove lock, not needed on that case * remove useless i2c msg send loop, as we support only write, read and write+read as one go and nothing more Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/usb/dvb-usb-v2/af9015.c

Re: [PATCH] dvb-usb-af9035: load HID table

Hello Jaroslav Škarvada kirjoitti 2017-06-09 20:46: Automatically load sniffed HID table from Windows driver if USB_VID_ITETECH:USB_PID_ITETECH_IT9135_9006 device is present (e.g. Evolveo Mars) or if module parameter force_hid_tab_load is set. There is few issues I don't like this approach.

Re: [media-af9013] question about return value in function af9013_wr_regs()

Gustavo A. R. Silva kirjoitti 2017-06-09 00:51: Hello everybody, While looking into Coverity ID 1227035 I ran into the following piece of code at drivers/media/dvb-frontends/af9013.c:595: The issue here is that the value stored in variable _ret_ at line 608, is not being evaluated as it

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 05/15/2017 11:28 PM, Andreas Kemnade wrote: Hi, On Sun, 23 Apr 2017 15:19:21 +0300 Antti Palosaari <cr...@iki.fi> wrote: On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si2

Re: [PATCH 1/3] [media] si2157: get chip id during probing

On 03/16/2017 12:22 AM, Andreas Kemnade wrote: If the si2157 is behind a e.g. si2168, the si2157 will at least in some situations not be readable after the si268 got the command 0101. It still accepts commands but the answer is just ff. So read the chip id before that so the information is

[GIT PULL 4.12] si2157: Si2141 tuner support

at: git://linuxtv.org/anttip/media_tree.git si2168 for you to fetch changes up to c9110a61811b9349ac64c3e50fd927c580e2eacd: si2157: Add support for Si2141-A10 (2017-04-06 16:48:52 +0300) Antti Palosaari (1): si2157: revert

[PATCH 1/2] si2157: revert si2157: Si2141/2151 tuner support

: Evgeny Plehov <evgenyple...@ukr.net> Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/tuners/si2157.c | 70 -- drivers/media/tuners/si2157_priv.h | 2 -- 2 files changed, 6 insertions(+), 66 deletions(-) diff --git a/drivers/

[PATCH 2/2] si2157: Add support for Si2141-A10

fan.bru...@rwth-aachen.de> Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/tuners/si2157.c | 23 +-- drivers/media/tuners/si2157_priv.h | 2 ++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/media/tuners/si2157.c b/drive

[GIT PULL 4.12] mn88472 statistics

to ea003f23ec598c46a31ad9bfe0e4d258f04edc0b: mn88472: implement PER statistics (2017-03-17 18:45:48 +0200) Antti Palosaari (3): mn88472: implement signal strength statistics mn88472: implement cnr statistics mn88472: implement PER statistics

[PATCH 3/3] mn88472: implement PER statistics

Implement DVBv5 PER. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/mn88472.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/media/dvb-frontends/mn88472.c b/drivers/media/dvb-frontends/mn88472.c index c7e5f63..f6938f96

[PATCH 1/3] mn88472: implement signal strength statistics

Implement DVBv5 signal strength on relative scale. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/mn88472.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/mn88472.c b/drivers/med

[PATCH 2/3] mn88472: implement cnr statistics

Implement DVBv5 CNR. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/mn88472.c | 90 +- drivers/media/dvb-frontends/mn88472_priv.h | 1 + 2 files changed, 88 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-fro

Re: [PATCH 12/13] [media] tuners/tda18212: add flag for retrying tuner init on failure

On 03/07/2017 08:57 PM, Daniel Scheller wrote: From: Daniel Scheller Taken from tda18212dd, first read after cold reset sometimes fails on some cards, trying twice shall do the trick. This is the case with the STV0367 demods soldered on the CineCTv6 bridge boards and older

Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

On 03/03/2017 08:35 PM, Brüns, Stefan wrote: On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote: The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and dvbsky driver are

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

On 02/16/2017 10:48 AM, Antti Palosaari wrote: On 02/16/2017 01:31 AM, Stefan Bruens wrote: +/* attach demod */ +memset(_config, 0, sizeof(si2168_config)); prefer sizeof dst You mean sizeof(struct si2168_config) ? yeah. See chapter 14 from kernel coding style documentation

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

coding style. Old code could be bad, but imho you could make new code better even it makes existing diver coding style slightly inconsistent. On Mittwoch, 15. Februar 2017 10:27:09 CET Antti Palosaari wrote: On 02/15/2017 03:51 AM, Stefan Brüns wrote: [...] diff --git a/drivers/media/usb/dvb

Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support

On 02/15/2017 03:51 AM, Stefan Brüns wrote: Mygica T230 DVB-T/T2/C USB stick support. It uses the same FX2/Si2168 bridge/demodulator combo as the other devices supported by the driver, but uses the Si2141 tuner. Several DVB-T (MPEG2) and DVB-T2 (H.265) channels were tested, as well as the

Re: [PATCH 2/3] si2157: Si2141/2151 tuner support.

7/2158 silicon tuner driver + * Silicon Labs Si2141/2146/2147/2148/2151/2157/2158 silicon tuner driver * * Copyright (C) 2014 Antti Palosaari <cr...@iki.fi> * @@ -75,6 +75,7 @@ static int si2157_cmd_execute(struct i2c_client *client, struct si2157_cmd *cmd) return ret;

Re: [PATCH 0/3] Add support for MyGica T230C DVB-T2 stick

On 02/12/2017 05:26 PM, Stefan Brüns wrote: The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and cxusb driver are mostly addition of the required IDs and some glue code.

Re: [PATCH 2/2] [media] cx231xx: Fix I2C on Internal Master 3 Bus

On 02/07/2017 09:35 PM, Oleh Kravchenko wrote: Internal Master 3 Bus can send and receive only 4 bytes per time. Signed-off-by: Oleh Kravchenko --- drivers/media/usb/cx231xx/cx231xx-core.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: rtl2832_sdr and /dev/swradio0

On 01/31/2017 07:50 PM, Russel Winder wrote: Hi, Is anyone actively working on the rtl2832_sdr driver? I am particularly interested in anyone who has code for turning the byte stream from /dev/swradio0 into an ETI stream. Or failing that getting enough data about the API for using

[GIT PULL 4.11] drop unused hd29l2 driver

to aacb6916b411c17d8372a5da46f94b39c5fd297a: hd29l2: remove unused driver (2017-01-27 19:25:19 +0200) Antti Palosaari (2): MAINTAINERS: remove hd29l2 hd29l2: remove unused driver MAINTAINERS

[GIT PULL 4.11] zd1301 usb interface + dvb-t demod driver

to 3b58fcff6d2578f83be4eb018274d6e82fcef426: mt2060: implement sleep (2017-01-27 18:44:37 +0200) Antti Palosaari (7): mt2060: add i2c bindings mt2060: add param to split long i2c writes zd1301_demod: ZyDAS ZD1301 DVB-T demodulator driver

[GIT PULL 4.11] af9035 misc changes

to 935e7e49e1cdf6f4c9beb1366c060fb1226c23ae: af9033: estimate cnr from formula (2016-12-19 18:38:23 +0200) Antti Palosaari (10): af9035: read and store whole eeprom af9033: convert to regmap api af9033: use 64-bit div

[GIT PULL 4.11] si2168 ber and ucb statistics

to 7a6d7b07e36a8161b56924d7e18a00f1b7e2436a: si2168: implement ucb statistics (2016-12-19 19:55:15 +0200) Antti Palosaari (2): si2168: implement ber statistics si2168: implement ucb statistics drivers/media/dvb-frontends

[PATCH 1/2] MAINTAINERS: remove hd29l2

Drop unused driver. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- MAINTAINERS | 10 -- 1 file changed, 10 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 52cc077..761a3cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5595,16 +5595,6 @@ L: lin

[PATCH 2/2] hd29l2: remove unused driver

Remove unused demod driver. Device that used it never went public. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-frontends/Kconfig | 7 - drivers/media/dvb-frontends/Makefile | 1 - drivers/media/dvb-frontends/hd29l2.c

[PATCH v3 3/7] zd1301_demod: ZyDAS ZD1301 DVB-T demodulator driver

ZyDAS ZD1301 is chip having USB interface and DVB-T demodulator integrated. This driver is for demodulator part. Driver is very reduced, just basic demodulator functionality, no statistics at all. It registers as a platform driver to driver core. Signed-off-by: Antti Palosaari <cr...@iki

[PATCH v3 6/7] MAINTAINERS: add zd1301 DVB USB interface driver

DVB USB interface driver for ZyDAS ZD1301 chip. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 26ae0ac..101be59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13389,6 +13389,1

[PATCH v3 7/7] mt2060: implement sleep

devices and it seems to be working, but I still consider it to be too risky to change it default. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/tuners/mt2060.c | 25 +++-- drivers/media/tuners/mt2060_priv.h | 8 2 files changed, 31 inse

[PATCH v3 5/7] zd1301: ZyDAS ZD1301 DVB USB interface driver

ZyDAS ZD1301 is chip having USB interface and DVB-T demodulator integrated. This driver is for USB interface part. Device has USB ID 0ace:13a1. Used tuner is MT2060. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/dvb-core/dvb-usb-ids.h | 1 + drivers/media/usb/dvb-

[PATCH v3 4/7] MAINTAINERS: add zd1301_demod driver

DVB-T demodulator driver for ZyDAS ZD1301 chip. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 52cc077..26ae0ac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13380,6 +13380,1

[PATCH v3 1/7] mt2060: add i2c bindings

Add proper i2c driver model bindings. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/tuners/mt2060.c | 83 ++ drivers/media/tuners/mt2060.h | 20 + drivers/media/tuners/mt2060_priv.h | 2 + 3 files changed, 105 inse

[PATCH v3 2/7] mt2060: add param to split long i2c writes

Add configuration parameter to split long i2c writes as some I2C adapters cannot write 10 bytes used as a one go. Signed-off-by: Antti Palosaari <cr...@iki.fi> --- drivers/media/tuners/mt2060.c | 21 + drivers/media/tuners/mt2060.h | 3 +++ drivers/media/

[GIT PULL 4.10] fix cxd2820r 4.9 regression

to 783d933cf02e970b49e0dcb586a76207aa6fa331: cxd2820r: fix gpio null pointer dereference (2017-01-23 10:40:17 +0200) Antti Palosaari (1): cxd2820r: fix gpio null pointer dereference drivers/media/dvb-frontends/cxd2820r_core.c

  1   2   3   4   5   6   7   8   9   10   >