[PATCH] media: marvel-ccic: mmp: select VIDEOBUF2_VMALLOC/DMA_CONTIG

2018-05-28 Thread Arnd Bergmann
file reveals that we need to select both VIDEOBUF2_DMA_CONTIG and VIDEOBUF2_VMALLOC, as already do for VIDEO_CAFE_CCIC. Fixes: 0a9c643c8faa ("media: marvel-ccic: re-enable mmp-driver build") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/marvell-ccic/Kconfi

[PATCH 5/5] media: omap2: fix compile-testing with FB_OMAP2=m

2018-05-25 Thread Arnd Bergmann
: d8555fd2f452 ("media: omap2: allow building it with COMPILE_TEST && DRM_OMAP") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/omap/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/omap/Kconfig b/dri

[PATCH 4/5] media: marvel-ccic: allow ccic and mmp drivers to coexist

2018-05-25 Thread Arnd Bergmann
module requires exporting a few symbols and adding the module license from the header. Fixes: 0a9c643c8faa ("media: marvel-ccic: re-enable mmp-driver build") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/marvell-ccic/Makefile| 9 - driver

[PATCH 3/5] media: cx231xx: fix RC_CORE dependency

2018-05-25 Thread Arnd Bergmann
. Fixes: 84545d2a1436 ("media: cx231xx: Remove RC_CORE dependency") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/usb/cx231xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/Kconfig b/drivers/media/usb/cx231

[PATCH 2/5] media: v4l: cadence: include linux/slab.h

2018-05-25 Thread Arnd Bergmann
-declaration] kzalloc() is declared in linux/slab.h, so let's include this to make it build in all configurations. Fixes: 84b477e6d4bc ("media: v4l: cadence: Add Cadence MIPI-CSI2 TX driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/cadence/cdns-csi2rx.c | 1

[PATCH 1/5] media: omap3isp: fix warning for !CONFIG_PM

2018-05-25 Thread Arnd Bergmann
functions as __maybe_unused as an easy workaround. Fixes: 243131134be4 ("media: omap3isp: Allow it to build with COMPILE_TEST") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/omap3isp/isp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 5:33 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > On Mon, May 07, 2018 at 04:36:45PM -0400, Arnd Bergmann wrote: >> On Mon, May 7, 2018 at 9:19 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> > On Mon, May 07, 2018 at 04:17:32PM

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 5:05 AM, Hans Verkuil <hverk...@xs4all.nl> wrote: > On 25/04/18 19:22, Mauro Carvalho Chehab wrote: >> Em Wed, 25 Apr 2018 17:58:25 +0200 >> Arnd Bergmann <a...@arndb.de> escreveu: >> >>> On Wed, Apr 25, 2018 at 5:26 PM, Christo

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 9:19 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > On Mon, May 07, 2018 at 04:17:32PM +0300, Laurent Pinchart wrote: >> On Thursday, 26 April 2018 00:30:10 EEST Arnd Bergmann wrote: >> > +int omap3isp_stat_request_statistics_tim

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-03 Thread Arnd Bergmann
On Thu, May 3, 2018 at 8:56 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > On Wed, Apr 25, 2018 at 11:30:10PM +0200, Arnd Bergmann wrote: >> @@ -165,7 +167,14 @@ struct omap3isp_h3a_aewb_config { >> * @config_counter: Number of the configuration associated with the dat

[PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-04-25 Thread Arnd Bergmann
the v4l2_get_timestamp() call. Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Cc: Sakari Ailus <sakari.ai...@iki.fi> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- I submitted this one in November and asked again in January, still waiting for a review so it can be applied. --- driv

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig <h...@infradead.org> wrote: > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote: >> That thought had occurred to me as well. I removed the oldest ISDN >> drivers already some years ago, and the OSS sound drivers &

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 9:21 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: >> > That probably also means it can use dma_mmap_coherent instead of the >> > handcrafted remap_pfn_range loop and the Pa

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-25 Thread Arnd Bergmann
On Wed, Apr 25, 2018 at 8:15 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Tue, Apr 24, 2018 at 10:40:45PM +0200, Arnd Bergmann wrote: >> @@ -221,6 +222,7 @@ struct zoran_fh { >> >> struct zoran_overlay_settings overlay_settings;

[PATCH] media: zoran: move to dma-mapping interface

2018-04-24 Thread Arnd Bergmann
No drivers should use virt_to_bus() any more. This converts one of the few remaining ones to the DMA mapping interface. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/pci/zoran/Kconfig| 2 +- drivers/media/pci/zoran/zoran.h| 10 +-- drivers/media/pci

Re: [PATCH 1/7] asm-generic, media: allow COMPILE_TEST with virt_to_bus

2018-04-24 Thread Arnd Bergmann
On Fri, Apr 20, 2018 at 7:42 PM, Mauro Carvalho Chehab wrote: > The virt_to_bus/bus_to_virt macros are arch-specific. Some > archs don't support it. Yet, as it is interesting to allow > doing compilation tests on non-ia32/ia64 archs, provide a > fallback for such archs.

Re: [PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Arnd Bergmann
epend on the first 6 patches, and are thus marked > RFC. This all looks fine to me. Acked-by: Arnd Bergmann <a...@arndb.de> Arnd

Re: [PATCH 02/16] media: omap3isp: allow it to build with COMPILE_TEST

2018-04-09 Thread Arnd Bergmann
lution could also be used to remove > the #ifdef inside drivers/iommu/ipmmu-vmsa.c. > > Yet, I think that the approach I proposed before is better, > but maybe arm maintainers may have a different opinion. > > Arnd, > > What do you think? I think including a foreign arch

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

2018-04-06 Thread Arnd Bergmann
On Fri, Apr 6, 2018 at 4:26 PM, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > Em Fri, 6 Apr 2018 16:16:46 +0200 > Arnd Bergmann <a...@arndb.de> escreveu: > >> On Fri, Apr 6, 2018 at 4:15 PM, Mauro Carvalho Chehab >> <mche...@s-opensource.com>

[PATCH 1/2] media: platform: fsl-viu: add __iomem annotations

2018-04-06 Thread Arnd Bergmann
This avoids countless sparse warnings like drivers/media/platform/fsl-viu.c:1081:25: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1082:25: sparse: incorrect type in argument 2 (different address spaces) Signed-off-by: Arnd Bergmann

[PATCH 2/2] media: platform: fsl-viu: mark local functions 'static'

2018-04-06 Thread Arnd Bergmann
conflicts. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/fsl-viu.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c index cc85620267f1..38c9be51f01f 100644 --- a/drivers

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

2018-04-06 Thread Arnd Bergmann
On Fri, Apr 6, 2018 at 4:15 PM, Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > Em Fri, 6 Apr 2018 11:51:16 +0200 > Arnd Bergmann <a...@arndb.de> escreveu: > >> On Fri, Apr 6, 2018 at 11:47 AM, Mauro Carvalho Chehab >> <mche...@s-opensource.com>

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

2018-04-06 Thread Arnd Bergmann
> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Reviewed-by: Arnd Bergmann <a...@arndb.de>

Re: [PATCH 05/16] media: fsl-viu: allow building it with COMPILE_TEST

2018-04-05 Thread Arnd Bergmann
On Thu, Apr 5, 2018 at 7:54 PM, Mauro Carvalho Chehab wrote: > There aren't many things that would be needed to allow it > to build with compile test. > +/* Allow building this driver with COMPILE_TEST */ > +#ifndef CONFIG_PPC_MPC512x > +#define NO_IRQ 0 The NO_IRQ

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-05 Thread Arnd Bergmann
On Thu, Apr 5, 2018 at 8:29 AM, Ulf Hansson wrote: > On 4 April 2018 at 21:56, Boris Brezillon wrote: >> On Wed, 04 Apr 2018 21:49:26 +0200 >> Robert Jarzmik wrote: >> >>> Ulf Hansson writes:

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Arnd Bergmann
On Tue, Apr 3, 2018 at 5:18 PM, Robert Jarzmik <robert.jarz...@free.fr> wrote: > Arnd Bergmann <a...@arndb.de> writes: > >>> + { "smc911x.0", "rx", PDMA_FILTER_PARAM(LOWEST, -1) }, >>> + { "smc911x.0", &quo

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > Hi, > > This serie is aimed at removing the dmaengine slave compat use, and transfer > knowledge of the DMA requestors into architecture code. > > This was discussed/advised by Arnd a couple of years back, it's almost

Re: [PATCH 12/15] dmaengine: pxa: make the filter function internal

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 6:35 PM, kbuild test robot wrote: > >drivers/mtd/nand/marvell_nand.c:2621:17: sparse: undefined identifier > 'pxad_filter_fn' >>> drivers/mtd/nand/marvell_nand.c:2621:17: sparse: call with no type! >In file included from

Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > > +static struct pxa_ssp_info pxa_ssp_infos[] = { > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + { .dma_chan_rx_name = "ssp1_rx", .dma_chan_tx_name = "ssp1_tx", }, > + {

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Arnd Bergmann
On Mon, Apr 2, 2018 at 4:26 PM, Robert Jarzmik wrote: > + > +static const struct dma_slave_map pxa_slave_map[] = { > + /* PXA25x, PXA27x and PXA3xx common entries */ > + { "pxa-pcm-audio", "ac97_mic_mono", PDMA_FILTER_PARAM(LOWEST, 8) }, > + {

[PATCH 20/47] media: platform: remove blackfin capture driver

2018-03-14 Thread Arnd Bergmann
The blackfin architecture is getting removed, so the video capture driver is also obsolete. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/Kconfig | 2 - drivers/media/platform/Makefile| 2 - drivers/media/platform/blackfin/K

[PATCH 21/47] media: platform: remove m32r specific arv driver

2018-03-14 Thread Arnd Bergmann
The m32r architecture is getting removed, so this one is no longer needed. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/Kconfig | 20 - drivers/media/platform/Makefile | 2 - drivers/media/platform/arv.c| 884 3

[PATCH 00/47] arch-removal: device drivers

2018-03-14 Thread Arnd Bergmann
. For anything else, I'd keep the removal patches in my asm-generic tree and will send a pull request for 4.17 along with the actual arch removal. Arnd Arnd Bergmann edac: remove tile driver net: tile: remove ethernet drivers net: adi: remove blackfin ethernet drivers net: 8390: remove m32r

[PATCH] media: imx: work around false-positive warning

2018-03-13 Thread Arnd Bergmann
ion, as a last resort, this adds an explicit zero-intialization of the structure. Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/staging/media/imx/imx-media-csi.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] media: ngene: avoid unused variable warning

2018-03-13 Thread Arnd Bergmann
'pdev' [-Werror=unused-variable] Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk() to dev_*() macros") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/pci/ngene/ngene-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] media: v4l: omap_vout: vrfb: remove an unused variable

2018-03-13 Thread Arnd Bergmann
media: v4l: omap_vout: vrfb: Use the wrapper for prep_interleaved_dma()") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/omap/omap_vout_vrfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/omap/omap_vout_vrfb.c b/drivers/med

[PATCH] media: cxd2880-spi: avoid out-of-bounds access warning

2018-03-13 Thread Arnd Bergmann
U8_MAX. Fixes: bd24fcddf6b8 ("media: cxd2880-spi: Add support for CXD2880 SPI interface") Cc: Martin Sebor <mse...@gmail.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/spi/cxd2880-spi.c | 24 +++- 1 file changed, 7 insertions(+), 17 de

Re: [PATCH 00/13] Remove metag architecture

2018-03-07 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 12:38 AM, James Hogan wrote: > These patches remove the metag architecture and tightly dependent > drivers from the kernel. With the 4.16 kernel the ancient gcc 4.2.4 > based metag toolchain we have been using is hitting compiler bugs, so > now seems a

[PATCH] media: renesas-ceu: mark PM functions as __maybe_unused

2018-02-28 Thread Arnd Bergmann
media: platform: Add Renesas CEU driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/platform/renesas-ceu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c in

[PATCH 2/2] media: ov5695: mark PM functions as __maybe_unused

2018-02-26 Thread Arnd Bergmann
: 'ov2685_runtime_resume' defined but not used [-Werror=unused-function] static int ov2685_runtime_resume(struct device *dev) This marks the affected functions as __maybe_unused. Fixes: e3861d9118c8 ("media: ov2685: add support for OV2685 sensor") Signed-off-by: Arnd Bergmann <

[PATCH 1/2] media: ov5695: mark PM functions as __maybe_unused

2018-02-26 Thread Arnd Bergmann
: error: 'ov5695_runtime_resume' defined but not used [-Werror=unused-function] static int ov5695_runtime_resume(struct device *dev) This marks the affected functions as __maybe_unused. Fixes: 8a77009be4be ("media: ov5695: add support for OV5695 sensor") Signed-off-by: Arnd Bergmann <

[PATCH] media: i2c: TDA1997x: add CONFIG_SND dependency

2018-02-23 Thread Arnd Bergmann
undefined! This adds the same Kconfig dependency that we have in other media drivers, using 'select SND_PCM' to ensure that we have can call snd_pcm_hw_constraint_minmax, while depending on CONFIG_SND_SOC for registering the codec. Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver dr

Re: [PATCH 00/13] Remove metag architecture

2018-02-23 Thread Arnd Bergmann
On Fri, Feb 23, 2018 at 12:02 PM, James Hogan <jho...@kernel.org> wrote: > On Fri, Feb 23, 2018 at 11:26:58AM +0100, Arnd Bergmann wrote: >> On Thu, Feb 22, 2018 at 12:38 AM, James Hogan <jho...@kernel.org> wrote: >> > So lets call it a day and drop the Meta architec

Re: [PATCH 00/13] Remove metag architecture

2018-02-23 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 12:38 AM, James Hogan wrote: > These patches remove the metag architecture and tightly dependent > drivers from the kernel. With the 4.16 kernel the ancient gcc 4.2.4 > based metag toolchain we have been using is hitting compiler bugs, so > now seems a

Re: stable-rc build: 3 warnings 0 failures (stable-rc/v4.14.20-119-g1b1ab1d)

2018-02-20 Thread Arnd Bergmann
On Tue, Feb 20, 2018 at 1:47 PM, Olof's autobuilder wrote: > Warnings: > > arm64.allmodconfig: > drivers/media/tuners/r820t.c:1334:1: warning: the frame size of 2896 bytes is > larger than 2048 bytes [-Wframe-larger-than=] Hi Greg, please add 16c3ada89cff ("media:

[PATCH] staging: media: atomisp: remove pointless string copy

2018-02-02 Thread Arnd Bergmann
: include/linux/string.h:253:9: error: '__builtin_strncpy' source argument is the same as destination [-Werror=restrict] return __builtin_strncpy(p, q, size); ^ This removes the bogus code, leaving the behavior otherwise unchanged. Signed-off-by: Arnd Bergmann

Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

2018-02-01 Thread Arnd Bergmann
On Thu, Feb 1, 2018 at 4:29 PM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Wed, Jan 31, 2018 at 10:37:37AM +0100, Arnd Bergmann wrote: >> On Wed, Jan 31, 2018 at 8:29 AM, Maxime Ripard > >> I can think of a couple of other problems that may or may not be &

Re: [linux-sunxi] Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

2018-02-01 Thread Arnd Bergmann
On Thu, Feb 1, 2018 at 9:32 AM, Maxime Ripard wrote: > On Wed, Jan 31, 2018 at 02:47:53PM +, Liviu Dudau wrote: >> On Wed, Jan 31, 2018 at 08:42:12AM +0100, Maxime Ripard wrote: >> > On Wed, Jan 31, 2018 at 03:08:08AM +, Liviu Dudau wrote: >> > > On Fri,

Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

2018-01-31 Thread Arnd Bergmann
On Wed, Jan 31, 2018 at 8:29 AM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > Hi Thierry, > > On Tue, Jan 30, 2018 at 11:01:50AM +0100, Thierry Reding wrote: >> On Tue, Jan 30, 2018 at 10:59:16AM +0100, Thierry Reding wrote: >> > On Tue, Jan 30, 2018 at 1

Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

2018-01-30 Thread Arnd Bergmann
On Tue, Jan 30, 2018 at 8:54 AM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Mon, Jan 29, 2018 at 03:34:02PM +0100, Arnd Bergmann wrote: >> On Mon, Jan 29, 2018 at 10:25 AM, Linus Walleij >> <linus.wall...@linaro.org> wrote: >> > On Mon, Ja

Re: [PATCH v7 2/2] media: V3s: Add support for Allwinner CSI.

2018-01-29 Thread Arnd Bergmann
On Mon, Jan 29, 2018 at 10:49 PM, Randy Dunlap wrote: > On 01/29/2018 01:21 AM, Yong Deng wrote: >> Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 >> interface and CSI1 is used for parallel interface. This is not >> documented in datasheet but by

Re: [PATCH v6 2/2] media: V3s: Add support for Allwinner CSI.

2018-01-29 Thread Arnd Bergmann
On Mon, Jan 29, 2018 at 10:25 AM, Linus Walleij wrote: > On Mon, Jan 29, 2018 at 9:25 AM, Maxime Ripard > wrote: >> On Sat, Jan 27, 2018 at 05:14:26PM +0100, Linus Walleij wrote: >> However, in DT systems, that >> field is filled only

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

2018-01-25 Thread Arnd Bergmann
es: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL > usage") > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> good catch! Acked-by: Arnd Bergmann <a...@arndb.de>

Re: [PATCH] [media] s3c-camif: array underflow in __camif_subdev_try_format()

2018-01-24 Thread Arnd Bergmann
On Wed, Jan 24, 2018 at 9:13 AM, Dan Carpenter wrote: > On Mon, Jan 22, 2018 at 09:50:04PM +0100, Sylwester Nawrocki wrote: >> On 01/22/2018 11:37 AM, Dan Carpenter wrote: > I happened to be looking at the same bugs but using Smatch. Did you get > these two bugs as

[PATCH] media: i2c: ov7740: use gpio/consumer.h instead of gpio.h

2018-01-18 Thread Arnd Bergmann
lem. Fixes: 39c5c4471b8d ("media: i2c: Add the ov7740 image sensor driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/i2c/ov7740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c

[PATCH] [v4] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
=69249#c3 Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v4: simplify a bit v3: fix newly introduced off-by-one bug. v2: rework logic rather than removing it. --- drivers/media/pl

Re: [PATCH] [v3] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 9:17 PM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Arnd, > > Thank you for the patch. > > On Tuesday, 16 January 2018 18:47:24 EET Arnd Bergmann wrote: >> While experimenting with older compiler versions, I ran >> in

Re: [PATCH 5/8] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-01-16 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 1:41 AM, Laurent Pinchart wrote: > Hi Arnd, > > Thank you for the patch. > > I'll try to review this without too much delay. In the meantime, I'm CC'ing > Sakari Ailus who might be faster than me :-) Hi Laurent and Sakari, I stumbled

Re: [PATCH] [v2] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 4:44 PM, Sakari Ailus wrote: >> if (camif_mbus_formats[i] == mf->code) >> break; >> >> + if (i == ARRAY_SIZE(camif_mbus_formats)) >> + mf->code = camif_mbus_formats[0]; >> + > > Either else

[PATCH] [v3] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
=69249#c3 Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v3: fix newly introduced off-by-one bug. v2: rework logic rather than removing it. --- drivers/media/platform/s3c-camif/cam

[PATCH] [v2] media: s3c-camif: fix out-of-bounds array access

2018-01-16 Thread Arnd Bergmann
=69249#c3 Fixes: babde1c243b2 ("[media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v2: rework logic rather than removing it. --- drivers/media/platform/s3c-camif/camif-capture.c | 7 +-- 1 file changed, 5

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

2018-01-14 Thread Arnd Bergmann
time_t, which requires the conversion function ktime_to_ns to be used on > some places. With this patch it will compile now also for older Kernel > versions. > > Signed-off-by: Jasmin Jessich <jas...@anw.at> Looks good to me, Acked-by: Arnd Bergmann <a...@arndb.de>

Re: [PATCH v2 1/1] media: entity: Add a nop variant of media_entity_cleanup

2018-01-11 Thread Arnd Bergmann
a few drivers around media_entity_cleanup(). > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Thanks for addressing this, Reviewed-by: Arnd Bergmann <a...@arndb.de>

Re: [PATCH 1/1] media: entity: Add a nop variant of media_entity_cleanupr

2018-01-10 Thread Arnd Bergmann
On Tue, Jan 9, 2018 at 11:31 PM, Sakari Ailus wrote: >> depends on VIDEO_V4L2_SUBDEV_API >> ---help--- >> This is a driver for the DW9714 camera lens voice coil. >> @@ -636,7 +636,6 @@ config VIDEO_OV5670 >> tristate "OmniVision

Re: [PATCH 1/1] media: entity: Add a nop variant of media_entity_cleanupr

2018-01-09 Thread Arnd Bergmann
On Tue, Jan 9, 2018 at 2:58 PM, Sakari Ailus wrote: > Add nop variant of media_entity_cleanup. This allows calling > media_entity_cleanup whether or not Media controller is enabled, > simplifying driver code. > > Also drop #ifdefs on a few drivers around

Re: [PATCH] media: i2c: ov7740: add media-controller dependency

2018-01-09 Thread Arnd Bergmann
On Tue, Jan 9, 2018 at 11:13 AM, Sakari Ailus <sakari.ai...@linux.intel.com> wrote: > Hi Arnd, > > On Mon, Jan 08, 2018 at 01:52:28PM +0100, Arnd Bergmann wrote: >> Without CONFIG_MEDIA_CONTROLLER, the new driver fails to build: >> >> drivers/perf/arm_dsu_pmu.

[PATCH] media: intel-ipu3: cio2: mark more PM functions as __maybe_unused

2018-01-08 Thread Arnd Bergmann
but not used [-Werror=unused-function] Fixes: 2086dd35705f ("media: intel-ipu3: cio2: mark PM functions as __maybe_unused") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- If my previous patch is not in a stable branch yet, folding the new fixup into that would be ideal. --- drivers

[PATCH] media: i2c: ov7740: add media-controller dependency

2018-01-08 Thread Arnd Bergmann
] This adds a dependency similar to what we have for other drivers like this. Fixes: 39c5c4471b8d ("media: i2c: Add the ov7740 image sensor driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] media: cobalt: select CONFIG_SND_PCM

2018-01-05 Thread Arnd Bergmann
t/cobalt.ko] undefined! ERROR: "snd_pcm_lib_ioctl" [drivers/media/pci/cobalt/cobalt.ko] undefined! ERROR: "snd_pcm_new" [drivers/media/pci/cobalt/cobalt.ko] undefined! The other audio drivers select 'SND_PCM' for this, so let's do the same. Signed-off-by: Arnd Bergmann <a

[PATCH] media: staging: tegra-vde: select DMA_SHARED_BUFFER

2018-01-05 Thread Arnd Bergmann
ers/staging/media/tegra-vde/tegra-vde.ko] undefined! Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/staging/media/tegra-vde/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/tegra-vde/Kconfig b/drivers/staging/media/tegra-vde/Kconfig index ec3dd

[PATCH] [v2] media: au0828: fix VIDEO_V4L2 dependency

2018-01-04 Thread Arnd Bergmann
so this makes the 'select' conditional on V4L2, and refines the dependencies in VIDEO_AU0828_V4L2 so it can only be enabled in the exact conditions that have VIDEOBUF2_VMALLOC reachable. Fixes: 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common") Fixes: 05439b1a3693 ("[med

Re: [PATCH 3/3] media: au0828: add VIDEO_V4L2 dependency

2018-01-04 Thread Arnd Bergmann
On Thu, Jan 4, 2018 at 11:31 AM, Arnd Bergmann <a...@arndb.de> wrote: > After the move of videobuf2 into the common directory, selecting the > au0828 driver with CONFIG_V4L2 disabled started causing a link failure, > as we now attempt to build videobuf2 but it still requires

[PATCH 2/3] media: dvb: fix DVB_MMAP dependency

2018-01-04 Thread Arnd Bergmann
not be a module if videobuf2 is built-in. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig index 3f69b948d102..d1be86ebfd9a 100644 --- a/drivers/media/Kconfig +++ b/drivers

[PATCH 3/3] media: au0828: add VIDEO_V4L2 dependency

2018-01-04 Thread Arnd Bergmann
ave. Fixes: 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common") Fixes: 05439b1a3693 ("[media] media: au0828 - convert to use videobuf2") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/usb/au0828/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/3] media: dvb: fix DVB_MMAP symbol name

2018-01-04 Thread Arnd Bergmann
CONFIG_DVB_MMAP was misspelled either as CONFIG_DVB_MMSP or DVB_MMAP, so it had no effect at all. This fixes that, to make it possible to build it again. Fixes: 4021053ed52d ("media: dvb-core: make DVB mmap API optional") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- driver

Re: [PATCH] media: don't drop front-end reference count for ->detach

2018-01-03 Thread Arnd Bergmann
On Wed, Jan 3, 2018 at 11:23 AM, Mauro Carvalho Chehab <mche...@kernel.org> wrote: > Em Tue, 2 Jan 2018 10:48:54 +0100 > Arnd Bergmann <a...@arndb.de> escreveu: >> @@ -2965,7 +2968,6 @@ void dvb_frontend_detach(struct dvb_frontend* fe) >> dvb_frontend_invoke_r

[PATCH] media: intel-ipu3: cio2: fix building with large PAGE_SIZE

2018-01-03 Thread Arnd Bergmann
e used on such an architecture, so the easiest workaround is to define the CIO2_PAGE_SIZE macro to the size that the hardware actually uses. Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/pci/intel/ipu3/ipu3

[PATCH] media: intel-ipu3: cio2: mark PM functions as __maybe_unused

2018-01-03 Thread Arnd Bergmann
' defined but not used [-Werror=unused-function] This marks them as __maybe_unused to shut up the warnings. Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 4 ++-- 1

[PATCH] media: don't drop front-end reference count for ->detach

2018-01-02 Thread Arnd Bergmann
ann <max.kellerm...@gmail.com> Cc: Wolfgang Rohdewald <wolfg...@rohdewald.de> Fixes: f686c14364ad ("[media] stb0899: move code to "detach" callback") Fixes: 6cdeaed3b142 ("media: dvb_usb_pctv452e: module refcount changes were unbalanced") Signed-off-by: Arn

Re: [PATCH] media: dvb_usb_pctv452e: module refcount changes were unbalanced

2017-12-18 Thread Arnd Bergmann
On Tue, Nov 28, 2017 at 12:33 PM, Wolfgang Rohdewald wrote: > @@ -913,6 +913,14 @@ static int pctv452e_frontend_attach(struct > dvb_usb_adapter *a) > >dev->i2c_adap); > if (!a->fe_adap[0].fe) > return

Re: [PATCH] em28xx: split up em28xx_dvb_init to reduce stack size

2017-12-15 Thread Arnd Bergmann
On Thu, Dec 14, 2017 at 6:10 PM, Mauro Carvalho Chehab <mche...@kernel.org> wrote: > Em Mon, 11 Dec 2017 13:05:02 +0100 > Arnd Bergmann <a...@arndb.de> escreveu: > >> With CONFIG_KASAN, the init function uses a large amount of kernel stack: >> >> drivers/med

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-12 Thread Arnd Bergmann
On Tue, Dec 12, 2017 at 1:45 PM, Mauro Carvalho Chehab wrote: > Em Tue, 12 Dec 2017 03:42:32 -0800 > Joe Perches escreveu: > >> > I actually thought about marking them 'const' here before sending >> > (without noticing the changelog text) and then ran into

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-12 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 10:17 PM, Michael Ira Krufky <mkru...@linuxtv.org> wrote: > On Mon, Dec 11, 2017 at 2:34 PM, Joe Perches <j...@perches.com> wrote: >> On Mon, 2017-12-11 at 13:06 +0100, Arnd Bergmann wrote: >>> With CONFIG_KASAN enabled, we get a relat

Re: [PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

2017-12-11 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 5:09 PM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > On Mon, 2017-12-11 at 12:30 +0100, Arnd Bergmann wrote: >> One patch that was meant as a cleanup apparently did more than it intended, >> allowing all combinations of legacy gadge

[PATCH] tuners: tda8290: reduce stack usage with kasan

2017-12-11 Thread Arnd Bergmann
', and this should result in better compiled code for everyone. I have another patch for the same symptom to patch tuner_i2c_xfer_*, and we actually want both of them. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/media/tuners/tda8290.c | 76 ++

[PATCH] em28xx: split up em28xx_dvb_init to reduce stack size

2017-12-11 Thread Arnd Bergmann
part of the switch/case statement that has its own local variables into a separate function, no single one of them uses more than 500 bytes, and with a noinline_for_stack annotation we can ensure that they are not merged back together. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- d

[PATCH 2/2] usb: gadget: webcam: fix V4L2 Kconfig dependency

2017-12-11 Thread Arnd Bergmann
of randconfig builds. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadget/legacy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/Kconfig b/drivers/usb/gadget/legacy/Kconfig index 2d80a9d1d5d9..fbd974965399 100644 --- a/drive

[PATCH 1/2] usb: gadget: restore tristate-choice for legacy gadgets

2017-12-11 Thread Arnd Bergmann
out USB_ETH") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/usb/gadget/Kconfig| 28 drivers/usb/gadget/legacy/Kconfig | 28 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/usb/gadget/

[PATCH] string.h: work around for increased stack usage

2017-12-05 Thread Arnd Bergmann
://patchwork.kernel.org/patch/9980413/ Link: https://patchwork.kernel.org/patch/9974047/ Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v3: don't use an asm barrier but use a constant string change. Aside from two other patches for drivers/media that I sent last week, this should fix all stack

Re: [PATCH 2/8] [media] uvc_video: use ktime_t for timestamps

2017-12-05 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 1:58 AM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Arnd, > > On Tuesday, 5 December 2017 02:37:27 EET Laurent Pinchart wrote: >> On Monday, 27 November 2017 15:19:54 EET Arnd Bergmann wrote: >> > uvc_video_get_ts() return

[PATCH v2] dvb-frontends: fix i2c access helpers for KASAN

2017-11-30 Thread Arnd Bergmann
for the argument variables, but on older compilers we can get the same behavior by taking the pointer of a local variable rather than the inline function argument. Cc: sta...@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <a...@arndb.de>

Re: [PATCH, RESEND 1/2] dvb-frontends: fix i2c access helpers for KASAN

2017-11-30 Thread Arnd Bergmann
On Thu, Nov 30, 2017 at 1:49 PM, Mauro Carvalho Chehab <mche...@kernel.org> wrote: >> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 >> Signed-off-by: Arnd Bergmann <a...@arndb.de> >> --- >> I'm undecided here whether there should be a comment

[PATCH, RESEND 1/2] dvb-frontends: fix i2c access helpers for KASAN

2017-11-30 Thread Arnd Bergmann
for the argument variables, but on older compilers we can get the same behavior by taking the pointer of a local variable rather than the inline function argument. Cc: sta...@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <a...@arndb.de> -

[PATCH, RESEND 2/2] r820t: fix r820t_write_reg for KASAN

2017-11-30 Thread Arnd Bergmann
=] This is caused by a gcc bug that has now been fixed in gcc-8. To work around the problem, we can pass the register data through a local variable that older gcc versions can optimize out as well. Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <a...@arndb

[PATCH] media: ov13858: select V4L2_FWNODE

2017-11-28 Thread Arnd Bergmann
a Kconfig 'select' statement like all the other users of this interface have. Fixes: 2e8a9fbb7950 ("media: ov13858: Add support for flash and lens devices") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- This is the same patch I submitted for et8ek8 earlier. Both are needed for 4.15. --

[PATCH v2] [media] vivid: use ktime_t for timestamp calculation

2017-11-27 Thread Arnd Bergmann
division gets turned into a multiplication on modern platforms, and we save multiple 32-bit divisions that can be expensive e.g. on ARMv7. Tested-by: Hans Verkuil <hans.verk...@cisco.com> Signed-off-by: Arnd Bergmann <a...@arndb.de> --- v2: fix a small mistake in the use_alternates

Re: [PATCH 6/8] [media] vivid: use ktime_t for timestamp calculation

2017-11-27 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 4:14 PM, Hans Verkuil wrote: >> - ktime_get_ts(); >> - use_alternates = ts.tv_sec % 10 >= 5; >> + timestamp = ktime_sub(ktime_get(), dev->radio_rds_init_time); >> + blk = ktime_divns(timestamp, VIVID_RDS_NSEC_PER_BLK); >> +

[PATCH v2] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Arnd Bergmann
-off-by: Arnd Bergmann <a...@arndb.de> --- v2: use min_t() as suggested by Andy Shevchenko --- drivers/staging/media/atomisp/i2c/ov2680.h| 1 - .../staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 19 --- drivers/staging/media/atomisp/i2c/ov5693/ov5693.h

Re: [Y2038] [PATCH 7/8] [media] staging: atomisp: convert timestamps to ktime_t

2017-11-27 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 4:05 PM, Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: > On Mon, 2017-11-27 at 14:19 +0100, Arnd Bergmann wrote: >> timespec overflows in 2038 on 32-bit architectures, and the >> getnstimeofday() suffers from possible time jumps, so t

[PATCH 8/8] [media] staging: imx: use ktime_t for timestamps

2017-11-27 Thread Arnd Bergmann
-off-by: Arnd Bergmann <a...@arndb.de> --- drivers/staging/media/imx/imx-media-csi.c | 8 ++-- drivers/staging/media/imx/imx-media-fim.c | 30 +- drivers/staging/media/imx/imx-media.h | 2 +- 3 files changed, 20 insertions(+), 20 deletions(-) diff

  1   2   3   4   5   6   7   8   >