Re: [PATCH v2 07/14] [media] s5p-mfc: Don't crash the kernel if the watchdog kicks in.

2014-10-21 Thread Arun Kumar K
Hi Kamil, Kiran will not be available to handle review comments of these patches. So I will be pushing the updated patchset rebased on media-tree. I hope all patches are good to merge except [media] s5p-mfc: Don't change the image size to smaller than the request. I will drop this one patch and

[PATCH v3 03/13] [media] s5p-mfc: clear 'enter_suspend' flag if suspend fails

2014-10-21 Thread Arun Kumar K
suspend will always return an error on subsequent tries. If clock off fails, disable hw_lock also. Signed-off-by: Prathyush K prathyus...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |8

[PATCH v3 00/13] Fixes from Chrome OS tree for MFC driver

2014-10-21 Thread Arun Kumar K
Upstreaming the fixes which have gone in to Chrome OS tree for MFC driver. Tested on MFCV8, MFCV7 and MFCV6 based Exynos5 based boards, peach-pi (5800), peach-pit (5420) and snow (5250). Changes from v2: 1) Rebased on latest media-tree 2) Dropped the patch (14/14) from previous set s5p-mfc:

[PATCH v3 01/13] [media] s5p-mfc: support MIN_BUFFERS query for encoder

2014-10-21 Thread Arun Kumar K
Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c index a904a1c..4816f31 100644 --- a/drivers

[PATCH v3 04/13] [media] s5p-mfc: Only set timestamp/timecode for new frames.

2014-10-21 Thread Arun Kumar K
...@google.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media

[PATCH v3 02/13] [media] s5p-mfc: Fix REQBUFS(0) for encoder.

2014-10-21 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org Handle REQBUFS(0) for CAPTURE queue as well. Also use the proper queue to call it on for OUTPUT. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers

[PATCH v3 05/13] [media] s5p-mfc: keep RISC ON during reset for V7/V8

2014-10-21 Thread Arun Kumar K
-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |1 + drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 25 ++- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h b

[PATCH v3 06/13] [media] s5p-mfc: check mfc bus ctrl before reset

2014-10-21 Thread Arun Kumar K
-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |1 + drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 25 - 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 07/13] [media] s5p-mfc: Don't crash the kernel if the watchdog kicks in.

2014-10-21 Thread Arun Kumar K
redesign of locking in the driver. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions

[PATCH v3 09/13] [media] s5p-mfc: De-init MFC when watchdog kicks in

2014-10-21 Thread Arun Kumar K
From: Arun Mankuzhi aru...@samsung.com If the software watchdog kicks in, we need to de-init MFC before reloading firmware and re-intializing it again. Signed-off-by: Arun Mankuzhi aru...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com

[PATCH v3 08/13] [media] s5p-mfc: modify mfc wakeup sequence for V8

2014-10-21 Thread Arun Kumar K
-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 78 +++-- 1 file changed, 61 insertions(+), 17 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c index 0d3661b

[PATCH v3 10/13] [media] s5p-mfc: flush dpbs when resolution changes

2014-10-21 Thread Arun Kumar K
-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c index 8798b14..7b1cf73

[PATCH v3 11/13] [media] s5p-mfc: Remove unused alloc field from private buffer struct.

2014-10-21 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org This field is no longer used as MFC driver doesn't use vb2 alloc contexts anymore. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform

[PATCH v3 13/13] [media] s5p-mfc: fix a race in interrupt flags handling

2014-10-21 Thread Arun Kumar K
intended to wait for. To prevent this, clear the flags only under hw_lock and before running a hardware job. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc

[PATCH v3 12/13] [media] s5p-mfc: fix V4L2_CID_MIN_BUFFERS_FOR_CAPTURE on resolution change.

2014-10-21 Thread Arun Kumar K
...@chromium.org Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform

Re: [PATCH 1/3] s5p-mfc: Fix selective sclk_mfc init

2014-07-08 Thread Arun Kumar K
Hi Jacek, On Tue, Jul 8, 2014 at 6:33 PM, Jacek Anaszewski j.anaszew...@samsung.com wrote: fc906b6d Remove special clock usage in driver removed initialization of MFC special clock, arguing that there's no need to do it explicitly, since it's one of MFC gate clock's dependencies and gets

Re: [PATCH 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-21 Thread Arun Kumar K
Hi Sachin, On Tue, May 20, 2014 at 5:15 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Arun, On 20 May 2014 15:47, Arun Kumar K arun...@samsung.com wrote: For MFC firmwares, improved versions with bug fixes and feature additions are released keeping the firmware version including major

[PATCH v2 0/3] Support for multiple MFC FW sub-versions

2014-05-21 Thread Arun Kumar K
/31735 Changes from v1 - Addressed nits pointed by Sachin on PATCH 2/3 Arun Kumar K (3): [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware [media] s5p-mfc: Support multiple firmware sub-versions [media] s5p-mfc: Add init buffer cmd to MFCV6 drivers/media/platform/s5p-mfc

[PATCH v2 1/3] [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware

2014-05-21 Thread Arun Kumar K
The function s5p_mfc_reload_firmware is exactly same as s5p_mfc_load_firmware. So removing the duplicate function. Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |2 +- drivers/media/platform/s5p

[PATCH v2 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-21 Thread Arun Kumar K
binaries for every version with the driver trying to load firmwares starting from latest. This ensures full backward compatibility regardless of which firmware version and kernel version is used. Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com --- drivers

[PATCH v2 3/3] [media] s5p-mfc: Add init buffer cmd to MFCV6

2014-05-21 Thread Arun Kumar K
Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command, in sync with v7. This patch adds this support for new v6 firmware. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com Reviewed-by: Tomasz Figa

[PATCH 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-20 Thread Arun Kumar K
binaries for every version with the driver trying to load firmwares starting from latest. This ensures full backward compatibility regardless of which firmware version and kernel version is used. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH 0/3] Support for multiple MFC FW sub-versions

2014-05-20 Thread Arun Kumar K
/31735 Arun Kumar K (3): [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware [media] s5p-mfc: Support multiple firmware sub-versions [media] s5p-mfc: Add init buffer cmd to MFCV6 drivers/media/platform/s5p-mfc/s5p_mfc.c| 11 +++--- drivers/media/platform/s5p-mfc

[PATCH 3/3] [media] s5p-mfc: Add init buffer cmd to MFCV6

2014-05-20 Thread Arun Kumar K
Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command, in sync with v7. This patch adds this support for new v6 firmware. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com --- drivers/media

[PATCH 1/3] [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware

2014-05-20 Thread Arun Kumar K
The function s5p_mfc_reload_firmware is exactly same as s5p_mfc_load_firmware. So removing the duplicate function. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 33

Re: [PATCH 2/2] v4l: s5p-mfc: Limit enum_fmt to output formats of current version

2014-05-19 Thread Arun Kumar K
Hi Kamil, Only a small correction. On Fri, May 16, 2014 at 5:33 PM, Kamil Debski k.deb...@samsung.com wrote: MFC versions support a different set of formats, this specially applies to the raw YUV formats. This patch changes enum_fmt, so that it only reports formats that are supported by the

[PATCH 06/10] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-05-19 Thread Arun Kumar K
Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 70f728f..297d681 100644 --- a/drivers/media/platform/s5p-mfc

[PATCH 01/10] [media] s5p-mfc: Copy timestamps only when a frame is produced.

2014-05-19 Thread Arun Kumar K
-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 89356ae..6ef6bd1 100644 --- a/drivers/media/platform

[PATCH 02/10] [media] s5p-mfc: Fixes for decode REQBUFS.

2014-05-19 Thread Arun Kumar K
() will fail otherwise. - Only verify state is MFCINST_INIT when allocating, not when freeing. - Refactor and simplify code. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 178

[PATCH 04/10] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-05-19 Thread Arun Kumar K
though. So move the allocation of private codec buffers to REQBUFS for OUTPUT queue. Also, move MFC instance opening and closing to REQBUFS as well, as it's tied to allocation and deallocation of private codec buffers. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K

[PATCH 08/10] [media] s5p-mfc: Move INIT_BUFFER_OPTIONS from v7 to v6

2014-05-19 Thread Arun Kumar K
The register S5P_FIMV_D_INIT_BUFFER_OPTIONS holds good for v6 firmware too. So moving the definition from v7 regs to v6. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h|1 + drivers/media/platform/s5p-mfc/regs-mfc-v7.h|2

[PATCH 07/10] [media] s5p-mfc: Update scratch buffer size for MPEG4

2014-05-19 Thread Arun Kumar K
Update the MPEG4 decoder scratch buffer size as per the new v6 firmware. This updation is increasing the size and so is backward compatible with older v6 firmwares. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |3 +-- 1 file changed, 1

[PATCH 05/10] [media] s5p-mfc: Update scratch buffer size for VP8 encoder

2014-05-19 Thread Arun Kumar K
Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v7.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/regs-mfc-v7.h b/drivers/media/platform/s5p-mfc/regs-mfc-v7.h index ea5ec2a..5dfa149 100644 --- a/drivers/media/platform

[PATCH 03/10] [media] s5p-mfc: Extract open/close MFC instance commands.

2014-05-19 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org This is in preparation for a new flow to fix issues with streamon, which should not be allocating buffer memory. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH 10/10] [media] s5p-mfc: Rename IS_MFCV7 macro

2014-05-19 Thread Arun Kumar K
Renaming the IS_MFCV7 macro to IS_MFCV7_PLUS for the addition of MFCv8 support which reuses the v7 code. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|2 +- drivers/media

[PATCH 1/2] [media] s5p-mfc: Core support to add v8 decoder

2014-05-19 Thread Arun Kumar K
-off-by: Arun Kumar K arun...@samsung.com --- .../devicetree/bindings/media/s5p-mfc.txt |3 +- drivers/media/platform/s5p-mfc/regs-mfc-v8.h | 94 drivers/media/platform/s5p-mfc/s5p_mfc.c | 31 +++ drivers/media/platform/s5p-mfc/s5p_mfc_common.h

[PATCH 0/2] Re-send MFCv8 support patches

2014-05-19 Thread Arun Kumar K
These 2 patches for MFCv8 support are rebased onto [1] with the dependencies as mentioned below. Changes include adding the MFC_V8 version to formats. - Re-send MFC patches https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31051.html - Adding version information to formats by

[PATCH 2/2] [media] s5p-mfc: Core support for v8 encoder

2014-05-19 Thread Arun Kumar K
Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v8.h| 30 drivers/media/platform/s5p-mfc/s5p_mfc.c|2 + drivers/media/platform/s5p-mfc/s5p_mfc_enc.c| 12 ++--- drivers/media/platform/s5p-mfc

Re: [PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-19 Thread Arun Kumar K
Hi Kamil, On 05/15/14 20:47, Kamil Debski wrote: Hi Arun, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Arun Kumar K Sent: Wednesday, May 14, 2014 10:10 AM Hi Hans, On 05/14/14 12:39, Hans Verkuil wrote: On 05/14/2014 08:29 AM, Arun

[PATCH v3] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-14 Thread Arun Kumar K
firmware which is a hexadecimal value based on the firmware date. Signed-off-by: avnd kiran avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- Changes from v2 - Addressed Kamil's comment https://patchwork.linuxtv.org/patch/22989/ Changes from v1 - Check for v6 firmware

[PATCH v2] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-05-14 Thread Arun Kumar K
though. So move the allocation of private codec buffers to REQBUFS for OUTPUT queue. Also, move MFC instance opening and closing to REQBUFS as well, as it's tied to allocation and deallocation of private codec buffers. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K

[PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-14 Thread Arun Kumar K
also come in earlier MFC firmware versions if the application calls STREAMON on CAPTURE with some delay after doing STREAMON on OUTPUT. So this patch keeps the header buffer until the other frame buffers are ready and dequeues it just before the first frame is ready. Signed-off-by: Arun Kumar K arun

[PATCH] [media] s5p-mfc: Update scratch buffer size for MPEG4

2014-05-14 Thread Arun Kumar K
Update the MPEG4 decoder scratch buffer size as per the new v6 firmware. This updation is increasing the size and so is backward compatible with older v6 firmwares. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |3 +-- 1 file changed, 1

[PATCH v2 0/4] Add MFCv8 support

2014-05-14 Thread Arun Kumar K
/ https://patchwork.linuxtv.org/patch/23768/ Arun Kumar K (1): [media] s5p-mfc: Rename IS_MFCV7 macro Kiran AVND (3): [media] s5p-mfc: Add variants to access mfc registers [media] s5p-mfc: Core support to add v8 decoder [media] s5p-mfc: Core support for v8 encoder .../devicetree/bindings

[PATCH v2 4/4] [media] s5p-mfc: Core support for v8 encoder

2014-05-14 Thread Arun Kumar K
Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v8.h| 30 +++ drivers/media/platform/s5p-mfc/s5p_mfc.c|2 + drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 61 +++ 3 files changed

[PATCH v2 2/4] [media] s5p-mfc: Rename IS_MFCV7 macro

2014-05-14 Thread Arun Kumar K
Renaming the IS_MFCV7 macro to IS_MFCV7_PLUS for the addition of MFCv8 support which reuses the v7 code. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|2 +- drivers/media

[PATCH v5 0/2] Add resolution change event

2014-05-14 Thread Arun Kumar K
from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Arun Kumar K (1): [media] v4l: Add source change event Pawel Osciak (1): [media] s5p-mfc: Add support for resolution change event Documentation/DocBook/media/v4l/vidioc

[PATCH v5 1/2] [media] v4l: Add source change event

2014-05-14 Thread Arun Kumar K
be expected to reallocate buffers before proceeding. The application can subscribe to events on a specific pad or input port which it is interested in. Signed-off-by: Arun Kumar K arun...@samsung.com --- Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 33 ++ .../DocBook/media/v4l

[PATCH v5 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-14 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com

Re: [PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-14 Thread Arun Kumar K
Hi Hans, On 05/14/14 12:39, Hans Verkuil wrote: On 05/14/2014 08:29 AM, Arun Kumar K wrote: MFCv6 encoder needs specific minimum number of buffers to be queued in the CAPTURE plane. This minimum number will be known only when the sequence header is generated. So we used to allow STREAMON

[PATCH v4 1/2] [media] v4l: Add source change event

2014-05-13 Thread Arun Kumar K
be expected to reallocate buffers before proceeding. The application can subscribe to events on a specific pad or input port which it is interested in. Signed-off-by: Arun Kumar K arun...@samsung.com --- Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 32 + .../DocBook/media/v4l

Re: [PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-13 Thread Arun Kumar K
Hi Kamil, On Tue, May 13, 2014 at 2:49 PM, Kamil Debski k.deb...@samsung.com wrote: Hi, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Tuesday, March 11, 2014 10:16 AM From: avnd kiran avnd.ki...@samsung.com Latest MFC v6 firmware requires tile mode

Re: [PATCH v4 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-13 Thread Arun Kumar K
Hi Hans, On Tue, May 13, 2014 at 1:29 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 05/13/14 07:59, Arun Kumar K wrote: From: Pawel Osciak posc...@chromium.org When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before

Re: [PATCH v4 1/2] [media] v4l: Add source change event

2014-05-13 Thread Arun Kumar K
Hi Hans, Will make the changes you suggested. Thanks regards Arun On Tue, May 13, 2014 at 1:30 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arun, I've got some more comments w.r.t. the documentation: On 05/13/14 07:59, Arun Kumar K wrote: This event indicates that the video device has

Re: [PATCH 1/3] [media] s5p-mfc: Add variants to access mfc registers

2014-05-13 Thread Arun Kumar K
Hi Kamil, On 05/13/14 16:02, Kamil Debski wrote: Hi, One small comment below, -Original Message- From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Wednesday, April 23, 2014 2:58 PM To: linux-media@vger.kernel.org; linux-samsung

Re: [PATCH] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-13 Thread Arun Kumar K
Hi Sachin, Thank you for the review. Will address your comments and post updated version. Regards Arun On Thu, May 8, 2014 at 3:09 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Arun, Just 2 small nits. On 7 May 2014 17:00, Arun Kumar K arun...@samsung.com wrote: MFCv6 encoder needs

Re: [PATCH v3 1/2] [media] v4l: Add source change event

2014-05-12 Thread Arun Kumar K
Hi Hans, Laurent, On 05/09/14 18:45, Hans Verkuil wrote: On 05/09/2014 03:09 PM, Laurent Pinchart wrote: Hi Arun, Thank you for the patch. We're slowly getting there :-) On Thursday 08 May 2014 17:19:15 Arun Kumar K wrote: This event indicates that the video device has encountered

[PATCH v4 0/2] Add resolution change event

2014-05-12 Thread Arun Kumar K
://patchwork.kernel.org/patch/4135731/ Changes from v2 --- - Event can be subscribed on specific pad / port as suggested by Hans. Changes from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Arun Kumar K (1): [media] v4l

[PATCH v4 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-12 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com

[PATCH v3 0/2] Add resolution change event

2014-05-08 Thread Arun Kumar K
://patchwork.kernel.org/patch/4023131/ Changes from v2 --- - Event can be subscribed on specific pad / port as suggested by Hans. Changes from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Arun Kumar K (1): [media] v4l

[PATCH v3 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-08 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com

[PATCH v3 1/2] [media] v4l: Add source change event

2014-05-08 Thread Arun Kumar K
be expected to reallocate buffers before proceeding. The application can subscribe to events on a specific pad or input/output port which it is interested in. Signed-off-by: Arun Kumar K arun...@samsung.com --- Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 32 + .../DocBook/media

Re: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-05-08 Thread Arun Kumar K
Hi Kamil, On 05/08/14 21:52, Kamil Debski wrote: Hi, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Friday, March 07, 2014 9:26 AM From: Pawel Osciak posc...@chromium.org Currently, for formats that are not H264, MFC driver will check

Re: [PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-08 Thread Arun Kumar K
Hi Kamil, On 05/08/14 21:52, Kamil Debski wrote: Hi, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Tuesday, March 11, 2014 10:16 AM From: avnd kiran avnd.ki...@samsung.com Latest MFC v6 firmware requires tile mode and loop filter setting

Re: [PATCH] [media] s5p-mfc: Add IOMMU support

2014-05-08 Thread Arun Kumar K
Hi Kamil, On 05/08/14 21:54, Kamil Debski wrote: Hi Arun, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] Sent: Tuesday, April 22, 2014 2:22 PM Hi Laurent, Thank you for the review. On Tue, Apr 22, 2014 at 5:23 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi

Re: [PATCH 1/3] [media] s5p-mfc: Add variants to access mfc registers

2014-05-08 Thread Arun Kumar K
Hi Tomasz, On 05/09/14 10:50, Tomasz Figa wrote: Hi Arun, PaweĊ‚, On 09.05.2014 06:49, Arun Kumar K wrote: Hi Kamil, On 05/09/14 06:30, Pawel Osciak wrote: Hi Kamil, On Fri, May 9, 2014 at 1:31 AM, Kamil Debski k.deb...@samsung.com wrote: Hi Arun, I think that this driver is getting

[PATCH] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-07 Thread Arun Kumar K
versions if the application calls STREAMON on CAPTURE with some delay after doing STREAMON on OUTPUT. So this patch keeps the header buffer until the other frame buffers are ready and dequeues it just before the first frame is ready. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media

[PATCH] [media] s5p-mfc: Update scratch buffer size for VP8 encoder

2014-05-07 Thread Arun Kumar K
Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v7.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/regs-mfc-v7.h b/drivers/media/platform/s5p-mfc/regs-mfc-v7.h index 82c96fa..1a5c6fd 100644 --- a/drivers/media/platform

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-05-05 Thread Arun Kumar K
Hi Hans, On Wed, Apr 30, 2014 at 8:03 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 04/30/2014 12:38 PM, Arun Kumar K wrote: Hi Hans, On 04/22/14 18:22, Hans Verkuil wrote: On 04/21/2014 11:26 AM, Arun Kumar K wrote: From: Pawel Osciak posc...@chromium.org This event indicates

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-30 Thread Arun Kumar K
Hi Hans, On 04/22/14 18:22, Hans Verkuil wrote: On 04/21/2014 11:26 AM, Arun Kumar K wrote: From: Pawel Osciak posc...@chromium.org This event indicates that the decoder has reached a point in the stream, at which the resolution changes. The userspace is expected to provide a new set

Re: [PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder

2014-04-29 Thread Arun Kumar K
Hi Sachin, Thank you for the review. On 04/29/14 22:45, Sachin Kamat wrote: Hi Arun, On 23 April 2014 18:27, Arun Kumar K arun...@samsung.com wrote: From: Kiran AVND avnd.ki...@samsung.com This patch adds variant data and core support for V8 decoder. This patch also adds the register

Re: [PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder

2014-04-29 Thread Arun Kumar K
Hi Sachin, On Wed, Apr 30, 2014 at 11:19 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Arun, On 30 April 2014 11:15, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Sachin, Thank you for the review. On 04/29/14 22:45, Sachin Kamat wrote: Hi Arun, On 23 April 2014 18:27, Arun

[PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder

2014-04-23 Thread Arun Kumar K
-off-by: Arun Kumar K arun...@samsung.com --- .../devicetree/bindings/media/s5p-mfc.txt |3 +- drivers/media/platform/s5p-mfc/regs-mfc-v8.h | 93 drivers/media/platform/s5p-mfc/s5p_mfc.c | 30 +++ drivers/media/platform/s5p-mfc/s5p_mfc_common.h

[PATCH 3/3] [media] s5p-mfc: Rename IS_MFCV7 macro

2014-04-23 Thread Arun Kumar K
With the inclusion of MFCv8 which reuses the v7 code, the macro IS_MFCV7 is modified to IS_MFCV7_PLUS. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|2 +- drivers/media/platform

[PATCH 0/3] Add MFCv8 support

2014-04-23 Thread Arun Kumar K
for decode. [media] s5p-mfc: Add a control for IVF format for VP8 encoder Arun Kumar K (1): [media] s5p-mfc: Rename IS_MFCV7 macro Kiran AVND (2): [media] s5p-mfc: Add variants to access mfc registers [media] s5p-mfc: Core support to add v8 decoder .../devicetree/bindings/media/s5p-mfc.txt

[PATCH] [media] s5p-mfc: Add IOMMU support

2014-04-22 Thread Arun Kumar K
The patch adds IOMMU support for MFC driver. Signed-off-by: Arun Kumar K arun...@samsung.com --- This patch is tested on IOMMU support series [1] posted by KyonHo Cho. [1] https://lkml.org/lkml/2014/3/14/9 --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 33 ++ 1 file

Re: [PATCH] [media] s5p-mfc: Add IOMMU support

2014-04-22 Thread Arun Kumar K
Hi Laurent, Thank you for the review. On Tue, Apr 22, 2014 at 5:23 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Arun, Thank you for the patch. On Tuesday 22 April 2014 16:32:48 Arun Kumar K wrote: The patch adds IOMMU support for MFC driver. I've been working

[PATCH v2 0/2] Add resolution change event

2014-04-21 Thread Arun Kumar K
This patchset adds the resolution change event to the MFC decoder. This will be used for triggering the runtime resolution change. Changes from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Pawel Osciak (2): v4l: Add

[PATCH v2 2/2] [media] s5p-mfc: Add support for resolution change event

2014-04-21 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com

[PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Arun Kumar K
generic events involving resolution or format changes at runtime for all kinds of video devices. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- .../DocBook/media/v4l/vidioc-subscribe-event.xml | 16 include/uapi/linux

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Arun Kumar K
Hi Pawel, On Mon, Apr 21, 2014 at 2:58 PM, Pawel Osciak posc...@chromium.org wrote: Arun, I think it'd better if you attributed this patch to yourself, I'm not the author of it. I only wrote patch 2/2 in this series. Thanks, Pawel Sure I will change it. I kept your name as it was a rework

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Arun Kumar K
Hi Laurent, Thank you for the review. On Mon, Apr 21, 2014 at 3:54 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Arun, Thank you for the patch. On Monday 21 April 2014 14:56:01 Arun Kumar K wrote: From: Pawel Osciak posc...@chromium.org This event indicates

[PATCH 1/2] v4l: Add resolution change event.

2014-04-16 Thread Arun Kumar K
...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- .../DocBook/media/v4l/vidioc-subscribe-event.xml |8 include/uapi/linux/videodev2.h |1 + 2 files changed, 9 insertions(+) diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe

[PATCH 2/2] [media] s5p-mfc: Add support for resolution change event

2014-04-16 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com

Re: [PATCH 1/2] v4l: Add resolution change event.

2014-04-16 Thread Arun Kumar K
Hi Laurent and Hans, Thank you for the review. On Wed, Apr 16, 2014 at 7:46 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 04/16/2014 04:09 PM, Laurent Pinchart wrote: Hi Arun, Thank you for the patch. On Wednesday 16 April 2014 18:29:21 Arun Kumar K wrote: From: Pawel Osciak posc

[PATCH 1/3] [media] s5p-mfc: Fixes for decode REQBUFS.

2014-03-21 Thread Arun Kumar K
() will fail otherwise. - Only verify state is MFCINST_INIT when allocating, not when freeing. - Refactor and simplify code. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 178

[PATCH 0/3] MFC cleanup of reqbuf, streamon, open and close

2014-03-21 Thread Arun Kumar K
This patch series contain some fixes and cleanups done to the s5p-mfc decoder in reqbuf, streamon and open/close commands. These patches are present in the ChromeOS tree and just rebased onto the media-tree and tested. Pawel Osciak (3): [media] s5p-mfc: Fixes for decode REQBUFS. [media]

[PATCH 2/3] [media] s5p-mfc: Extract open/close MFC instance commands.

2014-03-21 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org This is in preparation for a new flow to fix issues with streamon, which should not be allocating buffer memory. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH 3/3] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-03-21 Thread Arun Kumar K
though. So move the allocation of private codec buffers to REQBUFS for OUTPUT queue. Also, move MFC instance opening and closing to REQBUFS as well, as it's tied to allocation and deallocation of private codec buffers. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K

[PATCH] [media] s5p-mfc: Copy timestamps only when a frame is produced.

2014-03-18 Thread Arun Kumar K
-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 66c1775..d636789 100644 --- a/drivers/media/platform

[PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-11 Thread Arun Kumar K
firmware which is a hexadecimal value based on the firmware date. Signed-off-by: avnd kiran avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- Changes from v1 --- - Check for v6 firmware date for differenciating old and new firmware as per comments from Kamil

Re: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-11 Thread Arun Kumar K
Hi Kamil, On Tue, Mar 11, 2014 at 4:59 PM, Kamil Debski k.deb...@samsung.com wrote: Hi Arun, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun Kumar K Sent: Friday, March 07, 2014 9:26 AM From: Pawel Osciak posc...@chromium.org Currently, for formats

Re: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-09 Thread Arun Kumar K
Hi Kamil, On Fri, Mar 7, 2014 at 6:18 PM, Kamil Debski k.deb...@samsung.com wrote: Hi Arun, From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] Sent: Friday, March 07, 2014 12:10 PM Hi Sylwester, On Fri, Mar 7, 2014 at 2:59 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi

[PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-07 Thread Arun Kumar K
true; The only way to make it work is to queue only one frame per buffer from userspace and the check in the kernel is useless and wrong for VP8. MPEG4 still seems to require it, so keep it only for that format. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun

[PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Arun Kumar K
-by: avnd kiran avnd.ki...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h|1 + drivers/media/platform/s5p-mfc/regs-mfc-v7.h|2 -- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 11 +++ 3 files changed, 4

Re: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Arun Kumar K
Hi Sylwester, On Fri, Mar 7, 2014 at 2:59 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 07/03/14 09:31, Arun Kumar K wrote: From: avnd kiran avnd.ki...@samsung.com Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command

[PATCH] [media] s5p-mfc: Add a control for IVF format for VP8 encoder

2014-03-05 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org Add a control to enable/disable IVF output stream format for VP8 encode. Set the IVF format output to disabled as default. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- Documentation/DocBook/media/v4l

Re: [PATCH v10 1/2] [media] exynos5-is: Adds DT binding documentation

2014-02-03 Thread Arun Kumar K
if it is fine to be merged. Regards Arun On Fri, Dec 13, 2013 at 10:42 AM, Arun Kumar K arun...@samsung.com wrote: From: Shaik Ameer Basha shaik.am...@samsung.com The patch adds the DT binding doc for exynos5 SoC camera subsystem. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Signed

[PATCH] [media] exynos-gsc: swap cb/cr only for 3 plane formats

2013-12-20 Thread Arun Kumar K
). E.g. For NV21, the dma_address are (Y, CbCr, 0) and we swap them (Y, 0, CbCr) which is incorrect. Signed-off-by: Prathyush K prathyus...@samsung.com Signed-off-by: Shirish S s.shir...@samsung.com Signed-off-by: Arun Mankuzhi aru...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com

[PATCH v2] [media] s5p-mfc: Add controls to set vp8 enc profile

2013-12-16 Thread Arun Kumar K
-by: Arun Kumar K arun...@samsung.com --- Changes from v1 --- - Addressed review comments from Hans and Pawel https://www.mail-archive.com/linux-media@vger.kernel.org/msg68970.html https://www.mail-archive.com/linux-media@vger.kernel.org/msg68990.html --- Documentation/DocBook/media/v4l

  1   2   3   4   5   >