Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-14 Thread Arvydas Sidorenko
On Thu, Feb 14, 2013 at 8:12 AM, Hans Verkuil hverk...@xs4all.nl wrote: Arvydas, can you please test this? I'd like to do a git pull tomorrow and I'd like to know if the upside-down changes are now OK. Thanks, Hi Hans Everything is working fine now - dmesg is clean, LED lights on and off

Re: [RFCv2 PATCH 01/12] stk-webcam: the initial hflip and vflip setup was the wrong way around

2013-02-11 Thread Arvydas Sidorenko
On Mon, Feb 11, 2013 at 2:21 PM, Hans Verkuil hverk...@xs4all.nl wrote: That doesn't make sense either. Arvydas, it worked fine for you before, right? That is, if you use e.g. v3.8-rc7 then your picture is the right side up. It is upside down using any v3.7.x or v3.8-rc7. I didn't pay

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-10 Thread Arvydas Sidorenko
On Sun, Feb 10, 2013 at 8:28 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved this message, so please run again with the latest code and let me know what it says. I don't understand all the upside-down problems... $ dmesg | grep upside upside down: 0 -1 -1 -- To unsubscribe from

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-10 Thread Arvydas Sidorenko
On Sun, Feb 10, 2013 at 3:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks, I found the bug. It's my fault: I made a logic error w.r.t. setting up the initial hflip/vflip values. I've read over it dozens of times without actually catching the - rather obvious - bug :-) Get the latest

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-09 Thread Arvydas Sidorenko
On Fri, Feb 8, 2013 at 10:20 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks for the testing! I've pushed some more improvements to my git branch. Hopefully the compliance tests are now running OK. Please check the dmesg output as well. In addition I've added an 'upside down' message to

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-07 Thread Arvydas Sidorenko
On Wed, Feb 6, 2013 at 8:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved v4l2-compliance a bit, but I've also pushed a fix (I hope) to my git branch. It's great if you can test this! $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Arvydas Sidorenko
On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the patch series is also available in my git tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/stkwebcam Besides the

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Arvydas Sidorenko
On Tue, Feb 5, 2013 at 5:56 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: I have tested the patches using STK-1135 webcam. Everything works well. $ v4l2

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Arvydas Sidorenko
why the heck do we need this first_init? first_init was introduced in 7b1c8f58fcdbed75 for turning off LED when the cam finishes the capture. Andrea Anacleto andreaanacl...@libero.it claimed that the change broke his webcam on the same laptop, so he introduced that variable to fix the issue. It

[PATCH] drivers/media/video/stk-webcam.c: webcam LED bug fix [IMPROVED]

2011-09-21 Thread Arvydas Sidorenko
version seemed to break some other laptop webcam work. Thanks to Andrea Anacleto for the bug report and solution. Signed-off-by: Andrea Anacleto andreaanacl...@libero.it Signed-off-by: Arvydas Sidorenko asi...@gmail.com --- drivers/media/video/stk-webcam.c | 10 ++ 1 files changed, 10

[PATCH 1/2] drivers/media/video/stk-webcam.c: webcam LED bug fix

2011-09-13 Thread Arvydas Sidorenko
-by: Arvydas Sidorenko asi...@gmail.com --- drivers/media/video/stk-webcam.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/stk-webcam.c b/drivers/media/video/stk-webcam.c index d1a2cef..859e78f 100644 --- a/drivers/media/video/stk-webcam.c +++ b/drivers

[PATCH 2/2] drivers/media/video/stk-webcam.c: coding style issue

2011-09-13 Thread Arvydas Sidorenko
checkpatch.pl gave some coding style errors, so on the way to the first patch I added the fix to them. Signed-off-by: Arvydas Sidorenko asi...@gmail.com --- drivers/media/video/stk-webcam.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/media