Re: [PATCH] libv4l: fixup lfs mismatch in preload libraries

2018-07-12 Thread Baruch Siach
Mauro Carvalho Chehab writes: > Em Wed, 11 Jul 2018 22:38:56 +0300 > Baruch Siach escreveu: >> Added Peter's updated address to Cc. >> >> Mauro Carvalho Chehab writes: >> > Em Wed, 11 Jul 2018 10:22:51 -0300 >> > Ezequiel Garcia escreveu: >> &

Re: [PATCH] libv4l: fixup lfs mismatch in preload libraries

2018-07-11 Thread Baruch Siach
Hi Mauro, Added Peter's updated address to Cc. Mauro Carvalho Chehab writes: > Em Wed, 11 Jul 2018 10:22:51 -0300 > Ezequiel Garcia escreveu: > >> From: Peter Korsgaard >> >> Ensure that the lfs variants are not transparently used instead of the !lfs >> ones so both can be wrapped,

[PATCH] media: v4l2-ctrls.h: fix v4l2_ctrl field description typos

2018-07-05 Thread Baruch Siach
Signed-off-by: Baruch Siach --- include/media/v4l2-ctrls.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 5b445b5654f7..f615ba1b29dd 100644 --- a/include/media/v4l2-ctrls.h +++ b/include/media/v4l2-ctrls.h

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-24 Thread Baruch Siach
Hi Tomasz, On Mon, May 07, 2018 at 06:41:50AM +, Tomasz Figa wrote: > On Mon, May 7, 2018 at 3:38 PM Baruch Siach <bar...@tkos.co.il> wrote: > > On Mon, May 07, 2018 at 06:13:27AM +, Tomasz Figa wrote: > > > On Thu, May 3, 2018 at 6:09 PM Baruch Siach &

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-07 Thread Baruch Siach
Hi Tomasz, On Mon, May 07, 2018 at 06:13:27AM +, Tomasz Figa wrote: > On Thu, May 3, 2018 at 6:09 PM Baruch Siach <bar...@tkos.co.il> wrote: > > On Thu, Mar 08, 2018 at 05:47:55PM +0800, Jacob Chen wrote: > > > +static int rkisp1_isp_sd_s_power(str

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-03 Thread Baruch Siach
Hi Jacob, On Thu, Mar 08, 2018 at 05:47:55PM +0800, Jacob Chen wrote: > +static int rkisp1_isp_sd_s_power(struct v4l2_subdev *sd, int on) > +{ > + struct rkisp1_device *isp_dev = sd_to_isp_dev(sd); > + int ret; > + > + v4l2_dbg(1, rkisp1_debug, _dev->v4l2_dev, "s_power: %d\n", on); >

Re: [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver

2018-03-10 Thread Baruch Siach
Hi Jacob, On Thu, Mar 08, 2018 at 05:47:59PM +0800, Jacob Chen wrote: > +config VIDEO_ROCKCHIP_ISP1 > + tristate "Rockchip Image Signal Processing v1 Unit driver" > + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > + depends on ARCH_ROCKCHIP || COMPILE_TEST > + select

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

2018-03-08 Thread Baruch Siach
Hi Jacob, On Fri, Mar 09, 2018 at 01:05:28PM +0800, Jacob Chen wrote: > 2018-03-09 12:09 GMT+08:00 Baruch Siach <bar...@tkos.co.il>: > > On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > >> 2018-03-08 20:02 GMT+08:00 Baruch Siach <bar...@tkos.co.il>: >

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

2018-03-08 Thread Baruch Siach
Hi Jacob, On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > 2018-03-08 20:02 GMT+08:00 Baruch Siach <bar...@tkos.co.il>: > > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > >> This patch series add a ISP(Camera) v4l2 driver for rockchi

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

2018-03-08 Thread Baruch Siach
Hi Jacob, On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > SoC. > > Wiki Pages: > http://opensource.rock-chips.com/wiki_Rockchip-isp1 > > The deprecated g_mbus_config op is not dropped in V6 because i am

Re: v4l-utils fails to build against musl libc (with patch)

2018-03-07 Thread Baruch Siach
Hi Bjorn, On Wed, Mar 07, 2018 at 12:14:05PM -0500, Bjorn Pagen wrote: > Here's the link again and it's tinyurl, since the link seems to be > borked because of line wraparounds: > > https://git.alpinelinux.org/cgit/aports/tree/community/v4l-utils/0001-ir-ctl-fixes-for-musl-compile.patch >

Re: [PATCH v4 2/5] media: ov5695: add support for OV5695 sensor

2018-01-09 Thread Baruch Siach
Hi Shunqian Zheng, On Tue, Jan 09, 2018 at 10:48:21PM +0800, Shunqian Zheng wrote: > +static int ov5695_write_array(struct i2c_client *client, > + const struct regval *regs) > +{ > + u32 i; > + int ret = 0; > + > + for (i = 0; ret == 0 && regs[i].addr !=

Re: [PATCH v3] media: ABS macro parameter parenthesization

2017-12-24 Thread Baruch Siach
Hi Dan, On Sun, Dec 24, 2017 at 11:03:08PM -0500, Dan Gopstein wrote: > From: Dan Gopstein > > Replace usages of the locally defined ABS() macro with calls to the > canonical abs() from kernel.h and remove the old definitions of ABS() The note about some wrong ABS() macro

Re: [PATCH 1/2] media: dt-bindings: coda: Add compatible for CodaHx4 on i.MX51

2017-12-13 Thread Baruch Siach
Hi Philipp, On Wed, Dec 13, 2017 at 03:09:17PM +0100, Philipp Zabel wrote: > Add a compatible for the CodaHx4 VPU used on i.MX51. > > Signed-off-by: Philipp Zabel > --- > Documentation/devicetree/bindings/media/coda.txt | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [PATCH] media: ABS macro parameter parenthesization

2017-11-16 Thread Baruch Siach
Hi Dan, On Thu, Nov 16, 2017 at 06:09:20PM -0500, Dan Gopstein wrote: > From: Dan Gopstein > > Two definitions of the ABS (absolute value) macro fail to parenthesize their > parameter properly. This can lead to a bad expansion for low-precedence > expression arguments. Add

[PATCH 2/3] edid-decode: detailed_block: fix maybe uninitialized warning

2017-09-26 Thread Baruch Siach
-by: Baruch Siach <bar...@tkos.co.il> --- edid-decode.c | 4 1 file changed, 4 insertions(+) diff --git a/edid-decode.c b/edid-decode.c index 3df35ec6d07f..4abd79333d61 100644 --- a/edid-decode.c +++ b/edid-decode.c @@ -348,6 +348,10 @@ detailed_cvt_descriptor(unsigned char *x, int

[PATCH 1/3] edid-decode: parse_cta: fix maybe uninitialized warning

2017-09-26 Thread Baruch Siach
Fix the following warning: edid-decode.c: In function ‘parse_cta’: edid-decode.c:142:5: warning: ‘v’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- edid-decode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[PATCH 3/3] edid-decode: parse_extension: fix maybe uninitialized warning

2017-09-26 Thread Baruch Siach
Fix the following warning: edid-decode.c: In function ‘main’: edid-decode.c:2962:26: warning: ‘conformant_extension’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- edid-decode.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-30 Thread Baruch Siach
Hi Yong, On Mon, Jul 31, 2017 at 09:48:06AM +0800, Yong wrote: > On Sun, 30 Jul 2017 09:08:01 +0300 > Baruch Siach <bar...@tkos.co.il> wrote: > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > > On Thu, Jul 27, 2017 at 01:01:

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-30 Thread Baruch Siach
Hi Maxime, Yong, On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > Hi, > > Thanks for the second iteration! > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-27 Thread Baruch Siach
Hi Yong, I managed to get the Frame Done interrupt with the previous version of this driver on the A33 OLinuXino. No data yet (all zeros). I'm still working on it. One comment below. On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-07-19 Thread Baruch Siach
Hi Yong, On Wed, Jul 19, 2017 at 02:21:20PM +0800, Yong wrote: > On Wed, 19 Jul 2017 07:49:23 +0300 > Baruch Siach <bar...@tkos.co.il> wrote: > > On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > > > I am waiting for more comments for the sunxi-csi.h. It's ple

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-07-18 Thread Baruch Siach
Hi Yong, On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > On Tue, 18 Jul 2017 14:55:30 +0300 > Baruch Siach <bar...@tkos.co.il> wrote: > > I am trying to get this driver working on the Olimex A33 OLinuXino. I > > didn't get it working yet, but I had some progres

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-07-18 Thread Baruch Siach
Hi Yong, I am trying to get this driver working on the Olimex A33 OLinuXino. I didn't get it working yet, but I had some progress. See the comment below on one issue I encountered. On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote: > Add binding documentation for Allwinner CSI. > >

Re: [PATCH] radio: wl1273: add check on core->write() return value

2017-06-21 Thread Baruch Siach
Hi Gustavi, On Wed, Jun 21, 2017 at 11:01:22PM -0500, Gustavo A. R. Silva wrote: > Check return value from call to core->write(), so in case of > error print error message, jump to goto label fail and eventually > return. > > Addresses-Coverity-ID: 1226943 > Signed-off-by: Gustavo A. R. Silva

[PATCH] [media] doc: kapi: fix typo

2017-03-15 Thread Baruch Siach
Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- Documentation/media/kapi/v4l2-core.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/kapi/v4l2-core.rst b/Documentation/media/kapi/v4l2-core.rst index e9677150ed99..d8f6c46d26d5

Re: [PATCH] [media] coda: restore original firmware locations

2017-03-01 Thread Baruch Siach
location > off the list. > > Fixes: 8af7779f3cbc ("[media] coda: add Freescale firmware compatibility > location") > Cc: Baruch Siach <bar...@tkos.co.il> > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Thanks for cleaning up after me.

Re: PATCH: v4l-utils/utils/ir-ctl/irc-ctl.c: fix musl build

2017-02-20 Thread Baruch Siach
Hi Francesco, On Mon, Feb 20, 2017 at 12:33:14PM +0100, Francesco wrote: > This is my fist attempt to send a patch for v4l-utils project. > I maintain v4l-utils package for Alpine Linux (www.alpinelinux.org), a > musl-based distro. > > This patch allows the build for v4l-utils by allowing

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-19 Thread Baruch Siach
Hi Philipp, (Adding firmware loader maintainers to Cc). On Thu, Jan 19, 2017 at 10:44:54AM +0100, Philipp Zabel wrote: > On Wed, 2017-01-18 at 21:33 +0200, Baruch Siach wrote: > > > - if (dev->firmware == 1) { > > > + if (dev->firmware > 0) { > > > >

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-18 Thread Baruch Siach
Hi Philipp, On Wed, Jan 18, 2017 at 12:30:29PM +0100, Philipp Zabel wrote: > On Sun, 2017-01-15 at 12:33 +0200, Baruch Siach wrote: > > The Freescale provided imx-vpu looks for firmware files under > > /lib/firmware/vpu > > by default. Make coda look there for firmware fil

[PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-15 Thread Baruch Siach
The Freescale provided imx-vpu looks for firmware files under /lib/firmware/vpu by default. Make coda look there for firmware files to ease the update path. Cc: Fabio Estevam <feste...@gmail.com> Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- v3: adjust the number of firmwa

[PATCH v2] [media] coda: add Freescale firmware compatibility location

2017-01-15 Thread Baruch Siach
The Freescale provided imx-vpu looks for firmware files under /lib/firmware/vpu by default. Make coda look there for firmware files to ease the update path. Cc: Fabio Estevam <feste...@gmail.com> Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- v2: add compatibility path; don't cha

Re: [PATCHv2] dt: bindings: Add support for CSI1 bus

2017-01-12 Thread Baruch Siach
Hi Pavel, On Wed, Jan 11, 2017 at 11:53:35PM +0100, Pavel Machek wrote: > From: Sakari Ailus > > In the vast majority of cases the bus type is known to the driver(s) > since a receiver or transmitter can only support a single one. There > are cases however where different

[PATCH] [media] v4l2-subdev.h: fix v4l2_subdev_pad_config documentation

2017-01-04 Thread Baruch Siach
The fields of v4l2_subdev_pad_config are not pointers. Fixes: 21c29de1d09 ("[media] v4l2-subdev.h: Improve documentation") Cc: Mauro Carvalho Chehab <mche...@s-opensource.com> Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- include/media/v4l2-subdev.h | 6 +++--- 1 file

[PATCH] [media] adv7170: drop redundant ret local

2017-01-03 Thread Baruch Siach
Simplifies return value logic of adv7170_set_fmt(). Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- drivers/media/i2c/adv7170.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv7170.c b/drivers/media/i2c/adv7170.c index fc9ec0f3679c..9b0d6a

[PATCH] [media] ov2659: remove NOP assignment

2017-01-03 Thread Baruch Siach
The loop over the ov2659_formats[] array just a few line above verifies that mf->code matches the selected array entry. Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- drivers/media/i2c/ov2659.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ov2659.c b/drivers/

Re: [PATCH] [media] coda: fix Freescale firmware location

2016-12-27 Thread Baruch Siach
Hi Fabio, On Tue, Dec 27, 2016 at 09:26:16AM -0200, Fabio Estevam wrote: > 2016-12-27 8:06 GMT-02:00 Baruch Siach <bar...@tkos.co.il>: > > The Freescale provided imx-vpu looks for firmware files under > > /lib/firmware/vpu > > by default. Make coda conform with t

[PATCH] [media] coda: fix Freescale firmware location

2016-12-27 Thread Baruch Siach
The Freescale provided imx-vpu looks for firmware files under /lib/firmware/vpu by default. Make coda conform with that to ease the update path. Signed-off-by: Baruch Siach <bar...@tkos.co.il> --- drivers/media/platform/coda/coda-common.c | 8 1 file changed, 4 insertions

[PATCH] v4l2grab: print function name and ioctl number on failure

2015-08-12 Thread Baruch Siach
This makes the failure error message a little more useful. Signed-off-by: Baruch Siach bar...@tkos.co.il --- contrib/test/v4l2grab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/test/v4l2grab.c b/contrib/test/v4l2grab.c index 3e1be3de6353..778c51cc391a 100644

Re: [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor

2014-02-25 Thread Baruch Siach
Hi Sylwester, On Tue, Feb 25, 2014 at 10:46:58AM +0100, Sylwester Nawrocki wrote: On 24/02/14 20:38, Baruch Siach wrote: On Mon, Feb 24, 2014 at 06:35:16PM +0100, Sylwester Nawrocki wrote: This patch adds subdev driver for Samsung S5K6A3 raw image sensor. As it is intended at the moment

Re: [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor

2014-02-24 Thread Baruch Siach
Hi Sylwester, On Mon, Feb 24, 2014 at 06:35:16PM +0100, Sylwester Nawrocki wrote: This patch adds subdev driver for Samsung S5K6A3 raw image sensor. As it is intended at the moment to be used only with the Exynos FIMC-IS (camera ISP) subsystem it is pretty minimal subdev driver. It doesn't do

Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

2012-07-09 Thread Baruch Siach
Hi Javier, On Mon, Jul 09, 2012 at 09:46:03AM +0200, javier Martin wrote: On 9 July 2012 09:43, Sascha Hauer s.ha...@pengutronix.de wrote: On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote: On 9 July 2012 09:28, Sascha Hauer s.ha...@pengutronix.de wrote: On Fri, Jul 06, 2012

Re: [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

2012-03-26 Thread Baruch Siach
Hi Javier, On Mon, Mar 26, 2012 at 01:20:04PM +0200, Javier Martin wrote: Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- arch/arm/mach-imx/mach-imx27_visstrim_m10.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] media: video: mx2_camera: Remove ifdef's

2012-02-16 Thread Baruch Siach
-by: Baruch Siach bar...@tkos.co.il baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}ooO--U--Ooo{= - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list

Re: [PATCH] media i.MX27 camera: remove legacy dma support

2011-08-28 Thread Baruch Siach
. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Baruch Siach bar...@tkos.co.il Cc: linux-media@vger.kernel.org Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de --- [snip] Baruch, any comment? No comment so far. Thanks for your continued maintenance. I wish I could do

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-12-02 Thread Baruch Siach
Hi Guennadi, On Wed, Nov 17, 2010 at 08:09:09AM +0100, Guennadi Liakhovetski wrote: On Wed, 10 Nov 2010, Baruch Siach wrote: Guennadi Liakhovetski g.liakhovetski at gmx.de writes: On Wed, 27 Oct 2010, Baruch Siach wrote: When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset

Re: [PATCH 38/51] ARM: imx: move mx25 support to mach-imx

2010-11-17 Thread Baruch Siach
Hi Uwe, Tanks for all this work. Once this get merged we can get rid of the ugly '#ifdef CONFIG_MACH_MX27' in drivers/media/video/mx2_camera.c. Should such a patch go via Sascha's tree or the V4L tree? baruch On Wed, Nov 17, 2010 at 10:30:06PM +0100, Uwe Kleine-König wrote: Signed-off-by:

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-11-10 Thread Baruch Siach
Hi linux-media, On Wed, Oct 27, 2010 at 09:03:52AM +0200, Baruch Siach wrote: When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we get the inverted behaviour. Signed-off-by: Baruch Siach bar...@tkos.co.il Trying my luck again. Now adding Guennadi to Cc

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration

2010-11-10 Thread Baruch Siach
Guennadi Liakhovetski g.liakhovetski at gmx.de writes: On Wed, 27 Oct 2010, Baruch Siach wrote: When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we get the inverted behaviour. Seems logical to me, that if this is true, then you need the inverse

Re: [PATCH] soc-camera: Compile fixes for mx2-camera

2010-11-08 Thread Baruch Siach
-common.h #include media/v4l2-dev.h +#include media/videobuf-core.h What is this needed for? The driver seems to build without this hunk. Other than that: Acked-by: Baruch Siach bar...@tkos.co.il #include media/videobuf-dma-contig.h #include media/soc_camera.h #include media/soc_mediabus.h

[PATCH] mx2_camera: fix pixel clock polarity configuration

2010-10-27 Thread Baruch Siach
When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we get the inverted behaviour. Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/mx2_camera.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b

Re: [PATCH 4/4] mx2_camera: implement forced termination of active buffer for mx25

2010-08-29 Thread Baruch Siach
Hi Guennadi, On Fri, Aug 27, 2010 at 11:07:31AM +0200, Guennadi Liakhovetski wrote: On Tue, 27 Jul 2010, Baruch Siach wrote: This allows userspace to terminate a capture without waiting for the current frame to complete. This is an improvement, not a fix, right? Without this patch

Re: [PATCH 2/4] mx2_camera: return IRQ_NONE when doing nothing

2010-08-09 Thread Baruch Siach
hope ARM patches go in early enough. Since the driver is now merged upstream this series can go via the v4l tree. On Tue, 27 Jul 2010, Baruch Siach wrote: Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/mx2_camera.c |8 +--- 1 files changed, 5

[PATCH 0/4] mx2_camera: mx25 fixes and enhancements

2010-07-27 Thread Baruch Siach
The first 3 pathces in this series are fixes for the mx2_camera driver which is going upstream via the imx git tree. The last patch implements forced active buffer termination on mx25. Baruch Siach (4): mx2_camera: fix a race causing NULL dereference mx2_camera: return IRQ_NONE when doing

[PATCH 1/4] mx2_camera: fix a race causing NULL dereference

2010-07-27 Thread Baruch Siach
The mx25_camera_irq irq handler may get called after the camera has been deactivated (from mx2_camera_deactivate). Detect this situation, and bail out. Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/mx2_camera.c |4 1 files changed, 4 insertions(+), 0 deletions

[PATCH 3/4] mx2_camera: fix comment typo

2010-07-27 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/mx2_camera.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index b42ad8d..d327d11 100644 --- a/drivers/media/video/mx2_camera.c

[PATCH 2/4] mx2_camera: return IRQ_NONE when doing nothing

2010-07-27 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/mx2_camera.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 1536bd4..b42ad8d 100644 --- a/drivers/media/video

[PATCH 4/4] mx2_camera: implement forced termination of active buffer for mx25

2010-07-27 Thread Baruch Siach
This allows userspace to terminate a capture without waiting for the current frame to complete. Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/mx2_camera.c | 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/media/video

Re: [PATCHv6] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-07-15 Thread Baruch Siach
Hi, On Sun, Jul 04, 2010 at 07:55:10AM +0300, Baruch Siach wrote: This is the soc_camera support developed by Sascha Hauer for the i.MX27. Alan Carvalho de Assis modified the original driver to get it working on more recent kernels. I modified it further to add support for i.MX25

[PATCHv6] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-07-03 Thread Baruch Siach
-by: Baruch Siach bar...@tkos.co.il Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Changes v5 - v6 Typo fix: s/CONFIG_MX2_VIDEO/CONFIG_VIDEO_MX2_HOSTSUPPORT/ Changes v4 - v5 Comments from Uwe Kleine-König: Enclose mx27 DMA related stuff in #ifdefs since the dma-mx1-mx2.h

[PATCHv5] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-07-01 Thread Baruch Siach
-by: Baruch Siach bar...@tkos.co.il Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Changes v4 - v5 Comments from Uwe Kleine-König: Enclose mx27 DMA related stuff in #ifdefs since the dma-mx1-mx2.h is no longer accessible to mx25 builds s/MX2_VIDEO/VIDEO_MX2_HOSTSUPPORT

Re: [PATCHv5] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-07-01 Thread Baruch Siach
Hi Uwe, On Thu, Jul 01, 2010 at 02:28:03PM +0200, Uwe Kleine-König wrote: On Thu, Jul 01, 2010 at 02:03:19PM +0300, Baruch Siach wrote: This is the soc_camera support developed by Sascha Hauer for the i.MX27. Alan Carvalho de Assis modified the original driver to get it working on more

Re: [PATCHv4 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-06-29 Thread Baruch Siach
On Tue, Jun 29, 2010 at 09:47:42PM +0200, Guennadi Liakhovetski wrote: On Mon, 21 Jun 2010, Baruch Siach wrote: This is the soc_camera support developed by Sascha Hauer for the i.MX27. Alan Carvalho de Assis modified the original driver to get it working on more recent kernels. I

Re: [PATCH v3 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-06-20 Thread Baruch Siach
Hi Guennadi, On Sat, Jun 19, 2010 at 04:13:31PM +0200, Guennadi Liakhovetski wrote: On Wed, 26 May 2010, Baruch Siach wrote: This is the soc_camera support developed by Sascha Hauer for the i.MX27. Alan Carvalho de Assis modified the original driver to get it working on more recent

[PATCHv4 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-06-20 Thread Baruch Siach
. In mx27_camera_emma_buf_init I don't know the meaning of those hard coded magic numbers Applied i.MX27 fixes from Sascha. Baruch Siach (3): mx2_camera: Add soc_camera support for i.MX25/i.MX27 mx27: add support for the CSI device mx25: add support for the CSI device arch/arm/mach-mx2

[PATCHv4 2/3] mx27: add support for the CSI device

2010-06-20 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx2/clock_imx27.c |2 +- arch/arm/mach-mx2/devices.c | 31 +++ arch/arm/mach-mx2/devices.h |1 + 3 files changed, 33 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mx2

[PATCHv4 3/3] mx25: add support for the CSI device

2010-06-20 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx25/clock.c| 14 -- arch/arm/mach-mx25/devices.c | 22 ++ arch/arm/mach-mx25/devices.h |1 + arch/arm/plat-mxc/include/mach/mx25.h |2 ++ 4 files changed, 37

[PATCHv4 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-06-20 Thread Baruch Siach
-by: Baruch Siach bar...@tkos.co.il --- arch/arm/plat-mxc/include/mach/memory.h |4 +- arch/arm/plat-mxc/include/mach/mx2_cam.h | 46 + drivers/media/video/Kconfig | 13 + drivers/media/video/Makefile |1 + drivers/media/video/mx2_camera.c | 1493

[PATCH] soc_camera_platform: add set_fmt callback

2010-06-20 Thread Baruch Siach
This allows the platform camera to arrange a change in the capture format. Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/soc_camera_platform.c |3 +++ include/media/soc_camera_platform.h |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v3 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-06-09 Thread Baruch Siach
Hi linux-media list, Ping? Any news on this? baruch On Wed, May 26, 2010 at 12:13:15PM +0300, Baruch Siach wrote: This series contains a soc_camera driver for the i.MX25/i.MX27 CSI device, and platform code for the i.MX25 and i.MX27 chips. This driver is based on a driver for i.MX27 CSI

Re: [PATCH v2 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-05-26 Thread Baruch Siach
Hi Guennadi, Thanks for your comments. A question below. On Tue, May 25, 2010 at 05:34:52PM +0200, Guennadi Liakhovetski wrote: On Mon, 24 May 2010, Baruch Siach wrote: [snip] +static void mx2_camera_deactivate(struct mx2_camera_dev *pcdev) +{ + unsigned long flags

[PATCH v3 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-05-26 Thread Baruch Siach
pcdev-active on i.MX27, because mx27_camera_frame_done needs this pointer 3. In mx27_camera_emma_buf_init I don't know the meaning of those hard coded magic numbers Applied i.MX27 fixes from Sascha. Baruch Siach (3): mx2_camera: Add soc_camera support for i.MX25/i.MX27

[PATCH v3 2/3] mx27: add support for the CSI device

2010-05-26 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx2/clock_imx27.c |2 +- arch/arm/mach-mx2/devices.c | 31 +++ arch/arm/mach-mx2/devices.h |1 + 3 files changed, 33 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mx2

[PATCH v3 3/3] mx25: add support for the CSI device

2010-05-26 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx25/clock.c| 14 -- arch/arm/mach-mx25/devices.c | 22 ++ arch/arm/mach-mx25/devices.h |1 + arch/arm/plat-mxc/include/mach/mx25.h |2 ++ 4 files changed, 37

[PATCH v3 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-05-26 Thread Baruch Siach
-by: Baruch Siach bar...@tkos.co.il --- arch/arm/plat-mxc/include/mach/memory.h |4 +- arch/arm/plat-mxc/include/mach/mx2_cam.h | 46 + drivers/media/video/Kconfig | 13 + drivers/media/video/Makefile |1 + drivers/media/video/mx2_camera.c | 1488

Re: [PATCH v2 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-05-25 Thread Baruch Siach
Hi Sascha, On Tue, May 25, 2010 at 03:16:24PM +0200, Sascha Hauer wrote: On Mon, May 24, 2010 at 04:20:39PM +0300, Baruch Siach wrote: This is the soc_camera support developed by Sascha Hauer for the i.MX27. Alan Carvalho de Assis modified the original driver to get it working on more

[PATCH v2 2/3] mx27: add support for the CSI device

2010-05-24 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx2/clock_imx27.c |2 +- arch/arm/mach-mx2/devices.c | 31 +++ arch/arm/mach-mx2/devices.h |1 + 3 files changed, 33 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mx2

[PATCH v2 3/3] mx25: add support for the CSI device

2010-05-24 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx25/clock.c| 14 -- arch/arm/mach-mx25/devices.c | 22 ++ arch/arm/mach-mx25/devices.h |1 + arch/arm/plat-mxc/include/mach/mx25.h |2 ++ 4 files changed, 37

[PATCH v2 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-05-24 Thread Baruch Siach
know the meaning of those hard coded magic numbers Applied i.MX27 fixes from Sascha. Baruch Siach (3): mx2_camera: Add soc_camera support for i.MX25/i.MX27 mx27: add support for the CSI device mx25: add support for the CSI device arch/arm/mach-mx2/clock_imx27.c |2

[PATCH v2 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-05-24 Thread Baruch Siach
-by: Baruch Siach bar...@tkos.co.il --- arch/arm/plat-mxc/include/mach/memory.h |4 +- arch/arm/plat-mxc/include/mach/mx2_cam.h | 46 + drivers/media/video/Kconfig | 13 + drivers/media/video/Makefile |1 + drivers/media/video/mx2_camera.c | 1471

Re: [PATCH v2 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-05-24 Thread Baruch Siach
Hi Guennadi, On Mon, May 24, 2010 at 03:34:32PM +0200, Guennadi Liakhovetski wrote: On Mon, 24 May 2010, Baruch Siach wrote: This series contains a soc_camera driver for the i.MX25/i.MX27 CSI device, and platform code for the i.MX25 and i.MX27 chips. This driver is based on a driver

Re: [PATCH 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-05-21 Thread Baruch Siach
Hi Sascha, On Fri, May 21, 2010 at 09:20:45AM +0200, Sascha Hauer wrote: On Thu, May 06, 2010 at 04:09:38PM +0300, Baruch Siach wrote: This series contains a soc_camera driver for the i.MX25/i.MX27 CSI device, and platform code for the i.MX25 and i.MX27 chips. This driver is based

Re: [PATCH 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-05-17 Thread Baruch Siach
Hi Sascha, Thanks for your comments. On Mon, May 17, 2010 at 09:27:20AM +0200, Sascha Hauer wrote: On Wed, May 12, 2010 at 09:02:29PM +0200, Guennadi Liakhovetski wrote: Hi Baruch Thanks for eventually mainlining this driver! A couple of comments below. Sascha, would be great, if you

Re: [PATCH 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-05-12 Thread Baruch Siach
patch after getting Sascha comments on the mx27 specific code. baruch On Thu, 6 May 2010, Baruch Siach wrote: This is the soc_camera support developed by Sascha Hauer for the i.MX27. Alan Carvalho de Assis modified the original driver to get it working on more recent kernels. I

[PATCH 1/3] mx2_camera: Add soc_camera support for i.MX25/i.MX27

2010-05-06 Thread Baruch Siach
) 2008, Sascha Hauer s.ha...@pengutronix.de +Copyright (C) 2010, Baruch Siach bar...@tkos.co.il + +This program is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation; either version 2

[PATCH 0/3] Driver for the i.MX2x CMOS Sensor Interface

2010-05-06 Thread Baruch Siach
PDK paltform I can't test the mx27 specific code. Testers and comment are welcome. [1] https://patchwork.kernel.org/patch/67636/ Baruch Siach (3): mx2_camera: Add soc_camera support for i.MX25/i.MX27 mx27: add support for the CSI device mx25: add support for the CSI device arch/arm/mach

[PATCH 2/3] mx27: add support for the CSI device

2010-05-06 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx2/clock_imx27.c |2 +- arch/arm/mach-mx2/devices.c | 31 +++ arch/arm/mach-mx2/devices.h |1 + 3 files changed, 33 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mx2

[PATCH 3/3] mx25: add support for the CSI device

2010-05-06 Thread Baruch Siach
Signed-off-by: Baruch Siach bar...@tkos.co.il --- arch/arm/mach-mx25/clock.c| 14 -- arch/arm/mach-mx25/devices.c | 22 ++ arch/arm/mach-mx25/devices.h |1 + arch/arm/plat-mxc/include/mach/mx25.h |2 ++ 4 files changed, 37

Re: [PATCH] v4l: soc_camera: fix bound checking of mbus_fmt[] index

2010-02-20 Thread Baruch Siach
Hi Guennadi, On Fri, Feb 19, 2010 at 06:26:06PM +0100, Guennadi Liakhovetski wrote: On Thu, 18 Feb 2010, Baruch Siach wrote: Thanks for the patch, but I decided to improve it a bit. In fact, the only case my original version was missing was code == V4L2_MBUS_FMT_FIXED, the correct test

[PATCH] v4l: soc_camera: fix bound checking of mbus_fmt[] index

2010-02-17 Thread Baruch Siach
When code = V4L2_MBUS_FMT_FIXED soc_mbus_get_fmtdesc returns a pointer to mbus_fmt[x], where x 0. Fix this. Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/media/video/soc_mediabus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video

Re: [PATCH] RFC: mx27: Add soc_camera support

2010-02-04 Thread Baruch Siach
Hi Alan, On Tue, Dec 15, 2009 at 12:07:43PM -0200, Alan Carvalho de Assis wrote: Please note: I just get it compiling and loaded correctly on the mainline kernel. If you have a board powered by i.MX27 and with a camera supported by soc_camera driver, I will be glad case you can do a try.