Re: [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename

2014-04-23 Thread David Rientjes
= of_graph_get_next_endpoint(node, NULL); if (!node_ep) { dev_warn(dev, no endpoint defined for node: %s\n, node-full_name); Acked-by: David Rientjes rient...@google.com The build error that this patch fixes is still present in Linus's tree

Re: linux-next: Tree for May 1 (media/usb/stk1160)

2013-05-01 Thread David Rientjes
On Wed, 1 May 2013, Yann E. MORIN wrote: When CONFIG_SND=m and CONFIG_SND_AC97_CODEC=m and CONFIG_VIDEO_STK1160=y CONFIG_VIDEO_STK1160_AC97=y drivers/built-in.o: In function `stk1160_ac97_register': (.text+0x122706): undefined reference to `snd_card_create' drivers/built-in.o: In

Re: linux-next: Tree for May 1 (media/usb/stk1160)

2013-05-01 Thread David Rientjes
On Wed, 1 May 2013, Randy Dunlap wrote: When CONFIG_SND=m and CONFIG_SND_AC97_CODEC=m and CONFIG_VIDEO_STK1160=y CONFIG_VIDEO_STK1160_AC97=y drivers/built-in.o: In function `stk1160_ac97_register': (.text+0x122706): undefined reference to `snd_card_create' drivers/built-in.o: In

Re: [PATCH -next] media:

2013-04-15 Thread David Rientjes
On Tue, 9 Apr 2013, Antti Palosaari wrote: On 04/08/2013 08:47 PM, Randy Dunlap wrote: From: Randy Dunlap rdun...@infradead.org Fix randconfig error when USB is not enabled: ERROR: usb_control_msg [drivers/media/common/cypress_firmware.ko] undefined! Signed-off-by: Randy

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread David Rientjes
On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be depends on LEDS_CLASS rather than select it if there is a hard dependency that cannot be fixed with

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-08 Thread David Rientjes
On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register [drivers/media/radio/shark2.ko] undefined! ERROR:

Re: kernel OOPS when releasing usb webcam (random)

2011-10-19 Thread David Rientjes
On Tue, 18 Oct 2011, David Rientjes wrote: Guennadi or Mauro, how is this going to Linus? It sounds like 3.1 material since we've received at least a couple of reports of this in the past week. This fix is now in Linus' tree at e58fced201ad ([media] videodev: fix a NULL pointer

Re: [PATCH] [media] videodev: fix a NULL pointer dereference in v4l2_device_release()

2011-10-18 Thread David Rientjes
On Tue, 18 Oct 2011, Antonio Ospite wrote: can anyone reproduce this? Ping. David, does the change below fix it for you, I sent the patch last week. I never had the problem. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: kernel OOPS when releasing usb webcam (random)

2011-10-18 Thread David Rientjes
On Tue, 18 Oct 2011, Antonio Ospite wrote: im getting the following null pointer dereference from time to time when releasing a usb camera. maybe this trace is of assistance...please reply to my mail since im not subscribed. I suspect this is happening in

Re: kernel OOPS when releasing usb webcam (random)

2011-10-17 Thread David Rientjes
On Mon, 17 Oct 2011, Tomas M. wrote: im getting the following null pointer dereference from time to time when releasing a usb camera. maybe this trace is of assistance...please reply to my mail since im not subscribed. I suspect this is happening in v4l2_device_unregister_subdev().

RE: [GIT PULL for v3.0] OMAP_VOUT bug fixes and code cleanup

2011-07-08 Thread David Rientjes
On Thu, 7 Jul 2011, JAIN, AMBER wrote: I think what David wants to say is that if we do not have DMA restrictions on OMAP we should have not used GFP_DMA flag for page allocation at first place. Is my understanding correct David? Right, and that's what the patch is doing. -- To

RE: [GIT PULL for v3.0] OMAP_VOUT bug fixes and code cleanup

2011-07-06 Thread David Rientjes
On Tue, 5 Jul 2011, JAIN, AMBER wrote: diff --git a/drivers/media/video/omap24xxcam.c b/drivers/media/video/omap24xxcam.c index f6626e8..d92d4c6 100644 --- a/drivers/media/video/omap24xxcam.c +++ b/drivers/media/video/omap24xxcam.c @@ -309,11 +309,11 @@ static int