Re: [PATCH 0/3] Improve CEC autorepeat handling

2017-11-27 Thread Dmitry Torokhov
On Mon, Nov 27, 2017 at 09:47:24AM +, Sean Young wrote: > Hi Hans, > > On Mon, Nov 27, 2017 at 10:13:51AM +0100, Hans Verkuil wrote: > > On 11/26/2017 12:47 AM, Dmitry Torokhov wrote: > > > On Fri, Nov 24, 2017 at 11:43:58AM +, Sean Young wrote: > > >>

Re: [PATCH 0/3] Improve CEC autorepeat handling

2017-11-25 Thread Dmitry Torokhov
Hi Sean, On Fri, Nov 24, 2017 at 11:43:58AM +, Sean Young wrote: > Due to the slowness of the CEC bus, autorepeat handling rather special > on CEC. If the repeated user control pressed message is received, a > keydown repeat should be sent immediately. This sounds like you want to have

Re: [PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

2017-11-03 Thread Dmitry Torokhov
On Thu, Nov 02, 2017 at 10:16:58PM -0200, Mauro Carvalho Chehab wrote: > Em Thu, 2 Nov 2017 16:50:37 -0700 > Dmitry Torokhov <dmitry.torok...@gmail.com> escreveu: > > > On Thu, Nov 02, 2017 at 04:24:27PM -0700, Kees Cook wrote: > > > On Tue, Oct 31, 2017 at 1:11

Re: [PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

2017-11-02 Thread Dmitry Torokhov
> Signed-off-by: Sean Young <s...@mess.org> > > Hi! Just checking up on this... the input timer conversion is blocked > by getting this sorted out, so I'd love to have something either > media, input, or timer tree can carry. :) Acked-by: Dmitry Torokhov <dmitry.torok...

Re: [PATCH] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Dmitry Torokhov
Hi Sean, On Tue, Oct 31, 2017 at 05:45:58PM +, Sean Young wrote: > Leave the autorepeat handling up to the input layer, and move > to the new timer API. > > Compile tested only. > > Signed-off-by: Sean Young > --- > drivers/media/pci/ttpci/av7110.h| 2 +- >

[PATCH] media: av7110: switch to useing timer_setup()

2017-10-24 Thread Dmitry Torokhov
have such convoluted autorepeat handling in this driver instead of letting input core handle autorepeat, but this preserves current behavior of allowing controlling autorepeat delay and forcing autorepeat period to be whatever the hardware has. Signed-off-by: Dmitry Torokhov <dmitry.to

Re: [PATCH] media: input: Convert timers to use timer_setup()

2017-10-19 Thread Dmitry Torokhov
On Thu, Oct 19, 2017 at 03:45:38PM -0700, Kees Cook wrote: > On Thu, Oct 19, 2017 at 3:32 PM, Dmitry Torokhov > <dmitry.torok...@gmail.com> wrote: > > On Mon, Oct 16, 2017 at 04:14:43PM -0700, Kees Cook wrote: > >> In preparation for unconditionally passing th

Re: [PATCH] media: input: Convert timers to use timer_setup()

2017-10-19 Thread Dmitry Torokhov
ed its own private timer for that. > > Cc: Dmitry Torokhov <dmitry.torok...@gmail.com> > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Geliang Tang <gelia

Re: [PATCH 08/14] Input: adxl34x - fix gcc-7 -Wint-in-bool-context warning

2017-07-14 Thread Dmitry Torokhov
On Fri, Jul 14, 2017 at 10:17:10PM +0200, Arnd Bergmann wrote: > On Fri, Jul 14, 2017 at 9:24 PM, Linus Torvalds > wrote: > > On Fri, Jul 14, 2017 at 2:25 AM, Arnd Bergmann wrote: > >> FIFO_MODE is an macro expression with a '<<' operator, which > >>

Re: [PATCH 2/2] rainshadow-cec: new RainShadow Tech HDMI CEC driver

2017-04-04 Thread Dmitry Torokhov
Hi Hans, On Fri, Feb 03, 2017 at 03:46:01PM +0100, Hans Verkuil wrote: > Hi Dmitry, > > Thanks for the feedback. See my comments below: > > On 03/01/17 07:51, Dmitry Torokhov wrote: > >Hi Hans, > > > >On Thu, Dec 15, 2016 at 02:02:07PM +0100, Hans Verk

Re: [PATCHv2 1/2] serio.h: add SERIO_RAINSHADOW_CEC ID

2017-04-04 Thread Dmitry Torokhov
On Fri, Feb 03, 2017 at 04:26:32PM +0100, Hans Verkuil wrote: > From: Hans Verkuil <hans.verk...@cisco.com> > > Add a new serio ID for the RainShadow Tech USB HDMI CEC adapter. > > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Acked-by: Dmitry Torokhov

[PATCH] [media] Staging: media: radio-bcm2048: remove incorrect __exit markups

2017-03-01 Thread Dmitry Torokhov
-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index 37bd439ee08b..1fba377f816b

[PATCH] [media] ad5820: remove incorrect __exit markups

2017-03-01 Thread Dmitry Torokhov
-by: Dmitry Torokhov <dmitry.torok...@gmail.com> --- drivers/media/i2c/ad5820.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c index a9026a91855e..3d2a3c6b67d8 100644 --- a/drivers/media/i2c/ad5820.c +++ b/drivers/med

Re: [PATCH 2/2] rainshadow-cec: new RainShadow Tech HDMI CEC driver

2017-01-02 Thread Dmitry Torokhov
Hi Hans, On Thu, Dec 15, 2016 at 02:02:07PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > This driver supports the RainShadow Tech USB HDMI CEC adapter. > > See: http://rainshadowtech.com/HdmiCecUsb.html > > Signed-off-by: Hans Verkuil >

Re: [RFC] Input: synaptics-rmi4 - fix out-of-bounds memory access

2016-11-22 Thread Dmitry Torokhov
Hi Guenter, On Sat, Nov 19, 2016 at 07:46:58PM -0800, Guenter Roeck wrote: > Kasan reports: > > BUG: KASAN: slab-out-of-bounds in __fill_v4l2_buffer+0xc3/0x540 > [videobuf2_v4l2] at addr 8806c5e0c6cc > Read of size 4 by task heatmap/14414 > CPU: 2 PID: 14414 Comm: heatmap Tainted: G

Re: [PATCH v8 03/10] Input: atmel_mxt_ts - add support for T37 diagnostic data

2016-08-23 Thread Dmitry Torokhov
as from the device. This consists of an array of 16-bit > > integers, one for each node on the touchscreen matrix. > > Is it ok to merge this patch (and the other patches on this series) > via my tree? Yes, please (I do not think I have any other Atmel changes pending). Feel free to

Re: [PATCHv2] serio: add hangup support

2016-08-03 Thread Dmitry Torokhov
On Wed, Aug 03, 2016 at 01:00:44PM +0200, Hans Verkuil wrote: > The Pulse-Eight USB CEC adapter is a usb device that shows up as a ttyACM0 > device. > It requires that you run inputattach in order to communicate with it via > serio. > > This all works well, but it would be nice to have a udev

Re: [RFC PATCH] serio: add hangup support

2016-08-03 Thread Dmitry Torokhov
On Mon, Aug 01, 2016 at 03:43:32PM +0200, Hans Verkuil wrote: > > > On 07/15/2016 06:31 PM, Dmitry Torokhov wrote: > > Hi Hans, > > > > On Fri, Jul 15, 2016 at 01:27:21PM +0200, Hans Verkuil wrote: > >> For the upcoming 4.8 kernel I made a driver for t

Re: [RFC PATCH] serio: add hangup support

2016-07-15 Thread Dmitry Torokhov
Hi Hans, On Fri, Jul 15, 2016 at 01:27:21PM +0200, Hans Verkuil wrote: > For the upcoming 4.8 kernel I made a driver for the Pulse-Eight USB CEC > adapter. > This is a usb device that shows up as a ttyACM0 device. It requires that you > run > inputattach in order to communicate with it via

Re: [PATCH 2/5] serio.h: add new define for the Pulse-Eight USB-CEC Adapter

2016-07-11 Thread Dmitry Torokhov
On Sun, Jul 10, 2016 at 03:11:18PM +0200, Hans Verkuil wrote: > From: Hans Verkuil <hans.verk...@cisco.com> > > This is for the new pulse8-cec staging driver. > > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> > Cc: Dmitry Torokhov <dmitry.torok...@gmail

Re: [PATCH v5 1/9] [media] v4l2-core: Add support for touch devices

2016-06-23 Thread Dmitry Torokhov
On Wed, Jun 22, 2016 at 11:08:25PM +0100, Nick Dyer wrote: > Some touch controllers send out touch data in a similar way to a > greyscale frame grabber. > > Use a new device prefix v4l-touch for these devices, to stop generic > capture software from treating them as webcams. > > Add formats: > -

Re: [PATCH v5 8/9] Input: synaptics-rmi4 - add support for F54 diagnostics

2016-06-23 Thread Dmitry Torokhov
Hi Nick, On Wed, Jun 22, 2016 at 11:08:32PM +0100, Nick Dyer wrote: > Function 54 implements access to various RMI4 diagnostic features. > > This patch adds support for retrieving this data. It registers a V4L2 > device to output the data to user space. > > Signed-off-by: Nick Dyer

Re: [PATCH 0/2] input: add support for HDMI CEC

2016-06-18 Thread Dmitry Torokhov
On Sat, Jun 18, 2016 at 02:44:08PM -0300, Mauro Carvalho Chehab wrote: > Em Sat, 18 Jun 2016 18:56:24 +0200 > Hans Verkuil <hverk...@xs4all.nl> escreveu: > > > On 06/18/2016 06:26 PM, Dmitry Torokhov wrote: > > > Hi Hans, > > > > > > On Sat, Jun

Re: [PATCH 0/2] input: add support for HDMI CEC

2016-06-18 Thread Dmitry Torokhov
Hi Hans, On Sat, Jun 18, 2016 at 04:50:26PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Hi Dmitry, > > This patch series adds input support for the HDMI CEC bus through which > remote control keys can be passed from one HDMI device to another. > > This has been

Re: [PATCHv16 08/13] DocBook/media: add CEC documentation

2016-06-18 Thread Dmitry Torokhov
On Fri, Jun 17, 2016 at 08:37:38AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 17 Jun 2016 13:09:10 +0200 > Hans Verkuil escreveu: > > > On 06/17/2016 11:50 AM, Mauro Carvalho Chehab wrote: > > One area where I am uncertain is when remote control messages are received > >

Re: [PATCH v3 0/8] Input: atmel_mxt_ts - output raw touch diagnostic data via V4L

2016-06-01 Thread Dmitry Torokhov
On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: > This is a series of patches to add diagnostic data support to the Atmel > maXTouch driver. It's a rewrite of the previous implementation which output > via > debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. > >

Re: [PATCH v3 4/8] Input: atmel_mxt_ts - output diagnostic debug via v4l2 device

2016-06-01 Thread Dmitry Torokhov
On Wed, Jun 01, 2016 at 05:39:48PM +0100, Nick Dyer wrote: > Register a video device to output T37 diagnostic data. > > Signed-off-by: Nick Dyer > --- > drivers/input/touchscreen/Kconfig| 2 + > drivers/input/touchscreen/atmel_mxt_ts.c | 247 >

Re: [PATCH v3 7/8] Input: atmel_mxt_ts - add diagnostic data support for mXT1386

2016-06-01 Thread Dmitry Torokhov
On Wed, Jun 01, 2016 at 05:39:51PM +0100, Nick Dyer wrote: > The mXT1386 family of chips have a different architecture which splits > the diagnostic data into 3 columns. > > Signed-off-by: Nick Dyer > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 29

Re: [PATCH v3 1/8] Input: atmel_mxt_ts - add support for T37 diagnostic data

2016-06-01 Thread Dmitry Torokhov
Hi Nick, On Wed, Jun 01, 2016 at 05:39:45PM +0100, Nick Dyer wrote: > Atmel maXTouch devices have a T37 object which can be used to read raw > touch deltas from the device. This consists of an array of 16-bit > integers, one for each node on the touchscreen matrix. > > Signed-off-by: Nick Dyer

Re: [PATCHv14 05/18] HID: add HDMI CEC specific keycodes

2016-03-31 Thread Dmitry Torokhov
On Fri, Mar 25, 2016 at 02:10:03PM +0100, Hans Verkuil wrote: > From: Kamil Debski <ka...@wypas.org> > > Add HDMI CEC specific keycodes to the keycodes definition. > > Signed-off-by: Kamil Debski <ka...@wypas.org> > Signed-off-by: Hans Verkuil <hans.verk...@cisc

Re: [PATCHv12 05/17] HID: add HDMI CEC specific keycodes

2016-03-05 Thread Dmitry Torokhov
On Sat, Mar 05, 2016 at 09:44:24AM +0100, Hans Verkuil wrote: > Hi Dmitry, > > On 03/04/2016 08:58 PM, Dmitry Torokhov wrote: > > On Wed, Feb 10, 2016 at 01:51:39PM +0100, Hans Verkuil wrote: > >> +#define KEY_AUDIO_DESC0x26e &

Re: [PATCHv12 05/17] HID: add HDMI CEC specific keycodes

2016-03-04 Thread Dmitry Torokhov
On Wed, Feb 10, 2016 at 01:51:39PM +0100, Hans Verkuil wrote: > From: Kamil Debski > > Add HDMI CEC specific keycodes to the keycodes definition. > > Signed-off-by: Kamil Debski > Signed-off-by: Hans Verkuil > --- >

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 1:26 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 2:01 AM, Maarten Lankhorst <maarten.lankho...@linux.intel.com> wrote: > Op 15-12-15 om 02:29 schreef Dmitry Torokhov: >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 5:50 AM, Frank Binns wrote: > Is this not the issue fixed by 8e43c9c75? No because if we start teardown without waiting for the fence to be signaled it will still be on the active_list. Thanks. -- Dmitry -- To unsubscribe from this list: send

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 5:30 AM, Gustavo Padovan <gust...@padovan.org> wrote: > 2015-12-14 Dmitry Torokhov <d...@chromium.org>: > >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the followin

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 11:00 AM, Gustavo Padovan <gust...@padovan.org> wrote: > 2015-12-15 Daniel Vetter <dan...@ffwll.ch>: > >> On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: >> > Userspace can close the sync device while there are still active

[PATCH] android: fix warning when releasing active sync point

2015-12-14 Thread Dmitry Torokhov
(disable_signaling) to fence operations so that drivers can do proper clean ups when we remove last callback for given fence. Reviewed-by: Andrew Bresticker <abres...@chromium.org> Signed-off-by: Dmitry Torokhov <d...@chromium.org> --- drivers/dma-buf/fence.c| 6 +- drivers/sta

Re: ERROR: "vb2_ops_wait_finish" [drivers/input/touchscreen/sur40.ko] undefined!

2015-10-18 Thread Dmitry Torokhov
On Sat, Oct 17, 2015 at 06:19:31PM -0700, Randy Dunlap wrote: > On 10/17/15 17:38, kbuild test robot wrote: > > Hi Florian, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head:

Re: [PATCHv8 07/15] cec: add HDMI CEC framework

2015-08-18 Thread Dmitry Torokhov
On Tue, Aug 18, 2015 at 11:00:20AM +0100, Russell King - ARM Linux wrote: On Tue, Aug 18, 2015 at 10:26:32AM +0200, Hans Verkuil wrote: + /* Part 2: Initialize and register the character device */ + cdev_init(cecdev-cdev, cec_devnode_fops); + cecdev-cdev.owner = owner; + + ret =

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
On Thu, Jul 30, 2015 at 09:35:17AM -0700, Dmitry Torokhov wrote: Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: Hello, Short version: This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables to export that information so

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

2015-07-30 Thread Dmitry Torokhov
Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: Hello, Short version: This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables to export that information so modules have the correct aliases built-in and autoloading works correctly.

Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes

2015-06-30 Thread Dmitry Torokhov
On Tue, Jun 30, 2015 at 09:36:49AM +0200, Hans Verkuil wrote: On 06/29/15 21:25, Dmitry Torokhov wrote: On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil

Re: [PATCHv7 04/15] HID: add HDMI CEC specific keycodes

2015-06-29 Thread Dmitry Torokhov
On Mon, Jun 29, 2015 at 12:14:49PM +0200, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski ka...@wypas.org Signed-off-by: Hans Verkuil hans.verk...@cisco.com Could you please describe the intended

Re: [PATCHv7 05/15] input.h: add BUS_CEC type

2015-06-29 Thread Dmitry Torokhov
On Mon, Jun 29, 2015 at 12:14:50PM +0200, Hans Verkuil wrote: Inputs can come in over the HDMI CEC bus, so add a new type for this. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com --- include/uapi/linux/input.h | 1 + 1 file changed

Re: input_polldev interval (was Re: [sur40] Debugging a race condition)?

2015-03-25 Thread Dmitry Torokhov
On March 24, 2015 11:52:54 PM PDT, Florian Echtler f...@butterbrot.org wrote: Sorry for the continued noise, but this bug/crash is proving quite difficult to nail down. Currently, I'm setting the interval for input_polldev to 10 ms. However, with video data being retrieved at the same time, it's

Re: [PATCH 1/3] fixp-arith: replace sin/cos table by a better precision one

2015-02-04 Thread Dmitry Torokhov
to there, as they're not needed elsewhere. Cc: Hans de Goede hdego...@redhat.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: linux-in...@vger.kernel.org linux-in...@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Signed-off-by: Prashant Laddha prlad...@cisco.com Signed

[PATCH] [media] exynos4-is: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org --- Not tested, found by casual code inspection. drivers/media/platform/exynos4-is/fimc-is.c | 4 ++-- 1 file changed

Re: [PATCH] input:keyboard: keycode KEY_MAX changes some keycode value.

2013-11-23 Thread Dmitry Torokhov
Hi Andrew, On Sat, Nov 23, 2013 at 09:45:45PM +0800, andrew.liu200...@gmail.com wrote: From: Andrew Liu andrew.liu200...@gmail.com For exmaple, keycode: KEY_OK(0x160) is changed by and operation with KEY_MAX(0x2ff) to KEY_KPENTER(96). Signed-off-by: Andrew Liu andrew.liu200...@gmail.com

Re: [PATCH v2 4/8] drivers: input: use module_platform_driver_probe()

2013-03-14 Thread Dmitry Torokhov
Hi Fabio, On Thursday, March 14, 2013 06:09:34 PM Fabio Porcedda wrote: This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. I already have patches from Sachin Kamat for this, I am waiting for -rc3 to sync up with

Re: [PATCH] Media: remove incorrect __exit markups

2013-02-25 Thread Dmitry Torokhov
On Mon, Feb 25, 2013 at 08:49:26AM +0100, Guennadi Liakhovetski wrote: Hi Dmitry On Sun, 24 Feb 2013, Dmitry Torokhov wrote: Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods

[PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-25 Thread Dmitry Torokhov
() methods should not be marked __init unless platform_driver_probe() is used. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- v1-v2: removed __init markup on omap1_cam_probe() that was pointed out by Guennadi Liakhovetski. drivers/media/i2c/adp1653.c

[PATCH] Media: remove incorrect __exit markups

2013-02-24 Thread Dmitry Torokhov
-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/media/i2c/adp1653.c | 4 ++-- drivers/media/i2c/smiapp/smiapp-core.c | 4 ++-- drivers/media/platform/soc_camera/omap1_camera.c | 4 ++-- drivers/media/radio/radio-si4713.c | 4 ++-- drivers/media/rc

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Dmitry Torokhov
Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: The current kfifo API take the kfifo size as input, while it rounds _down_ the size to power of 2 at __kfifo_alloc. This may introduce potential issue. Take the code at drivers/hid/hid-logitech-dj.c as example:

Re: [PATCH 2/3] Input: move drivers/input/fixp-arith.h to include/linux

2012-04-23 Thread Dmitry Torokhov
(HUE). Signed-off-by: Antonio Ospite osp...@studenti.unina.it Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/ff-memless.c|3 +-- {drivers/input = include/linux}/fixp-arith.h |0 2 files changed, 1 insertion(+), 2 deletions(-) rename

Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-04-23 Thread Dmitry Torokhov
On Mon, Apr 23, 2012 at 03:21:04PM +0200, Antonio Ospite wrote: Hi, here are a couple more of controls for the gspca ov534 subdriver. In order to control the HUE value the sensor expects sin(HUE) and cos(HUE) to be set so I decided to reuse the fixed point implementation of sine and

Re: [PATCH 1/5] Driver core: driver_find() drops reference before returning

2012-01-28 Thread Dmitry Torokhov
or unloaded. Hence the patch will not introduce any new bugs. The existing callers all seem to be okay in this respect, however I don't understand the video drivers well enough to be certain about them. Signed-off-by: Alan Stern st...@rowland.harvard.edu CC: Dmitry Torokhov dmitry.torok

Re: [PATCH 5/7] [media] ati_remote: add keymap for Medion X10 RF remote

2011-08-07 Thread Dmitry Torokhov
On Sun, Aug 07, 2011 at 01:18:11AM +0300, Anssi Hannula wrote: Add keymap for the Medion X10 RF remote which uses the ati_remote driver, and default to it based on the usb id. Since rc-core supports loading custom keytmaps should we ass medion keymap here? I think we should keep the original

Re: [git:v4l-dvb/for_v3.1] [media] rc: call input_sync after scancode reports

2011-07-07 Thread Dmitry Torokhov
On Fri, Jul 01, 2011 at 09:34:45PM +0200, Mauro Carvalho Chehab wrote: This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/media_tree.git tree: Subject: [media] rc: call input_sync after scancode reports Author: Jarod

Re: [git:v4l-dvb/for_v3.1] [media] rc: call input_sync after scancode reports

2011-07-07 Thread Dmitry Torokhov
On Thu, Jul 07, 2011 at 08:28:12PM -0400, Jarod Wilson wrote: On Thu, Jul 7, 2011 at 7:58 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Jul 01, 2011 at 09:34:45PM +0200, Mauro Carvalho Chehab wrote: This is an automatic generated email to let you know that the following

Re: [PATCH] [media] rc: call input_sync after scancode reports

2011-06-23 Thread Dmitry Torokhov
function difference until the referenced change went into the input layer. Reported-by: Stephan Raue sr...@openelec.tv CC: Mauro Carvalho Chehab mche...@redhat.com CC: Jeff Brown jeffbr...@android.com Signed-off-by: Jarod Wilson ja...@redhat.com Signed-off-by: Dmitry Torokhov d...@mail.ru

Re: [PATCH v2] [media] rc: call input_sync after scancode reports

2011-06-23 Thread Dmitry Torokhov
keycode, which manifested with the reordering of calling input_report_key and setting last_keycode. Reported-by: Stephan Raue sr...@openelec.tv CC: Stephan Raue sr...@openelec.tv CC: Mauro Carvalho Chehab mche...@redhat.com CC: Jeff Brown jeffbr...@android.com CC: Dmitry Torokhov d...@mail.ru

Re: IR remote control autorepeat / evdev

2011-05-11 Thread Dmitry Torokhov
On Wed, May 11, 2011 at 08:59:16PM +0300, Anssi Hannula wrote: I meant replacing the softrepeat with native repeat for such devices that have native repeats but no native release events: - keypress from device = keydown + keyup - repeat from device = keydown + keyup - repeat from device =

Re: [RFC PATCH] input: add KEY_IMAGES specifically for AL Image Browser

2011-04-12 Thread Dmitry Torokhov
On Tuesday, April 12, 2011 02:00:53 PM Jarod Wilson wrote: Andy Walls wrote: Jarod Wilsonja...@redhat.com wrote: Many media center remotes have buttons intended for jumping straight to one type of media browser or another -- commonly, images/photos/pictures, audio/music, television,

Re: [Bug 30022] Kernel cannot find Flyvideo 98's remote control device.

2011-03-10 Thread Dmitry Torokhov
On Thursday, March 10, 2011 12:52:00 am bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=30022 --- Comment #7 from Mehmet TekbaĊŸ btek...@gmail.com 2011-03-10 08:51:59 --- Tried with Inca I-TV004 (bt878 analog card) and result didn't changed. IR

Re: cx23885-input.c does in fact use a workqueue....

2011-02-13 Thread Dmitry Torokhov
On Sun, Feb 13, 2011 at 08:35:22PM -0500, Andy Walls wrote: Tejun, I just noticed this commit: commit 8c71778cbf2c8beaefaa2dee5478aa0622d96682 Author: Tejun Heo t...@kernel.org Date: Fri Dec 24 16:14:20 2010 +0100 media/video: don't use flush_scheduled_work() This

[PATCH] dvb-usb-remote - convert to new style of get/setkeycode

2011-01-31 Thread Dmitry Torokhov
Input: dvb-usb-remote - convert to new style of get/setkeycode Signed-off-by: Dmitry Torokhov d...@mail.ru --- Mauro, This is needed so that I could rename get/setkeycode_new into get/setkeycode and get rid of duplicate pointers and compat code in input core. Compiled only, not tested. If you

[PATCH] Input: switch completely over to the new versions of get/setkeycode

2011-01-31 Thread Dmitry Torokhov
Input: switch completely over to the new versions of get/setkeycode All users of old style get/setkeycode methids have been converted so it is time to retire them. Signed-off-by: Dmitry Torokhov d...@mail.ru --- Jiri, Mauro, There is not a good way to avoid crossing multiple subsystems

Re: [PATCH] Input: switch completely over to the new versions of get/setkeycode

2011-01-31 Thread Dmitry Torokhov
. Signed-off-by: Dmitry Torokhov d...@mail.ru --- Jiri, Mauro, There is not a good way to avoid crossing multiple subsystems but the changes are minimal, so if you are OK with the patch I'd like to move it through my tree for .39. Acked-by: Mauro Carvalho Chehab mche

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 04:58:57PM -0200, Mauro Carvalho Chehab wrote: Em 27-01-2011 15:21, Dmitry Torokhov escreveu: On Thu, Jan 27, 2011 at 08:30:00AM -0200, Mauro Carvalho Chehab wrote: On my tests here, this is working fine, with Fedora and RHEL 6, on my usual test devices, so I don't

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 09:55:58AM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 07:39, Dmitry Torokhov escreveu: On Thu, Jan 27, 2011 at 04:58:57PM -0200, Mauro Carvalho Chehab wrote: Em 27-01-2011 15:21, Dmitry Torokhov escreveu: On Thu, Jan 27, 2011 at 08:30:00AM -0200, Mauro

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 11:53:25AM -0800, Dmitry Torokhov wrote: On Thu, Jan 27, 2011 at 01:12:48PM -0500, Mark Lord wrote: On 11-01-27 11:39 AM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: No, it does not seem to segfault when I unload/reload ir-kbd

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 03:01:58PM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 14:40, Dmitry Torokhov escreveu: On Fri, Jan 28, 2011 at 09:55:58AM -0200, Mauro Carvalho Chehab wrote: The rc-core register (and the corresponding input register) is done when the device detected

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 04:15:51PM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 15:33, Dmitry Torokhov escreveu: On Fri, Jan 28, 2011 at 03:01:58PM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 14:40, Dmitry Torokhov escreveu: On Fri, Jan 28, 2011 at 09:55:58AM -0200, Mauro

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 04:03:07PM -0500, Mark Lord wrote: On 11-01-28 03:55 PM, Mark Lord wrote: On 11-01-28 11:42 AM, Dmitry Torokhov wrote: On Thu, Jan 27, 2011 at 11:53:25AM -0800, Dmitry Torokhov wrote: On Thu, Jan 27, 2011 at 01:12:48PM -0500, Mark Lord wrote: On 11-01-27 11:39 AM

[PATCH] Input: rc-keymap - return KEY_RESERVED for unknown mappings

2011-01-28 Thread Dmitry Torokhov
...@teksavvy.com Signed-off-by: Dmitry Torokhov d...@mail.ru --- Linus, Due to the fact that contents of drivers/media in my 'for-linus' branch are quite different from mainline/Mauro's trees and I am not planning on merging this branch until closer to the next merge window I am sending

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-27 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: On 11-01-26 09:12 PM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 08:07:29PM -0500, Mark Lord wrote: On 11-01-26 08:01 PM, Mark Lord wrote: On 11-01-26 10:05 AM, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-27 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 08:30:00AM -0200, Mauro Carvalho Chehab wrote: On my tests here, this is working fine, with Fedora and RHEL 6, on my usual test devices, so I don't believe that the tool itself is broken, nor I think that the issue is due to the fix patch. I remember that when Kay

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-27 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 01:12:48PM -0500, Mark Lord wrote: On 11-01-27 11:39 AM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: No, it does not seem to segfault when I unload/reload ir-kbd-i2c and then invoke it by hand with the same parameters. Quite

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 10:05:57AM -0500, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 03:29:14PM -0800, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 05:22:09PM -0500, Mark Lord wrote: On 11-01-25 05:00 PM, Mauro Carvalho Chehab wrote: Em 25-01

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 12:18:29PM -0200, Mauro Carvalho Chehab wrote: Em 26-01-2011 11:08, Gerd Hoffmann escreveu: Hi, Btw, I took some time to take analyse the input-kbd stuff. As said at the README: This is a small collection of input layer utilities. I wrote them

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 12:18:29PM -0200, Mauro Carvalho Chehab wrote: diff --git a/input.c b/input.c index d57a31e..a9bd5e8 100644 --- a/input.c +++ b/input.c @@ -101,8 +101,8 @@ int device_open(int nr, int verbose) close(fd); return -1; } - if

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 03:41:01PM -0200, Mauro Carvalho Chehab wrote: Em 26-01-2011 12:58, Mark Lord escreveu: On 11-01-26 06:26 AM, Mauro Carvalho Chehab wrote: .. However, as said previously in this thread, input-kbd won't work with any RC table that uses NEC extended (and there are

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 03:29:09PM -0200, Mauro Carvalho Chehab wrote: Em 26-01-2011 14:51, Dmitry Torokhov escreveu: On Wed, Jan 26, 2011 at 12:18:29PM -0200, Mauro Carvalho Chehab wrote: diff --git a/input.c b/input.c index d57a31e..a9bd5e8 100644 --- a/input.c +++ b/input.c

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 08:16:09PM +0100, Gerd Hoffmann wrote:Hi, The check should be against concrete version (0x1 in this case). Stepping back: what does the version mean? Nothing, it is just a number. 0x1 == 1.0 ? 0x10001 == 1.1 ? No, not really. Can I expect the

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 02:31:44PM -0500, Mark Lord wrote: On 11-01-26 11:44 AM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 10:05:57AM -0500, Mark Lord wrote: .. Nope. Does not work here: $ lsinput protocol version mismatch (expected 65536, got 65537) It would be much more

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 02:33:17PM -0500, Mark Lord wrote: On 11-01-26 12:32 PM, Mauro Carvalho Chehab wrote: Em 26-01-2011 13:05, Mark Lord escreveu: .. Nope. Does not work here: $ lsinput protocol version mismatch (expected 65536, got 65537) You need to relax the version test at

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 02:47:18PM -0500, Mark Lord wrote: On 11-01-26 02:41 PM, Dmitry Torokhov wrote: I do not consider lsinput refusing to work a regression. Obviously, since you don't use that tool. Those of us who do use it see this as broken userspace compatibility. Who the hell

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 04:41:07PM -0500, Mark Lord wrote: On 11-01-26 02:50 PM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 02:47:18PM -0500, Mark Lord wrote: On 11-01-26 02:41 PM, Dmitry Torokhov wrote: I do not consider lsinput refusing to work a regression. Obviously, since you

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 04:49:14PM -0500, Mark Lord wrote: Or perhaps get rid of that unworkable version number thing (just freeze it in time with the 2.6.35 value returned), and implement a get_feature_flags ioctl or something for going forward. Then you can just turn on new bits in the flags

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 08:07:29PM -0500, Mark Lord wrote: On 11-01-26 08:01 PM, Mark Lord wrote: On 11-01-26 10:05 AM, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote: .. I wonder if the patch below is all that is needed... Nope. Does not work here: $ lsinput

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: On 11-01-26 09:12 PM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 08:07:29PM -0500, Mark Lord wrote: On 11-01-26 08:01 PM, Mark Lord wrote: On 11-01-26 10:05 AM, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 09:42:44AM -0200, Mauro Carvalho Chehab wrote: Em 25-01-2011 03:31, Dmitry Torokhov escreveu: On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: On 11-01-25 12:04 AM, Mark Lord wrote: On 11-01-24 11:55 PM, Dmitry Torokhov wrote: On Mon, Jan 24, 2011 at 11

Re: Extending rc-core/userspace to handle bigger scancodes - Was: Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 12:42:57PM -0200, Mauro Carvalho Chehab wrote: Em 25-01-2011 04:52, Dmitry Torokhov escreveu: On Mon, Jan 24, 2011 at 09:31:17PM -0800, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: On 11-01-25 12:04 AM, Mark Lord wrote: On 11-01

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 2:48 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: We should be able to handle the case where scancode is valid even though it might be unmapped yet. This is regardless of what version

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 12:54:53PM -0800, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 2:48 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: We should be able to handle the case where scancode is valid even though

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 07:20:07AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 7:01 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: BTW, another issue is that evdev's ioctl returns -EINVAL for unknown ioctls so applications would have hard time figuring out whether error

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 05:22:09PM -0500, Mark Lord wrote: On 11-01-25 05:00 PM, Mauro Carvalho Chehab wrote: Em 25-01-2011 18:54, Dmitry Torokhov escreveu: On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 2:48 AM, Dmitry Torokhov dmitry.torok

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 03:29:14PM -0800, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 05:22:09PM -0500, Mark Lord wrote: On 11-01-25 05:00 PM, Mauro Carvalho Chehab wrote: Em 25-01-2011 18:54, Dmitry Torokhov escreveu: On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-24 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: On 11-01-25 12:04 AM, Mark Lord wrote: On 11-01-24 11:55 PM, Dmitry Torokhov wrote: On Mon, Jan 24, 2011 at 11:37:06PM -0500, Mark Lord wrote: .. This results in (map-size==10) for 2.6.36+ (wrong), and a much larger map-size

  1   2   3   >