Re: [PATCH] dvb_frontend: fix typos in comments and one function

2010-06-10 Thread Guillaume Audirac
Hi Steven, > This and your other two patches are in > http://www.kernellabs.com/hg/~stoth/saa7164-dev > > They look good to me. What is the proper process to see the patches accepted and integrated ? I want to be aligned with the way of working before sending other corrections or improvements. T

Re: [PATCH] dvb_frontend: fix typos in comments and one function

2010-05-06 Thread Guillaume Audirac
Hello Steven, > I've had an open TDA10048 bug on my list for quite a while, I think > you've already made reference to this in an earlier email. Essentially > I'm told my a number of Australian users that the 10048 isn't > broad-locking when tuned +- 167Khz away from the carrier, which it > should

Re: Philips/NXP channel decoders

2010-05-06 Thread Guillaume Audirac
Hello Steven, > I can test your TDA10048 patches and add sign-off for merge. Looking > at the list it appears that you have a few nice cleanups. I'll draw > all of these together this weekend and run some tests. Thanks a lot. By the way, I found the read_ber function not fully defined. I guess th

[PATCH] dvb_frontend: fix typos in comments and one function

2010-05-06 Thread Guillaume Audirac
Hello, Trivial patch for typos. Signed-off-by: Guillaume Audirac --- drivers/media/dvb/dvb-core/dvb_frontend.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index

[PATCH] tda10048: clear the uncorrected packet registers when saturated

2010-05-06 Thread Guillaume Audirac
Hello, Use the register CLUNC to reset the CPTU registers (LSB & MSB) when they saturate at 0x. Fixes as well a few register typos. Signed-off-by: Guillaume Audirac --- drivers/media/dvb/frontends/tda10048.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff -

[PATCH] tda10048: fix bitmask for the transmission mode

2010-05-06 Thread Guillaume Audirac
Hello, Add a missing bit for reading the transmission mode (2K/8K) in tda10048_get_tps Signed-off-by: Guillaume Audirac --- drivers/media/dvb/frontends/tda10048.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/frontends/tda10048.c b/drivers/media

Re: [PATCH] tda10048: fix the uncomplete function tda10048_read_ber

2010-05-05 Thread Guillaume Audirac
Hello Steven, > Thanks Guillaume, I have a pile of other patches I'm ready to present > for merge so I'll pull this into one of my dev trees and present this > for merge also of course, I'll test it first! :) > > Thanks again for working on this. You're welcome. I am just starting reviewing t

[PATCH] tda10048: fix the uncomplete function tda10048_read_ber

2010-05-05 Thread Guillaume Audirac
Hello, Completes the bit-error-rate read function with the CBER register (before Viterbi decoder). The returned value is 1e8*actual_ber to be positive. Also includes some typo mistakes. Signed-off-by: Guillaume Audirac --- drivers/media/dvb/frontends/tda10048.c | 30

Philips/NXP channel decoders

2010-05-03 Thread Guillaume Audirac
Hello, I am new on this list and I would like to help with my support. I know rather well the Philips/NXP channel demodulators/decoders (TDA10023/24, TDA10046/A, TDA10048) as I've had to support them for a while. I am starting first in diving into the tda10048 driver (DVB-T) to become familiar wi