RE: [PATCH] [media] davinci: vpfe: Add documentation

2012-07-26 Thread Hadli, Manjunath
Laurent, Thank you for your comments. On Thu, Jul 26, 2012 at 05:55:31, Laurent Pinchart wrote: Hi Manjunath, On Tuesday 17 July 2012 10:43:54 Hadli, Manjunath wrote: On Sun, Jul 15, 2012 at 18:16:25, Laurent Pinchart wrote: On Wednesday 11 July 2012 21:09:26 Manjunath Hadli wrote

RE: [PATCH v4 1/2] media: add new mediabus format enums for dm365

2012-07-19 Thread Hadli, Manjunath
Hi Laurent, On Wed, Jul 18, 2012 at 16:35:18, Laurent Pinchart wrote: Hi Manjunath, On Tuesday 17 July 2012 12:22:42 Hadli, Manjunath wrote: On Tue, Jul 17, 2012 at 17:25:42, Laurent Pinchart wrote: On Tuesday 17 July 2012 11:41:11 Hadli, Manjunath wrote: On Tue, Jul 17, 2012 at 16

RE: [PATCH] [media] davinci: vpfe: Add documentation

2012-07-17 Thread Hadli, Manjunath
Hi Laurent, Thank you for your comments. On Sun, Jul 15, 2012 at 18:16:25, Laurent Pinchart wrote: Hi Manjunath, Thanks for the patch. On Wednesday 11 July 2012 21:09:26 Manjunath Hadli wrote: Add documentation on the Davinci VPFE driver. Document the subdevs, and private IOTCLs

RE: [PATCH v4 1/2] media: add new mediabus format enums for dm365

2012-07-17 Thread Hadli, Manjunath
Hi Laurent, Thanks for the review. On Tue, Jul 17, 2012 at 16:26:24, Laurent Pinchart wrote: Hi Manjunath, Thank you for the patch. Just some nitpicking, please see below. On Friday 30 March 2012 10:09:13 Hadli, Manjunath wrote: add new enum entries for supporting the media-bus

RE: [PATCH v4 2/2] v4l2: add new pixel formats supported on dm365

2012-07-17 Thread Hadli, Manjunath
Hi Laurent, On Tue, Jul 17, 2012 at 16:29:44, Laurent Pinchart wrote: Hi Manjunath, Thank you for the patch. A couple of comments below. On Friday 30 March 2012 10:09:14 Hadli, Manjunath wrote: add new macro V4L2_PIX_FMT_SGRBG10ALAW8 and associated formats to represent Bayer format

RE: [PATCH v4 1/2] media: add new mediabus format enums for dm365

2012-07-17 Thread Hadli, Manjunath
Hi Laurent, On Tue, Jul 17, 2012 at 17:25:42, Laurent Pinchart wrote: Hi Manjunath, On Tuesday 17 July 2012 11:41:11 Hadli, Manjunath wrote: On Tue, Jul 17, 2012 at 16:26:24, Laurent Pinchart wrote: On Friday 30 March 2012 10:09:13 Hadli, Manjunath wrote: add new enum entries

RE: [GIT PULL FOR v3.5] davicni: vpfe:media controller based capture driver for dm365

2012-07-10 Thread Hadli, Manjunath
Hi Mauro, On Thu, Jul 05, 2012 at 22:17:10, Mauro Carvalho Chehab wrote: Em 04-07-2012 02:01, Hadli, Manjunath escreveu: Mauro, Can you please pull the patches? Let me know if anything needs to be done from my side. -Manju On Thu, May 31, 2012 at 17:42:24, Hadli, Manjunath

RE: [GIT PULL FOR v3.5] davicni: vpfe:media controller based capture driver for dm365

2012-07-03 Thread Hadli, Manjunath
Mauro, Can you please pull the patches? Let me know if anything needs to be done from my side. -Manju On Thu, May 31, 2012 at 17:42:24, Hadli, Manjunath wrote: Mauro, The following patch set adds the media controller based driver TI dm365 SoC. Patches have gone through RFC and reviews

RE: [PATCH v3 08/13] davinci: vpif: add support for clipping on output data

2012-06-28 Thread Hadli, Manjunath
Hi, On Mon, Jun 25, 2012 at 18:53:20, Hans Verkuil wrote: On Mon 25 June 2012 15:18:41 Laurent Pinchart wrote: Hi Hans, On Monday 25 June 2012 15:08:10 Hans Verkuil wrote: On Mon 25 June 2012 14:54:39 Laurent Pinchart wrote: On Monday 25 June 2012 16:37:30 Manjunath Hadli wrote:

RE: [PATCH v3 04/13] davinci: vpif: fix setting of data width in config_vpif_params() function

2012-06-28 Thread Hadli, Manjunath
Hi Sergei, On Tue, Jun 26, 2012 at 16:06:01, Sergei Shtylyov wrote: Hello. On 25-06-2012 15:07, Manjunath Hadli wrote: fix setting of data width in config_vpif_params() function, which was wrongly set. Signed-off-by: Manjunath Hadlimanjunath.ha...@ti.com Signed-off-by: Lad,

RE: [PATCH v3 10/13] davinci: vpif capture:Add power management support

2012-06-28 Thread Hadli, Manjunath
Hi Laurent, On Mon, Jun 25, 2012 at 18:27:23, Laurent Pinchart wrote: Hi Manjunath, Thank you for the patch. On Monday 25 June 2012 16:37:32 Manjunath Hadli wrote: Implement power management operations - suspend and resume as part of dev_pm_ops for VPIF capture driver.

RE: [PATCH v3 09/13] davinci: vpif display: Add power management support

2012-06-28 Thread Hadli, Manjunath
Hi Laurent, On Mon, Jun 25, 2012 at 18:26:22, Laurent Pinchart wrote: Hi Manjunath, Thank you for the patch. On Monday 25 June 2012 16:37:31 Manjunath Hadli wrote: Implement power management operations - suspend and resume as part of dev_pm_ops for VPIF display driver.

RE: [PATCH v2 05/13] davinci: vpif display: declare contiguous region of memory handled by dma_alloc_coherent

2012-06-07 Thread Hadli, Manjunath
Hi Laurent, On Mon, May 14, 2012 at 13:16:27, Laurent Pinchart wrote: Hi Manjunath, On Friday 11 May 2012 05:30:43 Hadli, Manjunath wrote: On Tue, Apr 17, 2012 at 15:32:55, Laurent Pinchart wrote: On Tuesday 17 April 2012 14:23:03 Manjunath Hadli wrote: add support to declare

RE: [PATCH v2 01/13] davinci: vpif: add check for genuine interrupts in the isr

2012-06-07 Thread Hadli, Manjunath
Hi Laurent, On Mon, May 14, 2012 at 13:19:40, Laurent Pinchart wrote: Hi Manjunath, On Friday 11 May 2012 05:32:13 Hadli, Manjunath wrote: On Tue, Apr 17, 2012 at 15:36:16, Laurent Pinchart wrote: On Tuesday 17 April 2012 14:22:59 Manjunath Hadli wrote: As the same interrupt

[GIT PULL FOR v3.5] davicni: vpfe:media controller based capture driver for dm365

2012-05-31 Thread Hadli, Manjunath
Mauro, The following patch set adds the media controller based driver TI dm365 SoC. Patches have gone through RFC and reviews and are pending for some time. The main support added here: -CCDC capture -Previewer -Resizer -AEW/AF -Some media formats supported on dm365 -PIX_FORMATs supported on

RE: [PATCH v2 07/13] davinci: vpif: add support to use videobuf_iolock()

2012-05-10 Thread Hadli, Manjunath
Hi Laurent, On Tue, Apr 17, 2012 at 15:16:50, Laurent Pinchart wrote: Hi Manjunath, Thanks for the patch. On Tuesday 17 April 2012 14:23:05 Manjunath Hadli wrote: add support to use videobuf_iolock() instead of VPIF defined vpif_uservirt_to_phys API. Use videobuf_to_dma_contig API for

RE: [PATCH v2 05/13] davinci: vpif display: declare contiguous region of memory handled by dma_alloc_coherent

2012-05-10 Thread Hadli, Manjunath
Hi Laurent, On Tue, Apr 17, 2012 at 15:32:55, Laurent Pinchart wrote: Hi Manjunath, Thanks for the patch. On Tuesday 17 April 2012 14:23:03 Manjunath Hadli wrote: add support to declare contiguous region of memory to be handled when requested by dma_alloc_coherent call. The user can

RE: [PATCH v2 01/13] davinci: vpif: add check for genuine interrupts in the isr

2012-05-10 Thread Hadli, Manjunath
Hi Laurent, On Tue, Apr 17, 2012 at 15:36:16, Laurent Pinchart wrote: Hi Manjunath, Thanks for the patch. On Tuesday 17 April 2012 14:22:59 Manjunath Hadli wrote: As the same interrupt is shared between capture and display devices, sometimes we get isr calls where the interrupt might

RE: [PATCH v3 2/2] v4l2: add new pixel formats supported on dm365

2012-03-04 Thread Hadli, Manjunath
Sakari, On Sun, Mar 04, 2012 at 20:49:36, Sakari Ailus wrote: Hi Manju, Thanks for the patch. On Tue, Feb 07, 2012 at 03:35:14PM +0530, Manjunath Hadli wrote: add new macro V4L2_PIX_FMT_SGRBG10ALAW8 and associated formats to represent Bayer format frames compressed by A-LAW algorithm,

RE: [GIT PULL] davinci vpif pull request

2012-02-05 Thread Hadli, Manjunath
Mauro, A gentle reminder for the pull request. Cheers, -Manju On Fri, Jan 27, 2012 at 15:43:00, Hadli, Manjunath wrote: Hi Mauro, Can you please pull the following patch for v3.3-rc1 which removes some unnecessary inclusion of machine specific header files from the main driver files

[GIT PULL] davinci vpif pull request

2012-01-27 Thread Hadli, Manjunath
Hi Mauro, Can you please pull the following patch for v3.3-rc1 which removes some unnecessary inclusion of machine specific header files from the main driver files? This patch has undergone sufficient review already. It is just a cleanup patch and I don't expect any functionality to break

RE: [GIT PULL] davinci vpif pull request

2012-01-16 Thread Hadli, Manjunath
Mauro, On Mon, Jan 16, 2012 at 17:27:03, Mauro Carvalho Chehab wrote: Em 11-01-2012 09:39, Hadli, Manjunath escreveu: Hi Mauro, Can you please pull the following patch which removes some unnecessary inclusion of machine specific header files from the main driver files

RE: [GIT PULL] davinci vpif pull request

2012-01-16 Thread Hadli, Manjunath
Mauro, On Mon, Jan 16, 2012 at 18:26:25, Mauro Carvalho Chehab wrote: Em 16-01-2012 10:45, Hadli, Manjunath escreveu: Mauro, On Mon, Jan 16, 2012 at 17:27:03, Mauro Carvalho Chehab wrote: Em 11-01-2012 09:39, Hadli, Manjunath escreveu: Hi Mauro, Can you please pull the following patch

RE: [GIT PULL] davinci vpif pull request

2012-01-16 Thread Hadli, Manjunath
Mauro, On Mon, Jan 16, 2012 at 18:47:00, Mauro Carvalho Chehab wrote: Em 16-01-2012 11:06, Hadli, Manjunath escreveu: Mauro, On Mon, Jan 16, 2012 at 18:26:25, Mauro Carvalho Chehab wrote: Em 16-01-2012 10:45, Hadli, Manjunath escreveu: Mauro, On Mon, Jan 16, 2012 at 17:27:03, Mauro

RE: [PATCH 2/2] v4l2: add new pixel formats supported on dm365

2012-01-16 Thread Hadli, Manjunath
All, On Mon, Jan 02, 2012 at 16:51:06, Laurent Pinchart wrote: Hi Sakari, On Wednesday 28 December 2011 12:16:27 Sakari Ailus wrote: On Wed, Dec 21, 2011 at 11:23:26PM +0100, Laurent Pinchart wrote: On Wednesday 21 December 2011 14:56:36 Hadli, Manjunath wrote: On Wed, Dec 21, 2011

[GIT PULL] davinci vpif pull request

2012-01-11 Thread Hadli, Manjunath
Hi Mauro, Can you please pull the following patch which removes some unnecessary inclusion of machine specific header files from the main driver files? This patch has undergone sufficient review already. It is just a cleanup patch and I don't expect any functionality to break because

[GIT PULL] davinci vpbe pull request

2012-01-05 Thread Hadli, Manjunath
Hi Mauro, Can you please pull these vpbe patches which add the support for DM365 and DM355 display? The 3 vpbe patches were sent to you as a pull request earlier. Please see this mail: http://linux.omap.com/pipermail/davinci-linux-open-source/2011-November/023496.html I have now rebased

RE: [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver

2012-01-04 Thread Hadli, Manjunath
Sergei, On Wed, Jan 04, 2012 at 18:29:13, Sergei Shtylyov wrote: Hello. On 04-01-2012 11:17, Manjunath Hadli wrote: remove unnecessary inclusion of machine specific header files mach/dm646x.h, mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c driver which comes

RE: [PATCH 1/2] media: add new mediabus format enums for dm365

2011-12-21 Thread Hadli, Manjunath
Laurent, On Wed, Dec 21, 2011 at 05:28:31, Laurent Pinchart wrote: Hi Manju, On Friday 16 December 2011 15:20:24 Hadli, Manjunath wrote: On Thu, Dec 15, 2011 at 18:32:44, Laurent Pinchart wrote: On Thursday 15 December 2011 13:24:57 Manjunath Hadli wrote: add new enum entry

RE: [PATCH 2/2] v4l2: add new pixel formats supported on dm365

2011-12-21 Thread Hadli, Manjunath
Laurent, On Wed, Dec 21, 2011 at 05:32:08, Laurent Pinchart wrote: Hi Manju, On Friday 16 December 2011 14:42:48 Hadli, Manjunath wrote: On Thu, Dec 15, 2011 at 18:30:47, Laurent Pinchart wrote: On Thursday 15 December 2011 13:24:58 Manjunath Hadli wrote: add new macro

RE: [PATCH 2/2] v4l2: add new pixel formats supported on dm365

2011-12-16 Thread Hadli, Manjunath
Hello Laurent, Thank you for the comments. On Thu, Dec 15, 2011 at 18:30:47, Laurent Pinchart wrote: Hi Manjunath, Thanks for the patch. On Thursday 15 December 2011 13:24:58 Manjunath Hadli wrote: add new macro V4L2_PIX_FMT_SGRBG10ALAW8 to represent Bayer format frames compressed by

RE: [PATCH 1/2] media: add new mediabus format enums for dm365

2011-12-16 Thread Hadli, Manjunath
Laurent, Thank you for the comments. On Thu, Dec 15, 2011 at 18:32:44, Laurent Pinchart wrote: Hi Manhunath, Thanks for the patch. On Thursday 15 December 2011 13:24:57 Manjunath Hadli wrote: add new enum entry V4L2_MBUS_FMT_SGRBG10_ALAW8_1X8 into mbus_pixel_code to represent A-LAW

RE: [PATCH v6 01/11] davinci: vpif: remove obsolete header file inclusion

2011-12-16 Thread Hadli, Manjunath
Mauro, Sekhar needs your ack on this to get a series of mach patches in. Can you please have a look at this? -Manju On Thu, Dec 15, 2011 at 17:41:50, Hadli, Manjunath wrote: remove inclusion of header files from vpif.h and vpif_dispaly.c and add appropriate header file for building

RE: [PATCH] vpif_capture.c: v4l2_device_register() is called too late in vpif_probe()

2011-12-13 Thread Hadli, Manjunath
Hans, On Tue, Dec 13, 2011 at 15:14:42, Hans Verkuil wrote: The function v4l2_device_register() is called too late in vpif_probe(). This meant that vpif_obj.v4l2_dev is accessed before it is initialized which caused a crash. This used to work in the past, but video_register_device() is now

RE: [PATCH v3 0/5] ARM: davinci: re-arrange definitions to have a common davinci header

2011-12-01 Thread Hadli, Manjunath
Sekhar, On Wed, Nov 30, 2011 at 17:07:21, Nori, Sekhar wrote: Hi Manju, On Thu, Nov 17, 2011 at 15:48:53, Hadli, Manjunath wrote: Re-arrange definitions and remove unnecessary code so that we canx These are two different things and should be done in separate patches. Sergei has already

RE: [PATCH v3 4/5] ARM: davinci: create new common platform header for davinci

2011-11-17 Thread Hadli, Manjunath
Sergei, Thank you for the comments. On Thu, Nov 17, 2011 at 16:18:17, Sergei Shtylyov wrote: Hello. On 17-11-2011 14:18, Manjunath Hadli wrote: remove the code from individual platform header files for dm365, dm355, dm644x and dm646x and consolidate it into a single and common

RE: [PATCH] board-dm646x-evm.c: wrong register used in setup_vpif_input_channel_mode

2011-11-17 Thread Hadli, Manjunath
Hans, Thank you for the patch. I have verified from the data sheet. It might be a copy mistake. It also says the vpif_vsclkdis_reg can be used to disable and enable in case we make any clock switches so as to avoid glitches. In this case I would imagine we would stream off before switching, so

RE: [PATCH v2 4/5] davinci: create new common platform header for davinci

2011-11-15 Thread Hadli, Manjunath
Sergei, On Tue, Nov 15, 2011 at 15:33:14, Sergei Shtylyov wrote: Hello. On 14-11-2011 19:09, Manjunath Hadli wrote: remove the code from individual platform header files for dm365, dm355, dm644x and dm646x and consolidate it into a single and common header file davinci_common.h.

RE: [PATCH v2 5/5] davinci: delete individual platform header files and use a common header

2011-11-15 Thread Hadli, Manjunath
Sergei, On Tue, Nov 15, 2011 at 16:24:49, Sergei Shtylyov wrote: Hello. On 14-11-2011 19:09, Manjunath Hadli wrote: include davinci_common.h file in files using the platform header file for dm355, dm365, dm644x and dm646x and delete the individual platform header files.

RE: [PATCH v2 1/5] davinci: dm644x: remove the macros from the header to move to c file

2011-11-15 Thread Hadli, Manjunath
Sergei, On Tue, Nov 15, 2011 at 16:10:16, Sergei Shtylyov wrote: Hello. On 14-11-2011 19:09, Manjunath Hadli wrote: move the register base addresses and offsets used only by dm644x platform file from platform header dm644x.h to dm644x.c as they are used only in the c file.

RE: [GIT PULL] davinci vpbe: enable DM365 v4l2 display driver

2011-11-14 Thread Hadli, Manjunath
Mauro, A gentle reminder for the pull request. These have been acked by Hans. Cheers, -Manju On Wed, Sep 28, 2011 at 18:32:48, Hadli, Manjunath wrote: Mauro, Please pull : git://linuxtv.org/mhadli/v4l-dvb-davinci_devices.git for_mauro The patchset adds incremental changes necessary

new mbus formats

2011-10-23 Thread Hadli, Manjunath
Hi, I need a few mbus formats to be defined loosely for following. Please tell me if anyone has already thought of taking care of them already. These are supported for Texas Instruments DM365 and DM355 SoCs. 1. RGB 888 parallel: 2. YUV420 color separate: 3. C plane 420: ( On the

RE: [PATCH RESEND 2/4] davinci vpbe: add dm365 VPBE display driver changes

2011-09-28 Thread Hadli, Manjunath
On Mon, Sep 26, 2011 at 18:31:48, Hans Verkuil wrote: On Monday, September 19, 2011 07:35:27 Manjunath Hadli wrote: This patch implements the core additions to the display driver, mainly controlling the VENC and other encoders for dm365. This patch also includes addition of amplifier

RE: [PATCH RESEND 1/4] davinci vpbe: remove unused macro.

2011-09-26 Thread Hadli, Manjunath
On Sat, Sep 24, 2011 at 05:04:26, Mauro Carvalho Chehab wrote: Em 19-09-2011 02:35, Manjunath Hadli escreveu: remove VPBE_DISPLAY_SD_BUF_SIZE as it is no longer used. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com --- drivers/media/video/davinci/vpbe_display.c |1 - 1

RE: [PATCH RESEND 0/4] davinci vpbe: enable DM365 v4l2 display driver

2011-09-26 Thread Hadli, Manjunath
On Sat, Sep 24, 2011 at 05:08:34, Mauro Carvalho Chehab wrote: Em 19-09-2011 02:35, Manjunath Hadli escreveu: The patchset adds incremental changes necessary to enable dm365 v4l2 display driver, which includes vpbe display driver changes, osd specific changes and venc changes. The changes

RE: [PATCH RESEND 0/4] davinci vpbe: enable DM365 v4l2 display driver

2011-09-26 Thread Hadli, Manjunath
On Mon, Sep 26, 2011 at 16:46:52, Hans Verkuil wrote: On Monday, September 19, 2011 07:49:18 Hadli, Manjunath wrote: Sakari, Hans, Can I request you to have a look at these patches too? It's on my TODO list for this week. Thank you Hans. I will pull request nevertheless, and Mauro can

RE: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-09-18 Thread Hadli, Manjunath
Mauro, Thank you for your note. The first RFC for this (VPFE MC) driver was sent only in August this year. The other driver being discussed before was VPBE (which did go through some grind but not 2 years) which you accepted. This series of patches is definitely not two years old (unless I

RE: [PATCH RESEND 0/4] davinci vpbe: enable DM365 v4l2 display driver

2011-09-18 Thread Hadli, Manjunath
Sakari, Hans, Can I request you to have a look at these patches too? Thanks and Regards, -Manju On Mon, Sep 19, 2011 at 11:05:25, Hadli, Manjunath wrote: The patchset adds incremental changes necessary to enable dm365 v4l2 display driver, which includes vpbe display driver changes, osd

RE: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-09-12 Thread Hadli, Manjunath
Thank you Sakari. -Manju On Mon, Sep 12, 2011 at 17:29:25, Sakari Ailus wrote: On Sat, Sep 10, 2011 at 12:11:37PM +0530, Hadli, Manjunath wrote: Hi Sakari, On Fri, Sep 09, 2011 at 21:49:40, Sakari Ailus wrote: On Fri, Sep 09, 2011 at 07:10:49PM +0530, Hadli, Manjunath wrote: Hi Sakari

RE: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-09-10 Thread Hadli, Manjunath
Hi Sakari, On Fri, Sep 09, 2011 at 21:49:40, Sakari Ailus wrote: On Fri, Sep 09, 2011 at 07:10:49PM +0530, Hadli, Manjunath wrote: Hi Sakari, On Thu, Sep 01, 2011 at 03:00:32, Sakari Ailus wrote: Hi Manju, Do you have the media device grap that would be typical for this hardware

RE: [PATCH v2 1/8] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2011-09-09 Thread Hadli, Manjunath
Hi Sylwester, Thank you for your comments. My responses inline. Thanks and Regards, -Manju On Fri, Sep 02, 2011 at 02:17:49, Sylwester Nawrocki wrote: Hi Manjunath, A few comments below... On 08/29/2011 05:07 PM, Manjunath Hadli wrote: add support for dm3xx IPIPEIF hardware setup.

RE: [PATCH v2 4/8] davinci: vpfe: add support for CCDC hardware for dm365

2011-09-09 Thread Hadli, Manjunath
Thank you for these comments too. My responses inlined. -Manju On Fri, Sep 02, 2011 at 02:53:08, Sylwester Nawrocki wrote: Hi Manjunath, few more comments below.. On 08/29/2011 05:07 PM, Manjunath Hadli wrote: add support for ccdc on dm365 SoC. ccdc is responsible for capturing video

RE: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-09-09 Thread Hadli, Manjunath
Hi Sakari, On Thu, Sep 01, 2011 at 03:00:32, Sakari Ailus wrote: Hi Manju, Do you have the media device grap that would be typical for this hardware produced by media-ctl? That can be converted to postscript using dotfile. this would make it a little easier to understan this driver.

RE: [RFC PATCH 1/8] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2011-08-29 Thread Hadli, Manjunath
Sakari, I have sent a fresh patch-set with your comments fixed and and some cleanup and reorg of my own- mainly the headers. Please review. Also, I had to keep one of your comments without code change as I felt it was Ok to keep it here as it is only a local variable which actually

RE: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-08-29 Thread Hadli, Manjunath
Please treat the patches as RFC. Thx, -manju On Mon, Aug 29, 2011 at 20:37:11, Hadli, Manjunath wrote: changes from last patch set: 1. Made changes based on Sakari's feedback mainly: a. returned early to allow unindenting b. reformatting to shift the code to left where

RE: [RFC PATCH 1/8] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2011-07-19 Thread Hadli, Manjunath
Sakari, Thank you for your comments. I agree with them and fix. Please comment on the rest of the patches as well. -Manju On Thu, Jul 14, 2011 at 00:20:50, Sakari Ailus wrote: Hi Manju, Thanks for the patchset! I have a few comments on this patch below. I haven't read the rest of the

RE: [ RFC PATCH 0/8] RFC for Media Controller capture driver for DM365

2011-07-12 Thread Hadli, Manjunath
Sakari/Laurent, Did you get some time to review the code? Will look forward for your comments. -Manju On Wed, Jul 06, 2011 at 11:10:38, Hadli, Manjunath wrote: Hi Sakari, On Mon, Jul 04, 2011 at 21:43:09, Sakari Ailus wrote: Hadli, Manjunath wrote: Thank you Laurent. Hi

RE: [ RFC PATCH 0/8] RFC for Media Controller capture driver for DM365

2011-07-05 Thread Hadli, Manjunath
Hi Sakari, On Mon, Jul 04, 2011 at 21:43:09, Sakari Ailus wrote: Hadli, Manjunath wrote: Thank you Laurent. Hi Manjunath, On Mon, Jul 04, 2011 at 18:52:37, Laurent Pinchart wrote: Hi Manjunath, On Monday 04 July 2011 07:58:06 Hadli, Manjunath wrote: On Thu, Jun 30, 2011 at 19

RE: [ RFC PATCH 0/8] RFC for Media Controller capture driver for DM365

2011-07-04 Thread Hadli, Manjunath
Thank you Laurent. On Mon, Jul 04, 2011 at 18:52:37, Laurent Pinchart wrote: Hi Manjunath, On Monday 04 July 2011 07:58:06 Hadli, Manjunath wrote: On Thu, Jun 30, 2011 at 19:27:36, Sakari Ailus wrote: [snip] I understand that not all the blocks are there. Are there any major

RE: [ RFC PATCH 0/8] RFC for Media Controller capture driver for DM365

2011-07-03 Thread Hadli, Manjunath
Sakari, Thank you for the comments. My responses inlined. -Manjunath On Thu, Jun 30, 2011 at 19:27:36, Sakari Ailus wrote: Hi Manjunath, Thanks for the patches. On Thu, Jun 30, 2011 at 06:43:09PM +0530, Manjunath Hadli wrote: Thease are the RFC patches for the DM365 video capture, of

RE: [RFC] Media Controller Capture driver for DM365

2011-06-28 Thread Hadli, Manjunath
Laurent, Sorry for getting back late on this. I was also tied up. I am following it up with the patches. -Manju On Mon, May 02, 2011 at 03:36:23, Laurent Pinchart wrote: Hi Manjunath, On Wednesday 27 April 2011 16:14:03 Hadli, Manjunath wrote: Introduction

RE: [RESEND PATCH v19 0/6] davinci vpbe: dm6446 v4l2 driver

2011-06-27 Thread Hadli, Manjunath
Thanks Mauro. I will make sure I send you a pull request from a git tree. -Manju On Wed, Jun 22, 2011 at 00:54:01, Mauro Carvalho Chehab wrote: Em 17-06-2011 04:03, Hadli, Manjunath escreveu: Mauro, Can you consider this patch series for a pull? Next time, could you please add on your

RE: [RESEND PATCH v19 0/6] davinci vpbe: dm6446 v4l2 driver

2011-06-17 Thread Hadli, Manjunath
Mauro, Can you consider this patch series for a pull? -Manju On Fri, Jun 17, 2011 at 12:31:30, Hadli, Manjunath wrote: fixed a wrong file inclusion in one of the patches Manjunath Hadli (6): davinci vpbe: V4L2 display driver for DM644X SoC davinci vpbe: VPBE display driver davinci

RE: [PATCH v17 5/6] davinci vpbe: Build infrastructure for VPBE driver

2011-05-24 Thread Hadli, Manjunath
On Mon, May 23, 2011 at 13:58:26, Nori, Sekhar wrote: On Fri, May 20, 2011 at 20:02:08, Sergei Shtylyov wrote: Hello. Manjunath Hadli wrote: This patch adds the build infra-structure for Davinci VPBE dislay driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com

RE: [PATCH v16 01/13] davinci vpbe: V4L2 display driver for DM644X SoC

2011-05-19 Thread Hadli, Manjunath
last reviewed was: http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git?a=commit;h=690187eb05de65f1e63fc631ad4dc31358d01e55 Thanks, -Manju On Mon, May 02, 2011 at 15:28:23, Laurent Pinchart wrote: Hi Manjunath, On Tuesday 26 April 2011 16:47:45 Hadli, Manjunath wrote: Laurent, Can

[RFC] Media Controller Capture driver for DM365

2011-04-27 Thread Hadli, Manjunath
Introduction This is the proposal of the initial version of design and implementation of the DM365 VPFE (Video Port Front End) drivers using Media Controloler , the initial version which supports the following: 1) dm365 vpfe 2) ccdc,previewer,resizer,h3a,af blocks 3) supports both

RE: [PATCH v16 01/13] davinci vpbe: V4L2 display driver for DM644X SoC

2011-04-26 Thread Hadli, Manjunath
, April 26, 2011 12:07 PM To: Hadli, Manjunath Cc: LMML; Kevin Hilman; LAK; Nori, Sekhar; dlos Subject: Re: [PATCH v16 01/13] davinci vpbe: V4L2 display driver for DM644X SoC Manjunath Hadli wrote: This is the display driver for Texas Instruments's DM644X family SoC. This patch contains the main

RE: [PATCH v16 01/13] davinci vpbe: V4L2 display driver for DM644X SoC

2011-04-26 Thread Hadli, Manjunath
/v4l-dvb-davinci_devices.git?a=commitdiff;h=69f60ed7577ab9184ceabd7efbe5bb3453bf7ef1;hp=a400604f47c339831880c50eda6f6b03221579e3 -Manju -Original Message- From: Hadli, Manjunath Sent: Monday, April 25, 2011 2:20 PM To: 'Laurent Pinchart' Cc: davinci-linux-open-sou...@linux.davincidsp.com

RE: [PATCH v16 01/13] davinci vpbe: V4L2 display driver for DM644X SoC

2011-04-25 Thread Hadli, Manjunath
Laurent, Thank you for your comments. Please find my updates below. The updated patches will follow today. -Manju On Thu, Apr 21, 2011 at 15:48:05, Laurent Pinchart wrote: Hi Manjunath, On Wednesday 20 April 2011 17:30:08 Hadli, Manjunath wrote: Hi Laurent, Thank you for you very

RE: [PATCH v18 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-04-20 Thread Hadli, Manjunath
On Tue, Apr 05, 2011 at 16:28:33, Nori, Sekhar wrote: Hi Manju, On Sat, Apr 02, 2011 at 15:13:17, Hadli, Manjunath wrote: Current devices.c file has a number of instances where IO_ADDRESS() is used for system module register access. Eliminate this in favor of a ioremap() based access

RE: [PATCH v17 00/13] davinci vpbe: dm6446 v4l2 driver

2011-03-22 Thread Hadli, Manjunath
Sekhar, Kevin, These patches have gone through considerable reviews. Could you please ACK from your end? Thanks and Regards, -Manju On Tue, Mar 15, 2011 at 19:26:28, Hadli, Manjunath wrote: version17: The more important among the patch history from previous comments 1. Replacing

RE: [PATCH 1/7] davinci: move DM64XX_VDD3P3V_PWDN to devices.c

2011-03-14 Thread Hadli, Manjunath
Please ignore this platform patch series. I will repost it with the core driver patch series as well. Thx, -Manju On Mon, Mar 14, 2011 at 19:25:18, Hadli, Manjunath wrote: Move the definition of DM64XX_VDD3P3V_PWDN from hardware.h to devices.c since it is used only there. Signed-off

RE: [RFC] davinci: vpfe: mdia controller implementation for capture

2011-03-07 Thread Hadli, Manjunath
On Sun, Mar 06, 2011 at 22:59:40, Laurent Pinchart wrote: Hi Manjunath, On Sunday 06 March 2011 16:36:05 Manjunath Hadli wrote: Introduction This is the proposal of the initial version of design and implementation of the Davinci family (dm644x,dm355,dm365)VPFE (Video

RE: [PATCH v16 3/3] davinci vpbe: board specific additions

2011-01-20 Thread Hadli, Manjunath
Hi, On Wed, Jan 19, 2011 at 21:42:00, Robert Mellen wrote: Are the davinci vpbe patches specific only to the DM644x platform? I am developing on the DM365 and would like to use the OSD features implemented in the patches. Are there plans to port these patches to the DM365? Is it only a

RE: [PATCH v14 1/2] davinci vpbe: platform specific additions

2011-01-17 Thread Hadli, Manjunath
On Sat, Jan 15, 2011 at 21:13:33, Sergei Shtylyov wrote: Hello. On 14-01-2011 16:31, Manjunath Hadli wrote: This patch implements the overall device creation for the Video display driver. It does not only that... Signed-off-by: Manjunath Hadlimanjunath.ha...@ti.com

RE: [PATCH v13 5/8] davinci vpbe: platform specific additions

2011-01-10 Thread Hadli, Manjunath
On Mon, Jan 10, 2011 at 17:25:33, Nori, Sekhar wrote: On Mon, Jan 10, 2011 at 16:58:41, Sergei Shtylyov wrote: + +#define OSD_REG_SIZE 0x01ff +#define VENC_REG_SIZE0x017f Well, actually that's not the size but limit -- sizes

RE: [PATCH v12 5/8] davinci vpbe: platform specific additions

2011-01-07 Thread Hadli, Manjunath
On Fri, Jan 07, 2011 at 19:27:37, Sergei Shtylyov wrote: Hello. On 07-01-2011 16:40, Manjunath Hadli wrote: This patch implements the overall device creation for the Video display driver. Signed-off-by: Manjunath Hadlimanjunath.ha...@ti.com Acked-by: Muralidharan

RE: [PATCH 0/5] DaVinci VPIF: Support for DV preset and DV timings.

2011-01-05 Thread Hadli, Manjunath
Tested for SD modes on TI Dm6467 EVM. DV_PRESTES testing done for THS8200 based EVM by Hans. For the whole patch series: Acked-by: Manjunath Hadli manjunath.ha...@ti.com Regards, -Manju -Original Message- From: linux-media-ow...@vger.kernel.org

RE: [RFC PATCH 0/2] davinci: convert to core-assisted locking

2011-01-05 Thread Hadli, Manjunath
Tested for SD loopback and other IOCTLS. Reviewed the patches. Patch series Acked by: Manjunath Hadli manjunath.ha...@ti.com -Manju On Wed, Jan 05, 2011 at 22:12:38, Hans Verkuil wrote: These two patches convert vpif_capture and vpif_display to core-assisted locking and now use

RE: [PATCH v10 5/8] davinci vpbe: platform specific additions

2010-12-24 Thread Hadli, Manjunath
Sergei, On Thu, Dec 23, 2010 at 23:19:30, Sergei Shtylyov wrote: Hello. Manjunath Hadli wrote: This patch implements the overall device creation for the Video display driver Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri m-kariche...@ti.com

RE: [PATCH v10 0/8] davinci vpbe: dm6446 v4l2 driver

2010-12-23 Thread Hadli, Manjunath
On Thu, Dec 23, 2010 at 17:23:37, Hadli, Manjunath wrote: version10: addressed Kevin's and Sergei's comments on: 1.Lines spacing. 2.Language errors 3.Now based on Kevin Hilman's tree :) Manjunath Hadli (8): davinci vpbe: V4L2 display driver for DM644X SoC davinci vpbe: VPBE display

RE: [PATCH v8 6/8] davinci vpbe: board specific additions

2010-12-22 Thread Hadli, Manjunath
Sergei, Only one comment. For others I have done the fixes. Thanks and Regards, -Manju Others On Tue, Dec 21, 2010 at 17:13:30, Sergei Shtylyov wrote: Hello. On 20-12-2010 16:54, Manjunath Hadli wrote: This patch implements tables for display timings,outputs and other board related

RE: Volunteers needed: BKL removal: replace .ioctl by .unlocked_ioctl

2010-12-20 Thread Hadli, Manjunath
Hans, I can take a look at this (DM6467)conversion unless your colleague has already started working on t. -Manju On Sun, Dec 19, 2010 at 02:48:05, Hans Verkuil wrote: On Saturday, December 18, 2010 16:38:29 Muralidharan Karicheri wrote: Hans, For davinci drivers, I will be able to do

RE: [PATCH v7 5/8] davinci vpbe: board specific additions

2010-12-20 Thread Hadli, Manjunath
On Fri, Dec 17, 2010 at 21:59:23, Sergei Shtylyov wrote: Hello. Manjunath Hadli wrote: This patch implements tables for display timings,outputs and other board related functionalities. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Acked-by: Muralidharan Karicheri

RE: [PATCH v6 7/7] davinci vpbe: Readme text for Dm6446 vpbe

2010-12-16 Thread Hadli, Manjunath
, MD 20874 -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Manjunath Hadli Sent: Wednesday, December 15, 2010 4:12 AM To: LMML Cc: dlos; Mauro Carvalho Chehab; Hans Verkuil; Hadli, Manjunath Subject: [PATCH v6 7/7

RE: [PATCH v3 6/6] davinci vpbe: Build infrastructure for VPBE driver

2010-12-10 Thread Hadli, Manjunath
Sergei, Thank you for your comments. Will send a corrected pacth. -Manju On Thu, Dec 09, 2010 at 17:42:00, Sergei Shtylyov wrote: Hello. On 02-12-2010 15:39, Manjunath Hadli wrote: This patch adds the build infra-structure for Davinci VPBE dislay driver Signed-off-by: Manjunath

RE: [PATCH v3 2/6] davinci vpbe: VPBE display driver

2010-12-08 Thread Hadli, Manjunath
Hans, Thanks for the comments. Only one comment from me. Rest everything I have taken care. Thanks and Regards, -Manju On Tue, Dec 07, 2010 at 02:13:45, Hans Verkuil wrote: Comments below... On Thursday, December 02, 2010 13:38:36 Manjunath Hadli wrote: This patch implements the coe

RE: [PATCH v2 5/6] davinci vpbe: platform specific additions

2010-11-29 Thread Hadli, Manjunath
On Sat, Nov 27, 2010 at 20:52:14, Muralidharan Karicheri wrote: +static int dm644x_set_if_config(enum v4l2_mbus_pixelcode pixcode) { +       unsigned int val = 0; +       int ret = 0; + +       switch (pixcode) { +       case V4L2_MBUS_FMT_FIXED: +             /* Analog out.do

RE: [PATCH v2 5/6] davinci vpbe: platform specific additions

2010-11-29 Thread Hadli, Manjunath
Resending the reply with proper indentation.. On Mon, Nov 29, 2010 at 21:27:39, Hadli, Manjunath wrote: On Sat, Nov 27, 2010 at 20:52:14, Muralidharan Karicheri wrote: +static int dm644x_set_if_config(enum v4l2_mbus_pixelcode pixcode) { +       unsigned int val = 0; +       int ret = 0

RE: [PATCH 0/6] davinci vpbe: V4L2 Display driver for DM644X

2010-11-19 Thread Hadli, Manjunath
Hans, Thank you for the review comments. I will include a section on customizing for additions and changes to different boards. Thanks again, -Manju On Sat, Nov 13, 2010 at 18:22:19, Hans Verkuil wrote: Hi Manju, I've reviewed the other patches as well. The only one for which I had

RE: mediabus enums

2010-11-12 Thread Hadli, Manjunath
On Thu, Nov 11, 2010 at 22:17:23, Laurent Pinchart wrote: Hi Guennadi, On Thursday 11 November 2010 16:32:02 Guennadi Liakhovetski wrote: On Wed, 10 Nov 2010, Hadli, Manjunath wrote: Hello Guennadi, Your media-bus enumerations capture the formats quite well. I needed

RE: [PATCH 0/6] davinci vpbe: V4L2 Display driver for DM644X

2010-11-10 Thread Hadli, Manjunath
Murali, I will change the name order. Thanks and Regards, -manju On Wed, Nov 10, 2010 at 18:35:16, Muralidharan Karicheri wrote: Manjunath, Thank you for putting up this patch together. I didn't see the 1/6 of this series in the mailing list. Also it appears as if the patch came from me.

mediabus enums

2010-11-10 Thread Hadli, Manjunath
Hello Guennadi, Your media-bus enumerations capture the formats quite well. I needed the following for support on Davinci SOCs and liked to check with you if these are covered in some format in the list. 1. Parallel RGB 666 (18 data lines+ 5 sync lines) 2. YUYV16 (16 lines) (16 data lines +

RE: [PATCH 1/6] davinci vpbe: V4L2 display driver for DM644X SoC

2010-11-10 Thread Hadli, Manjunath
Will do. Thanks! -manju On Wed, Nov 10, 2010 at 18:54:12, Hans Verkuil wrote: Hans, Thank you for the review. I have taken care of the points you mentioned. The name comparison is unnecessary. I have also replaced the native struct definitions with those of v4l2. Request you to go

RE: [PATCH 6/6] davinci vpbe: Build infrastructure for VPBE driver

2010-11-09 Thread Hadli, Manjunath
On Tue, Nov 09, 2010 at 20:21:50, Sergei Shtylyov wrote: Hello. Manjunath Hadli wrote: From: Muralidharan Karicheri m-kariche...@ti.com This patch adds the build infra-structure for Davinci VPBE dislay driver. Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com

RE: Embedded Linux Conference

2009-03-05 Thread Hadli, Manjunath
That is great! I will let you know our plans soon. -Manju -Original Message- From: DongSoo(Nathaniel) Kim [mailto:dongsoo@gmail.com] Sent: Friday, March 06, 2009 9:33 AM To: Hans Verkuil Cc: linux-media@vger.kernel.org; linux-o...@vger.kernel.org; Hadli, Manjunath; Aguirre