RE: [PATCH 10/10] ux500: MCDE: Add platform specific data

Hi, + + if (ddev-id == PRIMARY_DISPLAY_ID rotate_main) { + swap(width, height); +#ifdef CONFIG_DISPLAY_GENERIC_DSI_PRIMARY_ROTATE_180_DEGREES + rotate = FB_ROTATE_CCW; +#else + rotate = FB_ROTATE_CW; +#endif + } + + virtual_width =

RE: [PATCH 02/10] MCDE: Add configuration registers

Hi, This patch adds the configuration registers found in MCDE. + +#define MCDE_VAL2REG(__reg, __fld, __val) \ + (((__val) __reg##_##__fld##_SHIFT) __reg##_##__fld##_MASK) +#define MCDE_REG2VAL(__reg, __fld, __val) \ + (((__val) __reg##_##__fld##_MASK)

RE: [PATCH 08/10] MCDE: Add frame buffer device

Hi, On Wednesday 10 November 2010, Jimmy Rubin wrote: + +static struct platform_device mcde_fb_device = { + .name = mcde_fb, + .id = -1, +}; Do not introduce new static devices. We are trying to remove them and they will stop working. Why do you even need a device here

RE: [PATCH 07/10] MCDE: Add display subsystem framework

Hi, +struct kobj_type ovly_type = { + .release = overlay_release, +}; You certainly should not define a new kobj_type for use in a device driver. This is an internal data structure of the linux core code. It might make sense if you were trying to become the new frame buffer layer

RE: [PATCH 01/10] MCDE: Add hardware abstraction layer

Hi, Thank you Arnd for your comments. A hardware abstraction layer is generally considered a bad thing, you're usually better off not advertising your code as being one. As a rule, the device driver *is* the hardware abstraction, so you should not add another one ;-) +static void

RE: [PATCH 01/10] MCDE: Add hardware abstraction layer

Hi Joe, Thanks for your input. See comments below. Just trivia: diff --git a/drivers/video/mcde/mcde_hw.c b/drivers/video/mcde/mcde_hw.c [] +#define dsi_rfld(__i, __reg, __fld) \ + ((dsi_rreg(__i, __reg) __reg##_##__fld##_MASK) \ + __reg##_##__fld##_SHIFT)

RE: [PATCH 00/10] MCDE: Add frame buffer device driver

framework. But we do not have drm drivers for 3D hw and this also makes drm a less obvious choice at the moment. Jimmy -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: den 10 november 2010 15:43 To: Jimmy RUBIN Cc: linux-fb...@vger.kernel.org; linux-arm-ker

[PATCH 09/10] MCDE: Add build files and bus

This patch adds support for the MCDE, Memory-to-display controller, found in the ST-Ericsson ux500 products. This patch adds the necessary build files for MCDE and the bus that all displays are connected to. Signed-off-by: Jimmy Rubin jimmy.ru...@stericsson.com Acked-by: Linus Walleij

[PATCH 03/10] MCDE: Add pixel processing registers

This patch adds support for MCDE, Memory-to-display controller found in the ST-Ericsson ux500 products. This patch adds pixel processing registers found in MCDE. Signed-off-by: Jimmy Rubin jimmy.ru...@stericsson.com Acked-by: Linus Walleij linus.walleij.stericsson.com --- drivers/video/mcde

[PATCH 04/10] MCDE: Add formatter registers

This patch adds support for MCDE, Memory-to-display controller found in the ST-Ericsson ux500 products. This patch adds the formatter registers found in MCDE. Signed-off-by: Jimmy Rubin jimmy.ru...@stericsson.com Acked-by: Linus Walleij linus.walleij.stericsson.com --- drivers/video/mcde

[PATCH 00/10] MCDE: Add frame buffer device driver

was to large to be handled by the mailing lists. Jimmy Rubin (10): MCDE: Add hardware abstraction layer MCDE: Add configuration registers MCDE: Add pixel processing registers MCDE: Add formatter registers MCDE: Add dsi link registers MCDE: Add generic display MCDE: Add display subsystem

[PATCH 06/10] MCDE: Add generic display

This patch adds support for MCDE, Memory-to-display controller found in the ST-Ericsson ux500 products. This patchs adds a generic DSI command display and a display framework that can be used to add support for new types of displays. Signed-off-by: Jimmy Rubin jimmy.ru...@stericsson.com Acked

[PATCH 08/10] MCDE: Add frame buffer device

This patch adds support for the MCDE, Memory-to-display controller, found in the ST-Ericsson ux500 products. This patch adds a frame buffer device driver that uses the DSS. Signed-off-by: Jimmy Rubin jimmy.ru...@stericsson.com Acked-by: Linus Walleij linus.walleij.stericsson.com --- drivers

[PATCH 07/10] MCDE: Add display subsystem framework

This patch adds support for the MCDE, Memory-to-display controller, found in the ST-Ericsson ux500 products. This patch adds a display subsystem framework that can be used by a frame buffer device driver to control a display and MCDE. Signed-off-by: Jimmy Rubin jimmy.ru...@stericsson.com Acked

[PATCH 10/10] ux500: MCDE: Add platform specific data

This patch adds support for the MCDE, Memory-to-display controller, found in the ST-Ericsson ux500 products. The configuration of the MCDE hardware, the MCDE framebuffer device and the display that is connected to ux500 is managed in this patch. Signed-off-by: Jimmy Rubin jimmy.ru

RFC:[PATCH 2/2] Ux500: Add support for MCDE frame buffer driver

This patch adds support for the MCDE, Memory-to-display controller, found in the ST-Ericsson Ux500 products. The configuration of the MCDE hardware, the MCDE framebuffer device and the display that is connected to Ux500 is managed in this patch. Signed-off-by: Jimmy Rubin jimmy.ru

RFC: [PATCH 0/2] Add support for MCDE frame buffer driver

and the frame buffer device is handled in this file. Jimmy Rubin (2): Video: Add support for MCDE frame buffer driver Ux500: Add support for MCDE frame buffer driver drivers/video/Kconfig |2 + drivers/video/Makefile|1 + drivers