[PATCH,v2] [media] vivi: Constify structures

2012-12-28 Thread Kirill Smelkov
On Thu, Dec 27, 2012 at 12:55:11PM +0100, Hans Verkuil wrote: On Wed December 26 2012 16:29:43 Kirill Smelkov wrote: Most of *_ops and other structures in vivi.c were already declared const but some have not. Constify and code/data will take less space: $ size drivers/media/platform

[PATCH] [media] vivi: Constify structures

2012-12-26 Thread Kirill Smelkov
/media/platform/vivi.o after: 12308 20 8 123363030 drivers/media/platform/vivi.o i.e. vivi.o is now ~500 bytes less. Signed-off-by: Kirill Smelkov k...@navytux.spb.ru --- drivers/media/platform/vivi.c | 26 +- 1 file changed, 13 insertions(+), 13

Re: [PATCH v6] [media] vivi: Teach it to tune FPS

2012-11-30 Thread Kirill Smelkov
On Mon, Nov 19, 2012 at 09:52:36AM +0400, Kirill Smelkov wrote: On Sun, Nov 18, 2012 at 07:25:38AM -0200, Mauro Carvalho Chehab wrote: Em 18-11-2012 07:24, Mauro Carvalho Chehab escreveu: Em 17-11-2012 08:45, Kirill Smelkov escreveu: On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho

Re: [PATCH v6] [media] vivi: Teach it to tune FPS

2012-11-30 Thread Kirill Smelkov
On Fri, Nov 30, 2012 at 12:10:59PM +0100, Hans Verkuil wrote: On Fri November 30 2012 12:02:14 Kirill Smelkov wrote: [...] P.S. Hans, if this is ok for you, would you please add your ack? Looks good to me! Acked-by: Hans Verkuil hans.verk...@cisco.com Thanks! -- To unsubscribe from

Re: [PATCH v6] [media] vivi: Teach it to tune FPS

2012-11-18 Thread Kirill Smelkov
On Sun, Nov 18, 2012 at 07:25:38AM -0200, Mauro Carvalho Chehab wrote: Em 18-11-2012 07:24, Mauro Carvalho Chehab escreveu: Em 17-11-2012 08:45, Kirill Smelkov escreveu: On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho Chehab wrote: Em 16-11-2012 11:38, Hans Verkuil escreveu: On Wed

Re: [PATCH v4] [media] vivi: Teach it to tune FPS

2012-11-17 Thread Kirill Smelkov
On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho Chehab wrote: Em 16-11-2012 11:38, Hans Verkuil escreveu: On Wed November 7 2012 12:30:01 Kirill Smelkov wrote: [...] diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c index 37d0af8..5d1b374 100644

Re: [PATCH v5] [media] vivi: Teach it to tune FPS

2012-11-16 Thread Kirill Smelkov
On Fri, Nov 16, 2012 at 02:38:09PM +0100, Hans Verkuil wrote: On Wed November 7 2012 12:30:01 Kirill Smelkov wrote: [...] diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c index 37d0af8..5d1b374 100644 --- a/drivers/media/platform/vivi.c +++ b/drivers/media

Re: [PATCH v5] [media] vivi: Teach it to tune FPS

2012-11-16 Thread Kirill Smelkov
On Fri, Nov 16, 2012 at 03:51:23PM +0100, Hans Verkuil wrote: On Fri November 16 2012 15:48:41 Kirill Smelkov wrote: On Fri, Nov 16, 2012 at 02:38:09PM +0100, Hans Verkuil wrote: On Wed November 7 2012 12:30:01 Kirill Smelkov wrote: [...] diff --git a/drivers/media/platform/vivi.c

Re: [PATCH v4] [media] vivi: Teach it to tune FPS

2012-11-12 Thread Kirill Smelkov
On Wed, Nov 07, 2012 at 03:30:01PM +0400, Kirill Smelkov wrote: On Fri, Nov 02, 2012 at 03:42:21PM +0100, Hans Verkuil wrote: Thanks for the ping, I forgot about this patch... Thanks for feedback and for waiting. I'm here again... On Tue October 23 2012 15:35:21 Kirill Smelkov wrote

[PATCH v4] [media] vivi: Teach it to tune FPS

2012-11-07 Thread Kirill Smelkov
On Fri, Nov 02, 2012 at 03:42:21PM +0100, Hans Verkuil wrote: Thanks for the ping, I forgot about this patch... Thanks for feedback and for waiting. I'm here again... On Tue October 23 2012 15:35:21 Kirill Smelkov wrote: On Tue, Oct 23, 2012 at 08:40:04AM +0200, Hans Verkuil wrote

[PATCH 0/4] Speedup vivi

2012-11-02 Thread Kirill Smelkov
Hello up there. I was trying to use vivi to generate multiple video streams for my test-lab environment on atom system and noticed it wastes a lot of cpu. Please apply some optimization patches. Thanks, Kirill Kirill Smelkov (4): [media] vivi: Optimize gen_text() [media] vivi: vivi_dev-line

[PATCH 1/4] [media] vivi: Optimize gen_text()

2012-11-02 Thread Kirill Smelkov
for simplifying the code. That's done because for memcpy used for conditional assignment, gcc generates suboptimal code with more indirections. Fortunately, in C struct assignment is builtin and that's all we need from pixeltype for font rendering. Signed-off-by: Kirill Smelkov k

[PATCH 2/4] [media] vivi: vivi_dev-line[] was not aligned

2012-11-02 Thread Kirill Smelkov
2.42% rawv [vivi] [k] precalculate_line 1.33% swapper [kernel.kallsyms] [k] read_hpet Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/media/platform/vivi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] [media] vivi: Move computations out of vivi_fillbuf linecopy loop

2012-11-02 Thread Kirill Smelkov
] vivi_fillbuff (i.e. vivi_fillbuff own overhead is almost gone) Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/media/platform/vivi.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c index ddcc712

[PATCH 4/4] [media] vivi: Optimize precalculate_line()

2012-11-02 Thread Kirill Smelkov
... 0.14% rawv [vivi][k] gen_twopix (i.e. gen_twopix and precalculate_line overheads are almost gone) Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/media/platform/vivi.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions

Re: [PATCH v3] [media] vivi: Teach it to tune FPS

2012-11-02 Thread Kirill Smelkov
On Tue, Oct 23, 2012 at 05:35:21PM +0400, Kirill Smelkov wrote: On Tue, Oct 23, 2012 at 08:40:04AM +0200, Hans Verkuil wrote: On Mon October 22 2012 19:01:40 Kirill Smelkov wrote: On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote: On Mon October 22 2012 15:54:44 Kirill Smelkov

Re: [PATCH 0/4] Speedup vivi

2012-11-02 Thread Kirill Smelkov
On Fri, Nov 02, 2012 at 02:48:43PM +0100, Hans Verkuil wrote: On Fri November 2 2012 14:10:29 Kirill Smelkov wrote: Hello up there. I was trying to use vivi to generate multiple video streams for my test-lab environment on atom system and noticed it wastes a lot of cpu. Please apply

Re: [PATCH v3] [media] vivi: Teach it to tune FPS

2012-11-02 Thread Kirill Smelkov
On Fri, Nov 02, 2012 at 03:42:21PM +0100, Hans Verkuil wrote: Thanks for the ping, I forgot about this patch... Thanks for the reply. Have to run now - will try to rework it in several days. Thanks again, Kirill On Tue October 23 2012 15:35:21 Kirill Smelkov wrote: On Tue, Oct 23, 2012

[PATCH v3] [media] vivi: Teach it to tune FPS

2012-10-23 Thread Kirill Smelkov
On Tue, Oct 23, 2012 at 08:40:04AM +0200, Hans Verkuil wrote: On Mon October 22 2012 19:01:40 Kirill Smelkov wrote: On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote: On Mon October 22 2012 15:54:44 Kirill Smelkov wrote: I was testing my video-over-ethernet subsystem today

[PATCH] [media] vivi: Kill TSTAMP_* macros

2012-10-23 Thread Kirill Smelkov
Usage of TSTAMP_* macros has gone in 2010 in 730947bc (V4L/DVB: vivi: clean up and a major overhaul) but the macros remain. Say goodbye to them. Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/media/platform/vivi.c | 5 - 1 file changed, 5

[PATCH 1/2] [media] vivi: Kill BUFFER_TIMEOUT macro

2012-10-22 Thread Kirill Smelkov
Usage of BUFFER_TIMEOUT has gone in 2008 in 78718e5d (V4L/DVB (7492): vivi: Simplify the vivi driver and avoid deadlocks), but the macro remains. Say goodbye to it. Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/media/platform/vivi.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 2/2] [media] vivi: Teach it to tune FPS

2012-10-22 Thread Kirill Smelkov
. Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/media/platform/vivi.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c index 3e6902a..48325f4 100644 --- a/drivers/media/platform/vivi.c +++ b

Re: [PATCH 2/2] [media] vivi: Teach it to tune FPS

2012-10-22 Thread Kirill Smelkov
On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote: On Mon October 22 2012 15:54:44 Kirill Smelkov wrote: I was testing my video-over-ethernet subsystem today, and vivi seemed to be perfect video source for testing when one don't have lots of capture boards and cameras. Only its

Re: [PATCH 2/2] [media] vivi: Teach it to tune FPS

2012-10-22 Thread Kirill Smelkov
On Mon, Oct 22, 2012 at 09:01:39PM +0400, Kirill Smelkov wrote: On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote: On Mon October 22 2012 15:54:44 Kirill Smelkov wrote: I was testing my video-over-ethernet subsystem today, and vivi seemed to be perfect video source for testing

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Kirill Smelkov
5103 netbook Author: Kirill Smelkov k...@mns.spb.ru Date:Fri Jul 22 11:47:22 2011 -0300 Thanks The camera there identifies itself as being manufactured by Cheng Uei Precision Industry Co., Ltd (Foxlink), and product is titled as HP Webcam [2 MP Fixed]. I was trying to get 2 USB video

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Kirill Smelkov
Mauro, thanks for answering, On Thu, Jul 28, 2011 at 10:45:29AM -0300, Mauro Carvalho Chehab wrote: Em 28-07-2011 08:42, Kirill Smelkov escreveu: On Wed, Jul 27, 2011 at 09:42:08PM +0200, Mauro Carvalho Chehab wrote: This is an automatic generated email to let you know that the following

Re: [git:v4l-dvb/for_v3.1] [media] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam on HP Mini 5103 netbook

2011-07-28 Thread Kirill Smelkov
On Thu, Jul 28, 2011 at 11:55:04AM -0300, Mauro Carvalho Chehab wrote: Em 28-07-2011 10:54, Kirill Smelkov escreveu: Mauro, thanks for answering, On Thu, Jul 28, 2011 at 10:45:29AM -0300, Mauro Carvalho Chehab wrote: Em 28-07-2011 08:42, Kirill Smelkov escreveu: On Wed, Jul 27, 2011

Re: [PATCH, RESEND] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam found on HP Mini 5103 netbook

2011-07-23 Thread Kirill Smelkov
Hi Laurent, All, On Sat, Jul 23, 2011 at 01:12:11AM +0200, Laurent Pinchart wrote: Hi Kirill, On Saturday 23 July 2011 00:25:20 Kirill Smelkov wrote: On Sat, Jul 23, 2011 at 12:03:57AM +0200, Laurent Pinchart wrote: On Friday 22 July 2011 16:47:22 Kirill Smelkov wrote: [ Cc'ing

[PATCH, RESEND] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam found on HP Mini 5103 netbook

2011-07-22 Thread Kirill Smelkov
bandwidth) will be entering the mainline via Greg's usb tree. 8 From: Kirill Smelkov k...@mns.spb.ru Subject: [PATCH] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam found on HP Mini 5103 netbook The camera there identifies itself as being manufactured by Cheng Uei Precision Industry Co., Ltd

Re: [PATCH, RESEND] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam found on HP Mini 5103 netbook

2011-07-22 Thread Kirill Smelkov
Hi Laurent, All, On Sat, Jul 23, 2011 at 12:03:57AM +0200, Laurent Pinchart wrote: Hi Kirill, On Friday 22 July 2011 16:47:22 Kirill Smelkov wrote: [ Cc'ing Andrew Morton -- Andrew, could you please pick this patch, in case there is no response from maintainers again? Thanks

Re: [PATCH] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam found on HP Mini 5103 netbook

2011-07-12 Thread Kirill Smelkov
On Tue, Jun 21, 2011 at 10:07:43PM +0400, Kirill Smelkov wrote: The camera there identifeis itself as being manufactured by Cheng Uei Precision Industry Co., Ltd (Foxlink), and product is titled as HP Webcam [2 MP Fixed]. I was trying to get 2 USB video capture devices to work simultaneously

[PATCH v4 0/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-07-03 Thread Kirill Smelkov
is specified by USB 2.0; Kirill Smelkov (2): USB: EHCI: Move sysfs related bits into ehci-sysfs.c USB: EHCI: Allow users to override 80% max periodic bandwidth Documentation/ABI/testing/sysfs-module | 23 Documentation/usb/ehci.txt |2 + drivers/usb/host/ehci-hcd.c

[PATCH v4 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c

2011-07-03 Thread Kirill Smelkov
Stern (in 57e06c11 EHCI: force high-speed devices to run at full speed; Jan 16 2007), that's why I'm putting Copyright (C) 2007 by Alan Stern there after explicit request from the author. Signed-off-by: Kirill Smelkov k...@mns.spb.ru Acked-by: Alan Stern st...@rowland.harvard.edu --- drivers

[PATCH v4 2/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-07-03 Thread Kirill Smelkov
into Documentation/usb/ehci.txt -- the text there seems to be outdated and much needing refreshing, before it could be amended. Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Kirill Smelkov k...@mns.spb.ru Acked-by: Alan Stern st...@rowland.harvard.edu --- Documentation/ABI/testing/sysfs-module

Re: [PATCH v3 2/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-07-02 Thread Kirill Smelkov
On Fri, Jul 01, 2011 at 02:24:27PM -0700, Greg KH wrote: On Fri, Jul 01, 2011 at 03:47:11PM +0400, Kirill Smelkov wrote: drivers/usb/host/ehci-sysfs.c | 104 +++-- As you are adding new sysfs files, it is required that you also add new entries

Re: [PATCH v2 0/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-07-01 Thread Kirill Smelkov
On Thu, Jun 30, 2011 at 11:01:01AM -0700, Sarah Sharp wrote: On Fri, Jun 24, 2011 at 08:48:06PM +0400, Kirill Smelkov wrote: Changes since v1: - dropped RFC status as this seems like the sort of feature somebody might reasonably want to use -- if they know exactly what they're

[PATCH v3 0/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-07-01 Thread Kirill Smelkov
; Kirill Smelkov (2): USB: EHCI: Move sysfs related bits into ehci-sysfs.c USB: EHCI: Allow users to override 80% max periodic bandwidth drivers/usb/host/ehci-hcd.c | 11 ++- drivers/usb/host/ehci-hub.c | 75 drivers/usb/host/ehci-sched.c | 17 ++-- drivers/usb/host

[PATCH v3 2/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-07-01 Thread Kirill Smelkov
the patch. So only those of us who need the extreme settings are taking the risk - normal users who do not alter uframe_periodic_max sysfs attribute should not see any change at all. Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/usb/host/ehci

[PATCH v3 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c

2011-07-01 Thread Kirill Smelkov
Stern (in 57e06c11 EHCI: force high-speed devices to run at full speed; Jan 16 2007), that's why I'm putting Copyright (C) 2007 by Alan Stern there after explicit request from the author. Signed-off-by: Kirill Smelkov k...@mns.spb.ru Acked-off-by: Alan Stern st...@rowland.harvard.edu

[PATCH 1/2] USB: EHCI: Move sysfs related bits into ehci-sysfs.c

2011-06-24 Thread Kirill Smelkov
The only sysfs attr implemented so far is companion from ehci-hub.c, but in the next patch we are going to add another sysfs file, so prior to that let's structure things and move already-in-there sysfs code to separate file. Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/usb/host

[PATCH v2 2/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-06-24 Thread Kirill Smelkov
per microframe), but I think that is still enough for control traffic. Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/usb/host/ehci-hcd.c |6 +++ drivers/usb/host/ehci-sched.c | 17 +++ drivers/usb/host/ehci-sysfs.c | 98 +++-- drivers

Re: [RFC, PATCH] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-06-24 Thread Kirill Smelkov
On Thu, Jun 23, 2011 at 01:14:04PM -0400, Alan Stern wrote: On Thu, 23 Jun 2011, Kirill Smelkov wrote: At 480 Mb/s, each microframe holds 7500 bytes (less if you count bit-stuffing). 4% of that is 300 bytes, which is not enough for a 512-byte bulk packet. I think you'd run

Re: [RFC, PATCH] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-06-23 Thread Kirill Smelkov
On Wed, Jun 22, 2011 at 03:22:28PM -0400, Alan Stern wrote: On Wed, 22 Jun 2011, Kirill Smelkov wrote: There are cases, when 80% max isochronous bandwidth is too limiting. For example I have two USB video capture cards which stream uncompressed video, and to stream full NTSC + PAL

Re: [RFC, PATCH] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-06-23 Thread Kirill Smelkov
On Wed, Jun 22, 2011 at 10:35:44AM -0700, matt mooney wrote: On 10:30 Wed 22 Jun , matt mooney wrote: On 20:02 Wed 22 Jun , Kirill Smelkov wrote: There are cases, when 80% max isochronous bandwidth is too limiting. For example I have two USB video capture cards which stream

[RFC, PATCH] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-06-22 Thread Kirill Smelkov
default. NOTE: for two streams with max_pkt_size=3072 (worst case) both time allocation would be 60us+60us=120us which is 96% periodic bandwidth leaving 4% for bulk and control. I think this should work too. Signed-off-by: Kirill Smelkov k...@mns.spb.ru Cc: Alan Stern st...@rowland.harvard.edu

[PATCH] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam found on HP Mini 5103 netbook

2011-06-21 Thread Kirill Smelkov
@30fps simultaneously. Hooray! Signed-off-by: Kirill Smelkov k...@mns.spb.ru --- drivers/media/video/uvc/uvc_driver.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/uvc/uvc_driver.c b/drivers/media/video/uvc/uvc_driver.c index b6eae48..f633700