Hi Sakari, Bingbu,
On 27/11/18 10:34, Sakari Ailus wrote:
> While the test pattern menu itself is not standardised, many devices
> support the same test patterns. Aligning the menu entries helps the user
> space to use the interface, and adding macros for the menu entry strings
> helps to keep
Hi Bingbu,
On 27/11/18 09:55, Bingbu Cao wrote:
>
>
> On 11/27/2018 04:05 PM, Luca Ceresoli wrote:
>> Hi Bingbu,
>>
>> On 27/11/18 05:01, bingbu@intel.com wrote:
>>> From: Bingbu Cao
>>>
>>> Some Sony camera sensors have same test
Hi Bingbu,
On 27/11/18 05:01, bingbu@intel.com wrote:
> From: Bingbu Cao
>
> Some Sony camera sensors have same test pattern
> definitions, this patch unify the pattern naming
> to make it more clear to the userspace.
>
> Suggested-by: Sakari Ailus
> Signed-off-by: Bingbu Cao
> ---
>
and output a
600x480 format. Using binning in the names avoids any
misunderstanding. For the same reason, replace the 'size' field in
struct imx274_frmfmt with 'bin_ratio'.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v5 -> v6:
- simplify last call to imx274_write_mbreg() (Sakari)
-
two advantages:
- sets all the bytes in a unique I2C transaction
- removes lots of now unused code.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v5 -> v6:
- fix warning on debug print on 32-bit machines (reported by the
kbuild test robot)
- fix line above 80 chars
Changed v
e central 1080p area (no binning):
media-ctl -V '"IMX274":0[crop:(960,540)/1920x1080]'
(this also sets the compose and fmt rects to 1920x1080)
Regards,
Luca
Luca Ceresoli (2):
media: imx274: use regmap_bulk_write to write multybyte registers
media: imx274: add cropping support via SEL
pd -> pad
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -> v4: nothing
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index e5ba19b97083..2c13961e9764
1920x1080]'
(this also sets the compose and fmt rects to 1920x1080)
Regards,
Luca
Luca Ceresoli (8):
media: imx274: initialize format before v4l2 controls
media: imx274: consolidate per-mode data in imx274_frmfmt
media: imx274: get rid of mode_index
media: imx274: actually use IMX274_DEFAULT_
entirely since it would
print the same value anyway.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -> v4: nothing
Changed v2 -> v3:
- really fix dev_dbg() format mismatch warning for both 32 and 64 bit
Changed v1 -> v2:
- add "media: " prefix to commit mes
early.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -> v4: nothing
Changed v2 -> v3: nothing
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(
IMX274_TABLE_WAIT_MS and IMX274_TABLE_END.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -> v4: nothing
Changed v2 -> v3: nothing
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 28 ++--
tion to fill
reg_8 tables in a simple and clean way.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -> v4: nothing
Changed v2 -> v3:
- minor reformatting in prepare_reg() documentation
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/
. using 2:1 binning mode to crop 1200x960 and output a 600x480
format. Using binning in the names avoids any misunderstanding. For
the same reason, replace the 'size' field in struct imx274_frmfmt with
'bin_ratio'.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -> v4:
-
74_mode_regs() that is now unused.
While this adds the mode pointer to the device struct, it does not
remove the mode_index from it because mode_index is still used in two
dev_dbg() calls. This will be handled in a follow-up commit.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -&
IMX274_DEFAULT_MODE is defined but not used. Start using it, so the
default can be more easily changed without digging into the code.
Signed-off-by: Luca Ceresoli
Cc: Sakari Ailus
---
Changed v3 -> v4: nothing
Changed v2 -> v3: nothing
Changed v1 -> v2:
- add "media: &quo
early.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Changed v2 -> v3: nothing
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 20 ++--
1 file chang
entirely since it would
print the same value anyway.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Changed v2 -> v3:
- really fix dev_dbg() format mismatch warning for both 32 and 64 bit
Changed v1 -> v2:
- add "me
a 600x480
format. Using binning in the names avoids any misunderstanding.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Changed v2 -> v3:
- Remove hard-coded HMAX reg setting from all modes, not only the
first one.
IMX274_DEFAULT_MODE is defined but not used. Start using it, so the
default can be more easily changed without digging into the code.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Changed v2 -> v3: nothing
Changed v
IMX274_TABLE_WAIT_MS and IMX274_TABLE_END.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Changed v2 -> v3: nothing
Changed v1 -> v2:
- add "media: " prefix to commit message
---
dri
80p area (no binning):
media-ctl -V '"IMX274":0[crop:(960,540)/1920x1080]'
(this also sets the fmt to 1920x1080)
Regards,
Luca
[0] https://www.spinics.net/lists/kernel/msg2787725.html
Luca Ceresoli (7):
media: imx274: initialize format before v4l2 controls
media: imx
74_mode_regs() that is now unused.
While this adds the mode pointer to the device struct, it does not
remove the mode_index from it because mode_index is still used in two
dev_dbg() calls. This will be handled in a follow-up commit.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
tion to fill
reg_8 tables in a simple and clean way.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
---
Changed v2 -> v3:
- minor reformatting in prepare_reg() documentation
Changed v1 -> v2:
- add "media: " prefix to c
a note at the beginning of the CROP API section
- update note about VIDIOC_CROPCAP
Also remove a note that is incorrect (correct wording is in
vidioc-cropcap.rst).
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Based on info from: Hans Verkuil <hverk...@xs4all.nl>
Cc: Hans Ve
These files have an automatically-generated numbering. Rename them
with a name that suggests their meaning.
Reported-by: Hans Verkuil <hverk...@xs4all.nl>
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- fix
The API limitation described here is about the CROP API, not about the
entire V4L2.
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2: nothing.
---
Documentation/media/uapi/v4l/selection-api-vs-crop-api.rst | 2 +-
1
Fix typos in the selection documentation:
- over -> cover
- BONDS -> BOUNDS
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add a commit message (Hans)
---
Documentation/media/uapi/v4l/sele
Split section "Comparison with old cropping API" in paragraphs for
easier reading and improve visible links text.
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2: nothing.
---
.../media/uapi/v4l/sele
Hi Hans,
On 13/05/2018 11:19, Hans Verkuil wrote:
> Hi Luca,
>
> My apologies for the long delay in reviewing this.
>
> It all looks very good and if you can post a v2 with these small issues
> fixed, then I'll merge it for 4.18.
On its way!
Thanks,
--
Luca
Hi Hans,
thanks for the review.
On 13/05/2018 11:12, Hans Verkuil wrote:
> On 04/03/2018 11:15 PM, Luca Ceresoli wrote:
>> Having two somewhat similar and largely overlapping APIs is confusing,
>> especially since the older one appears in the docs before the newer
>>
Hi Sakari,
thanks for your feedback, see below my replies.
On 26/04/2018 10:13, Sakari Ailus wrote:
> Hi Luca,
>
> On Tue, Apr 24, 2018 at 04:30:38PM +0200, Luca Ceresoli wrote:
>> Hi Sakari,
>>
>> On 24/04/2018 11:59, Sakari Ailus wrote:
>>> Hi Luca
es, but I suggest you only apply patches 1-6. I noticed a warning in
patch 9, and patches 7-8 are not very useful without it. Will fix it in v3.
I'll wait for the outcome of the discussion below before sending v3.
Tell me if you prefer me to do it earlier.
> On Tue, Apr 24, 2018 at 10:24:18AM +0
Most registers are defined using the name used in the datasheet.
E.g. the defines for the HMAX register are IMX274_HMAX_REG_*.
Rename the SHR and VMAX register accordingly. Also move them close to
related registers: SHR close to SVR, VMAX close to HMAX.
Signed-off-by: Luca Ceresoli &l
directly.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 25 ++---
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/drivers/media/i2c/imx274.c
ontal crop.
Regards,
Luca
Luca Ceresoli (13):
media: imx274: document reset delays more clearly
media: imx274: fix typo in comment
media: imx274: slightly simplify code
media: imx274: remove unused data from struct imx274_frmfmt
media: imx274: rename and reorder register address definitio
.
The colorspace member is also never used, which is normal since the
imx274 sensor can output only one colorspace.
Let's get rid of all of them.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/medi
74_mode_regs() that is now unused.
While this adds the mode pointer to the device struct, it does not
remove the mode_index from it because mode_index is still used in two
dev_dbg() calls. This will be handled in a follow-up commit.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
--
IMX274_TABLE_WAIT_MS and IMX274_TABLE_END.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 28 ++--
1 file changed, 10 insertions(+), 18 deletions(-)
d
misunderstanding.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 266 -
1 file changed, 192 insertions(+), 74 deletions(-)
diff --
tion to fill
reg_8 tables in a simple and clean way.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 90 --
1 file changed, 55 inse
entirely since it would
print the same value anyway.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
- fix dev_dbg() format mismatch warning
("warning: format ‘%ld’ expects argument of type ‘long int’,
IMX274_DEFAULT_MODE is defined but not used. Start using it, so the
default can be more easily changed without digging into the code.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c
early.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/imx274.c
imx274_s_frame_interval() already has a direct pointer to the v4l2
exposure control, so reuse it to simplify code.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 2 +-
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
Document the unit to avoid having to look through the code to compute it.
Also clarify that these are min and max values.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Changed v1 -> v2:
- add "media: " prefix to commit message
---
drivers/media/i2c/imx274.c | 2 +-
early.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 63fb94e7da37..8a8a11b8d75d 100644
--- a/drive
a parameter to imx274_mode_regs() that becomes unused.
While this adds the mode pointer to the device struct, it does not
remove the mode_index from it because mode_index is still used in two
dev_dbg() calls. This will be handled in a follow-up commit.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
IMX274_DEFAULT_MODE is defined but not used. Start using it, so the
default can be more easily changed without digging into the code.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
since it prints the
same value anyway.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 2ec31ae4e60d..25907d
Document the unit to avoid having to look through the code to compute it.
Also clarify that these are min and max values.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/med
IMX274_TABLE_WAIT_MS and IMX274_TABLE_END.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 28 ++--
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 39d548
tion to fill
reg_8 tables in a simple and clean way.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 90 --
1 file changed, 55 insertions(+), 35 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/
misunderstanding.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 266 -
1 file changed, 192 insertions(+), 74 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 0b3183
directly.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 25 ++---
1 file changed, 6 insertions(+), 19 deletions(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 62a0d7af0e51..63fb94e7da37 100644
--- a/d
.
Regards,
Luca
Luca Ceresoli (13):
imx274: document reset delays more clearly
imx274: fix typo in comment
imx274: slightly simplify code
imx274: remove unused data from struct imx274_frmfmt
imx274: rename and reorder register address definitions
imx274: remove non-indexed pointers from
imx274_s_frame_interval() already has a direct pointer to the v4l2
exposure control, so reuse it to simplify code.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx2
.
The colorspace member is also never used, which is normal since the
imx274 sensor can output only one colorspace.
Let's get rid of all of them.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 5e425db9204d..dfd04edcdd48 100644
--- a/drivers/media/i2c/imx274.c
+++ b/d
Most registers are defined using the name used in the datasheet.
E.g. the defines for the HMAX register are IMX274_HMAX_REG_*.
Rename the SHR and VMAX register accordingly. Also move them close to
related registers: SHR close to SVR, VMAX close to HMAX.
Signed-off-by: Luca Ceresoli &l
a note at the beginning of the CROP API section
Also remove a note that is incorrect (correct wording is in
vidioc-cropcap.rst).
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Based on info from: Hans Verkuil <hverk...@xs4all.nl>
Cc: Hans Verkuil <hverk...@xs4all.nl>
---
D
These files have an automatically-generated numbering. Replaname them
to something that suggests their meaning.
Reported-by: Hans Verkuil <hverk...@xs4all.nl>
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
.../{selection-api-00
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Documentation/media/uapi/v4l/selection-api-004.rst | 2 +-
Documentation/media/uapi/v4l/selection.svg | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documen
Split section "Comparison with old cropping API" in paragraphs for
easier reading and improve visible links text.
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
.../media/uapi/v4l/selection-api-vs-crop-api.rst | 55
The API limitation described here is about the CROP API, not about the
entire V4L2.
Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Documentation/media/uapi/v4l/selection-api-vs-crop-api.rst | 2 +-
1 file changed, 1 insertion(+)
There is a ':' i excess, resulting in an unwanted ':' in the rendered
output.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
Documentation/media/kapi/v4l2-dev.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/media/kapi/v4l2-dev.rst
b/Documen
VB2_BUF_STATE_REQUEUEING is accepted by vb2_buffer_done() but not
documented, so add it along with notes about calls in interrupt
context.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Pawel Osciak <pa...@osciak
Documentation about what start_streaming() should do on failure are
scattered in two places and mostly duplicated, so consolidate them in
one of the two places.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Pawe
Driver writers can benefit in knowing if/when callbacks are called in
interrupt context. But it is not completely obvious here, so document
it.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Pawel Osciak <pa...
Hi,
I noticed a typo in the title:
cantext -> context
I will fix in v2.
On 28/02/2018 23:24, Luca Ceresoli wrote:
> Driver writers can benefit in knowing if/when callbacks are called in
> interrupt context. But it is not completely obvious here, so document it.
>
> Signed-off-by
ioctl name.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
---
Documentation/media/uapi/v4l/func-poll.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/media/uapi/v4l/func-poll.rst
b/Docume
Driver writers can benefit in knowing if/when callbacks are called in
interrupt context. But it is not completely obvious here, so document it.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Pawel Osciak <pa...
VB2_BUF_STATE_REQUEUEING is accepted by vb2_buffer_done() but not
documented, so add it along with notes about calls in interrupt context.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Pawel Osciak <pa...@osciak
Documentation about what start_streaming() should do on failure are
scattered in two places and mostly duplicated, so consolidate them in
one of the two places.
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Pawe
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 664e8acdf2a0..daec33f4196a 100644
--- a/drivers/media/i2c/imx274.c
+++ b/d
75 matches
Mail list logo
